D22705: Deprecate KRun::runService

broulik added inline comments. INLINE COMMENTS > krun.h:238 > * @since 5.6 > */ > +#ifndef KIOWIDGETS_NO_DEPRECATED Add `@deprecated since` and what should be used instead REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22705 To: nicolasfella, dfaure Cc:

D22708: [WIP] Add a kded module infra for fuse mount services

chinmoyr created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. chinmoyr requested review of this revision. REVISION SUMMARY This module watches the install directories of kded modules and curates a list of modules having plugin

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.13 - Build # 18 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.13/18/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 24 Jul 2019 07:35:59 + Build duration: 4 min 9 sec and counting JUnit Tests

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 150 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/150/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 24 Jul 2019 08:01:06 + Build duration: 17 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 329 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/329/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 24 Jul 2019 08:11:12 + Build duration: 7 min 13 sec and counting

KDE CI: Frameworks » knewstuff » kf5-qt5 WindowsMSVCQt5.11 - Build # 102 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20WindowsMSVCQt5.11/102/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 24 Jul 2019 08:19:49 + Build duration: 4 min 13 sec and counting JUnit Tests

D22689: Replace QString::null with QString

ltoscano added a comment. I can see that several frameworks can't build anymore on build.kde.org after the change. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D22689 To: aacid, apol, nicolasfella Cc: ltoscano, nicolasfella, kde-frameworks-devel, LeGast00n,

D22670: Change Highlight to ButtonFocus

This revision was automatically updated to reflect the committed changes. Closed by commit R242:b0541ffbff28: Change Highlight to ButtonFocus (authored by ndavis). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22670?vs=62427=62457

D22698: Support passing target to ki18n_wrap_ui macro

cgiboudeaux added inline comments. INLINE COMMENTS > KF5I18nMacros.cmake.in:72 > + if(TARGET ${_sources}) > + cmake_minimum_required(VERSION 3.1) > + target_sources(${_sources} PRIVATE ${_header}) same thing as D22699 . A macro must not

D22698: Support passing target to ki18n_wrap_ui macro

daandemeyer marked an inline comment as done. daandemeyer added a comment. Removed the cmake_minimum_required call REVISION DETAIL https://phabricator.kde.org/D22698 To: daandemeyer, ilic Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 18 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/18/ Project: kf5-qt5 SUSEQt5.13 Date of build: Wed, 24 Jul 2019 08:01:09 + Build duration: 7 min 10 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 12 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/12/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 24 Jul 2019 08:01:03 + Build duration: 7 min 22 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.13 - Build # 8 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.13/8/ Project: kf5-qt5 SUSEQt5.13 Date of build: Wed, 24 Jul 2019 08:10:29 + Build duration: 7 min 40 sec and counting BUILD ARTIFACTS

D22365: KNotification macOS native support by NSNotificationCenter

broulik added inline comments. INLINE COMMENTS > Inoki wrote in notifybymacosnotificationcenter.mm:169 > KDE Connect does set icon by pixmap, any idea how should we treat these? Check for `pixmap().isNull()` and use `iconName()` then REVISION DETAIL https://phabricator.kde.org/D22365 To:

D22689: Replace QString::null with QString

aacid abandoned this revision. aacid added a comment. Fixed it manually, marking it as abandoned since i can't close any other way. Sorry, should have tested this a bit more, yesterday it was late :/ REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D22689 To:

D22144: Add kio recentlyused:/ to access KActivityStats data

ivan requested changes to this revision. ivan added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > recentlyused.cpp:140-144 > +if (agentValue.contains(QLatin1Char(','))) { > +query = query | Agent(agentValue.split(QLatin1Char(','))); > +

D22709: Support passing target to ecm_add_app_icon.

daandemeyer created this revision. daandemeyer added reviewers: alexmerry, dschmidt. daandemeyer added a project: Frameworks. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. Herald added a project: Build System. daandemeyer requested review of this revision. REVISION SUMMARY

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.13 - Build # 22 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.13/22/ Project: kf5-qt5 SUSEQt5.13 Date of build: Wed, 24 Jul 2019 07:35:58 + Build duration: 6 min 39 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » knewstuff » kf5-qt5 SUSEQt5.13 - Build # 6 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.13/6/ Project: kf5-qt5 SUSEQt5.13 Date of build: Wed, 24 Jul 2019 08:01:01 + Build duration: 4 min 18 sec and counting BUILD ARTIFACTS

D22699: Support passing target to ecm_qt_declare_logging_category

cgiboudeaux added inline comments. INLINE COMMENTS > cgiboudeaux wrote in ECMQtDeclareLoggingCategory.cmake:133 > -1 for changing the minimum CMake version in a macro. The change must be > compatible the project requirement. must be compatible **with** the project.. REPOSITORY R240 Extra

KDE CI: Frameworks » knewstuff » kf5-qt5 SUSEQt5.12 - Build # 48 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.12/48/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 24 Jul 2019 07:56:03 + Build duration: 3 min 50 sec and counting BUILD ARTIFACTS

D22698: Support passing target to ki18n_wrap_ui macro

daandemeyer updated this revision to Diff 62459. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22698?vs=62434=62459 REVISION DETAIL https://phabricator.kde.org/D22698 AFFECTED FILES cmake/KF5I18nMacros.cmake.in To: daandemeyer, ilic Cc: cgiboudeaux, kde-frameworks-devel,

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.12 - Build # 37 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.12/37/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 24 Jul 2019 08:10:26 + Build duration: 5 min 11 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 7 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/7/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 24 Jul 2019 08:10:22 + Build duration: 4 min 25 sec and counting JUnit Tests

D22653: Add view-qrcode icons

mbruchert updated this revision to Diff 62460. mbruchert added a comment. rename to view-barcode-qr as suggeste REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22653?vs=62346=62460 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22653

D22699: Support passing target to ecm_qt_declare_logging_category

cgiboudeaux added inline comments. INLINE COMMENTS > ECMQtDeclareLoggingCategory.cmake:133 > +if(TARGET ${sources_var}) > +cmake_minimum_required(VERSION 3.1) > +target_sources(${sources_var} PRIVATE ${cpp_filename}) -1 for changing the minimum CMake version in a macro. The

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 145 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/145/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 24 Jul 2019 07:35:59 + Build duration: 17 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » knewstuff » kf5-qt5 FreeBSDQt5.13 - Build # 5 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20FreeBSDQt5.13/5/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 24 Jul 2019 08:00:56 + Build duration: 1 min 11 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kdelibs4support » kf5-qt5 WindowsMSVCQt5.11 - Build # 61 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20WindowsMSVCQt5.11/61/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 24 Jul 2019 08:11:08 + Build duration: 18 min and counting JUnit Tests

D22717: Add Date term to KActivities Stats to filter on resource event date

meven created this revision. meven added reviewers: ivan, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Add a Term Date to Query to filter on ResourceEvent start column when querying

D22717: Add Date term to KActivities Stats to filter on resource event date

meven updated this revision to Diff 62473. meven added a comment. Improve sql padding REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22717?vs=62472=62473 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22717 AFFECTED FILES

D22715: Save and load page margins

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. I think this is a good idea. Instead of KSharedConfig::openConfig() one should use KTextEditor::EditorPrivate::config() otherwise this is fine for me.

D22653: Add view-barcode-qr icons

mbruchert retitled this revision from "Add view-qrcode icons" to "Add view-barcode-qr icons". REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22653 To: mbruchert, #breeze, ndavis Cc: broulik, ndavis, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham,

D22705: Deprecate KRun::runService

dfaure added a comment. Wait I'm having second thoughts about that comment :-) Let's discuss this a bit later. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22705 To: nicolasfella, dfaure Cc: broulik, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham,

D22653: Add view-barcode-qr icons

ndavis added a comment. I think I do want the 32px version to not have the blue corners so that it is visually consistent with the smaller versions. Once that is done, I will accept this, as long as there aren't any issues with the colorscheme support. REPOSITORY R266 Breeze Icons

D22653: Add view-barcode-qr icons

ngraham added a comment. In D22653#501534 , @ndavis wrote: > I think I do want the 32px version to not have the blue corners so that it is visually consistent with the smaller versions. Once that is done, I will accept this, as long as there

D22144: Add kio recentlyused:/ to access KActivityStats data

meven marked 2 inline comments as done. meven added inline comments. INLINE COMMENTS > ivan wrote in recentlyused.cpp:140-144 > Could this just be replaced with `query = query | > Agent(agentValue.split(QLatin1Char(',')));`? > > Obviously, the downside is always creating a list (usually with a

D22699: Support passing target to ecm_qt_declare_logging_category

daandemeyer added inline comments. INLINE COMMENTS > cgiboudeaux wrote in ECMQtDeclareLoggingCategory.cmake:133 > must be compatible **with** the project.. What's the alternative for extra-cmake-modules? Can I just remove the cmake_minimum_required call or do I need to update the version

D22699: Support passing target to ecm_qt_declare_logging_category

cgiboudeaux added inline comments. INLINE COMMENTS > daandemeyer wrote in ECMQtDeclareLoggingCategory.cmake:133 > I found that the CMake script of extra-cmake-modules itself specifies 2.8.12 > as the minimum so I'm assuming that's the minimum version for the modules as > well. The advantage of

D22708: [WIP] Add a kded module infra for fuse mount services

chinmoyr updated this revision to Diff 62469. chinmoyr added a comment. Added KRun changes REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22708?vs=62453=62469 BRANCH monitorprotocol REVISION DETAIL https://phabricator.kde.org/D22708 AFFECTED FILES

D22144: Add kio recentlyused:/ to access KActivityStats data

meven updated this revision to Diff 62464. meven added a comment. Use QStringLiteral only check for commas in string once to check for multiple values parameters, typo REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22144?vs=62417=62464 BRANCH

D22699: Support passing target to ecm_qt_declare_logging_category

daandemeyer added a comment. I INLINE COMMENTS > cgiboudeaux wrote in ECMQtDeclareLoggingCategory.cmake:133 > If the change cannot be made compatible with the minimum ECM version, I > suggest waiting for KF6. Personally, I don't see the harm in adding a completely backwards compatible

D22144: Add kio recentlyused:/ to access KActivityStats data

meven marked 2 inline comments as done. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22144 To: meven, ivan, #frameworks, ngraham Cc: elvisangelaccio, kde-frameworks-devel, kfm-devel, aprcela, fprice, LeGast00n, sbergeron, fbampaloukas, alexde, feverfew, meven,

D22705: Deprecate KRun::runService

nicolasfella updated this revision to Diff 62465. nicolasfella added a comment. - Add @deprecated since REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22705?vs=62446=62465 BRANCH depre2 REVISION DETAIL https://phabricator.kde.org/D22705 AFFECTED FILES

D22705: Deprecate KRun::runService

nicolasfella marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22705 To: nicolasfella, dfaure Cc: broulik, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22714: Add missing KIOWIDGETS_NO_DEPRECTAED check

nicolasfella created this revision. nicolasfella added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY It is marked as deprecated but didn't have the #ifdef check

D22715: Save and load page margins

hoffmannrobert created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. hoffmannrobert requested review of this revision. REVISION SUMMARY Adapt and reapply former fix from

D22715: Save and load page margins

hoffmannrobert updated this revision to Diff 62475. hoffmannrobert added a comment. - Use KTextEditor::EditorPrivate::config() REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22715?vs=62470=62475 BRANCH save_and_load_page_margins REVISION DETAIL

D22715: Save and load page margins

This revision was automatically updated to reflect the committed changes. Closed by commit R39:2d02e5c684e3: Save and load page margins (authored by hoffmannrobert, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22715?vs=62475=62476

D22715: Save and load page margins

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R39 KTextEditor BRANCH save_and_load_page_margins REVISION DETAIL https://phabricator.kde.org/D22715 To: hoffmannrobert, cullmann Cc: cullmann, kwrite-devel,

D22682: Compile package structure plugins into expected subdirectory

This revision was automatically updated to reflect the committed changes. Closed by commit R242:af2a7fbf69f1: Compile package structure plugins into expected subdirectory (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.13 - Build # 19 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.13/19/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 24 Jul 2019 16:11:16 + Build duration: 4 min 54 sec and counting JUnit Tests

D22720: Apply busy indicator duration change of D22646 to the QQC2 style

jbbgameich created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jbbgameich requested review of this revision. REVISION SUMMARY Match the duration (2 seconds) that was set in D22630 . REPOSITORY R242

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.13 - Build # 23 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.13/23/ Project: kf5-qt5 SUSEQt5.13 Date of build: Wed, 24 Jul 2019 16:11:16 + Build duration: 15 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 146 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/146/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 24 Jul 2019 16:11:16 + Build duration: 15 min and counting BUILD ARTIFACTS

D22720: Apply busy indicator duration change of D22646 to the QQC2 style

jbbgameich edited the summary of this revision. jbbgameich added reviewers: VDG, Plasma: Mobile. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D22720 To: jbbgameich, #vdg, #plasma:_mobile Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh,

D22723: Fix RunnerManager::queryFinished()

fvogt added a reviewer: davidedmundson. fvogt added a comment. Looks like a hack still, with two Job objects for each job... What about just merging `QObjectDecorator` into `FindMatchesJobInternal` by basically just adding a custom `done` signal and ignoring the entire "decorators which

D22698: Support passing target to ki18n_wrap_ui macro

turbov added a comment. @daandemeyer Cool stuff! :)) one more proposal is to turn it into a function to avoid pollution of the outer scope w/ inner used (**and still unset**) variables %) Using `set(${RESULT_VAR} "blah-blah" PARENT_SCOPE)` could help to do that %) REVISION DETAIL

D22720: Apply busy indicator duration change of D22646 to the QQC2 style

This revision was automatically updated to reflect the committed changes. Closed by commit R242:31cd4f8d8ee8: Apply busy indicator duration change of D22646 to the QQC2 style (authored by jbbgameich). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D22717: Add Date term to KActivities Stats to filter on resource event date

ivan requested changes to this revision. ivan added a comment. This revision now requires changes to proceed. Joining with `ResourceEvent` is a problem. At least make it not get joined if the date filter is not present. INLINE COMMENTS > QueryTest.h:53 > void

D22698: Support passing target to ki18n_wrap_ui macro

turbov added inline comments. INLINE COMMENTS > KF5I18nMacros.cmake.in:76 > + endif() > endforeach (_current_FILE) > endmacro (KI18N_WRAP_UI) Its _Modern CMake_ :) no need to use that crap anymore %) (I'm talking about matched `end*()` things %) REVISION DETAIL

D22724: [WIP] Add ECMAddQtDesignerPlugin

kossebau edited the summary of this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D22724 To: kossebau Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, bencreasy, michaelh, ngraham, bruns

D22724: [WIP] Add ECMAddQtDesignerPlugin

kossebau created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Goal is to replace KDesignerPlugin. So options & defaults are tried to be met. Only

D22720: Apply busy indicator duration change of D22646 to the QQC2 style

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. So many busy indicators! REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D22720 To: jbbgameich, #vdg, #plasma:_mobile,

D22698: Support passing target to ki18n_wrap_ui macro

daandemeyer added a comment. I want to keep the changes in KDE Frameworks focused on what's necessary to clean up Kate's CMake scripts. I'll leave the general cleanup for another revision. REVISION DETAIL https://phabricator.kde.org/D22698 To: daandemeyer, ilic Cc: turbov, cgiboudeaux,

D22723: Fix RunnerManager::queryFinished()

apol created this revision. apol added reviewers: Frameworks, fvogt. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY This actually looks like the port to the QObjectDecorator was done wrong.

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.13 - Build # 24 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.13/24/ Project: kf5-qt5 SUSEQt5.13 Date of build: Wed, 24 Jul 2019 19:13:39 + Build duration: 4 min 20 sec and counting BUILD ARTIFACTS

D22725: [WIP] Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON

kossebau created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REPOSITORY R236 KWidgetsAddons BRANCH createdesignerplugin REVISION DETAIL https://phabricator.kde.org/D22725 AFFECTED FILES

D22724: [WIP] Add ECMAddQtDesignerPlugin

kossebau added a dependent revision: D22725: [WIP] Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D22724 To: kossebau Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron,

D22725: [WIP] Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON

kossebau added a dependency: D22724: [WIP] Add ECMAddQtDesignerPlugin. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D22725 To: kossebau Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 147 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/147/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 24 Jul 2019 19:13:39 + Build duration: 9 min 15 sec and counting BUILD ARTIFACTS

D21760: Add KListOpenFiles::listProcessesWithOpenFiles

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > klistopenfilestest.cpp:45 > +eventLoop.exec(); > +QVERIFY(processInfoList.empty() == false); > +auto testProcessIterator =

Re: Qt dependency policy

El diumenge, 21 de juliol de 2019, a les 12:55:21 CEST, David Faure va escriure: > Taking into account the feedback from the SUSE packagers > (about how dropping support for Qt 5.9 LTS the very month Qt 5.12 LTS comes > out is a problem since not everyone can upgrade to Qt 5.12 LTS right away) >

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.13 - Build # 20 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.13/20/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 24 Jul 2019 19:13:39 + Build duration: 2 min 19 sec and counting JUnit Tests

D22699: Support passing target to ecm_qt_declare_logging_category

daandemeyer updated this revision to Diff 62496. daandemeyer added a comment. Update CMake minimum required version to 3.1 (for `target_sources`). CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22699?vs=62438=62496 REVISION DETAIL https://phabricator.kde.org/D22699 AFFECTED

D22730: KZip::openArchive: Remove "bad" assert

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY There's nothing the caller of this function can do to control the assert condition, so asserting is "too rude", and on

D22714: Add missing KIOWIDGETS_NO_DEPRECTAED check

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. I can't remember what's the use case for building KIO with that flag REPOSITORY R241 KIO BRANCH missingcheck REVISION DETAIL https://phabricator.kde.org/D22714 To:

D22727: allow kio-extras to build with mingw on win32 and remove unnecessary includes

vonreth accepted this revision. vonreth added a reviewer: dfaure. vonreth added a comment. This revision is now accepted and ready to land. Looks good. Why not the first time  REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL https://phabricator.kde.org/D22727 To:

D22727: allow kio-extras to build with mingw on win32 and remove unnecessary includes

brute4s99 added a comment. In D22727#501824 , @vonreth wrote: > Looks good. > Why not the first time  I was afraid of reverts  REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL https://phabricator.kde.org/D22727 To:

D11156: add autotest for zips within zips

dfaure added a comment. Herald added a subscriber: kde-frameworks-devel. @sandsmark can you add an expected list of files like other tests do? REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D11156 To: sandsmark, dfaure, #frameworks Cc: kde-frameworks-devel,

D22729: KZip::openArchive: Return false instead of asserting in broken files

aacid closed this revision. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D22729 To: aacid, apol Cc: kde-frameworks-devel, dfaure, apol, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22701: [kfileutils] Add isExecutableFile from KRun

dfaure added a comment. I started to write a KIO::OpenUrlJob, as a core-only version of KRun. I think this method actually belongs there, because it means "can be executed by KRun" (or soon OpenUrlJob). In isolation I don't think this method is useful. I looked at all users of this method

D22727: allow kio-extras to build with mingw on win32 and remove unnecessary includes

brute4s99 created this revision. brute4s99 added a reviewer: vonreth. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. brute4s99 requested review of this revision. TEST PLAN should build on windows with mingw as compiler should build on

D22729: KZip::openArchive: Return false instead of asserting in broken files

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY We can easily return false, so do that instead of asserting REPOSITORY R243 KArchive BRANCH master REVISION DETAIL

D22729: KZip::openArchive: Return false instead of asserting in broken files

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R243 KArchive BRANCH master REVISION DETAIL https://phabricator.kde.org/D22729 To: aacid, apol Cc: kde-frameworks-devel, dfaure, apol, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22732: Install plasma theme into local XDG_DATA_DIR for icon test

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY Relevant code is moved from dialognativetest into a header for

D22730: KZip::openArchive: Remove "bad" assert

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R243 KArchive BRANCH master REVISION DETAIL https://phabricator.kde.org/D22730 To: aacid, apol Cc: apol, dfaure, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22732: Install plasma theme into local XDG_DATA_DIR for icon test

This revision was automatically updated to reflect the committed changes. Closed by commit R242:08a6a4a7cd53: Install plasma theme into local XDG_DATA_DIR for icon test (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.13 - Build # 26 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.13/26/ Project: kf5-qt5 SUSEQt5.13 Date of build: Wed, 24 Jul 2019 23:19:21 + Build duration: 8 min 55 sec and counting BUILD ARTIFACTS

D22732: Install plasma theme into local XDG_DATA_DIR for icon test

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D22732 To: davidedmundson, #plasma, apol Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham,

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.13 - Build # 25 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.13/25/ Project: kf5-qt5 SUSEQt5.13 Date of build: Wed, 24 Jul 2019 22:57:34 + Build duration: 6 min 47 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.13 - Build # 21 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.13/21/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 24 Jul 2019 22:57:34 + Build duration: 5 min 2 sec and counting JUnit Tests

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.13 - Build # 22 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.13/22/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 24 Jul 2019 23:19:21 + Build duration: 3 min 14 sec and counting JUnit Tests

D22733: Delete redundant and monochrome versions of applications-internet

ngraham created this revision. ngraham added reviewers: VDG, ndavis. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY `applications-internet` is the only category icon that has monochrome versions

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 149 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/149/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 24 Jul 2019 23:19:21 + Build duration: 11 min and counting BUILD ARTIFACTS

D22730: KZip::openArchive: Remove "bad" assert

aacid closed this revision. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D22730 To: aacid, apol Cc: apol, dfaure, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 148 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/148/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 24 Jul 2019 22:57:34 + Build duration: 9 min 45 sec and counting BUILD ARTIFACTS

D22723: Fix RunnerManager::queryFinished()

apol added a comment. In D22723#501690 , @fvogt wrote: > Looks like a hack still, with two Job objects for each job... > > What about just merging `QObjectDecorator` into `FindMatchesJobInternal` by basically just adding a custom `done`

D22727: allow kio-extras to build with mingw on win32 and remove unnecessary includes

pino requested changes to this revision. pino added a comment. This revision now requires changes to proceed. other than building, please also check that it actually still works on Linux INLINE COMMENTS > kio_sftp.cpp:383 > fileType = QT_STAT_MASK - 1; > -#ifdef Q_OS_WIN > -

D22733: Delete redundant and monochrome versions of applications-internet

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. Ha! I was just about to start working on this myself. Obviously, I agree that this should be done. However, we should take note of all of the instances where `applications-internet` is

  1   2   >