D17595: Upstream Dolphin's file rename dialog

meven marked 6 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17595 To: meven, #frameworks, #dolphin, broulik, ngraham, dfaure Cc: dfaure, sitter, mitchell, emmanuelp, ltoscano, bruns, meven, dhaumann, pino, kde-frameworks-devel, LeGast00n,

D23108: Add KWindowSystem::setMainWindow(QWindow *) overload

dfaure updated this revision to Diff 63893. dfaure added a comment. Adjust documentation REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23108?vs=63597=63893 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23108 AFFECTED FILES

D17595: Upstream Dolphin's file rename dialog

meven marked 2 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17595 To: meven, #frameworks, #dolphin, broulik, ngraham, dfaure Cc: dfaure, sitter, mitchell, emmanuelp, ltoscano, bruns, meven, dhaumann, pino, kde-frameworks-devel, LeGast00n,

D17595: Upstream Dolphin's file rename dialog

meven marked an inline comment as done. meven added inline comments. INLINE COMMENTS > dfaure wrote in renamefiledialog.cpp:246 > I see you used the more complicated solution of keeping showEvent and testing > for spontaneous. Any reason? It didn't work from the constructor? After some testing

D17595: Upstream Dolphin's file rename dialog

meven updated this revision to Diff 63895. meven added a comment. Call setFocus() in dialog constructor REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17595?vs=63892=63895 BRANCH arcpatch-D17595 REVISION DETAIL https://phabricator.kde.org/D17595

D17595: Upstream Dolphin's file rename dialog

meven updated this revision to Diff 63892. meven added a comment. Fix dialog where the private class was missing the renamed files items REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17595?vs=63891=63892 BRANCH arcpatch-D17595 REVISION DETAIL

D19620: Use a searchbar similar to the one in okular

GB_2 added a comment. See https://phabricator.kde.org/D19774#inline-110882 REPOSITORY R313 KHtml BRANCH master REVISION DETAIL https://phabricator.kde.org/D19620 To: ognarb, #vdg, #frameworks, ndavis, ngraham Cc: dhaumann, GB_2, ngraham, ndavis, kde-frameworks-devel, LeGast00n,

D23188: Fix supported OS attributes for api.kde.org

vkrause added a reviewer: Frameworks. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D23188 To: vkrause, #frameworks Cc: plasma-devel, fbampaloukas, domson, dkardarakos, apol, davidedmundson, mart, hein

D23119: Fix dates being on the wrong locale when setting an application language individually

asemke added inline comments. INLINE COMMENTS > kxmlgui_unittest.cpp:1089 > QCOMPARE(QLocale::system().language(), QLocale::Russian); > +QCOMPARE(QLocale::system().monthName(1), QString::fromUtf8("января")); > does this test work? The name of the month is "январь" in russian, not

D23215: Port to non-deprecated KWindowSystem::setMainWindow overload

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R311 KWallet BRANCH master REVISION DETAIL https://phabricator.kde.org/D23215 To: dfaure, zzag, vkrause Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23217: KIO: port to non-deprecated KWindowSystem::setMainWindow

dfaure created this revision. dfaure added reviewers: vkrause, zzag. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY Cleaned up Q_WS_WIN usage along the way (dead code) TEST PLAN Builds

D23214: Add a BlockinApp util class to find process blockng access

hallas added a comment. In D23214#513408 , @meven wrote: > In D23214#513396 , @hallas wrote: > > > Hey @meven I have been working on the same thing D21760 -

D23214: Add a BlockinApp util class to find process blockng access

meven abandoned this revision. meven added a comment. In D23214#513396 , @hallas wrote: > Hey @meven I have been working on the same thing D21760 - maybe we should consolidate our efforts? The code you have

D23217: KIO: port to non-deprecated KWindowSystem::setMainWindow

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D23217 To: dfaure, vkrause, zzag Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23215: Port to non-deprecated KWindowSystem::setMainWindow overload

dfaure created this revision. dfaure added a reviewer: zzag. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY I wish there was a method like nativeWindow() which would take care of both ensuring a

D23112: Add a event Spy for GtkFileChooser recent files

meven updated this revision to Diff 63913. meven added a comment. Reduce the amount of included code and linked libraries REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23112?vs=63890=63913 BRANCH arcpatch-D23112 REVISION DETAIL

D23208: Use CMake find_dependency in CMake config file instead of find_package

daandemeyer updated this revision to Diff 63914. daandemeyer added a comment. Use `REQUIRED_QT_VERSION` to specifiy required Qt version. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23208?vs=63877=63914 REVISION DETAIL https://phabricator.kde.org/D23208 AFFECTED FILES

D23208: Use CMake find_dependency in CMake config file instead of find_package

daandemeyer marked an inline comment as done. REVISION DETAIL https://phabricator.kde.org/D23208 To: daandemeyer, #framework_syntax_highlighting, dhaumann Cc: cgiboudeaux, kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, bmortimer, domson, michaelh, genethomas, ngraham, bruns, demsking,

D23112: Add a event Spy for GtkFileChooser recent files

This revision was automatically updated to reflect the committed changes. Closed by commit R161:acbc21c15622: Add a event Spy for GtkFileChooser recent files (authored by meven). REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE

D21760: Add KListOpenFiles::listProcessesWithOpenFiles

hallas added inline comments. INLINE COMMENTS > meven wrote in klistopenfiles.cpp:39 > The qAsConst wrapping is missing it seems. Yeah, I have only done this change locally ;) REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D21760 To: hallas, davidedmundson,

D23208: Use CMake find_dependency in CMake config file instead of find_package

cgiboudeaux accepted this revision. REVISION DETAIL https://phabricator.kde.org/D23208 To: daandemeyer, #framework_syntax_highlighting, dhaumann, cgiboudeaux Cc: cgiboudeaux, kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, bmortimer, domson, michaelh, genethomas, ngraham, bruns,

D23195: SCSS: fix interpolation (#{...}) and add the Interpolation color

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Thanks, let's merge that. REPOSITORY R216 Syntax Highlighting BRANCH fix_scss_interpolation (branched from master) REVISION DETAIL https://phabricator.kde.org/D23195 To:

D23214: Add a BlockinApp util class to find process blockng access

meven created this revision. meven added reviewers: davidedmundson, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Uses lsof and kprocesslist to extract names of process blocking on the

D23214: Add a BlockinApp util class to find process blockng access

meven updated this revision to Diff 63911. meven added a comment. Add copyright REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23214?vs=63910=63911 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23214 AFFECTED FILES

D23208: Use CMake find_dependency in CMake config file instead of find_package

This revision was automatically updated to reflect the committed changes. Closed by commit R216:635cb83670f9: Use CMake find_dependency in CMake config file instead of find_package (authored by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D23112: Add a event Spy for GtkFileChooser recent files

ivan accepted this revision. This revision is now accepted and ready to land. REPOSITORY R161 KActivity Manager Service BRANCH arcpatch-D23112 REVISION DETAIL https://phabricator.kde.org/D23112 To: meven, #frameworks, ivan Cc: bruns, ngraham, broulik, plasma-devel, LeGast00n,

D23214: Add a BlockinApp util class to find process blockng access

hallas added a comment. Hey @meven I have been working on the same thing D21760 - maybe we should consolidate our efforts? The code you have written looks very similar to what I have been doing :) As you can read in the review comments for D21760

D21760: Add KListOpenFiles::listProcessesWithOpenFiles

meven added inline comments. INLINE COMMENTS > dfaure wrote in klistopenfiles.cpp:39 > Not possible, due to the removeDuplicates() line. The qAsConst wrapping is missing it seems. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D21760 To: hallas, davidedmundson,

D23203: Use CMake find_dependency instead of find_package in CMake config file template.

This revision was automatically updated to reflect the committed changes. Closed by commit R39:d55e0120fdc3: Use CMake find_dependency instead of find_package in CMake config file template. (authored by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D23195: SCSS: fix interpolation (#{...}) and add the Interpolation color

This revision was automatically updated to reflect the committed changes. Closed by commit R216:624ba8b98dbc: SCSS: fix interpolation (#{...}) and add the Interpolation color (authored by jpoelen, committed by cullmann). CHANGED PRIOR TO COMMIT

D8810: Do not look for kioslave binary in applicationDirPath on *nix (#386859)

cullmann commandeered this revision. cullmann edited reviewers, added: kkofler; removed: cullmann. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8810 To: cullmann, #frameworks, kfunk, kkofler Cc: kde-frameworks-devel, dfaure, ngraham, broulik, kfunk, LeGast00n, michaelh,

D23112: Add a event Spy for GtkFileChooser recent files

meven updated this revision to Diff 63890. meven added a comment. Ensure the log category is exported, compare only chars, variable naming fix REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23112?vs=63830=63890 BRANCH arcpatch-D23112

D23208: Use CMake find_dependency in CMake config file instead of find_package

dhaumann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23208 To: daandemeyer, #framework_syntax_highlighting, dhaumann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, gennad,

D23203: Use CMake find_dependency instead of find_package in CMake config file template.

dhaumann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23203 To: daandemeyer, #ktexteditor, dhaumann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, szutmael, domson, michaelh, ngraham,

D23208: Use CMake find_dependency in CMake config file instead of find_package

cgiboudeaux added inline comments. INLINE COMMENTS > KF5SyntaxHighlightingConfig.cmake.in:4-5 > +include(CMakeFindDependencyMacro) > +find_dependency(Qt5Core @Qt5Core_VERSION_MAJOR@.@Qt5Core_VERSION_MINOR@) > +find_dependency(Qt5Gui @Qt5Core_VERSION_MAJOR@.@Qt5Core_VERSION_MINOR@) > Please

D23112: Add a event Spy for GtkFileChooser recent files

meven marked 3 inline comments as done. REPOSITORY R161 KActivity Manager Service REVISION DETAIL https://phabricator.kde.org/D23112 To: meven, #frameworks, ivan Cc: bruns, ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot,

D19620: Use a searchbar similar to the one in okular

dhaumann added a comment. In D19620#512883 , @GB_2 wrote: > Don't use the unicode ellipsis. We use three dots everywhere. Interesting. @ngraham didn't you suggest to use the ellipsis recently? REPOSITORY R313 KHtml BRANCH master

D17595: Upstream Dolphin's file rename dialog

meven updated this revision to Diff 63891. meven added a comment. Emit error correctly use name() function of KFileItem REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17595?vs=63854=63891 BRANCH arcpatch-D17595 REVISION DETAIL

D23224: Fix capitalization of Nextcloud

z3ntu created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. z3ntu requested review of this revision. REVISION SUMMARY Nextcloud is not written like NextCloud TEST PLAN There is no more instance of 'NextCloud' in the codebase. REPOSITORY

D23224: Fix capitalization of Nextcloud

romangg added a comment. This means only change it in lines without `[..]`. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D23224 To: z3ntu Cc: romangg, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23224: Fix capitalization of Nextcloud

z3ntu updated this revision to Diff 63935. z3ntu added a comment. Don't change the translated strings REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23224?vs=63934=63935 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23224

D23224: Fix capitalization of Nextcloud

z3ntu added a comment. I'm guessing the changed English strings will trigger a "untranslated string" warning in the translation software, so the translators should notice it, right? REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D23224 To: z3ntu Cc:

D23112: Add a event Spy for GtkFileChooser recent files

meven edited the summary of this revision. REPOSITORY R161 KActivity Manager Service REVISION DETAIL https://phabricator.kde.org/D23112 To: meven, #frameworks, ivan Cc: bruns, ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel,

D8810: Do not look for kioslave binary in applicationDirPath on *nix (#386859)

cullmann updated this revision to Diff 63931. cullmann added a comment. Instead of changing the search paths, alter the kioslave binary name to "kioslave5" to avoid clashs with old variants. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8810?vs=22338=63931

D8810: Do not look for kioslave binary in applicationDirPath on *nix (#386859)

cullmann added a reviewer: dfaure. cullmann added a comment. Could somebody try this? Unfortunately, neither with or without this patch I can get all kio unit tests running here properly :( REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8810 To: cullmann,

D23112: Add a event Spy for GtkFileChooser recent files

meven edited the summary of this revision. REPOSITORY R161 KActivity Manager Service REVISION DETAIL https://phabricator.kde.org/D23112 To: meven, #frameworks, ivan Cc: bruns, ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel,

D23224: Fix capitalization of Nextcloud

pino added a comment. Please do **not** change the translations manually -- there is an automatic system that takes care of extracting the English strings, and merging back the translators for desktop/json/xml/alike files. If the English text is correct but a translation is not: please

D23224: Fix capitalization of Nextcloud

pino added a comment. In D23224#513556 , @z3ntu wrote: > I'm guessing the changed English strings will trigger a "untranslated string" warning in the translation software, so the translators should notice it, right? Yes. REPOSITORY

D7446: [Places panel] Revamp the Recently Saved section

meven edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: meven, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks, ngraham Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, spoorun,

D7446: [Places panel] Revamp the Recently Saved section

meven edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: meven, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks, ngraham Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, spoorun,

D23205: [KProcessList] Optimize KProcessList::processInfo

apol added a comment. patch looks good overall. INLINE COMMENTS > kprocesslist_unix.cpp:157 > const QStringList procIds = procDir.entryList(); > if (procIds.isEmpty()) > return rc; checking if it's empty is unnecessary. > kprocesslist_unix.cpp:171 > +KProcessInfo

D23188: Fix supported OS attributes for api.kde.org

apol added inline comments. INLINE COMMENTS > metainfo.yaml:12 > - name: Windows > -- name: macOS (maintainer needed) > +- name: MacOSX > + note: maintainer needed Isn't it called macOS nowadays? Or is it a keyword we have that we'd need to change elsewhere? REPOSITORY

D23224: Fix capitalization of Nextcloud

apol added a comment. Do you have commit rights or you need us to land it for you? REPOSITORY R495 Purpose Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D23224 To: z3ntu, nicolasfella, apol Cc: romangg, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham,

D23224: Fix capitalization of Nextcloud

apol accepted this revision. REPOSITORY R495 Purpose Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D23224 To: z3ntu, nicolasfella, apol Cc: romangg, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 14 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/14/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 18 Aug 2019 00:42:14 + Build duration: 2 min 34 sec and counting JUnit Tests Name:

D23224: Fix capitalization of Nextcloud

nicolasfella accepted this revision. This revision is now accepted and ready to land. REPOSITORY R495 Purpose Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D23224 To: z3ntu, nicolasfella Cc: romangg, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23225: Allow 0 in line ranges in vim mode.

verner created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. verner requested review of this revision. REVISION SUMMARY Vim numbers lines starting from 1. However, in command ranges such as, e.g., 0,$s/foo/bar/g it

D23225: Allow 0 in line ranges in vim mode.

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Seems reasonable, thanks for taking care ;=) I you use the vi mode, we have more open vi mode bugs that need some love:

D23225: Allow 0 in line ranges in vim mode.

This revision was automatically updated to reflect the committed changes. Closed by commit R39:622bd6c94803: Allow 0 in line ranges in vim mode. (authored by verner, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.12 - Build # 149 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/149/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 17 Aug 2019 19:56:43 + Build duration: 6 min 40 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 21 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/21/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 17 Aug 2019 19:56:43 + Build duration: 7 min 53 sec and counting JUnit Tests Name:

D23229: KF5DocToolsMacros.cmake: Use non-deprecated KDEInstallDirs variables

asturmlechner added a reviewer: Frameworks. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D23229 To: asturmlechner, #frameworks Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, fbampaloukas, michaelh, ngraham, bruns, skadinna

D23229: KF5DocToolsMacros.cmake: Use non-deprecated KDEInstallDirs variables

asturmlechner updated this revision to Diff 63954. asturmlechner added a comment. Use deprecated variables as fallback if defined REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23229?vs=63952=63954 BRANCH kdeinstalldirs REVISION DETAIL

D23225: Allow 0 in line ranges in vim mode.

cullmann added a comment. Jonathan, could you take a look? Thanks. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23225 To: verner, cullmann Cc: dfaure, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann, sars,

D23225: Allow 0 in line ranges in vim mode.

verner added a reviewer: cullmann. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23225 To: verner, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.13 - Build # 25 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.13/25/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 17 Aug 2019 19:56:43 + Build duration: 15 min and counting BUILD ARTIFACTS

D23225: Allow 0 in line ranges in vim mode.

dfaure added a comment. The unittest doesn't seem to pass on CI: https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/149/testReport/junit/projectroot.autotests.src/vimode/vimode_emulatedcommandbar/ FAIL! : EmulatedCommandBarTest::EmulatedCommandBarTests()

D23229: KF5DocToolsMacros.cmake: Use non-deprecated KDEInstallDirs variables

asturmlechner created this revision. Herald added projects: Frameworks, Documentation. Herald added subscribers: kde-doc-english, kde-frameworks-devel. asturmlechner requested review of this revision. REVISION SUMMARY HTML_INSTALL_DIR -> KDE_INSTALL_DOCBUNDLEDIR MAN_INSTALL_DIR ->

D23229: KF5DocToolsMacros.cmake: Use non-deprecated KDEInstallDirs variables

ltoscano added a comment. I can't check now, but I think the case were "the deprecated variable is set, but the new one is not, then the old one is used" should be considered. INLINE COMMENTS > KF5DocToolsMacros.cmake:236 > +if (NOT KDE_INSTALL_MANDIR) > +set(KDE_INSTALL_MANDIR

D23225: Allow 0 in line ranges in vim mode.

cullmann reopened this revision. This revision is now accepted and ready to land. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23225 To: verner, cullmann Cc: dfaure, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, bruns, demsking,

D22144: Add kio recentlyused:/ to access KActivityStats data

ngraham added a comment. @ivan? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22144 To: meven, ivan, #frameworks, ngraham Cc: elvisangelaccio, kde-frameworks-devel, kfm-devel, aprcela, vmarinescu, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, Codezela,

D22727: allow kio-extras to build with mingw on win32 and remove unnecessary includes

sredman added a comment. In D22727#510698 , @brute4s99 wrote: > In D22727#505540 , @dfaure wrote: > > > But, wait, this code is mixing "int permissions" (*) with the QFileDevice enum, that doesn't

D23196: have the app icon as fallback icon in Snore

sredman accepted this revision. sredman added a comment. This revision is now accepted and ready to land. Since KNotifications on Windows is so far only used by you anyway, I say it's fine to merge. @broulik, any objections? INLINE COMMENTS > notifybysnore.cpp:157 > +