D22143: Add proper logging using ECMQtDeclareLoggingCategory

meven updated this revision to Diff 64789. meven added a comment. Fix plural REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22143?vs=64787&id=64789 BRANCH arcpatch-D22143 REVISION DETAIL https://phabricator.kde.org/D22143 AFFECTED FILE

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 40 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/40/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 28 Aug 2019 06:49:04 + Build duration: 8 min 23 sec and counting JUnit Tests Name: projectroo

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 22 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/22/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 28 Aug 2019 06:26:20 + Build duration: 1 min 31 sec and counting JUnit Tests Name: proje

D22143: Add proper logging using ECMQtDeclareLoggingCategory

ivan added inline comments. INLINE COMMENTS > kactivities-stats.categories:1 > +org.kde.kactivities.stats KActivities Stats DEFAULT_SEVERITY [WARNING] > IDENTIFIER [KACTIVITY_STAT_LOG] Missed one here > CMakeLists.txt:21 > +HEADER kactivities-stats-logsettings.h

D23513: Gettext: Add "Translated String" style and spellChecking attribute

dhaumann closed this revision. dhaumann added a comment. Sorry accidentally reopened. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23513 To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n,

D23513: Gettext: Add "Translated String" style and spellChecking attribute

dhaumann reopened this revision. dhaumann added a comment. This revision is now accepted and ready to land. Lgtm. There are many dsStrings now, which could be distinguished by the default styles for strings in a later patch (dsVerbatim, ...): https://kate-editor.org/2014/03/07/kate-par

D23516: Fix for all themes: allow turn off attributes in XML highlighting files

dhaumann added a comment. I like it, although this all will not be needed anymore oncee KTextEditor is fully ported to KSyntaxHighlighting::Theme. Still a long way to go. +1 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23516 To: nibags, #ktexteditor, cull

D23515: Format class: add functions to know if XML files set style attributes

dhaumann added a comment. I am thinking about whether ` overwritesBold()` , ... is better than `definitionHasBold()`. Because the `Format` matches an `itemData` in xml. Or even `boldHardcoded()`. Any thoughts? PS: Another solution is to port all xml files to not use hard coded color

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 69 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/69/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 28 Aug 2019 05:49:19 + Build duration: 10 min and counting BUILD ARTIFACTS abi-compatibility

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.13 - Build # 22 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.13/22/ Project: kf5-qt5 SUSEQt5.13 Date of build: Wed, 28 Aug 2019 05:49:19 + Build duration: 9 min 15 sec and counting BUILD ARTIFACTS abi-compati

D22143: Add proper logging using ECMQtDeclareLoggingCategory

meven updated this revision to Diff 64787. meven added a comment. Rebase on master REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22143?vs=64784&id=64787 BRANCH arcpatch-D22143 REVISION DETAIL https://phabricator.kde.org/D22143 AFFECTE

D23500: Support for native Matlab strings

dhaumann added a comment. If you use kateversion="5.0" then you can use the new text styles we introduced with KDE 5: https://kate-editor.org/2014/03/07/kate-part-kf5-new-default-styles-for-better-color-schemes/ This allows to remove many of the hardcoded colors so that the highlighti

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 20 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/20/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 28 Aug 2019 05:49:19 + Build duration: 1 min 46 sec and counting JUnit Tests Name: pr

D23497: Keep 'lib' as default libdir on Arch Linux based systems

This revision was automatically updated to reflect the committed changes. Closed by commit R240:c806bd48a29f: Keep 'lib' as default LIBDIR on Arch Linux based systems (authored by arojas). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23497?vs=647

D22144: Add kio recentlyused:/ to access KActivityStats data

meven added a comment. @dfaure A missing piece for this kio slave is to be able to filter to the current app, meaning the app using the slave. I am not sure there is a way to achieve this yet, please correct me if I am wrong, I've looked around but I could have missed something. REPOSITORY

D22144: Add kio recentlyused:/ to access KActivityStats data

meven marked 7 inline comments as done. meven added inline comments. INLINE COMMENTS > dfaure wrote in recentlyused.cpp:91 > I'm confused. Which code from ForwardingSlaveBase is this class benefiting > from? > With internalRewriteUrl returning false all SlaveBase reimplementations in > that cla

D22144: Add kio recentlyused:/ to access KActivityStats data

meven marked 2 inline comments as done. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22144 To: meven, ivan, #frameworks, ngraham, dfaure Cc: dhaumann, elvisangelaccio, kde-frameworks-devel, kfm-devel, aprcela, vmarinescu, fprice, LeGast00n, MrPepe, fbampaloukas, a

D22143: Add proper logging using ECMQtDeclareLoggingCategory

meven updated this revision to Diff 64784. meven added a comment. kactivities-stat-logsettings.h -> kactivities-stats-logsettings.h, KACTIVITY_STAT_LOG -> KACTIVITIE_STATS_LOG REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22143?vs=62695&id=

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 39 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/39/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 28 Aug 2019 03:10:54 + Build duration: 15 min and counting JUnit Tests Name: projectroot Fail

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 104 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/104/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 28 Aug 2019 03:11:39 + Build duration: 8 min 57 sec and counting BUILD ARTIFACTS acc/KF5Purpos

D23512: Avoid overloading KCModule::changed

apol added a comment. +1 INLINE COMMENTS > kcmodule.h:382 > */ > void changed(); > Use KCONFIGWIDGETS_DEPRECATED? REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D23512 To: davidedmundson Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh

D23513: Gettext: Add "Translated String" style and spellChecking attribute

This revision was automatically updated to reflect the committed changes. Closed by commit R216:0f150cafac4b: Gettext: Add "Translated String" style and spellChecking attribute (authored by jpoelen). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23513?vs=64782&id=64783#toc REPOSITORY

D23497: Keep 'lib' as default libdir on Arch Linux based systems

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D23497 To: arojas, apol Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D23513: Gettext: Add "Translated String" style and spellChecking attribute

jpoelen updated this revision to Diff 64782. jpoelen added a comment. - increase version REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23513?vs=64775&id=64782 BRANCH po_spellcheck (branched from master) REVISION DETAIL https://phabricator

D23515: Format class: add functions to know if XML files set style attributes

nibags added a dependent revision: D23516: Fix for all themes: allow turn off attributes in XML highlighting files. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23515 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann, vkrause Cc: kwrite-devel

D23516: Fix for all themes: allow turn off attributes in XML highlighting files

nibags created this revision. nibags added reviewers: KTextEditor, cullmann, vkrause, dhaumann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY Depends on D23515

D23515: Format class: add functions to know if XML files set style attributes

nibags created this revision. nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann, vkrause. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY The functions isBo

D23145: [Exe Thumbnailer] Match 16 bit executables and don't request icon types wrestool cannot handle

broulik updated this revision to Diff 64777. broulik added a comment. - Minimize unrelated changes... REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23145?vs=63697&id=64777 REVISION DETAIL https://phabricator.kde.org/D23145 AFFECTED FILES thumbnail

D23513: Gettext: Add "Translated String" style and spellChecking attribute

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Nice! Please inc version and push. REPOSITORY R216 Syntax Highlighting BRANCH po_spellcheck (branched from master) REVISION DETAIL https://phabricator.kde.org/D23513 To: jpoelen

D23513: Gettext: Add "Translated String" style and spellChecking attribute

jpoelen edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23513 To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, dems

D23513: Gettext: Add "Translated String" style and spellChecking attribute

jpoelen edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23513 To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, dems

D23513: Gettext: Add "Translated String" style and spellChecking attribute

jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY New style ("Translated String") for a string associated with msgstr and msgstr_plural

D23512: Avoid overloading KCModule::changed

davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY KCModule contains a signal and a protected slot with the same name. With the new connect syntax this bec

D22143: Add proper logging using ECMQtDeclareLoggingCategory

ivan requested changes to this revision. ivan added a comment. This revision now requires changes to proceed. Change everything to plural. I agree with @kossebau, though I don't think it will lead to problems in future, so I could say it is bearable dirtyness. INLINE COMMENTS > CMakeLis

D22143: Add proper logging using ECMQtDeclareLoggingCategory

meven added a comment. @kossebau what about my last changes ? @ivan I feel this is ok to have `${CMAKE_BINARY_DIR}/src/kactivities-stat-logsettings.cpp` in the test CMakeLists.txt file with the documentation associated with ECMQtDeclareLoggingCategory and my comment, no-one can miss whe

D23498: Highlighting of keywords, variables and operators as such for Matlab source files

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. Change looks ok modulo missing version update, for more input please take a look at the reply in D23500 Support for native Matlab strings

D23484: gcc naming conflict

This revision was automatically updated to reflect the committed changes. Closed by commit R216:3ff7f78ebcb7: gcc naming conflict (authored by mickaelbo, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23484?vs=64727&id=64757

D23472: Mimic QInputControl::isAcceptableInput() when filtering typed characters

This revision was automatically updated to reflect the committed changes. Closed by commit R39:0bf552243404: Mimic QInputControl::isAcceptableInput() when filtering typed characters (authored by ahmadsamir, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://

D23472: Mimic QInputControl::isAcceptableInput() when filtering typed characters

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Actually, I can take care of the changes after applying this, is already a good start, thanks! REPOSITORY R39 KTextEditor BRANCH ahmad/soft-hyphen (branched from master) REVISION

D23500: Support for native Matlab strings

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. Hi, I think it is very nice that you pickup the matlab file! Three things I would like to have changed: 1. please move the example from the comment in the XML to auto

D23483: Fix section hierachy in distributing.md

This revision was automatically updated to reflect the committed changes. Closed by commit R293:33e042970075: Fix section hierachy in distributing.md (authored by arojas). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23483?vs=64721&id=64754 REVISION DETAIL

D23500: Support for native Matlab strings

bbuch added a reviewer: cullmann. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23500 To: bbuch, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D23500: Support for native Matlab strings

bbuch created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. bbuch requested review of this revision. REVISION SUMMARY As of Matlab 2016b, a separate string data type and literal was introduced in Matlab. https://de.ma

D23483: Fix section hierachy in distributing.md

kossebau accepted this revision. kossebau added a comment. This revision is now accepted and ready to land. Seems to me more a bug of doxygen. Is it not allowed to put level-3 titles below level-1 titles? At least as long as one does not do numbering, there should not be a problem, in with

D23207: Fixing implementation of FileJob interface in smb/sftp slaves

sitter added a comment. SlaveBase (which the slaves derive from) runs a command loop, out of this command loop come the actual calls to the API functions. So, in said command loop we can verify which state the slave is in before and more importantly after any API call. Specifically about the

D23498: Highlighting of keywords, variables and operators as such for Matlab source files

bbuch added a reviewer: cullmann. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23498 To: bbuch, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D23498: Highlighting of keywords, variables and operators as such for Matlab source files

bbuch created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. bbuch requested review of this revision. REVISION SUMMARY Currently, Matlab source files display keywords, variables, and operators as normal text. So they don't

D23490: [KUrlNavigator] Add MIME types supported by krarc to isCompressedPath

ngraham edited the summary of this revision. ngraham edited reviewers, added: Frameworks, cfeck, pino, dfaure; removed: kde-frameworks-devel. Herald added a subscriber: kde-frameworks-devel. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23490 To: nhiga, #frameworks, cfeck

D23207: Fixing implementation of FileJob interface in smb/sftp slaves

feverfew added a comment. In D23207#520233 , @sitter wrote: > Not knowing the background here at a glance I would argue that SlaveBase in KIO should be getting state verification on all of this,. Sorry, I'm not sure what you mean by "stat

D23497: Keep 'lib' as default libdir on Arch Linux based systems

arojas created this revision. arojas added a reviewer: apol. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Port of upstream commit https://gitlab.kitware.com/cmake/cmak

D23207: Fixing implementation of FileJob interface in smb/sftp slaves

sitter added a comment. Not knowing the background here at a glance I would argue that SlaveBase in KIO should be getting state verification on all of this,. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D23207 To: feverfew, chinmoyr, fvogt, sitter, dfaure Cc: k

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 38 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/38/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 27 Aug 2019 14:55:04 + Build duration: 8 min 22 sec and counting JUnit Tests Name: projectroo

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir edited the summary of this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D21721 To: leinir, #knewstuff, #vdg, #frameworks Cc: anthonyfieroni, pino, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23344: assert slave command finality

sitter updated this revision to Diff 64744. sitter added a comment. - wrap in custom assert defines that either assert or qwarn based on a cmake option - new cmake option KIO_ASSERT_SLAVE_STATES enables the asserts. the option is only on by default when run on jenkins - fix a bunch of typ

D23493: [server] Cache current mode

romangg added a dependent revision: D23495: Get output pixel size from output device. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D23493 To: romangg, #kwin Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23103: Add decibel power units (dBW and multiples)

This revision was automatically updated to reflect the committed changes. Closed by commit R292:edca5ae10796: Add decibel power units (dBW and multiples) (authored by iasensio, committed by ngraham). REPOSITORY R292 KUnitConversion CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23103

D23103: Add decibel power units (dBW and multiples)

broulik accepted this revision. REPOSITORY R292 KUnitConversion BRANCH log_power_units REVISION DETAIL https://phabricator.kde.org/D23103 To: iasensio, broulik, ngraham Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23103: Add decibel power units (dBW and multiples)

iasensio added a comment. Friendly ping REPOSITORY R292 KUnitConversion BRANCH log_power_units REVISION DETAIL https://phabricator.kde.org/D23103 To: iasensio, broulik, ngraham Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23493: [server] Cache current mode

romangg added a task: T11459: AbstractWaylandOutput and output device consolidation. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D23493 To: romangg, #kwin Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23493: [server] Cache current mode

romangg created this revision. romangg added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. romangg requested review of this revision. REVISION SUMMARY Instead of looping over all modes for retrieving current mode data copy it to a separa

D23490: [KUrlNavigator] Add MIME types supported by krarc to isCompressedPath

nhiga added a comment. This patch may be related to Bug 411330 . REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23490 To: nhiga, kde-frameworks-devel Cc: LeGast00n, GB_2, michaelh, ngraham, bruns

D23490: [KUrlNavigator] Add MIME types supported by krarc to isCompressedPath

nhiga created this revision. nhiga added a reviewer: kde-frameworks-devel. nhiga added a project: Frameworks. nhiga requested review of this revision. REVISION SUMMARY With D23476 , this patch should let users who have Krusader installed to view files inside

D22144: Add kio recentlyused:/ to access KActivityStats data

meven edited the test plan for this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22144 To: meven, ivan, #frameworks, ngraham, dfaure Cc: dhaumann, elvisangelaccio, kde-frameworks-devel, kfm-devel, aprcela, vmarinescu, fprice, LeGast00n, MrPepe, fbampalou

D22144: Add kio recentlyused:/ to access KActivityStats data

meven updated this revision to Diff 64736. meven added a comment. Inherit from SlaveBase instead of ForwardingSlaveBase, rename url parameter to path parameter REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22144?vs=64504&id=64736 BRANCH arcpatch-D22

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir edited the summary of this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D21721 To: leinir, #knewstuff, #vdg, #frameworks Cc: anthonyfieroni, pino, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir edited the summary of this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D21721 To: leinir, #knewstuff, #vdg, #frameworks Cc: anthonyfieroni, pino, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir retitled this revision from "[WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)" to "Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)". leinir edited the summary of this revision. leinir edited the test plan for this revision. leinir added reviewers: KNewStu

D23484: gcc naming conflict

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. ok, thanks REVISION DETAIL https://phabricator.kde.org/D23484 To: mickaelbo, #framework_syntax_highlighting, cullmann Cc: jriddell, cullmann, kde-frameworks-devel, kwrite-devel, LeGas

D23484: gcc naming conflict

mickaelbo updated this revision to Diff 64727. mickaelbo added a comment. It makes sense. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23484?vs=64719&id=64727 REVISION DETAIL https://phabricator.kde.org/D23484 AFFECTED FILES src/indexer/katehighlightingindexer.cpp To: mickae

D23484: gcc naming conflict

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. I would prefer that we just rename the vars. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23484 To: mickaelbo, #framework_syntax_highl

D23484: gcc naming conflict

mickaelbo created this revision. mickaelbo added a reviewer: Framework: Syntax Highlighting. Herald added projects: Kate, Frameworks. Herald added a subscriber: kde-frameworks-devel. mickaelbo requested review of this revision. REVISION SUMMARY With gcc 7.4.0 (and maybe some other versions), "m

D23483: Fix section hierachy in distributing.md

arojas created this revision. arojas added reviewers: bruns, kossebau. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Fixes QCH build with doxygen 1.8.16, which seems to be more strict wh

D23420: Use solid to check if a KFileItem is located on a network mount

broulik added a comment. > isSlow() didn't check linkDest before. Even more reason to do it properly now :P `KFileSystemType` uses `statfs`. I didn't find any documentation on whether it follows symlinks, but it is documented to return an `ELOOP` error code "Too many symbolic links

D23420: Use solid to check if a KFileItem is located on a network mount

meven marked an inline comment as done. meven added a comment. In D23420#519949 , @broulik wrote: > Now we still need the `linkDest` check :) isSlow() didn't check linkDest before. REPOSITORY R241 KIO BRANCH arcpatch-D23420 REVISION

D23420: Use solid to check if a KFileItem is located on a network mount

meven updated this revision to Diff 64716. meven added a comment. Add a const& clean unused variable REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23420?vs=64715&id=64716 BRANCH arcpatch-D23420 REVISION DETAIL https://phabricator.kde.org/D23420 AFFECTED

D23420: Use solid to check if a KFileItem is located on a network mount

anthonyfieroni added inline comments. INLINE COMMENTS > anthonyfieroni wrote in kfileitem.cpp:764 > Get it as `const Solid::StorageAccess`, you can use `auto storageAccess = ...` Let clarify what David mean for (const Solid::Device& device : devices) { auto storageAccess = device.as();

D23420: Use solid to check if a KFileItem is located on a network mount

broulik added a comment. Now we still need the `linkDest` check :) REPOSITORY R241 KIO BRANCH arcpatch-D23420 REVISION DETAIL https://phabricator.kde.org/D23420 To: meven, dfaure, #frameworks Cc: broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23420: Use solid to check if a KFileItem is located on a network mount

meven updated this revision to Diff 64715. meven added a comment. better check file path REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23420?vs=64645&id=64715 BRANCH arcpatch-D23420 REVISION DETAIL https://phabricator.kde.org/D23420 AFFECTED FILES src

D23420: Use solid to check if a KFileItem is located on a network mount

meven marked an inline comment as done. REPOSITORY R241 KIO BRANCH arcpatch-D23420 REVISION DETAIL https://phabricator.kde.org/D23420 To: meven, dfaure, #frameworks Cc: broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns