D24239: make editMode a corona global property

GB_2 added a comment. Thanks! REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24239 To: mart, #plasma, #vdg Cc: GB_2, broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D24239: make editMode a corona global property

mart added inline comments. INLINE COMMENTS > broulik wrote in containmentinterface.cpp:416 > I think you should check for `SystemImmutable` here (KIOSK) m_containment->corona()->setEditMode(edit) will fail if the immutability isn't mutable. so both systemimmutable and userimmutable

D23667: Add == and != operators to KIO::UDSEntry

This revision was automatically updated to reflect the committed changes. Closed by commit R241:f893784ea4f1: Add == and != operators to KIO::UDSEntry (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23667?vs=66086=66883 REVISION DETAIL

D24239: make editMode a corona global property

mart created this revision. mart added reviewers: Plasma, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY The plans are to switch on/off the whole plasma shell into edit mode. For this it needs

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 66876. leinir added a comment. Ping @Frameworks - new cycle, chunky thing, be good to get it in early :) - Since 5.63 now that 5.62 is out the door REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE

D24239: make editMode a corona global property

broulik added inline comments. INLINE COMMENTS > containmentinterface.cpp:416 > - > -if (m_containment->immutability() != Plasma::Types::Mutable) { > -return; I think you should check for `SystemImmutable` here (KIOSK) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D24239: make editMode a corona global property

broulik added inline comments. INLINE COMMENTS > broulik wrote in containmentinterface.cpp:416 > I think you should check for `SystemImmutable` here (KIOSK) Nevermind, it just moved :) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24239 To: mart,

D24220: [src/ioslaves/*] replace deprecated foreach with range for

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > http.cpp:2612 > qCDebug(KIO_HTTP) << " Sending Header:"; > -Q_FOREACH (const QString , header.split(QStringLiteral("\r\n"), >

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 99 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/99/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 26 Sep 2019 10:07:20 + Build duration: 19 min and counting CONSOLE OUTPUT Started by an SCM

D24239: make editMode a corona global property

GB_2 added a dependent revision: D24246: Only show panel toolbox when desktop toolbox is open. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24239 To: mart, #plasma, #vdg Cc: ngraham, GB_2, broulik, kde-frameworks-devel, LeGast00n, michaelh, bruns

D24220: [src/ioslaves/*] replace deprecated foreach with range for

ahmadsamir updated this revision to Diff 66895. ahmadsamir added a comment. Use const local var for implicilty shared qstringlist's to prevent detaching REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24220?vs=66815=66895 BRANCH ahmad/foreach-ioslaves2

D24185: Add format-text-underline-squiggle actions icons

This revision was automatically updated to reflect the committed changes. Closed by commit R266:477729808ef6: Add format-text-underline-squiggle actions icons (authored by Rafael Brandmaier rafael.brandma...@kdemail.net). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

D23951: Improve desktop layout and panel editing UX

GB_2 added a dependency: D24246: Only show panel toolbox when desktop toolbox is open. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D23951 To: GB_2, #plasma, #vdg, mart Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n,

D24245: Add support for passing Unix file descriptors

fvogt requested changes to this revision. fvogt added a comment. This revision now requires changes to proceed. Unfortunately, this breaks public API and ABI by modifying KAuth::ActionReply. I'm not sure whether there has to be any compatibility for the DBus API, but I guess not (logging

D23835: Add TabKCM

mart added a comment. as background it should probably use a Frame component (which atm in the style is just a simple Rectangle.. si i should fix that and make it draw the proper raised frame;) also, sadly, it will have to look good-ish also with other styles, like omg, oxygen

D24245: Add support for passing Unix file descriptors

volkov created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. volkov requested review of this revision. REVISION SUMMARY Introduce UnixFileDescriptor class, which holds a copy of a file descriptor. Actually it's a wrapper around

D22365: KNotification macOS native support by NSNotificationCenter

Inoki added a comment. In D22365#538245 , @lnj wrote: > There's something for notifications for iOS and macOS here: https://developer.apple.com/documentation/foundation/nsnotification > Would this patch already work on iOS or could a common

D24239: make editMode a corona global property

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Never mind, that's not in this patch. REPOSITORY R242 Plasma Framework (Library) BRANCH phab/editMode REVISION DETAIL https://phabricator.kde.org/D24239 To: mart, #plasma, #vdg,

D24171: [src/filewidgets/*] replace deprecated foreach with range for

ahmadsamir updated this revision to Diff 66899. ahmadsamir added a comment. More implicit sharing detach prevention REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24171?vs=66698=66899 BRANCH ahmad/foreach-filewidgets (branched from master) REVISION DETAIL

D24239: make editMode a corona global property

mart updated this revision to Diff 66904. mart added a comment. - global actions needed for new edit mode toolbox REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24239?vs=66885=66904 BRANCH phab/editMode REVISION DETAIL

D24245: Add support for passing Unix file descriptors

ngraham added reviewers: fvogt, chinmoyr, cfeck, Frameworks. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D24245 To: volkov, fvogt, chinmoyr, cfeck, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22365: KNotification macOS native support by NSNotificationCenter

lnj added a comment. There's something for notifications for iOS and macOS here: https://developer.apple.com/documentation/foundation/nsnotification Would this patch already work on iOS or could a common API for both be used? (I have no experiences with iOS or macOS, but we (Kaidan)

D5394: KAuth integration in document saving - vol. 2

volkov added a comment. D24245 - support for passing Unix file descriptors in KAuth. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D5394 To: martinkostolny, #ktexteditor, fvogt Cc: kde-frameworks-devel, volkov,

D6709: Add support for sharing file descriptor between KIO slave and KAuth helper

volkov added a comment. Herald added a subscriber: kde-frameworks-devel. Passing file descriptors with KAuth: D24245 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6709 To: chinmoyr, thiago, #frameworks, dfaure Cc:

D24239: make editMode a corona global property

ngraham added a comment. Could we put the word "wallpaper" somewhere in the global edit mode toolbox to improve wallpaper changing discoverability? I recall this in a mockup shown at the Plasma & Usability & Productivity sprint. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D24220: [src/ioslaves/*] replace deprecated foreach with range for

dfaure added inline comments. INLINE COMMENTS > ahmadsamir wrote in http.cpp:2612 > Right. A temporary; but since it's a qstringlist it's implicitly shared. Yes it is, so non-const begin() will detach and make a full copy. REPOSITORY R241 KIO REVISION DETAIL

D24185: Add format-text-underline-squiggle actions icons

trickyricky26 added a comment. In D24185#537880 , @ngraham wrote: > Now the butt ends are gone again. :) Yes, I think it makes more sense for this underline to be a visual crop of a longer one as they would appear in eg. LibreOffice

D24185: Add format-text-underline-squiggle actions icons

ngraham accepted this revision. ngraham added a comment. All right, ship it! REPOSITORY R266 Breeze Icons BRANCH arcpatch-D24185 REVISION DETAIL https://phabricator.kde.org/D24185 To: trickyricky26, #vdg, ngraham Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D24220: [src/ioslaves/*] replace deprecated foreach with range for

ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in http.cpp:2612 > need to move that function call into a const local variable Right. A temporary; but since it's a qstringlist it's implicitly shared. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24220

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir added a comment. Alrighty, quick chat somewhere else, and i'm going to have to call silent agreement on this one - unless i hear things to the contrary, i'm going to merge this next week (that is, 2nd or 3rd of October 2019) so we can get a bit more wide-spread testing done on it

D24239: make editMode a corona global property

ngraham added a comment. +1 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24239 To: mart, #plasma, #vdg Cc: ngraham, GB_2, broulik, kde-frameworks-devel, LeGast00n, michaelh, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 100 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/100/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 26 Sep 2019 10:30:39 + Build duration: 8 min 22 sec and counting JUnit Tests Name:

D23951: Improve desktop layout and panel editing UX

GB_2 added a dependency: D24246: Only show panel toolbox when desktop toolbox is open. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D23951 To: GB_2, #plasma, #vdg, mart Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n,

D24239: make editMode a corona global property

This revision was automatically updated to reflect the committed changes. Closed by commit R242:c621ebe5726f: make editMode a corona global property (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24239?vs=66904=66910

D24245: Add support for passing Unix file descriptors

volkov added a comment. DBus is an internal dependency for KAuth. With the wrapper users don't have to link with QtDBus. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D24245 To: volkov, fvogt, chinmoyr, cfeck, #frameworks, security-team Cc: kde-frameworks-devel,

D23857: Honor global animation speed factor

ngraham added a task: T11315: Global Animation Slider. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23857 To: broulik, #plasma, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D2545: Cleanup KSharedUiServerProxy before qApp exists

cullmann added a comment. Ok, ah, no longer applies cleanly, must redo some things it seems. Will create a new patch for submission. REVISION DETAIL https://phabricator.kde.org/D2545 To: kfunk, vonreth, dfaure Cc: cullmann, thiago, albertvaka, mutlaqja, arrowd, #frameworks

D23951: Improve desktop layout and panel editing UX

GB_2 removed a dependency: D24246: Only show panel toolbox when desktop toolbox is open. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D23951 To: GB_2, #plasma, #vdg, mart Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n,

D24245: Add support for passing Unix file descriptors

aacid added a reviewer: security-team. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D24245 To: volkov, fvogt, chinmoyr, cfeck, #frameworks, security-team Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 186 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/186/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 26 Sep 2019 17:54:10 + Build duration: 20 min and counting BUILD ARTIFACTS

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

cfeck added a comment. I would suggest to commit it either sooner, or after 5.63 is tagged. If you commit on 3rd, there are only two days to test and decide how to improve or revert before tars are made. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D21721 To:

D2545: Cleanup KSharedUiServerProxy before qApp exists

dfaure added a comment. I don't mind, go ahead. REVISION DETAIL https://phabricator.kde.org/D2545 To: kfunk, vonreth, dfaure Cc: cullmann, thiago, albertvaka, mutlaqja, arrowd, #frameworks

D2545: Cleanup KSharedUiServerProxy before qApp exists

cullmann added a comment. David, could we apply this patch, even with the workaround in the Qt patch in craft to have a better experience for people not patching their Qt? REVISION DETAIL https://phabricator.kde.org/D2545 To: kfunk, vonreth, dfaure Cc: cullmann, thiago, albertvaka,

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir added a comment. In D21721#538404 , @cfeck wrote: > I would suggest to commit it either sooner, or after 5.63 is tagged. If you commit on 3rd, there are only two days to test and decide how to improve or revert before tars are made.

D24252: Make OK button configurable in KMessageBox::detailedSorry

dfaure created this revision. dfaure added reviewers: cfeck, vkrause. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY A `kdialog` user requested being able to set it to e.g. "Abort", and indeed

D24150: Fix crash on exit in kio_file

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Ah, I see, OK. REVISION DETAIL https://phabricator.kde.org/D24150 To: hwti, cfeck, dfaure, broulik Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24253: Make 22px squiggle more like 16px squiggle

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH squiggle (branched from master) REVISION DETAIL

D24254: [KCollapsibleGroupBox] Fix QTimeLine::start warning at runtime

dfaure created this revision. dfaure added reviewers: cfeck, ngraham, elvisangelaccio. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY KCollapsibleGroupBox::overrideFocusPolicy calls

D24179: Fix skipOffset with dynamic RegExpr

This revision was automatically updated to reflect the committed changes. Closed by commit R216:d6b1e02ad4da: Fix skipOffset with dynamic RegExpr (authored by jpoelen). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24179?vs=66788=66928#toc REPOSITORY R216 Syntax Highlighting CHANGES

D24252: Make OK button configurable in KMessageBox::sorry/detailedSorry

dfaure updated this revision to Diff 66932. dfaure retitled this revision from "Make OK button configurable in KMessageBox::detailedSorry" to "Make OK button configurable in KMessageBox::sorry/detailedSorry". dfaure added a comment. also add this to sorry(); fix inconsistency with Options

D24150: Fix crash on exit in kio_file

dfaure closed this revision. REVISION DETAIL https://phabricator.kde.org/D24150 To: hwti, cfeck, dfaure, broulik Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 232 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/232/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 27 Sep 2019 00:56:41 + Build duration: 9 min 30 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 101 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/101/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 27 Sep 2019 00:56:41 + Build duration: 8 min 15 sec and counting JUnit Tests Name:

D24253: Make 22px squiggle more like 16px squiggle

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24253 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24220: [src/ioslaves/*] replace deprecated foreach with range for

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH ahmad/foreach-ioslaves2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D24220 To: ahmadsamir, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2,

D24253: Make 22px squiggle more like 16px squiggle

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24253 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23951: Improve desktop layout and panel editing UX

GB_2 added 1 blocking reviewer(s): Plasma. This revision now requires review to proceed. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23951 To: GB_2, #plasma, #vdg, mart Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh,