D25125: Use KListOpenFilesJob for retrieving apps blocking unmount

hallas added a comment. Note that I haven't tested this patch locally because I don't know how to "run" the locally compiled devicenotifier. I can see that I get a `plasma_engine_devicenotifications.so` library from building the project, but I don't know how to "run" it, do we have a cli

D25117: file ioslave: stop copying as soon as the ioslave is killed

meven updated this revision to Diff 69208. meven added a comment. Fix test JobTest::cancelCopyAndCleanDest REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25117?vs=69204=69208 BRANCH better-kill REVISION DETAIL https://phabricator.kde.org/D25117 AFFECTED

Re: D25084: Allow a Multiple instances to become Unique

https://invent.kde.org/kde/konsole/merge_requests/45 But it’s not related to this path, it’s just another bug On Fri, 1 Nov 2019 at 07:06 David Edmundson wrote: > davidedmundson added a comment. View Revision > > > I think I just need to verify if the name

D24962: [DeleteJob] Use a separate worker thread to run actual IO operation

dfaure added inline comments. INLINE COMMENTS > deletejob.cpp:406 > +QMetaObject::invokeMethod(worker(), "rmfile", > Qt::QueuedConnection, > + Q_ARG(const QUrl&, m_currentURL), > + Q_ARG(bool, isLink)); Since

D25117: file ioslave: stop copying as soon as the ioslave is killed

meven updated this revision to Diff 69204. meven marked an inline comment as done. meven added a comment. Better safe than sorry, keep the doKill override REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25117?vs=69187=69204 BRANCH better-kill REVISION

D25113: ftp ioslave: remove redundant variable

This revision was automatically updated to reflect the committed changes. Closed by commit R241:d03551cd0367: ftp ioslave: remove redundant variable (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25113?vs=69180=69205 REVISION DETAIL

D25122: embedd trigrams.map into shared library

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R246 Sonnet BRANCH master REVISION DETAIL https://phabricator.kde.org/D25122 To: cullmann, dfaure, vonreth, #frameworks, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

cullmann added a comment. This patch will still need some work to make dark mode available. Kate will be able to switch to it via the color theme switcher, as that will just switch over to breeze-dark. Could you elaborate on "Also, our icon loading has kind of evolved and we've

D25122: embedd trigrams.map into shared library

This revision was automatically updated to reflect the committed changes. Closed by commit R246:0c195d0ff947: embed trigrams.map into shared library (authored by cullmann). REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25122?vs=69200=69211 REVISION DETAIL

D25125: Use KListOpenFilesJob for retrieving apps blocking unmount

anthonyfieroni added a comment. Set QT_PLUGIN_PATH to you local path with plugin after that set the system path for others `QT_PLUGIN_PATH=/local/path:/system/path executable` INLINE COMMENTS > ksolidnotify.h:50 > void notify(Solid::ErrorType solidError, const QString& error, const

D25125: Use KListOpenFilesJob for retrieving apps blocking unmount

hallas added a comment. In D25125#558043 , @anthonyfieroni wrote: > Set QT_PLUGIN_PATH to you local path with plugin after that set the system path for others > `QT_PLUGIN_PATH=/local/path:/system/path executable` Thanks for the info

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 168 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/168/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 03 Nov 2019 07:27:59 + Build duration: 7 min 11 sec and counting JUnit Tests Name:

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

rempt added a comment. It sounds like it would be something very useful and easy to use. Right now, we package all icons Krita uses in rc files that are compiled in as well. Also, our icon loading has kind of evolved and we've got a bit of code for switching between dark and light icons

D25125: Use KListOpenFilesJob for retrieving apps blocking unmount

hallas created this revision. hallas added reviewers: Frameworks, broulik, bruns. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. hallas requested review of this revision. REVISION SUMMARY Use the KListOpenFilesJob class from KCoreAddons to retrieve the applications

D21235: Add handling of fuseiso filesystem type

hallas added a comment. @bruns - ping :) I have updated this patch with the changes you requested, I hope you are ok with it now. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D21235 To: hallas, bruns, ngraham Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2,

D25123: [WIP] New yakuake logo/icon

ognarb added a reviewer: hein. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D25123 To: mglb, #vdg, #yakuake, hein Cc: ognarb, ngraham, hein, kde-frameworks-devel, vmarinescu, ryanmccoskrie, LeGast00n, GB_2, michaelh, bruns

D24959: Add new preferences search icons

astippich added a comment. I also think that this is too thin. If you'd like to do the updates, please go ahead! You can do it much better than me I think REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24959 To: astippich, #vdg, ngraham, trickyricky26 Cc:

D24433: Move URL parsing methods from kioslave to query object

iasensio removed a dependent revision: D25130: [dolphin/search] Search by (multiple) tags. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D24433 To: iasensio, #baloo, meven Cc: kde-frameworks-devel, #dolphin, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson,

D25132: Use an eyedropper for color-picker icons

ngraham created this revision. ngraham added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY The current icon is a black droplet which doesn't really communicate "pick a color from

D24990: KDEFrameworkCompilerSettings: enable all Qt % KF deprecation warnings

dfaure accepted this revision. dfaure added a comment. Done (in the process of being pushed), you can push this. REPOSITORY R240 Extra CMake Modules BRANCH enableallqtkfdeprecationwarningsforframeworks REVISION DETAIL https://phabricator.kde.org/D24990 To: kossebau, #frameworks,

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 22 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/22/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 03 Nov 2019 20:11:45 + Build duration: 5 min 43 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 169 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/169/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 03 Nov 2019 20:13:28 + Build duration: 26 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 26 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/26/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 03 Nov 2019 20:14:09 + Build duration: 26 min and counting JUnit Tests Name:

D24990: KDEFrameworkCompilerSettings: enable all Qt % KF deprecation warnings

This revision was automatically updated to reflect the committed changes. Closed by commit R240:879769daf047: KDEFrameworkCompilerSettings: enable all Qt % KF deprecation warnings (authored by kossebau). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

cullmann added a comment. As soon as we use the rcc file for the icons, we set an icon theme name. If you have an icon theme name set, QIcon::fromTheme will do: bool hasUserTheme = QIconLoader::instance()->hasUserTheme(); QIconEngine * const engine = (platformTheme &&

D25084: Allow a Multiple instances to become Unique

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Same reservations as davidedmundson. Furthermore this would break talking to dbus-activated unique apps, too, since they wouldn't register with the expected service name. -2

KDE CI: Frameworks » kimageformats » kf5-qt5 FreeBSDQt5.13 - Build # 19 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20FreeBSDQt5.13/19/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 03 Nov 2019 20:13:20 + Build duration: 18 min and counting JUnit Tests Name:

D25123: [WIP] New yakuake logo/icon

KonqiDragon added a comment. I like A. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D25123 To: mglb, #vdg, #yakuake, hein Cc: KonqiDragon, ognarb, ngraham, hein, kde-frameworks-devel, vmarinescu, ryanmccoskrie, LeGast00n, GB_2, michaelh, bruns

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

cullmann added a comment. In D25119#558092 , @broulik wrote: > In D25119#558084 , @cullmann wrote: > > > Hmm, where does that happen? > > >

D24641: Collect more information from version control systems

thomasfischer updated this revision to Diff 69225. thomasfischer added a comment. I updated the diff. I was quite surprised about the time it takes to compute the number of commits (26 seconds), thus I removed this functionality completely. As of now, only 'revision' and 'branch' are queried

D25132: Use an eyedropper for color-picker icons

ngraham edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D25132 To: ngraham, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Vacations

I'm going to be away on vacations until Nov 20, so don't worry if you don't get patches reviewed during that time. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

D25123: [WIP] New yakuake logo/icon

ngraham added a comment. In D25123#558205 , @ndavis wrote: > #vdg , Should we allow some types of icons to be vertically off center? If not that, should we allow some icons to not reach all the way to the

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 56 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/56/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 03 Nov 2019 20:12:11 + Build duration: 9 min 13 sec and counting JUnit Tests Name:

D24990: KDEFrameworkCompilerSettings: enable all Qt % KF deprecation warnings

kossebau added a comment. Merci, will land later tonight. Bonnes vacances :) REPOSITORY R240 Extra CMake Modules BRANCH enableallqtkfdeprecationwarningsforframeworks REVISION DETAIL https://phabricator.kde.org/D24990 To: kossebau, #frameworks, #build_system, apol, dfaure Cc: dfaure,

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 31 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/31/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 03 Nov 2019 20:14:56 + Build duration: 42 min and counting JUnit Tests Name:

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 34 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/34/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 03 Nov 2019 20:15:40 + Build duration: 53 min and counting JUnit Tests Name: projectroot

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

cullmann added a comment. In D25119#558082 , @broulik wrote: > > If you e.g. want to switch to "breeze-dark" this fails as the icons will not be found. > > But why would you need this anyway? At least with `KIconEngine` we colorize the

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

broulik added a subscriber: davidedmundson. broulik added a comment. In D25119#558084 , @cullmann wrote: > Hmm, where does that happen? https://cgit.kde.org/kiconthemes.git/tree/src/kiconloader.cpp#n888 > And does that work for icons

D24959: Add new preferences search icons

trickyricky26 added a comment. What do you think of this? The symbol with 1px lines. F7727547: preferences-desktop-search.svg F7727552: montage.png I thought this might look nicer, but it is too thin

D24641: Collect more information from version control systems

thomasfischer edited the test plan for this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D24641 To: thomasfischer, sitter, kossebau Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

dfaure added a comment. You could use KIOCORE_ENABLE_DEPRECATED_SINCE(5, 65) to already put in place the trigger for the compat code to disappear when KF6 comes around, like you did in file_unix.cpp. It will also make it easier for the future developer who cleans this up. I mean

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 49 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/49/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 03 Nov 2019 20:14:39 + Build duration: 30 min and counting JUnit Tests Name:

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

broulik added a comment. > If you e.g. want to switch to "breeze-dark" this fails as the icons will not be found. But why would you need this anyway? At least with `KIconEngine` we colorize the icons dynamically. I don't have to switch to breeze-dark when I use a dark color scheme on

D24433: Move URL parsing methods from kioslave to query object

iasensio added a dependent revision: D25130: [dolphin/search] Search by (multiple) tags. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D24433 To: iasensio, #baloo, meven Cc: kde-frameworks-devel, #dolphin, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson,

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

cullmann added a comment. Ok, I traced this now a bit. The KIconLoaderPrivate::createIconImage processing seems already not to work for resource based themes on Linux. To try, e.g. use Kate, add the binary resource icon theme to the right location cp

Re: Vacations

Hi David, I wish you to have nice vacations! Who is going to release and announce KDE Frameworks 5.64.0 next Saturday? вс, 3 нояб. 2019 г. в 22:45, David Faure : > > I'm going to be away on vacations until Nov 20, so don't worry if you don't > get patches reviewed during that time. > > -- >

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.13 - Build # 19 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.13/19/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 03 Nov 2019 20:12:34 + Build duration: 11 min and counting JUnit Tests Name: projectroot

D25123: [WIP] New yakuake logo/icon

ngraham added subscribers: hein, ngraham. ngraham added a comment. My vote is for A. I love it. It looks like a pull-down terminal just like the parent icon, re-uses the `>_` iconography common to our terminal icons, but adds a flair that makes the > look like a Y, conjuring up the app's

D25123: [WIP] New yakuake logo/icon

ndavis added a comment. A or C for me. `A` looks more like how I imagine a "drop down terminal", but it's got a lot of margin below the bottom of it. I tried seeing how it would look extended down to the bottom margin: F7728707: Screenshot_20191103_135015.png

D24990: KDEFrameworkCompilerSettings: enable all Qt % KF deprecation warnings

kossebau added a subscriber: dfaure. kossebau added a comment. @dfaure Hi. Any chance you you can sneak in before you are away (enjoy :) ) to remove the "-DQT_DEPRECATED_WARNINGS_SINCE=0x06" from all the KF modules in the next days? Otherwise would land this here with just the

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.13 - Build # 18 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.13/18/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 03 Nov 2019 20:14:24 + Build duration: 28 min and counting JUnit Tests Name: projectroot

HEADS-UP: from now do new deprecations in KF API by *_DEPRECATED_* macros only using upcoming version number

Hi, with KF 5.64 now branched and thus the new deprecation macros going to be released for the first time, now please make sure when in the future marking API as deprecated to use the correct current version, i.e. the one where the deprecation will be made public the first time. So if pushing

D24443: Add a plugin system

nicolasfella updated this revision to Diff 69241. nicolasfella added a comment. - Put into namespace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24443?vs=69239=69241 BRANCH arcpatch-D24443 REVISION DETAIL https://phabricator.kde.org/D24443 AFFECTED FILES

D25132: Use an eyedropper for color-picker icons

ngraham added a comment. Like this maybe? F7730326: Screenshot_20191103_154347.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D25132 To: ngraham, #vdg Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 78 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/78/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 03 Nov 2019 20:14:56 + Build duration: 1 hr 20 min and counting BUILD ARTIFACTS

D25107: Add install dir for systemd units

This revision was automatically updated to reflect the committed changes. Closed by commit R240:fb275fb95d9c: Add install dir for systemd units (authored by davidedmundson). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25107?vs=69160=69238

D25122: embedd trigrams.map into shared library

cullmann reopened this revision. cullmann added a comment. This revision is now accepted and ready to land. Is that because I moved the target to the other cmake file? The generation process should be unchanged. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D25122

D24443: Add a plugin system

nicolasfella marked an inline comment as done. REVISION DETAIL https://phabricator.kde.org/D24443 To: nicolasfella, #frameworks, #plasma, #kde_pim Cc: dkardarakos, vkrause, dvratil, davidedmundson, dhaumann

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.13 - Build # 35 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.13/35/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sun, 03 Nov 2019 20:14:56 + Build duration: 2 hr 40 min and counting BUILD ARTIFACTS

D25084: Allow a Multiple instances to become Unique

tcanabrava added a comment. Point taken, I’ll rework the patch for a regexp of servicenane + ‘-‘ + pid, this will fix your second point. About your first point, do you think it’s a problem? Just speculating, if an app opens as multiple and then another instance tries to open as

D24979: KRunner: port away from deprecated KF5 API

kossebau accepted this revision. kossebau added a comment. This revision is now accepted and ready to land. Untested, but looks okay, besides the unneeded #f in the sources. INLINE COMMENTS > abstractrunner.cpp:327 > > +#if PLASMA_ENABLE_DEPRECATED_SINCE(5, 28) // Plasma::Package is

D25122: embedd trigrams.map into shared library

nicolasfella added a comment. This seems to break several Android builds https://binary-factory.kde.org/view/Android/job/Koko_android/36/console REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D25122 To: cullmann, dfaure, vonreth, #frameworks, vkrause Cc:

D24979: KRunner: port away from deprecated KF5 API

dfaure added a comment. Thanks for the detailed analysis. I'm ok with option A. Let's not complicate this by adding submodule granularity. I have submitted the removal of the "package" member variable separately, that one is obvious and almost unrelated. REPOSITORY R308 KRunner

Re: D25084: Allow a Multiple instances to become Unique

im Open to redo the patch but I don’t see the problems you guys see. The only thing this patch does is to quit early if you trigger a unique application *after* a multiple one has been spawned. See: Konsole (register as multiple) Konsole —new-tab (register as single) But instead of adding a tab

Re: D25084: Allow a Multiple instances to become Unique

Point taken, I’ll rework the patch for a regexp of servicenane + ‘-‘ + pid, this will fix your second point. About your first point, do you think it’s a problem? Just speculating, if an app opens as multiple and then another instance tries to open as unique, it should reuse the existing one or

D25132: Use an eyedropper for color-picker icons

ndavis added a comment. Here's another idea: F7730258: Screenshot_20191103_173337.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D25132 To: ngraham, #vdg Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D24443: Add a plugin system

nicolasfella updated this revision to Diff 69239. nicolasfella marked 9 inline comments as done. nicolasfella added a comment. - Drop property - Use QVector - Use unique_ptr - Make unique_ptr const - Comments - Make calendars pure virtual - ref CHANGES SINCE LAST UPDATE

D24443: Add a plugin system

nicolasfella added inline comments. INLINE COMMENTS > dvratil wrote in calendarentry.h:57 > I would move `sync()` from here to be a virtual method on the plugin - > `sync(const CalendarEntry::Ptr &)`. The implementations would reimplement it > to handle sync, which feels cleaner than having to

D24979: KRunner: port away from deprecated KF5 API

dfaure updated this revision to Diff 69242. dfaure added a comment. rebase, add PLASMA_DISABLE_DEPRECATED_BEFORE_AND_AT=0x050500 REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24979?vs=68815=69242 BRANCH D24979 REVISION DETAIL

D25084: Allow a Multiple instances to become Unique

dfaure added a comment. If I read the patch correctly, then running a multi-instance app (`konsole-1234`) and then running it as unique will lead to `konsole-1234` instead of the expected `konsole`. Worse, if there was a completely unrelated `konsolesettings` application running, then

D25132: Use an eyedropper for color-picker icons

ndavis added a comment. I think it needs to be a little more Breezy. Here are 2 of my attempts with the 16px version: F7730187: Screenshot_20191103_172328.png F7730173: Screenshot_20191103_172121.png F7730179:

D25132: Use an eyedropper for color-picker icons

ngraham added a comment. I dunno, the alternative you've produced looks has a really chunky and unattractive tip to me, but I like some of the other elements. I could maybe square off the little protruding wings on the side though, and make the squeezey bit on the top part more straight. I

D25084: Allow a Multiple instances to become Unique

tcanabrava added a comment. im Open to redo the patch but I don’t see the problems you guys see. The only thing this patch does is to quit early if you trigger a unique application *after* a multiple one has been spawned. See: Konsole (register as multiple) Konsole —new-tab

D25132: Use an eyedropper for color-picker icons

ndavis added a comment. The chunky look works well at 16px, but I can see it sticking out at larger sizes. These ones have pointier tips: 1x F7730340: Screenshot_20191103_174917.png 4x F7730343: Screenshot_20191103_175058.png

D25123: [WIP] New yakuake logo/icon

mglb added a comment. In D25123#558205 , @ndavis wrote: > I tried seeing how it would look extended down to the bottom margin: F7728707: Screenshot_20191103_135015.png Breaking nice-looking

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 170 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/170/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 04 Nov 2019 04:17:57 + Build duration: 17 min and counting JUnit Tests Name: projectroot

D25123: [WIP] New yakuake logo/icon

ndavis added a comment. In D25123#558353 , @mglb wrote: > Breaking nice-looking proportions just to fill vertical space is not good IMO. Making the bar a bit higher might make it look more reasonably. Your second proposition (icon C) looks nice

D25122: embedd trigrams.map into shared library

cullmann planned changes to this revision. cullmann added a comment. Ok, I see. For cross-compiling the trigrams were never generated... I don't think this is a good idea, but I can guard the resource creation with the same code. Volker: You are more familiar with the Android stuff,

D25122: embedd trigrams.map into shared library

cullmann added a comment. Fix see https://commits.kde.org/sonnet/be0414de6b921a1b926ea5e6c75ea3df02240379 REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D25122 To: cullmann, dfaure, vonreth, #frameworks, vkrause Cc: nicolasfella, kde-frameworks-devel, LeGast00n,

D25122: embedd trigrams.map into shared library

cullmann added a comment. I re-scheduled the build, seems to work for me now. @vkrause : have you some solution to run the trigrams stuff for cross compiles, too? REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D25122 To: cullmann, dfaure, vonreth, #frameworks,