D25219: Only create a session config when actually restoring a session

[Nathaniel Graham]

ngraham added a dependent revision: D11382: Add an option to show tabs from 
last time when Dolphin starts.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D25219

To: ngraham, #frameworks, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25215: Fix a couple of broken links, update links to https://kde.org/applications/, add obs

[Méven Car]

meven updated this revision to Diff 69470.
meven added a comment.


  Reapply some lost changes

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25215?vs=69469=69470

BRANCH
  arcpatch-D25215_1

REVISION DETAIL
  https://phabricator.kde.org/D25215

AFFECTED FILES
  data/kmoretools-desktopfiles/_update_all_files.sh
  data/kmoretools-desktopfiles/com.obsproject.Studio.desktop
  data/kmoretools-desktopfiles/com.obsproject.Studio.png
  src/kmoretools/kmoretoolspresets.cpp

To: meven, leinir, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25215: Fix a couple of broken links, update links to https://kde.org/applications/

[Méven Car]

meven updated this revision to Diff 69477.
meven added a comment.


  Split obs changes to D25221 

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25215?vs=69474=69477

BRANCH
  arcpatch-D25215

REVISION DETAIL
  https://phabricator.kde.org/D25215

AFFECTED FILES
  src/kmoretools/kmoretoolspresets.cpp

To: meven, leinir, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25215: Fix a couple of broken links, update links to https://kde.org/applications/

[Méven Car]

meven edited the summary of this revision.

REPOSITORY
  R304 KNewStuff

BRANCH
  arcpatch-D25215

REVISION DETAIL
  https://phabricator.kde.org/D25215

To: meven, leinir, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25215: Fix a couple of broken links, update links to https://kde.org/applications/

[Méven Car]

meven retitled this revision from "Fix a couple of broken links, update links 
to https://kde.org/applications/, add obs" to "Fix a couple of broken links, 
update links to https://kde.org/applications/;.

REPOSITORY
  R304 KNewStuff

BRANCH
  arcpatch-D25215

REVISION DETAIL
  https://phabricator.kde.org/D25215

To: meven, leinir, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24980: Port ssl_cert_errors meta data from KSslError to QSslError

[Ahmad Samir]

ahmadsamir added inline comments.

INLINE COMMENTS

> jobuidelegate.cpp:365
>  
> sslMetaData.value(QStringLiteral("ssl_cipher_bits")).toInt(),
> -
> KSslInfoDialog::errorsFromString(sslMetaData.value(QStringLiteral("ssl_cert_errors";
> +
> KSslInfoDialog::certificateErrorsFromString(sslMetaData.value(QStringLiteral("ssl_cert_errors";
>  kid->exec();

Nitpick, wouldn't QLatin1String be better here?

c.f. Marc Mutz's talk about QStringLiteral and QLatin1String: 
https://youtu.be/Ov7s0GgBbOQ?t=2806

> ksslinfodialog.cpp:263
>  }
>  
> +QList> 
> KSslInfoDialog::certificateErrorsFromString(const QString )

Nitpick, shouldn't there be a "// static" comment like the other method?

Wouldn't a QVector be better here (QVector>)? that 
is IIUC what the QList docs and [1] are saying.

[1]https://marcmutz.wordpress.com/effective-qt/containers/

REPOSITORY
  R241 KIO

BRANCH
  next

REVISION DETAIL
  https://phabricator.kde.org/D24980

To: vkrause, nicolasfella
Cc: ahmadsamir, nicolasfella, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D24843: [KDEPlatformSystemTrayIcon] Recreate deleted menu

[Konrad Materka]

kmaterka added a comment.


  In D24843#560188 , @kmaterka wrote:
  
  > In D24843#560023 , @broulik 
wrote:
  >
  > > This causes menus (mostly submenus) to randomly show up when the SNI is 
updated, e.g. every time VLC changes a track I get its "speed (slower, normal, 
faster)" menu open:
  >
  >
  > I will fix that right away!
  
  
  Fixed in D25223 

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D24843

To: kmaterka, apol, davidedmundson, #plasma, #frameworks, broulik, nicolasfella
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25223: Avoid side effects during menu initialization

[Konrad Materka]

kmaterka updated this revision to Diff 69489.
kmaterka added a comment.


  Final version, ready for review.

REPOSITORY
  R135 Integration for Qt applications in Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25223?vs=69484=69489

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25223

AFFECTED FILES
  src/platformtheme/kdeplatformsystemtrayicon.cpp

To: kmaterka, #plasma, #frameworks, broulik
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25216: Fix translations of $GenericName

[Méven Car]

meven added a comment.


  @aspotashev Is it good for ?

REPOSITORY
  R304 KNewStuff

BRANCH
  arcpatch-D25216

REVISION DETAIL
  https://phabricator.kde.org/D25216

To: meven, leinir, ngraham, #localization
Cc: aspotashev, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25216: Fix translations of $GenericName

[Méven Car]

meven added a comment.


  In D25216#560212 , @aspotashev 
wrote:
  
  > LGTM since it fixes the issue.
  >
  > A next step could be a clearer explaination of what $GenericName will be 
replaced with. Is it always replaced with Filelight's GenericName from its 
filelight.desktop file?
  
  
  Yes, it uses KMoreToolsService::formatString to replace $GenericName with 
content from its desktop file.

REPOSITORY
  R304 KNewStuff

BRANCH
  arcpatch-D25216

REVISION DETAIL
  https://phabricator.kde.org/D25216

To: meven, leinir, ngraham, #localization, aspotashev
Cc: aspotashev, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25216: Fix translations of $GenericName

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R304:91f212f983ef: Fix translations of $GenericName (authored 
by meven).

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25216?vs=69461=69472

REVISION DETAIL
  https://phabricator.kde.org/D25216

AFFECTED FILES
  src/kmoretools/kmoretoolsmenufactory.cpp

To: meven, leinir, ngraham, #localization, aspotashev
Cc: aspotashev, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25221: Add OBS to screenrecorders

[Méven Car]

meven updated this revision to Diff 69478.
meven marked an inline comment as done.
meven added a comment.


  Remove translations

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25221?vs=69476=69478

BRANCH
  obs-branch

REVISION DETAIL
  https://phabricator.kde.org/D25221

AFFECTED FILES
  data/kmoretools-desktopfiles/_update_all_files.sh
  data/kmoretools-desktopfiles/com.obsproject.Studio.desktop
  data/kmoretools-desktopfiles/com.obsproject.Studio.png
  src/kmoretools/kmoretoolspresets.cpp

To: meven, leinir, ngraham
Cc: nicolasfella, kde-frameworks-devel, ngraham, LeGast00n, GB_2, michaelh, 
bruns

D25223: Avoid side effects during menu initialization

[Konrad Materka]

kmaterka created this revision.
kmaterka added reviewers: Plasma, Frameworks, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
kmaterka requested review of this revision.

REVISION SUMMARY
  Setting some attributes, like visible, enabled, etc has side effects. Do
  not set them if these are not changed.

TEST PLAN
  Without this change menus (mostly submenus) randomly shows up when the SNI is 
updated, e.g. every time VLC changes a track I get its "speed (slower, normal, 
faster)" menu open.

REPOSITORY
  R135 Integration for Qt applications in Plasma

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25223

AFFECTED FILES
  src/platformtheme/kdeplatformsystemtrayicon.cpp

To: kmaterka, #plasma, #frameworks, broulik
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25215: Fix a couple of broken links, update links to https://kde.org/applications/, add obs

[Méven Car]

meven updated this revision to Diff 69473.
meven added a comment.


  rebase on master

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25215?vs=69470=69473

BRANCH
  arcpatch-D25215

REVISION DETAIL
  https://phabricator.kde.org/D25215

AFFECTED FILES
  data/kmoretools-desktopfiles/_update_all_files.sh
  data/kmoretools-desktopfiles/com.obsproject.Studio.desktop
  data/kmoretools-desktopfiles/com.obsproject.Studio.png
  src/kmoretools/kmoretoolspresets.cpp

To: meven, leinir, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25221: Add OBS to screenrecorders

[Méven Car]

meven created this revision.
meven added reviewers: leinir, ngraham.
meven added a project: Frameworks.
meven requested review of this revision.

REVISION SUMMARY
  BUG: 412320
  FIXED-IN:  5.65

TEST PLAN
  Spectacle > Tools > More

REPOSITORY
  R304 KNewStuff

BRANCH
  obs-branch

REVISION DETAIL
  https://phabricator.kde.org/D25221

AFFECTED FILES
  data/kmoretools-desktopfiles/_update_all_files.sh
  data/kmoretools-desktopfiles/com.obsproject.Studio.desktop
  data/kmoretools-desktopfiles/com.obsproject.Studio.png
  src/kmoretools/kmoretoolspresets.cpp

To: meven, leinir, ngraham
Cc: kde-frameworks-devel, ngraham, LeGast00n, GB_2, michaelh, bruns

D24980: Port ssl_cert_errors meta data from KSslError to QSslError

[Nicolas Fella]

nicolasfella accepted this revision.
nicolasfella added a comment.
This revision is now accepted and ready to land.


  Code looks sane to me and builds. Haven't done any testing though

REPOSITORY
  R241 KIO

BRANCH
  next

REVISION DETAIL
  https://phabricator.kde.org/D24980

To: vkrause, nicolasfella
Cc: nicolasfella, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25215: Fix a couple of broken links, update links to https://kde.org/applications/, add obs

[Méven Car]

meven updated this revision to Diff 69469.
meven added a comment.


  Add OBS entry to screenrecorders

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25215?vs=69460=69469

BRANCH
  arcpatch-D25215_1

REVISION DETAIL
  https://phabricator.kde.org/D25215

AFFECTED FILES
  data/kmoretools-desktopfiles/_update_all_files.sh
  data/kmoretools-desktopfiles/com.obsproject.Studio.desktop
  data/kmoretools-desktopfiles/com.obsproject.Studio.png
  src/kmoretools/kmoretoolspresets.cpp

To: meven, leinir, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25215: Fix a couple of broken links, update links to https://kde.org/applications/, add obs

[Nathaniel Graham]

ngraham added a comment.


  In an ideal world the OBS stuff would be in a separate patch. :)

REPOSITORY
  R304 KNewStuff

BRANCH
  arcpatch-D25215

REVISION DETAIL
  https://phabricator.kde.org/D25215

To: meven, leinir, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25223: Avoid side effects during menu initialization

[Konrad Materka]

kmaterka added a comment.


  The problem was with:
  
m_menu->setVisible(m_visible);
  
  setters/getters should not have side effects or any logic, but this method 
has. Detached menu stayed as top level window and rendered itself.
  
  VLC has a bug, each systray menu update creates new QMenu, but old one is not 
deleted:
  https://github.com/videolan/vlc/blob/master/modules/gui/qt/menus.cpp#L655
  
  QMenu::clear() deletes all attached actions (if not used somewhere else) but 
not menus! It is weird, but someone explained it here:
  https://bugreports.qt.io/browse/QTBUG-11070

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D25223

To: kmaterka, #plasma, #frameworks, broulik
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25223: Avoid side effects during menu initialization

[Konrad Materka]

kmaterka edited the summary of this revision.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D25223

To: kmaterka, #plasma, #frameworks, broulik
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25221: Add OBS to screenrecorders

[Nicolas Fella]

nicolasfella added inline comments.

INLINE COMMENTS

> com.obsproject.Studio.desktop:4
> +GenericName=Streaming/Recording Software
> +GenericName[fr]=Logiciel d'enregistrement/diffusion
> +Comment=Free and Open Source Streaming/Recording Software

Remove the translated strings

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D25221

To: meven, leinir, ngraham
Cc: nicolasfella, kde-frameworks-devel, ngraham, LeGast00n, GB_2, michaelh, 
bruns

D25215: Fix a couple of broken links, update links to https://kde.org/applications/

[Méven Car]

meven added a comment.


  In D25215#560229 , @ngraham wrote:
  
  > In an ideal world the OBS stuff would be in a separate patch. :)
  
  
  Done.
  
  I interpreted "While you're touching this stuff" wrongly.

REPOSITORY
  R304 KNewStuff

BRANCH
  arcpatch-D25215

REVISION DETAIL
  https://phabricator.kde.org/D25215

To: meven, leinir, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25221: Add OBS to screenrecorders

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R304 KNewStuff

BRANCH
  obs-branch

REVISION DETAIL
  https://phabricator.kde.org/D25221

To: meven, leinir, ngraham
Cc: nicolasfella, kde-frameworks-devel, ngraham, LeGast00n, GB_2, michaelh, 
bruns

D25215: Fix a couple of broken links, update links to https://kde.org/applications/

[Nathaniel Graham]

ngraham added a comment.


  No problem, I wasn't being very clear myself. :)

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D25215

To: meven, leinir, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25132: Use an eyedropper for color-picker icons

[Nathaniel Graham]

ngraham updated this revision to Diff 69471.
ngraham added a comment.


  Update to be a bit more Breezey and address review comments

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25132?vs=69232=69471

BRANCH
  eyedropper-style-color-picker-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25132

AFFECTED FILES
  icons-dark/actions/16/color-picker.svg
  icons-dark/actions/22/color-picker.svg
  icons-dark/actions/24/color-picker.svg
  icons-dark/actions/32/color-picker.svg
  icons/actions/16/color-picker.svg
  icons/actions/22/color-picker.svg
  icons/actions/24/color-picker.svg
  icons/actions/32/color-picker.svg

To: ngraham, #vdg
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25132: Use an eyedropper for color-picker icons

[Nathaniel Graham]

ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25132

To: ngraham, #vdg
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25216: Fix translations of $GenericName

[Alexander Potashev]

aspotashev accepted this revision.
aspotashev added a comment.


  LGTM since it fixes the issue.
  
  A next step could be a clearer explaination of what $GenericName will be 
replaced with. Is it always replaced with Filelight's GenericName from its 
filelight.desktop file?

REPOSITORY
  R304 KNewStuff

BRANCH
  arcpatch-D25216

REVISION DETAIL
  https://phabricator.kde.org/D25216

To: meven, leinir, ngraham, #localization, aspotashev
Cc: aspotashev, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25215: Fix a couple of broken links, update links to https://kde.org/applications/, add obs

[Méven Car]

meven updated this revision to Diff 69474.
meven added a comment.


  rebasing on master

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25215?vs=69473=69474

BRANCH
  arcpatch-D25215

REVISION DETAIL
  https://phabricator.kde.org/D25215

AFFECTED FILES
  data/kmoretools-desktopfiles/_update_all_files.sh
  data/kmoretools-desktopfiles/com.obsproject.Studio.desktop
  data/kmoretools-desktopfiles/com.obsproject.Studio.png
  src/kmoretools/kmoretoolspresets.cpp

To: meven, leinir, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25215: Fix a couple of broken links, update links to https://kde.org/applications/, add obs

[Méven Car]

meven retitled this revision from "Fix a couple of broken links, update links 
to https://kde.org/applications/; to "Fix a couple of broken links, update 
links to https://kde.org/applications/, add obs".
meven edited the summary of this revision.

REPOSITORY
  R304 KNewStuff

BRANCH
  arcpatch-D25215

REVISION DETAIL
  https://phabricator.kde.org/D25215

To: meven, leinir, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25215: Fix a couple of broken links, update links to https://kde.org/applications/

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R304:cdafed6b395f: Fix a couple of broken links, update links 
to https://kde.org/applications/ (authored by meven).

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25215?vs=69477=69480

REVISION DETAIL
  https://phabricator.kde.org/D25215

AFFECTED FILES
  src/kmoretools/kmoretoolspresets.cpp

To: meven, leinir, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25223: Avoid side effects during menu initialization

[Konrad Materka]

kmaterka added a comment.


  Too soon, it is still not finished.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D25223

To: kmaterka, #plasma, #frameworks, broulik
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24843: [KDEPlatformSystemTrayIcon] Recreate deleted menu

[Konrad Materka]

kmaterka added a comment.


  In D24843#560023 , @broulik wrote:
  
  > This causes menus (mostly submenus) to randomly show up when the SNI is 
updated, e.g. every time VLC changes a track I get its "speed (slower, normal, 
faster)" menu open:
  >  F7748305: Screenshot_20191108_151344.png 

  >  (note the thick shadow, this is multiple menus stacked ontop of each other)
  
  
  I will fix that right away!

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D24843

To: kmaterka, apol, davidedmundson, #plasma, #frameworks, broulik, nicolasfella
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25226: [KPropertiesDialog] provide a way of showing the target of a symlink

[Nathaniel Graham]

ngraham added a comment.


  Or maybe should the UI be changed to show a clickable link and an "edit" 
button that temporarily turns it into a text field that lets you edit it?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25226

To: ngraham, #vdg, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25132: Use an eyedropper for color-picker icons

[Noah Davis]

ndavis requested changes to this revision.
ndavis added a comment.
This revision now requires changes to proceed.


  I still think the lines on the side of the tube need to be a bit thicker. 
They're almost half a pixel thick, which is not in line with what we normally 
do and it makes them fuzzy or light gray. 1px diagonal strokes converted to 
paths should look right, but you'll have to change the shape of the body a bit 
to fit the new sides. The tip should also be exended to fill the bottom left 
pixel, otherwise it's kind of blurry.
  
  You see the difference in clarity for the sides and tip?
  top: original
  left: modified with pointy tip, right: modified with thicker tip
  F7749303: Screenshot_20191108_203534.png 
 8x F7749305: 
Screenshot_20191108_203747.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25132

To: ngraham, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25226: [KPropertiesDialog] provide a way of showing the target of a symlink

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  BUG: 413002
  FIXED-IN: 5.65
  
  Undecided on the button. Should it be text-only displaying "Show" instead of 
an icon?
  Or text-and-icon? Is there a better icon we could use or is this one good 
enough?

TEST PLAN
  F7749378: demo-2019-11-08_19.44.51.webm 

REPOSITORY
  R241 KIO

BRANCH
  show-link-target-in-properties-dialog (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25226

AFFECTED FILES
  src/widgets/kpropertiesdialog.cpp

To: ngraham, #vdg, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

[Allen Winter]

winterz added a comment.


  FYI:  Today I added a Krazy checker to do this.  Should see results on the 
EBN in a day or 2.
  
  Although I am skipping the .htignore's, there will still be lots of false 
positives especially in the test programs.
  Let's see what happens.
  -Allen

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D19996

To: vkrause
Cc: kossebau, winterz, knauss, cgiboudeaux, kde-frameworks-devel, 
kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D25225: Symlink microphone to audio-input-microphone on all sizes

[Luigi Toscano]

ltoscano created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ltoscano requested review of this revision.

REVISION SUMMARY
  Right now microphone.png (which is a fall-back for icons like
  microphone-sensitivity-{muted,low,medium,high}) exists
  as a symbolic link to audio-input-microphone.png for small
  icon sizes (16x16, 22x22, 32x32) only.
  
  There is no reason to not have the symlink for all sizes.
  
  As a side effect, the icon is used as OSD for the microphone
  keyboard button and having bigger sizes makes it non-blurry.
  
  BUG: 398160

TEST PLAN
  The microphone OSD is no more blurry.

REPOSITORY
  R267 Oxygen Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25225

AFFECTED FILES
  128x128/devices/microphone.png
  48x48/devices/microphone.png
  64x64/devices/microphone.png

To: ltoscano
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25225: Symlink microphone to audio-input-microphone on all sizes

[Nicolas Fella]

nicolasfella accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R267 Oxygen Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25225

To: ltoscano, nicolasfella
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25221: Add OBS to screenrecorders

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R304:d9258f219328: Add OBS to screenrecorders (authored by 
meven).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D25221?vs=69478=69498#toc

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25221?vs=69478=69498

REVISION DETAIL
  https://phabricator.kde.org/D25221

AFFECTED FILES
  data/kmoretools-desktopfiles/_update_all_files.sh
  data/kmoretools-desktopfiles/com.obsproject.Studio.desktop
  data/kmoretools-desktopfiles/com.obsproject.Studio.png
  src/kmoretools/kmoretoolspresets.cpp

To: meven, leinir, ngraham
Cc: nicolasfella, kde-frameworks-devel, ngraham, LeGast00n, GB_2, michaelh, 
bruns

D24959: Add new preferences search icons

[Alexander Stippich]

astippich updated this revision to Diff 69500.
astippich added a comment.


  - tweak shadows

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24959?vs=68979=69500

BRANCH
  newSearchIcon

REVISION DETAIL
  https://phabricator.kde.org/D24959

AFFECTED FILES
  icons-dark/preferences/32/preferences-desktop-search.svg
  icons/preferences/32/preferences-desktop-search.svg

To: astippich, #vdg, ngraham, trickyricky26
Cc: ndavis, trickyricky26, bruns, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham

D24959: Add new preferences search icons

[Alexander Stippich]

astippich added a comment.


  F7749583: search.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24959

To: astippich, #vdg, ngraham, trickyricky26
Cc: ndavis, trickyricky26, bruns, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham

D25216: Fix translations of $GenericName

[Alexander Potashev]

aspotashev added a comment.


  I suggest a more flexible approach which allows translators to more around 
the "$GenericName" part inside their translation and change the " - " separator 
to anything more appropriate in their language:
  
i18nc("@action:inmenu %1=\"$GenericName\"", "%1 - current folder", 
QStringLiteral("$GenericName"))
  
  (and so on for the other messages)

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D25216

To: meven, leinir, ngraham
Cc: aspotashev, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25215: Fix a couple of broken links, update links to https://kde.org/applications/

[Méven Car]

meven updated this revision to Diff 69460.
meven added a comment.


  Replace remaning kde project links to https://kde.org/applications/

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25215?vs=69457=69460

BRANCH
  arcpatch-D25215

REVISION DETAIL
  https://phabricator.kde.org/D25215

AFFECTED FILES
  src/kmoretools/kmoretoolspresets.cpp

To: meven, leinir, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25117: file ioslave: stop copying as soon as the ioslave is killed

[Méven Car]

meven added a reviewer: ngraham.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25117

To: meven, #frameworks, dfaure, ngraham
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25216: Fix translations of $GenericName

[Méven Car]

meven added a comment.


  In D25216#560122 , @aspotashev 
wrote:
  
  > I suggest a more flexible approach which allows translators to more around 
the "$GenericName" part inside their translation and change the " - " separator 
to anything more appropriate in their language:
  >
  >   i18nc("@action:inmenu %1=\"$GenericName\"", "%1 - current folder", 
"$GenericName")
  >
  >
  > (and so on for the other messages)
  
  
  I like it better will do

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D25216

To: meven, leinir, ngraham
Cc: aspotashev, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25216: Fix translations of $GenericName

[Alexander Potashev]

aspotashev added a comment.


  In general, string concatenation that you suggested is a big red flag for me 
as a translator. Concatenation often creates an untranslatable word puzzle.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D25216

To: meven, leinir, ngraham
Cc: aspotashev, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25216: Fix translations of $GenericName

[Méven Car]

meven updated this revision to Diff 69461.
meven added a comment.


  Better translator-friendly implementation

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25216?vs=69453=69461

BRANCH
  arcpatch-D25216

REVISION DETAIL
  https://phabricator.kde.org/D25216

AFFECTED FILES
  src/kmoretools/kmoretoolsmenufactory.cpp

To: meven, leinir, ngraham
Cc: aspotashev, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25215: Fix a couple of broken links, update links to https://kde.org/applications/

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  While you're touching this stuff, it'll probably be easy to implement 
https://bugs.kde.org/show_bug.cgi?id=412320

REPOSITORY
  R304 KNewStuff

BRANCH
  arcpatch-D25215

REVISION DETAIL
  https://phabricator.kde.org/D25215

To: meven, leinir, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25216: Fix translations of $GenericName

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R304 KNewStuff

BRANCH
  arcpatch-D25216

REVISION DETAIL
  https://phabricator.kde.org/D25216

To: meven, leinir, ngraham, #localization
Cc: aspotashev, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25216: Fix translations of $GenericName

[Nathaniel Graham]

ngraham added a reviewer: Localization.
ngraham added a comment.


  LGTM but please wait for approval from a translator too.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D25216

To: meven, leinir, ngraham, #localization
Cc: aspotashev, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25219: Also only create a session config when actually restoring a session

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Frameworks, davidedmundson.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This allows manually invoking session restoration logic without creating 
duplicate
  configs, in support of D25106  and 
https://invent.kde.org/kde/okular/merge_requests/58/

TEST PLAN
  Apply either of the above patches and verify that it works

REPOSITORY
  R237 KConfig

BRANCH
  session-config (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25219

AFFECTED FILES
  src/gui/kconfiggui.cpp

To: ngraham, #frameworks, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25219: Only create a session config when actually restoring a session

[Nathaniel Graham]

ngraham retitled this revision from "Also only create a session config when 
actually restoring a session" to "Only create a session config when actually 
restoring a session".

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D25219

To: ngraham, #frameworks, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25106: Also allow invoking session restoration logic when apps are manually launched

[Nathaniel Graham]

ngraham added a comment.


  Done, see D25219 

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D25106

To: ngraham, davidedmundson, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25208: Add missing property to KKeySequenceWidget

[Kevin Ottens]

ervin created this revision.
ervin added reviewers: Frameworks, dfaure, davidedmundson, bport.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ervin requested review of this revision.

REVISION SUMMARY
  Oddly enough we had all the necessary to manage keySequence as a
  property but that was never exposed. This makes it for instance
  unavailable to Qt Designer and impossible to use with KConfigXT.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D25208

AFFECTED FILES
  src/kkeysequencewidget.h

To: ervin, #frameworks, dfaure, davidedmundson, bport
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25208: Add missing property to KKeySequenceWidget

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D25208

To: ervin, #frameworks, dfaure, davidedmundson, bport
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25209: Register KKeySequenceWidget to KConfigDialogManager

[Kevin Ottens]

ervin created this revision.
ervin added reviewers: Frameworks, dfaure, davidedmundson, bport.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ervin requested review of this revision.

REVISION SUMMARY
  This makes it usable in a KConfigXT context.
  
  Depends on KKeySequenceWidget property to be available,
  introduced with: https://phabricator.kde.org/D25208

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25209

AFFECTED FILES
  src/kconfigdialogmanager.cpp

To: ervin, #frameworks, dfaure, davidedmundson, bport
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25210: Prepare KConfigSkeletonItem to allow inheriting its private class

[Kevin Ottens]

ervin created this revision.
ervin added reviewers: Frameworks, dfaure, davidedmundson, bport, crossi.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ervin requested review of this revision.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D25210

AFFECTED FILES
  src/core/kcoreconfigskeleton.cpp
  src/core/kcoreconfigskeleton.h

To: ervin, #frameworks, dfaure, davidedmundson, bport, crossi
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25211: Add KPropertySkeletonItem

[Kevin Ottens]

ervin created this revision.
ervin added reviewers: Frameworks, dfaure, davidedmundson, bport, crossi.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ervin requested review of this revision.

REVISION SUMMARY
  This new item allows to use a QObject property as a source for a
  setting. This is especially convenient for using with KCMs present in
  systemsettings which tend to store information outside of KConfig (for
  interfacing deeper with the system).

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D25211

AFFECTED FILES
  src/core/kcoreconfigskeleton.cpp
  src/core/kcoreconfigskeleton.h
  src/core/kcoreconfigskeleton_p.h

To: ervin, #frameworks, dfaure, davidedmundson, bport, crossi
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25106: Also allow invoking session restoration logic when apps are manually launched

[Nathaniel Graham]

ngraham added a comment.


  Ping.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D25106

To: ngraham, davidedmundson, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25209: Register KKeySequenceWidget to KConfigDialogManager

[Volker Krause]

vkrause accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25209

To: ervin, #frameworks, dfaure, davidedmundson, bport, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25210: Prepare KConfigSkeletonItem to allow inheriting its private class

[Kevin Ottens]

ervin updated this revision to Diff 69440.
ervin added a comment.


  Add missing virtual dtor

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25210?vs=69431=69440

REVISION DETAIL
  https://phabricator.kde.org/D25210

AFFECTED FILES
  src/core/kcoreconfigskeleton.cpp
  src/core/kcoreconfigskeleton.h
  src/core/kcoreconfigskeleton_p.h

To: ervin, #frameworks, dfaure, davidedmundson, bport, crossi
Cc: vkrause, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » knewstuff » kf5-qt5 WindowsMSVCQt5.13 - Build # 35 - Aborted!

[CI System]

BUILD ABORTED
 Build URL
https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20WindowsMSVCQt5.13/35/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Thu, 07 Nov 2019 14:06:02 +
 Build duration:
20 hr and counting

D25117: file ioslave: stop copying as soon as the ioslave is killed

[Méven Car]

meven added a comment.


  friendly ping

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25117

To: meven, #frameworks, dfaure
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25208: Add missing property to KKeySequenceWidget

[Kevin Ottens]

This revision was automatically updated to reflect the committed changes.
Closed by commit R263:fab6d95a9fad: Add missing property to KKeySequenceWidget 
(authored by ervin).

REPOSITORY
  R263 KXmlGui

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25208?vs=69429=69436

REVISION DETAIL
  https://phabricator.kde.org/D25208

AFFECTED FILES
  src/kkeysequencewidget.h

To: ervin, #frameworks, dfaure, davidedmundson, bport
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25210: Prepare KConfigSkeletonItem to allow inheriting its private class

[Volker Krause]

vkrause added a comment.


  Ok as such, but I think KConfigSkeletonItemPrivate would need a virtual dtor 
for this to actually work safely when used by a sub-class?

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D25210

To: ervin, #frameworks, dfaure, davidedmundson, bport, crossi
Cc: vkrause, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25210: Prepare KConfigSkeletonItem to allow inheriting its private class

[Kevin Ottens]

ervin added a comment.


  In D25210#559977 , @vkrause wrote:
  
  > Ok as such, but I think KConfigSkeletonItemPrivate would need a virtual 
dtor for this to actually work safely when used by a sub-class?
  
  
  You mean like not leaking memory? woops. ;-)

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D25210

To: ervin, #frameworks, dfaure, davidedmundson, bport, crossi
Cc: vkrause, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25210: Prepare KConfigSkeletonItem to allow inheriting its private class

[Volker Krause]

vkrause accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D25210

To: ervin, #frameworks, dfaure, davidedmundson, bport, crossi, vkrause
Cc: vkrause, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25209: Register KKeySequenceWidget to KConfigDialogManager

[Kevin Ottens]

This revision was automatically updated to reflect the committed changes.
Closed by commit R265:c0a8cd4a2a95: Register KKeySequenceWidget to 
KConfigDialogManager (authored by ervin).

REPOSITORY
  R265 KConfigWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25209?vs=69430=69439

REVISION DETAIL
  https://phabricator.kde.org/D25209

AFFECTED FILES
  src/kconfigdialogmanager.cpp

To: ervin, #frameworks, dfaure, davidedmundson, bport, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25197: Show a "Loading more..." busy indicator when loading view data

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In D25197#559686 , @ngraham wrote:
  
  > Cool, I'm okay with that.
  >
  > The "Loading more" indicator is aligned to the top, not centered like the 
other loading indicator is.
  
  
  It's at the end of the list, though... perhaps it'd make sense to do a thing 
and ensure the item is the height of the view if there's no items in the list 
(which i think is what you're seeing)

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D25197

To: leinir, #knewstuff, #frameworks, #plasma, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25197: Show a "Loading more..." busy indicator when loading view data

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 69428.
leinir added a comment.


  - Ensure that the indicator is the full height of the view when it's empty

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25197?vs=69398=69428

BRANCH
  reduce-some-noise (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25197

AFFECTED FILES
  src/qtquick/qml/DialogContent.qml
  src/qtquick/qml/Page.qml
  src/qtquick/quickitemsmodel.cpp
  src/qtquick/quickitemsmodel.h

To: leinir, #knewstuff, #frameworks, #plasma, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » knewstuff » kf5-qt5 WindowsMSVCQt5.13 - Build # 36 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20WindowsMSVCQt5.13/36/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Fri, 08 Nov 2019 10:42:11 +
 Build duration:
6 min 18 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: projectroot.autotests.kmoretoolstest

D25216: Fix translations of $GenericName

[Méven Car]

meven created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  $GenericName was translated before being passed to 
KMoreToolsService::formatString,
  causing translators to process "$GenericName - ..." in their language, in 
turn causing formatString not to replace the expected placeholder $GenericName 
for instance.

TEST PLAN
  In another language than English:
  Open Dolphin
  Click on the free space progress bar
  Menu appears
  
  Before (with French) :
  First entry begins with "$NomGénérique -..."
  
  After:
  First entry begins with "Statistiques d'utilisation des disques - ..."

REPOSITORY
  R304 KNewStuff

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25216

AFFECTED FILES
  src/kmoretools/kmoretoolsmenufactory.cpp

To: meven
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25216: Fix translations of $GenericName

[Méven Car]

meven added reviewers: leinir, ngraham.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D25216

To: meven, leinir, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25216: Fix translations of $GenericName

[Méven Car]

meven edited the summary of this revision.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D25216

To: meven, leinir, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25216: Fix translations of $GenericName

[Méven Car]

meven updated this revision to Diff 69453.
meven added a comment.


  Amend comment

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25216?vs=69452=69453

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25216

AFFECTED FILES
  src/kmoretools/kmoretoolsmenufactory.cpp

To: meven, leinir, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25217: don't delete and recreate wallpaperinterface if not needed

[Marco Martin]

mart created this revision.
mart added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mart requested review of this revision.

REVISION SUMMARY
  the wallpaperinterface instance already reacts to wallpaper package
  change and loads the current one.
  containemtninterface deleted it every time the wallpaper changed
  and recreated, effectively loading the wallpaper two times every time
  the plugin was changed

TEST PLAN
  switching plugins still works, but it's actually visible faster on slow 
hardware

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/dontdelete

REVISION DETAIL
  https://phabricator.kde.org/D25217

AFFECTED FILES
  src/scriptengines/qml/plasmoid/containmentinterface.cpp

To: mart, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25217: don't delete and recreate wallpaperinterface if not needed

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/dontdelete

REVISION DETAIL
  https://phabricator.kde.org/D25217

To: mart, #plasma, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25217: don't delete and recreate wallpaperinterface if not needed

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:b58d7c775299: dont delete and recreate 
wallpaperinterface if not needed (authored by mart).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25217?vs=69454=69455

REVISION DETAIL
  https://phabricator.kde.org/D25217

AFFECTED FILES
  src/scriptengines/qml/plasmoid/containmentinterface.cpp

To: mart, #plasma, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25215: Fix a couple of broken links

[Méven Car]

meven added a comment.


  In D25215#560047 , @ngraham wrote:
  
  > We should use the kde.org/applications links, e.g. 
https://kde.org/applications/system/org.kde.kdf, not 
https://utils.kde.org/projects/kdf
  
  
  I did not find this url, thanks

INLINE COMMENTS

> kmoretoolspresets.cpp:83
>  ADD_ENTRY(QStringLiteral("org.kde.kcharselect"),0, 
> "https://utils.kde.org/projects/kcharselect/;, 
> QStringLiteral("org.kde.kcharselect"));
> -ADD_ENTRY(QStringLiteral("org.kde.kdf"),0, 
> "https://www.kde.org/applications/system/kdiskfree;, 
> QStringLiteral("org.kde.kdf"));
> +ADD_ENTRY(QStringLiteral("org.kde.kdf"),0, 
> "https://utils.kde.org/projects/kdf;, QStringLiteral("org.kde.kdf"));
>  ADD_ENTRY(QStringLiteral("org.kde.kfind"),  1, 
> "https://www.kde.org/applications/utilities/kfind/;, 
> QStringLiteral("org.kde.kfind.desktop")); // has good filtering options

Replace with https://kde.org/applications/system/org.kde.kdf

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D25215

To: meven, leinir, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25215: Fix a couple of broken links

[Méven Car]

meven updated this revision to Diff 69456.
meven added a comment.


  Fix kdf link and update others

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25215?vs=69447=69456

BRANCH
  arcpatch-D25215

REVISION DETAIL
  https://phabricator.kde.org/D25215

AFFECTED FILES
  src/kmoretools/kmoretoolspresets.cpp

To: meven, leinir, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25215: Fix a couple of broken links, update links to https://kde.org/applications/

[Méven Car]

meven retitled this revision from "Fix a couple of broken links" to "Fix a 
couple of broken links, update links to https://kde.org/applications/;.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D25215

To: meven, leinir, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25215: Fix a couple of broken links, update links to https://kde.org/applications/

[Méven Car]

meven updated this revision to Diff 69457.
meven marked an inline comment as done.
meven added a comment.


  amend comment

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25215?vs=69456=69457

BRANCH
  arcpatch-D25215

REVISION DETAIL
  https://phabricator.kde.org/D25215

AFFECTED FILES
  src/kmoretools/kmoretoolspresets.cpp

To: meven, leinir, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25106: Also allow invoking session restoration logic when apps are manually launched

[David Edmundson]

davidedmundson added a comment.


  > KConfigGui::sessionConfig();
  
  This method behaves weirdly and not what I expected from reading this code.
  
  If no-one has explicitly called KConfigGui::sessionConfig it creates a new 
one using qApp->sessionConfig() regardless of whether we're session restored or 
not. If we're not sessionRestored it'll effectively leak a bogus config with a 
broken ID name.
  
  I think  to accept the patch we would need to also change
  
  kconfiggui.cpp:42 to be
  
  - if (!hasSessionConfig()) {
  
  + if (!hasSessionConfig() && qApp->isSessionRestored()) {

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D25106

To: ngraham, davidedmundson, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24843: [KDEPlatformSystemTrayIcon] Recreate deleted menu

[Kai Uwe Broulik]

broulik added a comment.


  This causes menus (mostly submenus) to randomly show up when the SNI is 
updated, e.g. every time VLC changes a track I get its "speed (slower, normal, 
faster)" menu open:
  F7748305: Screenshot_20191108_151344.png 

  (note the thick shadow, this is multiple menus stacked ontop of each other)

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D24843

To: kmaterka, apol, davidedmundson, #plasma, #frameworks, broulik, nicolasfella
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25215: Fix a couple of broken links

[Méven Car]

meven created this revision.
meven added a reviewer: leinir.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REPOSITORY
  R304 KNewStuff

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25215

AFFECTED FILES
  src/kmoretools/kmoretoolspresets.cpp

To: meven, leinir
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25211: Add KPropertySkeletonItem

[Kevin Ottens]

ervin updated this revision to Diff 69442.
ervin added a comment.


  Fix member variable naming convention

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25211?vs=69432=69442

REVISION DETAIL
  https://phabricator.kde.org/D25211

AFFECTED FILES
  src/core/kcoreconfigskeleton.cpp
  src/core/kcoreconfigskeleton.h
  src/core/kcoreconfigskeleton_p.h

To: ervin, #frameworks, dfaure, davidedmundson, bport, crossi
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25197: Show a "Loading more..." busy indicator when loading view data

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R304 KNewStuff

BRANCH
  reduce-some-noise (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25197

To: leinir, #knewstuff, #frameworks, #plasma, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25173: Give some more pretty feedback in NewStuff::Page while the Engine is loading

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R304 KNewStuff

BRANCH
  be-more-friendly-during-initial-load (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25173

To: leinir, #knewstuff, #frameworks, ngraham, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25197: Show a "Loading more..." busy indicator when loading view data

[Dan Leinir Turthra Jensen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R304:080f5276ae2f: Show a Loading more... busy 
indicator when loading view data (authored by leinir).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D25197?vs=69428=69446#toc

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25197?vs=69428=69446

REVISION DETAIL
  https://phabricator.kde.org/D25197

AFFECTED FILES
  src/qtquick/qml/DialogContent.qml
  src/qtquick/qml/Page.qml
  src/qtquick/quickitemsmodel.cpp
  src/qtquick/quickitemsmodel.h

To: leinir, #knewstuff, #frameworks, #plasma, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25215: Fix a couple of broken links

[Dan Leinir Turthra Jensen]

leinir accepted this revision.
leinir added a comment.
This revision is now accepted and ready to land.


  Good catch :)

REPOSITORY
  R304 KNewStuff

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25215

To: meven, leinir
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25173: Give some more pretty feedback in NewStuff::Page while the Engine is loading

[Dan Leinir Turthra Jensen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R304:f1f439cbef94: Give some more pretty feedback in 
NewStuff::Page while the Engine is loading (authored by leinir).

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25173?vs=69399=69445

REVISION DETAIL
  https://phabricator.kde.org/D25173

AFFECTED FILES
  src/qtquick/qml/DialogContent.qml
  src/qtquick/qml/Page.qml
  src/qtquick/quickengine.cpp
  src/qtquick/quickengine.h

To: leinir, #knewstuff, #frameworks, ngraham, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25215: Fix a couple of broken links

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  We should use the kde.org/applications links, e.g. 
https://kde.org/applications/system/org.kde.kdf, not 
https://utils.kde.org/projects/kdf

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D25215

To: meven, leinir, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns