D25244: Implement ISpellChecker backend for Windows >= 8

vonreth accepted this revision. This revision is now accepted and ready to land. REPOSITORY R246 Sonnet BRANCH sonnet_ispellchecker_win REVISION DETAIL https://phabricator.kde.org/D25244 To: cullmann, #frameworks, vonreth Cc: mludwig, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

KDE CI: Frameworks » sonnet » kf5-qt5 WindowsMSVCQt5.13 - Build # 19 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/sonnet/job/kf5-qt5%20WindowsMSVCQt5.13/19/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sun, 17 Nov 2019 14:02:42 + Build duration: 2 min 14 sec and counting CONSOLE OUTPUT

D25355: [Samba] Improve warning message about netbios name

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D25355 To: meven, #frameworks, ngraham Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D21660: remove dbus for windows build and change audio dep logic

cullmann added a comment. +1 for no dbus on Windows! REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21660 To: brute4s99, broulik, nicolasfella Cc: cullmann, habacker, aspotashev, bcooksley, apol, nicolasfella, kde-frameworks-devel, LeGast00n, GB_2,

D25334: Added transparent blue background to tabbars

ngraham added a comment. Can you remove the line width changes from this? When this patch just adds the transparent blue background, I think it's pretty uncontroversial and read to land quickly. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL

D25334: Added transparent blue background to tabbars

niccolove updated this revision to Diff 69879. niccolove added a comment. Resized 2px tabbar line to 3px REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25334?vs=69841=69879 BRANCH tabbar_blue_background (branched from master)

D25015: Update breeze theme shadows

niccolove added a comment. Finally! I'm 100% this works now. In D25015#563300 , @niccolove wrote: > This is a comparison: F7766697: Screenshot_20191116_165659.png > The problem is not that you

D25328: Always rehiglhight() after definition was changed

cullmann added a comment. Hmm, the use case is that it re-highlights if you set an invalid definition? Perhaps one should just trigger rehighlight here just for that case, too. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D25328 To: meven, kossebau,

D24568: Provide clang-format target with a KDE Frameworks style file

cullmann added a comment. In D24568#563092 , @davidedmundson wrote: > As an update on this from the Plasma POV. > > I added the macro to every repo and told every dev to do a final test before we commit the formatted results. > > I had

D24568: Provide clang-format target with a KDE Frameworks style file

cullmann reopened this revision. cullmann added a comment. This revision is now accepted and ready to land. Let's just reopen this and work on improving it. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D24568 To: cullmann, #frameworks, dfaure Cc: zzag,

D25015: Update breeze theme shadows

filipf added a comment. +1 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25015 To: niccolove, #vdg Cc: cblack, ndavis, manueljlin, ngraham, filipf, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D21235: Add handling of fuseiso filesystem type

anthonyfieroni added inline comments. INLINE COMMENTS > fstabdevice.cpp:92 > +if (!isoFilePath.isEmpty()) { > +m_description = ShortenPath(isoFilePath) + QLatin1String(" > on ") + m_product; > +} That's incorrect concatenation of translated strings.

D24568: Provide clang-format target with a KDE Frameworks style file

cullmann added reviewers: broulik, davidedmundson. cullmann added a comment. For the lambda issue, I think we can add: # keep lambda formatting multi-line if not empty AllowShortLambdasOnASingleLine: Empty see https://clang.llvm.org/docs/ClangFormatStyleOptions.html That

D25244: Implement ISpellChecker backend for Windows >= 8

This revision was automatically updated to reflect the committed changes. cullmann marked an inline comment as done. Closed by commit R246:67cbe8776a1f: Implement ISpellChecker backend for Windows = 8 (authored by cullmann). REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » sonnet » kf5-qt5 WindowsMSVCQt5.13 - Build # 20 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/sonnet/job/kf5-qt5%20WindowsMSVCQt5.13/20/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sun, 17 Nov 2019 14:08:32 + Build duration: 5 min 52 sec and counting JUnit Tests Name:

D25355: [Samba] Improve warning message about netbios name

meven edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25355 To: meven, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25355: [Samba] Improve warning message about netbios name

meven updated this revision to Diff 69877. meven added a comment. Display leftovers warnings if any REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25355?vs=69876=69877 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25355 AFFECTED FILES

D21235: Add handling of fuseiso filesystem type

ngraham added inline comments. INLINE COMMENTS > anthonyfieroni wrote in fstabdevice.cpp:92 > That's incorrect concatenation of translated strings. yeah, should be `m_description = i18nc("provide context here", %1 on %2, ShortenPath(isoFilePath), m_product);` REPOSITORY R245 Solid REVISION

D25340: Added background colors to active and inactive icon view

niccolove updated this revision to Diff 69880. niccolove added a comment. Changed 2px lines to 3px REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25340?vs=69851=69880 BRANCH backrgound-color-iconviewer (branched from master) REVISION

D25015: Update breeze theme shadows

niccolove updated this revision to Diff 69886. niccolove added a comment. Updated breeze shadows REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25015?vs=69820=69886 BRANCH bettershadows (branched from master) REVISION DETAIL

D25355: [Samba] Improve warning message about netbios name

meven created this revision. meven added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Before: kf5.kio.core: We got some errors while running testparm "Load smb config

D25340: Added background colors to active and inactive icon view

niccolove updated this revision to Diff 69882. niccolove added a comment. Tweaked colors of icon view backgrounds REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25340?vs=69880=69882 BRANCH backrgound-color-iconviewer (branched from

D25244: Implement ISpellChecker backend for Windows >= 8

cullmann marked 2 inline comments as done. cullmann added inline comments. INLINE COMMENTS > vonreth wrote in ispellcheckerclient.cpp:33 > is that needed? It should be handled by the qt main loop? The docs state one shall do that in any case and that it stacks. I think there is no harm to do

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

cullmann added a comment. The issue with this approach is, that you get "too high" lines for the case that none of this characters ever appear. Beside that, unfortunately, you get rendering artifacts in addition, as Qt will not paint e.g. selection high enough for lines without such chars.

D25355: [Samba] Improve warning message about netbios name

meven updated this revision to Diff 69878. meven edited the summary of this revision. meven added a comment. Fix REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25355?vs=69877=69878 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25355

D25340: Added background colors to active and inactive icon view

niccolove added a comment. In D25340#563593 , @ndavis wrote: > Here's a cleaned up version of the file with the changes Nate and I requested: F7767647: tasks.svg Oh sorry, I missed this. I'll use

D24568: Provide clang-format target with a KDE Frameworks style file

cullmann added a comment. Btw., I just tried e.g. https://code.qt.io/cgit/qt/qt5.git/tree/_clang-format that one has exactly the same issues as our file and re-flows stuff into single lines (even lambdas). The only thing that often hinders that is the column limit of 100 there.

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

anthonyfieroni added a comment. In D25339#563822 , @xuetianweng wrote: > Having different font height for every line? 1. We don't want a bigger lines 2. We don't want a lines that are bigger that other in a view. 3. We don't

D25244: Implement ISpellChecker backend for Windows >= 8

cullmann added a comment. This allows to shrink e.g. the Kate installation on Windows from 431 MB to 274 MB, > 150 MB space less occupied ;=) REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D25244 To: cullmann, #frameworks, vonreth Cc: mludwig, kde-frameworks-devel,

D25331: Duplicate QML installation for unit tests

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Maybe wrap in if(BUILD_TESTING) REPOSITORY R275 KItemModels BRANCH master REVISION DETAIL https://phabricator.kde.org/D25331 To: davidedmundson, apol Cc: apol, kde-frameworks-devel,

D25331: Duplicate QML installation for unit tests

davidedmundson updated this revision to Diff 69896. davidedmundson added a comment. update REPOSITORY R275 KItemModels CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25331?vs=69816=69896 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25331 AFFECTED FILES

D25360: Conditionally set SH_ScrollBar_LeftClickAbsolutePosition based on kdeglobals setting

ngraham created this revision. ngraham added reviewers: Frameworks, Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY CCBUG: 379498 TEST PLAN - Set `LeftClickNavigatesByPage=true` in the

D25360: Conditionally set SH_ScrollBar_LeftClickAbsolutePosition based on kdeglobals setting

ngraham added a dependent revision: D25361: [Workspace KCM] Expose setting to choose what left-clicking in the scroll trough does. REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D25360 To: ngraham, #frameworks, #plasma Cc: kde-frameworks-devel, LeGast00n,

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

cullmann added a comment. Actually, I could live with: 1. All lines are a bit higher, for me that makes reading even easier. But the rendering shall have no glitches. 2. Some lines have different heights. But I assume this is hard to implement at the moment. REPOSITORY R39

D25340: Added background colors to active and inactive icon view

ngraham added a comment. I'm not 100% sure how I feel about the change to use the same background color for "open" and "minimized" states and distinguish the two entirely with the presence or absence of a gray line. It feels very subtle, almost too much so. I preferred it when the open and

D19498: loadLibrary: Use enum values to define what type of plugin we load

This revision was automatically updated to reflect the committed changes. Closed by commit R317:f6a65feda870: loadLibrary: Use enum values to define what type of plugin we load (authored by aspotashev). REPOSITORY R317 Kross CHANGES SINCE LAST UPDATE

D25334: Added transparent blue background to tabbars

ndavis added a comment. Even if the colors are fixed, there are a number of other places that need fixes in order for this to look right, so I think we should hold off landing this until these issues are fixed: Not extending to the edge: F7768790: Screenshot_20191117_171047.png

D25331: Duplicate QML installation for unit tests

apol accepted this revision. REPOSITORY R275 KItemModels BRANCH master REVISION DETAIL https://phabricator.kde.org/D25331 To: davidedmundson, apol Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25340: Added background colors to active and inactive icon view

ndavis added a comment. In D25340#563783 , @ngraham wrote: > I don't hate the current state, let me note. It's just not what I expected, and I feel like I would need to get used to it rather than immediately falling in love with it.

D25340: Added background colors to active and inactive icon view

ndavis added a comment. F7769041: Screenshot_20191117_203818.png 15% Inactive BG opacity 10% Minimized BG opacity REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25340 To: niccolove, #vdg, ngraham Cc:

D25015: Update breeze theme shadows

ngraham added a comment. Yep, can confirm that it works now. It is indeed a more subtle and pleasing effect. I still think the distance away from the window would be lengthened to make it even nicer-looking. :) But if nobody else agrees, I'm okay with this in its current form. REPOSITORY

D25334: Added transparent blue background to tabbars

ngraham accepted this revision. ngraham added a comment. This seems perfect to me. A big visual improvement IMO. Any objections? REPOSITORY R242 Plasma Framework (Library) BRANCH tabbar_blue_background (branched from master) REVISION DETAIL https://phabricator.kde.org/D25334 To:

D25334: Added transparent blue background to tabbars

ngraham added a comment. In D25334#563841 , @ndavis wrote: > Even if the colors are fixed, there are a number of other places that need fixes in order for this to look right, so I think we should hold off landing this until these issues are

D25340: Added background colors to active and inactive icon view

niccolove added a comment. Now that we got back the 3px line, I would say that it is recognizable. I like the idea of having the background and reinforcing the idea that line=visible. But it's such a minor change that I would be okay with any option really. F7768659:

D25340: Added background colors to active and inactive icon view

ndavis added a comment. In D25340#563908 , @ngraham wrote: > Decreasing the opacity of the icon itself? Maybe that could work. Not the icon, the background. > A pet peeve I have with the status quo is that minimized apps/windows have

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 59 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/59/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 18 Nov 2019 01:44:37 + Build duration: 1 min 42 sec and counting JUnit Tests Name:

D25340: Added background colors to active and inactive icon view

ngraham added a comment. I don't hate the current state, let me note. It's just not what I expected, and I feel like I would need to get used to it rather than immediately falling in love with it. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

xuetianweng added a comment. Any idea about how konsole derive In D25339#563656 , @cullmann wrote: > The issue with this approach is, that you get "too high" lines for the case that none of this characters ever appear. > Beside that,

D25334: Added transparent blue background to tabbars

ndavis requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25334 To: niccolove, #vdg, ngraham, ndavis Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel,

D25340: Added background colors to active and inactive icon view

ngraham added a comment. Decreasing the opacity of the icon itself? Maybe that could work. A pet peeve I have with the status quo is that minimized apps/windows have greater visual prominence than other ones, which seems backwards. This patch generally fixes that (especially for the

D25334: Added transparent blue background to tabbars

ndavis added a comment. These colors don't look right F7768670: Screenshot_20191117_152000.png REPOSITORY R242 Plasma Framework (Library) BRANCH tabbar_blue_background (branched from master) REVISION DETAIL https://phabricator.kde.org/D25334