D25658: Remove superflous private

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. TEST PLAN builds REPOSITORY R294 KBookmarks BRANCH pri REVISION DETAIL http

D25657: Clean up includes

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Sort alphabetically and use CamelCase headers TEST PLAN builds

D25656: Remove unneeded moc include

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. TEST PLAN Builds REPOSITORY R294 KBookmarks BRANCH moc REVISION DETAIL http

D25655: Remove outdated comments

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY They come from a time before KF5 and are probably outdated since th

D25654: Rename actions to be consistent

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Rename actions to all have Action suffix after D25653

D25653: [bookmarksmenu] Improve variable name

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY addAddBookmark make some sense as the method name, but as a variabl

D25629: Port away from KTextWidgets

This revision was automatically updated to reflect the committed changes. Closed by commit R263:13cb497277fa: Port away from KTextWidgets (authored by nicolasfella). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25629?vs=70619&id=70672 REVISION DETAIL http

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH arcpatch-D25010 REVISION DETAIL https://phabricator.kde.org/D25010 To: meven, #frameworks, dfaure, kossebau Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven updated this revision to Diff 70669. meven marked an inline comment as done. meven added a comment. Fix: | instead of & to build a QFlags REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25010?vs=70543&id=70669 BRANCH arcpatch-D25010 REVISION DETAIL h

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > directorysizejob.cpp:141 > +#endif > +listJob->addMetaData(QStringLiteral("statDetails"), > QString::number(KIO::StatDetail::Basic & KIO::StatDetail::Inod

D25572: [KFileWidget] Allow double quotes in filenames

dfaure added a comment. Restarting kdeinit is only needed when making changes that affect kioslaves. Here it's just about a widget, all you need is to start the application from a terminal. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25572 To: meven, #frameworks,

D25650: Port foreach

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. TEST PLAN Builds, tests pass, dolphin opens REPOSITORY R263 KXmlGui BRANCH for

KDE CI: Frameworks » kcalendarcore » kf5-qt5 SUSEQt5.13 - Build # 32 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20SUSEQt5.13/32/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sun, 01 Dec 2019 12:45:16 + Build duration: 3 min 30 sec and counting BUILD ARTIFACTS abi-comp

KDE CI: Frameworks » kcalendarcore » kf5-qt5 SUSEQt5.12 - Build # 30 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20SUSEQt5.12/30/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 01 Dec 2019 12:45:16 + Build duration: 3 min 52 sec and counting BUILD ARTIFACTS abi-comp

D24477: Add PATH/LD_LIBRARY_PATH to qrcAlias invocation

kossebau added inline comments. INLINE COMMENTS > CMakeLists.txt:56 > +COMMAND ${CMAKE_COMMAND} -E env > + > $,PATH,LD_LIBRARY_PATH>=$ > +$ -i ${CMAKE_CURRENT_BINARY_DIR}/tmp.qrc > -o ${RESOURCE_FILE} This breaks builds with CMake 3.5 - 3.7, as `$` was only added

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 30 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/30/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 01 Dec 2019 12:45:16 + Build duration: 1 min 58 sec and counting JUnit Tests Name:

D25638: autotests: Find perl executable on all platforms

This revision was automatically updated to reflect the committed changes. Closed by commit R172:accdbdd65ee0: autotests: Find perl executable on all platforms (authored by aspotashev). REPOSITORY R172 KCalendar Core CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25638?vs=70636&id=706

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

dfaure added a comment. @ngraham AFAIK gnome has a trick where a fuse mount is created, its path is passed to the application being started, and the application, if it supports gvfs, re-translates that into a URL and uses that instead if it makes more sense. This way "dumb" apps get a local

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew added a comment. In D23384#570016 , @ngraham wrote: > In D23384#569929 , @feverfew wrote: > > > This isn't reaching KIOFuse at all. I believe this is related to this bug and that you've als

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

fvogt added a comment. Unfortunately the `kio-fuse -d` output is incomplete, probably because Qt was too smart and logged to the journal instead... It's visible that there are multiple processes reading the file, maybe thumbnailing is in progress? Can you try with thumbnails in dolphin di

D25638: autotests: Find perl executable on all platforms

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. I approve, given that I wrote the same in D25643 :-) REPOSITORY R172 KCalendar Core BRANCH perl REVISION DETAIL https://phabricator.kde.org/D256

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew updated this revision to Diff 70661. feverfew added a comment. - Get rid of unnecessary copying of URLs - Switch to interface generated at compile time - Delete unused interfaces - Merge branch 'master' into arcpatch-D23384 - remove kiofuseinterface from build - Align argumen

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew reopened this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23384 To: feverfew, fvogt, davidedmundson, dfaure, ngraham Cc: sitter, davidedmundson, kde-frameworks-devel, ngraham, LeGast00n, GB_2, michaelh, bruns

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit R241:92c2886c3714: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use… (authored by feverfew).

D24489: KAutosaveFile not respecting maximum filename length

mardelle added a reviewer: dfaure. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D24489 To: mardelle, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25632: Fix module imports with Python3

cordlandwehr added a reviewer: ochurlaud. REPOSITORY R264 KApiDox REVISION DETAIL https://phabricator.kde.org/D25632 To: cordlandwehr, ochurlaud Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D25599: Fix plugin-metadata translations on windows

vonreth added a comment. The doc doesn't mention the LANGUAGE var. QLocale::QLocale() Constructs a QLocale object initialized with the default locale. If no default locale was set using setDefault(), this locale will be the same as the one returned by system(). See al

D25638: autotests: Find perl executable on all platforms

aspotashev added inline comments. INLINE COMMENTS > apol wrote in CMakeLists.txt:93 > maybe it would make sense to check for BSD instead? > I don't know much about BSD, but I'd expect the shebang to work there as well. I think it's better to minimize platform-specific if-endifs and make CMake co

D25572: [KFileWidget] Allow double quotes in filenames

meven added a comment. In D25572#569573 , @ngraham wrote: > This isn't working for me. When I create a file named `"foobar".txt`, the file dialog is still unable to open it, saying: That's precisely the unit test included, it works for.

D25572: [KFileWidget] Allow double quotes in filenames

meven updated this revision to Diff 70651. meven added a comment. Remove unrelated change REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25572?vs=70499&id=70651 BRANCH arcpatch-D25572_1 REVISION DETAIL https://phabricator.kde.org/D25572 AFFECTED FILES

<    1   2