D25755: Replace iterators with range-based for

aacid added inline comments. INLINE COMMENTS > kded.cpp:622 > const QStringList dirs = > QStandardPaths::locateAll(QStandardPaths::GenericDataLocation, > QStringLiteral("kconf_update"), QStandardPaths::LocateDirectory); > -for (QStringList::ConstIterator it = dirs.begin(); > -

D25755: Replace iterators with range-based for

broulik added a comment. In D25755#572418 , @apol wrote: > Do we dislike iterators now? We don't, and they still make sense for when you need the `key`, but range for is just much nier to look at :) REPOSITORY R297 KDED REVISION

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew added a comment. Thanks for the reviews everyone! I'll update the diff and respond to the comments no later than Tuesday REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23384 To: feverfew, fvogt, davidedmundson, dfaure, ngraham Cc: alexde, broulik, sitter,

D25755: Replace iterators with range-based for

apol added a comment. In D25755#572575 , @broulik wrote: > In D25755#572418 , @apol wrote: > > > Do we dislike iterators now? > > > We don't, and they still make sense for when you need the

Re: D25448: EBN cleanup of autotests transfer protocol

I don't have commit access, could someone land this for me? On Sat, 23 Nov 2019, 9:07 am John Hayes, wrote: > jhayes updated this revision to Diff 70220. > jhayes retitled this revision from "EBN cleanup of autests transfer > protocol" to "EBN cleanup of autotests transfer protocol". > jhayes

D25753: EBN extra-cmake-modules transport cleanup

jhayes updated this revision to Diff 70958. jhayes added a comment. - Corrections made per review comments. Reverted some non-working URL's back to http and updated one URL to the correct address REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D25755: Replace iterators with range-based for

ahmadsamir added a comment. If we're going to iterate over a whole container, from cbegin() to cend(), and the container isn't going to change in the loop, then IMHO (H for humble :)) range-for would convey the intention better and make the code slightly easier to read/look cleaner.

D25755: Replace iterators with range-based for

ahmadsamir added a subscriber: dfaure. REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D25755 To: nicolasfella, #frameworks Cc: dfaure, ahmadsamir, broulik, aacid, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25720: Fix shortcut conflict between Cut and Delete File

ngraham added a comment. In D25720#572326 , @aacid wrote: > Apps that need both should be aware of it and remove the secondary Cut shortcut. > > Or if you want to be mega fancy you can make kactioncollection (or something in xmlgui) do that

D24489: KAutosaveFile not respecting maximum filename length

ahmadsamir added a dependent revision: D25767: KAutoSaveFile: add a unit test to check max. filename length. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D24489 To: mardelle, #frameworks, dfaure Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D25767: KAutoSaveFile: add a unit test to check max. filename length

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, mpyne. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY In KAutoSaveFilePrivate::tempFile() the name of the kautosavefile that's going to be created is generated using

D24489: KAutosaveFile not respecting maximum filename length

ahmadsamir added a reviewer: mpyne. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D24489 To: mardelle, #frameworks, dfaure, mpyne Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24489: KAutosaveFile not respecting maximum filename length

ahmadsamir added a comment. Unit test added in D25767 . AFAICS, both points addressed in this diff are needed to fix the referenced bug. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D24489 To: mardelle, #frameworks, dfaure,

D25753: EBN extra-cmake-modules transport cleanup

cgiboudeaux added a comment. The sphinx doc URL is https://www.sphinx-doc.org (it just doesn't work without www) REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D25753 To: jhayes, apol, cgiboudeaux Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem,

D25753: EBN extra-cmake-modules transport cleanup

jhayes updated this revision to Diff 70973. jhayes added a comment. - Corrected URL as review comments Corrected url to http://www.sphinx-doc.org REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25753?vs=70958=70973 BRANCH

D25770: Several enhancements to gitolite syntax definition.

zrax created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. zrax requested review of this revision. REVISION SUMMARY - Add more keywords, including access modes - Highlight include directives properly - Fix group

D25770: Several enhancements to gitolite syntax definition.

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Looks good. But does the highlighting work for `RW+CD`? I am wondering whether `+` needs to be added to the weakDeliminator list? REPOSITORY R216 Syntax Highlighting BRANCH

D25755: Replace iterators with range-based for

dhaumann added a comment. >>> Do we dislike iterators now? >> >> We don't, and they still make sense for when you need the `key`, but range for is just much nier to look at :) > > I'm fine with that statement. But are we going to be reviewing changing all the KDE code from

D23780: Add new protocol for 7z archives

This revision was automatically updated to reflect the committed changes. Closed by commit R241:58800b4d2abd: Add new protocol for 7z archives (authored by nhiga, committed by ngraham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23780?vs=65622=70980 REVISION

D23730: Add new protocol for 7z archives

This revision was automatically updated to reflect the committed changes. Closed by commit R320:f3e66c240d1e: Add new protocol for 7z archives (authored by nhiga, committed by ngraham). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23730?vs=65416=70982

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 215 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/215/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 05 Dec 2019 20:33:35 + Build duration: 10 min and counting JUnit Tests Name: projectroot

D24433: Move URL parsing methods from kioslave to query object

ngraham added a comment. @bruns, is this good to go now? REPOSITORY R293 Baloo BRANCH extend_query_url REVISION DETAIL https://phabricator.kde.org/D24433 To: iasensio, #baloo, meven, ngraham, astippich Cc: broulik, bruns, kde-frameworks-devel, #dolphin, hurikhan77, lots0logs,

D8774: Show Configure Toolbars dialog as modal

ngraham added a comment. Herald added a subscriber: kde-frameworks-devel. Can this land? REPOSITORY R263 KXmlGui BRANCH modal-toolbar-dialog REVISION DETAIL https://phabricator.kde.org/D8774 To: elvisangelaccio, #frameworks, dfaure Cc: kde-frameworks-devel, ngraham, LeGast00n, GB_2,

D25743: Expose IndexerState enum to QML

davidedmundson updated this revision to Diff 70985. davidedmundson edited the summary of this revision. davidedmundson added a comment. redo without the export REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25743?vs=70906=70985 BRANCH master REVISION

D25753: EBN extra-cmake-modules transport cleanup

cgiboudeaux accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH ebn-transport-cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D25753 To: jhayes, apol, cgiboudeaux Cc: cgiboudeaux,

D25753: EBN extra-cmake-modules transport cleanup

This revision was automatically updated to reflect the committed changes. Closed by commit R240:f082ed20e6a8: EBN extra-cmake-modules transport cleanup (authored by jhayes, committed by cgiboudeaux). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D25753?vs=70973=70986#toc REPOSITORY

D14218: Introduce a test to make sure we're not offering duplicated icons

ngraham added a comment. @apol we have a duplicate test in breeze-icons now; is this still relevant? REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D14218 To: apol, andreaska, mart, vkrause, #breeze, #frameworks Cc: dfaure, ngraham, andreask,

D25770: Several enhancements to gitolite syntax definition.

zrax updated this revision to Diff 70989. zrax added a comment. Fix "+" in keywords to not act as a word break. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25770?vs=70974=70989 BRANCH gitolite-syntax (branched from master) REVISION

D25753: EBN extra-cmake-modules transport cleanup

winterz added a comment. please send me a list of urls that don't have https: and I'll add them to the whitelist REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D25753 To: jhayes, apol, cgiboudeaux Cc: winterz, cgiboudeaux, kde-frameworks-devel,

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.12 - Build # 81 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.12/81/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 05 Dec 2019 21:14:24 + Build duration: 17 min and counting JUnit Tests Name:

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.13 - Build # 46 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.13/46/ Project: kf5-qt5 SUSEQt5.13 Date of build: Thu, 05 Dec 2019 21:14:24 + Build duration: 25 min and counting JUnit Tests Name:

D25743: Expose IndexerState enum to QML

ngraham added a comment. Thanks, now it compiles! I'm not sure it's working perfectly though. I updated D25447 to use this, but it's claiming that my indexer is suspended, while ` balooctl status` disagrees. REPOSITORY R293 Baloo REVISION DETAIL

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 49 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/49/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 05 Dec 2019 22:17:13 + Build duration: 3 min 15 sec and counting JUnit Tests

D25775: Check cursor_open return value

davidedmundson created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY This will only fail if something else has already gone wrong, but I was hitting a crash in

D8774: Show Configure Toolbars dialog as modal

dfaure added a comment. The description says this depends on D8773 which isn't approved. REPOSITORY R263 KXmlGui BRANCH modal-toolbar-dialog REVISION DETAIL https://phabricator.kde.org/D8774 To: elvisangelaccio, #frameworks, dfaure Cc:

D24489: KAutosaveFile not respecting maximum filename length

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Why is this not in the same commit as the related unittest, as is common practice? INLINE COMMENTS > kautosavefile.cpp:70 > const QString protocol(managedFile.scheme()); >

D8773: Improve discoverability of drag-and-drop of toolbar actions

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Herald added a subscriber: kde-frameworks-devel. In D8773#167625 , @colomar wrote: > In D8773#167607

D8774: Show Configure Toolbars dialog as modal

ngraham added a comment. Oops, sorry! I added comments to D8773 . REPOSITORY R263 KXmlGui BRANCH modal-toolbar-dialog REVISION DETAIL https://phabricator.kde.org/D8774 To: elvisangelaccio, #frameworks, dfaure Cc: kde-frameworks-devel, ngraham,

D25767: KAutoSaveFile: add a unit test to check max. filename length

dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kautosavefiletest.cpp:84 > +// In KAutoSaveFilePrivate::tempFile() the name of the kautosavefile > that's going to be created > +// is concatinated in the

D8773: Improve discoverability of drag-and-drop of toolbar actions

davidedmundson added a comment. @ngraham Like this: http://static.davidedmundson.co.uk/toolbars_change_01.ogv ? REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D8773 To: elvisangelaccio, #frameworks, #vdg, dfaure, ngraham Cc: davidedmundson, kde-frameworks-devel,

D25755: Replace iterators with range-based for

aacid added a comment. https://clang.llvm.org/extra/clang-tidy/checks/modernize-loop-convert.html is something you can use if you feel bored, i made it mandatory in poppler REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D25755 To: nicolasfella, #frameworks Cc:

D8773: Improve discoverability of drag-and-drop of toolbar actions

dfaure added a comment. That is excellent! But in the implementation, mind the "multiple kxmlgui-clients" use case, like konqueror or kdevelop (or kate I guess). It can make things tricky... (you drop between two clients, how do you know which one should memorize the action into its

D25720: Fix shortcut conflict between Cut and Delete File

aacid added a comment. > Trying to assign anything to Shift+Delete shows the "conflicting shortcuts" error dialog. But that's fine, no? I mean this is the user assigning a shortcut that already exists, not any different than the user trying to assign Ctrl+C somewhere. If he doesn't

D8773: Improve discoverability of drag-and-drop of toolbar actions

davidedmundson added a comment. > That is excellent! That was from my very first PlanetKDE blog post back in 2009 :D And from what I recall, I hit that exact issue you're describing and gave up. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D8773 To:

D8773: Improve discoverability of drag-and-drop of toolbar actions

ngraham added a comment. Haha yes almost exactly like that! Maybe today I'd use a sheet instead of a separate dialog window. But I have great faith that the 2019 David is able to conquer the challenges of 2009. :) REPOSITORY R263 KXmlGui REVISION DETAIL

D25727: Expose enum to the metaobject compiler

apol updated this revision to Diff 70997. apol added a comment. Alternative approach without Q_NAMESPACE_EXPORT, which is too new REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25727?vs=70895=70997 BRANCH arcpatch-D25727 REVISION DETAIL

D25727: Expose enum to the metaobject compiler

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R307 KPeople BRANCH arcpatch-D25727 REVISION DETAIL https://phabricator.kde.org/D25727 To: apol, jbbgameich, davidedmundson Cc: lnj, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2,

D14218: Introduce a test to make sure we're not offering duplicated icons

apol abandoned this revision. apol added a comment. Doesn't seem relevant anymore REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D14218 To: apol, andreaska, mart, vkrause, #breeze, #frameworks Cc: dfaure, ngraham, andreask, kde-frameworks-devel, LeGast00n,

D25753: EBN extra-cmake-modules transport cleanup

cgiboudeaux added inline comments. INLINE COMMENTS > FindCanberra.cmake:98 > DESCRIPTION "Event sound library" > -URL "http://0pointer.de/lennart/projects/libcanberra; > +URL "https://0pointer.de/lennart/projects/libcanberra; > ) redirects to http://0pointer.net/ which is probably

D25753: EBN extra-cmake-modules transport cleanup

cgiboudeaux requested changes to this revision. cgiboudeaux added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > CMakeLists.txt:35 > PROPERTIES > -URL "http://sphinx-doc.org/; > +URL "https://sphinx-doc.org/; > DESCRIPTION "Tool to

D25719: EBN KActivites transfer protocol cleanup

This revision was automatically updated to reflect the committed changes. Closed by commit R6:8c0352356062: EBN KActivites transfer protocol cleanup (authored by jhayes, committed by cgiboudeaux). REPOSITORY R6 KActivities CHANGES SINCE LAST UPDATE

D25742: move backgroundhints managment in Applet

This revision was automatically updated to reflect the committed changes. Closed by commit R242:af861eb2a438: move backgroundhints managment in Applet (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25742?vs=70907=70941

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.13 - Build # 100 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.13/100/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 05 Dec 2019 09:42:24 + Build duration: 4 min 52 sec and counting JUnit Tests

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.13 - Build # 107 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.13/107/ Project: kf5-qt5 SUSEQt5.13 Date of build: Thu, 05 Dec 2019 09:42:23 + Build duration: 4 min 15 sec and counting BUILD ARTIFACTS

D25397: Install .pri file for KAuthCore

This revision was automatically updated to reflect the committed changes. Closed by commit R283:49ed872608fa: Install .pri file for KAuthCore (authored by volkov, committed by cgiboudeaux). REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25397?vs=69987=70944

D25721: EBN kdeclarative transfer protocol cleanup

This revision was automatically updated to reflect the committed changes. Closed by commit R296:342a575c0dd5: EBN kdeclarative transfer protocol cleanup (authored by jhayes, committed by cgiboudeaux). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE

D25448: EBN cleanup of autotests transfer protocol

This revision was automatically updated to reflect the committed changes. Closed by commit R267:b86aa2b10f7d: EBN cleanup of autotests transfer protocol (authored by jhayes, committed by cgiboudeaux). REPOSITORY R267 Oxygen Icons CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.12 - Build # 80 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.12/80/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 05 Dec 2019 09:37:46 + Build duration: 3 min 27 sec and counting JUnit Tests Name:

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.13 - Build # 45 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.13/45/ Project: kf5-qt5 SUSEQt5.13 Date of build: Thu, 05 Dec 2019 09:37:46 + Build duration: 3 min 25 sec and counting JUnit Tests Name:

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 229 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/229/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 05 Dec 2019 09:42:23 + Build duration: 7 min 41 sec and counting BUILD ARTIFACTS

D25752: EBN extra-cmake-modules comments spelling cleanup

This revision was automatically updated to reflect the committed changes. Closed by commit R240:9f441190a36a: EBN extra-cmake-modules comments spelling cleanup (authored by jhayes, committed by cgiboudeaux). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D25493: EBN kmoretools cleanup transport protocol

This revision was automatically updated to reflect the committed changes. Closed by commit R304:19bbe83f5527: EBN kmoretools cleanup transport protocol (authored by jhayes, committed by cgiboudeaux). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE

D25420: [KFileWidget] Avoid calling slotOk right after the url changed

ahmadsamir added a comment. FWIW, this still doesn't work: - Open a pdf in okular - Invoke save as, navigate via the keyboard, highlight/select a dir, Enter, the file is saved inside that dir and the dialog closes REPOSITORY R241 KIO REVISION DETAIL

D25757: EBN purpose constructor cleanup

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R495 Purpose Library BRANCH ebn-cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D25757 To: jhayes, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

broulik added inline comments. INLINE COMMENTS > dfaure wrote in desktopexecparser.cpp:356 > This blocks. > > I don't mind much myself, but I know some people had a mandate to remove as > many blocking calls as possible from KRun and related code. Or was that only > avoiding blocking I/O

D25311: Add KColumnHeadersProxyModel

ahiemstra marked an inline comment as done. REPOSITORY R275 KItemModels REVISION DETAIL https://phabricator.kde.org/D25311 To: ahiemstra Cc: kossebau, vkrause, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25311: Add KColumnHeadersProxyModel

ahiemstra updated this revision to Diff 70948. ahiemstra added a comment. - Add missing layoutChanged/reset signals REPOSITORY R275 KItemModels CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25311?vs=70437=70948 BRANCH columnheadersmodel REVISION DETAIL

D25311: Add KColumnHeadersProxyModel

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Though maybe we should wait till after tagging (Saturday) ? REPOSITORY R275 KItemModels BRANCH columnheadersmodel REVISION DETAIL https://phabricator.kde.org/D25311

D25311: Add KColumnHeadersProxyModel

ahiemstra added a comment. Sure, I can land it after saturday. REPOSITORY R275 KItemModels BRANCH columnheadersmodel REVISION DETAIL https://phabricator.kde.org/D25311 To: ahiemstra, davidedmundson Cc: kossebau, vkrause, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2,