D26918: Improve KNotification API docs

2020-02-16 Thread Aleix Pol Gonzalez
apol added a comment. +1 on improving the documentation, it does read dated. Thanks! INLINE COMMENTS > knotification.h:44 > * @li Feedback events: > - * For notifying the user that he/she just performed an operation, like > maximizing a > - * window. This allows us to play sounds when a

D27429: ThreadWeaver: Convert license headers to SPDX expressions

2020-02-16 Thread Andreas Cord-Landwehr
cordlandwehr created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cordlandwehr requested review of this revision. REVISION SUMMARY Add license files are required by REUSE and add license files as reuqired by REUSE. Please note the

D27429: ThreadWeaver: Convert license headers to SPDX expressions

2020-02-16 Thread Andreas Cord-Landwehr
cordlandwehr added a task: T11550: Add SPDX License markers. REPOSITORY R279 ThreadWeaver REVISION DETAIL https://phabricator.kde.org/D27429 To: cordlandwehr Cc: kde-frameworks-devel, mirko, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27433: Check activeModule before using it

2020-02-16 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D27433 To: wbauer, #frameworks, davidedmundson Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27223: add kirigami-gallery icon

2020-02-16 Thread Mathis Brüchert
mbruchert updated this revision to Diff 75771. mbruchert added a comment. - fix issues REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27223?vs=75228=75771 BRANCH arcpatch-D27223 REVISION DETAIL https://phabricator.kde.org/D27223 AFFECTED FILES

D27419: Update Japanese holidays

2020-02-16 Thread Allen Winter
This revision was automatically updated to reflect the committed changes. Closed by commit R175:1f9332f8f322: Update Japanese holidays (authored by winterz). REPOSITORY R175 KHolidays CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27419?vs=75732=75777 REVISION DETAIL

D27430: [PATCH] General update for CartoCSS syntax highlighting

2020-02-16 Thread Christoph Cullmann
cullmann added a comment. Hi, nice that you keep working on this and upstream your stuff ;=) Could you provide some test file for this? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D27430 To: sommer, #framework_syntax_highlighting Cc: cullmann,

D27223: add kirigami-gallery icon

2020-02-16 Thread Mathis Brüchert
mbruchert added a comment. I have no Idea why the diff deletes the ktrip icon. unfortunately I cant fix that because I have no Idea how to do that with git. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27223 To: mbruchert, mart, #vdg, ndavis Cc: ndavis,

D26918: Improve KNotification API docs

2020-02-16 Thread Nicolas Fella
nicolasfella added a comment. Ping? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D26918 To: nicolasfella, #frameworks, broulik, jucato Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D24401: Use exposed DBus methods to switch activities in CLI

2020-02-16 Thread Ivan Čukić
ivan accepted this revision. This revision is now accepted and ready to land. REPOSITORY R6 KActivities BRANCH cli-nextprev-activity (branched from master) REVISION DETAIL https://phabricator.kde.org/D24401 To: muesli, ivan Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2,

D27430: [PATCH] General update for CartoCSS syntax highlighting

2020-02-16 Thread Lukas Sommer
sommer created this revision. sommer added a project: Framework: Syntax Highlighting. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. sommer requested review of this revision. REVISION SUMMARY Hi. Here I propose an updated syntax

Re: New Framework Review: KDAV

2020-02-16 Thread Andreas Cord-Landwehr
On Sonntag, 16. Februar 2020 10:29:42 CET Volker Krause wrote: > On Saturday, 15 February 2020 11:42:57 CET Andreas Cord-Landwehr wrote: > > Hi, sorry for this very late mail, missed the call for reviews... > > > > Would it be possible to do some license clarifications before moving kdav > > into

D26519: Show button respecting what is declared by KCModule

2020-02-16 Thread Wolfgang Bauer
wbauer added a comment. This change causes kontact to crash when opening its settings: https://bugs.kde.org/show_bug.cgi?id=417396 REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D26519 To: bport, ervin, meven, crossi, davidedmundson Cc: wbauer,

D27434: Improve readme

2020-02-16 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added reviewers: Frameworks, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Add a basic description including the supported platforms,

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 432 - Unstable!

2020-02-16 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/432/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 16 Feb 2020 16:19:55 + Build duration: 19 min and counting BUILD ARTIFACTS

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

2020-02-16 Thread David Faure
dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Well, I'm not the KConfig maintainer, mdawson is :-) INLINE COMMENTS > kcoreconfigskeleton.h:89 > + */ > +void setGroup(const KConfigGroup ); > + Missing @since 5.68 >

D26519: Show button respecting what is declared by KCModule

2020-02-16 Thread Wolfgang Bauer
wbauer added inline comments. INLINE COMMENTS > kcmultidialog.cpp:184 > > +auto buttons = activeModule->buttons(); > + `activeModule` can be a nullptr here, as this is outside/after the `if (activeModule)`. This causes the kontact crash. Possible fix: D27433

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

2020-02-16 Thread Kevin Ottens
ervin added inline comments. INLINE COMMENTS > dfaure wrote in kcoreconfigskeleton.h:448 > So this KF6 TODO is to make those methods virtual? It's a bit unclear to me... > > I'm asking because: if the solution is something else then maybe it can be > done already for those new methods. That's

D24401: Use exposed DBus methods to switch activities in CLI

2020-02-16 Thread Christian Muehlhaeuser
This revision was automatically updated to reflect the committed changes. Closed by commit R6:a1c973c01ece: Use exposed DBus methods to switch activities in CLI (authored by muesli). REPOSITORY R6 KActivities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24401?vs=67281=75776

D27223: add kirigami-gallery icon

2020-02-16 Thread Carl Schwan
ognarb added a comment. In D27223#612284 , @mbruchert wrote: > I have no Idea why the diff deletes the ktrip icon. > unfortunately I cant fix that because I have no Idea how to do that with git. You can try to execute this git

D27419: Update Japanese holidays

2020-02-16 Thread Luigi Toscano
ltoscano added a comment. Please revert and commit it with the correct authorship. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D27419 To: nhiga, dvratil, winterz, cgiboudeaux Cc: ltoscano, aacid, #kde_pim, kde-frameworks-devel, LeGast00n, cblack, fbampaloukas,

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 307 - Unstable!

2020-02-16 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/307/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sun, 16 Feb 2020 16:19:55 + Build duration: 15 min and counting BUILD ARTIFACTS

Re: 2 kirigami fixes for a point release

2020-02-16 Thread Ben Cooksley
On Sun, Feb 16, 2020 at 8:35 AM Nate Graham wrote: > > On 2020-02-15 11:55, Ben Cooksley wrote: > > My point above was that the version you decide to freeze on should > > only be the version you depend on during development. > > The version you depend on when you release will be the next release

D27433: Check activeModule before using it

2020-02-16 Thread Wolfgang Bauer
wbauer created this revision. wbauer added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. wbauer requested review of this revision. REVISION SUMMARY `activeModule` can be a nullptr here, as this is outside/after the `if

D27433: Check activeModule before using it

2020-02-16 Thread Kevin Ottens
ervin accepted this revision. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D27433 To: wbauer, #frameworks, davidedmundson, ervin Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27223: add kirigami-gallery icon

2020-02-16 Thread Mathis Brüchert
mbruchert updated this revision to Diff 75772. mbruchert added a comment. - fix issues REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27223?vs=75771=75772 BRANCH arcpatch-D27223 REVISION DETAIL https://phabricator.kde.org/D27223 AFFECTED FILES

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.13 - Build # 200 - Failure!

2020-02-16 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.13/200/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sun, 16 Feb 2020 17:20:01 + Build duration: 26 sec and counting CONSOLE OUTPUT Started by an SCM

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.12 - Build # 347 - Failure!

2020-02-16 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/347/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 16 Feb 2020 17:20:01 + Build duration: 26 sec and counting CONSOLE OUTPUT Started by an SCM

KDE CI: Frameworks » kirigami » kf5-qt5 AndroidQt5.13 - Build # 194 - Failure!

2020-02-16 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20AndroidQt5.13/194/ Project: kf5-qt5 AndroidQt5.13 Date of build: Sun, 16 Feb 2020 17:20:01 + Build duration: 41 sec and counting CONSOLE OUTPUT Started by an

D27430: [PATCH] General update for CartoCSS syntax highlighting

2020-02-16 Thread Lukas Sommer
sommer added a reviewer: Framework: Syntax Highlighting. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D27430 To: sommer, #framework_syntax_highlighting Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, gennad, GB_2, bmortimer, domson,

Re: New Framework Review: KDAV

2020-02-16 Thread Volker Krause
On Saturday, 15 February 2020 11:42:57 CET Andreas Cord-Landwehr wrote: > Hi, sorry for this very late mail, missed the call for reviews... > > Would it be possible to do some license clarifications before moving kdav > into the frameworks section? > > In mostly all files it is not clear if the

D27433: Check activeModule before using it

2020-02-16 Thread Wolfgang Bauer
wbauer edited the summary of this revision. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D27433 To: wbauer, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27434: Improve readme

2020-02-16 Thread Carl Schwan
ognarb added a comment. Maybe you could also mention the license and the maintainers in the README? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D27434 To: nicolasfella, #frameworks, broulik Cc: ognarb, kde-frameworks-devel, LeGast00n, cblack, GB_2,

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 299 - Still Unstable!

2020-02-16 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/299/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 16 Feb 2020 16:19:55 + Build duration: 13 min and counting JUnit Tests Name: projectroot

D27433: Check activeModule before using it

2020-02-16 Thread Wolfgang Bauer
wbauer closed this revision. wbauer added a comment. Committed with https://commits.kde.org/kcmutils/ea7120ed901bf6161bb483ab73211a6491daac8f REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D27433 To: wbauer, #frameworks, davidedmundson, ervin Cc:

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.13 - Build # 201 - Failure!

2020-02-16 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.13/201/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sun, 16 Feb 2020 18:02:46 + Build duration: 3 min 24 sec and counting CONSOLE OUTPUT Started by

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.12 - Build # 348 - Failure!

2020-02-16 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/348/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 16 Feb 2020 18:02:44 + Build duration: 3 min 27 sec and counting CONSOLE OUTPUT Started by

D26918: Improve KNotification API docs

2020-02-16 Thread Nicolas Fella
nicolasfella added inline comments. INLINE COMMENTS > apol wrote in knotification.h:44 > This entirely changes the semantics. Might still be correct but it could make > sense to make sure that's the case? > At least, for an action the user triggers should still be a feedback event, > right? I

D27444: Added top area

2020-02-16 Thread Niccolò Venerandi
niccolove added a dependent revision: D27189: Created a top area based on widgets/toparea.svg. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27444 To: niccolove, #vdg, ngraham, ndavis Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

2020-02-16 Thread Niccolò Venerandi
niccolove edited the summary of this revision. niccolove added dependencies: D27189: Created a top area based on widgets/toparea.svg, D27439: Replaced isDock check with !hasDecoration. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To:

Re: 2 kirigami fixes for a point release

2020-02-16 Thread David Faure
On dimanche 16 février 2020 22:17:17 CET Albert Astals Cid wrote: > This is their fault, they as a distribution have decided to support a random > KDE Frameworks version for longer than we do support it, so they are the > ones that should be the job of supporting it. > > It's like you are trying

D27444: Added top area

2020-02-16 Thread Nathaniel Graham
ngraham added inline comments. INLINE COMMENTS > toparea.svg:727 > + id="rect4138-7" > + > style="color:#eff0f1;opacity:0.75;fill:currentColor;fill-opacity:0.6;stroke:none" > /> > + Are these supposed to have hardcoded colors? REPOSITORY R242 Plasma Framework (Library)

D27444: Added top area

2020-02-16 Thread Nathaniel Graham
ngraham added a comment. This will need CMake changes to actually install it. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27444 To: niccolove, #vdg, ngraham, ndavis Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27445: Move tasks from 3px to 2px

2020-02-16 Thread Noah Davis
ndavis added a comment. I don't think it's really worth it to do this patch for the same reasons as Nate. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27445 To: niccolove, #vdg Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack,

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

2020-02-16 Thread Niccolò Venerandi
niccolove updated this revision to Diff 75787. niccolove added a comment. Make the panel always as transparent as the dialogs REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27122?vs=75786=75787 BRANCH contrast_effect_background_color

D27444: Added top area

2020-02-16 Thread Niccolò Venerandi
niccolove created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. niccolove requested review of this revision. REVISION SUMMARY Adds top area for D27189 REPOSITORY R242 Plasma Framework (Library) BRANCH

D27444: Added top area

2020-02-16 Thread Niccolò Venerandi
niccolove added reviewers: VDG, ngraham, ndavis. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27444 To: niccolove, #vdg, ngraham, ndavis Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27445: Move tasks from 3px to 2px

2020-02-16 Thread Niccolò Venerandi
niccolove updated this revision to Diff 75798. niccolove added a comment. Used scour REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27445?vs=75797=75798 BRANCH 2px_tasks (branched from master) REVISION DETAIL

D26918: Improve KNotification API docs

2020-02-16 Thread Nicolas Fella
nicolasfella added inline comments. INLINE COMMENTS > apol wrote in knotification.h:58 > It could make sense to specify the cmake syntax to do that? > > `install(FILES appname.notifyrc DESTINATION ${KNOTIFYRC_INSTALL_DIR})` Don't we have that already below? REPOSITORY R289 KNotifications

D27445: Move tasks from 3px to 2px

2020-02-16 Thread Niccolò Venerandi
niccolove requested review of this revision. niccolove added a comment. Nope, that does not work. Let's stick to 2px. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27445 To: niccolove, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2,

D26918: Improve KNotification API docs

2020-02-16 Thread Aleix Pol Gonzalez
apol added a subscriber: class. apol added a comment. Let's do this. +1 INLINE COMMENTS > Mainpage.dox:9 > + > +KNotification is the main entry point for using KNotifications. > + @class so we create a link. REPOSITORY R289 KNotifications REVISION DETAIL

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

2020-02-16 Thread Niccolò Venerandi
niccolove updated this revision to Diff 75786. niccolove added a comment. - Merge branch 'master' into contrast_effect_background_color REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27122?vs=75277=75786 BRANCH

D26918: Improve KNotification API docs

2020-02-16 Thread Nicolas Fella
nicolasfella updated this revision to Diff 75795. nicolasfella added a comment. O - Add a dedicated main page and link to the HIG from there REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26918?vs=74362=75795 BRANCH docs REVISION DETAIL

D27445: Move tasks from 3px to 2px

2020-02-16 Thread Niccolò Venerandi
niccolove edited the summary of this revision. niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27445 To: niccolove Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

Re: 2 kirigami fixes for a point release

2020-02-16 Thread Albert Astals Cid
El dissabte, 15 de febrer de 2020, a les 20:35:23 CET, Nate Graham va escriure: > On 2020-02-15 11:55, Ben Cooksley wrote: > > My point above was that the version you decide to freeze on should > > only be the version you depend on during development. > > The version you depend on when you release

D27445: Move tasks from 3px to 2px

2020-02-16 Thread Nathaniel Graham
ngraham added a comment. Technical review: This patch has hardcoded colors in it. Gotta fix that. --- Visual review: F8107681: Screenshot_20200216_154612.png Personally I don't really see the point of it. This patch makes the line so

D27445: Move tasks from 3px to 2px

2020-02-16 Thread Noah Davis
ndavis added a comment. > This change is purely visual and I don't think that usability is affected. I personally find the 2px version prettier and more consistent with T11124 For the record, I use 3px lines in what I have done so far with that task.

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

2020-02-16 Thread Niccolò Venerandi
niccolove added a comment. Regarding maximized windows: I don't think it's possible to make the dialog and panel feel united in this case; windows has this problem as well: F8107248: image.png I'd say this is the expected behavior for a theme with

D27445: Move tasks from 3px to 2px

2020-02-16 Thread Niccolò Venerandi
niccolove added a reviewer: VDG. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27445 To: niccolove, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27445: Move tasks from 3px to 2px

2020-02-16 Thread Niccolò Venerandi
niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27445 To: niccolove, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27445: Move tasks from 3px to 2px

2020-02-16 Thread Niccolò Venerandi
niccolove planned changes to this revision. niccolove added a comment. I do prefer the 2px version, but I think a compromise would look best. I will try a 2.5px version, although I'm not sure how good .5 pixel are displayed. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D26918: Improve KNotification API docs

2020-02-16 Thread Nicolas Fella
nicolasfella updated this revision to Diff 75799. nicolasfella added a comment. - Move most content to main page REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26918?vs=75795=75799 BRANCH docs REVISION DETAIL https://phabricator.kde.org/D26918

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.12 - Build # 349 - Fixed!

2020-02-16 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/349/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 16 Feb 2020 21:42:48 + Build duration: 2 min 7 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.13 - Build # 202 - Fixed!

2020-02-16 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.13/202/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sun, 16 Feb 2020 21:43:38 + Build duration: 2 min 3 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kirigami » kf5-qt5 AndroidQt5.13 - Build # 196 - Fixed!

2020-02-16 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20AndroidQt5.13/196/ Project: kf5-qt5 AndroidQt5.13 Date of build: Sun, 16 Feb 2020 21:43:40 + Build duration: 48 sec and counting

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

2020-02-16 Thread Niccolò Venerandi
niccolove edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove, ndavis, ngraham, cblack Cc: cblack, ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, manueljlin, Orage, LeGast00n,

D26918: Improve KNotification API docs

2020-02-16 Thread Nicolas Fella
nicolasfella added a task: T12709: Improvements for KNotifications documentation/guidelines. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D26918 To: nicolasfella, #frameworks, broulik, jucato Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

KDE CI: Frameworks » kirigami » kf5-qt5 AndroidQt5.13 - Build # 195 - Failure!

2020-02-16 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20AndroidQt5.13/195/ Project: kf5-qt5 AndroidQt5.13 Date of build: Sun, 16 Feb 2020 18:02:28 + Build duration: 3 min 42 sec and counting CONSOLE OUTPUT Started

Re: 2 kirigami fixes for a point release

2020-02-16 Thread Nate Graham
On 2020-02-15 11:55, Ben Cooksley wrote: My point above was that the version you decide to freeze on should only be the version you depend on during development. The version you depend on when you release will be the next release of Frameworks (so by freezing on 5.66 for development, it should

D27445: Move tasks from 3px to 2px

2020-02-16 Thread Niccolò Venerandi
niccolove created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. niccolove requested review of this revision. REVISION SUMMARY *gimme a sec* REPOSITORY R242 Plasma Framework (Library) BRANCH 2px_tasks (branched from master) REVISION

Re: 2 kirigami fixes for a point release

2020-02-16 Thread Albert Astals Cid
El diumenge, 16 de febrer de 2020, a les 22:34:51 CET, David Faure va escriure: > On dimanche 16 février 2020 22:17:17 CET Albert Astals Cid wrote: > > This is their fault, they as a distribution have decided to support a random > > KDE Frameworks version for longer than we do support it, so they

Re: 2 kirigami fixes for a point release

2020-02-16 Thread Friedrich W. H. Kossebau
Sorry, no time to rewrite to make this short. Am Mittwoch, 12. Februar 2020, 21:59:32 CET schrieb Nate Graham: > [+ frameworks and plasma mailing lists] > > On 2020-02-12 11:31, Albert Astals Cid wrote: > > El dimecres, 12 de febrer de 2020, a les 15:37:09 CET, Nate Graham va escriure: > >> On

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 433 - Still Unstable!

2020-02-16 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/433/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 17 Feb 2020 04:40:55 + Build duration: 17 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 300 - Still Unstable!

2020-02-16 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/300/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 17 Feb 2020 04:40:55 + Build duration: 9 min 10 sec and counting JUnit Tests Name:

D27327: Drop qmake pri file generation & installation, currently broken

2020-02-16 Thread Jan Grulich
jgrulich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R281 ModemManagerQt BRANCH dropbrokenprifile REVISION DETAIL https://phabricator.kde.org/D27327 To: kossebau, jgrulich Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27328: Drop qmake pri file generation & installation, currently broken

2020-02-16 Thread Jan Grulich
jgrulich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R282 NetworkManagerQt BRANCH dropbrokenprifile REVISION DETAIL https://phabricator.kde.org/D27328 To: kossebau, jgrulich Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 109 - Still Unstable!

2020-02-16 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/109/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 17 Feb 2020 01:56:55 + Build duration: 1 min 38 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.13 - Build # 114 - Fixed!

2020-02-16 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.13/114/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 17 Feb 2020 01:56:55 + Build duration: 3 min 26 sec and counting BUILD ARTIFACTS

D26918: Improve KNotification API docs

2020-02-16 Thread Juan Carlos Torres
jucato added inline comments. INLINE COMMENTS > knotification.h:96 > - * > - * The icon filename is just the name, without extension, it's found with > the KIconLoader. > - * The Comment field will be used in KControl to describe the application. Maybe we should keep this part that the

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 308 - Still Unstable!

2020-02-16 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/308/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 17 Feb 2020 04:40:55 + Build duration: 8 min 24 sec and counting BUILD ARTIFACTS

Re: 2 kirigami fixes for a point release

2020-02-16 Thread David Edmundson
> My point above was that the version you decide to freeze on should > only be the version you depend on during development. > The version you depend on when you release will be the next release of > Frameworks (so by freezing on 5.66 for development, it should have had > a release-day dependency

D27419: Update Japanese holidays

2020-02-16 Thread Luigi Toscano
ltoscano added a comment. Just did it: https://commits.kde.org/kholidays/263bc0f2d601bcf9a5d3632f8535e0bbd8f50255 REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D27419 To: nhiga, dvratil, winterz, cgiboudeaux Cc: ltoscano, aacid, #kde_pim, kde-frameworks-devel,

Re: 2 kirigami fixes for a point release

2020-02-16 Thread Ben Cooksley
On Mon, Feb 17, 2020 at 4:42 AM David Edmundson wrote: > > > My point above was that the version you decide to freeze on should > > only be the version you depend on during development. > > The version you depend on when you release will be the next release of > > Frameworks (so by freezing on