Re: Fixing QNetworkAccessManager use

On Thu, Feb 20, 2020 at 9:58 AM Friedrich W. H. Kossebau wrote: > > Am Mittwoch, 19. Februar 2020, 21:01:20 CET schrieb Johan Ouwerkerk: > > On Wed, Feb 19, 2020 at 2:09 PM Friedrich W. H. Kossebau > > > > wrote: > > > Personally I am still unsure what the actual issue is. Why are redirects > >

D27152: Introduce FilesystemEntry class

hallas added inline comments. INLINE COMMENTS > meven wrote in filesystem_entry.cpp:47 > This sound sane to me. > Ideally we would store only the string in case of an unknown fs or the enum > but not both for a same entry, the choice could be done in ctor. I have added a new enum class type

D27504: WIP: RFC: smb faster copy to local

hallas added inline comments. INLINE COMMENTS > anthonyfieroni wrote in kio_smb_dir.cpp:49 > Segment does not free its memory. Why not use QByteArray or similar with > automatic storage allocation? Yes, you could (and should ;) ) use standard C++ for this, i.e.: std::unique_ptr buf; buf =

D27464: Add application menu dbus paths to org_kde_plasma_window interface

cblack marked an inline comment as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D27464 To: cblack, #kwin, zzag Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27464: Add application menu dbus paths to org_kde_plasma_window interface

cblack updated this revision to Diff 76035. cblack added a comment. Use utf8 encoding on client side REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27464?vs=75855=76035 BRANCH cblack/appmenu-listener REVISION DETAIL

D27464: Add application menu dbus paths to org_kde_plasma_window interface

davidedmundson added a comment. Good start. The direction makes sense. display.cpp and registry.cpp need updating to the new version number. Otherwise we won't be able to use this new method. It'd be great if you could update the unit test too. INLINE COMMENTS >

Re: Fixing QNetworkAccessManager use

On Wed, Feb 19, 2020 at 2:09 PM Friedrich W. H. Kossebau wrote: > > Personally I am still unsure what the actual issue is. Why are redirects > needed at all. Why all the address changes all the time? > It is part of the HTTP spec for servers to be able to inform clients that resource /foo/bar

D27514: Fix incorrect use of case statements in accountmodel.cpp

bero created this revision. bero added a reviewer: Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bero requested review of this revision. REVISION SUMMARY Building user-manager 5.18.1 with clang++ 10.0 resulted in 2 compiler warnings - a quick look at the

D27514: Fix incorrect use of case statements in accountmodel.cpp

bero edited reviewers, added: Plasma; removed: Frameworks. REPOSITORY R128 User Manager REVISION DETAIL https://phabricator.kde.org/D27514 To: bero, #plasma, #frameworks Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot,

D26769: Always strip html if server does not support it

This revision was automatically updated to reflect the committed changes. Closed by commit R289:994f88929a83: Always strip html if server does not support it (authored by nicolasfella). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE

Re: Banning QNetworkAccessManager

El dimecres, 19 de febrer de 2020, a les 9:28:22 CET, Volker Krause va escriure: > Additionally, improved documentation, a possible KNAM and/or driving the QNAM > changes upstream can still be done alongside this obviously. Also for Qt5 which will probably never be changed a clazy warning and

Re: Banning QNetworkAccessManager

El dimecres, 19 de febrer de 2020, a les 8:05:01 CET, Ben Cooksley va escriure: > The easiest path forward is to simply ban QNetworkAccessManager. Stop saying that, that's not going to happen. Cheers, Albert > > > > > Regards, > > Volker > > Regards, > Ben >

Re: Fixing QNetworkAccessManager use

Am Mittwoch, 19. Februar 2020, 21:01:20 CET schrieb Johan Ouwerkerk: > On Wed, Feb 19, 2020 at 2:09 PM Friedrich W. H. Kossebau > > wrote: > > Personally I am still unsure what the actual issue is. Why are redirects > > needed at all. Why all the address changes all the time? > > It is part of

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

cfeck accepted this revision. cfeck added a comment. Merci :) REPOSITORY R236 KWidgetsAddons BRANCH no-css (branched from master) REVISION DETAIL https://phabricator.kde.org/D27035 To: davidre, #frameworks, ngraham, cfeck Cc: cfeck, dhaumann, ngraham, kde-frameworks-devel, LeGast00n,

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.13 - Build # 184 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.13/184/ Project: kf5-qt5 SUSEQt5.13 Date of build: Wed, 19 Feb 2020 19:29:31 + Build duration: 9 min 3 sec and counting BUILD ARTIFACTS

D27512: README.md: fix example code & code markup

This revision was automatically updated to reflect the committed changes. Closed by commit R39:8630da5fa573: README.md: fix example code code markup (authored by kossebau). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27512?vs=76019=76021 REVISION

D27512: README.md: fix example code & code markup

cullmann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R39 KTextEditor BRANCH fixreadme REVISION DETAIL https://phabricator.kde.org/D27512 To: kossebau, #kate, cullmann Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, domson,

D27512: README.md: fix example code & code markup

kossebau created this revision. kossebau added a reviewer: Kate. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. kossebau requested review of this revision. REVISION SUMMARY - scope examples with ``` and code type - serviceByDesktopName

D27504: WIP: RFC: smb faster copy to local

anthonyfieroni added inline comments. INLINE COMMENTS > kio_smb_dir.cpp:49 > +: segmentSize(static_cast(segmentSize_)) // won't be <0 > +, buf(static_cast(malloc(segmentSize))) > +{ Segment does not free its memory. Why not use QByteArray or similar with automatic storage

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

davidre updated this revision to Diff 76018. davidre marked 4 inline comments as done. davidre added a comment. Code style and typos REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27035?vs=75717=76018 BRANCH no-css (branched from master)

D27083: [PC2]Give Label integer width.

davidedmundson added a comment. > In my opinion the Plasma Controls need fix I would approve that. Though let's be sure to focus on components3. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27083 To: gvgeo, #plasma, #vdg, ndavis,

D27083: [PC2]Give Label integer width.

ngraham added a comment. Probably `frameworks-plasma | components` REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27083 To: gvgeo, #plasma, #vdg, ndavis, davidedmundson Cc: ngraham, davidedmundson, kde-frameworks-devel, Orage, LeGast00n,

D27083: [PC2]Give Label integer width.

gvgeo added a comment. In D27083#614285 , @ngraham wrote: > So the test needs to be fixed? In my opinion the Plasma Controls need fix. They need to always display the icons in an real position, no matter what their x position is. Just

D27508: Remove unnecessary monochrome app icons

ngraham created this revision. ngraham added reviewers: VDG, ndavis. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY This is a continuation of the ongoing issue we have in reliably making icons

D27508: Remove unnecessary monochrome app icons

ngraham edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27508 To: ngraham, #vdg, ndavis Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27504: WIP: RFC: smb faster copy to local

ngraham added a comment. Yep I'm seeing pretty much double speed here. Amazing. This code is above my pay grade, so I won't try to review it. :) But the patch works as described! REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27504 To: sitter, ngraham,

D27296: [PlasmaComponents]Clean up ListItem code

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D27296 To: gvgeo, #plasma, ngraham Cc: kde-frameworks-devel, LeGast00n, cblack,

D27083: [PC2]Give Label integer width.

ngraham added a comment. So the test needs to be fixed? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27083 To: gvgeo, #plasma, #vdg, ndavis, davidedmundson Cc: ngraham, davidedmundson, kde-frameworks-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D27460: fix layout size hints for button labels

ngraham added a comment. This patch also does not fix the media controller buttons' icon sizes, so D27449 is still needed. :/ REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27460 To: mart, #plasma,

D27460: fix layout size hints for button labels

ngraham added a comment. The System Tray's pin button now looks like this for me: F8112931: Screenshot_20200219_083903.png REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27460 To: mart, #plasma,

D27504: WIP: RFC: smb faster copy to local

sitter added inline comments. INLINE COMMENTS > kio_smb_dir.cpp:88 > +const off_t idealSegmentSize = qMin(fileSize / 50, > +4L * 1024 * 1024 /* 4 MiB */); > +segmentSize = qMax(segmentSize, This may actually be too optimistic. If you

D27504: WIP: RFC: smb faster copy to local

sitter created this revision. sitter added reviewers: ngraham, cfeck. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY see https://bugs.kde.org/show_bug.cgi?id=291835#c57 for

D27502: Create ConfigView an unmanaged ConfigWidget

meven edited the summary of this revision. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D27502 To: bport, #plasma, ervin, crossi, meven Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27502: Create ConfigView an unmanaged ConfigWidget

bport added a dependent revision: D27503: [KCM Spellchecking] port to KPropertySkeletonItem. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D27502 To: bport, #plasma, ervin, crossi, meven Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27502: Create ConfigView an unmanaged ConfigWidget

bport created this revision. bport added reviewers: Plasma, ervin, crossi, meven. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bport requested review of this revision. REVISION SUMMARY - Allow to manage controller externally - Compatible (for checkbox)

D27334: Fix pri file: have qmake name of QtGui as dep, do not fail with CamelCase includes

kossebau closed this revision. kossebau added a comment. Pushed as eaab60ebc9835e0df5fc0c397dc72002a8870218 & 0817e21427218cbb0fcff772f00b5d3e0e851939

D27496: Fix isImmutable generated property

This revision was automatically updated to reflect the committed changes. Closed by commit R237:55aaa712b75b: Fix isPropertyNameImmutable generated property (authored by meven). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27496?vs=75974=75995 REVISION

Re: Fixing QNetworkAccessManager use

Am Mittwoch, 19. Februar 2020, 08:05:01 CET schrieb Ben Cooksley: > On Mon, Feb 3, 2020 at 7:42 AM Volker Krause wrote: > > It would also help to know where specifically we have that problem, so we > > can actually solve it, and so we can figure out why we failed to fix this > > there earlier. >

Re: Banning QNetworkAccessManager

Hi, as Volker said, without any alternative, we can't just ban QNAM. And even with one, we would need time to implement it (for example, for GCompris, this part of the code was written by someone who is less active now, so rewriting it, testing it and be sure it works will take some time). Can't

D27497: Fix code generation for entries with min/max

hchain updated this revision to Diff 75987. hchain added a comment. Add reference files for other tests that were impacted REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27497?vs=75985=75987 REVISION DETAIL https://phabricator.kde.org/D27497 AFFECTED

D27497: Fix code generation for entries with min/max

hchain updated this revision to Diff 75985. hchain added a comment. Reduce number of lines in generated test code REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27497?vs=75983=75985 REVISION DETAIL https://phabricator.kde.org/D27497 AFFECTED FILES

D27496: Fix isImmutable generated property

crossi accepted this revision. REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D27496 To: meven, hchain, ervin, bport, crossi, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27497: Fix code generation for entries with min/max

hchain updated this revision to Diff 75983. hchain added a comment. Yet more style fixes REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27497?vs=75982=75983 REVISION DETAIL https://phabricator.kde.org/D27497 AFFECTED FILES

D27497: Fix code generation for entries with min/max

hchain updated this revision to Diff 75982. hchain added a comment. Fix Style/whitespace REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27497?vs=75978=75982 REVISION DETAIL https://phabricator.kde.org/D27497 AFFECTED FILES

D27296: [PlasmaComponents]Clean up ListItem code

gvgeo added a comment. The 2 removed lines were leftovers from 54e87fe879ba . REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27296 To: gvgeo, #plasma Cc:

D27497: Fix code generation for entries with min/max

bport added inline comments. INLINE COMMENTS > test_param_minmax.kcfg:17 > + > \ No newline at end of file Add a new line > test_param_minmax.kcfgc:4 > +Mutators=true > \ No newline at end of file add a new line > test_param_minmax_main.cpp:28 > +return 0; > +} Missing new line at end

D27496: Fix isImmutable generated property

hchain accepted this revision. hchain added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D27496 To: meven, hchain, ervin, bport, crossi, #frameworks Cc: kde-frameworks-devel,

D27497: Fix code generation for entries with min/max

hchain created this revision. hchain added reviewers: meven, crossi, ervin, bport, tcanabrava. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. hchain requested review of this revision. REVISION SUMMARY - When GenerateProperties and Mutators are activated,

D27083: [PC2]Give Label integer width.

gvgeo abandoned this revision. gvgeo added a comment. The problem is with controls, not with label. QtQuick controls work fine. problem F8112471: Screenshot_20200219_124506.png F8112472: Screenshot_20200219_124602.png

D27460: fix layout size hints for button labels

This revision was automatically updated to reflect the committed changes. Closed by commit R242:ba0b637de94a: fix layout size hints for button labels (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27460?vs=75976=75977

D27460: fix layout size hints for button labels

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH phab/buttonslayout REVISION DETAIL https://phabricator.kde.org/D27460 To: mart, #plasma, davidedmundson Cc: davidedmundson, kde-frameworks-devel,

D27460: fix layout size hints for button labels

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in Button.qml:62 > I don't understand this part about constraining the width to the parent > height (for all 3) > > If I remove it all the tests still pass. was an extra constraint to have buttons always square, but i added

D27460: fix layout size hints for button labels

mart updated this revision to Diff 75976. mart marked an inline comment as done. mart added a comment. - remove extra check for squareness REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27460?vs=75972=75976 BRANCH phab/buttonslayout

D27496: Fix isImmutable generated property

meven created this revision. meven added reviewers: hchain, ervin, bport, crossi, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Relates to D26368

D27460: fix layout size hints for button labels

davidedmundson added inline comments. INLINE COMMENTS > Button.qml:62 > +Layout.minimumHeight: units.iconSizes.tiny > +Layout.maximumWidth: Math.min(parent.height, control.icon.width > > 0 ? control.icon.width : units.iconSizes.small) > +Layout.maximumHeight:

D27460: fix layout size hints for button labels

mart marked an inline comment as done. mart added inline comments. INLINE COMMENTS > davidedmundson wrote in button3.qml:90 > You didn't even run this :( > > 1. icon.name not icon.source > 2. now the comment next to it is wrong > 3. there's a binding loop > > 4. if I make a test without any

D27460: fix layout size hints for button labels

mart updated this revision to Diff 75972. mart marked an inline comment as done. mart added a comment. - fix button display property - add a test for tabbar REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27460?vs=75927=75972 BRANCH

D27463: KconfigXT: Add a value attribute to Enum field choices

meven updated this revision to Diff 75969. meven added a comment. Add a since to dox REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27463?vs=75968=75969 BRANCH arcpatch-D27463 REVISION DETAIL https://phabricator.kde.org/D27463 AFFECTED FILES

D27463: KconfigXT: Add a value attribute to Enum field choices

meven updated this revision to Diff 75968. meven added a comment. Add documentation about value in dox REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27463?vs=75967=75968 BRANCH arcpatch-D27463 REVISION DETAIL https://phabricator.kde.org/D27463

Re: Banning QNetworkAccessManager

On Wed, Feb 19, 2020 at 9:30 PM Volker Krause wrote: > > On Wednesday, 19 February 2020 08:05:01 CET Ben Cooksley wrote: > > On Mon, Feb 3, 2020 at 7:42 AM Volker Krause wrote: > > > I agree on the problem of QNAM's default, see also > > > https://conf.kde.org/en/ > > >

D27463: KconfigXT: Add a value attribute to Enum field choices

meven added a comment. In D27463#613961 , @davidre wrote: > Could you also add documentation to whatever https://api.kde.org/frameworks/kconfig/html/kconfig_compiler.html is generated from? Thanks for pointing it out. I meant to

D27463: KconfigXT: Add a value attribute to Enum field choices

davidre added a comment. Could you also add documentation to whatever https://api.kde.org/frameworks/kconfig/html/kconfig_compiler.html is generated from? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27463 To: meven, ervin, bport, crossi, #frameworks Cc:

D27463: KconfigXT: Add a value attribute to Enum field choices

meven updated this revision to Diff 75967. meven added a comment. Ignore empty value attribute for choice REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27463?vs=75966=75967 BRANCH arcpatch-D27463 REVISION DETAIL https://phabricator.kde.org/D27463

D27463: KconfigXT: Add a value attribute to Enum field choices

meven updated this revision to Diff 75966. meven added a comment. Default value must refere to the choice name REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27463?vs=75964=75966 BRANCH arcpatch-D27463 REVISION DETAIL

Re: Banning QNetworkAccessManager

On Wednesday, 19 February 2020 08:05:01 CET Ben Cooksley wrote: > On Mon, Feb 3, 2020 at 7:42 AM Volker Krause wrote: > > I agree on the problem of QNAM's default, see also > > https://conf.kde.org/en/ > > akademy2019/public/events/135 on that subject. > > > > On Saturday, 1 February 2020

D27463: KconfigXT: Add a value attribute to Enum field choices

meven updated this revision to Diff 75964. meven marked 2 inline comments as done. meven added a comment. Clean garbage files REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27463?vs=75917=75964 BRANCH arcpatch-D27463 REVISION DETAIL