KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 439 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/439/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 23 Feb 2020 04:37:03 +
 Build duration:
13 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.68.0.xmllogs/KF5KIO/5.68.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiofilewidgets_knewfilemenutestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(270/406)67%
(270/406)56%
(34805/62087)40%
(17686/43854)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9732/10191)47%
(4545/9638)autotests.http100%
(5/5)100%
(5/5)99%
(580/581)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(104/118)88%
(104/118)60%
(8716/14614)51%
(4506/8833)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4666/8327)43%
(2072/4812)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(680/1269)39%
(390/1000)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(645/1372)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4288)36%
(1309/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(632/1331)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
   

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 305 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/305/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 23 Feb 2020 04:37:03 +
 Build duration:
9 min 0 sec and counting
   JUnit Tests
  Name: projectroot Failed: 5 test(s), Passed: 47 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiofilewidgets_knewfilemenutestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 314 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/314/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sun, 23 Feb 2020 04:37:03 +
 Build duration:
6 min 25 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.68.0.xmllogs/KF5KIO/5.68.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiofilewidgets_knewfilemenutestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(270/406)67%
(270/406)56%
(34850/62090)40%
(17715/43850)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9732/10191)47%
(4551/9638)autotests.http100%
(5/5)100%
(5/5)99%
(580/581)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(104/118)88%
(104/118)60%
(8751/14616)51%
(4526/8833)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4666/8327)43%
(2070/4808)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(680/1269)39%
(390/1000)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(645/1372)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1806/4289)36%
(1312/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(632/1331)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
 

D27589: Try to apply the colorscheme of the current theme to QIcons

[Wolfgang Bauer]

wbauer added a comment.


  Sounds like it would fix https://bugs.kde.org/show_bug.cgi?id=417780 ?

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  qiconcolor (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27589

To: davidre, #plasma, cblack
Cc: wbauer, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D27038: [KMessageWidget] Allow the style to change our palette

[Aleix Pol Gonzalez]

apol added a comment.


  But then now we are not refreshing the palette when it changes outside, no?
  
  How about adding a boolean value when it's already happening to prevent the 
infinite recursion?

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D27038

To: davidre, #frameworks
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 313 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/313/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sat, 22 Feb 2020 22:23:32 +
 Build duration:
30 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.68.0.xmllogs/KF5KIO/5.68.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiofilewidgets_knewfilemenutestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(270/406)67%
(270/406)56%
(34801/62086)40%
(17687/43850)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9732/10191)47%
(4549/9638)autotests.http100%
(5/5)100%
(5/5)99%
(580/581)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(104/118)88%
(104/118)60%
(8717/14614)51%
(4508/8833)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4666/8327)43%
(2070/4808)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(680/1269)39%
(390/1000)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(645/1372)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4288)36%
(1309/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(632/1331)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
   

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.13 - Build # 64 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.13/64/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sat, 22 Feb 2020 22:23:28 +
 Build duration:
28 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 19 test(s)Failed: projectroot.tests.ECMPoQmToolsTestName: projectroot.tests Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 61 test(s)Name: projectroot.tests.ECMAddTests Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  Cobertura Coverage Report

D27589: Try to apply the colorscheme of the current theme to QIcons

[Carson Black]

cblack accepted this revision.
cblack added a comment.
This revision is now accepted and ready to land.


  Patch works as advertised and the code LGTM.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  qiconcolor (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27589

To: davidre, #plasma, cblack
Cc: cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27589: Try to apply the colorscheme of the current theme to QIcons

[David Redondo]

davidre edited the test plan for this revision.
davidre added a reviewer: Plasma.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27589

To: davidre, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27589: Try to apply the colorscheme of the current theme to QIcons

[David Redondo]

davidre created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidre requested review of this revision.

REVISION SUMMARY
  Before icons loaded internally with QIcon::fromTheme were being colored with 
the
  colors from the current global color scheme instead of the ones from the 
current
  Plasma Theme. Leading to visual bugs when the two differ. This happened 
because
  KIconLoader uses the global color scheme by default.
  A prominent case is the notification send by the network plasmoid when one
  successfully connected to a wireless network. It sets the icon
  "network-wireless-on" which is not included in Breeze icons (but is included 
in
  Breeze Plasma Theme). If the current icon theme is indeed Breeze, IconItem
  resorts to using QIcon::fromTheme and we end up with a wrong colored
  "network-wireless" icon.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  qiconcolor (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27589

AFFECTED FILES
  src/declarativeimports/core/CMakeLists.txt
  src/declarativeimports/core/iconitem.cpp

To: davidre
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27588: templates: Convert license statements to SPDX headers

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: cordlandwehr, broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REPOSITORY
  R308 KRunner

BRANCH
  spdxlicensefortemplate

REVISION DETAIL
  https://phabricator.kde.org/D27588

AFFECTED FILES
  templates/runner/LICENSES/LGPL-2.1-or-later.txt
  templates/runner/src/%{APPNAMELC}.cpp
  templates/runner/src/%{APPNAMELC}.h

To: kossebau, cordlandwehr, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27587: templates: Convert license statements to SPDX headers

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Kate, cordlandwehr.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
kossebau requested review of this revision.

REPOSITORY
  R39 KTextEditor

BRANCH
  spdxlicensefortemplate

REVISION DETAIL
  https://phabricator.kde.org/D27587

AFFECTED FILES
  templates/ktexteditor-plugin/LICENSES/GPL-2.0-or-later.txt
  templates/ktexteditor-plugin/src/%{APPNAMELC}plugin.cpp
  templates/ktexteditor-plugin/src/%{APPNAMELC}plugin.h
  templates/ktexteditor-plugin/src/%{APPNAMELC}view.cpp
  templates/ktexteditor-plugin/src/%{APPNAMELC}view.h

To: kossebau, #kate, cordlandwehr
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D27586: templates: Convert license statements to SPDX headers

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: cordlandwehr, dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REPOSITORY
  R306 KParts

BRANCH
  spdxlicensefortemplate

REVISION DETAIL
  https://phabricator.kde.org/D27586

AFFECTED FILES
  templates/kpartsapp/LICENSES/GPL-2.0-or-later.txt
  templates/kpartsapp/src/part/%{APPNAMELC}part.cpp
  templates/kpartsapp/src/part/%{APPNAMELC}part.h
  templates/kpartsapp/src/shell/%{APPNAMELC}shell.cpp
  templates/kpartsapp/src/shell/%{APPNAMELC}shell.h
  templates/kpartsapp/src/shell/main.cpp

To: kossebau, cordlandwehr, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 312 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/312/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sat, 22 Feb 2020 11:36:09 +
 Build duration:
9 hr 47 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.68.0.xmllogs/KF5KIO/5.68.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiofilewidgets_knewfilemenutestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(270/406)67%
(270/406)56%
(34804/62087)40%
(17683/43850)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)96%
(9734/10191)47%
(4547/9638)autotests.http100%
(5/5)100%
(5/5)99%
(580/581)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(104/118)88%
(104/118)60%
(8726/14615)51%
(4515/8833)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4666/8327)43%
(2070/4808)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(680/1269)39%
(390/1000)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(645/1372)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1788/4288)36%
(1300/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(632/1331)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
  

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 438 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/438/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 22 Feb 2020 15:37:40 +
 Build duration:
5 hr 3 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.68.0.xmllogs/KF5KIO/5.68.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiofilewidgets_knewfilemenutestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(270/406)67%
(270/406)56%
(34849/62089)40%
(17702/43854)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9732/10191)47%
(4545/9638)autotests.http100%
(5/5)100%
(5/5)99%
(580/581)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(104/118)88%
(104/118)60%
(8755/14616)51%
(4520/8833)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4666/8327)43%
(2072/4812)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(680/1269)39%
(390/1000)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(645/1372)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1806/4289)36%
(1312/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(632/1331)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
   

D27573: Fix issue finding the Boost include directories

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R6:53d8ae317c6c: Fix issue finding the Boost include 
directories (authored by dalbers, committed by nicolasfella).

REPOSITORY
  R6 KActivities

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27573?vs=76168&id=76188

REVISION DETAIL
  https://phabricator.kde.org/D27573

AFFECTED FILES
  src/CMakeLists.txt

To: dalbers, #kactivities, nicolasfella
Cc: nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27557: Auto-generate 24px monochrome icons

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  After you rebase this, I'd say this patch is ready to go.

REPOSITORY
  R266 Breeze Icons

BRANCH
  autogenerate-24px-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27557

To: ngraham, #vdg, ndavis, #frameworks, sitter
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27557: Auto-generate 24px monochrome icons

[Noah Davis]

ndavis added a comment.


  I've added the icons that were only in actions/24 to actions/22.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27557

To: ngraham, #vdg, ndavis, #frameworks, sitter
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27557: Auto-generate 24px monochrome icons

[Noah Davis]

ndavis added a comment.


  I've fixed the 22px files that had height/width and viewbox set.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27557

To: ngraham, #vdg, ndavis, #frameworks, sitter
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27039: [KStyle] Set the color of KMessageWidgets to the correct one from the current color scheme

[Albert Astals Cid]

aacid added a comment.


  Any particular reason you added me?

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D27039

To: davidre, #frameworks, aacid
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.12 - Build # 98 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.12/98/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 22 Feb 2020 12:20:13 +
 Build duration:
3 hr 48 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 19 test(s)Failed: projectroot.tests.ECMPoQmToolsTestName: projectroot.tests Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 61 test(s)Name: projectroot.tests.ECMAddTests Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  Cobertura Coverage Report

D27580: Updates for CMake 3.17

[Alex Turbov]

turbov created this revision.
turbov added a reviewer: Framework: Syntax Highlighting.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
turbov requested review of this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D27580

AFFECTED FILES
  data/generators/cmake.xml.tpl
  data/generators/cmake.yaml
  data/syntax/cmake.xml

To: turbov, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 437 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/437/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 22 Feb 2020 11:36:07 +
 Build duration:
4 hr 1 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.68.0.xmllogs/KF5KIO/5.68.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiofilewidgets_knewfilemenutestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(270/406)67%
(270/406)56%
(34823/62088)40%
(17704/43854)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9732/10191)47%
(4551/9638)autotests.http100%
(5/5)100%
(5/5)99%
(580/581)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(104/118)88%
(104/118)60%
(8734/14615)51%
(4515/8833)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4666/8327)43%
(2072/4812)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(680/1269)39%
(390/1000)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(645/1372)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4288)36%
(1309/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(632/1331)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
   

D27039: [KStyle] Set the color of KMessageWidgets to the correct one from the current color scheme

[Anthony Fieroni]

anthonyfieroni added a reviewer: aacid.
anthonyfieroni added a comment.


  +1

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D27039

To: davidre, #frameworks, aacid
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27039: [KStyle] Set the color of KMessageWidgets to the correct one from the current color scheme

[David Redondo]

davidre added a comment.


  Ping

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D27039

To: davidre, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27038: [KMessageWidget] Allow the style to change our palette

[David Redondo]

davidre added a comment.


  Ping

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D27038

To: davidre, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

[David Redondo]

This revision was automatically updated to reflect the committed changes.
Closed by commit R236:835c64d1b693: [KMessageWidget] Draw it with QPainter 
instead of using stylesheet (authored by davidre).

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27035?vs=76018&id=76174

REVISION DETAIL
  https://phabricator.kde.org/D27035

AFFECTED FILES
  autotests/kmessagewidgetautotest.cpp
  src/kmessagewidget.cpp

To: davidre, #frameworks, ngraham, cfeck
Cc: apol, cfeck, dhaumann, ngraham, kde-frameworks-devel, LeGast00n, cblack, 
GB_2, michaelh, bruns

D27573: Fix issue finding the Boost include directories

[Daniel Albers]

dalbers added a comment.


  That'd be `dan...@lbe.rs`, thank you!
  I'll close the PR I mistakenly opened on GitHub.

REPOSITORY
  R6 KActivities

REVISION DETAIL
  https://phabricator.kde.org/D27573

To: dalbers, #kactivities, nicolasfella
Cc: nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27573: Fix issue finding the Boost include directories

[Nicolas Fella]

nicolasfella accepted this revision.
nicolasfella added a comment.
This revision is now accepted and ready to land.


  Thanks!
  
  Can you please give me your email address so I can merge this with the 
correct authorship information?

REPOSITORY
  R6 KActivities

REVISION DETAIL
  https://phabricator.kde.org/D27573

To: dalbers, #kactivities, nicolasfella
Cc: nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27573: Fix issue finding the Boost include directories

[Daniel Albers]

dalbers added a reviewer: KActivities.

REPOSITORY
  R6 KActivities

REVISION DETAIL
  https://phabricator.kde.org/D27573

To: dalbers, #kactivities
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27573: Fix issue finding the Boost include directories

[Daniel Albers]

dalbers created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dalbers requested review of this revision.

REVISION SUMMARY
  Replaces ${Boost_INCLUDE_DIR} with ${Boost_INCLUDE_DIRS}.

REPOSITORY
  R6 KActivities

REVISION DETAIL
  https://phabricator.kde.org/D27573

AFFECTED FILES
  src/CMakeLists.txt

To: dalbers
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 304 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/304/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 22 Feb 2020 11:36:09 +
 Build duration:
17 min and counting
   JUnit Tests
  Name: projectroot Failed: 5 test(s), Passed: 47 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiofilewidgets_knewfilemenutestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D27539: KIO::iconNameForUrl: fix searching for kde protocol icons

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:eb20176d1a42: KIO::iconNameForUrl: fix searching for kde 
protocol icons (authored by meven).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27539?vs=76156&id=76162

REVISION DETAIL
  https://phabricator.kde.org/D27539

AFFECTED FILES
  autotests/kfileitemtest.cpp
  src/core/global.cpp

To: meven, ngraham, #frameworks, dfaure, broulik, sitter
Cc: sitter, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27550: Support Qt 5.14 on Android

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R249:91c5e2ff604e: Support Qt 5.14 on Android (authored by 
vkrause).

REPOSITORY
  R249 KI18n

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27550?vs=76160&id=76161

REVISION DETAIL
  https://phabricator.kde.org/D27550

AFFECTED FILES
  src/kcatalog.cpp

To: vkrause, apol
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27363: KHolidays: Convert license statements to SPDX expressions

[Andreas Cord-Landwehr]

cordlandwehr marked 3 inline comments as done.
cordlandwehr added a comment.


  Did additional code digging in the Plan repository and I think that all 
stated copyright claims are valid.

INLINE COMMENTS

> cgiboudeaux wrote in holidayparserdriverplan.cpp:6-13
> The original text lacks clarity. Are these file contributors or copyright 
> holders? @winterz

the original code comes from Plan's holiday.c

- original author has obvious claim, since important code fragments remain
- additional code contributors are listed in original source for contribution 
specific functions each, thus have also a valid copyright claim

> cgiboudeaux wrote in holidayparserplan.ypp:3-10
> same question for this file

analyzed code history:

- original file comes from Plan's parser.y by Thomas Driemeyer
- IMO the changes for integrating into KOrganizer are above the limit of 
copyright, so I would (in case of doubt) prefer to state copyright explicitly
- the individual conversion commits are unfortunately buried deep in the 
disabled Reviewboard

> cordlandwehr wrote in holidayscannerplan.cpp:1297-1301
> @winterz same question here as above: are these people copyright holders or 
> file contributors?

this copyright statement comes from the .lpp file; thus to be discussed in that 
statement

> holidayscannerplan.lpp:2
>  /*
> -Original version from plan by Thomas Driemeyer 
> +Original version from plan:
> +SPDX-FileCopyrightText: Thomas Driemeyer 

analyzed the code history of this file:

- original copyright claim comes from Plan's parser.lex file
- the code was massively changed and rewritten, thus IMO all three additional 
claims to the original author are valid IMO.

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D27363

To: cordlandwehr
Cc: cgiboudeaux, winterz, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D27363: KHolidays: Convert license statements to SPDX expressions

[Andreas Cord-Landwehr]

cordlandwehr marked 2 inline comments as done.

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D27363

To: cordlandwehr
Cc: cgiboudeaux, winterz, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D27550: Support Qt 5.14 on Android

[Volker Krause]

vkrause updated this revision to Diff 76160.
vkrause added a comment.


  Improve compile-time conditional to only build the new code with Qt >= 5.14.

REPOSITORY
  R249 KI18n

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27550?vs=76117&id=76160

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27550

AFFECTED FILES
  src/kcatalog.cpp

To: vkrause, apol
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27533: [WIP] Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> kossebau wrote in kateviewhelpers.cpp:1963
> Possibly `QIcon::paint()` might be also working here as wanted? Needs someone 
> with HiDPI to check if all things behave as wanted. The old code with all the 
> `devicePixelRatioF()` made me change not too much here.

You should keep devicePixelRatioF calls

REPOSITORY
  R39 KTextEditor

BRANCH
  addmarkinterfacev2

REVISION DETAIL
  https://phabricator.kde.org/D27533

To: kossebau, #kate, #kdevelop, dhaumann
Cc: anthonyfieroni, dhaumann, kwrite-devel, kde-frameworks-devel, rrosch, 
LeGast00n, cblack, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, 
sars

D27539: KIO::iconNameForUrl: fix searching for kde protocol icons

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D27539

REVISION DETAIL
  https://phabricator.kde.org/D27539

To: meven, ngraham, #frameworks, dfaure, broulik, sitter
Cc: sitter, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27539: KIO::iconNameForUrl: fix searching for kde protocol icons

[Méven Car]

meven updated this revision to Diff 76156.
meven marked 2 inline comments as done.
meven added a comment.


  Improve comment, remove unnecessary check

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27539?vs=76148&id=76156

BRANCH
  arcpatch-D27539

REVISION DETAIL
  https://phabricator.kde.org/D27539

AFFECTED FILES
  autotests/kfileitemtest.cpp
  src/core/global.cpp

To: meven, ngraham, #frameworks, dfaure, broulik, sitter
Cc: sitter, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27533: [WIP] Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks

[Dominik Haumann]

dhaumann accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R39 KTextEditor

BRANCH
  addmarkinterfacev2

REVISION DETAIL
  https://phabricator.kde.org/D27533

To: kossebau, #kate, #kdevelop, dhaumann
Cc: anthonyfieroni, dhaumann, kwrite-devel, kde-frameworks-devel, rrosch, 
LeGast00n, cblack, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, 
sars

D27533: [WIP] Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks

[Dominik Haumann]

dhaumann added a comment.


  Ok, then I am fine with this. Maybe add a KF6 task to the KF6 board?

INLINE COMMENTS

> kossebau wrote in katedocument.h:86
> See the warning in the API docs, nobody should rely on this private API, so 
> the BIC here is okay.
> The class is exported for the unit tests basically.
> Also is the header file not installed, so not really available outside.

Friedrich is correct. We have no issue here.

> katedocument.h:586
>  QHash m_marks;
> -QHash m_markPixmaps;
> +QHash m_markIcons; // QPixmap or QIcon, KF6: remove 
> QPixmap support
>  QHash m_markDescriptions;

Better turn " Remove pixmap support" into use QIcon only.

> katesearchbar.cpp:906
>  if (!m_highlightRanges.empty()) {
> -KTextEditor::MarkInterface *iface = 
> qobject_cast(m_view->document());
> +KTextEditor::MarkInterfaceV2 *iface = 
> qobject_cast(m_view->document());
>  if (iface) {

maybe use `auto` here.

> kossebau wrote in kateviewhelpers.cpp:1963
> Possibly `QIcon::paint()` might be also working here as wanted? Needs someone 
> with HiDPI to check if all things behave as wanted. The old code with all the 
> `devicePixelRatioF()` made me change not too much here.

I believe you can check yourself with proper environment variables, or?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D27533

To: kossebau, #kate, #kdevelop
Cc: anthonyfieroni, dhaumann, kwrite-devel, kde-frameworks-devel, rrosch, 
LeGast00n, cblack, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, 
sars

D27539: KIO::iconNameForUrl: fix searching for kde protocol icons

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> global.cpp:240
>  // Let KFileItem::iconName handle things for us
> -if (i == unknown || i.isEmpty() || mt.isDefault()) {
> +if (iconName.isEmpty() || mt.isDefault()) {
>  const KFileItem item(url, mt.name());

With the new logic, I'm not sure what the mt.isDefault() is useful for. I think 
it can be removed.

> global.cpp:268
>  }
> -return !i.isEmpty() ? i : unknown;
> +// if we found nothing, revert to mimeTypeIcon (which is usually 
> "application-octet-stream")
> +return !iconName.isEmpty() ? iconName : mt.iconName();

There's no variable called mimeTypeIcon anymore.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27539

To: meven, ngraham, #frameworks, dfaure, broulik, sitter
Cc: sitter, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27363: KHolidays: Convert license statements to SPDX expressions

[Andreas Cord-Landwehr]

cordlandwehr updated this revision to Diff 76151.
cordlandwehr marked 2 inline comments as done.
cordlandwehr added a comment.


  Add missing SPDX identifier

REPOSITORY
  R175 KHolidays

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27363?vs=75737&id=76151

BRANCH
  spdx

REVISION DETAIL
  https://phabricator.kde.org/D27363

AFFECTED FILES
  LICENSES/BSD-2-Clause.txt
  LICENSES/Bison-exception-2.2.txt
  LICENSES/GPL-3.0-or-later.txt
  LICENSES/LGPL-2.0-or-later.txt
  autotests/testholidayregion.cpp
  autotests/testholidayregion.h
  autotests/testlunar.cpp
  autotests/testlunar.h
  autotests/testseasons.cpp
  autotests/testseasons.h
  autotests/testsunriseset.cpp
  autotests/testsunriseset.h
  autotests/testzodiac.cpp
  src/astroseasons.cpp
  src/astroseasons.h
  src/declarative/holidayregionsmodel.cpp
  src/declarative/holidayregionsmodel.h
  src/declarative/kholidaysdeclarativeplugin.cpp
  src/declarative/kholidaysdeclarativeplugin.h
  src/holiday.cpp
  src/holiday.h
  src/holiday_p.h
  src/holidayregion.cpp
  src/holidayregion.h
  src/lunarphase.cpp
  src/lunarphase.h
  src/parsers/holidayparserdriver.cpp
  src/parsers/holidayparserdriver_p.h
  src/parsers/plan2/FlexLexer.h
  src/parsers/plan2/holidayparserdriverplan.cpp
  src/parsers/plan2/holidayparserdriverplan_p.h
  src/parsers/plan2/holidayparserplan.cpp
  src/parsers/plan2/holidayparserplan.hpp
  src/parsers/plan2/holidayparserplan.ypp
  src/parsers/plan2/holidayscannerplan.cpp
  src/parsers/plan2/holidayscannerplan.lpp
  src/parsers/plan2/holidayscannerplan_p.h
  src/parsers/plan2/location.hh
  src/parsers/plan2/position.hh
  src/parsers/plan2/stack.hh
  src/parsers/qcalendarsystem.cpp
  src/parsers/qcalendarsystem_p.h
  src/sunriseset.cpp
  src/sunriseset.h
  src/zodiac.cpp
  src/zodiac.h

To: cordlandwehr
Cc: cgiboudeaux, winterz, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D27557: Auto-generate 24px monochrome icons

[Noah Davis]

ndavis added a comment.


  The following 24px icon symlinks are linked to 22px icons. Maybe it's 
material for another patch, but I figured I'd bring it up.
  
configure-shortcuts.svg -> ../../devices/22/input-keyboard.svg
dblatex.svg -> ../../places/22/network-server-database.svg
headphones.svg -> ../../devices/22/audio-headphones.svg
help-contents.svg -> ../../apps/22/system-help.svg
kdenlive-hide-audio.svg -> ../../status/22/audio-volume-muted.svg
kdenlive-show-audio.svg -> ../../status/22/audio-volume-high.svg
kstars_xplanet.svg -> ../../places/22/folder-html.svg
l2h.svg -> ../../places/22/folder-html.svg
new-command-alarm.svg -> ../../places/22/folder-script.svg
player-volume-muted.svg -> ../../status/22/audio-volume-muted.svg
player-volume.svg -> ../../status/22/audio-volume-high.svg
viewhtml.svg -> ../../places/22/folder-html.svg

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27557

To: ngraham, #vdg, ndavis, #frameworks, sitter
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27557: Auto-generate 24px monochrome icons

[Noah Davis]

ndavis added a comment.


  `draw-highlight` got a bit mangled: F8124601: Screenshot_20200222_043230.PNG 

  
  I think it's because both the viewbox and the height/width were set, which 
made the scaling at 22px equal to 0.26459. This looks fine when we're not 
trying to make 24px icons, but it obviously messes with the transformation math.
  
  All of the other 22px icons that have height/width and viewbox set have the 
same problem.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27557

To: ngraham, #vdg, ndavis, #frameworks, sitter
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27562: [kcmcontrols] Respect header/footer visibility

[Nicolas Fella]

nicolasfella edited the summary of this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D27562

To: nicolasfella, #plasma, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27245: Ki18n: Convert license headers to SPDX statements

[Andreas Cord-Landwehr]

cordlandwehr added a comment.


  In D27245#614915 , @kossebau wrote:
  
  > What about the `COPYING.LIB` file (containing LGLP 2.1 text) in the root 
directory? Could that not be removed given the new copy 
`LICENSES/LGPL-2.1-only.txt`?
  >  Or are both copies required? If so, why? Similar question also for any 
other repo.
  
  
  I agree, this file is obsolete. Yet, I did not touch it in any of the pull 
requests for the following reasons:
  
  - Several of the COPYING.LIB files are stating the wrong license revision, 
since we have frameworks that are only licensed LGPL-2.0 (as a common 
denominator)
  - This COPYING file is (in my perception) also understood as the outbound 
license of the whole library/application. Yet, this is a topic I only want to 
approach in a second step after clarifying the used licenses. The whole 
statement of the outbound license of a library is actually not defined yet 
AFAIS.
  - I just created a ticket for REUSE 
(https://github.com/fsfe/reuse-docs/issues/56) and asking for clarification, 
mostly because the GPL HowTo suggests to adding this file 
(https://www.gnu.org/licenses/gpl-howto.html).
  
  I will created another work item on the KF6 board for tracking the COPYING 
file handling, such that this does not block the progress for the SPDX 
identifier introduction.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D27245

To: cordlandwehr
Cc: kossebau, cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D27539: KIO::iconNameForUrl: fix searching for kde protocol icons

[Méven Car]

meven added a comment.


  In D27539#615654 , @dfaure wrote:
  
  > This is about an icon name. Apps don't (shouldn't) "check the value".
  >
  > We should return application-octet-stream if we did find the file, but 
mimetype determination failed. That's what this mimetype and its icon are about.
  >
  > We should return unknown if we have no clue what that URL is.
  
  
  So unless I am mistaken, you are saying the current behavior is the correct, 
one. And I can go with it.
  The code does :
  
  - if no scheme "unkwown"
  - else a bunch of rules, islocalFile, KFileItem handling, http, trash, 
KProtocolInfo::icon...
  - else whatever db.mimeTypeForUrl(url) returns (worse case 
application-octet-stream)
  
  Feel free to accept the diff ;)

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D27539

REVISION DETAIL
  https://phabricator.kde.org/D27539

To: meven, ngraham, #frameworks, dfaure, broulik, sitter
Cc: sitter, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27539: KIO::iconNameForUrl: fix searching for kde protocol icons

[Méven Car]

meven updated this revision to Diff 76148.
meven added a comment.


  Add an https test case

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27539?vs=76147&id=76148

BRANCH
  arcpatch-D27539

REVISION DETAIL
  https://phabricator.kde.org/D27539

AFFECTED FILES
  autotests/kfileitemtest.cpp
  src/core/global.cpp

To: meven, ngraham, #frameworks, dfaure, broulik, sitter
Cc: sitter, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27539: KIO::iconNameForUrl: fix searching for kde protocol icons

[David Faure]

dfaure added a comment.


  This is about an icon name. Apps don't (shouldn't) "check the value".
  
  We should return application-octet-stream if we did find the file, but 
mimetype determination failed. That's what this mimetype and its icon are about.
  
  We should return unknown if we have no clue what that URL is.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D27539

REVISION DETAIL
  https://phabricator.kde.org/D27539

To: meven, ngraham, #frameworks, dfaure, broulik, sitter
Cc: sitter, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27097: Port from QRegExp to QRegularExpression

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  OK for deprecating Incremental. A full revert (at KF6 time) of commit 
9ac82e27ad0322e444c16 
 
looks tricky though :-)
  I searched the git history, and I can't see where we ever used 
FindIncremental... [I searched kdelibs, since I'm pretty sure this was added 
for KHTML]
  
  You say that nothing calls find(QRegExp), that's because the find dialog just 
sets the option RegularExpression, right?
  This makes sense actually. I don't see why we have this API. The user uses 
the dialog and checks a box...
  It sounds like we should just deprecate find(QRegExp) and point to the 
RegularExpression option.
  (and make it private, as you said, i.e. move to private class)

INLINE COMMENTS

> kfind.cpp:775
>  d->pattern = pattern;
> -setOptions(options());   // rebuild d->regExp if necessary
> +// rebuild d->regex and d->regeExp (the latter is deprecated) if 
> necessary
> +setOptions(options());

typo: additional 'e' in regeExp

> kfinddialog.cpp:567
> +if (!QRegularExpression(q->pattern()).isValid()) {
> +KMessageBox::error(q, i18n("Invalid regular expression (see the 
> QRegularExpression documentation)."));
>  return;

I doubt end users want to open Qt API documentation...

REPOSITORY
  R310 KTextWidgets

REVISION DETAIL
  https://phabricator.kde.org/D27097

To: ahmadsamir, #frameworks, mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27557: Auto-generate 24px monochrome icons

[Noah Davis]

ndavis added a comment.


  Out of the ones listed above, these are symlinks:
  
24/font.svg
24/gnumeric-format-border-all.svg
24/gnumeric-format-border-none.svg
24/gnumeric-format-border-outside.svg
24/gnumeric-object-label.svg
24/gnumeric-object-line.svg
24/gnumeric-pagesetup-hf-cell.svg
24/gnumeric-pagesetup-hf-time.svg
24/gtk-tab-duplicate.svg
24/gtk-tab-new.svg
24/media-mout.svg
24/transform-scale-horizontal.svg
24/transform-scale-vertical.svg

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27557

To: ngraham, #vdg, ndavis, #frameworks, sitter
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27557: Auto-generate 24px monochrome icons

[Noah Davis]

ndavis added a comment.


  Looking pretty good so far. The only icons that have 24px versions but no 
22px versions are the following from the actions category:
  
24/align-horizontal-node.svg
24/align-vertical-node.svg
24/audio-volume-high.svg
24/audio-volume-low.svg
24/audio-volume-medium.svg
24/audio-volume-muted.svg
24/distribute-horizontal-node.svg
24/distribute-vertical-node.svg
24/font.svg
24/gnumeric-autofilter-delete.svg
24/gnumeric-autosum.svg
24/gnumeric-bucket.svg
24/gnumeric-cells-merge.svg
24/gnumeric-column-size.svg
24/gnumeric-component-insert-shaped.svg
24/gnumeric-data-slicer.svg
24/gnumeric-font.svg
24/gnumeric-format-border-all.svg
24/gnumeric-format-accounting.svg
24/gnumeric-format-border-double-bottom.svg
24/gnumeric-format-border-none.svg
24/gnumeric-format-border-outside.svg
24/gnumeric-format-border-thick-bottom.svg
24/gnumeric-format-border-thick-outside.svg
24/gnumeric-format-border-top-n-bottom.svg
24/gnumeric-format-border-top-n-thick-bottom.svg
24/gnumeric-format-border-top-n-double-bottom.svg
24/gnumeric-format-percentage.svg
24/gnumeric-format-precision-decrease.svg
24/gnumeric-format-precision-increase.svg
24/gnumeric-format-thousand-separator.svg
24/gnumeric-formulaguru.svg
24/gnumeric-link-external.svg
24/gnumeric-link-internal.svg
24/gnumeric-link-url.svg
24/gnumeric-object-arrow.svg
24/gnumeric-object-button.svg
24/gnumeric-object-checkbox.svg
24/gnumeric-object-combo.svg
24/gnumeric-object-ellipse.svg
24/gnumeric-object-label.svg
24/gnumeric-object-line.svg
24/gnumeric-object-list.svg
24/gnumeric-object-rectangle.svg
24/gnumeric-object-scrollbar.svg
24/gnumeric-object-spinbutton.svg
24/gnumeric-pagesetup-hf-cell.svg
24/gnumeric-protection-no.svg
24/gnumeric-pagesetup-hf-time.svg
24/gnumeric-protection-yes.svg
24/gnumeric-row-size.svg
24/gtk-tab-duplicate.svg
24/snap-nodes-cusp.svg
24/snap-nodes-midpoint.svg
24/snap-nodes-path.svg
24/snap-nodes-smooth.svg
24/transform-scale-horizontal.svg
24/transform-scale-vertical.svg
24/y-zoom-in.svg
24/zoom-in-x.svg
24/zoom-out-x.svg
24/zoom-out-y.svg
24/gtk-tab-new.svg
24/media-mout.svg

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27557

To: ngraham, #vdg, ndavis, #frameworks, sitter
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27533: [WIP] Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in katedocument.h:86
> Why private class is exported, changing parent of an exported class is BIC.

See the warning in the API docs, nobody should rely on this private API, so the 
BIC here is okay.
The class is exported for the unit tests basically.
Also is the header file not installed, so not really available outside.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D27533

To: kossebau, #kate, #kdevelop
Cc: anthonyfieroni, dhaumann, kwrite-devel, kde-frameworks-devel, rrosch, 
LeGast00n, cblack, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, 
sars

D27153: port sftp to Result system to force serialization of error/finish condition

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Nice work! Found 2 bugs though.

INLINE COMMENTS

> kio_sftp.cpp:1306
>  rc = ssh_channel_poll(mSftp->channel, 1);
> -}
> -
> -if (rc < 0) {
> +} else if (rc < 0) {
>  qCDebug(KIO_SFTP_LOG) << "ssh_channel_poll failed: " << 
> ssh_get_error(mSession);

Warning, you changed the logic. This "else" wasn't there, in order to catch the 
case where the second call to ssh_channel_poll failed too. I think you need to 
revert this "else".

> kio_sftp.cpp:2075
>  if (cPath.isEmpty()) {
> -error(KIO::ERR_MALFORMED_URL, url.toDisplayString());
> -return;
> +Result::fail(KIO::ERR_MALFORMED_URL, url.toDisplayString());
>  }

missing "return" in front

> kio_sftp.h:48
> + *
> + * The Result is forwared all the way to the frontend API where it is
> + * turned into an error() or finished() call.

typo: forwar*d*ed

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27153

To: sitter, dfaure, feverfew
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27539: KIO::iconNameForUrl: fix searching for kde protocol icons

[Méven Car]

meven added a comment.


  In D27539#615288 , @dfaure wrote:
  
  > kfileitemtest still passes?
  
  
  It does, and I added more tests.
  
  A question I have is that in case we don't find an icon depending on how we 
determine it we can return `application-octet-stream` or `unknown`.
  I guess we should return one of the two, in all cases.
  I would be in favor of `unknown` as application may be already checking this 
value.
  That would mean `if (mt.iconName() == "application-octet-stream") return 
"unknown"`.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D27539

REVISION DETAIL
  https://phabricator.kde.org/D27539

To: meven, ngraham, #frameworks, dfaure, broulik, sitter
Cc: sitter, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27539: KIO::iconNameForUrl: fix searching for kde protocol icons

[Méven Car]

meven updated this revision to Diff 76147.
meven added a comment.


  Add some tests

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27539?vs=76106&id=76147

BRANCH
  arcpatch-D27539

REVISION DETAIL
  https://phabricator.kde.org/D27539

AFFECTED FILES
  autotests/kfileitemtest.cpp
  src/core/global.cpp

To: meven, ngraham, #frameworks, dfaure, broulik, sitter
Cc: sitter, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27533: [WIP] Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> katedocument.h:86
>  class KTEXTEDITOR_EXPORT KTextEditor::DocumentPrivate : public 
> KTextEditor::Document,
> -public 
> KTextEditor::MarkInterface,
> +public 
> KTextEditor::MarkInterfaceV2,
>  public 
> KTextEditor::ModificationInterface,

Why private class is exported, changing parent of an exported class is BIC.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D27533

To: kossebau, #kate, #kdevelop
Cc: anthonyfieroni, dhaumann, kwrite-devel, kde-frameworks-devel, rrosch, 
LeGast00n, cblack, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, 
sars

D27451: Drop KToolInvocation support from KRun::runService

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  This makes runService and runApplication almost the same, right?
  
  KRecentDocument::add seems missing in runApplication, but that's a bug, so 
one could just call the other?

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27451

To: davidedmundson, dfaure
Cc: ervin, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27533: [WIP] Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D27533#615478 , @dhaumann wrote:
  
  > Still, I wonder whether we should postpone adding the MarkInterfaceV2 until 
the KF6 branch. Then we have it properly fixed in KF6.
  
  
  KF5 will stay around for a few more years though, if we compare to kdelibs3 & 
kdelibs4 life times. So IMHO it would be good/nice to already now allow more 
crisp symbols on the border (and in the default popup menu, which reuses the 
symbols passed, so right now the pixmap, again scaling to another size). Even 
more with SVG icons being the default now, so we can render as close as 
possible.
  
  The code I wrote did not feel like such a bummer, and the patch for Kate 
could perhaps just bump the required min version and spare the #if/#else. At 
time of porting it will be just an adaption of MarkInterfaceV2 back to 
MarkInterface on the client side. Merging MarkInterfaceV2 into MarkInterface in 
KTextEditor should also be simple work done in a few minutes, so no real 
technical debt added IMHO, compared to achieving a crisp symbol border.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D27533

To: kossebau, #kate, #kdevelop
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, 
GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars