D27730: Add API to check whether a barcode is one- or two-dimensional

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This matters for user code doing some more advanced layouting or size computations, especially once we remove the

D27731: Improve KDirModel to avoid showing '+' if there are no subdirs

rrosch accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D27731 To: dfaure, apol, ahmadsamir, meven, rrosch Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

kossebau added a comment. In D27150#619735 , @bruns wrote: > You have ommited to update the minimum ECM version in all cases AFAICS. Because that bump is done by the release scripts, and I did not want to mess with them. In general

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 146 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/146/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 28 Feb 2020 23:38:51 + Build duration: 1 min 30 sec and counting JUnit Tests Name:

D27731: Improve KDirModel to avoid showing '+' if there are no subdirs

dfaure created this revision. dfaure added reviewers: apol, ahmadsamir, meven. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY We either have the information at hand (in populated dirs) or we query

D25315: KDirModel: implement showing "/" as a root node, optionally

rrosch added a comment. > Keep only matters for further calls to openUrl, not the first one. It's about whether to *add* or *replace* the currently open URL. > KDirModel takes care of that. Ah ok, so it's going to do that without me needing to explicitly specify "Keep"? >> I

D27731: Improve KDirModel to avoid showing '+' if there are no subdirs

dfaure added a reviewer: rrosch. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27731 To: dfaure, apol, ahmadsamir, meven, rrosch Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

bruns added a comment. @kossebau - you have pushed commits depending on this change to several repositories, sometimes without waiting for acceptance, sometimes even bypassing Phabricator review completely. You have ommited to update the minimum ECM version in all cases AFAICS.

D25315: KDirModel: implement showing "/" as a root node, optionally

dfaure planned changes to this revision. dfaure added a comment. In D25315#619436 , @rrosch wrote: > Tested on patched KF5 5.64, on Fedora 30 (32bit)... root node shows up! I had to change the call in my code that was originally: > >

D27178: Use ecm_qt_install_logging_categories over manual categories file

bruns added inline comments. INLINE COMMENTS > CMakeLists.txt:7 > include(FeatureSummary) > find_package(ECM 5.67.0 NO_MODULE) > set_package_properties(ECM PROPERTIES TYPE REQUIRED DESCRIPTION "Extra CMake > Modules." URL "https://commits.kde.org/extra-cmake-modules;) Obviously, this is no

D27269: Use ecm_qt_install_logging_categories over manual categories file

bruns added inline comments. INLINE COMMENTS > CMakeLists.txt:9 > include(FeatureSummary) > find_package(ECM 5.67.0 NO_MODULE) > set_package_properties(ECM PROPERTIES TYPE REQUIRED DESCRIPTION "Extra CMake > Modules." URL "https://commits.kde.org/extra-cmake-modules;) Obviously, this is no

D26342: Allow overriding to disable auto language detection

sdepiets added a reviewer: mludwig. sdepiets added a comment. Can we get some traction on this? It's a relatively light change that doesn't affect the default Sonnet behavior. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D26342 To: sdepiets, #frameworks,

D25743: Expose IndexerState enum to QML

davidedmundson added a comment. > Ping. Will do on Sunday (after tagging) REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D25743 To: davidedmundson, #baloo, ngraham Cc: broulik, kde-frameworks-devel, ngraham, #baloo, hurikhan77, lots0logs,

D25315: KDirModel: implement showing "/" as a root node, optionally

rrosch added a comment. Tested on patched KF5 5.64, on Fedora 30 (32bit)... root node shows up! I had to change the call in my code that was originally: model->dirLister()->openUrl(QUrl::fromLocalFile("/"), KDirLister::Keep); to model->openUrl(QUrl::fromLocalFile("/"),

D25315: KDirModel: implement showing "/" as a root node, optionally

rrosch added a comment. Ok, I found one of the "implications". With `model->dirLister()->openUrl(m_initURL, KDirLister::Keep);` I can list KIO urls like `remote:`, `font:`, and `applications:`, but with `model->openUrl(m_initURL, KDirModel::ShowRoot);` I cannot, and only seems to display

D21795: [KAuth] Add support for action details in Polkit1 backend.

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. Much better. Since nobody has input on the deprecations I guess they must be alright. Do have a look into using QDBusError::InvalidArgs before landing though. INLINE COMMENTS >

D27628: Buttons: allow to scale up icons

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Lovely. - Media controller is fine now - Pin on systray popup is fine - buttons in NM applet are fine REPOSITORY R242 Plasma Framework (Library) BRANCH phab/anothersizehint

D27709: Move job classes to kaccounts lib and rename to *Job

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. As i was going to do this as part of something else, i obviously think this is a good idea ;) And yes, the thought process behind it was indeed that this is something that'd just make

D27717: fix min/max entries with dpointer

ervin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27717 To: hchain, meven, ervin Cc: kde-frameworks-devel, aacid, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27717: fix min/max entries with dpointer

meven accepted this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27717 To: hchain, meven, ervin Cc: kde-frameworks-devel, aacid, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27633: Port to KPluginLoader

aacid added a comment. I think this broke https://build.kde.org/job/Applications/job/ktp-common-internals/job/kf5-qt5%20SUSEQt5.12/20/console guess ¿KAccountsDPlugin now requires parameters to the constructor and is thus not a valid Q_INTERFACE? @nicolasfella can you please look at it?

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 442 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/442/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 28 Feb 2020 10:28:44 + Build duration: 9 min 31 sec and counting BUILD ARTIFACTS

D27709: Move job classes to kaccounts lib and rename to *Job

This revision was automatically updated to reflect the committed changes. Closed by commit R155:2030bb498ed3: Move job classes to kaccounts lib and rename to *Job (authored by nicolasfella). REPOSITORY R155 KAccounts Integration CHANGES SINCE LAST UPDATE

D27705: Use QStringLiteral

nicolasfella marked an inline comment as done. REPOSITORY R155 KAccounts Integration REVISION DETAIL https://phabricator.kde.org/D27705 To: nicolasfella, #frameworks, bshah, leinir, apol Cc: apol

D27707: Use kcoreaddons_add_plugin for kded module

This revision was automatically updated to reflect the committed changes. Closed by commit R155:4ad7ceea349b: Use kcoreaddons_add_plugin for kded module (authored by nicolasfella). REPOSITORY R155 KAccounts Integration CHANGES SINCE LAST UPDATE

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

emateli added a comment. Well, this patch is more or less complete but it doesn't make sense to be deployed without batch operations from KIO as it would spawn a job for each file to be renamed. Like I stated in my last comment, I tried to give adding batch renaming a go but it felt

D27706: Random cmake cleanup

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R155 KAccounts Integration BRANCH cmakecleanup REVISION DETAIL https://phabricator.kde.org/D27706 To: nicolasfella, #frameworks, bshah, leinir, apol

D27705: Use QStringLiteral

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. if you want to have this, it could make sense to enforce it from cmake. INLINE COMMENTS > createaccount.cpp:195 > base.append(authData.method()); > -base.append("/"); > +

D27654: [kio] Fix running konsole on Wayland

This revision was automatically updated to reflect the committed changes. Closed by commit R241:07ab04bfe774: Fix running konsole on Wayland (authored by wbauer). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27654?vs=76387=76607 REVISION DETAIL

D27633: Port to KPluginLoader

aacid added a comment. In D27633#619365 , @aacid wrote: > I think this broke https://build.kde.org/job/Applications/job/ktp-common-internals/job/kf5-qt5%20SUSEQt5.12/20/console guess ¿KAccountsDPlugin now requires parameters to the constructor

D27633: Port to KPluginLoader

aacid added a comment. In D27633#619369 , @aacid wrote: > In D27633#619365 , @aacid wrote: > > > I think this broke

D27707: Use kcoreaddons_add_plugin for kded module

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R155 KAccounts Integration BRANCH plug REVISION DETAIL https://phabricator.kde.org/D27707 To: nicolasfella, #frameworks, bshah, leinir, apol

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 317 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/317/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 28 Feb 2020 10:28:43 + Build duration: 7 min 35 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 308 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/308/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 28 Feb 2020 10:28:44 + Build duration: 7 min 2 sec and counting JUnit Tests Name:

D27705: Use QStringLiteral

This revision was automatically updated to reflect the committed changes. Closed by commit R155:be294dcc69e7: Use QStringLiteral (authored by nicolasfella). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27705?vs=76566=76610#toc REPOSITORY R155 KAccounts Integration CHANGES SINCE

D27717: fix min/max entries with dpointer

hchain created this revision. hchain added reviewers: meven, ervin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. hchain requested review of this revision. REVISION SUMMARY D27497 was causing cases with dpointer +

D27717: fix min/max entries with dpointer

This revision was automatically updated to reflect the committed changes. Closed by commit R237:f98feb169813: fix min/max entries with dpointer (authored by hchain). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27717?vs=76600=76604 REVISION DETAIL

D27706: Random cmake cleanup

This revision was automatically updated to reflect the committed changes. Closed by commit R155:3f4fc9d4071b: Random cmake cleanup (authored by nicolasfella). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27706?vs=76567=76611#toc REPOSITORY R155 KAccounts Integration CHANGES SINCE

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 260 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/260/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 28 Feb 2020 14:49:30 + Build duration: 2 min 55 sec and counting JUnit Tests Name:

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 152 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/152/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 28 Feb 2020 14:49:30 + Build duration: 2 min 12 sec and counting JUnit Tests Name:

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 145 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/145/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 28 Feb 2020 14:49:30 + Build duration: 1 min 46 sec and counting JUnit Tests Name:

D27607: Deprecate KDBusConnectionPool

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R271 KDBusAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D27607 To: vkrause, davidedmundson Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,

D27607: Deprecate KDBusConnectionPool

vkrause added a comment. ping? REPOSITORY R271 KDBusAddons REVISION DETAIL https://phabricator.kde.org/D27607 To: vkrause Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27714: C++: constinit keyword and std::format syntax for strings. Improvement printf format.

This revision was automatically updated to reflect the committed changes. Closed by commit R216:c41ed480a504: C++: constinit keyword and std::format syntax for strings. Improvement printf… (authored by jpoelen, committed by cullmann). CHANGED PRIOR TO COMMIT

D27533: [WIP] Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks

cullmann accepted this revision. cullmann added a comment. I think this should go in now. I think the usage of the API is correct even for HiDPI. In KF6, we should just fold that interface into the main class. REPOSITORY R39 KTextEditor BRANCH addmarkinterfacev2 REVISION DETAIL

D27430: [PATCH] General update for CartoCSS syntax highlighting

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok, let's land that. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D27430 To: sommer, #framework_syntax_highlighting, cullmann Cc: cullmann,

D27580: Updates for CMake 3.17

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Thanks for the update! REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D27580 To: turbov, #framework_syntax_highlighting, cullmann Cc: cullmann,

D27580: Updates for CMake 3.17

This revision was automatically updated to reflect the committed changes. Closed by commit R216:fb8e0b2777a2: Updates for CMake 3.17 (authored by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27580?vs=76182=76646 REVISION DETAIL

D27486: Add FreeCAD FCMacro extension to the python highlighting definition

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok, makes sense, will increase version myself. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D27486 To: martonmiklos,

D27486: Add FreeCAD FCMacro extension to the python highlighting definition

This revision was automatically updated to reflect the committed changes. Closed by commit R216:978e23b2c44c: Add FreeCAD FCMacro extension to the python highlighting definition (authored by cullmann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27486?vs=75942=76647#toc REPOSITORY

D27724: Syncronise setNeedsSave between KCModule and ConfigModule in both directions

davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY The problem occurs in the following situation: Widgets and such often change state and emit they're

D27714: C++: constinit keyword and std::format syntax for strings. Improvement printf format.

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Nice! Thanks for the improvements ;=) REPOSITORY R216 Syntax Highlighting BRANCH cpp (branched from master) REVISION DETAIL https://phabricator.kde.org/D27714 To: jpoelen,

D27607: Deprecate KDBusConnectionPool

This revision was automatically updated to reflect the committed changes. Closed by commit R271:417607275368: Deprecate KDBusConnectionPool (authored by vkrause). REPOSITORY R271 KDBusAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27607?vs=76316=76652 REVISION DETAIL

D27727: Remove empty/unused private classes on internal types

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This avoids unnecessary allocations. This also un-exports QRCodeBarcode, which is declared in a non-installed header