KDE CI: Frameworks » ktextwidgets » kf5-qt5 WindowsMSVCQt5.14 - Build # 13 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ktextwidgets/job/kf5-qt5%20WindowsMSVCQt5.14/13/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Wed, 25 Mar 2020 02:02:19 + Build duration: 10 min and counting JUnit Tests Name:

KDE CI: Frameworks » kunitconversion » kf5-qt5 WindowsMSVCQt5.14 - Build # 14 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kunitconversion/job/kf5-qt5%20WindowsMSVCQt5.14/14/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Wed, 25 Mar 2020 02:02:18 + Build duration: 11 min and counting JUnit Tests

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 WindowsMSVCQt5.14 - Build # 24 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20WindowsMSVCQt5.14/24/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Wed, 25 Mar 2020 02:02:17 + Build duration: 11 min and counting JUnit Tests

KDE CI: Frameworks » knotifyconfig » kf5-qt5 WindowsMSVCQt5.14 - Build # 14 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/knotifyconfig/job/kf5-qt5%20WindowsMSVCQt5.14/14/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Wed, 25 Mar 2020 02:02:22 + Build duration: 18 min and counting

KDE CI: Frameworks » knotifications » kf5-qt5 WindowsMSVCQt5.14 - Build # 24 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20WindowsMSVCQt5.14/24/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Wed, 25 Mar 2020 02:02:22 + Build duration: 18 min and counting

KDE CI: Frameworks » ktexteditor » kf5-qt5 WindowsMSVCQt5.14 - Build # 39 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20WindowsMSVCQt5.14/39/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Wed, 25 Mar 2020 02:02:19 + Build duration: 18 min and counting JUnit Tests Name:

KDE CI: Frameworks » kcompletion » kf5-qt5 WindowsMSVCQt5.14 - Build # 13 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcompletion/job/kf5-qt5%20WindowsMSVCQt5.14/13/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Wed, 25 Mar 2020 02:02:52 + Build duration: 31 min and counting JUnit Tests Name:

KDE CI: Frameworks » kcrash » kf5-qt5 WindowsMSVCQt5.14 - Build # 16 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcrash/job/kf5-qt5%20WindowsMSVCQt5.14/16/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Wed, 25 Mar 2020 02:02:48 + Build duration: 31 min and counting JUnit Tests Name:

KDE CI: Frameworks » kcontacts » kf5-qt5 WindowsMSVCQt5.14 - Build # 15 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcontacts/job/kf5-qt5%20WindowsMSVCQt5.14/15/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Wed, 25 Mar 2020 02:02:52 + Build duration: 33 min and counting JUnit Tests Name:

KDE CI: Frameworks » kmediaplayer » kf5-qt5 WindowsMSVCQt5.14 - Build # 12 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kmediaplayer/job/kf5-qt5%20WindowsMSVCQt5.14/12/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Wed, 25 Mar 2020 02:02:24 + Build duration: 21 min and counting JUnit Tests Name:

KDE CI: Frameworks » knewstuff » kf5-qt5 WindowsMSVCQt5.14 - Build # 27 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20WindowsMSVCQt5.14/27/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Wed, 25 Mar 2020 02:02:23 + Build duration: 21 min and counting JUnit Tests Name:

KDE CI: Frameworks » kjobwidgets » kf5-qt5 WindowsMSVCQt5.14 - Build # 13 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kjobwidgets/job/kf5-qt5%20WindowsMSVCQt5.14/13/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Wed, 25 Mar 2020 02:02:33 + Build duration: 21 min and counting

KDE CI: Frameworks » kemoticons » kf5-qt5 WindowsMSVCQt5.14 - Build # 13 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kemoticons/job/kf5-qt5%20WindowsMSVCQt5.14/13/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Wed, 25 Mar 2020 02:02:45 + Build duration: 39 min and counting JUnit Tests Name:

KDE CI: Frameworks » kactivities » kf5-qt5 WindowsMSVCQt5.14 - Build # 17 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kactivities/job/kf5-qt5%20WindowsMSVCQt5.14/17/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Wed, 25 Mar 2020 02:02:55 + Build duration: 37 min and counting

KDE CI: Frameworks » kauth » kf5-qt5 WindowsMSVCQt5.14 - Build # 20 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kauth/job/kf5-qt5%20WindowsMSVCQt5.14/20/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Wed, 25 Mar 2020 02:02:52 + Build duration: 36 min and counting JUnit Tests Name:

T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

ngraham added a parent task: T11950: Reduce the pain of working on monochrome Breeze icons. TASK DETAIL https://phabricator.kde.org/T12855 To: ngraham Cc: kde-frameworks-devel, davidhurka, dmenig, manueljlin, Orage, LeGast00n, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh,

T11950: Reduce the pain of working on monochrome Breeze icons

ngraham added a subtask: T12855: [Breeze Icons] Get rid of redundancy in icons-dark/. TASK DETAIL https://phabricator.kde.org/T11950 To: ngraham Cc: davidhurka, mglb, #frameworks, mart, trickyricky26, ndavis, #vdg, ngraham, dmenig, manueljlin, Orage, LeGast00n, cblack, konkinartem, ian,

D27951: Allow users to change dropAction to MoveAction through kdeglobals

trmdi updated this revision to Diff 78426. trmdi marked 2 inline comments as done. trmdi added a comment. - Always move files if all of them are symlinks - Use KMountPoint REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27951?vs=77511=78426 BRANCH

KDE CI: Frameworks » kpeople » kf5-qt5 WindowsMSVCQt5.14 - Build # 16 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kpeople/job/kf5-qt5%20WindowsMSVCQt5.14/16/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Wed, 25 Mar 2020 02:02:21 + Build duration: 17 min and counting JUnit Tests Name:

KDE CI: Frameworks » kservice » kf5-qt5 WindowsMSVCQt5.14 - Build # 34 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20WindowsMSVCQt5.14/34/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Wed, 25 Mar 2020 02:02:20 + Build duration: 15 min and counting JUnit Tests Name:

KDE CI: Frameworks » krunner » kf5-qt5 WindowsMSVCQt5.14 - Build # 16 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/krunner/job/kf5-qt5%20WindowsMSVCQt5.14/16/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Wed, 25 Mar 2020 02:02:21 + Build duration: 14 min and counting JUnit Tests Name:

KDE CI: Frameworks » kfilemetadata » kf5-qt5 WindowsMSVCQt5.14 - Build # 14 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20WindowsMSVCQt5.14/14/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Wed, 25 Mar 2020 02:02:34 + Build duration: 24 min and counting JUnit Tests

KDE CI: Frameworks » kimageformats » kf5-qt5 WindowsMSVCQt5.14 - Build # 9 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20WindowsMSVCQt5.14/9/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Wed, 25 Mar 2020 02:02:33 + Build duration: 24 min and counting JUnit Tests Name:

KDE CI: Frameworks » kjsembed » kf5-qt5 WindowsMSVCQt5.14 - Build # 12 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kjsembed/job/kf5-qt5%20WindowsMSVCQt5.14/12/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Wed, 25 Mar 2020 02:02:32 + Build duration: 24 min and counting

KDE CI: Frameworks » kdeclarative » kf5-qt5 WindowsMSVCQt5.14 - Build # 22 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20WindowsMSVCQt5.14/22/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Wed, 25 Mar 2020 02:02:48 + Build duration: 29 min and counting JUnit Tests

D28203: Move corner fold to top right in 24 icons

ndavis requested changes to this revision. ndavis added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > document-preview.svg:1 > +/home/david/kde/breeze-icons/icons/actions/32/document-preview-archive.svg This needs to be a relative symlink (`ln -sr

KDE CI: Frameworks » kdewebkit » kf5-qt5 WindowsMSVCQt5.14 - Build # 12 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kdewebkit/job/kf5-qt5%20WindowsMSVCQt5.14/12/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Wed, 25 Mar 2020 02:02:46 + Build duration: 25 min and counting

KDE CI: Frameworks » kiconthemes » kf5-qt5 WindowsMSVCQt5.14 - Build # 13 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kiconthemes/job/kf5-qt5%20WindowsMSVCQt5.14/13/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Wed, 25 Mar 2020 02:02:44 + Build duration: 27 min and counting JUnit Tests Name:

KDE CI: Frameworks » kded » kf5-qt5 WindowsMSVCQt5.14 - Build # 14 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kded/job/kf5-qt5%20WindowsMSVCQt5.14/14/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Wed, 25 Mar 2020 02:02:46 + Build duration: 27 min and counting

KDE CI: Frameworks » kconfigwidgets » kf5-qt5 WindowsMSVCQt5.14 - Build # 21 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kconfigwidgets/job/kf5-qt5%20WindowsMSVCQt5.14/21/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Wed, 25 Mar 2020 02:02:52 + Build duration: 34 min and counting JUnit Tests

KDE CI: Frameworks » kcmutils » kf5-qt5 WindowsMSVCQt5.14 - Build # 18 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcmutils/job/kf5-qt5%20WindowsMSVCQt5.14/18/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Wed, 25 Mar 2020 02:02:52 + Build duration: 34 min and counting

KDE CI: Frameworks » kbookmarks » kf5-qt5 WindowsMSVCQt5.14 - Build # 17 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20WindowsMSVCQt5.14/17/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Wed, 25 Mar 2020 02:02:52 + Build duration: 47 min and counting JUnit Tests Name:

D28203: Move corner fold to top right in 24 icons

ndavis added a comment. Eh, I'm not going to make a big fuss about the copy icon. In D28203#633041 , @davidhurka wrote: > There are 172 icons in 16px but not in 22px, and 348 icons in 22px but not in 16px. There are 1561 icons in 22px but

D27951: Allow users to change dropAction to MoveAction through kdeglobals

trmdi added inline comments. INLINE COMMENTS > davidedmundson wrote in dropjob.cpp:286 > Why QStorageInfo? We're in kio. There's a KMountPoint which is similar > > I suspect this is a recursive list up the tree resolving symlinks. This will > mean blocking stat calls, so this somewhat

D28223: Add "Stat" prefix to StatDetails Enum entries

meven updated this revision to Diff 78401. meven added a comment. Properly use KIO::Stat* as C-style enum REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28223?vs=78301=78401 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28223 AFFECTED FILES

D28193: [KFontChooser] Use one QFontDatabase object for the ::Private class

ahmadsamir abandoned this revision. ahmadsamir added a comment. In D28193#633829 , @dfaure wrote: > I don't think this makes any difference, they all share the same underlying private singleton. > So all this does is to use a tiny bit more

D27883: Register spawned applications as an independent cgroups

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. It would be good to add a link to the spec as a code comment -- but I see that the docu isn't merged yet, so can't be done yet. INLINE COMMENTS > kprocessrunner.cpp:43 > + > +#include >

D28260: [QML] Set the remaining time in the monitor more reliably

bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The remaining time was only updated when the count of indexed files modulo

D28223: Add "Stat" prefix to StatDetails Enum entries

broulik added inline comments. INLINE COMMENTS > global.h:322 > /// No field returned, useful to check if a file exists > -NoDetails = 0x0, > +StatNoDetails = 0x0, > /// Filename, access, type, size, linkdest Is this change source-compatible? REPOSITORY R241 KIO REVISION

D28223: Add "Stat" prefix to StatDetails Enum entries

meven marked 2 inline comments as done. meven added inline comments. INLINE COMMENTS > davidre wrote in global.h:322 > I think this enum was not released yet Indeed it will be part of KF 5.69 (as the comment above the enum tells), view discussion in D25010

D28223: Add "Stat" prefix to StatDetails Enum entries

meven marked 2 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28223 To: meven, #frameworks, kossebau, dfaure Cc: davidre, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28223: Add "Stat" prefix to StatDetails Enum entries

davidre added inline comments. INLINE COMMENTS > global.h:322 > /// No field returned, useful to check if a file exists > -NoDetails = 0x0, > +StatNoDetails = 0x0, > /// Filename, access, type, size, linkdest I think this enum was not released yet REPOSITORY R241 KIO

D28220: Switch to using Kirigami's ShadowedRectangle

leinir updated this revision to Diff 78341. leinir added a comment. - Increase Kirigami runtime dep version to 2.12 REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28220?vs=78290=78341 BRANCH switch-to-kirigami-shadowedrectangle (branched from master)

D28220: Switch to using Kirigami's ShadowedRectangle

leinir added a reviewer: VDG. leinir marked 3 inline comments as done. leinir added a comment. (pending some screenshots of the visible change) INLINE COMMENTS > broulik wrote in EntryScreenshots.qml:138 > You used `largeSpacing` as `verticalOffset` before Hm, on second thought, it looks

D28220: Switch to using Kirigami's ShadowedRectangle

leinir updated this revision to Diff 78342. leinir added a comment. - Less magic numbers - Remove some unneeded bits REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28220?vs=78341=78342 BRANCH switch-to-kirigami-shadowedrectangle (branched from

D28220: Switch to using Kirigami's ShadowedRectangle

leinir edited the test plan for this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D28220 To: leinir, #knewstuff, #frameworks, #plasma, ahiemstra, broulik, mart, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28122: Copy KFontDialog from KDELibs4Support to KWidgetAddons, now KFontChooserDialog

meven added inline comments. INLINE COMMENTS > kfontchooserdialog.cpp:93 > + > +// static > +int KFontChooserDialog::getFontDiff(QFont , > KFontChooser::FontDiffFlags , Shouldn't this be not commented > kfontchooserdialog.cpp:110 > + > +// static > +int KFontChooserDialog::getFont(QFont ,

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.14 - Build # 2 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.14/2/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Tue, 24 Mar 2020 10:50:32 + Build duration: 15 min and counting JUnit Tests Name:

D28220: Switch to using Kirigami's ShadowedRectangle

broulik added inline comments. INLINE COMMENTS > EntryScreenshots.qml:133 > anchors.fill: thumbnail > -verticalOffset: Kirigami.Units.largeSpacing > -horizontalOffset: 0 > -radius: 12.0 > -

D28220: Switch to using Kirigami's ShadowedRectangle

leinir marked 5 inline comments as done. leinir added inline comments. INLINE COMMENTS > broulik wrote in EntryScreenshots.qml:133 > Not needed given you `anchors.fill` Ah yes, quite :) > broulik wrote in EntryScreenshots.qml:135 > What's this for? That's a good question, really - i found

D27936: Windows: Add suport for file date creation

This revision was automatically updated to reflect the committed changes. Closed by commit R241:50bc53ffbcf2: Windows: Add suport for file date creation (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27936?vs=77236=78343 REVISION DETAIL

D27535: Add XdgOutputV1 version 2

This revision was automatically updated to reflect the committed changes. Closed by commit R127:8b355825a3b8: Add XdgOutputV1 version 2 (authored by davidedmundson). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27535?vs=76077=78345 REVISION DETAIL

D27873: sftp: do not show creation time when we do not know it

meven added a comment. In D27873#624567 , @sitter wrote: > In D27873#623582 , @bruns wrote: > > > Please correct the comment in the code - it depends on the server SFTP implementation. > > >

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 117 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/117/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 24 Mar 2020 10:50:33 + Build duration: 6 min 47 sec and counting BUILD ARTIFACTS

D28122: Copy KFontDialog from KDELibs4Support to KWidgetAddons, now KFontChooserDialog

ahmadsamir added inline comments. INLINE COMMENTS > meven wrote in kfontchooserdialog.cpp:93 > Shouldn't this be not commented IIUC, if a function is declared static inside the class body (e.g. in the header file), the static keyword can't be repeated when it's defined outside the class body.

D28128: Add force save behavior to KEntryMap

dfaure added inline comments. INLINE COMMENTS > bport wrote in kconfigtest.cpp:1970 > This is a global local file, not system wide and so not considered as default > cf. https://lxr.kde.org/source/frameworks/kconfig/src/core/kconfig.cpp#0702 > if the entry is set system wide > /etc/kde5rc >

D27873: sftp: do not show creation time when we do not know it

sitter updated this revision to Diff 78352. sitter added a comment. . REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27873?vs=77080=78352 BRANCH sftp-ctime REVISION DETAIL https://phabricator.kde.org/D27873 AFFECTED FILES sftp/kio_sftp.cpp To:

D28235: Add a simpler example

apol created this revision. apol added a reviewer: vkrause. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. apol requested review of this revision. REVISION SUMMARY Just a QPlainTextEdit and a highlighter. TEST PLAN Used it to figure out

D28144: Make animation durations consistent with Kirigami values

ngraham added a dependent revision: D28239: Stop multiplying duration values. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28144 To: ngraham, #plasma, davidedmundson, mart Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28241: Check correct file for sandbox detection

This revision was automatically updated to reflect the committed changes. Closed by commit R271:7f8d778b0a05: Check correct file for sandbox detection (authored by jgrulich). REPOSITORY R271 KDBusAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28241?vs=78362=78363 REVISION

D25495: Fix Sonnet autodetect failing on Indian langs

apol added inline comments. INLINE COMMENTS > waqar wrote in guesslanguage.cpp:586 > `identify()` fails if a certain language is not present in the trigrams. Why did you handle it here rather than in identify then? is it a problem doing it there? I see that identify is being used elsewhere

D25495: Fix Sonnet autodetect failing on Indian langs

waqar added inline comments. INLINE COMMENTS > apol wrote in guesslanguage.cpp:586 > Why did you handle it here rather than in identify then? is it a problem > doing it there? I see that identify is being used elsewhere too. It will be > wrong there. Initially I handled it in identify () but

D25495: Fix Sonnet autodetect failing on Indian langs

waqar added a comment. In D25495#633551 , @apol wrote: > Whatever, let's go with this and we can learn along the way. > > Sorry it took so long. I am excited. Thanks! I will be sure to keep checking in if anything goes amiss in

D28220: Switch to using Kirigami's ShadowedRectangle

ngraham added a comment. Just an observation, we should maybe consider making a shared component for this screenshots list so that Discover can use it too. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D28220 To: leinir, #knewstuff, #frameworks, #plasma,

D25495: Fix Sonnet autodetect failing on Indian langs

waqar added a comment. I tried but I don't have the access. So I guess you guys would have land. REPOSITORY R246 Sonnet BRANCH fix-176537 (branched from master) REVISION DETAIL https://phabricator.kde.org/D25495 To: waqar, mludwig, cullmann, apol Cc: apol, ognarb,

D27873: sftp: do not show creation time when we do not know it

meven accepted this revision. meven added a comment. Ok to me @bruns ? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27873 To: sitter, ngraham, bruns, meven Cc: meven, bruns, kde-frameworks-devel, kfm-devel, nikolaik, pberestov, iasensio, fprice, LeGast00n,

Re: Problems in KWayland causes by API and ABI compatibility promises

On Mon, Mar 23, 2020 at 3:45 PM David Edmundson wrote: > > > > > That's a good question! On one hand, it's nice to have Qt-friendly > > wrappers for Wayland protocols. On the other hand, it would be even > > better to have a library to write Wayland compositors. So, one just > > needs to plug a

D28241: Check correct file for sandbox detection

jgrulich created this revision. jgrulich added a reviewer: apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jgrulich requested review of this revision. REPOSITORY R271 KDBusAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D28241

D28241: Check correct file for sandbox detection

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R271 KDBusAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D28241 To: jgrulich, apol Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D25495: Fix Sonnet autodetect failing on Indian langs

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Whatever, let's go with this and we can learn along the way. Sorry it took so long. REPOSITORY R246 Sonnet BRANCH fix-176537 (branched from master) REVISION DETAIL

D28144: Make animation durations consistent with Kirigami values

ngraham added a dependent revision: D28238: Stop multiplying duration values. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28144 To: ngraham, #plasma, davidedmundson, mart Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28144: Make animation durations consistent with Kirigami values

ngraham reopened this revision. ngraham added a comment. This revision is now accepted and ready to land. I reverted this for now in e2a13e9ac79a8d8d8a7dfd0916f6826760b73165 because if we land it now before the companion Plasma patches are in, rolling release users will suffer from slow

D25495: Fix Sonnet autodetect failing on Indian langs

apol added a comment. Can you land the patch or you need us to? REPOSITORY R246 Sonnet BRANCH fix-176537 (branched from master) REVISION DETAIL https://phabricator.kde.org/D25495 To: waqar, mludwig, cullmann, apol Cc: apol, ognarb, kde-frameworks-devel, LeGast00n, cblack, GB_2,

D28220: Switch to using Kirigami's ShadowedRectangle

leinir added a subscriber: davidedmundson. leinir added a comment. In D28220#633557 , @ngraham wrote: > Just an observation, we should maybe consider making a shared component for this screenshots list so that Discover can use it too. i

D28220: Switch to using Kirigami's ShadowedRectangle

ahiemstra added inline comments. INLINE COMMENTS > EntryScreenshots.qml:134 > +Kirigami.Theme.colorSet: Kirigami.Theme.View > +shadow.xOffset: 0 > +shadow.yOffset: 0 The x and y offsets should be 0 by default, so there's little reason

D28244: GIT_SILENT minor code formatting

ahmadsamir created this revision. ahmadsamir added a reviewer: Frameworks. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REPOSITORY R236 KWidgetsAddons BRANCH l-code-cleanup-2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D28244

D28245: [xdgoutput] Only send initial name and description if set

zzag accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D28245 To: davidedmundson, #kwin, zzag Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28245: [xdgoutput] Only send initial name and description if set

apol accepted this revision. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D28245 To: davidedmundson, #kwin, zzag, apol Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28245: [xdgoutput] Only send initial name and description if set

This revision was automatically updated to reflect the committed changes. Closed by commit R127:2b74a0386854: [xdgoutput] Only send initial name and description if set (authored by davidedmundson). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

D28245: [xdgoutput] Only send initial name and description if set

zzag added a comment. The spec says that `name` and `description` events will be sent after the `xdg-output` is created. I believe it might be a problem. We should remove these `if`s in KF 5.70. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D28245 To:

D25495: Fix Sonnet autodetect failing on Indian langs

This revision was automatically updated to reflect the committed changes. Closed by commit R246:2ce07be5dff3: Fix Sonnet autodetect failing on Indian langs (authored by waqar, committed by apol). REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » sonnet » kf5-qt5 FreeBSDQt5.14 - Build # 3 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/sonnet/job/kf5-qt5%20FreeBSDQt5.14/3/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Tue, 24 Mar 2020 15:47:06 + Build duration: 2 min 7 sec and counting JUnit Tests Name:

KDE CI: Frameworks » sonnet » kf5-qt5 SUSEQt5.12 - Build # 87 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/sonnet/job/kf5-qt5%20SUSEQt5.12/87/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 24 Mar 2020 15:47:06 + Build duration: 1 min 46 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » sonnet » kf5-qt5 SUSEQt5.13 - Build # 64 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/sonnet/job/kf5-qt5%20SUSEQt5.13/64/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 24 Mar 2020 15:47:06 + Build duration: 1 min 43 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » sonnet » kf5-qt5 WindowsMSVCQt5.14 - Build # 17 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/sonnet/job/kf5-qt5%20WindowsMSVCQt5.14/17/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Tue, 24 Mar 2020 15:47:06 + Build duration: 1 min 57 sec and counting JUnit Tests

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs

meven planned changes to this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26407 To: meven, #frameworks, ngraham, broulik, dfaure Cc: cfeck, anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28191: [KFontChooser] General code cleanup

ahmadsamir updated this revision to Diff 78375. ahmadsamir edited the summary of this revision. ahmadsamir edited the test plan for this revision. ahmadsamir added a comment. Tweak REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28191?vs=78299=78375

D28191: [KFontChooser] General code cleanup

ahmadsamir updated this revision to Diff 78376. ahmadsamir edited the summary of this revision. ahmadsamir edited the test plan for this revision. ahmadsamir added a comment. Fix, arcanist is REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE

D28244: GIT_SILENT minor code formatting

ahmadsamir updated this revision to Diff 78377. ahmadsamir added a comment. tweak REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28244?vs=78374=78377 BRANCH l-code-cleanup-2 (branched from master) REVISION DETAIL

D28245: [xdgoutput] Only send initial name and description if set

davidedmundson created this revision. davidedmundson added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY We hit this if we run an old kwin against new kwayland. Kwin

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 118 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/118/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 24 Mar 2020 16:38:57 + Build duration: 10 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.14 - Build # 3 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.14/3/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Tue, 24 Mar 2020 16:38:56 + Build duration: 12 min and counting JUnit Tests Name:

D28245: [xdgoutput] Only send initial name and description if set

davidedmundson added a comment. I interpreted the spec the same way when I wrote this...but we don't have a choice. > I believe it might be a problem From a QtWayland POV it's fine at least. > We should remove these ifs in KF 5.70. Why then? Removing them then would

D28191: [KFontChooser] General code cleanup

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons BRANCH l-kfontchooser (branched from master) REVISION DETAIL https://phabricator.kde.org/D28191 To: ahmadsamir, #frameworks, cfeck, apol, bport, dfaure Cc: kde-frameworks-devel,

Re: Problems in KWayland causes by API and ABI compatibility promises

There's another problem we're going to hit with kwayland at some point in the future. KWayland specifies the protocol version. This means, according to framework policies we might have a released kwin which suddenly gets a new protocol version of something being announced. I just had a near miss

D28246: [KFontChooser] Use one QFontDatabase object for the Private class

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, cfeck, apol, bport, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Minor optimisation by instantiating one QFontDatabase Object, and using it in

D28193: [KFontChooser] Use one QFontDatabase object for the ::Private class

ahmadsamir abandoned this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D28193 To: ahmadsamir, #frameworks, cfeck, apol, bport, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28246: [KFontChooser] Use one QFontDatabase object for the Private class

ahmadsamir abandoned this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D28246 To: ahmadsamir, #frameworks, cfeck, apol, bport, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28191: [KFontChooser] General code cleanup

This revision was automatically updated to reflect the committed changes. Closed by commit R236:f22c1864f5c8: [KFontChooser] General code cleanup (authored by ahmadsamir). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28191?vs=78376=78382 REVISION

D27873: sftp: do not show creation time when we do not know it

bruns added a comment. Looks ok now. Should be followed up by a corresponding change for ACCESS_TIME/MODIFICATION_TIME - both are optional as well. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27873 To: sitter, ngraham, bruns, meven Cc: meven, bruns,

  1   2   3   >