D28470: [PlasmaCore.IconItem] Refactor source handling for different types

kmaterka added a comment. In D28470#641230 , @davidre wrote: > In D28470#640468 , @cblack wrote: > > > Splitting into multiple classes seems like a good idea, but "strategy"? Seems like an odd

D24443: Add a plugin system

dvratil added inline comments. INLINE COMMENTS > calendarentry.cpp:36 > + > +CalendarEntry::~CalendarEntry() > +{ ` = default` (instead of empty body) > calendarentry.cpp:57 > +{ > +return ReadWrite; > +} Should that be `d->type`? How can implementations change it? Will implementation

D28470: [PlasmaCore.IconItem] Refactor source handling for different types

kmaterka updated this revision to Diff 79283. kmaterka added a comment. Change class name: *Strategy -> *Source REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28470?vs=79281=79283 BRANCH master REVISION DETAIL

D25079: [CopyJob] Increase the amount of data sendfile can copy at once

meven abandoned this revision. meven added a comment. In favor of D28555 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25079 To: meven, dfaure, #frameworks, davidedmundson Cc: ahmadsamir, sitter, apol, kde-frameworks-devel,

D28555: File ioslave : use Better setting for sendfile syscall

meven added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28555 To: meven, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28555: File ioslave : use Better setting for sendfile syscall

meven created this revision. meven added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Changes : - use sendfile when copying file bigger than 2 GB - copy 512 kB

T11627: Improve KIO asynchronicity

meven added a revision: D28555: File ioslave : use Better setting for sendfile syscall. TASK DETAIL https://phabricator.kde.org/T11627 To: meven Cc: ahartmetz, broulik, ognarb, #dolphin, #frameworks, meven, dfaure, nikolaik, pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas,

D28555: File ioslave : use Better setting for sendfile syscall

meven added a task: T11627: Improve KIO asynchronicity. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28555 To: meven, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28553: Rename stylesheet color ButtonFocus -> Highlight

davidhurka added a comment. Cuttlefish (Ubuntu release)? So that means all icons should be changed from Highlight to ButtonFocus? That would also affect colorful icons. Some of them have Highlight and ButtonFocus in the stylesheet, fortunately with the same color. REPOSITORY R266

D28555: File ioslave : use Better setting for sendfile syscall

dfaure added a comment. any idea what buff_src.st_size < 0x7FFF was for? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28555 To: meven, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28553: Rename stylesheet color ButtonFocus -> Highlight

ndavis added a comment. In D28553#641271 , @davidhurka wrote: > Cuttlefish (Ubuntu release)? > > So that means all icons should be changed from Highlight to ButtonFocus? That would also affect colorful icons. Some of them have Highlight and

D28555: File ioslave : use Better setting for sendfile syscall

broulik added a comment. > reduce the overhead of processedSize dbus progress notification in each iteration since it is called less often, adding some more speed. From what I recall in copy job the processed size in emitted by a timer and not every time a chunk got processed

D28553: Rename stylesheet color ButtonFocus -> Highlight

davidhurka abandoned this revision. davidhurka added a comment. Ok, then I’ll let you do it. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28553 To: davidhurka, ndavis Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28553: Rename stylesheet color ButtonFocus -> Highlight

davidhurka created this revision. davidhurka added a reviewer: ndavis. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidhurka requested review of this revision. REVISION SUMMARY This fixes the 3 icons with blue elements, which I recently modified. I used

D28421: Add static method to check start condition

kossebau added inline comments. INLINE COMMENTS > hchain wrote in kautostart.h:289 > I think you added it to the wrong method ;) Fixed with 79fea5fc4043be72f3addf8980d4d78ef04530ff REPOSITORY R309 KService REVISION

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.14 - Build # 7 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.14/7/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 04 Apr 2020 11:26:20 + Build duration: 2 min 8 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 300 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/300/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 04 Apr 2020 11:26:20 + Build duration: 2 min 11 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » breeze-icons » kf5-qt5 WindowsMSVCQt5.14 - Build # 76 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20WindowsMSVCQt5.14/76/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sat, 04 Apr 2020 11:26:19 + Build duration: 2 min 39 sec and counting JUnit Tests

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.14 - Build # 10 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.14/10/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 04 Apr 2020 11:26:20 + Build duration: 2 min 10 sec and counting JUnit Tests Name:

D28203: Move corner fold to top right in 24 icons

ndavis added a comment. Fixed it. I missed a few more symlinks that weren't relative in the review. I couldn't test it locally during review because `arc` can't download patches that convert a file into a symlink or vice versa. REPOSITORY R266 Breeze Icons REVISION DETAIL

D27951: Allow users to change dropAction to MoveAction through kdeglobals

trmdi abandoned this revision. trmdi added a comment. In D27951#641173 , @meven wrote: > In D27951#639386 , @trmdi wrote: > > > In D27951#639350 , @meven

D28203: Move corner fold to top right in 24 icons

kossebau added a comment. Yay for quick fixing, thanks (in name of KF release interest group) :) Do not forget to set this review request as Closed again if you are done here now (cannot tell myself). REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28203

D28515: [CommandLauncherJob] Add constructor taking an executable and argument list

broulik planned changes to this revision. broulik added a comment. Good idea REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28515 To: broulik, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.14 - Build # 9 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.14/9/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 04 Apr 2020 09:56:13 + Build duration: 43 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.14 - Build # 6 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.14/6/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 04 Apr 2020 09:56:13 + Build duration: 57 sec and counting CONSOLE OUTPUT [...truncated 184

D28552: [CommandLauncherJob] Also mention setDesktopName in constructor

This revision was automatically updated to reflect the committed changes. Closed by commit R241:60d7cfec0595: [CommandLauncherJob] Also mention setDesktopName in constructor (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 299 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/299/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 04 Apr 2020 09:56:13 + Build duration: 58 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » breeze-icons » kf5-qt5 WindowsMSVCQt5.14 - Build # 75 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20WindowsMSVCQt5.14/75/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sat, 04 Apr 2020 09:56:27 + Build duration: 1 min 35 sec and counting CONSOLE OUTPUT

D28470: [PlasmaCore.IconItem] Refactor source handling for different types

davidre added a comment. In D28470#640468 , @cblack wrote: > Splitting into multiple classes seems like a good idea, but "strategy"? Seems like an odd choice of name to me. I had assumed it's because of

D28553: Rename stylesheet color ButtonFocus -> Highlight

ndavis added a comment. Actually, I just tested the icons in Cuttlefish and apparently ButtonFocus works now, so it's preferred to Highlight. Sorry to give you the run around. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28553 To: davidhurka, ndavis Cc:

D28515: [CommandLauncherJob] Add constructor taking an executable and argument list

This revision was automatically updated to reflect the committed changes. Closed by commit R241:5f2be012c27d: [CommandLauncherJob] Add constructor taking an executable and argument list (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D27983: Make find-location show a magnifier on a map, to be different to mark-location

This revision was automatically updated to reflect the committed changes. Closed by commit R266:aff4a3e23d92: Make find-location show a magnifier on a map, to be different to mark-location (authored by davidhurka). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

D28203: Move corner fold to top right in 24 icons

davidhurka updated this revision to Diff 79272. davidhurka added a comment. Rebase on an initial commit which points to D28203 , not D28204 . - link 32px document-preview-archive and document-preview - Move corner

D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

bruns added inline comments. INLINE COMMENTS > jobtest.cpp:1510 > +{ > +// this test doesn't make sense on the CI as it's an LXC container with > one partition > +if (!otherTmpDirIsOnSamePartition()) { This should only apply to the `QVERIFY(device != otherDevice);` > bruns wrote in

D28540: Fix layout in DownloadItemsSheet

This revision was automatically updated to reflect the committed changes. Closed by commit R304:449d056a2d77: Fix layout in DownloadItemsSheet (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28540?vs=79226=79290 REVISION DETAIL

D28535: [KIO-MTP] Fix null pointer dereference

anthonyfieroni added a comment. Ok that's look good to me. We can move that code in constructor just before loop for storages, then use m_mtpdevice instead of raw device, but it looks like removed code is just a noise and it shouldn't present at all. +1 REPOSITORY R320 KIO Extras

D27455: FileWidgets: Ignore Return events from KDirOperator

This revision was automatically updated to reflect the committed changes. Closed by commit R241:6327a9f05eb2: FileWidgets: Ignore Return events from KDirOperator (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27455?vs=79039=79265 REVISION

D28515: [CommandLauncherJob] Add constructor taking an executable and argument list

broulik updated this revision to Diff 79267. broulik added a comment. This revision is now accepted and ready to land. - Add test for binary in path with space REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28515?vs=79189=79267 REVISION DETAIL

D28515: [CommandLauncherJob] Add constructor taking an executable and argument list

broulik requested review of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28515 To: broulik, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28513: smb: use prettyname.kio-discovery-wsd for hostname of wsdiscoveries

meven accepted this revision. meven added a comment. Seems good to me REPOSITORY R320 KIO Extras BRANCH smb-lazy-resolve REVISION DETAIL https://phabricator.kde.org/D28513 To: sitter, ngraham, meven Cc: kossebau, kde-frameworks-devel, kfm-devel, nikolaik, pberestov, iasensio,

D28520: Fix lifetime of slot in KIO-MTP

meven accepted this revision. REPOSITORY R320 KIO Extras BRANCH slotLifetime (branched from master) REVISION DETAIL https://phabricator.kde.org/D28520 To: feverfew, akrutzler, dfaure, elvisangelaccio, apol, meven Cc: apol, kde-frameworks-devel, kfm-devel, fvogt, nikolaik, pberestov,

T11627: Improve KIO asynchronicity

meven added a comment. I have tried using https://www.kdab.com/uiwatchdog-a-keepalive-monitor-for-the-gui-thread/ to see what makes the system stutter during file operation, it seems it is due to Breeze processing with styling loading, and QXcb* events. TASK DETAIL

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 33 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/33/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 04 Apr 2020 09:43:38 + Build duration: 8 min 45 sec and counting JUnit Tests Name:

D26113: Places: For mounted volume display mount points instead of description

meven added inline comments. INLINE COMMENTS > broulik wrote in kfileplacesitem.cpp:244 > What if it isn't mounted? `if (m_access)` checks this REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26113 To: meven, #frameworks, ngraham Cc: feverfew, bruns, broulik,

D26113: Places: For mounted volume display mount points instead of description

meven updated this revision to Diff 79277. meven marked 2 inline comments as done. meven added a comment. Clean superfluous variable REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26113?vs=71861=79277 BRANCH arcpatch-D26113 REVISION DETAIL

D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

bruns added inline comments. INLINE COMMENTS > meven wrote in jobtest.cpp:1524 > add `QCOMPARE(entry.count(), 2);` Its 'statDetails**With**Inode' not 'statDetailsInode**Only**' REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28478 To: ahmadsamir, #frameworks, dfaure,

D28421: Add static method to check start condition

davidedmundson added a comment. That was embarrassing, I shouldn't try and rush. Sorry. Thanks for cleaning up after me. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D28421 To: hchain, davidedmundson, broulik, dfaure, kossebau Cc: kde-frameworks-devel,

D28470: WIP: IconItem: Refactor source handling for different types

kmaterka marked 2 inline comments as done. kmaterka added inline comments. INLINE COMMENTS > cblack wrote in iconitem.cpp:58 > Is this class necessary? I feel like this class's behaviour should be what > its parent does without a child implementation. I wanted `IconItemStrategy` to be just an

D28421: Add static method to check start condition

hchain added inline comments. INLINE COMMENTS > davidedmundson wrote in kautostart.h:289 > Added. > https://commits.kde.org/kservice/ce83ae51bfc88be77573745ed8a4434393b2f9f1 I think you added it to the wrong method ;) REPOSITORY R309 KService REVISION DETAIL

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 32 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/32/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 04 Apr 2020 09:01:52 + Build duration: 41 min and counting JUnit Tests Name: projectroot

D28552: [CommandLauncherJob] Also mention setDesktopName in constructor

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28552 To: broulik, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

meven requested changes to this revision. meven added a comment. This revision now requires changes to proceed. I just want to keep as much checks as possible INLINE COMMENTS > jobtest.cpp:1524 > +QVERIFY(entry.contains(KIO::UDSEntry::UDS_DEVICE_ID)); > +

D26113: Places: For mounted volume display mount points instead of description

meven edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26113 To: meven, #frameworks, ngraham Cc: feverfew, bruns, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham

D28203: Move corner fold to top right in 24 icons

kossebau added a comment. Hi. Seems this broke the build somehow, please check: https://build.kde.org/view/Failing/job/Frameworks/job/breeze-icons/ Remember this is KF 5.69 branching WE, so needs fixing to not block the release. Do not shoot the messenger :) REPOSITORY R266 Breeze

D28470: WIP: IconItem: Refactor source handling for different types

kmaterka updated this revision to Diff 79281. kmaterka marked an inline comment as done. kmaterka added a comment. be consistent with old implementation REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28470?vs=79279=79281 BRANCH master

D28470: [PlasmaCore.IconItem] Refactor source handling for different types

kmaterka retitled this revision from "WIP: IconItem: Refactor source handling for different types" to "[PlasmaCore.IconItem] Refactor source handling for different types". kmaterka edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D24443: Add a plugin system

nicolasfella planned changes to this revision. nicolasfella added a comment. - single level hierarchy with a calendargroup object - calendar entry folded into calendar - calendar::open REPOSITORY R172 KCalendar Core REVISION DETAIL https://phabricator.kde.org/D24443 To:

D27951: Allow users to change dropAction to MoveAction through kdeglobals

meven added a comment. In D27951#639386 , @trmdi wrote: > In D27951#639350 , @meven wrote: > > > Anything that concerns a kdeconnet:/ url is handled by the kdeconnect ioslave, including the stat

D28203: Move corner fold to top right in 24 icons

davidre requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28203 To: davidhurka, #vdg, ndavis, ngraham, davidre Cc: davidre, kossebau, ngraham, kde-frameworks-devel, LeGast00n, cblack,

D28203: Move corner fold to top right in 24 icons

davidre reopened this revision. davidre added a comment. This broke the build. Please note that tagging is today REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28203 To: davidhurka, #vdg, ndavis, ngraham Cc: davidre, kossebau, ngraham, kde-frameworks-devel,

D28470: WIP: IconItem: Refactor source handling for different types

kmaterka updated this revision to Diff 79279. kmaterka added a comment. fix some silly errors REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28470?vs=79011=79279 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28470

D28203: Move corner fold to top right in 24 icons

davidre accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28203 To: davidhurka, #vdg, ndavis, ngraham, davidre Cc: davidre, kossebau, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2,

D28203: Move corner fold to top right in 24 icons

davidre closed this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28203 To: davidhurka, #vdg, ndavis, ngraham, davidre Cc: davidre, kossebau, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28515: [CommandLauncherJob] Add constructor taking an executable and argument list

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Awesome. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28515 To: broulik, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,

D28552: [CommandLauncherJob] Also mention setDesktopName in constructor

broulik created this revision. broulik added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY I think it's to be preferred over name + icon. REPOSITORY R241 KIO

D28203: Move corner fold to top right in 24 icons

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R266:2808396a7bb8: Move corner fold to top right in 24 icons (authored by davidhurka). REPOSITORY R266 Breeze Icons

D28203: Move corner fold to top right in 24 icons

davidhurka added a comment. I created revision D28204 accidentally when I tried to update this revision. That made my initial commit point to D28204 instead of D28203 , so I

D26113: Places: For mounted volume display mount points instead of description

bruns added a comment. In D26113#581228 , @ngraham wrote: > > As Vaults are not backed by an fstab entry, it would be the responsibility of Vaults to set a useful name (via x-gvfs-name). > > What I'm saying is that I think it makes sense for

D28203: Move corner fold to top right in 24 icons

davidre added a comment. Seems @kossebau was faster ;) REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28203 To: davidhurka, #vdg, ndavis, ngraham, davidre Cc: davidre, kossebau, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28203: Move corner fold to top right in 24 icons

davidhurka added a comment. @ndavis commited (excerpt): diff --git a/icons-dark/actions/22/document-export-ocal.svg b/icons-dark/actions/22/document-export-ocal.svg index 4bfca303..ace4fe41 12 --- a/icons-dark/actions/22/document-export-ocal.svg +++

D28555: File ioslave : use Better setting for sendfile syscall

meven added a comment. In D28555#641276 , @dfaure wrote: > any idea what buff_src.st_size < 0x7FFF was for? None, it does not makes sense to me, perhaps, we had an implementation limitation. In D28555#641277

Re: New Framework Review: KDAV

Thanks for the review! We are cutting it close again with the 20.04 deadline, but fortunately most of these findings aren't ABI-breaking :) The result was discussed in more detail at the (virtual) PIM sprint, summary below for the record. On Saturday, 4 April 2020 16:20:21 CEST Kevin Ottens

D28555: File ioslave : use Better setting for sendfile syscall

This revision was automatically updated to reflect the committed changes. Closed by commit R241:10cf5aca5b3d: File ioslave : use Better setting for sendfile syscall (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28555?vs=79284=79338 REVISION

D28555: File ioslave : use Better setting for sendfile syscall

meven edited the summary of this revision. REPOSITORY R241 KIO BRANCH sendfile-opt REVISION DETAIL https://phabricator.kde.org/D28555 To: meven, #frameworks, dfaure Cc: bruns, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham

D28555: File ioslave : use Better setting for sendfile syscall

bruns added a comment. @dfaure: probably this: man sendfile, NOTES > The original Linux sendfile() system call was not designed to handle large file offsets. Consequently, Linux 2.4 added sendfile64(), with a wider type for the offset argument. The glibc sendfile() wrapper

D28561: Remove border from format-border-set-* icons

davidhurka added a comment. There are 22px versions of these icons. They passed the auto-generation, because they use a different approach. They have a border, but it is not in ViewBackground, but in Text with transparency 0.1. Should I add such a border to the 16px version, or remove it in

D28561: Remove border from format-border-set-* icons

davidhurka created this revision. davidhurka added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidhurka requested review of this revision. REVISION SUMMARY These icons had a kind of border in ViewBackground color, which made them look

D28555: File ioslave : use Better setting for sendfile syscall

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Ah sorry, I missed the fact that one doesn't actually need to call sendfile64() explicitly. And if sendfile fails we have a fall back, so yeah, might as well try in all cases.

D28565: [QueryParser] Replace single-use helper with std::none_of

bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28565

D28570: Add 3mf thumbnail support

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL https://phabricator.kde.org/D28570 To: davidedmundson, broulik Cc: kde-frameworks-devel, kfm-devel, nikolaik, pberestov, iasensio, fprice, LeGast00n,

D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

ahmadsamir marked an inline comment as done. ahmadsamir added inline comments. INLINE COMMENTS > bruns wrote in jobtest.cpp:1510 > The first goal should be to test if it works at all, i.e. if there is an > UDS_DEVICE_ID/INODE at all. OK, that makes sense. Done. REPOSITORY R241 KIO REVISION

D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

ahmadsamir updated this revision to Diff 79339. ahmadsamir added a comment. Skip the smallest part of the unit test REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28478?vs=79315=79339 BRANCH l-statx (branched from master) REVISION DETAIL

D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

ahmadsamir updated this revision to Diff 79315. ahmadsamir marked 2 inline comments as done. ahmadsamir added a comment. - Change unit test name - More QCOMPARE() REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28478?vs=79133=79315 BRANCH l-statx (branched

D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

meven accepted this revision. meven added a comment. Nice, plus a nice test added. Give some time to others to have a final say before merging. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28478 To: ahmadsamir, #frameworks, dfaure, meven, bruns Cc:

D28555: File ioslave : use Better setting for sendfile syscall

meven edited the summary of this revision. REPOSITORY R241 KIO BRANCH sendfile-opt REVISION DETAIL https://phabricator.kde.org/D28555 To: meven, #frameworks, dfaure Cc: bruns, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham

T12641: Refactor KFileProtocol::copy

meven updated the task description. TASK DETAIL https://phabricator.kde.org/T12641 To: meven Cc: apol, dfaure, #frameworks, #dolphin, ognarb, broulik, meven, nikolaik, pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, spoorun,

D28573: Add 16px System Settings icon

manueljlin edited the summary of this revision. manueljlin added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28573 To: manueljlin, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28574: KRunner: Improve code snippet

alex created this revision. alex added reviewers: Plasma, davidedmundson, broulik, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. alex requested review of this revision. REVISION SUMMARY The code snippet now uses the Qt5 syntax for the signals and

D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

ahmadsamir added inline comments. INLINE COMMENTS > bruns wrote in jobtest.cpp:1510 > This should only apply to the `QVERIFY(device != otherDevice);` Why? The goal is to test if the UDS_DEVICE_ID is unique for individual partitions, which won't work unless there are two separate partitions.

D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

bruns added inline comments. INLINE COMMENTS > ahmadsamir wrote in jobtest.cpp:1510 > Why? The goal is to test if the UDS_DEVICE_ID is unique for individual > partitions, which won't work unless there are two separate partitions. The first goal should be to test if it works at all, i.e. if

D28561: Remove border from format-border-set-* icons

davidhurka edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28561 To: davidhurka, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28555: File ioslave : use Better setting for sendfile syscall

bruns added a comment. In D28555#641390 , @dfaure wrote: > Sounds like the size check should stay then. Pessimizing sendfile for everyone, for the sake of Linux 2.2.x users? REPOSITORY R241 KIO REVISION DETAIL

D28570: Add 3mf thumbnail support

davidedmundson created this revision. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY 3D Modelling Format is based on "Open Packaging Conventions" which is already

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 35 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/35/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 04 Apr 2020 18:52:59 + Build duration: 5 min 55 sec and counting JUnit Tests Name:

Re: New Framework Review: KDAV

Hello, On Saturday, 9 November 2019 12:33:54 CEST Volker Krause wrote: > during Akademy there was a request to promote KDAV from KDE PIM to > Frameworks for use by Plasma Mobile. KDAV is a framework that implements > the CalDav/ CardDav/GroupDav protocol on top of KIO's WebDav support. It > would

D28555: File ioslave : use Better setting for sendfile syscall

dfaure added a comment. Sounds like the size check should stay then. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28555 To: meven, #frameworks, dfaure Cc: bruns, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham

D28573: Add 16px System Settings icon

manueljlin created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. manueljlin requested review of this revision. REVISION SUMMARY Adds a pixel fitted icon for System Settings REPOSITORY R266 Breeze Icons REVISION DETAIL

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.14 - Build # 2 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.14/2/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 04 Apr 2020 22:14:41 + Build duration: 1 min 30 sec and counting BUILD ARTIFACTS

D28579: Improve the look of kcachegrind

ndavis updated this revision to Diff 79358. ndavis added a comment. Remove unused element REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28579?vs=79357=79358 BRANCH kcachegrind (branched from master) REVISION DETAIL

D28579: Improve the look of kcachegrind

ndavis updated this revision to Diff 79359. ndavis added a comment. Update breeze dark version REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28579?vs=79358=79359 BRANCH kcachegrind (branched from master) REVISION DETAIL

  1   2   >