D28679: [KPropertiesDialog] Disable changing remote dir icons

dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kpropertiesdialog.cpp:1285 > +// exclude remote dirs as changing the icon has no effect (bug > 205954) > +if (item.isLocalFile()|| item.url().scheme()

D28739: Close the database connection to prevent file descriptor leak

akandaurov added a reviewer: ivan. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D28739 To: akandaurov, ivan Cc: kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven,

D24773: kio_trash: Add size, modification, access and create date for trash:/

meven updated this revision to Diff 79813. meven marked 4 inline comments as done. meven added a comment. Fix typo, avoid allocations, improve variable naming REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24773?vs=79804=79813 BRANCH arcpatch-D24773_1

D28271: [KFontChooser] More code cleanup

This revision was automatically updated to reflect the committed changes. Closed by commit R236:11589f5e4166: [KFontChooser] More code cleanup (authored by ahmadsamir). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28271?vs=78986=79812 REVISION

D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

dfaure added a comment. In D28478#645702 , @ahmadsamir wrote: > I meant something like: > const int i = foo(); int is a very bad example for this reasoning. It's cheaper to copy an int than to use a reference. That's not the case for

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.14 - Build # 4 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.14/4/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 11 Apr 2020 09:25:16 + Build duration: 17 min and counting JUnit Tests Name:

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.14 - Build # 5 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.14/5/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 11 Apr 2020 09:28:23 + Build duration: 32 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.14 - Build # 4 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.14/4/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 11 Apr 2020 09:24:01 + Build duration: 37 min and counting JUnit Tests Name:

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.14 - Build # 7 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.14/7/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 11 Apr 2020 09:29:11 + Build duration: 43 min and counting JUnit Tests Name:

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.14 - Build # 9 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.14/9/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 11 Apr 2020 09:29:38 + Build duration: 44 min and counting JUnit Tests Name:

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 SUSEQt5.12 - Build # 129 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20SUSEQt5.12/129/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 11 Apr 2020 10:05:17 + Build duration: 6 min 52 sec and counting BUILD ARTIFACTS

Re: Update on Status of Gitlab Migration

On Sat, Apr 11, 2020 at 11:36 AM Ben Cooksley wrote: > > Should anyone have any questions on the above, please let us know. > Does the migration also mean that `git.kde.org` push URL will be retired and would need to be remapped to `invent.kde.org`? In that case, it would be good to have a

D20749: autotests: don't fail appstream test because of anything on stderr

dfaure added a comment. Similar to this... is it expected that a glib error makes the test fail? Is the error severe or harmless? CMake Error at /home/jenkins/workspace/Frameworks/kpackage/kf5-qt5 SUSEQt5.12/autotests/kpackagetoolappstreamtest.cmake:45 (message): appstream data

D27097: [KTextWidgets] Port from QRegExp to QRegularExpression

dfaure added a comment. CI doesn't like this commit. https://build.kde.org/job/Frameworks/job/ktextwidgets/job/kf5-qt5%20SUSEQt5.14/4/testReport/junit/projectroot/autotests/ktextwidgets_kfindtest/ FAIL! : TestKFind::testStaticFindRegexp(whole words ok) Compared values are not

D28406: Fix sonnet autodetect test failure

waqar added a comment. In D28406#644383 , @dfaure wrote: > @waqar ping? What do you think about my suggestion? If you agree, can you update the patch? Sorry I have been really busy at work, and overlooked the last email. I did plan to

D28274: [KFontChooser] Add a checkbox to toggle showing only monospaced fonts

ahmadsamir marked an inline comment as done. ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in kfontchooser.cpp:393 > would `true` be more readable? > > (same for the previous line, actually) Indeed; however onlyFixedCheckbox->setChecked(usingFixed) doesn't need to be in

D28756: [findreplace] Handle searching for WholeWordsOnly in Regex mode

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R310 KTextWidgets BRANCH l-wholewords (branched from master) REVISION DETAIL https://phabricator.kde.org/D28756 To: ahmadsamir, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack,

D28675: [KMimeTypeChooser] Add the ability to filter the treeview with a QSFPM

ahmadsamir updated this revision to Diff 79866. ahmadsamir added a comment. - Bring the comment column back, more filter-ability - Use QFontMetrics fm(fontMetrics()), more efficient as it gets copied REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE

Update on Status of Gitlab Migration

Good morning Community, I'm pleased to report that this week we reached a major milestone, with all the necessary technical components now being in place on our side for our migration to Gitlab to take place. This includes the replacement of the tooling that supports the anongit network, as well

KDE CI: Frameworks » sonnet » kf5-qt5 FreeBSDQt5.14 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/sonnet/job/kf5-qt5%20FreeBSDQt5.14/6/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 11 Apr 2020 09:31:28 + Build duration: 53 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.14 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.14/6/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 11 Apr 2020 09:31:22 + Build duration: 53 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » sonnet » kf5-qt5 SUSEQt5.14 - Build # 5 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/sonnet/job/kf5-qt5%20SUSEQt5.14/5/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 11 Apr 2020 11:53:06 + Build duration: 2 min 1 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » sonnet » kf5-qt5 SUSEQt5.12 - Build # 90 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/sonnet/job/kf5-qt5%20SUSEQt5.12/90/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 11 Apr 2020 11:53:06 + Build duration: 2 min 2 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » sonnet » kf5-qt5 WindowsMSVCQt5.14 - Build # 21 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/sonnet/job/kf5-qt5%20WindowsMSVCQt5.14/21/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sat, 11 Apr 2020 11:53:06 + Build duration: 1 min 57 sec and counting JUnit Tests Name:

D28406: Fix sonnet autodetect test failure

dfaure commandeered this revision. dfaure edited reviewers, added: waqar; removed: dfaure. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D28406 To: dfaure, waqar Cc: dfaure, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28406: Fix sonnet autodetect test failure

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit R246:78450298149e: Fix sonnet autodetect test failure (authored by waqar, committed by dfaure). CHANGED PRIOR TO COMMIT

KDE CI: Frameworks » sonnet » kf5-qt5 FreeBSDQt5.14 - Build # 7 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/sonnet/job/kf5-qt5%20FreeBSDQt5.14/7/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 11 Apr 2020 11:53:06 + Build duration: 57 sec and counting JUnit Tests Name: projectroot

D28745: Skipping catching of thumbnails on encrytped filesystems

marcingu created this revision. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. marcingu requested review of this revision. REVISION SUMMARY When generating thumbnails for directory, don't cache the previews for files stored on encrypted

D28742: Add KDialogJobUiDelegate(KJobUiDelegate::Flags) constructor

kossebau added a comment. Not into details, so if there is no sane default, forcing developers to pass something sane here make sense Second thought I also had was avoiding code which uses `nullptr` as arguments, which harms humans reading code a bit as in, "nullptr of what?!!" (compare

KDE CI: Frameworks » ktextwidgets » kf5-qt5 SUSEQt5.14 - Build # 6 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ktextwidgets/job/kf5-qt5%20SUSEQt5.14/6/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 11 Apr 2020 14:57:22 + Build duration: 1 min 59 sec and counting BUILD ARTIFACTS

D28742: Add KDialogJobUiDelegate(KJobUiDelegate::Flags) constructor

ervin accepted this revision. REPOSITORY R288 KJobWidgets BRANCH master REVISION DETAIL https://phabricator.kde.org/D28742 To: dfaure, broulik, davidedmundson, ervin Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

KDE CI: Frameworks » ktextwidgets » kf5-qt5 SUSEQt5.12 - Build # 79 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ktextwidgets/job/kf5-qt5%20SUSEQt5.12/79/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 11 Apr 2020 14:57:22 + Build duration: 1 min 58 sec and counting BUILD ARTIFACTS

D28742: Add KDialogJobUiDelegate(KJobUiDelegate::Flags) constructor

dfaure closed this revision. REPOSITORY R288 KJobWidgets REVISION DETAIL https://phabricator.kde.org/D28742 To: dfaure, broulik, davidedmundson, ervin Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28647: Fix KIO::Scheduler::emitReparseSlaveConfiguration() to work if called twice in same process

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. The new code structure screams for killing the bool and just extracting the code (all of slotReparseSlaveConfiguration) to a different method, called directly from

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.14 - Build # 7 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.14/7/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 11 Apr 2020 09:24:45 + Build duration: 11 min and counting JUnit Tests Name:

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.14 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.14/6/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 11 Apr 2020 09:29:12 + Build duration: 1 hr 14 min and counting BUILD ARTIFACTS

D28406: Fix sonnet autodetect test failure

dfaure added a comment. I pushed it with my changes included. The test is fixed: https://build.kde.org/job/Frameworks/view/Platform%20-%20SUSEQt5.12/job/sonnet/job/kf5-qt5%20SUSEQt5.12/ REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D28406 To: dfaure, waqar Cc:

D28739: activities: Close the database connection to prevent file descriptor leak

akandaurov retitled this revision from "Close the database connection to prevent file descriptor leak" to "activities: Close the database connection to prevent file descriptor leak". REVISION DETAIL https://phabricator.kde.org/D28739 To: akandaurov, ivan, meven Cc: meven,

D28742: Add KDialogJobUiDelegate(KJobUiDelegate::Flags) constructor

ervin accepted this revision. ervin added a comment. Indeed, good point. REPOSITORY R288 KJobWidgets BRANCH master REVISION DETAIL https://phabricator.kde.org/D28742 To: dfaure, broulik, davidedmundson, ervin Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D28742: Add KDialogJobUiDelegate(KJobUiDelegate::Flags) constructor

kossebau added a comment. `window` parameter wants API dox mentioning, though. And perhaps could be defaulted to nullptr, for use-cases which do not have a window at hand and are fine with any default? REPOSITORY R288 KJobWidgets BRANCH master REVISION DETAIL

D24773: kio_trash: Add size, modification, access and create date for trash:/

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH arcpatch-D24773_1 REVISION DETAIL https://phabricator.kde.org/D24773 To: meven, #frameworks, ngraham, elvisangelaccio, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh,

D25707: [renamedialog] Replace KIconLoader usage with QIcon::fromTheme

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. loadMimeTypeIcon isn't deprecated, so what's the reason? Porting away from kiconthemes? Should we actually deprecate it? REPOSITORY R241 KIO BRANCH rena REVISION DETAIL

D28271: [KFontChooser] More code cleanup

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons BRANCH l-kfontchooser-3 (branched from master) REVISION DETAIL https://phabricator.kde.org/D28271 To: ahmadsamir, #frameworks, dfaure, cfeck, apol, bport Cc:

D24773: kio_trash: Add size, modification, access and create date for trash:/

dfaure added inline comments. INLINE COMMENTS > kfileitem.h:349 > + * > + * Initialy only implemented for trash:/ > + * typo: Initially > trashimpl.cpp:1099 > + > +info = QFileInfo(trashPath); > +modified = info.lastModified(); Reusing info is more expensive (and

D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

ahmadsamir added a comment. In D28478#645682 , @dfaure wrote: > In D28478#645019 , @ahmadsamir wrote: > > > hmm... first this is a copy-paste "error" on my part, I personally never use & when the

D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

ahmadsamir added a comment. In D28478#645717 , @dfaure wrote: > In D28478#645702 , @ahmadsamir wrote: > > > I meant something like: > > const int i = foo(); > > > int is a very bad example

D28590: Add a QString Solid::Device::DisplayName, used in Fstab Device for network mounts

meven retitled this revision from "Add a QString Solid::Device::label, used in Fstab Device for network mounts" to "Add a QString Solid::Device::DisplayName, used in Fstab Device for network mounts". REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D28590 To: meven,

D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts

meven retitled this revision from "Add a QString Solid::Device::DisplayName, used in Fstab Device for network mounts" to "Add a QString Solid::Device::displayName, used in Fstab Device for network mounts". REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D28590 To: meven,

KDE CI: Frameworks » ktextwidgets » kf5-qt5 SUSEQt5.14 - Build # 5 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktextwidgets/job/kf5-qt5%20SUSEQt5.14/5/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 11 Apr 2020 09:29:18 + Build duration: 1 hr 7 min and counting BUILD ARTIFACTS

D28743: Port kruntest to ApplicationLauncherJob

dfaure created this revision. dfaure added reviewers: broulik, davidedmundson, ervin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY NO_CHANGELOG TEST PLAN The "run(doesnotexist, no url)" button

D28274: [KFontChooser] Add a checkbox to toggle showing only monospaced fonts

ahmadsamir updated this revision to Diff 79823. ahmadsamir added a comment. Handle the case where KFontChooser::FixedFontsOnly is set, the fixedOnlyCheckBox should be shown as "checked" from the get go. REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE

D28726: [KJS] Port QRegExp to QRegularExpression

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R314 KJs BRANCH l-qregularexpression (branched from master) REVISION DETAIL https://phabricator.kde.org/D28726 To: ahmadsamir, #frameworks, porten, apol Cc: kde-frameworks-devel, LeGast00n, cblack,

D28742: Add KDialogJobUiDelegate(KJobUiDelegate::Flags) constructor

dfaure marked an inline comment as done. dfaure added inline comments. INLINE COMMENTS > kossebau wrote in kdialogjobuidelegate.h:51 > Why no explicit? good point REPOSITORY R288 KJobWidgets BRANCH master REVISION DETAIL https://phabricator.kde.org/D28742 To: dfaure, broulik,

D28742: Add KDialogJobUiDelegate(KJobUiDelegate::Flags) constructor

kossebau added inline comments. INLINE COMMENTS > kdialogjobuidelegate.h:51 > + */ > +KDialogJobUiDelegate(KJobUiDelegate::Flags flags); // KF6 TODO merge > with default constructor, using AutoHandlingDisabled as default value > + Why no explicit? REPOSITORY R288 KJobWidgets BRANCH

D28741: [KJobUiDelegate] Add AutoHandlingEnabled flag

dfaure closed this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D28741 To: dfaure, broulik, davidedmundson, ervin Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.14 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.14/8/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 11 Apr 2020 13:48:37 + Build duration: 1 min 38 sec and counting JUnit Tests Name:

KDE CI: Frameworks » ktextwidgets » kf5-qt5 WindowsMSVCQt5.14 - Build # 19 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ktextwidgets/job/kf5-qt5%20WindowsMSVCQt5.14/19/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sat, 11 Apr 2020 14:57:22 + Build duration: 5 min 1 sec and counting JUnit Tests

D28739: activities: Close the database connection to prevent file descriptor leak

akandaurov added a comment. Yes, I don't have an account, so I'll need someone to land it, thanks. REVISION DETAIL https://phabricator.kde.org/D28739 To: akandaurov, ivan, meven Cc: meven, kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, iasensio, fprice, LeGast00n, cblack,

D25707: [renamedialog] Replace KIconLoader usage with QIcon::fromTheme

dfaure added a comment. OK. Then let me change my comment to: please document in kiconloader.h how to port away from loadMimeTypeIcon, even if it's not actually deprecated. I remember wondering the same thing at one point. REPOSITORY R241 KIO BRANCH rena REVISION DETAIL

D25707: [renamedialog] Replace KIconLoader usage with QIcon::fromTheme

ahmadsamir added a comment. In D25707#645676 , @dfaure wrote: > loadMimeTypeIcon isn't deprecated, so what's the reason? Porting away from kiconthemes? Should we actually deprecate it? It's been going on for a while

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.14 - Build # 7 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.14/7/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 11 Apr 2020 09:25:03 + Build duration: 13 min and counting JUnit Tests Name:

KDE CI: Frameworks » sonnet » kf5-qt5 SUSEQt5.12 - Build # 89 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/sonnet/job/kf5-qt5%20SUSEQt5.12/89/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 11 Apr 2020 09:31:27 + Build duration: 38 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » sonnet » kf5-qt5 SUSEQt5.14 - Build # 4 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/sonnet/job/kf5-qt5%20SUSEQt5.14/4/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 11 Apr 2020 09:31:27 + Build duration: 1 hr 18 min and counting BUILD ARTIFACTS

D28742: Add KDialogJobUiDelegate(KJobUiDelegate::Flags) constructor

dfaure created this revision. dfaure added reviewers: broulik, davidedmundson, ervin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY Requires: D28741 TEST PLAN

D28742: Add KDialogJobUiDelegate(KJobUiDelegate::Flags) constructor

dfaure updated this revision to Diff 79848. dfaure added a comment. Add QWidget *window parameter. Even better, no? Needed for dialog boxes to respect stacking order, centering to parent, focus going back to parent after closing... REPOSITORY R288 KJobWidgets CHANGES SINCE LAST

D28755: Breeze Icons cannot be built from read-only source location

marten updated this revision to Diff 79867. marten added a comment. Yes, that would mean fewer changes to the validate_svg.sh script. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28755?vs=79845=79867 REVISION DETAIL

D28742: Add KDialogJobUiDelegate(KJobUiDelegate::Flags) constructor

kossebau added a comment. (nullptr used as arguments always make me consider finally working on a patch to add to normal kdevelop the feature "Show argument names at call site" like demoed here among other things: https://kate-editor.org/wp-content/uploads/2018/08/inline-note-anim.gif so

D28758: [KFontChooser] Make the code slightly more readable

This revision was automatically updated to reflect the committed changes. Closed by commit R236:9e97265723f2: [KFontChooser] Make the code slightly more readable (authored by ahmadsamir). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE

D28675: [KMimeTypeChooser] Add the ability to filter the treeview with a QSFPM

This revision was automatically updated to reflect the committed changes. Closed by commit R236:75298895a5e3: [KMimeTypeChooser] Add the ability to filter the treeview with a QSFPM (authored by ahmadsamir). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 45 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/45/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 11 Apr 2020 09:27:07 + Build duration: 30 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » ktextwidgets » kf5-qt5 SUSEQt5.12 - Build # 78 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktextwidgets/job/kf5-qt5%20SUSEQt5.12/78/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 11 Apr 2020 09:29:19 + Build duration: 29 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.14 - Build # 8 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.14/8/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 11 Apr 2020 09:24:46 + Build duration: 56 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 46 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/46/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 11 Apr 2020 09:57:57 + Build duration: 33 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.14 - Build # 5 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.14/5/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 11 Apr 2020 09:28:23 + Build duration: 1 hr 2 min and counting BUILD ARTIFACTS

D28741: [KJobUiDelegate] Add AutoHandlingEnabled flag

dfaure created this revision. dfaure added reviewers: broulik, davidedmundson, ervin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY This allows to simplify code from KDialogJobUiDelegate

D28741: [KJobUiDelegate] Add AutoHandlingEnabled flag

broulik added a comment. +1 REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D28741 To: dfaure, broulik, davidedmundson, ervin Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28739: Close the database connection to prevent file descriptor leak

akandaurov updated this revision to Diff 79827. akandaurov added a comment. Added indentation. The block is suggested by the Qt Documentation . Without it, a warning will be thrown: QSqlDatabasePrivate::removeDatabase:

D28755: Breeze Icons cannot be built from read-only source location

marten created this revision. marten added a reviewer: Breeze. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. marten requested review of this revision. REVISION SUMMARY In the situation, for example, where a master source tree may be shared among a number

D28726: [KJS] Port QRegExp to QRegularExpression

porten accepted this revision. REPOSITORY R314 KJs BRANCH l-qregularexpression (branched from master) REVISION DETAIL https://phabricator.kde.org/D28726 To: ahmadsamir, #frameworks, porten, apol Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28742: Add KDialogJobUiDelegate(KJobUiDelegate::Flags) constructor

dfaure added a comment. In D28742#646009 , @kossebau wrote: > `window` parameter wants API dox mentioning, though. Oops, I thought I did that. Fixed. > And perhaps could be defaulted to nullptr, for use-cases which do not have a

D28274: [KFontChooser] Add a checkbox to toggle showing only monospaced fonts

ahmadsamir updated this revision to Diff 79861. ahmadsamir added a comment. A better location for onlyFixedCheckbox->setChecked() is next to its siblings REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28274?vs=79823=79861 BRANCH

D28742: Add KDialogJobUiDelegate(KJobUiDelegate::Flags) constructor

ervin added a comment. Agreed, nullptr is going to be the boolean flag of our time, before it was 0 though, so still an improvement. ;-) More seriously, here I'm not sure how to avoid it, at least it's a case of "if you feel like passing nullptr here you might be doing something wrong".

D28743: Port kruntest to ApplicationLauncherJob

dfaure closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28743 To: dfaure, broulik, davidedmundson, ervin Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

dfaure added a comment. In D28478#645019 , @ahmadsamir wrote: > hmm... first this is a copy-paste "error" on my part, I personally never use & when the RHS is a temporary (I don't see the point). The point is to avoid a copy ;-) If

D28734: Port to Aether Bootstrap 4

ochurlaud accepted this revision. ochurlaud added a comment. This revision is now accepted and ready to land. OK for me REPOSITORY R264 KApiDox BRANCH cblack+ognarb/bootstrap-4 (branched from master) REVISION DETAIL https://phabricator.kde.org/D28734 To: cblack, #vdg, ochurlaud Cc:

D28679: [KPropertiesDialog] Disable changing remote dir icons

This revision was automatically updated to reflect the committed changes. Closed by commit R241:a2335335ecfe: [KPropertiesDialog] Disable changing remote dir icons (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28679?vs=79814=79815

D28675: [KMimeTypeChooser] Add the ability to filter the treeview with a QSFPM

dfaure added a comment. Nice work. But can you give the reasoning for removing the comment column? For non-english speakers this might be the only thing that's actually readable? I'm also curious about the use of QStandardItemModel which I consider to be at best a class for unittesting

D28679: [KPropertiesDialog] Disable changing remote dir icons

ahmadsamir updated this revision to Diff 79814. ahmadsamir added a comment. Rebase; fix coding style REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28679?vs=79766=79814 BRANCH l-kprop (branched from master) REVISION DETAIL

KDE CI: Frameworks » kbookmarks » kf5-qt5 WindowsMSVCQt5.14 - Build # 19 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20WindowsMSVCQt5.14/19/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sat, 11 Apr 2020 09:23:56 + Build duration: 22 min and counting JUnit Tests Name:

KDE CI: Frameworks » ktextwidgets » kf5-qt5 FreeBSDQt5.14 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktextwidgets/job/kf5-qt5%20FreeBSDQt5.14/6/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 11 Apr 2020 09:29:18 + Build duration: 37 min and counting JUnit Tests Name:

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 SUSEQt5.12 - Build # 128 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20SUSEQt5.12/128/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 11 Apr 2020 09:29:44 + Build duration: 35 min and counting BUILD ARTIFACTS

Re: Update on Status of Gitlab Migration

On Sat, Apr 11, 2020 at 11:36 AM Ben Cooksley wrote: > > To help assist with this, it would be appreciated if all holders of a > KDE Developer account could please login on our Gitlab instance (at > https://invent.kde.org/) and ensure they are listed as a 'Developer' > of the KDE group. You can

D28745: Skipping catching of thumbnails on encrytped filesystems

marcingu added a dependency: D28746: Show previews on encrypted filesystems. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D28745 To: marcingu Cc: kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde,

D28746: Show previews on encrypted filesystems

marcingu added a dependent revision: D28745: Skipping catching of thumbnails on encrytped filesystems. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28746 To: marcingu Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28746: Show previews on encrypted filesystems

marcingu created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. marcingu requested review of this revision. REVISION SUMMARY Instead of skipping generating previews on encrypted filesystems, do create them but don't cache. BUG: 411919

D28739: Close the database connection to prevent file descriptor leak

meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. Too bad we have so many lines to change. Could you maybe add some context to your commit comment like `activities: Close the database connection to prevent file descriptor leak`

D28743: Port kruntest to ApplicationLauncherJob

ervin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D28743 To: dfaure, broulik, davidedmundson, ervin Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.14 - Build # 9 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.14/9/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 11 Apr 2020 13:50:17 + Build duration: 1 min 29 sec and counting JUnit Tests Name:

D28742: Add KDialogJobUiDelegate(KJobUiDelegate::Flags) constructor

dfaure updated this revision to Diff 79840. dfaure marked an inline comment as done. dfaure added a comment. explicit REPOSITORY R288 KJobWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28742?vs=79820=79840 BRANCH master REVISION DETAIL

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.14 - Build # 9 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.14/9/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 11 Apr 2020 13:48:37 + Build duration: 3 min 16 sec and counting BUILD ARTIFACTS

  1   2   >