D26131: Braces around for, break early.

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  I'd remove the space after '!' and make the bool const, but I'm nitpicking, 
you can also push as is.
  
  cbegin/cend wouldn't change anything on a const container.

REPOSITORY
  R237 KConfig

BRANCH
  arcpatch-D26131

REVISION DETAIL
  https://phabricator.kde.org/D26131

To: tcanabrava, ervin, dfaure
Cc: kossebau, ervin, patrickelectric, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham, bruns

D28811: WIP: Use CSS grid to improve layout

[Carl Schwan]

ognarb updated this revision to Diff 80156.
ognarb added a comment.


  Add NoScript support

REPOSITORY
  R264 KApiDox

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28811?vs=80155=80156

BRANCH
  flex-grid

REVISION DETAIL
  https://phabricator.kde.org/D28811

AFFECTED FILES
  src/kapidox/data/htmlresource/css/kapidox.css
  src/kapidox/data/htmlresource/css/kapidox.scss
  src/kapidox/data/templates/base.html
  src/kapidox/data/templates/subgroup-sidebar.html

To: ognarb
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, michaelh, ngraham, bruns, skadinna

D24695: Add a KF6 TODO to make KXMLGUIClient generic over a state enum

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Can go in, but I'd still suggest starting the separate class now.

REPOSITORY
  R263 KXmlGui

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24695

To: meven, #frameworks, kossebau, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D7563: Add privilegeExecution field to file protocol description

[Nathaniel Graham]

ngraham added a comment.


  @chinmoyr phab reports that this has a missing dependency/patch base. Is 
there some unmerged patch that's left to do, or does it just need a rebase on 
master?

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7563

To: chinmoyr, #frameworks, dfaure
Cc: feverfew, mreeves, mati865, ngraham, elvisangelaccio

D28819: [KRichTextEdit] Always treat key press as single modification in undo stack

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R310 KTextWidgets

BRANCH
  single-undo (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28819

To: poboiko, #frameworks, mlaurent, dfaure
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D28811: Add drawer on mobile and clean code

[Carl Schwan]

ognarb retitled this revision from "WIP: Use CSS grid to improve layout" to 
"Add drawer on mobile and clean code".
ognarb edited the summary of this revision.
ognarb edited the test plan for this revision.

REPOSITORY
  R264 KApiDox

REVISION DETAIL
  https://phabricator.kde.org/D28811

To: ognarb, cblack, ochurlaud
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, michaelh, ngraham, bruns, skadinna

D25443: [chmodjob] Port away from QLinkedList

[Nicolas Fella]

nicolasfella edited the summary of this revision.

REPOSITORY
  R241 KIO

BRANCH
  ll

REVISION DETAIL
  https://phabricator.kde.org/D25443

To: nicolasfella, #frameworks, dfaure
Cc: dfaure, bruns, fabiank, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham

D28839: [PostingIterator] Make sure skipTo also works for first element

[Stefan Brüns]

bruns added a dependent revision: D28844: [PhraseAndIterator] Replace recursive 
next() implementation.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28839

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28844: [PhraseAndIterator] Replace recursive next() implementation

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  This changes the code for the PhraseAndIterator in the
  same way as done for the AndPostingIterator in D28843 
.
  
  The only difference is the additional
  checkIfPositionsMatch in the break criterion
  
  Depends on D28839 

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28844

AFFECTED FILES
  src/engine/phraseanditerator.cpp
  src/engine/phraseanditerator.h

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28470: [PlasmaCore.IconItem] Refactor source handling for different types

[Konrad Materka]

kmaterka updated this revision to Diff 80148.
kmaterka marked an inline comment as done.
kmaterka added a comment.


  Do not inherit from QObject

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28470?vs=79283=80148

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28470

AFFECTED FILES
  src/declarativeimports/core/iconitem.cpp
  src/declarativeimports/core/iconitem.h

To: kmaterka, #plasma, broulik, apol, davidedmundson
Cc: mart, davidre, cblack, kde-frameworks-devel, #plasma, LeGast00n, michaelh, 
ngraham, bruns

D28834: Add metadata properties to calendar

[Nicolas Fella]

nicolasfella marked an inline comment as done.

REPOSITORY
  R172 KCalendar Core

REVISION DETAIL
  https://phabricator.kde.org/D28834

To: nicolasfella, #frameworks, #kde_pim, vkrause
Cc: winterz, kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, vkrause, 
mlaurent, knauss, dvratil

D28834: Add metadata properties to calendar

[Nicolas Fella]

nicolasfella updated this revision to Diff 80150.
nicolasfella added a comment.


  - default to ReadWrite
  - rename icon to iconname to reflect that it's just the name

REPOSITORY
  R172 KCalendar Core

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28834?vs=80140=80150

BRANCH
  props

REVISION DETAIL
  https://phabricator.kde.org/D28834

AFFECTED FILES
  src/calendar.cpp
  src/calendar.h
  src/calendar_p.h

To: nicolasfella, #frameworks, #kde_pim, vkrause
Cc: winterz, kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, vkrause, 
mlaurent, knauss, dvratil

D24887: WIP slave command behavior assertion system

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  After much delay some replies but there are yet more questions in 
here

INLINE COMMENTS

> commands_p.h:27
>  {
> +#pragma message "this is awkward since this causes symbols on the public KIO 
> entity"
> +Q_NAMESPACE

parse error

> slavebase.cpp:96
> +
> +#pragma message "pretty sure this isn't safe WRT static init order"
> +/**

why? does another global ctor use it?

It's safe. It's just costly -- happens in each and every process that links to 
KIO.

Maybe this should be all in NDEBUG anyhow?

> slavebase.cpp:128
> +//   * position lacks any documentation
> +// * trash listdir calls totalsize() (via listroot)
> +// * applications listdir calls totalsize()

In order to get progress information when listing very large directories, the 
idea used to be "emit totalSize(number of files) from listDir()".

Then kdelibs4 commit 23ba25b6505dc7 
 
changed the logic for the batching in KIO and this information is no longer 
necessary.

I just removed outdated docu from slavebase.h in commit 2261f2045c0a 
 
(the kdelibs4 commit removed most of it).

I'm wondering how ListJob can emit percent though, as comments over there say, 
without knowing about the totalsize. Something seems amiss here.
I can see how batching (based on time) doesn't need to know the total number of 
items, but progress information surely does...

And in fact AFAICS this information does end up in ListJob, and is used there 
to calculate progress information.
So I was wrong in today's commit, and that kdelibs4 commit was wrong in 
removing that docu too.
This is useful, and slaves should emit it.

The porting to KJob turned a simple int into something explicitly called 
"Bytes" though, so it looks even more like a hack than it did before (see 
SimpleJobPrivate::slotTotalSize, also called from ListJob). 
ListJob should have its own slot, and use Files instead of Bytes.

kio_file should also emit totalSize, 1) for slow network-mounted directories, 
2) so that all this can be unittested.

One question, 3 TODOs, this is going to be a long patch to review ;-)

> slavebase.cpp:131
> +// * settings listdir calls totalsize()
> +// * desktop listdir calls processedsize()
> +// * remote listDir calls totalSize()

Sounds wrong (i.e. but g in kio_desktop), listjob takes care of that.

> slavebase.cpp:137
> +#pragma message "deal with not codified expectations"
> +// * during get mimetype should be emitted before data (req: 
> mimetype mustn't be after data?)
> +// * canResume has two variants that should be called at the 
> beginning of get/put (req: mustn't be after data/written?)

Right. This allows to pick the app based on mimetype, and it will get all the 
data.

> slavebase.cpp:139
> +// * canResume has two variants that should be called at the 
> beginning of get/put (req: mustn't be after data/written?)
> +// * listDir should call listEntry --> not really something to warn 
> about, a dir may be empty
> +// * stat should call statEntry --> unless error?

right

> slavebase.cpp:140
> +// * listDir should call listEntry --> not really something to warn 
> about, a dir may be empty
> +// * stat should call statEntry --> unless error?
> +

right, on error it won't call statEntry

> slavebase.cpp:185
> +#pragma message "deal with commands I don't know expectations for"
> +case CMD_SLAVE_CONNECT:
> +case CMD_SLAVE_HOLD:

That's internal, doesn't get to SlaveBase.

> slavebase.cpp:186
> +case CMD_SLAVE_CONNECT:
> +case CMD_SLAVE_HOLD:
> +case CMD_NONE:

same

> slavebase.cpp:187
> +case CMD_SLAVE_HOLD:
> +case CMD_NONE:
> +case CMD_TESTDIR:

That's a reply (slave->app). No expectations, since it's the other way around.

> slavebase.cpp:188
> +case CMD_NONE:
> +case CMD_TESTDIR:
> +case CMD_SPECIAL:

unused, should be removed in KF6

> slavebase.cpp:189
> +case CMD_TESTDIR:
> +case CMD_SPECIAL:
> +case CMD_REPARSECONFIGURATION:

depends on the subcommand, as you documented in slavebase.h

> slavebase.cpp:190
> +case CMD_SPECIAL:
> +case CMD_REPARSECONFIGURATION:
> +case CMD_META_DATA:

fire-and-forget command app->slave, no expectations.

> slavebase.cpp:191
> +case CMD_REPARSECONFIGURATION:
> +case CMD_META_DATA:
> +case CMD_SUBURL:

handled internally in slavebase.cpp, doesn't get to the SlaveBase subclass

> slavebase.cpp:192
> +case CMD_META_DATA:
> +case CMD_SUBURL:
> +case CMD_MESSAGEBOXANSWER:

Obsolete. There's much cleanup to be done around that stuff in KF6. Unless 
someone feels like 

D28834: Add metadata properties to calendar

[Allen Winter]

winterz added a comment.


  looks good.
  nice touch using Q_EMIT.

INLINE COMMENTS

> calendar_p.h:81
> +QString mIcon;
> +CalendarType mType;
>  };

CalendarType mType = ReadWrite ?

REPOSITORY
  R172 KCalendar Core

REVISION DETAIL
  https://phabricator.kde.org/D28834

To: nicolasfella, #frameworks, #kde_pim, vkrause
Cc: winterz, kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, vkrause, 
mlaurent, knauss, dvratil

D28834: Add metadata properties to calendar

[Allen Winter]

winterz accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R172 KCalendar Core

BRANCH
  props

REVISION DETAIL
  https://phabricator.kde.org/D28834

To: nicolasfella, #frameworks, #kde_pim, vkrause, winterz
Cc: winterz, kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, vkrause, 
mlaurent, knauss, dvratil

D28834: Add metadata properties to calendar

[Allen Winter]

winterz added a comment.


  I don't know how things are done in frameworks but it seems to me that the 
KF5_VERSION (see top of kcalendarcore/CMakeLists.txt) needs to become 5.70.0 now

REPOSITORY
  R172 KCalendar Core

BRANCH
  props

REVISION DETAIL
  https://phabricator.kde.org/D28834

To: nicolasfella, #frameworks, #kde_pim, vkrause, winterz
Cc: winterz, kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, vkrause, 
mlaurent, knauss, dvratil

D28811: WIP: Use CSS grid to improve layout

[Carl Schwan]

ognarb updated this revision to Diff 80155.
ognarb added a comment.


  - Add drawer on mobile (with JS)
  - Fix some layout issues

REPOSITORY
  R264 KApiDox

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28811?vs=80057=80155

BRANCH
  flex-grid

REVISION DETAIL
  https://phabricator.kde.org/D28811

AFFECTED FILES
  src/kapidox/data/htmlresource/css/kapidox.css
  src/kapidox/data/htmlresource/css/kapidox.scss
  src/kapidox/data/templates/base.html
  src/kapidox/data/templates/subgroup-sidebar.html

To: ognarb
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, michaelh, ngraham, bruns, skadinna

D28834: Add metadata properties to calendar

[Volker Krause]

vkrause added a comment.


  In D28834#648405 , @winterz wrote:
  
  > I don't know how things are done in frameworks but it seems to me that the 
KF5_VERSION (see top of kcalendarcore/CMakeLists.txt) needs to become 5.70.0 now
  
  
  This is handled automatically, no need to change this.

INLINE COMMENTS

> calendar.h:101
> +*/
> +enum CalendarType
> +{

As already noted in the previous review, "type" isn't the best naming for 
something that is about access control/permission IMHO.

A possible alternative name could be something like "AccessMode", or maybe even 
just bool isReadOnly.

REPOSITORY
  R172 KCalendar Core

BRANCH
  props

REVISION DETAIL
  https://phabricator.kde.org/D28834

To: nicolasfella, #frameworks, #kde_pim, vkrause, winterz
Cc: winterz, kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, vkrause, 
mlaurent, knauss, dvratil

D25443: [chmodjob] Port away from QLinkedList

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  (remember to s/list/stack/ in the commit log)

REPOSITORY
  R241 KIO

BRANCH
  ll

REVISION DETAIL
  https://phabricator.kde.org/D25443

To: nicolasfella, #frameworks, dfaure
Cc: dfaure, bruns, fabiank, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham

D19913: [plasma-desktop] make it compiles without foreach

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Looks like this got lost/abandoned? It's painful to review (because it's so 
long), but it shouldn't be lost work...
  
  Can you rebase and see if it still applies?
  
  Maybe in the future better split this up into multiple patches so it can land 
in chunks instead of getting stuck forever

INLINE COMMENTS

> broulik wrote in daysmodel.cpp:171
> While at it `const QDate &`

Actually better not, a QDate is just a wrapper for a qint64, with a generated 
copy constructor (so it's just "copying" a qint64)

> corona.cpp:467
>  KConfigGroup containmentsGroup(cg, "Containments");
> -foreach (const Containment *containment, containments) {
> +for (const Containment *containment : qAsConst(containments)) {
>  QString cid = QString::number(containment->id());

(already const, this method is const)

> apol wrote in pluginloader.cpp:567
> shouldn't it be const?

(it is now)

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19913

To: mlaurent, dfaure
Cc: broulik, apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D28843: [AndPostingIterator] Replace recursive next() implementation

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The next() call will recurse once for each document in the first set
  until all iterators align, which is especially bad when the first term
  is common. It will only advance the first iterator just by one, although
  it could skip to the largest id in the set.
  
  Use skipTo on each iterator until none of the iterators moves forward,
  and in case the iterator has moved use the new position as new lower
  bound. If one of of the iterators only contains a small set, the
  iterators on average will be moved much further in each round.
  
  As skipTo(...) and next() are mostly identical with this approach next()
  can be trivially implemented with skipTo.
  
  Depends on D28839 

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28843

AFFECTED FILES
  src/engine/andpostingiterator.cpp
  src/engine/andpostingiterator.h

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28839: [PostingIterator] Make sure skipTo also works for first element

[Stefan Brüns]

bruns added a dependent revision: D28843: [AndPostingIterator] Replace 
recursive next() implementation.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28839

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D22705: Deprecate KRun::runService

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Should now point to ApplicationLauncherJob.
  
  And please consider porting the users, not just deprecating and letting 
others do the porting.
  
  I'm taking care of run() and runCommand() at the moment.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D22705

To: nicolasfella, dfaure
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28811: WIP: Use CSS grid to improve layout

[Carl Schwan]

ognarb edited the summary of this revision.
ognarb added reviewers: cblack, ochurlaud.

REPOSITORY
  R264 KApiDox

REVISION DETAIL
  https://phabricator.kde.org/D28811

To: ognarb, cblack, ochurlaud
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, michaelh, ngraham, bruns, skadinna

D28765: KSettings::Dialog: add support for KPluginInfos without a KService

[David Faure]

dfaure added a comment.


  For KF6 we could also just replace KCModuleInfo with KPluginInfo. It really 
doesn't provide anything on top

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D28765

To: dfaure, pino, broulik, mart, davidedmundson
Cc: cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D28839: [PostingIterator] Make sure skipTo also works for first element

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  In case next() has never been called on an iterator, docId() returns 0
  (it points before the first element). Only break the loop when next()
  returns 0.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28839

AFFECTED FILES
  src/engine/postingiterator.cpp

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D27385: [RFC] Return error instead of aborting when receiving an unexpected answer

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  I don't understand what these "external causes" might be.
  
  The bug report doesn't say more other than "happens after a suspend".
  This needs further debugging IMHO.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27385

To: fifr, #frameworks, dfaure, meven
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D24025: Don't use KCrash on Android

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  see Volker's comment

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24025

To: nicolasfella, dfaure
Cc: vkrause, apol, broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 545 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/545/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 14 Apr 2020 21:26:59 +
 Build duration:
18 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.70.0.xmllogs/KF5KIO/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 55 test(s), Skipped: 0 test(s), Total: 55 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(276/412)67%
(276/412)56%
(35471/62791)40%
(17952/44369)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(60/60)100%
(60/60)96%
(10112/10582)46%
(4728/10192)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(105/119)88%
(105/119)60%
(8739/14659)51%
(4538/8849)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4694/8342)43%
(2081/4826)src.gui100%
(5/5)100%
(5/5)81%
(332/412)58%
(163/280)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(711/1286)41%
(423/1036)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(646/1375)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1791/4287)36%
(1311/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(74/270)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
 

D28831: Add note about porting loadMimeTypeIcon

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  OK, for the simple case (no overlays, no extraction of path). More complete 
documentation would include the args for QIcon::pixmap but OK, very often we 
just port to QIcon instead.

REPOSITORY
  R302 KIconThemes

BRANCH
  mime

REVISION DETAIL
  https://phabricator.kde.org/D28831

To: nicolasfella, #frameworks, dfaure
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D19913: [plasma-desktop] make it compiles without foreach

[Nicolas Fella]

nicolasfella added a comment.


  The title says plasma-desktop, but this is plasma-framework?

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19913

To: mlaurent, dfaure
Cc: nicolasfella, broulik, apol, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham, bruns

D28839: [PostingIterator] Make sure skipTo also works for first element

[Stefan Brüns]

bruns added a dependent revision: D28845: [OrpostingIterator] Allow skipping 
elements, implement skipTo.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28839

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28845: [OrpostingIterator] Allow skipping elements, implement skipTo

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  In case an OrPostingIterator is below and AndPostingIterator, which is
  the common case when using atleast two term, most of the documents will
  be skipped.
  
  Instead of skipping by repeatedly calling OrPostingIterator::next()
  implement the skipTo method. This removes the overhead of looping over
  the subsets for each next call.
  
  When skipTo is implemented in the AndPostingIterator and
  OrPostingIterator, the instruction count is significantly reduced,
  e.g. a query for "the fox" goes down from 20M to 4.5M instructions
  (query time 6ms vs 1.5ms), on a DB with 4.600 documents.
  
  Depends on D28839 

TEST PLAN
  - ctest
  - valgrind baloosearch some words

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28845

AFFECTED FILES
  src/engine/orpostingiterator.cpp
  src/engine/orpostingiterator.h

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28470: [PlasmaCore.IconItem] Refactor source handling for different types

[Konrad Materka]

kmaterka marked an inline comment as done.
kmaterka added a comment.


  In D28470#647757 , @davidedmundson 
wrote:
  
  > Note there's a unit test for IconItem worth running if you haven't already.
  
  
  I've checked that already, these test were really useful!
  
  > The refactor in general makes sense - it's a lot cleaner.
  >  Though I'm not sure what our super long term KF6 plan for IconItem is, 
it'll definitely be changing quite a bit.
  
  If there is no harm now, then it should be easier to change it in the future 
:)

INLINE COMMENTS

> mart wrote in iconitem.cpp:40
> does it have to be a QObject? it doesn't have properties, signals or 
> invokables.. qobject is an expensive class so if you don't have to use oits 
> features is better to avoid

There is one use of `connect` in `SvgSource` but I can change the 
implementation.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28470

To: kmaterka, #plasma, broulik, apol, davidedmundson
Cc: mart, davidre, cblack, kde-frameworks-devel, #plasma, LeGast00n, michaelh, 
ngraham, bruns

D28839: [PostingIterator] Make sure skipTo also works for first element

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28839

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 54 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/54/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Tue, 14 Apr 2020 21:27:01 +
 Build duration:
9 min 9 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 54 test(s), Skipped: 0 test(s), Total: 54 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 46 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/46/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Tue, 14 Apr 2020 21:26:59 +
 Build duration:
16 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.70.0.xmllogs/KF5KIO/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 54 test(s), Skipped: 0 test(s), Total: 55 test(s)Failed: projectroot.autotests.kiocore_ktcpsockettestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(276/412)67%
(276/412)57%
(35513/62795)41%
(17974/44365)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(60/60)100%
(60/60)95%
(10096/10581)46%
(4724/10192)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(105/119)88%
(105/119)60%
(8775/14660)52%
(4561/8849)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4694/8344)43%
(2079/4822)src.gui100%
(5/5)100%
(5/5)81%
(332/412)58%
(163/280)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(711/1286)41%
(423/1036)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(646/1375)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1806/4288)36%
(1312/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(74/270)8%
(14/184)src.ioslaves.remote.kdedmodule0%
  

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 546 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/546/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 14 Apr 2020 21:57:59 +
 Build duration:
7 min 4 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.70.0.xmllogs/KF5KIO/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 55 test(s), Skipped: 0 test(s), Total: 55 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(276/412)67%
(276/412)57%
(35487/62792)40%
(17964/44369)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(60/60)100%
(60/60)96%
(10112/10582)46%
(4738/10192)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(105/119)88%
(105/119)60%
(8750/14660)51%
(4542/8849)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4694/8342)43%
(2081/4826)src.gui100%
(5/5)100%
(5/5)81%
(332/412)58%
(163/280)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(711/1286)41%
(423/1036)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(646/1375)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4287)36%
(1309/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(74/270)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 55 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/55/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Tue, 14 Apr 2020 21:57:59 +
 Build duration:
7 min 23 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 54 test(s), Skipped: 0 test(s), Total: 54 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 47 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/47/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Tue, 14 Apr 2020 21:57:59 +
 Build duration:
7 min 32 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.70.0.xmllogs/KF5KIO/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 55 test(s), Skipped: 0 test(s), Total: 55 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(276/412)67%
(276/412)57%
(35494/62794)41%
(17974/44365)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(60/60)100%
(60/60)96%
(10112/10581)46%
(4736/10192)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(105/119)88%
(105/119)60%
(8750/14660)51%
(4549/8849)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4694/8344)43%
(2079/4822)src.gui100%
(5/5)100%
(5/5)81%
(332/412)58%
(163/280)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(711/1286)41%
(423/1036)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(646/1375)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4287)36%
(1309/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(74/270)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%

D25267: Improve XCF support

[Albert Astals Cid]

aacid added a comment.


  In D25267#647547 , @sandsmark 
wrote:
  
  > In D25267#647148 , @aacid wrote:
  >
  > > Seems like the windows build is broken :/
  > >
  > > 
https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20WindowsMSVCQt5.14/16/console
  >
  >
  > Seems like I forgot to use the custom rand_r (to avoid exactly that + get 
the same noise function as windows) a couple of places.
  >
  > Should just be to replace `rand_r` with `RandomTable::rand_r` where it is 
missing, okay if I just do that in master?
  
  
  Yeah fixing that directly in master makes sense

REPOSITORY
  R287 KImageFormats

REVISION DETAIL
  https://phabricator.kde.org/D25267

To: sandsmark, aacid, cfeck, apol, vkrause
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28819: [KRichTextEdit] Always treat key press as single modification in undo stack

[Igor Poboiko]

This revision was automatically updated to reflect the committed changes.
Closed by commit R310:1d1eb6feb7f8: [KRichTextEdit] Always treat key press as 
single modification in undo stack (authored by poboiko).

REPOSITORY
  R310 KTextWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28819?vs=80084=80164

REVISION DETAIL
  https://phabricator.kde.org/D28819

AFFECTED FILES
  src/widgets/krichtextedit.cpp

To: poboiko, #frameworks, mlaurent, dfaure
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D19913: [plasma-desktop] make it compiles without foreach

[Laurent Montel]

mlaurent updated this revision to Diff 80170.
mlaurent added a comment.


  Fix David comment

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19913?vs=80169=80170

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19913

AFFECTED FILES
  CMakeLists.txt
  autotests/coronatest.cpp
  autotests/utils.h
  src/declarativeimports/calendar/daysmodel.cpp
  src/declarativeimports/calendar/eventpluginsmanager.cpp
  src/declarativeimports/core/datamodel.cpp
  src/declarativeimports/core/datamodel.h
  src/declarativeimports/core/datasource.cpp
  src/declarativeimports/core/iconitem.cpp
  src/declarativeimports/core/tooltipdialog.cpp
  src/declarativeimports/plasmacomponents/qmenu.cpp
  src/declarativeimports/plasmaextracomponents/fallbackcomponent.cpp
  src/plasma/containment.cpp
  src/plasma/corona.cpp
  src/plasma/datacontainer.cpp
  src/plasma/dataengine.cpp
  src/plasma/dataengineconsumer.cpp
  src/plasma/package.cpp
  src/plasma/pluginloader.cpp
  src/plasma/private/applet_p.cpp
  src/plasma/private/containment_p.cpp
  src/plasma/private/dataenginemanager.cpp
  src/plasma/private/theme_p.cpp
  src/plasma/private/timetracker.cpp
  src/plasma/service.cpp
  src/plasma/svg.cpp
  src/plasmaquick/appletquickitem.cpp
  src/plasmaquick/configview.cpp
  src/plasmaquick/dialog.cpp
  src/plasmaquick/dialogshadows.cpp
  src/scriptengines/qml/plasmoid/appletinterface.cpp
  src/scriptengines/qml/plasmoid/containmentinterface.cpp
  src/scriptengines/qml/plasmoid/dropmenu.cpp
  tests/kplugins/plugintest.cpp

To: mlaurent, dfaure
Cc: nicolasfella, broulik, apol, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham, bruns

D19913: [plasma-framework] make it compiles without foreach

[Laurent Montel]

mlaurent retitled this revision from "[plasma-desktop] make it compiles without 
foreach" to "[plasma-framework] make it compiles without foreach".

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19913

To: mlaurent, dfaure
Cc: nicolasfella, broulik, apol, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham, bruns

D19913: [plasma-desktop] make it compiles without foreach

[Laurent Montel]

mlaurent updated this revision to Diff 80169.
mlaurent added a comment.


  Port last element to for(...:...)

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19913?vs=80168=80169

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19913

AFFECTED FILES
  CMakeLists.txt
  autotests/coronatest.cpp
  autotests/utils.h
  src/declarativeimports/calendar/daysmodel.cpp
  src/declarativeimports/calendar/eventpluginsmanager.cpp
  src/declarativeimports/core/datamodel.cpp
  src/declarativeimports/core/datamodel.h
  src/declarativeimports/core/datasource.cpp
  src/declarativeimports/core/iconitem.cpp
  src/declarativeimports/core/tooltipdialog.cpp
  src/declarativeimports/plasmacomponents/qmenu.cpp
  src/declarativeimports/plasmaextracomponents/fallbackcomponent.cpp
  src/plasma/containment.cpp
  src/plasma/corona.cpp
  src/plasma/datacontainer.cpp
  src/plasma/dataengine.cpp
  src/plasma/dataengineconsumer.cpp
  src/plasma/package.cpp
  src/plasma/pluginloader.cpp
  src/plasma/private/applet_p.cpp
  src/plasma/private/containment_p.cpp
  src/plasma/private/dataenginemanager.cpp
  src/plasma/private/theme_p.cpp
  src/plasma/private/timetracker.cpp
  src/plasma/service.cpp
  src/plasma/svg.cpp
  src/plasmaquick/appletquickitem.cpp
  src/plasmaquick/configview.cpp
  src/plasmaquick/dialog.cpp
  src/plasmaquick/dialogshadows.cpp
  src/scriptengines/qml/plasmoid/appletinterface.cpp
  src/scriptengines/qml/plasmoid/containmentinterface.cpp
  src/scriptengines/qml/plasmoid/dropmenu.cpp
  tests/kplugins/plugintest.cpp

To: mlaurent, dfaure
Cc: nicolasfella, broulik, apol, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham, bruns

D19913: [plasma-desktop] make it compiles without foreach

[Laurent Montel]

mlaurent updated this revision to Diff 80168.
mlaurent added a comment.


  Rebase against master

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19913?vs=55796=80168

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19913

AFFECTED FILES
  CMakeLists.txt
  autotests/coronatest.cpp
  src/declarativeimports/calendar/daysmodel.cpp
  src/declarativeimports/calendar/eventpluginsmanager.cpp
  src/declarativeimports/core/datamodel.cpp
  src/declarativeimports/core/datamodel.h
  src/declarativeimports/core/datasource.cpp
  src/declarativeimports/core/iconitem.cpp
  src/declarativeimports/core/tooltipdialog.cpp
  src/declarativeimports/plasmacomponents/qmenu.cpp
  src/declarativeimports/plasmaextracomponents/fallbackcomponent.cpp
  src/plasma/containment.cpp
  src/plasma/corona.cpp
  src/plasma/datacontainer.cpp
  src/plasma/dataengine.cpp
  src/plasma/dataengineconsumer.cpp
  src/plasma/package.cpp
  src/plasma/pluginloader.cpp
  src/plasma/private/applet_p.cpp
  src/plasma/private/containment_p.cpp
  src/plasma/private/dataenginemanager.cpp
  src/plasma/private/theme_p.cpp
  src/plasma/private/timetracker.cpp
  src/plasma/service.cpp
  src/plasma/svg.cpp
  src/plasmaquick/appletquickitem.cpp
  src/plasmaquick/configview.cpp
  src/plasmaquick/dialog.cpp
  src/plasmaquick/dialogshadows.cpp
  src/scriptengines/qml/plasmoid/appletinterface.cpp
  src/scriptengines/qml/plasmoid/containmentinterface.cpp
  tests/kplugins/plugintest.cpp

To: mlaurent, dfaure
Cc: nicolasfella, broulik, apol, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham, bruns

Re: Update on Status of Gitlab Migration

[Ivan Čukić]

Hi all,

While I do like the invent name, I agree there should be a redirect of some 
sort from git.kde.org to it.

The aforementioned Debian salsa server has one as well - https://
git.debian.org/ - a message stating that the new server is 'salsa.debian.org'

Cheers,
Ivan


-- 
dr Ivan Čukić
i...@cukic.co, https://cukic.co/
gpg key fingerprint: 8FE4 D32F 7061 EA9C 8232  07AE 01C6 CE2B FF04 1C12

D28470: [PlasmaCore.IconItem] Refactor source handling for different types

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> iconitem.cpp:40
>  
> +class IconItemSource : public QObject
> +{

does it have to be a QObject? it doesn't have properties, signals or 
invokables.. qobject is an expensive class so if you don't have to use oits 
features is better to avoid

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28470

To: kmaterka, #plasma, broulik, apol, davidedmundson
Cc: mart, davidre, cblack, kde-frameworks-devel, #plasma, LeGast00n, michaelh, 
ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 44 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/44/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Tue, 14 Apr 2020 05:41:33 +
 Build duration:
1 hr 10 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.70.0.xmllogs/KF5KIO/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 55 test(s), Skipped: 0 test(s), Total: 55 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(276/412)67%
(276/412)57%
(35495/62794)40%
(17955/44365)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(60/60)100%
(60/60)96%
(10112/10581)46%
(4723/10192)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(105/119)88%
(105/119)60%
(8751/14660)51%
(4546/8849)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4694/8344)43%
(2079/4822)src.gui100%
(5/5)100%
(5/5)81%
(332/412)58%
(163/280)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(711/1286)41%
(423/1036)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(646/1375)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4287)36%
(1309/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(74/270)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
 

D26650: Use KService to look for Filelight

[Kai Uwe Broulik]

broulik added a comment.


  Superseded by D28266 

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26650

To: shubham, broulik, ngraham
Cc: sitter, meven, anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 52 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/52/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Tue, 14 Apr 2020 05:41:33 +
 Build duration:
41 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 54 test(s), Skipped: 0 test(s), Total: 54 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

Re: Update on Status of Gitlab Migration

[Ben Cooksley]

On Mon, Apr 13, 2020 at 9:29 AM Johan Ouwerkerk  wrote:
>
> On Sun, Apr 12, 2020 at 12:49 AM Johan Ouwerkerk  
> wrote:
> >
> > >
> > > We may need to do on-the-fly conversion of the kde: repo paths if they
> > > won't be expressible as 'kde:foo' in the future, but we should have the
> > > information needed to do this in kdesrc-build to make this happen
> > > on-the-fly.
> > >
> >
> > Yes, this should be fairly straight forward: we could do a `git remote
> > set-url` based on what the repo metadata tells us before updating a
> > local clone. In fact: we could build this right now and sell it as
> > "automagically recover your upstream".  :)
> >
> > I might try to hack something up tomorrow or monday for that.
> >
>
> A basic version of this is now available via:
> https://invent.kde.org/kde/kdesrc-build/-/merge_requests/27
> With this feature sysadmin should now be free to change the repopath
> value in the metadata YAML and kdesrc-build will reconfigure the
> remote URL appropriately automatically. This works as long as the same
> `kde:$path` expression works for both fetch and push, i.e. the layout
> on the anongit.kde.org network must match with the layout of
> git.kde.org/invent.kde.org. If necessary a simple path prefix change
> could still work with a minor update to the pushInsteadOf mapping,
> e.g. when repos on invent are mapped to kde/   instead of
> /.
>
> You can also experiment with setting invent.kde.org as the push URL by
> setting x-invent-kde-push-urls to true in your rc file. The effect
> should be visible through git remote -vv afterwards. (Disable the
> setting and re-run again afterwards because this will obviously break
> your push URLs as long as the Gitlab migration hasn't completed yet).

Many thanks for sending this patch through Johan, it's appreciated.

As one of the options we are looking at involves grouping
repositories, having the ability for kdesrc-build to seamlessly handle
this transition is definitely appreciated.


>
> Regards,
>
> - Johan

Cheers,
Ben

Re: Update on Status of Gitlab Migration

[Ben Cooksley]

On Tue, Apr 14, 2020 at 2:37 PM Nate Graham  wrote:
>
> On 4/13/20 6:59 PM, Ben Cooksley wrote:
> > Why do we need to mimic them?
> >
> > If you Google "KDE Gitlab" then the first hit is invent.kde.org
> > .
>
> To flip it around: why do we need to do something different? I don't
> think it's about mimicking anyone else, but rather using the most
> intuitively obvious domain name rather than some arbitrarily different one.
>
> No matter what, we're all going to be talking about "KDE GitLab" or
> "KDE's GitLab instance". The title of the relevant documentation page is
> "GitLab" (much as the Phabricator documentation page was named
> "Phabricator"). And when the migration is complete, we're all going to
> announce that "KDE is now using GitLab!" So the cat's out of the bag on
> using the word "GitLab" and avoiding some number of people looking for
> our stuff at gitlab.com and not finding it there. invent.kde.org doesn't
> avoid that at all.
>
> Given that, which is more confusing: explaining to people that we have a
> GitLab instance at invent.kde.org, or explaining to people that we have
> a GitLab instance at gitlab.kde.org?

There is no difference to be honest, the amount of explaining is
exactly the same.

We're also not alone in giving ours a different name - Debian did as
well (theirs is at salsa.debian.org). They didn't see fit to setup a
compatibility "gitlab.debian.org" hostname either.

>
> I know that over the next few years I'm going to be directing hundreds
> of people towards our infrastructure, and I would rather be able to say
> "please submit a pull request at gitlab.kde.org" rather than "please
> submit a pull request at KDE's GitLab instance at invent.kde.org."

Sorry, but the "KDE's Gitlab instance" in your second sentence is superfluous.
You could just as easily say "please submit a pull request on
invent.kde.org", not sure why you need to explicitly mention it is
Gitlab.

If people have already found the source code, chances are they will
have already found invent.kde.org anyway - as they will have probably
found it via a web browser, and Gitlab will be the only web interface
to our repositories (CGit is being discontinued)

>
> I know this probably feels like annoyingly extreme bikeshedding, but, I
> dunno, names are important.
>
> Nate

Cheers,
Ben

D28701: [WIP] Add KPackage support to KNewStuffCore

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In D28701#644973 , @ngraham wrote:
  
  > Okay thanks, can you update the test plan then? Also I think the diff 
currently does not actually fix 418466.
  
  
  Your comments (and adding on reviewers) seems to suggest to me that you 
either haven't noticed the [WIP] at the start of the diff's title... or that 
i'm marking work in progress patches incorrectly? (and to answer the question, 
i will of course be adding testing instructions)

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D28701

To: leinir, #plasma, #knewstuff, #frameworks
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28814: TypeScript: add the "awaited" type operator

[Nibaldo González]

nibags created this revision.
nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REVISION SUMMARY
  Add the new keyword "awaited": 
https://github.com/microsoft/TypeScript/pull/35998

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  add-awaited-typescript

REVISION DETAIL
  https://phabricator.kde.org/D28814

AFFECTED FILES
  autotests/folding/test.ts.fold
  autotests/html/test.ts.html
  autotests/input/test.ts
  autotests/reference/test.ts.ref
  data/syntax/typescript.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D20655: Use generated DBus interface

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  We copy udisks xml already. I don't think it ends up any better. Otherwise we 
have a compile time dep on a runtime plugin, which inevitably means we need to 
make it optional which only introduces more real-world bugs. It also means 
future devs know what we were compiled against.
  
  Marking as requesting changes for the extra include, but personally I think 
it's generally good to go.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D20655

To: broulik, #frameworks, davidedmundson, bruns
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28819: [KRichTextEdit] Always treat key press as single modification in undo stack

[Igor Poboiko]

poboiko edited the summary of this revision.

REPOSITORY
  R310 KTextWidgets

REVISION DETAIL
  https://phabricator.kde.org/D28819

To: poboiko, #frameworks, mlaurent
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28819: [KRichTextEdit] Always treat key press as single modification in undo stack

[Igor Poboiko]

poboiko created this revision.
poboiko added reviewers: Frameworks, mlaurent.
Herald added a project: Frameworks.
poboiko requested review of this revision.

REVISION SUMMARY
  If my cursor is on a bullet list, and I press Enter to create a new element,
  it registers as 5-7 actions in an undo stack, mostly margins adjustments. So 
to
  rewind it, user has to press `Ctrl+Z` 5+ times, which is quite frustrating.
  
  Instead this patch suggests to treat _any_ change that is a result of a single
  key press as a single event, so user has to press `Ctrl+Z` just once to undo 
it

TEST PLAN
  1. Open KMail -> New Mail, enable Rich Text mode (or, say, open KJots)
  2. Create a bullet list with couple of elements
  3. Put cursor on the last element, press Enter to create a new element
  4. Try to undo this action with Ctrl+Z
  5. (without patch) One has to press Ctrl+Z 5-7 times to undo it.
  6. (with patch) A single Ctrl+Z is enough

REPOSITORY
  R310 KTextWidgets

BRANCH
  single-undo (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28819

AFFECTED FILES
  src/widgets/krichtextedit.cpp

To: poboiko, #frameworks, mlaurent
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28470: [PlasmaCore.IconItem] Refactor source handling for different types

[David Edmundson]

davidedmundson added a comment.


  Note there's a unit test for IconItem worth running if you haven't already. 
  The refactor in general makes sense - it's a lot cleaner.
  
  Though I'm not sure what our super long term KF6 plan for IconItem is, it'll 
definitely be changing quite a bit.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28470

To: kmaterka, #plasma, broulik, apol, davidedmundson
Cc: mart, davidre, cblack, kde-frameworks-devel, #plasma, LeGast00n, michaelh, 
ngraham, bruns

Re: Update on Status of Gitlab Migration

[Nate Graham]

On 4/13/20 6:59 PM, Ben Cooksley wrote:

Why do we need to mimic them?

If you Google "KDE Gitlab" then the first hit is invent.kde.org 
.


To flip it around: why do we need to do something different? I don't 
think it's about mimicking anyone else, but rather using the most 
intuitively obvious domain name rather than some arbitrarily different one.


No matter what, we're all going to be talking about "KDE GitLab" or 
"KDE's GitLab instance". The title of the relevant documentation page is 
"GitLab" (much as the Phabricator documentation page was named 
"Phabricator"). And when the migration is complete, we're all going to 
announce that "KDE is now using GitLab!" So the cat's out of the bag on 
using the word "GitLab" and avoiding some number of people looking for 
our stuff at gitlab.com and not finding it there. invent.kde.org doesn't 
avoid that at all.


Given that, which is more confusing: explaining to people that we have a 
GitLab instance at invent.kde.org, or explaining to people that we have 
a GitLab instance at gitlab.kde.org?


I know that over the next few years I'm going to be directing hundreds 
of people towards our infrastructure, and I would rather be able to say 
"please submit a pull request at gitlab.kde.org" rather than "please 
submit a pull request at KDE's GitLab instance at invent.kde.org."


I know this probably feels like annoyingly extreme bikeshedding, but, I 
dunno, names are important.


Nate

D28701: [WIP] Add KPackage support to KNewStuffCore

[Dan Leinir Turthra Jensen]

leinir edited the test plan for this revision.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D28701

To: leinir, #plasma, #knewstuff, #frameworks
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28701: [WIP] Add KPackage support to KNewStuffCore

[Dan Leinir Turthra Jensen]

leinir edited the test plan for this revision.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D28701

To: leinir, #plasma, #knewstuff, #frameworks
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D20655: Use generated DBus interface

[Stefan Brüns]

bruns added a comment.


  In D20655#647806 , @davidedmundson 
wrote:
  
  > We copy udisks xml already. I don't think it ends up any better. Otherwise 
we have a compile time dep on a runtime plugin, which inevitably means we need 
to make it optional which only introduces more real-world bugs. It also means 
future devs know what we were compiled against.
  >
  > Marking as requesting changes for the extra include, but personally I think 
it's generally good to go.
  
  
  We are also already copying part of the interface specification. After all, 
`indexOfSignal("DeviceAdded(QDBusObjectPath)")` is the same as the 
corresponding code generated by dbusxml2cpp.
  
  Two more change requests:
  
  - Please mention support for the deprecated `DeviceAdded(string)` (upower < 
0.99) is removed
  - Please wrap long lines in the summary etc.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D20655

To: broulik, #frameworks, davidedmundson, bruns
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28701: [WIP] Add KPackage support to KNewStuffCore

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 80098.
leinir added a comment.


  Bunch of new functionality, with a fallback which ought to allow it to work
  without requiring any kind of changes to the existing knsrc files based on
  kpackage, as long as they follow the pattern they seem to mostly follow.
  
  - Introduce a getter (and enum) for the uncompress Installation setting
  - Add a redirection to the knsrc documentation location
  - Add a function to clean the cache of functionally stale entries
  - Clean the cache when the uncompression method is set to kpackage
  - Add a fallback for uncinverted kpackage based knsrc files

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28701?vs=79704=80098

BRANCH
  add-kpackage-support (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28701

AFFECTED FILES
  CMakeLists.txt
  src/core/CMakeLists.txt
  src/core/cache.cpp
  src/core/cache.h
  src/core/engine.cpp
  src/core/engine.h
  src/core/installation.cpp
  src/core/installation.h

To: leinir, #plasma, #knewstuff, #frameworks
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28701: [WIP] Add KPackage support to KNewStuffCore

[Dan Leinir Turthra Jensen]

leinir edited the summary of this revision.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D28701

To: leinir, #plasma, #knewstuff, #frameworks
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28701: [WIP] Add KPackage support to KNewStuffCore

[Dan Leinir Turthra Jensen]

leinir edited the summary of this revision.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D28701

To: leinir, #plasma, #knewstuff, #frameworks
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28701: [WIP] Add KPackage support to KNewStuffCore

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 80099.
leinir added a comment.


  - Make a touch of noise when encountering the fallback

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28701?vs=80098=80099

BRANCH
  add-kpackage-support (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28701

AFFECTED FILES
  CMakeLists.txt
  src/core/CMakeLists.txt
  src/core/cache.cpp
  src/core/cache.h
  src/core/engine.cpp
  src/core/engine.h
  src/core/installation.cpp
  src/core/installation.h

To: leinir, #plasma, #knewstuff, #frameworks
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28745: Skip caching thumbnails on encrypted filesystems

[Méven Car]

meven added a comment.


  This is gonna have an hefty toll on perf as it will add a `getmntent` syscall 
to every thumbnail generation.
  Using `Solid::Device::listFromType` would leverage Solid always up-to-date 
(using events rather thane sysalls) device cache.
  I am not sure in the end this is preferable though.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28745

To: marcingu, ivan, broulik, #dolphin, ngraham
Cc: meven, ngraham, kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, 
iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, feverfew, 
michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, 
rdieter, mikesomov

D27816: KI18N_WRAP_UI macro: set SKIP_AUTOUIC property on ui file and gen. header

[Friedrich W. H. Kossebau]

kossebau added a comment.


  If no-one objects, going to push upcoming WE then, April 18/19

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D27816

To: kossebau, #frameworks, ilic
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D25707: [renamedialog] Replace KIconLoader usage with QIcon::fromTheme

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:ee08d0b4e56e: [renamedialog] Replace KIconLoader usage 
with QIcon::fromTheme (authored by nicolasfella).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25707?vs=70853=80131

REVISION DETAIL
  https://phabricator.kde.org/D25707

AFFECTED FILES
  src/widgets/renamedialog.cpp

To: nicolasfella, #frameworks, dfaure
Cc: ahmadsamir, broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

D27704: Drop FindAccountsFileDir.cmake

[Nicolas Fella]

nicolasfella abandoned this revision.

REPOSITORY
  R155 KAccounts Integration

REVISION DETAIL
  https://phabricator.kde.org/D27704

To: nicolasfella, #frameworks, bshah, leinir, lbeltrame
Cc: lbeltrame

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 544 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/544/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 14 Apr 2020 15:15:28 +
 Build duration:
7 min 56 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.70.0.xmllogs/KF5KIO/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 55 test(s), Skipped: 0 test(s), Total: 55 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(276/412)67%
(276/412)57%
(35487/62792)41%
(17973/44369)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(60/60)100%
(60/60)96%
(10112/10582)47%
(4740/10192)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(105/119)88%
(105/119)60%
(8750/14660)51%
(4549/8849)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4694/8342)43%
(2081/4826)src.gui100%
(5/5)100%
(5/5)81%
(332/412)58%
(163/280)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(711/1286)41%
(423/1036)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(646/1375)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4287)36%
(1309/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(74/270)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
   

D28498: [xdgoutput] Explicitly set version of server interface

[Vlad Zahorodnii]

zzag added inline comments.

INLINE COMMENTS

> display.h:281-288
>  /**
>   * Creates the XdgOutputManagerInterface
>   *
>   * @return the created manager
>   * @since 5.47
> + * @deprecated use the version that takes a version
>   */

Please use KWAYLAND_ENABLE_DEPRECATED_SINCE to make the compiler bark whenever 
someone uses the deprecated version of createXdgOutputManager.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D28498

To: davidedmundson, #kwin
Cc: zzag, anthonyfieroni, apol, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham, bruns

D25707: [renamedialog] Replace KIconLoader usage with QIcon::fromTheme

[Nicolas Fella]

nicolasfella added a comment.


  In D25707#645694 , @dfaure wrote:
  
  > OK. Then let me change my comment to: please document in kiconloader.h how 
to port away from loadMimeTypeIcon, even if it's not actually deprecated.
  >
  > I remember wondering the same thing at one point.
  
  
  Done in D28831 

REPOSITORY
  R241 KIO

BRANCH
  rena

REVISION DETAIL
  https://phabricator.kde.org/D25707

To: nicolasfella, #frameworks, dfaure
Cc: ahmadsamir, broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

D24773: kio_trash: Add size, modification, access and create date for trash:/

[Ahmad Samir]

ahmadsamir added a comment.


  Hello. This broke the testtrash unit test 
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/45/execution/node/36/log/

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24773

To: meven, #frameworks, ngraham, elvisangelaccio, dfaure
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D28831: Add note about porting loadMimeTypeIcon

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added reviewers: Frameworks, dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  We're phasing out loadMimeTypeIcon in favor of QIcon::fromTheme(). We can't 
oficially deprecate it yet since there are still unported users, but add a 
comment recommending alternative API.

REPOSITORY
  R302 KIconThemes

BRANCH
  mime

REVISION DETAIL
  https://phabricator.kde.org/D28831

AFFECTED FILES
  src/kiconloader.h

To: nicolasfella, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28831: Add note about porting loadMimeTypeIcon

[Nathaniel Graham]

ngraham added a comment.


  +1

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D28831

To: nicolasfella, #frameworks, dfaure
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 53 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/53/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Tue, 14 Apr 2020 15:15:28 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 54 test(s), Skipped: 0 test(s), Total: 54 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D22554: Finer No-Dbus on Windows

[Nicolas Fella]

nicolasfella added a comment.


  @brute4s99 Is this still relevant?

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D22554

To: brute4s99, nicolasfella, broulik
Cc: andriusr, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 45 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/45/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Tue, 14 Apr 2020 15:15:28 +
 Build duration:
14 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.70.0.xmllogs/KF5KIO/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 55 test(s), Skipped: 0 test(s), Total: 55 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(276/412)67%
(276/412)57%
(35495/62794)41%
(17979/44365)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(60/60)100%
(60/60)96%
(10114/10581)47%
(4740/10192)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(105/119)88%
(105/119)60%
(8749/14660)51%
(4552/8849)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4694/8344)43%
(2079/4822)src.gui100%
(5/5)100%
(5/5)81%
(332/412)58%
(163/280)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(711/1286)41%
(423/1036)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(646/1375)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4287)36%
(1309/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(74/270)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
  

D25443: [chmodjob] Port away from QLinkedList

[Nicolas Fella]

nicolasfella updated this revision to Diff 80139.
nicolasfella added a comment.


  - Update comment

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25443?vs=70143=80139

BRANCH
  ll

REVISION DETAIL
  https://phabricator.kde.org/D25443

AFFECTED FILES
  src/core/chmodjob.cpp

To: nicolasfella, #frameworks, dfaure
Cc: dfaure, bruns, fabiank, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham

D25443: [chmodjob] Port away from QLinkedList

[Nicolas Fella]

nicolasfella marked an inline comment as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25443

To: nicolasfella, #frameworks, dfaure
Cc: dfaure, bruns, fabiank, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham

D28834: Add metadata properties to calendar

[Nicolas Fella]

nicolasfella added reviewers: Frameworks, KDE PIM, vkrause.

REPOSITORY
  R172 KCalendar Core

REVISION DETAIL
  https://phabricator.kde.org/D28834

To: nicolasfella, #frameworks, #kde_pim, vkrause
Cc: kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, 
mlaurent, knauss, dvratil

D28834: Add metadata properties to calendar

[Nicolas Fella]

nicolasfella added a dependent revision: D24443: Add a plugin system.

REPOSITORY
  R172 KCalendar Core

REVISION DETAIL
  https://phabricator.kde.org/D28834

To: nicolasfella, #frameworks, #kde_pim, vkrause
Cc: kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, 
mlaurent, knauss, dvratil

D24443: Add a plugin system

[Nicolas Fella]

nicolasfella updated this revision to Diff 80141.
nicolasfella added a comment.


  - Remove calendarentry

REPOSITORY
  R172 KCalendar Core

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24443?vs=71067=80141

BRANCH
  arcpatch-D24443_2

REVISION DETAIL
  https://phabricator.kde.org/D24443

AFFECTED FILES
  src/CMakeLists.txt
  src/calendarplugin.cpp
  src/calendarplugin.h

To: nicolasfella, #frameworks, #plasma, #kde_pim
Cc: z3ntu, ognarb, kde-pim, dkardarakos, vkrause, dvratil, davidedmundson, 
dhaumann, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, mlaurent, knauss

D24443: Add a plugin system

[Nicolas Fella]

nicolasfella edited the summary of this revision.
nicolasfella added a dependency: D28834: Add metadata properties to calendar.

REPOSITORY
  R172 KCalendar Core

REVISION DETAIL
  https://phabricator.kde.org/D24443

To: nicolasfella, #frameworks, #plasma, #kde_pim
Cc: z3ntu, ognarb, kde-pim, dkardarakos, vkrause, dvratil, davidedmundson, 
dhaumann, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, mlaurent, knauss

D24443: Add a plugin system

[Nicolas Fella]

nicolasfella updated this revision to Diff 80142.
nicolasfella added a comment.


  - Convert license headers to SPDX

REPOSITORY
  R172 KCalendar Core

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24443?vs=80141=80142

BRANCH
  arcpatch-D24443_2

REVISION DETAIL
  https://phabricator.kde.org/D24443

AFFECTED FILES
  src/CMakeLists.txt
  src/calendarplugin.cpp
  src/calendarplugin.h

To: nicolasfella, #frameworks, #plasma, #kde_pim
Cc: z3ntu, ognarb, kde-pim, dkardarakos, vkrause, dvratil, davidedmundson, 
dhaumann, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, mlaurent, knauss

D24443: Add a plugin system

[Nicolas Fella]

nicolasfella planned changes to this revision.

REPOSITORY
  R172 KCalendar Core

REVISION DETAIL
  https://phabricator.kde.org/D24443

To: nicolasfella, #frameworks, #plasma, #kde_pim
Cc: z3ntu, ognarb, kde-pim, dkardarakos, vkrause, dvratil, davidedmundson, 
dhaumann, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, mlaurent, knauss

D26650: Use KService to look for Filelight

[Nathaniel Graham]

ngraham commandeered this revision.
ngraham edited reviewers, added: shubham; removed: ngraham.
ngraham added a comment.


  Aha!

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26650

To: ngraham, broulik, shubham
Cc: sitter, meven, anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham, bruns

D28819: [KRichTextEdit] Always treat key press as single modification in undo stack

[Ahmad Samir]

ahmadsamir added a reviewer: dfaure.
ahmadsamir added a comment.


  I tested this with the krichtexteditor test app from kxmlgui, and it works. 
(It's never too late to fix a bug, even if it's from 2010 :)).

REPOSITORY
  R310 KTextWidgets

REVISION DETAIL
  https://phabricator.kde.org/D28819

To: poboiko, #frameworks, mlaurent, dfaure
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D28774: [KFontRequester] Port from QFontDialog to KFontChooserDialog

[Ahmad Samir]

ahmadsamir added a comment.


  In D28774#647157 , @dfaure wrote:
  
  > I mean, the user can press cancel, that's when QColorDialog returns an 
invalid color.
  >  If there was a concept like an invalid font we could do the same here, but 
there's no such concept in QFont.
  >  So yep, no better way.
  
  
  Looking at the code, if the user presses cancel, "theFont" is returned 
unchanged; seems pretty good to me:
  
int KFontChooserDialog::getFont(QFont , const 
KFontChooser::DisplayFlags , QWidget *parent)
{
KFontChooserDialog dlg(flags, parent);
dlg.setObjectName(QStringLiteral("Font Selector"));
dlg.setFont(theFont, flags & KFontChooser::FixedFontsOnly);

const int result = dlg.exec();
if (result == Accepted) {
theFont = dlg.d->chooser->font();
stripRegularStyleName(theFont);
}
return result;
}
  
  QFontDialog::getFont() returns a QFont, and one may pass a bool * to check 
the dialog result code:
  QFont QFontDialog::getFont(bool *ok, const QFont , QWidget *parent, 
const QString , FontDialogOptions options)
  
  which is standard Qt behaviour from other dialogs/widgets that handle user 
yes/no use cases, IIRC.
  
  The KFontChooer* approach is more "economical", the "initial" font and the 
font you get from the dialog if you press OK, are the same object, and the 
function returns the dialog result code. As some wise old builder once said 
"there's no right or wrong way to lay bricks, as long as it works".

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D28774

To: ahmadsamir, #frameworks, dfaure, cfeck
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D26650: Use KService to look for Filelight

[Nathaniel Graham]

ngraham abandoned this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26650

To: ngraham, broulik, shubham
Cc: sitter, meven, anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham, bruns