D29577: Stop using deprecated methods

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL https://phabricator.kde.org/D29577 To: aacid, dfaure Cc: kossebau, kde-frameworks-devel, kfm-devel, dfaure, waitquietly, azyx, nikolaik, pberestov,

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.14 - Build # 18 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.14/18/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 09 May 2020 22:45:49 + Build duration: 11 min and counting JUnit Tests Name:

D28745: Skip caching thumbnails on encrypted filesystems

thiago added a comment. Use Solid and ask it if the device is on an encrypted device. If Solid does not have such an API, add it. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D28745 To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns Cc: thiago,

D29574: Use KSERVICE_DEPRECATED_VERSION_BELATED

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R309 KService BRANCH usebelated REVISION DETAIL https://phabricator.kde.org/D29574 To: kossebau, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29575: holidayregion.cpp - provide translatable strings for the German regions.

ltoscano added a comment. In D29575#667175 , @winterz wrote: > I'm guessing it's ok to depend on K5I18N ? KHolidays is a Tier 1 framework, so it can't depend on KI18n. Just use QCoreApplication::translate as used already in

D29577: Stop using deprecated methods

aacid added a subscriber: kossebau. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29577 To: aacid Cc: kossebau, kde-frameworks-devel, kfm-devel, dfaure, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde,

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.14 - Build # 7 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.14/7/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 09 May 2020 22:38:36 + Build duration: 5 min 50 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.14 - Build # 14 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.14/14/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 09 May 2020 22:38:23 + Build duration: 5 min 0 sec and counting JUnit Tests Name:

D29575: holidayregion.cpp - provide translatable strings for the German regions.

winterz updated this revision to Diff 82398. winterz added a comment. don't try to provide translatable string for unknown subdivisions REPOSITORY R175 KHolidays CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29575?vs=82396=82398 BRANCH master REVISION DETAIL

D29577: Stop using deprecated methods

aacid created this revision. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY They are no-ops REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL

KDE CI: Frameworks » frameworkintegration » kf5-qt5 WindowsMSVCQt5.14 - Build # 19 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/frameworkintegration/job/kf5-qt5%20WindowsMSVCQt5.14/19/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sat, 09 May 2020 22:37:57 + Build duration: 3 min 51 sec and counting JUnit

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 591 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/591/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 09 May 2020 23:56:13 + Build duration: 5 min 49 sec and counting BUILD ARTIFACTS

D28745: Skip caching thumbnails on encrypted filesystems

bruns added a comment. In D28745#667225 , @thiago wrote: > Use Solid and ask it if the device is on an encrypted device. If Solid does not have such an API, add it. I fully second that. REPOSITORY R320 KIO Extras REVISION DETAIL

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 94 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/94/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 09 May 2020 23:56:13 + Build duration: 8 min 1 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 102 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/102/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 09 May 2020 23:56:13 + Build duration: 7 min 44 sec and counting JUnit Tests Name:

D29575: holidayregion.cpp - provide translatable strings for the German regions.

winterz created this revision. winterz added a reviewer: vkrause. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. winterz requested review of this revision. REVISION SUMMARY The German holiday files now all have a proper country and name since commits

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.14 - Build # 10 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.14/10/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 09 May 2020 22:39:39 + Build duration: 10 min and counting JUnit Tests Name:

D29577: Stop using deprecated methods

aacid closed this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29577 To: aacid, dfaure Cc: kossebau, kde-frameworks-devel, kfm-devel, dfaure, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde,

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 592 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/592/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 10 May 2020 00:03:50 + Build duration: 5 min 38 sec and counting BUILD ARTIFACTS

D29575: holidayregion.cpp - provide translatable strings for the German regions.

winterz added a comment. I'm guessing it's ok to depend on K5I18N ? REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D29575 To: winterz, vkrause Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29361: KCrash: remove debug output which breaks unittests from using ~/.qttest/config for categorized logging

This revision was automatically updated to reflect the committed changes. Closed by commit R285:58afbdf29a83: KCrash: remove debug output which breaks unittests from using ~/.qttest/config… (authored by dfaure). REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.14 - Build # 10 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.14/10/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 09 May 2020 22:39:50 + Build duration: 10 min and counting JUnit Tests Name: projectroot

D29572: Build with EXCLUDE_DEPRECATED_BEFORE_AND_AT=CURRENT

This revision was automatically updated to reflect the committed changes. Closed by commit R309:c8c10b76931a: Build with EXCLUDE_DEPRECATED_BEFORE_AND_AT=CURRENT (authored by kossebau). REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29572?vs=82392=82403

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 191 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/191/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 09 May 2020 22:45:49 + Build duration: 9 min 48 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.14 - Build # 20 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.14/20/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 09 May 2020 22:45:49 + Build duration: 23 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.14 - Build # 188 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.14/188/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sat, 09 May 2020 23:56:13 + Build duration: 2 min 37 sec and counting CONSOLE OUTPUT

D25339: update lineHeight if boundingRect indicates a larger value.

rjvbb added a comment. > Looking at the code, might it make more sense to just move away from the fixed height we have? > It isn't used that often and in most cases one could just query the height of the current line. I'd be all for that, provided it doesn't introduce any

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.14 - Build # 17 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.14/17/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 09 May 2020 11:32:52 + Build duration: 53 min and counting JUnit Tests Name:

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.14 - Build # 11 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.14/11/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 09 May 2020 11:32:14 + Build duration: 1 hr 2 min and counting BUILD ARTIFACTS

D28745: Skip caching thumbnails on encrypted filesystems

bruns added a comment. I think the patch as is has some structural problems. I think it would be significantly cleaner when: - the "cacheAllowed" checking code is moved into a separate function - the global `allowCache` variable is removed, and the value is passed into

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 92 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/92/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 09 May 2020 13:53:13 + Build duration: 16 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 589 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/589/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 09 May 2020 13:53:13 + Build duration: 16 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.14 - Build # 9 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.14/9/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 09 May 2020 11:31:31 + Build duration: 38 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.14 - Build # 185 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.14/185/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sat, 09 May 2020 11:29:35 + Build duration: 1 hr 2 min and counting CONSOLE OUTPUT

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.14 - Build # 17 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.14/17/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 09 May 2020 11:34:41 + Build duration: 1 hr 3 min and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 93 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/93/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 09 May 2020 14:13:24 + Build duration: 6 min 7 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 101 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/101/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 09 May 2020 14:13:25 + Build duration: 4 min 33 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 99 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/99/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 09 May 2020 11:29:35 + Build duration: 28 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.14 - Build # 9 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.14/9/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 09 May 2020 11:30:56 + Build duration: 36 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kcalendarcore » kf5-qt5 WindowsMSVCQt5.14 - Build # 24 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20WindowsMSVCQt5.14/24/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sat, 09 May 2020 11:25:45 + Build duration: 43 min and counting JUnit Tests

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.14 - Build # 12 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.14/12/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 09 May 2020 11:32:14 + Build duration: 44 min and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 91 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/91/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 09 May 2020 11:29:35 + Build duration: 55 min and counting BUILD ARTIFACTS

D29561: Add missing compiler deprecation tag for 5-args KServiceAction constructor

kossebau created this revision. kossebau added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REPOSITORY R309 KService BRANCH addmissingdeprecationtag REVISION DETAIL

D29561: Add missing compiler deprecation tag for 5-args KServiceAction constructor

This revision was automatically updated to reflect the committed changes. Closed by commit R309:429c80c96142: Add missing compiler deprecation tag for 5-args KServiceAction constructor (authored by kossebau). REPOSITORY R309 KService CHANGES SINCE LAST UPDATE

D25339: update lineHeight if boundingRect indicates a larger value.

cullmann added a comment. F8304597: lineheight.patch see e.g. here for a start of using the right heights inside the renderer. for a dynamically wrapped line, the lines before the last one get now the right height for me. But there are a

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 590 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/590/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 09 May 2020 14:13:25 + Build duration: 17 min and counting BUILD ARTIFACTS

D29573: ECMGenerateExportHeader: add generation of *_DEPRECATED_VERSION_BELATED()

kossebau created this revision. kossebau added reviewers: Frameworks, Build System, dfaure. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Now and then tagging some

D29572: Build with EXCLUDE_DEPRECATED_BEFORE_AND_AT=CURRENT

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R309 KService BRANCH buildwithoutdeprecated REVISION DETAIL https://phabricator.kde.org/D29572 To: kossebau, #frameworks, dfaure Cc: kde-frameworks-devel,

D29573: ECMGenerateExportHeader: add generation of *_DEPRECATED_VERSION_BELATED()

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. So many things to take care of :-) REPOSITORY R240 Extra CMake Modules BRANCH addbelated REVISION DETAIL https://phabricator.kde.org/D29573 To: kossebau, #frameworks,

D29574: Use KSERVICE_DEPRECATED_VERSION_BELATED

kossebau created this revision. kossebau added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REPOSITORY R309 KService BRANCH usebelated REVISION DETAIL

D29574: Use KSERVICE_DEPRECATED_VERSION_BELATED

kossebau added a dependency: D29573: ECMGenerateExportHeader: add generation of *_DEPRECATED_VERSION_BELATED(). REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D29574 To: kossebau, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham,

D29573: ECMGenerateExportHeader: add generation of *_DEPRECATED_VERSION_BELATED()

kossebau added a dependent revision: D29574: Use KSERVICE_DEPRECATED_VERSION_BELATED. REPOSITORY R240 Extra CMake Modules BRANCH addbelated REVISION DETAIL https://phabricator.kde.org/D29573 To: kossebau, #frameworks, #build_system, dfaure Cc: kde-frameworks-devel, kde-buildsystem,

D25339: update lineHeight if boundingRect indicates a larger value.

dhaumann added a comment. In D25339#666832 , @cullmann wrote: > Looking at the code, might it make more sense to just move away from the fixed height we have? Yes please. Instead of hacks and options, which will make the code and the UI

D29569: Fix computing display geometry on multi-monitor HiDPI setups on X11

printesoi added reviewers: davidedmundson, KWin. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D29569 To: printesoi, davidedmundson, #kwin Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29569: Fix computing display geometry on multi-monitor HiDPI setups on X11

anthonyfieroni added a reviewer: zzag. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D29569 To: printesoi, davidedmundson, #kwin, zzag Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.14 - Build # 13 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.14/13/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 09 May 2020 18:52:50 + Build duration: 8 min 17 sec and counting JUnit Tests Name:

D29572: Build with EXCLUDE_DEPRECATED_BEFORE_AND_AT=CURRENT

kossebau created this revision. kossebau added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY To also support EXCLUDE_DEPRECATED_BEFORE_AND_AT=5.69.0 properly some

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.14 - Build # 12 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.14/12/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 09 May 2020 18:52:50 + Build duration: 6 min 41 sec and counting BUILD ARTIFACTS

D29569: Fix computing display geometry on multi-monitor HiDPI setups on X11

printesoi created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. printesoi requested review of this revision. REVISION SUMMARY KWindowSystem::workArea() and KWindowSystem::workArea(QList()) should return the same value, but the second call

D29569: Fix computing display geometry on multi-monitor HiDPI setups on X11

printesoi added a comment. I would like to add some more details about my setup: I have a laptop with a 4K display and I use a second 4K external monitor. I have enabled the 200% scalling and `xrandr -q | grep -E '\bconnected' `gives DP-0 connected 3840x2160+0+0 (normal left inverted

D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts

meven marked 2 inline comments as done. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D28590 To: meven, #frameworks, bruns, sitter Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.14 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.14/6/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 09 May 2020 11:25:44 + Build duration: 38 min and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 588 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/588/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 09 May 2020 11:29:35 + Build duration: 43 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.14 - Build # 19 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.14/19/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 09 May 2020 11:26:40 + Build duration: 46 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.14 - Build # 186 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.14/186/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sat, 09 May 2020 13:53:13 + Build duration: 5 min 0 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 100 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/100/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 09 May 2020 13:53:13 + Build duration: 5 min 20 sec and counting JUnit Tests Name:

D25339: update lineHeight if boundingRect indicates a larger value.

cullmann added a comment. In D25339#666877 , @rjvbb wrote: > > Looking at the code, might it make more sense to just move away from the fixed height we have? > > It isn't used that often and in most cases one could just query the height

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.14 - Build # 187 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.14/187/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sat, 09 May 2020 14:13:24 + Build duration: 1 min 40 sec and counting CONSOLE OUTPUT

D29561: Add missing compiler deprecation tag for 5-args KServiceAction constructor

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R309 KService BRANCH addmissingdeprecationtag REVISION DETAIL https://phabricator.kde.org/D29561 To: kossebau, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham,

D25339: update lineHeight if boundingRect indicates a larger value.

rjvbb added a comment. > I assume the lineHeight usages in the renderer are easy to replace with the proper "height()" of the individual lines of the layout. This is what I think could be tricky. One wouldn't want fluctuating line heights when only a single font is used (at least not

D29526: Thumbnails: make thumbnail generation dpr-aware

meven updated this revision to Diff 82332. meven added a comment. Store thumbnails with dpr 2 in @2x folders REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29526?vs=82254=82332 BRANCH thumbnail-dpr REVISION DETAIL

D29397: KPreviewJob : Support for DeviceRatioPixel

meven updated this revision to Diff 82331. meven added a comment. Store thumbnails with dpr 2 in @2x folders REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29397?vs=82292=82331 BRANCH preview-dpr REVISION DETAIL https://phabricator.kde.org/D29397

D29485: [CopyJob] Check free space for remote urls before copying and other improvements

dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > ahmadsamir wrote in copyjob.cpp:477 > I meant connection to the remote ulr/host; however e.g Dolphin already > reports those connection errors in the status bar when

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 89 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/89/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 09 May 2020 10:05:04 + Build duration: 30 min and counting BUILD ARTIFACTS

D29485: [CopyJob] Check free space for remote urls before copying and other improvements

dfaure added inline comments. INLINE COMMENTS > ahmadsamir wrote in copyjob.cpp:444 > Excellent points; I was scratching my head trying to figure out what use > UDS_LOCAL_PATH is when, while testing with qDebug(), it was _always_ empty, > the only time it wasn't empty was in testtrash unit

D29558: Add KIO::OpenUrlJob::setShowOpenWithDialog as replacement for KRun::displayOpenWithDialog

dfaure created this revision. dfaure added reviewers: ahmadsamir, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY This will not look up the preferred app or run scripts/executables, it

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 98 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/98/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 09 May 2020 10:55:21 + Build duration: 8 min 31 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.14 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.14/6/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 09 May 2020 11:27:29 + Build duration: 16 min and counting JUnit Tests Name: projectroot

D29485: [CopyJob] Check free space for remote urls before copying and other improvements

ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in copyjob.cpp:477 > This comment is now completely out of context. It used to be about NFS/SMB, > now this information has gone and one is left wondering why kind of > connections we're talking about (connection to the

D29485: [CopyJob] Check free space for remote urls before copying and other improvements

ahmadsamir updated this revision to Diff 82334. ahmadsamir added a comment. Remove comment REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29485?vs=82305=82334 BRANCH l-freespace-remote-2 (branched from master) REVISION DETAIL

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

araujoluis marked 7 inline comments as done. araujoluis added a comment. Changes made. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D29502 To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham Cc: broulik, cfeck, kde-frameworks-devel, LeGast00n,

D29513: [kcm trash] Change kcm trash size percent to 2 decimal places

This revision was automatically updated to reflect the committed changes. Closed by commit R241:92ba7545763b: [kcm trash] Change kcm trash size percent to 2 decimal places (authored by shubham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29513?vs=82221=82345

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

cfeck added inline comments. INLINE COMMENTS > kcolorcombo.cpp:89 > +int unused, v; > +innercolor.getHsv(, , ); > +textColor = v > 128 ? Qt::black : Qt::white; Please don't use "value" component to calculate the brightness of a color. #81 is much darker

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 96 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/96/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 09 May 2020 10:05:03 + Build duration: 34 min and counting JUnit Tests Name: projectroot

D29485: [CopyJob] Check free space for remote urls before copying and other improvements

ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in copyjob.cpp:444 > I'm a bit confused. My explanation here points to kio_desktop and kio_remote > (and was apparently clear), and the API docs for UDS_LOCAL_PATH say > > /// A local file path if the ioslave display files

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.14 - Build # 17 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.14/17/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 09 May 2020 11:26:40 + Build duration: 12 min and counting JUnit Tests Name:

D29397: KPreviewJob : Support for DeviceRatioPixel

meven updated this revision to Diff 82335. meven added a comment. Fix thumbpath when in devicepixel subdir REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29397?vs=82331=82335 BRANCH preview-dpr REVISION DETAIL https://phabricator.kde.org/D29397 AFFECTED

D29397: KPreviewJob : Support for DeviceRatioPixel

meven updated this revision to Diff 82339. meven added a comment. Rebasing REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29397?vs=82335=82339 BRANCH preview-dpr REVISION DETAIL https://phabricator.kde.org/D29397 AFFECTED FILES

D29547: KRun: deprecate all static 'run*' methods, with full porting instructions

dfaure added a dependent revision: D29557: Add KIO::OpenUrlJob::setShowOpenWithDialog as replacement for KRun::displayOpenWithDialog. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29547 To: dfaure, ahmadsamir, broulik Cc: kde-frameworks-devel, LeGast00n, cblack,

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 587 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/587/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 09 May 2020 10:55:21 + Build duration: 5 min 46 sec and counting BUILD ARTIFACTS

D29354: Bash: fix comments after escapes

This revision was automatically updated to reflect the committed changes. Closed by commit R216:1e8466029c82: Bash: fix comments after escapes (authored by nibags, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D29354: Bash: fix comments after escapes

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Same here ;=) Thanks a lot for the work on all this issues! REPOSITORY R216 Syntax Highlighting BRANCH fix-comments-bash REVISION DETAIL https://phabricator.kde.org/D29354 To:

KDE CI: Frameworks » kbookmarks » kf5-qt5 WindowsMSVCQt5.14 - Build # 27 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20WindowsMSVCQt5.14/27/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sat, 09 May 2020 11:25:38 + Build duration: 16 min and counting JUnit Tests Name:

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.14 - Build # 13 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.14/13/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 09 May 2020 11:27:00 + Build duration: 14 min and counting JUnit Tests Name:

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 190 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/190/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 09 May 2020 11:26:40 + Build duration: 14 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » frameworkintegration » kf5-qt5 WindowsMSVCQt5.14 - Build # 18 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/frameworkintegration/job/kf5-qt5%20WindowsMSVCQt5.14/18/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sat, 09 May 2020 11:24:48 + Build duration: 25 min and counting JUnit Tests

D29525: Make Previews devicePixelRatio aware

meven updated this revision to Diff 82336. meven added a comment. Add missing dependency bump REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29525?vs=82257=82336 BRANCH arcpatch-D29525 REVISION DETAIL https://phabricator.kde.org/D29525 AFFECTED

D29485: [CopyJob] Check free space for remote urls before copying and other improvements

ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in copyjob.cpp:477 > I'm assuming the TODO was about "What if I'm using a NFS mount and the > connection breaks at the time of KDiskFreeSpaceInfo, i.e. what should we do > about error handling". > > But I think the current code

D28745: Skip caching thumbnails on encrypted filesystems

marcingu marked an inline comment as done. marcingu added inline comments. INLINE COMMENTS > meven wrote in thumbnail.cpp:738 > There is an error with the previous line, one of the two should be > allowDirCached I think. > Here you always ignore result of `sharesFilesystemWithThumbRoot` Could

D29485: [CopyJob] Check free space for remote urls before copying and other improvements

ahmadsamir added a comment. @dfaure please don't forget to flesh out the UDS_LOCAL_PATH docs https://phabricator.kde.org/D29485#inline-169199 REPOSITORY R241 KIO BRANCH l-freespace-remote-2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D29485 To: ahmadsamir,

  1   2   >