Re: Review Request 112745: karchive - remove unused dependency

2013-09-15 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112745/#review40087 --- Ship it! Ship It! - David Faure On Sept. 15, 2013, 3:09 p.m

Build failed in Jenkins: kdelibs_frameworks_qt5 #1201

2013-09-15 Thread KDE CI System
See Changes: [hein] Rename KCoreAuthorized to KAuthorized, KAuthorized to KUrlAuthorized. -- [...truncated 30032 lines...] -- Installing:

Re: Review Request 112722: Juggle around Kiosk include names to avoid incorrect library linkage and for better layering

2013-09-15 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112722/ --- (Updated Sept. 15, 2013, 11:33 p.m.) Status -- This change has been m

Re: Review Request 112722: Juggle around Kiosk include names to avoid incorrect library linkage and for better layering

2013-09-15 Thread Eike Hein
> On Sept. 15, 2013, 8:37 a.m., David Faure wrote: > > Only some docu is missing: @since 5.0 in the new namespace (or its methods, > > rather), and porting instructions in KDE5PORTING.html Thanks :). The pushed version includes the requested docs changes. - Eike

Re: Review Request 112722: Juggle around Kiosk include names to avoid incorrect library linkage and for better layering

2013-09-15 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112722/#review40085 --- This review has been submitted with commit 9319f78c6ad63a377ae

Review Request 112745: karchive - remove unused dependency

2013-09-15 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112745/ --- Review request for KDE Frameworks. Description --- I can't find any r

Re: Review Request 112702: KIO slavebase listEntry improvement and cleanups

2013-09-15 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112702/#review40070 --- This review has been submitted with commit 61815341d9761068e3c

Re: Review Request 112702: KIO slavebase listEntry improvement and cleanups

2013-09-15 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112702/ --- (Updated Sept. 15, 2013, 3 p.m.) Status -- This change has been marke

Re: Review Request 112662: Clean up CMakeLists.txt and prepare for splitting KEmoticons

2013-09-15 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112662/ --- (Updated Sept. 15, 2013, 12:27 p.m.) Review request for KDE Frameworks and

Re: Review Request 112662: Clean up CMakeLists.txt and prepare for splitting KEmoticons

2013-09-15 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112662/ --- (Updated Sept. 15, 2013, 12:26 p.m.) Review request for KDE Frameworks and

Re: Review Request 112717: Start adopting QCollator

2013-09-15 Thread Frank Reininghaus
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112717/#review40054 --- Thanks for your cool work on QCollator! It will be interesting

Re: Review Request 112681: Tests for KPluginTrader and friends

2013-09-15 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112681/#review40051 --- Data-driven tests *can* be run separately (and therefore qDebug

Re: Review Request 112722: Juggle around Kiosk include names to avoid incorrect library linkage and for better layering

2013-09-15 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112722/#review40048 --- Ship it! Only some docu is missing: @since 5.0 in the new name

Re: Review Request 112702: KIO slavebase listEntry improvement and cleanups

2013-09-15 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112702/#review40047 --- Ship it! Thanks! - David Faure On Sept. 14, 2013, 10:36 p.m

Re: Review Request 112702: KIO slavebase listEntry improvement and cleanups

2013-09-15 Thread David Faure
> On Sept. 14, 2013, 10:45 a.m., David Faure wrote: > > staging/kio/src/core/slavebase.h, line 23 > > > > > > I'm pretty sure it was included already, via one of the kio/* includes > > below. You can just remove t

Re: Dependency specifications

2013-09-15 Thread Alexander Neundorf
On Sunday 15 September 2013, Aleix Pol wrote: > On Sat, Sep 14, 2013 at 7:42 PM, Stephen Kelly wrote: > > Aleix Pol wrote: > > > I'd say that all Qt dependencies in the module should be defined only > > > > once > > > > > in the root CMakeLists.txt. Actually this should be the only file with > >