Re: kcmutils linking issues
Hello, And what's the error message? -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 After his patch http://commits.kde.org/kdelibs/aac41bc93595a0f341886692fba48717a1a9e2a9, the issue has been fixed by itself... I can no more reproduce it. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 113045: Prepare KCMUtils for move to tier3
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113045/ --- Review request for KDE Frameworks. Repository: kdelibs Description --- Only find publicly used libraries in cmake.in KCategoryDrawer - KCategoryDrawerV3 No QString cast from ascii Diffs - staging/kcmutils/CMakeLists.txt dc577d3 staging/kcmutils/KCMUtilsConfig.cmake.in c67ad52 staging/kcmutils/src/CMakeLists.txt dc19649 staging/kcmutils/src/kcmodulecontainer.cpp c08eda2 staging/kcmutils/src/kcmoduleinfo.cpp f46308c staging/kcmutils/src/kcmoduleproxy.cpp d2db3ab staging/kcmutils/src/kcmultidialog.cpp 4812407 staging/kcmutils/src/kpluginselector.cpp 77cbfda staging/kcmutils/src/kpluginselector_p.h 2dffae0 staging/kcmutils/src/ksettings/componentsdialog.cpp 111549a staging/kcmutils/src/ksettings/dialog.cpp 131f75f staging/kcmutils/src/ksettings/dispatcher.cpp 48bb0fc staging/kcmutils/src/ksettings/pluginpage.cpp 0577908 Diff: http://git.reviewboard.kde.org/r/113045/diff/ Testing --- Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: [Review Request] Modularizing KF5
On Tuesday 01 October 2013 19:28:04 Aleix Pol wrote: Hi, Since ReviewBoard is not working for me, I decided to send this review as an e-mail. I know it's less practical, but also I think it's important to get it done and I'd rather go reasonably fast with it before we start getting too much conflicts. This patch removes all find_package usages in the root CMakeLists.txt file (not the includes, only find_package) and moves it to every different module or unsplitted folder. ENOPATCH :) ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: [Review Request] Modularizing KF5
On Wednesday 02 October 2013 10:14:12 Aurélien Gâteau wrote: On Tuesday 01 October 2013 19:28:04 Aleix Pol wrote: Hi, Since ReviewBoard is not working for me, I decided to send this review as an e-mail. I know it's less practical, but also I think it's important to get it done and I'd rather go reasonably fast with it before we start getting too much conflicts. This patch removes all find_package usages in the root CMakeLists.txt file (not the includes, only find_package) and moves it to every different module or unsplitted folder. ENOPATCH :) Ignore me. Just read the mail again, the changes are actually in the kf5_find_package branch. Aurélien ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: [Review Request] Modularizing KF5
Aurélien Gâteau wrote:
On Tuesday 01 October 2013 19:28:04 Aleix Pol wrote:
Hi,
Since ReviewBoard is not working for me, I decided to send this review as
an e-mail. I know it's less practical, but also I think it's important to
get it done and I'd rather go reasonably fast with it before we start
getting too much conflicts.
I for one a big reviewboard non-fan. I much prefer reviewing patches in
email or outside git remotes.
This patch removes all find_package usages in the root CMakeLists.txt
file (not the includes, only find_package) and moves it to every
different module or unsplitted folder.
ENOPATCH :)
He pushed a branch to the kdelibs.git repo, which is unfortunate. There's so
many dead branches in there, you'd be forgiven for not noticing. I wish it
only was allowed to contain branches which contain releases and master. All
of these 'personal work branches' should be in other remotes.
Anyway, Aleix, it looks like a lot of the use of macro_bool_to_01 is
obsolete.
All configure_file uses of HAVE_X11 seem to already use #cmakedefine01.
git grep -e HAVE_X11 --and -e cmakedefine
Replace the use of macro_bool_to_01 with set() first in a separate patch.
set(HAVE_X11 ${X11_FOUND})
Why did you comment the HAVE_QSSLSOCKET check?
Thanks,
Steve.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 113046: Move kconfigwidgets to tier3
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113046/ --- Review request for KDE Frameworks. Repository: kdelibs Description --- Move kconfigwidgets to tier3 Diffs - staging/CMakeLists.txt f3d9d2f staging/kconfigwidgets/CMakeLists.txt staging/kconfigwidgets/KConfigWidgetsConfig.cmake.in staging/kconfigwidgets/autotests/CMakeLists.txt staging/kconfigwidgets/autotests/kconfigdialog_unittest.cpp staging/kconfigwidgets/autotests/kstandardactiontest.h staging/kconfigwidgets/autotests/kstandardactiontest.cpp staging/kconfigwidgets/docs/DESIGN.COLOR staging/kconfigwidgets/src/CMakeLists.txt staging/kconfigwidgets/src/kcmodule.h staging/kconfigwidgets/src/kcmodule.cpp staging/kconfigwidgets/src/kcodecaction.h staging/kconfigwidgets/src/kcodecaction.cpp staging/kconfigwidgets/src/kcolorscheme.h staging/kconfigwidgets/src/kcolorscheme.cpp staging/kconfigwidgets/src/kconfigdialog.h staging/kconfigwidgets/src/kconfigdialog.cpp staging/kconfigwidgets/src/kconfigdialogmanager.h staging/kconfigwidgets/src/kconfigdialogmanager.cpp staging/kconfigwidgets/src/kconfigviewstatesaver.h staging/kconfigwidgets/src/kconfigviewstatesaver.cpp staging/kconfigwidgets/src/klanguagebutton.h staging/kconfigwidgets/src/klanguagebutton.cpp staging/kconfigwidgets/src/kpastetextaction.h staging/kconfigwidgets/src/kpastetextaction.cpp staging/kconfigwidgets/src/krecentfilesaction.h staging/kconfigwidgets/src/krecentfilesaction.cpp staging/kconfigwidgets/src/krecentfilesaction_p.h staging/kconfigwidgets/src/kstandardaction.h staging/kconfigwidgets/src/kstandardaction.cpp staging/kconfigwidgets/src/kstandardaction_p.h staging/kconfigwidgets/src/ktip-bulb.png staging/kconfigwidgets/src/ktip.h staging/kconfigwidgets/src/ktip.cpp staging/kconfigwidgets/src/kviewstatemaintainer.h staging/kconfigwidgets/src/preparetips staging/kconfigwidgets/tests/CMakeLists.txt staging/kconfigwidgets/tests/kcodecactiontest.h staging/kconfigwidgets/tests/kcodecactiontest.cpp staging/kconfigwidgets/tests/kcolorutilsdemo.h staging/kconfigwidgets/tests/kcolorutilsdemo.cpp staging/kconfigwidgets/tests/kcolorutilsdemo.ui staging/kconfigwidgets/tests/kimageframe.h staging/kconfigwidgets/tests/kimageframe.cpp staging/kconfigwidgets/tests/klanguagebuttontest.cpp superbuild/CMakeLists.txt fe99c2f tier3/CMakeLists.txt ec0b9b4 Diff: http://git.reviewboard.kde.org/r/113046/diff/ Testing --- Still builds, tests pass. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112931: Prepare kconfigwidgets for tier3
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112931/ --- (Updated Oct. 2, 2013, 10:33 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kdelibs Description --- These changes make kconfigwidgets build standalone, so that it can be moved to tier3. Diffs - CMakeLists.txt eb1ea8c staging/kconfigwidgets/CMakeLists.txt a2a0b8a staging/kconfigwidgets/src/CMakeLists.txt 905509d staging/kconfigwidgets/tests/CMakeLists.txt bc52bc1 superbuild/CMakeLists.txt 86e3389 Diff: http://git.reviewboard.kde.org/r/112931/diff/ Testing --- Builds within kdelibs and within superbuild. Tests pass. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113046: Move kconfigwidgets to tier3
Aurélien Gâteau wrote: Move kconfigwidgets to tier3 When I suggested tiers, I proposed that tier2 frameworks could depend on other tier2 frameworks. http://thread.gmane.org/gmane.comp.kde.devel.core/67458/focus=67520 http://techbase.kde.org/index.php?title=Projects/KDELibsModificationsoldid=55633 The reason for that is that the difference between one common-origin dependency and zero common-origin dependencies is huge, whereas the difference between one common-origin dependency and two common-origin dependencies is tiny by comparison, from a pov of using something. The common-origin point is important because it means that KF5::Something version X.Y depends on KF5::Dependency version X.Y, which are released at the same time. It doesn't matter that KArchive depends on zlib, because it can probably work with a zlib released long ago and already widely distributed. When the repos are split, the difference between tier2 and tier3 will matter even less. The kconfigwidgets framework will depend on another framework which happens to have a tier2 label. That does not mean that kconfigwidgets should get a tier3 label. I suggest moving kconfigwidgets to tier2/ instead, and being clear that it is ok for tier2 to depend on tier2. Thanks, Steve. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112998: Add a simple app to test KPrintPreview
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112998/#review41099 --- the add_subdirectory(tests) is still commented in staging/kprintutils/CMakeLists.txt. Just uncommented it to test, the test app does not do much yet, but it does what you said :) I'd say ship it once the add_subdirectory() call is uncommented and the indent is fixed. staging/kprintutils/tests/CMakeLists.txt http://git.reviewboard.kde.org/r/112998/#comment30166 nitpick: 2-spaces indent is more common in kdelibs CMake files. - Aurélien Gâteau On Oct. 1, 2013, 10:06 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112998/ --- (Updated Oct. 1, 2013, 10:06 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Simple app testing KPrintPreview. However there's no suitable pdf KPart right now so at this point it tests the case of missing such KPart. Which is also good. It will work as expected once such KPart exists. Diffs - staging/kprintutils/tests/CMakeLists.txt PRE-CREATION staging/kprintutils/tests/kprintpreview_test.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112998/diff/ Testing --- Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112998: Add a simple app to test KPrintPreview
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112998/ --- (Updated Oct. 2, 2013, 9:27 a.m.) Review request for KDE Frameworks. Changes --- Uncomment tests directory; fix indentation Repository: kdelibs Description --- Simple app testing KPrintPreview. However there's no suitable pdf KPart right now so at this point it tests the case of missing such KPart. Which is also good. It will work as expected once such KPart exists. Diffs (updated) - staging/kprintutils/CMakeLists.txt 54d3d40 staging/kprintutils/tests/CMakeLists.txt PRE-CREATION staging/kprintutils/tests/kprintpreview_test.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112998/diff/ Testing --- Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113046: Move kconfigwidgets to tier3
On Wednesday 02 October 2013 11:09:59 Stephen Kelly wrote: Aurélien Gâteau wrote: Move kconfigwidgets to tier3 When I suggested tiers, I proposed that tier2 frameworks could depend on other tier2 frameworks. http://thread.gmane.org/gmane.comp.kde.devel.core/67458/focus=67520 http://techbase.kde.org/index.php?title=Projects/KDELibsModificationsoldid =55633 The reason for that is that the difference between one common-origin dependency and zero common-origin dependencies is huge, whereas the difference between one common-origin dependency and two common-origin dependencies is tiny by comparison, from a pov of using something. The common-origin point is important because it means that KF5::Something version X.Y depends on KF5::Dependency version X.Y, which are released at the same time. It doesn't matter that KArchive depends on zlib, because it can probably work with a zlib released long ago and already widely distributed. When the repos are split, the difference between tier2 and tier3 will matter even less. The kconfigwidgets framework will depend on another framework which happens to have a tier2 label. That does not mean that kconfigwidgets should get a tier3 label. I suggest moving kconfigwidgets to tier2/ instead, and being clear that it is ok for tier2 to depend on tier2. I don't have any strong opinion on this, but if we allow tier2 frameworks to depend on other tier2 frameworks then is there a need for tier3 at all? Your wiki pages seems to indicate there is no need for it. Aurélien ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112998: Add a simple app to test KPrintPreview
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112998/ --- (Updated Oct. 2, 2013, 9:36 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kdelibs Description --- Simple app testing KPrintPreview. However there's no suitable pdf KPart right now so at this point it tests the case of missing such KPart. Which is also good. It will work as expected once such KPart exists. Diffs - staging/kprintutils/CMakeLists.txt 54d3d40 staging/kprintutils/tests/CMakeLists.txt PRE-CREATION staging/kprintutils/tests/kprintpreview_test.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112998/diff/ Testing --- Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112998: Add a simple app to test KPrintPreview
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112998/#review41101 --- This review has been submitted with commit 0110e8148a52c88fba9c584f51ed400dc0d801a0 by Martin Klapetek to branch frameworks. - Commit Hook On Oct. 2, 2013, 9:27 a.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112998/ --- (Updated Oct. 2, 2013, 9:27 a.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Simple app testing KPrintPreview. However there's no suitable pdf KPart right now so at this point it tests the case of missing such KPart. Which is also good. It will work as expected once such KPart exists. Diffs - staging/kprintutils/CMakeLists.txt 54d3d40 staging/kprintutils/tests/CMakeLists.txt PRE-CREATION staging/kprintutils/tests/kprintpreview_test.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112998/diff/ Testing --- Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113046: Move kconfigwidgets to tier3
Aurélien Gâteau wrote: I don't have any strong opinion on this, but if we allow tier2 frameworks to depend on other tier2 frameworks then is there a need for tier3 at all? Your wiki pages seems to indicate there is no need for it. That wiki page predates the Randa meeting, where some stuff was made more- concrete. I don't know of any reason to not let tier2 depend on tier2 though. Thanks, Steve. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 113048: Move KPrintUtils to tier3
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113048/ --- Review request for KDE Frameworks. Repository: kdelibs Description --- Tier3 because of KService Diffs - staging/CMakeLists.txt f3d9d2f staging/kprintutils/CMakeLists.txt staging/kprintutils/KPrintUtilsConfig.cmake.in staging/kprintutils/src/CMakeLists.txt staging/kprintutils/src/config-kprintutils.h.cmake staging/kprintutils/src/kcupsoptionsjobwidget_p.h staging/kprintutils/src/kcupsoptionspageswidget.ui staging/kprintutils/src/kcupsoptionspageswidget_p.h staging/kprintutils/src/kcupsoptionspageswidget_p.cpp staging/kprintutils/src/kcupsoptionssettingswidget_p.h staging/kprintutils/src/kcupsoptionswidget_p.h staging/kprintutils/src/kcupsoptionswidget_p.cpp staging/kprintutils/src/kdeprintdialog.h staging/kprintutils/src/kdeprintdialog.cpp staging/kprintutils/src/kprintpreview.h staging/kprintutils/src/kprintpreview.cpp staging/kprintutils/tests/CMakeLists.txt staging/kprintutils/tests/kprintpreview_test.cpp tier3/CMakeLists.txt ec0b9b4 Diff: http://git.reviewboard.kde.org/r/113048/diff/ Testing --- Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113048: Move KPrintUtils to tier3
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113048/ --- (Updated Oct. 2, 2013, 10:29 a.m.) Review request for KDE Frameworks. Repository: kdelibs Description (updated) --- Tier3 because of KService and KParts Diffs - staging/CMakeLists.txt f3d9d2f staging/kprintutils/CMakeLists.txt staging/kprintutils/KPrintUtilsConfig.cmake.in staging/kprintutils/src/CMakeLists.txt staging/kprintutils/src/config-kprintutils.h.cmake staging/kprintutils/src/kcupsoptionsjobwidget_p.h staging/kprintutils/src/kcupsoptionspageswidget.ui staging/kprintutils/src/kcupsoptionspageswidget_p.h staging/kprintutils/src/kcupsoptionspageswidget_p.cpp staging/kprintutils/src/kcupsoptionssettingswidget_p.h staging/kprintutils/src/kcupsoptionswidget_p.h staging/kprintutils/src/kcupsoptionswidget_p.cpp staging/kprintutils/src/kdeprintdialog.h staging/kprintutils/src/kdeprintdialog.cpp staging/kprintutils/src/kprintpreview.h staging/kprintutils/src/kprintpreview.cpp staging/kprintutils/tests/CMakeLists.txt staging/kprintutils/tests/kprintpreview_test.cpp tier3/CMakeLists.txt ec0b9b4 Diff: http://git.reviewboard.kde.org/r/113048/diff/ Testing --- Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113045: Prepare KCMUtils for move to tier3
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113045/#review41105 --- staging/kcmutils/CMakeLists.txt http://git.reviewboard.kde.org/r/113045/#comment30168 Why removing these? - Aleix Pol Gonzalez On Oct. 2, 2013, 8:06 a.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113045/ --- (Updated Oct. 2, 2013, 8:06 a.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Only find publicly used libraries in cmake.in KCategoryDrawer - KCategoryDrawerV3 No QString cast from ascii Diffs - staging/kcmutils/CMakeLists.txt dc577d3 staging/kcmutils/KCMUtilsConfig.cmake.in c67ad52 staging/kcmutils/src/CMakeLists.txt dc19649 staging/kcmutils/src/kcmodulecontainer.cpp c08eda2 staging/kcmutils/src/kcmoduleinfo.cpp f46308c staging/kcmutils/src/kcmoduleproxy.cpp d2db3ab staging/kcmutils/src/kcmultidialog.cpp 4812407 staging/kcmutils/src/kpluginselector.cpp 77cbfda staging/kcmutils/src/kpluginselector_p.h 2dffae0 staging/kcmutils/src/ksettings/componentsdialog.cpp 111549a staging/kcmutils/src/ksettings/dialog.cpp 131f75f staging/kcmutils/src/ksettings/dispatcher.cpp 48bb0fc staging/kcmutils/src/ksettings/pluginpage.cpp 0577908 Diff: http://git.reviewboard.kde.org/r/113045/diff/ Testing --- Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112828: Provide ecm_add_unit_test() and ecm_add_multiple_unit_tests()
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112828/#review41107 --- ping, Richardson can you comment over this review? we really need to get this going... - Aleix Pol Gonzalez On Sept. 19, 2013, 3:57 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112828/ --- (Updated Sept. 19, 2013, 3:57 p.m.) Review request for Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- Add a new functions to add unit tests Every framework in KF5 has a macro similar to these, this reduces the unnecessary duplication inside all of the frameworks Diffs - modules/ECMAddUnitTest.cmake PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112828/diff/ Testing --- Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113048: Move KPrintUtils to tier3
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113048/#review41108 --- Ship it! Ship It! - Aleix Pol Gonzalez On Oct. 2, 2013, 10:29 a.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113048/ --- (Updated Oct. 2, 2013, 10:29 a.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Tier3 because of KService and KParts Diffs - staging/CMakeLists.txt f3d9d2f staging/kprintutils/CMakeLists.txt staging/kprintutils/KPrintUtilsConfig.cmake.in staging/kprintutils/src/CMakeLists.txt staging/kprintutils/src/config-kprintutils.h.cmake staging/kprintutils/src/kcupsoptionsjobwidget_p.h staging/kprintutils/src/kcupsoptionspageswidget.ui staging/kprintutils/src/kcupsoptionspageswidget_p.h staging/kprintutils/src/kcupsoptionspageswidget_p.cpp staging/kprintutils/src/kcupsoptionssettingswidget_p.h staging/kprintutils/src/kcupsoptionswidget_p.h staging/kprintutils/src/kcupsoptionswidget_p.cpp staging/kprintutils/src/kdeprintdialog.h staging/kprintutils/src/kdeprintdialog.cpp staging/kprintutils/src/kprintpreview.h staging/kprintutils/src/kprintpreview.cpp staging/kprintutils/tests/CMakeLists.txt staging/kprintutils/tests/kprintpreview_test.cpp tier3/CMakeLists.txt ec0b9b4 Diff: http://git.reviewboard.kde.org/r/113048/diff/ Testing --- Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113046: Move kconfigwidgets to tier3
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113046/#review41109 --- Ship it! Ship It! - Aleix Pol Gonzalez On Oct. 2, 2013, 8:33 a.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113046/ --- (Updated Oct. 2, 2013, 8:33 a.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Move kconfigwidgets to tier3 Diffs - staging/CMakeLists.txt f3d9d2f staging/kconfigwidgets/CMakeLists.txt staging/kconfigwidgets/KConfigWidgetsConfig.cmake.in staging/kconfigwidgets/autotests/CMakeLists.txt staging/kconfigwidgets/autotests/kconfigdialog_unittest.cpp staging/kconfigwidgets/autotests/kstandardactiontest.h staging/kconfigwidgets/autotests/kstandardactiontest.cpp staging/kconfigwidgets/docs/DESIGN.COLOR staging/kconfigwidgets/src/CMakeLists.txt staging/kconfigwidgets/src/kcmodule.h staging/kconfigwidgets/src/kcmodule.cpp staging/kconfigwidgets/src/kcodecaction.h staging/kconfigwidgets/src/kcodecaction.cpp staging/kconfigwidgets/src/kcolorscheme.h staging/kconfigwidgets/src/kcolorscheme.cpp staging/kconfigwidgets/src/kconfigdialog.h staging/kconfigwidgets/src/kconfigdialog.cpp staging/kconfigwidgets/src/kconfigdialogmanager.h staging/kconfigwidgets/src/kconfigdialogmanager.cpp staging/kconfigwidgets/src/kconfigviewstatesaver.h staging/kconfigwidgets/src/kconfigviewstatesaver.cpp staging/kconfigwidgets/src/klanguagebutton.h staging/kconfigwidgets/src/klanguagebutton.cpp staging/kconfigwidgets/src/kpastetextaction.h staging/kconfigwidgets/src/kpastetextaction.cpp staging/kconfigwidgets/src/krecentfilesaction.h staging/kconfigwidgets/src/krecentfilesaction.cpp staging/kconfigwidgets/src/krecentfilesaction_p.h staging/kconfigwidgets/src/kstandardaction.h staging/kconfigwidgets/src/kstandardaction.cpp staging/kconfigwidgets/src/kstandardaction_p.h staging/kconfigwidgets/src/ktip-bulb.png staging/kconfigwidgets/src/ktip.h staging/kconfigwidgets/src/ktip.cpp staging/kconfigwidgets/src/kviewstatemaintainer.h staging/kconfigwidgets/src/preparetips staging/kconfigwidgets/tests/CMakeLists.txt staging/kconfigwidgets/tests/kcodecactiontest.h staging/kconfigwidgets/tests/kcodecactiontest.cpp staging/kconfigwidgets/tests/kcolorutilsdemo.h staging/kconfigwidgets/tests/kcolorutilsdemo.cpp staging/kconfigwidgets/tests/kcolorutilsdemo.ui staging/kconfigwidgets/tests/kimageframe.h staging/kconfigwidgets/tests/kimageframe.cpp staging/kconfigwidgets/tests/klanguagebuttontest.cpp superbuild/CMakeLists.txt fe99c2f tier3/CMakeLists.txt ec0b9b4 Diff: http://git.reviewboard.kde.org/r/113046/diff/ Testing --- Still builds, tests pass. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113048: Move KPrintUtils to tier3
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113048/ --- (Updated Oct. 2, 2013, 11:48 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kdelibs Description --- Tier3 because of KService and KParts Diffs - staging/CMakeLists.txt f3d9d2f staging/kprintutils/CMakeLists.txt staging/kprintutils/KPrintUtilsConfig.cmake.in staging/kprintutils/src/CMakeLists.txt staging/kprintutils/src/config-kprintutils.h.cmake staging/kprintutils/src/kcupsoptionsjobwidget_p.h staging/kprintutils/src/kcupsoptionspageswidget.ui staging/kprintutils/src/kcupsoptionspageswidget_p.h staging/kprintutils/src/kcupsoptionspageswidget_p.cpp staging/kprintutils/src/kcupsoptionssettingswidget_p.h staging/kprintutils/src/kcupsoptionswidget_p.h staging/kprintutils/src/kcupsoptionswidget_p.cpp staging/kprintutils/src/kdeprintdialog.h staging/kprintutils/src/kdeprintdialog.cpp staging/kprintutils/src/kprintpreview.h staging/kprintutils/src/kprintpreview.cpp staging/kprintutils/tests/CMakeLists.txt staging/kprintutils/tests/kprintpreview_test.cpp tier3/CMakeLists.txt ec0b9b4 Diff: http://git.reviewboard.kde.org/r/113048/diff/ Testing --- Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113048: Move KPrintUtils to tier3
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113048/#review41112 --- This review has been submitted with commit 51d842f411194d22ff821aa5469b2a5332b2d0f5 by Martin Klapetek to branch frameworks. - Commit Hook On Oct. 2, 2013, 10:29 a.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113048/ --- (Updated Oct. 2, 2013, 10:29 a.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Tier3 because of KService and KParts Diffs - staging/CMakeLists.txt f3d9d2f staging/kprintutils/CMakeLists.txt staging/kprintutils/KPrintUtilsConfig.cmake.in staging/kprintutils/src/CMakeLists.txt staging/kprintutils/src/config-kprintutils.h.cmake staging/kprintutils/src/kcupsoptionsjobwidget_p.h staging/kprintutils/src/kcupsoptionspageswidget.ui staging/kprintutils/src/kcupsoptionspageswidget_p.h staging/kprintutils/src/kcupsoptionspageswidget_p.cpp staging/kprintutils/src/kcupsoptionssettingswidget_p.h staging/kprintutils/src/kcupsoptionswidget_p.h staging/kprintutils/src/kcupsoptionswidget_p.cpp staging/kprintutils/src/kdeprintdialog.h staging/kprintutils/src/kdeprintdialog.cpp staging/kprintutils/src/kprintpreview.h staging/kprintutils/src/kprintpreview.cpp staging/kprintutils/tests/CMakeLists.txt staging/kprintutils/tests/kprintpreview_test.cpp tier3/CMakeLists.txt ec0b9b4 Diff: http://git.reviewboard.kde.org/r/113048/diff/ Testing --- Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113045: Prepare KCMUtils for move to tier3
On Oct. 2, 2013, 11:02 a.m., Aleix Pol Gonzalez wrote: staging/kcmutils/CMakeLists.txt, line 23 http://git.reviewboard.kde.org/r/113045/diff/1/?file=193397#file193397line23 Why removing these? As I understand it everything should compile with -DQT_NO_CAST_TO_ASCII, it was previously added here to make it compile before all the blah - QLiteralString(blah) changes. - David --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113045/#review41105 --- On Oct. 2, 2013, 8:06 a.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113045/ --- (Updated Oct. 2, 2013, 8:06 a.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Only find publicly used libraries in cmake.in KCategoryDrawer - KCategoryDrawerV3 No QString cast from ascii Diffs - staging/kcmutils/CMakeLists.txt dc577d3 staging/kcmutils/KCMUtilsConfig.cmake.in c67ad52 staging/kcmutils/src/CMakeLists.txt dc19649 staging/kcmutils/src/kcmodulecontainer.cpp c08eda2 staging/kcmutils/src/kcmoduleinfo.cpp f46308c staging/kcmutils/src/kcmoduleproxy.cpp d2db3ab staging/kcmutils/src/kcmultidialog.cpp 4812407 staging/kcmutils/src/kpluginselector.cpp 77cbfda staging/kcmutils/src/kpluginselector_p.h 2dffae0 staging/kcmutils/src/ksettings/componentsdialog.cpp 111549a staging/kcmutils/src/ksettings/dialog.cpp 131f75f staging/kcmutils/src/ksettings/dispatcher.cpp 48bb0fc staging/kcmutils/src/ksettings/pluginpage.cpp 0577908 Diff: http://git.reviewboard.kde.org/r/113045/diff/ Testing --- Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113045: Prepare KCMUtils for move to tier3
David Edmundson wrote: On Oct. 2, 2013, 11:02 a.m., Aleix Pol Gonzalez wrote: staging/kcmutils/CMakeLists.txt, line 23 http://git.reviewboard.kde.org/r/113045/diff/1/?file=193397#file193397line23 Why removing these? As I understand it everything should compile with -DQT_NO_CAST_TO_ASCII, it was previously added here to make it compile before all the blah - QLiteralString(blah) changes. This discussion is exactly why you are supposed to make changes like this before the move in a separate patch, so that you can explain the above in a commit message. Then the move commit is 'clean'. Thanks, Steve. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113045: Prepare KCMUtils for move to tier3
I haven't moved anything. Also this review is 3 different commits, one for each of the sentences in the description. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: [Review Request] Modularizing KF5
On Wed, Oct 2, 2013 at 10:25 AM, Stephen Kelly steve...@gmail.com wrote:
Aurélien Gâteau wrote:
On Tuesday 01 October 2013 19:28:04 Aleix Pol wrote:
Hi,
Since ReviewBoard is not working for me, I decided to send this review
as
an e-mail. I know it's less practical, but also I think it's important
to
get it done and I'd rather go reasonably fast with it before we start
getting too much conflicts.
I for one a big reviewboard non-fan. I much prefer reviewing patches in
email or outside git remotes.
This patch removes all find_package usages in the root CMakeLists.txt
file (not the includes, only find_package) and moves it to every
different module or unsplitted folder.
ENOPATCH :)
He pushed a branch to the kdelibs.git repo, which is unfortunate. There's
so
many dead branches in there, you'd be forgiven for not noticing. I wish it
only was allowed to contain branches which contain releases and master. All
of these 'personal work branches' should be in other remotes.
Anyway, Aleix, it looks like a lot of the use of macro_bool_to_01 is
obsolete.
All configure_file uses of HAVE_X11 seem to already use #cmakedefine01.
git grep -e HAVE_X11 --and -e cmakedefine
Replace the use of macro_bool_to_01 with set() first in a separate patch.
set(HAVE_X11 ${X11_FOUND})
Why did you comment the HAVE_QSSLSOCKET check?
Thanks,
Steve.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
I pushed a couple of new commits that remove the usage of macro_bool_to_01
and the HAVE_QSSLSOCKET thing.
Aleix
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113045: Prepare KCMUtils for move to tier3
David Edmundson wrote: I haven't moved anything. Also this review is 3 different commits, one for each of the sentences in the description. Indeed, thanks! Steve. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: [Review Request] Modularizing KF5
Aleix Pol wrote: I pushed a couple of new commits that remove the usage of macro_bool_to_01 and the HAVE_QSSLSOCKET thing. I assume you have no intention of merging that branch? The top commit looks fine at least. Please cherry-pick it to frameworks, and rebase and clean-up the rest of the kf5_find_package branch. Thanks, Steve. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113046: Move kconfigwidgets to tier3
On Wednesday 02 October 2013 12:06:57 Stephen Kelly wrote: Aurélien Gâteau wrote: I don't have any strong opinion on this, but if we allow tier2 frameworks to depend on other tier2 frameworks then is there a need for tier3 at all? Your wiki pages seems to indicate there is no need for it. That wiki page predates the Randa meeting, where some stuff was made more- concrete. I don't know of any reason to not let tier2 depend on tier2 though. Still, what would be the difference between tier2 and tier3 if tier2 frameworks were allowed to depend on other tier2 frameworks? Aurélien ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113046: Move kconfigwidgets to tier3
Aurélien Gâteau wrote: On Wednesday 02 October 2013 12:06:57 Stephen Kelly wrote: Aurélien Gâteau wrote: I don't have any strong opinion on this, but if we allow tier2 frameworks to depend on other tier2 frameworks then is there a need for tier3 at all? Your wiki pages seems to indicate there is no need for it. That wiki page predates the Randa meeting, where some stuff was made more- concrete. I don't know of any reason to not let tier2 depend on tier2 though. Still, what would be the difference between tier2 and tier3 if tier2 frameworks were allowed to depend on other tier2 frameworks? I don't know. I don't see any benefit of 3 tiers instead of 2. I'd collapse tier3 into tier2 if it was my decision :). Thanks, Steve. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113046: Move kconfigwidgets to tier3
On Wednesday 02 October 2013 14:48:45 Stephen Kelly wrote: Aurélien Gâteau wrote: On Wednesday 02 October 2013 12:06:57 Stephen Kelly wrote: Aurélien Gâteau wrote: I don't have any strong opinion on this, but if we allow tier2 frameworks to depend on other tier2 frameworks then is there a need for tier3 at all? Your wiki pages seems to indicate there is no need for it. That wiki page predates the Randa meeting, where some stuff was made more- concrete. I don't know of any reason to not let tier2 depend on tier2 though. Still, what would be the difference between tier2 and tier3 if tier2 frameworks were allowed to depend on other tier2 frameworks? I don't know. I don't see any benefit of 3 tiers instead of 2. I'd collapse tier3 into tier2 if it was my decision :). I agree with this, but I think you should start a separate thread to discuss this topic, otherwise it is going to be missed by David, Kevin and others. For now I am going to move kconfigwidgets to tier3, will be simple to move it to tier2 with the others if your proposal is accepted. Aurélien ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113046: Move kconfigwidgets to tier3
On Wednesday, October 02, 2013 11:09:59 Stephen Kelly wrote: Aurélien Gâteau wrote: Move kconfigwidgets to tier3 When I suggested tiers, I proposed that tier2 frameworks could depend on other tier2 frameworks. http://thread.gmane.org/gmane.comp.kde.devel.core/67458/focus=67520 http://techbase.kde.org/index.php?title=Projects/KDELibsModificationsoldid =55633 The reason for that is that the difference between one common-origin dependency and zero common-origin dependencies is huge, whereas the difference between one common-origin dependency and two common-origin dependencies is tiny by comparison, from a pov of using something. The common-origin point is important because it means that KF5::Something version X.Y depends on KF5::Dependency version X.Y, which are released at the same time. It doesn't matter that KArchive depends on zlib, because it can probably work with a zlib released long ago and already widely distributed. When the repos are split, the difference between tier2 and tier3 will matter even less. The kconfigwidgets framework will depend on another framework which happens to have a tier2 label. That does not mean that kconfigwidgets should get a tier3 label. I suggest moving kconfigwidgets to tier2/ instead, and being clear that it is ok for tier2 to depend on tier2. http://dot.kde.org/sites/dot.kde.org/files/KDE%20Frameworks%205%20clean.png This diagram says that tier2 can't depend on tier2, and that's also how I understand it. The email and wiki changes you quote both predate the Randa meeting, so I think this has simply been revisited. -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113046: Move kconfigwidgets to tier3
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113046/#review41114 --- This review has been submitted with commit a0a0920fe3731cd780302d20bc4f3fe1d2d7525a by Aurélien Gâteau to branch frameworks. - Commit Hook On Oct. 2, 2013, 8:33 a.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113046/ --- (Updated Oct. 2, 2013, 8:33 a.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Move kconfigwidgets to tier3 Diffs - staging/CMakeLists.txt f3d9d2f staging/kconfigwidgets/CMakeLists.txt staging/kconfigwidgets/KConfigWidgetsConfig.cmake.in staging/kconfigwidgets/autotests/CMakeLists.txt staging/kconfigwidgets/autotests/kconfigdialog_unittest.cpp staging/kconfigwidgets/autotests/kstandardactiontest.h staging/kconfigwidgets/autotests/kstandardactiontest.cpp staging/kconfigwidgets/docs/DESIGN.COLOR staging/kconfigwidgets/src/CMakeLists.txt staging/kconfigwidgets/src/kcmodule.h staging/kconfigwidgets/src/kcmodule.cpp staging/kconfigwidgets/src/kcodecaction.h staging/kconfigwidgets/src/kcodecaction.cpp staging/kconfigwidgets/src/kcolorscheme.h staging/kconfigwidgets/src/kcolorscheme.cpp staging/kconfigwidgets/src/kconfigdialog.h staging/kconfigwidgets/src/kconfigdialog.cpp staging/kconfigwidgets/src/kconfigdialogmanager.h staging/kconfigwidgets/src/kconfigdialogmanager.cpp staging/kconfigwidgets/src/kconfigviewstatesaver.h staging/kconfigwidgets/src/kconfigviewstatesaver.cpp staging/kconfigwidgets/src/klanguagebutton.h staging/kconfigwidgets/src/klanguagebutton.cpp staging/kconfigwidgets/src/kpastetextaction.h staging/kconfigwidgets/src/kpastetextaction.cpp staging/kconfigwidgets/src/krecentfilesaction.h staging/kconfigwidgets/src/krecentfilesaction.cpp staging/kconfigwidgets/src/krecentfilesaction_p.h staging/kconfigwidgets/src/kstandardaction.h staging/kconfigwidgets/src/kstandardaction.cpp staging/kconfigwidgets/src/kstandardaction_p.h staging/kconfigwidgets/src/ktip-bulb.png staging/kconfigwidgets/src/ktip.h staging/kconfigwidgets/src/ktip.cpp staging/kconfigwidgets/src/kviewstatemaintainer.h staging/kconfigwidgets/src/preparetips staging/kconfigwidgets/tests/CMakeLists.txt staging/kconfigwidgets/tests/kcodecactiontest.h staging/kconfigwidgets/tests/kcodecactiontest.cpp staging/kconfigwidgets/tests/kcolorutilsdemo.h staging/kconfigwidgets/tests/kcolorutilsdemo.cpp staging/kconfigwidgets/tests/kcolorutilsdemo.ui staging/kconfigwidgets/tests/kimageframe.h staging/kconfigwidgets/tests/kimageframe.cpp staging/kconfigwidgets/tests/klanguagebuttontest.cpp superbuild/CMakeLists.txt fe99c2f tier3/CMakeLists.txt ec0b9b4 Diff: http://git.reviewboard.kde.org/r/113046/diff/ Testing --- Still builds, tests pass. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113046: Move kconfigwidgets to tier3
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113046/ --- (Updated Oct. 2, 2013, 1:19 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kdelibs Description --- Move kconfigwidgets to tier3 Diffs - staging/CMakeLists.txt f3d9d2f staging/kconfigwidgets/CMakeLists.txt staging/kconfigwidgets/KConfigWidgetsConfig.cmake.in staging/kconfigwidgets/autotests/CMakeLists.txt staging/kconfigwidgets/autotests/kconfigdialog_unittest.cpp staging/kconfigwidgets/autotests/kstandardactiontest.h staging/kconfigwidgets/autotests/kstandardactiontest.cpp staging/kconfigwidgets/docs/DESIGN.COLOR staging/kconfigwidgets/src/CMakeLists.txt staging/kconfigwidgets/src/kcmodule.h staging/kconfigwidgets/src/kcmodule.cpp staging/kconfigwidgets/src/kcodecaction.h staging/kconfigwidgets/src/kcodecaction.cpp staging/kconfigwidgets/src/kcolorscheme.h staging/kconfigwidgets/src/kcolorscheme.cpp staging/kconfigwidgets/src/kconfigdialog.h staging/kconfigwidgets/src/kconfigdialog.cpp staging/kconfigwidgets/src/kconfigdialogmanager.h staging/kconfigwidgets/src/kconfigdialogmanager.cpp staging/kconfigwidgets/src/kconfigviewstatesaver.h staging/kconfigwidgets/src/kconfigviewstatesaver.cpp staging/kconfigwidgets/src/klanguagebutton.h staging/kconfigwidgets/src/klanguagebutton.cpp staging/kconfigwidgets/src/kpastetextaction.h staging/kconfigwidgets/src/kpastetextaction.cpp staging/kconfigwidgets/src/krecentfilesaction.h staging/kconfigwidgets/src/krecentfilesaction.cpp staging/kconfigwidgets/src/krecentfilesaction_p.h staging/kconfigwidgets/src/kstandardaction.h staging/kconfigwidgets/src/kstandardaction.cpp staging/kconfigwidgets/src/kstandardaction_p.h staging/kconfigwidgets/src/ktip-bulb.png staging/kconfigwidgets/src/ktip.h staging/kconfigwidgets/src/ktip.cpp staging/kconfigwidgets/src/kviewstatemaintainer.h staging/kconfigwidgets/src/preparetips staging/kconfigwidgets/tests/CMakeLists.txt staging/kconfigwidgets/tests/kcodecactiontest.h staging/kconfigwidgets/tests/kcodecactiontest.cpp staging/kconfigwidgets/tests/kcolorutilsdemo.h staging/kconfigwidgets/tests/kcolorutilsdemo.cpp staging/kconfigwidgets/tests/kcolorutilsdemo.ui staging/kconfigwidgets/tests/kimageframe.h staging/kconfigwidgets/tests/kimageframe.cpp staging/kconfigwidgets/tests/klanguagebuttontest.cpp superbuild/CMakeLists.txt fe99c2f tier3/CMakeLists.txt ec0b9b4 Diff: http://git.reviewboard.kde.org/r/113046/diff/ Testing --- Still builds, tests pass. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113038: Move KDESu to staging + adopt standard dir scheme
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113038/#review41115 --- Ship it! kdesu/CMakeLists.txt http://git.reviewboard.kde.org/r/113038/#comment30170 we can probably port this to QProcess. - David Faure On Oct. 1, 2013, 8:31 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113038/ --- (Updated Oct. 1, 2013, 8:31 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Moves kdesu from toplevel dir to staging/ Diffs - CMakeLists.txt c71b1b3 kdesu/CMakeLists.txt e526643 kdesu/Mainpage.dox kdesu/README kdesu/client.h kdesu/client.cpp kdesu/config-kdesu.h.cmake kdesu/defaults.h kdesu/kcookie.h kdesu/kcookie.cpp kdesu/kdesu_stub.c kdesu/process.h kdesu/process.cpp kdesu/ssh.h kdesu/ssh.cpp kdesu/stub.h kdesu/stub.cpp kdesu/su.h kdesu/su.cpp staging/CMakeLists.txt f3d9d2f staging/kdesu/CMakeLists.txt PRE-CREATION staging/kdesu/KDESuConfig.cmake.in PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113038/diff/ Testing --- Builds. Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113049: Fix libAttica build
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113049/#review41117 --- Ship it! Does this make attica independent of ECM? Does it still need to find ECM? - Stephen Kelly On Oct. 2, 2013, 2:07 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113049/ --- (Updated Oct. 2, 2013, 2:07 p.m.) Review request for Attica and KDE Frameworks. Repository: attica Description --- There were 2 files recently removed from ECM which broke attica's build, this puts the removed files as local cmake modules. Diffs - CMakeLists.txt e0efb9b cmake/modules/ECMQt4To5Porting.cmake PRE-CREATION cmake/modules/FindQt5Transitional.cmake PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113049/diff/ Testing --- Builds again. Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113049: Fix libAttica build
On Oct. 2, 2013, 2:20 p.m., Stephen Kelly wrote: Does this make attica independent of ECM? Does it still need to find ECM? Actually yes. So I'll remove the find_package(ECM...) too and push. - Martin --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113049/#review41117 --- On Oct. 2, 2013, 2:07 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113049/ --- (Updated Oct. 2, 2013, 2:07 p.m.) Review request for Attica and KDE Frameworks. Repository: attica Description --- There were 2 files recently removed from ECM which broke attica's build, this puts the removed files as local cmake modules. Diffs - CMakeLists.txt e0efb9b cmake/modules/ECMQt4To5Porting.cmake PRE-CREATION cmake/modules/FindQt5Transitional.cmake PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113049/diff/ Testing --- Builds again. Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 113050: Use enum for KMessageBox return types
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113050/ --- Review request for KDE Frameworks. Repository: kdelibs Description --- Use enum for KMessageBox return types instead of int. Diffs - staging/kde4support/src/kdeui/kmessagebox_queued.cpp 00e9eb0 tier1/kwidgetsaddons/src/kmessagebox.h 4d1306b tier1/kwidgetsaddons/src/kmessagebox.cpp d974cd6 Diff: http://git.reviewboard.kde.org/r/113050/diff/ Testing --- Builds, tests pass. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113050: Use enum for KMessageBox return types
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113050/#review41120 --- I like the idea of being more specific about the return value, but isn't this going to break source compatibility? - Aleix Pol Gonzalez On Oct. 2, 2013, 2:43 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113050/ --- (Updated Oct. 2, 2013, 2:43 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Use enum for KMessageBox return types instead of int. Diffs - staging/kde4support/src/kdeui/kmessagebox_queued.cpp 00e9eb0 tier1/kwidgetsaddons/src/kmessagebox.h 4d1306b tier1/kwidgetsaddons/src/kmessagebox.cpp d974cd6 Diff: http://git.reviewboard.kde.org/r/113050/diff/ Testing --- Builds, tests pass. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113050: Use enum for KMessageBox return types
On Oct. 2, 2013, 4:47 p.m., Aleix Pol Gonzalez wrote: I like the idea of being more specific about the return value, but isn't this going to break source compatibility? No because it is OK to assign an enum to an int, so this code: int result = KMessageBox::warningContinueCancel(...) will still work. The only tricky part is KMessageBox::createKMessageBox(). See my email about it on kde-frameworks-devel. - Aurélien --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113050/#review41120 --- On Oct. 2, 2013, 4:43 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113050/ --- (Updated Oct. 2, 2013, 4:43 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Use enum for KMessageBox return types instead of int. Diffs - staging/kde4support/src/kdeui/kmessagebox_queued.cpp 00e9eb0 tier1/kwidgetsaddons/src/kmessagebox.h 4d1306b tier1/kwidgetsaddons/src/kmessagebox.cpp d974cd6 Diff: http://git.reviewboard.kde.org/r/113050/diff/ Testing --- Builds, tests pass. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113049: Fix libAttica build
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113049/ --- (Updated Oct. 2, 2013, 3:29 p.m.) Status -- This change has been marked as submitted. Review request for Attica and KDE Frameworks. Repository: attica Description --- There were 2 files recently removed from ECM which broke attica's build, this puts the removed files as local cmake modules. Diffs - CMakeLists.txt e0efb9b cmake/modules/ECMQt4To5Porting.cmake PRE-CREATION cmake/modules/FindQt5Transitional.cmake PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113049/diff/ Testing --- Builds again. Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113049: Fix libAttica build
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113049/#review41126 --- This review has been submitted with commit a84850ffea8d8dc9bb6503422aec953fff34da16 by Martin Klapetek to branch master. - Commit Hook On Oct. 2, 2013, 2:07 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113049/ --- (Updated Oct. 2, 2013, 2:07 p.m.) Review request for Attica and KDE Frameworks. Repository: attica Description --- There were 2 files recently removed from ECM which broke attica's build, this puts the removed files as local cmake modules. Diffs - CMakeLists.txt e0efb9b cmake/modules/ECMQt4To5Porting.cmake PRE-CREATION cmake/modules/FindQt5Transitional.cmake PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113049/diff/ Testing --- Builds again. Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113052: Remove find_package calls from root kdelibs
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113052/ --- (Updated Oct. 2, 2013, 3:54 p.m.) Review request for KDE Frameworks and Stephen Kelly. Repository: kdelibs Description --- As suggested by a kdelibs_cleanups task, move all find_package usages to its own module. Diffs - CMakeLists.txt a33ab62 dnssd/CMakeLists.txt 053b897 dnssd/src/CMakeLists.txt d392cbe experimental/CMakeLists.txt 30a2ff8 experimental/kdeclarative/CMakeLists.txt a4c8982 interfaces/CMakeLists.txt 8a3a2fc kded/CMakeLists.txt d373cdb kdesu/CMakeLists.txt a004c82 kdewidgets/CMakeLists.txt d8b8542 kfile/CMakeLists.txt b62973d khtml/CMakeLists.txt 4ce8fce kinit/CMakeLists.txt 4ae92f3 kio/CMakeLists.txt 18a9962 kioslave/CMakeLists.txt 3b957ae kioslave/http/CMakeLists.txt 97a5a4b kioslave/http/kcookiejar/tests/CMakeLists.txt e41731a kioslave/http/tests/CMakeLists.txt 590e2be kjsembed/CMakeLists.txt 15450b5 knewstuff/CMakeLists.txt 3fccbc6 knotify/CMakeLists.txt 8c3bf50 kpty/CMakeLists.txt 9a79827 kross/CMakeLists.txt 014f5c9 kross/modules/CMakeLists.txt d22a11c staging/CMakeLists.txt 0f608c7 staging/frameworkintegration/CMakeLists.txt 58776b0 staging/frameworkintegration/autotests/CMakeLists.txt c203019 staging/kbookmarks/autotests/CMakeLists.txt b1e031b staging/kde4attic/CMakeLists.txt 44cbc17 staging/kde4attic/src/CMakeLists.txt c7c4373 staging/kde4support/CMakeLists.txt 3f13677 staging/kde4support/src/CMakeLists.txt bab81e6 staging/kinterprocesswindowing/CMakeLists.txt PRE-CREATION staging/kinterprocesswindowing/src/CMakeLists.txt PRE-CREATION staging/kio/CMakeLists.txt f9afb6d staging/kio/src/widgets/CMakeLists.txt 35eae7e staging/kjobwidgets/CMakeLists.txt c1e769e staging/kjobwidgets/src/CMakeLists.txt 46d1a6e staging/kwallet/CMakeLists.txt 02c3d7b tier1/itemviews/CMakeLists.txt e13ea0e tier1/kconfig/CMakeLists.txt d6fe4f7 tier1/kidletime/CMakeLists.txt ed801f4 tier1/kidletime/src/CMakeLists.txt b005120 tier1/kjs/CMakeLists.txt 2385027 tier1/kwidgetsaddons/CMakeLists.txt 765d2f1 tier1/kwindowsystem/CMakeLists.txt dde412d tier1/kwindowsystem/src/CMakeLists.txt ea0f313 tier2/kauth/CMakeLists.txt 6fe7f68 tier2/kcrash/CMakeLists.txt 8879784 tier2/ki18n/CMakeLists.txt be337de tier2/knotifications/CMakeLists.txt 5e1b4cc tier2/knotifications/src/CMakeLists.txt 7c52664 tier3/kconfigwidgets/CMakeLists.txt a212a11 tier3/kprintutils/CMakeLists.txt dd8c403 tier3/kprintutils/src/CMakeLists.txt 5d797d1 tier3/ktextwidgets/CMakeLists.txt a8b4aa9 tier3/xmlgui/CMakeLists.txt a45d86d tier3/xmlgui/src/CMakeLists.txt 9677b0a Diff: http://git.reviewboard.kde.org/r/113052/diff/ Testing --- Everything keeps building Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113052: Remove find_package calls from root kdelibs
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113052/#review41128 --- Ship it! Ship It! - Stephen Kelly On Oct. 2, 2013, 3:54 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113052/ --- (Updated Oct. 2, 2013, 3:54 p.m.) Review request for KDE Frameworks and Stephen Kelly. Repository: kdelibs Description --- As suggested by a kdelibs_cleanups task, move all find_package usages to its own module. Diffs - CMakeLists.txt a33ab62 dnssd/CMakeLists.txt 053b897 dnssd/src/CMakeLists.txt d392cbe experimental/CMakeLists.txt 30a2ff8 experimental/kdeclarative/CMakeLists.txt a4c8982 interfaces/CMakeLists.txt 8a3a2fc kded/CMakeLists.txt d373cdb kdesu/CMakeLists.txt a004c82 kdewidgets/CMakeLists.txt d8b8542 kfile/CMakeLists.txt b62973d khtml/CMakeLists.txt 4ce8fce kinit/CMakeLists.txt 4ae92f3 kio/CMakeLists.txt 18a9962 kioslave/CMakeLists.txt 3b957ae kioslave/http/CMakeLists.txt 97a5a4b kioslave/http/kcookiejar/tests/CMakeLists.txt e41731a kioslave/http/tests/CMakeLists.txt 590e2be kjsembed/CMakeLists.txt 15450b5 knewstuff/CMakeLists.txt 3fccbc6 knotify/CMakeLists.txt 8c3bf50 kpty/CMakeLists.txt 9a79827 kross/CMakeLists.txt 014f5c9 kross/modules/CMakeLists.txt d22a11c staging/CMakeLists.txt 0f608c7 staging/frameworkintegration/CMakeLists.txt 58776b0 staging/frameworkintegration/autotests/CMakeLists.txt c203019 staging/kbookmarks/autotests/CMakeLists.txt b1e031b staging/kde4attic/CMakeLists.txt 44cbc17 staging/kde4attic/src/CMakeLists.txt c7c4373 staging/kde4support/CMakeLists.txt 3f13677 staging/kde4support/src/CMakeLists.txt bab81e6 staging/kinterprocesswindowing/CMakeLists.txt PRE-CREATION staging/kinterprocesswindowing/src/CMakeLists.txt PRE-CREATION staging/kio/CMakeLists.txt f9afb6d staging/kio/src/widgets/CMakeLists.txt 35eae7e staging/kjobwidgets/CMakeLists.txt c1e769e staging/kjobwidgets/src/CMakeLists.txt 46d1a6e staging/kwallet/CMakeLists.txt 02c3d7b tier1/itemviews/CMakeLists.txt e13ea0e tier1/kconfig/CMakeLists.txt d6fe4f7 tier1/kidletime/CMakeLists.txt ed801f4 tier1/kidletime/src/CMakeLists.txt b005120 tier1/kjs/CMakeLists.txt 2385027 tier1/kwidgetsaddons/CMakeLists.txt 765d2f1 tier1/kwindowsystem/CMakeLists.txt dde412d tier1/kwindowsystem/src/CMakeLists.txt ea0f313 tier2/kauth/CMakeLists.txt 6fe7f68 tier2/kcrash/CMakeLists.txt 8879784 tier2/ki18n/CMakeLists.txt be337de tier2/knotifications/CMakeLists.txt 5e1b4cc tier2/knotifications/src/CMakeLists.txt 7c52664 tier3/kconfigwidgets/CMakeLists.txt a212a11 tier3/kprintutils/CMakeLists.txt dd8c403 tier3/kprintutils/src/CMakeLists.txt 5d797d1 tier3/ktextwidgets/CMakeLists.txt a8b4aa9 tier3/xmlgui/CMakeLists.txt a45d86d tier3/xmlgui/src/CMakeLists.txt 9677b0a Diff: http://git.reviewboard.kde.org/r/113052/diff/ Testing --- Everything keeps building Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112942: Move KDNSSD to tier2
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112942/ --- (Updated Oct. 2, 2013, 4:05 p.m.) Review request for KDE Frameworks. Changes --- removed include of MacroBoolTo01. Repository: kdelibs Description --- Moves KDNSSD to tier2, fixes some missing dependencies. Diffs (updated) - CMakeLists.txt a33ab62 dnssd/CMakeLists.txt 053b897 dnssd/ConfigureChecks.cmake dnssd/KDNSSDConfig.cmake.in dnssd/Mainpage.dox dnssd/PACKAGERS dnssd/config-dnssd.h.cmake dnssd/src/CMakeLists.txt dnssd/src/avahi-domainbrowser.cpp dnssd/src/avahi-domainbrowser_p.h dnssd/src/avahi-publicservice.cpp dnssd/src/avahi-publicservice_p.h dnssd/src/avahi-remoteservice.cpp dnssd/src/avahi-remoteservice_p.h dnssd/src/avahi-servicebrowser.cpp dnssd/src/avahi-servicebrowser_p.h dnssd/src/avahi-servicetypebrowser.cpp dnssd/src/avahi-servicetypebrowser_p.h dnssd/src/avahi_entrygroup_interface.h dnssd/src/avahi_entrygroup_interface.cpp dnssd/src/avahi_server_interface.h dnssd/src/avahi_server_interface.cpp dnssd/src/avahi_serviceresolver_interface.h dnssd/src/avahi_serviceresolver_interface.cpp dnssd/src/domainbrowser.h dnssd/src/domainmodel.h dnssd/src/domainmodel.cpp dnssd/src/dummy-domainbrowser.cpp dnssd/src/dummy-publicservice.cpp dnssd/src/dummy-remoteservice.cpp dnssd/src/dummy-servicebrowser.cpp dnssd/src/dummy-servicetypebrowser.cpp dnssd/src/kcm_kdnssd.kcfg dnssd/src/mdnsd-domainbrowser.cpp dnssd/src/mdnsd-domainbrowser_p.h dnssd/src/mdnsd-publicservice.cpp dnssd/src/mdnsd-remoteservice.cpp dnssd/src/mdnsd-responder.h dnssd/src/mdnsd-responder.cpp dnssd/src/mdnsd-sdevent.h dnssd/src/mdnsd-servicebrowser.cpp dnssd/src/mdnsd-servicebrowser_p.h dnssd/src/mdnsd-servicetypebrowser.cpp dnssd/src/mdnsd-servicetypebrowser_p.h dnssd/src/org.freedesktop.Avahi.DomainBrowser.xml dnssd/src/org.freedesktop.Avahi.ServiceBrowser.xml dnssd/src/org.freedesktop.Avahi.ServiceTypeBrowser.xml dnssd/src/publicservice.h dnssd/src/remoteservice.h dnssd/src/servicebase.h dnssd/src/servicebase.cpp dnssd/src/servicebase_p.h dnssd/src/servicebrowser.h dnssd/src/servicemodel.h dnssd/src/servicemodel.cpp dnssd/src/servicetypebrowser.h dnssd/src/settings.kcfgc tier2/CMakeLists.txt 73175b3 Diff: http://git.reviewboard.kde.org/r/112942/diff/ Testing --- Builds, no tests Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113038: Move KDESu to staging + adopt standard dir scheme
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113038/#review41130 --- This review has been submitted with commit 75d32589a379415e9516e5038561d69095c187e6 by Martin Klapetek to branch frameworks. - Commit Hook On Oct. 1, 2013, 8:31 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113038/ --- (Updated Oct. 1, 2013, 8:31 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Moves kdesu from toplevel dir to staging/ Diffs - CMakeLists.txt c71b1b3 kdesu/CMakeLists.txt e526643 kdesu/Mainpage.dox kdesu/README kdesu/client.h kdesu/client.cpp kdesu/config-kdesu.h.cmake kdesu/defaults.h kdesu/kcookie.h kdesu/kcookie.cpp kdesu/kdesu_stub.c kdesu/process.h kdesu/process.cpp kdesu/ssh.h kdesu/ssh.cpp kdesu/stub.h kdesu/stub.cpp kdesu/su.h kdesu/su.cpp staging/CMakeLists.txt f3d9d2f staging/kdesu/CMakeLists.txt PRE-CREATION staging/kdesu/KDESuConfig.cmake.in PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113038/diff/ Testing --- Builds. Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113038: Move KDESu to staging + adopt standard dir scheme
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113038/ --- (Updated Oct. 2, 2013, 4:09 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kdelibs Description --- Moves kdesu from toplevel dir to staging/ Diffs - CMakeLists.txt c71b1b3 kdesu/CMakeLists.txt e526643 kdesu/Mainpage.dox kdesu/README kdesu/client.h kdesu/client.cpp kdesu/config-kdesu.h.cmake kdesu/defaults.h kdesu/kcookie.h kdesu/kcookie.cpp kdesu/kdesu_stub.c kdesu/process.h kdesu/process.cpp kdesu/ssh.h kdesu/ssh.cpp kdesu/stub.h kdesu/stub.cpp kdesu/su.h kdesu/su.cpp staging/CMakeLists.txt f3d9d2f staging/kdesu/CMakeLists.txt PRE-CREATION staging/kdesu/KDESuConfig.cmake.in PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113038/diff/ Testing --- Builds. Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113052: Remove find_package calls from root kdelibs
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113052/ --- (Updated Oct. 2, 2013, 5:07 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Stephen Kelly. Repository: kdelibs Description --- As suggested by a kdelibs_cleanups task, move all find_package usages to its own module. Diffs - CMakeLists.txt a33ab62 dnssd/CMakeLists.txt 053b897 dnssd/src/CMakeLists.txt d392cbe experimental/CMakeLists.txt 30a2ff8 experimental/kdeclarative/CMakeLists.txt a4c8982 interfaces/CMakeLists.txt 8a3a2fc kded/CMakeLists.txt d373cdb kdesu/CMakeLists.txt a004c82 kdewidgets/CMakeLists.txt d8b8542 kfile/CMakeLists.txt b62973d khtml/CMakeLists.txt 4ce8fce kinit/CMakeLists.txt 4ae92f3 kio/CMakeLists.txt 18a9962 kioslave/CMakeLists.txt 3b957ae kioslave/http/CMakeLists.txt 97a5a4b kioslave/http/kcookiejar/tests/CMakeLists.txt e41731a kioslave/http/tests/CMakeLists.txt 590e2be kjsembed/CMakeLists.txt 15450b5 knewstuff/CMakeLists.txt 3fccbc6 knotify/CMakeLists.txt 8c3bf50 kpty/CMakeLists.txt 9a79827 kross/CMakeLists.txt 014f5c9 kross/modules/CMakeLists.txt d22a11c staging/CMakeLists.txt 0f608c7 staging/frameworkintegration/CMakeLists.txt 58776b0 staging/frameworkintegration/autotests/CMakeLists.txt c203019 staging/kbookmarks/autotests/CMakeLists.txt b1e031b staging/kde4attic/CMakeLists.txt 44cbc17 staging/kde4attic/src/CMakeLists.txt c7c4373 staging/kde4support/CMakeLists.txt 3f13677 staging/kde4support/src/CMakeLists.txt bab81e6 staging/kinterprocesswindowing/CMakeLists.txt PRE-CREATION staging/kinterprocesswindowing/src/CMakeLists.txt PRE-CREATION staging/kio/CMakeLists.txt f9afb6d staging/kio/src/widgets/CMakeLists.txt 35eae7e staging/kjobwidgets/CMakeLists.txt c1e769e staging/kjobwidgets/src/CMakeLists.txt 46d1a6e staging/kwallet/CMakeLists.txt 02c3d7b tier1/itemviews/CMakeLists.txt e13ea0e tier1/kconfig/CMakeLists.txt d6fe4f7 tier1/kidletime/CMakeLists.txt ed801f4 tier1/kidletime/src/CMakeLists.txt b005120 tier1/kjs/CMakeLists.txt 2385027 tier1/kwidgetsaddons/CMakeLists.txt 765d2f1 tier1/kwindowsystem/CMakeLists.txt dde412d tier1/kwindowsystem/src/CMakeLists.txt ea0f313 tier2/kauth/CMakeLists.txt 6fe7f68 tier2/kcrash/CMakeLists.txt 8879784 tier2/ki18n/CMakeLists.txt be337de tier2/knotifications/CMakeLists.txt 5e1b4cc tier2/knotifications/src/CMakeLists.txt 7c52664 tier3/kconfigwidgets/CMakeLists.txt a212a11 tier3/kprintutils/CMakeLists.txt dd8c403 tier3/kprintutils/src/CMakeLists.txt 5d797d1 tier3/ktextwidgets/CMakeLists.txt a8b4aa9 tier3/xmlgui/CMakeLists.txt a45d86d tier3/xmlgui/src/CMakeLists.txt 9677b0a Diff: http://git.reviewboard.kde.org/r/113052/diff/ Testing --- Everything keeps building Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113052: Remove find_package calls from root kdelibs
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113052/#review41131 --- This review has been submitted with commit ca62212ab2a68e716167f08f2433fe735dcba302 by Aleix Pol to branch frameworks. - Commit Hook On Oct. 2, 2013, 3:54 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113052/ --- (Updated Oct. 2, 2013, 3:54 p.m.) Review request for KDE Frameworks and Stephen Kelly. Repository: kdelibs Description --- As suggested by a kdelibs_cleanups task, move all find_package usages to its own module. Diffs - CMakeLists.txt a33ab62 dnssd/CMakeLists.txt 053b897 dnssd/src/CMakeLists.txt d392cbe experimental/CMakeLists.txt 30a2ff8 experimental/kdeclarative/CMakeLists.txt a4c8982 interfaces/CMakeLists.txt 8a3a2fc kded/CMakeLists.txt d373cdb kdesu/CMakeLists.txt a004c82 kdewidgets/CMakeLists.txt d8b8542 kfile/CMakeLists.txt b62973d khtml/CMakeLists.txt 4ce8fce kinit/CMakeLists.txt 4ae92f3 kio/CMakeLists.txt 18a9962 kioslave/CMakeLists.txt 3b957ae kioslave/http/CMakeLists.txt 97a5a4b kioslave/http/kcookiejar/tests/CMakeLists.txt e41731a kioslave/http/tests/CMakeLists.txt 590e2be kjsembed/CMakeLists.txt 15450b5 knewstuff/CMakeLists.txt 3fccbc6 knotify/CMakeLists.txt 8c3bf50 kpty/CMakeLists.txt 9a79827 kross/CMakeLists.txt 014f5c9 kross/modules/CMakeLists.txt d22a11c staging/CMakeLists.txt 0f608c7 staging/frameworkintegration/CMakeLists.txt 58776b0 staging/frameworkintegration/autotests/CMakeLists.txt c203019 staging/kbookmarks/autotests/CMakeLists.txt b1e031b staging/kde4attic/CMakeLists.txt 44cbc17 staging/kde4attic/src/CMakeLists.txt c7c4373 staging/kde4support/CMakeLists.txt 3f13677 staging/kde4support/src/CMakeLists.txt bab81e6 staging/kinterprocesswindowing/CMakeLists.txt PRE-CREATION staging/kinterprocesswindowing/src/CMakeLists.txt PRE-CREATION staging/kio/CMakeLists.txt f9afb6d staging/kio/src/widgets/CMakeLists.txt 35eae7e staging/kjobwidgets/CMakeLists.txt c1e769e staging/kjobwidgets/src/CMakeLists.txt 46d1a6e staging/kwallet/CMakeLists.txt 02c3d7b tier1/itemviews/CMakeLists.txt e13ea0e tier1/kconfig/CMakeLists.txt d6fe4f7 tier1/kidletime/CMakeLists.txt ed801f4 tier1/kidletime/src/CMakeLists.txt b005120 tier1/kjs/CMakeLists.txt 2385027 tier1/kwidgetsaddons/CMakeLists.txt 765d2f1 tier1/kwindowsystem/CMakeLists.txt dde412d tier1/kwindowsystem/src/CMakeLists.txt ea0f313 tier2/kauth/CMakeLists.txt 6fe7f68 tier2/kcrash/CMakeLists.txt 8879784 tier2/ki18n/CMakeLists.txt be337de tier2/knotifications/CMakeLists.txt 5e1b4cc tier2/knotifications/src/CMakeLists.txt 7c52664 tier3/kconfigwidgets/CMakeLists.txt a212a11 tier3/kprintutils/CMakeLists.txt dd8c403 tier3/kprintutils/src/CMakeLists.txt 5d797d1 tier3/ktextwidgets/CMakeLists.txt a8b4aa9 tier3/xmlgui/CMakeLists.txt a45d86d tier3/xmlgui/src/CMakeLists.txt 9677b0a Diff: http://git.reviewboard.kde.org/r/113052/diff/ Testing --- Everything keeps building Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112828: Add a new functions to add unit tests
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112828/ --- (Updated Oct. 2, 2013, 7:14 p.m.) Review request for Extra Cmake Modules and KDE Frameworks. Changes --- renamed functions Summary (updated) - Add a new functions to add unit tests Repository: extra-cmake-modules Description --- Add a new functions to add unit tests Every framework in KF5 has a macro similar to these, this reduces the unnecessary duplication inside all of the frameworks Diffs (updated) - modules/ECMAddTests.cmake PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112828/diff/ Testing --- Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: kdelibs_frameworks_qt5 #1318
See http://build.kde.org/job/kdelibs_frameworks_qt5/1318/changes Changes: [aleixpol] Remove weird cmake indirections -- [...truncated 614 lines...] -- Looking for include files sys/types.h, netinet/in.h - found -- Looking for res_init in resolv -- Looking for res_init in resolv - not found -- Looking for __res_init in resolv -- Looking for __res_init in resolv - found -- Looking for gethostbyname in nsl -- Looking for gethostbyname in nsl - found -- Looking for connect in socket -- Looking for connect in socket - not found -- KF5[InstallDirs]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDEInstallDirs.cmake -- KF5[CMake]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECMakeSettings.cmake -- KF5[Compiler]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECompilerSettings.cmake -- KF5[InstallDirs]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDEInstallDirs.cmake -- KF5[CMake]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECMakeSettings.cmake -- KF5[Compiler]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECompilerSettings.cmake -- KF5[InstallDirs]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDEInstallDirs.cmake -- KF5[CMake]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECMakeSettings.cmake -- KF5[Compiler]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECompilerSettings.cmake CMake Error at kioslave/file/ConfigureChecks.cmake:5 (include): include could not find load file: CheckStructMember Call Stack (most recent call first): kioslave/file/CMakeLists.txt:4 (include) -- Looking for posix_fadvise -- Looking for posix_fadvise - found CMake Warning at kioslave/file/CMakeLists.txt:16 (find_package): By not providing FindACL.cmake in CMAKE_MODULE_PATH this project has asked CMake to find a package configuration file provided by ACL, but CMake did not find one. Could not find a package configuration file provided by ACL with any of the following names: ACLConfig.cmake acl-config.cmake Add the installation prefix of ACL to CMAKE_PREFIX_PATH or set ACL_DIR to a directory containing one of the above files. If ACL provides a separate development package or SDK, be sure it has been installed. -- Looking for strtoll -- Looking for strtoll - not found CMake Warning at kioslave/http/CMakeLists.txt:7 (find_package): By not providing FindGSSAPI.cmake in CMAKE_MODULE_PATH this project has asked CMake to find a package configuration file provided by GSSAPI, but CMake did not find one. Could not find a package configuration file provided by GSSAPI with any of the following names: GSSAPIConfig.cmake gssapi-config.cmake Add the installation prefix of GSSAPI to CMAKE_PREFIX_PATH or set GSSAPI_DIR to a directory containing one of the above files. If GSSAPI provides a separate development package or SDK, be sure it has been installed. -- Looking for include file sys/time.h -- Looking for include file sys/time.h - found -- KF5[InstallDirs]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDEInstallDirs.cmake -- KF5[CMake]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECMakeSettings.cmake -- KF5[Compiler]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECompilerSettings.cmake -- Looking for include file malloc.h -- Looking for include file malloc.h - found -- Looking for include file alloca.h -- Looking for include file alloca.h - found -- Looking for getpagesize -- Looking for getpagesize - found -- Performing Test GIF_GifFileType_UserData -- Performing Test GIF_GifFileType_UserData - Success -- Found GIF: /usr/lib64/libgif.so (found version 4) -- PNG r: png;libpng;png17;libpng17;png16;libpng16;png15;libpng15;png14;libpng14;png12;libpng12 d: png17d;libpng17d;png16d;libpng16d;png15d;libpng15d;png14d;libpng14d;png12d;libpng12d -- Found PNG: /usr/lib64/libpng.so (found version 1.5.13) -- KF5[InstallDirs]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDEInstallDirs.cmake -- KF5[CMake]: Loaded settings
Re: Review Request 112901: Remove weird cmake indirections
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112901/
---
(Updated Oct. 2, 2013, 5:17 p.m.)
Status
--
This change has been marked as submitted.
Review request for Build System and KDE Frameworks.
Repository: kdelibs
Description
---
There were some un-reviewed cmake files where libraries would be defined with a
${LIBRARY_TYPE}. It seems to be something coming from the KDE4 times that
didn't follow through.
I propose to remove all the uses for the moment, it's not ever being set anyway.
Diffs
-
interfaces/kimproxy/library/CMakeLists.txt 36e55ef
interfaces/kmediaplayer/CMakeLists.txt 3d1797d
kdesu/CMakeLists.txt e526643
kdewebkit/CMakeLists.txt cdc5835
kfile/CMakeLists.txt e05137d
khtml/CMakeLists.txt 4e1bb80
kio/CMakeLists.txt 25dc6d9
kio/misc/kntlm/CMakeLists.txt fe70a8d
kjsembed/kjsembed/CMakeLists.txt 8ed55c1
knewstuff/src/CMakeLists.txt c313981
knotify/config/CMakeLists.txt 69e1c11
kparts/CMakeLists.txt 6ab9391
kpty/CMakeLists.txt 9a79827
kross/core/CMakeLists.txt 52cd3d4
kross/qts/CMakeLists.txt 1a30bd1
kross/ui/CMakeLists.txt 9e7806d
kutils/CMakeLists.txt 0cb281d
staging/kemoticons/src/core/CMakeLists.txt f7fb463
staging/ktextwidgets/src/CMakeLists.txt 4787c10
Diff: http://git.reviewboard.kde.org/r/112901/diff/
Testing
---
Everything still builds
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112901: Remove weird cmake indirections
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112901/#review41133
---
This review has been submitted with commit
fcd2f0fa8f8e5c3228c0d58b6369cee7eca446b6 by Aleix Pol to branch frameworks.
- Commit Hook
On Sept. 24, 2013, 1:32 p.m., Aleix Pol Gonzalez wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112901/
---
(Updated Sept. 24, 2013, 1:32 p.m.)
Review request for Build System and KDE Frameworks.
Repository: kdelibs
Description
---
There were some un-reviewed cmake files where libraries would be defined with
a ${LIBRARY_TYPE}. It seems to be something coming from the KDE4 times that
didn't follow through.
I propose to remove all the uses for the moment, it's not ever being set
anyway.
Diffs
-
interfaces/kimproxy/library/CMakeLists.txt 36e55ef
interfaces/kmediaplayer/CMakeLists.txt 3d1797d
kdesu/CMakeLists.txt e526643
kdewebkit/CMakeLists.txt cdc5835
kfile/CMakeLists.txt e05137d
khtml/CMakeLists.txt 4e1bb80
kio/CMakeLists.txt 25dc6d9
kio/misc/kntlm/CMakeLists.txt fe70a8d
kjsembed/kjsembed/CMakeLists.txt 8ed55c1
knewstuff/src/CMakeLists.txt c313981
knotify/config/CMakeLists.txt 69e1c11
kparts/CMakeLists.txt 6ab9391
kpty/CMakeLists.txt 9a79827
kross/core/CMakeLists.txt 52cd3d4
kross/qts/CMakeLists.txt 1a30bd1
kross/ui/CMakeLists.txt 9e7806d
kutils/CMakeLists.txt 0cb281d
staging/kemoticons/src/core/CMakeLists.txt f7fb463
staging/ktextwidgets/src/CMakeLists.txt 4787c10
Diff: http://git.reviewboard.kde.org/r/112901/diff/
Testing
---
Everything still builds
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: kdelibs_frameworks_qt5 #1319
See http://build.kde.org/job/kdelibs_frameworks_qt5/1319/changes Changes: [aleixpol] Fix build [aleixpol] Should have gone in -- [...truncated 541 lines...] -- Looking for include file arpa/nameser8_compat.h - not found -- Looking for include files sys/types.h, netinet/in.h -- Looking for include files sys/types.h, netinet/in.h - found -- Looking for res_init in resolv -- Looking for res_init in resolv - not found -- Looking for __res_init in resolv -- Looking for __res_init in resolv - found -- Looking for gethostbyname in nsl -- Looking for gethostbyname in nsl - found -- Looking for connect in socket -- Looking for connect in socket - not found -- KF5[InstallDirs]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDEInstallDirs.cmake -- KF5[CMake]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECMakeSettings.cmake -- KF5[Compiler]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECompilerSettings.cmake -- KF5[InstallDirs]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDEInstallDirs.cmake -- KF5[CMake]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECMakeSettings.cmake -- KF5[Compiler]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECompilerSettings.cmake -- KF5[InstallDirs]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDEInstallDirs.cmake -- KF5[CMake]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECMakeSettings.cmake -- KF5[Compiler]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECompilerSettings.cmake CMake Error at kioslave/file/ConfigureChecks.cmake:5 (include): include could not find load file: CheckStructMember Call Stack (most recent call first): kioslave/file/CMakeLists.txt:4 (include) -- Looking for posix_fadvise -- Looking for posix_fadvise - found CMake Warning at kioslave/file/CMakeLists.txt:16 (find_package): By not providing FindACL.cmake in CMAKE_MODULE_PATH this project has asked CMake to find a package configuration file provided by ACL, but CMake did not find one. Could not find a package configuration file provided by ACL with any of the following names: ACLConfig.cmake acl-config.cmake Add the installation prefix of ACL to CMAKE_PREFIX_PATH or set ACL_DIR to a directory containing one of the above files. If ACL provides a separate development package or SDK, be sure it has been installed. -- Looking for strtoll -- Looking for strtoll - not found CMake Warning at kioslave/http/CMakeLists.txt:7 (find_package): By not providing FindGSSAPI.cmake in CMAKE_MODULE_PATH this project has asked CMake to find a package configuration file provided by GSSAPI, but CMake did not find one. Could not find a package configuration file provided by GSSAPI with any of the following names: GSSAPIConfig.cmake gssapi-config.cmake Add the installation prefix of GSSAPI to CMAKE_PREFIX_PATH or set GSSAPI_DIR to a directory containing one of the above files. If GSSAPI provides a separate development package or SDK, be sure it has been installed. -- Looking for include file sys/time.h -- Looking for include file sys/time.h - found -- KF5[InstallDirs]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDEInstallDirs.cmake -- KF5[CMake]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECMakeSettings.cmake -- KF5[Compiler]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECompilerSettings.cmake -- Looking for include file malloc.h -- Looking for include file malloc.h - found -- Looking for include file alloca.h -- Looking for include file alloca.h - found -- Looking for getpagesize -- Looking for getpagesize - found -- Performing Test GIF_GifFileType_UserData -- Performing Test GIF_GifFileType_UserData - Success -- Found GIF: /usr/lib64/libgif.so (found version 4) -- PNG r: png;libpng;png17;libpng17;png16;libpng16;png15;libpng15;png14;libpng14;png12;libpng12 d: png17d;libpng17d;png16d;libpng16d;png15d;libpng15d;png14d;libpng14d;png12d;libpng12d -- Found PNG: /usr/lib64/libpng.so (found version 1.5.13) -- KF5[InstallDirs]: Loaded settings from
Build failed in Jenkins: kdelibs_frameworks_qt5 #1320
See http://build.kde.org/job/kdelibs_frameworks_qt5/1320/changes Changes: [aleixpol] kioslaves also uses finders from cmake/modules -- [...truncated 522 lines...] CMake Warning at kio/CMakeLists.txt:40 (find_package): By not providing FindACL.cmake in CMAKE_MODULE_PATH this project has asked CMake to find a package configuration file provided by ACL, but CMake did not find one. Could not find a package configuration file provided by ACL with any of the following names: ACLConfig.cmake acl-config.cmake Add the installation prefix of ACL to CMAKE_PREFIX_PATH or set ACL_DIR to a directory containing one of the above files. If ACL provides a separate development package or SDK, be sure it has been installed. -- Looking for include file arpa/nameser_compat.h -- Looking for include file arpa/nameser_compat.h - not found -- Looking for include file arpa/nameser8_compat.h -- Looking for include file arpa/nameser8_compat.h - not found -- Looking for include files sys/types.h, netinet/in.h -- Looking for include files sys/types.h, netinet/in.h - found -- Looking for res_init in resolv -- Looking for res_init in resolv - not found -- Looking for __res_init in resolv -- Looking for __res_init in resolv - found -- Looking for gethostbyname in nsl -- Looking for gethostbyname in nsl - found -- Looking for connect in socket -- Looking for connect in socket - not found -- KF5[InstallDirs]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDEInstallDirs.cmake -- KF5[CMake]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECMakeSettings.cmake -- KF5[Compiler]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECompilerSettings.cmake -- KF5[InstallDirs]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDEInstallDirs.cmake -- KF5[CMake]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECMakeSettings.cmake -- KF5[Compiler]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECompilerSettings.cmake -- KF5[InstallDirs]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDEInstallDirs.cmake -- KF5[CMake]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECMakeSettings.cmake -- KF5[Compiler]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECompilerSettings.cmake -- Looking for posix_fadvise -- Looking for posix_fadvise - found -- Found ACL support: /usr/lib64/libacl.so;/usr/lib64/libattr.so -- Looking for strtoll -- Looking for strtoll - not found -- Found GSSAPI: -lgssapi_krb5 -lkrb5 -lk5crypto -lcom_err -- Looking for include file sys/time.h -- Looking for include file sys/time.h - found -- KF5[InstallDirs]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDEInstallDirs.cmake -- KF5[CMake]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECMakeSettings.cmake -- KF5[Compiler]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECompilerSettings.cmake -- Looking for include file malloc.h -- Looking for include file malloc.h - found -- Looking for include file alloca.h -- Looking for include file alloca.h - found -- Looking for getpagesize -- Looking for getpagesize - found -- Performing Test GIF_GifFileType_UserData -- Performing Test GIF_GifFileType_UserData - Success -- Found GIF: /usr/lib64/libgif.so (found version 4) -- PNG r: png;libpng;png17;libpng17;png16;libpng16;png15;libpng15;png14;libpng14;png12;libpng12 d: png17d;libpng17d;png16d;libpng16d;png15d;libpng15d;png14d;libpng14d;png12d;libpng12d -- Found PNG: /usr/lib64/libpng.so (found version 1.5.13) -- KF5[InstallDirs]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDEInstallDirs.cmake -- KF5[CMake]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECMakeSettings.cmake -- KF5[Compiler]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECompilerSettings.cmake -- KF5[InstallDirs]: Loaded settings from
Switch build.kde.org to Qt stable branch
As you may know, Qt is working to release 5.2. The dev branch has been merged to the stable branch, which means the stable branch is now 5.2, and dev is now 5.3. build.kde.org is compiling Qt from source, but it's using the dev branch. As far as I know, the plan is to release KF5 depending on Qt 5.2. I propose switching build.kde.org to the 'stable' Qt branch to ensure we don't accidentally depend on 5.3 features. -- Nicolás ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Switch build.kde.org to Qt stable branch
On Wed, Oct 2, 2013 at 7:53 PM, Nicolás Alvarez nicolas.alva...@gmail.comwrote: As you may know, Qt is working to release 5.2. The dev branch has been merged to the stable branch, which means the stable branch is now 5.2, and dev is now 5.3. build.kde.org is compiling Qt from source, but it's using the dev branch. As far as I know, the plan is to release KF5 depending on Qt 5.2. I propose switching build.kde.org to the 'stable' Qt branch to ensure we don't accidentally depend on 5.3 features. -- Nicolás ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel Sounds like a good idea to me! +1 Aleix ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113039: Remove unused includes from KDESu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113039/#review41141 --- Ship it! Woa amazing :) +1 - Aleix Pol Gonzalez On Oct. 1, 2013, 9:12 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113039/ --- (Updated Oct. 1, 2013, 9:12 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- There are a whole lot of unused includes in KDESu, this removes them all. Diffs - staging/kdesu/src/client.h 6f425a0 staging/kdesu/src/client.cpp 8a3230a staging/kdesu/src/kcookie.cpp 22a119b staging/kdesu/src/process.cpp 9b27ad6 staging/kdesu/src/ssh.cpp d4f76fe staging/kdesu/src/stub.cpp a9af802 staging/kdesu/src/su.h 8681f2c staging/kdesu/src/su.cpp 8cd5b25 Diff: http://git.reviewboard.kde.org/r/113039/diff/ Testing --- Builds. Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113008: Clean up KWallet before moving to its own tier
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113008/#review41142 --- Ship it! Ship It! - Valentin Rusu On Oct. 2, 2013, 12:53 a.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113008/ --- (Updated Oct. 2, 2013, 12:53 a.m.) Review request for KDE Frameworks and Valentin Rusu. Repository: kdelibs Description --- Makes a bit of sense of the cmake, adds a TODO. Diffs - staging/kwallet/src/CMakeLists.txt 0aaa39e staging/kwallet/src/kwallet_mac.cpp d5d522b Diff: http://git.reviewboard.kde.org/r/113008/diff/ Testing --- Builds, tests pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113008: Clean up KWallet before moving to its own tier
On Oct. 2, 2013, 6:51 p.m., Valentin Rusu wrote: Ship It! Thanks for doing this! - Valentin --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113008/#review41142 --- On Oct. 2, 2013, 12:53 a.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113008/ --- (Updated Oct. 2, 2013, 12:53 a.m.) Review request for KDE Frameworks and Valentin Rusu. Repository: kdelibs Description --- Makes a bit of sense of the cmake, adds a TODO. Diffs - staging/kwallet/src/CMakeLists.txt 0aaa39e staging/kwallet/src/kwallet_mac.cpp d5d522b Diff: http://git.reviewboard.kde.org/r/113008/diff/ Testing --- Builds, tests pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112923: Make leftMargin rightMargin virtual methods in KCategoryDrawer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112923/ --- (Updated Oct. 2, 2013, 7:12 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kdelibs Description --- Make leftMargin rightMargin virtual methods in KCategoryDrawer Currently KCategoryDrawer operates on a setter/getter for margins but setting the height and painting is all set by overriding methods This makes everything consistent. -- This was marked as a KDE5 TODO Diffs - KDE5PORTING.html 57ecf2e tier1/itemviews/src/kcategorydrawer.h 3665457 tier1/itemviews/src/kcategorydrawer.cpp 0fb857e Diff: http://git.reviewboard.kde.org/r/112923/diff/ Testing --- Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112923: Make leftMargin rightMargin virtual methods in KCategoryDrawer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112923/#review41145 --- This review has been submitted with commit d58a96548bf5af0352969f92ef8cd31b1f28a0e4 by David Edmundson to branch frameworks. - Commit Hook On Sept. 24, 2013, 11:46 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112923/ --- (Updated Sept. 24, 2013, 11:46 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Make leftMargin rightMargin virtual methods in KCategoryDrawer Currently KCategoryDrawer operates on a setter/getter for margins but setting the height and painting is all set by overriding methods This makes everything consistent. -- This was marked as a KDE5 TODO Diffs - KDE5PORTING.html 57ecf2e tier1/itemviews/src/kcategorydrawer.h 3665457 tier1/itemviews/src/kcategorydrawer.cpp 0fb857e Diff: http://git.reviewboard.kde.org/r/112923/diff/ Testing --- Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: kdelibs_frameworks_qt5 #1322
See http://build.kde.org/job/kdelibs_frameworks_qt5/1322/changes Changes: [kde] Make leftMargin rightMargin virtual methods in KCategoryDrawer [kde] Set correct target for KEmoticons export -- [...truncated 510 lines...] -- Looking for openpty in util -- Looking for openpty in util - found -- Looking for ptsname -- Looking for ptsname - found -- KF5[InstallDirs]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDEInstallDirs.cmake -- KF5[CMake]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECMakeSettings.cmake -- KF5[Compiler]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECompilerSettings.cmake -- KF5[InstallDirs]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDEInstallDirs.cmake -- KF5[CMake]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECMakeSettings.cmake -- KF5[Compiler]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECompilerSettings.cmake -- Found KF5: /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/find-modules/FindKF5.cmake (found suitable version 5.0.0, minimum required is 5.0) found components: CMake Compiler InstallDirs -- Found Avahi: /usr/include -- KF5[InstallDirs]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDEInstallDirs.cmake -- KF5[CMake]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECMakeSettings.cmake -- KF5[Compiler]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECompilerSettings.cmake -- Found KF5: /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/find-modules/FindKF5.cmake (found suitable version 5.0.0, minimum required is 5.0.0) found components: CMake Compiler InstallDirs -- Found ACL support: /usr/lib64/libacl.so;/usr/lib64/libattr.so -- Looking for include file arpa/nameser_compat.h -- Looking for include file arpa/nameser_compat.h - not found -- Looking for include file arpa/nameser8_compat.h -- Looking for include file arpa/nameser8_compat.h - not found -- Looking for include files sys/types.h, netinet/in.h -- Looking for include files sys/types.h, netinet/in.h - found -- Looking for res_init in resolv -- Looking for res_init in resolv - not found -- Looking for __res_init in resolv -- Looking for __res_init in resolv - found -- Looking for gethostbyname in nsl -- Looking for gethostbyname in nsl - found -- Looking for connect in socket -- Looking for connect in socket - not found -- KF5[InstallDirs]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDEInstallDirs.cmake -- KF5[CMake]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECMakeSettings.cmake -- KF5[Compiler]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECompilerSettings.cmake -- KF5[InstallDirs]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDEInstallDirs.cmake -- KF5[CMake]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECMakeSettings.cmake -- KF5[Compiler]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECompilerSettings.cmake -- KF5[InstallDirs]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDEInstallDirs.cmake -- KF5[CMake]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECMakeSettings.cmake -- KF5[Compiler]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECompilerSettings.cmake -- Looking for posix_fadvise -- Looking for posix_fadvise - found -- Found ACL support: /usr/lib64/libacl.so;/usr/lib64/libattr.so -- Looking for strtoll -- Looking for strtoll - not found -- Found GSSAPI: -lgssapi_krb5 -lkrb5 -lk5crypto -lcom_err -- Looking for include file sys/time.h -- Looking for include file sys/time.h - found -- KF5[InstallDirs]: Loaded settings from
Review Request 113067: Fix compilation
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113067/
---
Review request for KDE Frameworks.
Repository: kdelibs
Description
---
Partially revert ca62212ab2a68e716167f08f2433fe735dcba302
By removing find_package(KF5 InstallDirs) ${LIB_INSTALL_DIR} does
not expand causing kdelibsLibraryTargets to be installed to try
and install to the root directory /cmake/ which causes compile errors.
We cannot remove kdelibsLibraryTargets until each library can install itself
see http://build.kde.org/job/kdelibs_frameworks_qt5/1317/console
Diffs
-
CMakeLists.txt cdc3120
Diff: http://git.reviewboard.kde.org/r/113067/diff/
Testing
---
Thanks,
David Edmundson
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113067: Fix compilation
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113067/#review41148
---
Ship it!
This is the simplest solution to get it back building. Go for it.
- Nicolás Alvarez
On Oct. 2, 2013, 9:12 p.m., David Edmundson wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113067/
---
(Updated Oct. 2, 2013, 9:12 p.m.)
Review request for KDE Frameworks.
Repository: kdelibs
Description
---
Partially revert ca62212ab2a68e716167f08f2433fe735dcba302
By removing find_package(KF5 InstallDirs) ${LIB_INSTALL_DIR} does
not expand causing kdelibsLibraryTargets to be installed to try
and install to the root directory /cmake/ which causes compile errors.
We cannot remove kdelibsLibraryTargets until each library can install itself
see http://build.kde.org/job/kdelibs_frameworks_qt5/1317/console
Diffs
-
CMakeLists.txt cdc3120
Diff: http://git.reviewboard.kde.org/r/113067/diff/
Testing
---
Thanks,
David Edmundson
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112985: Adjust API in KEmoticons framework: map and index methods
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112985/ --- (Updated Oct. 2, 2013, 9:33 p.m.) Review request for KDE Frameworks. Changes --- Add KEMOTICONS_DEPRECATED. Explain better what is this patch for. Repository: kdelibs Description (updated) --- Adjust API in KEmoticons framework: map and index methods -Make map and index KEmoticons API slightly clearer and deprecate the methods that are confusing. -Use the new methods in the plugins. Diffs (updated) - staging/kemoticons/src/core/kemoticonsprovider.h 85fc7efb8923d76476f0a16f70f8ebb15e451081 staging/kemoticons/src/core/kemoticonsprovider.cpp d04c76e87b118f5d45717b3b2ccd9dea47dc2526 staging/kemoticons/src/providers/adium/adium_emoticons.cpp a3aaa0fdc0b3dcc862f98865d2e6419e716f4f17 staging/kemoticons/src/providers/kde/kde_emoticons.cpp 5b5114a14dd94a6ebcba8a6f7dd163f73048189a staging/kemoticons/src/providers/pidgin/pidgin_emoticons.cpp e9f89eecce3d6e6407113a84cb5200ff66564c19 staging/kemoticons/src/providers/xmpp/xmpp_emoticons.cpp 0dc92ed092d87a559fe7fa1a40e804843ab73d59 Diff: http://git.reviewboard.kde.org/r/112985/diff/ Testing --- It builds. It installs. Tests pass. Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: kdelibs_frameworks_qt5 #1323
See http://build.kde.org/job/kdelibs_frameworks_qt5/1323/changes Changes: [aleixpol] Fix build -- [...truncated 511 lines...] -- KF5[InstallDirs]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDEInstallDirs.cmake -- KF5[CMake]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECMakeSettings.cmake -- KF5[Compiler]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECompilerSettings.cmake -- KF5[InstallDirs]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDEInstallDirs.cmake -- KF5[CMake]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECMakeSettings.cmake -- KF5[Compiler]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECompilerSettings.cmake -- Found KF5: /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/find-modules/FindKF5.cmake (found suitable version 5.0.0, minimum required is 5.0) found components: CMake Compiler InstallDirs -- Found Avahi: /usr/include -- KF5[InstallDirs]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDEInstallDirs.cmake -- KF5[CMake]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECMakeSettings.cmake -- KF5[Compiler]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECompilerSettings.cmake -- Found KF5: /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/find-modules/FindKF5.cmake (found suitable version 5.0.0, minimum required is 5.0.0) found components: CMake Compiler InstallDirs -- Found ACL support: /usr/lib64/libacl.so;/usr/lib64/libattr.so -- Looking for include file arpa/nameser_compat.h -- Looking for include file arpa/nameser_compat.h - not found -- Looking for include file arpa/nameser8_compat.h -- Looking for include file arpa/nameser8_compat.h - not found -- Looking for include files sys/types.h, netinet/in.h -- Looking for include files sys/types.h, netinet/in.h - found -- Looking for res_init in resolv -- Looking for res_init in resolv - not found -- Looking for __res_init in resolv -- Looking for __res_init in resolv - found -- Looking for gethostbyname in nsl -- Looking for gethostbyname in nsl - found -- Looking for connect in socket -- Looking for connect in socket - not found -- KF5[InstallDirs]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDEInstallDirs.cmake -- KF5[CMake]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECMakeSettings.cmake -- KF5[Compiler]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECompilerSettings.cmake -- KF5[InstallDirs]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDEInstallDirs.cmake -- KF5[CMake]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECMakeSettings.cmake -- KF5[Compiler]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECompilerSettings.cmake -- KF5[InstallDirs]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDEInstallDirs.cmake -- KF5[CMake]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECMakeSettings.cmake -- KF5[Compiler]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECompilerSettings.cmake -- Looking for posix_fadvise -- Looking for posix_fadvise - found -- Found ACL support: /usr/lib64/libacl.so;/usr/lib64/libattr.so -- Looking for strtoll -- Looking for strtoll - not found -- Found GSSAPI: -lgssapi_krb5 -lkrb5 -lk5crypto -lcom_err -- Looking for include file sys/time.h -- Looking for include file sys/time.h - found -- KF5[InstallDirs]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDEInstallDirs.cmake -- KF5[CMake]: Loaded settings from
Jenkins build is back to normal : kdelibs_frameworks_qt5 #1324
See http://build.kde.org/job/kdelibs_frameworks_qt5/1324/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Use of the WIN32 executable property
[Background for the blissfully Windows-ignorant devs: On Windows, executable files have a flag saying whether they are GUI or console applications. Running a GUI application from a console will give you the prompt back immediately; I think there's no way to capture stdout. Running a console application from a console will show stdout/stderr as usual and only give you the prompt back when the program finishes, and running it from elsewhere, such as by double-clicking the .exe file, will open a console window in order to show output.] In CMake, executables are console-mode by default, unless 'WIN32' is passed to add_executable. KDECMakeSettings.cmake in ECM sets a variable to change the default to GUI-mode instead. It can be set back to console mode for a specific target using set_target_properties. It's fine to set GUI mode globally, because most KDE applications are graphical. But I think *all* autotests should be marked as console executables. Some manual tests should be too; for example the kcolorcollectiontest test in kguiaddons doesn't display any UI, it only printf()s stuff into stdout. In fact, I wonder if we should make all tests console applications by default (in ecm_mark_as_test?)... -- Nicolás ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
