Suggestion: create an own framework for KGlobalAccel
Hi, at the moment KGlobalAccel is part of XmlGui which I consider semantically wrong. Global shortcuts have nothing to do with XmlGui and there are quite some examples for applications which need global shortcuts but do not use xml gui (e.g. everything in the desktop shell). My suggestion is to move the following source files into an own framework: * kglobalaccel.cpp * kglobalaccel.h * kglobalaccel_p.h * kglobalshortcutinfo.cpp * kglobalshortcutinfo.h * kglobalshortcutinfo_dbus.cpp * kglobalshortcutinfo_p.h * org.kde.kglobalaccel.Component.xml * org.kde.KGlobalAccel.xml From checking the source files this would become a tier1 framework as the dependencies are: * QtCore * QtDBus * QtWidgets * QtX11Extras Opinions? Cheers Martin P.S. I blame Aurélien and his diagrams for this proposal. It made me look into the dependencies of KWin and I had a wtf why are we linking sonnet? moment and looked into what we used of XmlGui. signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114328: re-add customstyleelement suite to kstyle
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114328/#review45342 --- This review has been submitted with commit 278f2ed5630e21bba28c3433579405d372b7c89b by Hugo Pereira Da Costa to branch frameworks. - Commit Hook On Dec. 6, 2013, 2:43 p.m., Hugo Pereira Da Costa wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114328/ --- (Updated Dec. 6, 2013, 2:43 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- re-add customstyleelement suite to kstyle Diffs - tier4/frameworkintegration/src/kstyle/kstyle.h 8a881f5 tier4/frameworkintegration/src/kstyle/kstyle.cpp 27d407e Diff: http://git.reviewboard.kde.org/r/114328/diff/ Testing --- compiles, works, fix kde-workspace build also: will be used when moving oxygen from qcommonstyle back to kstyle (right now we have a fork of some of the said methods) Thanks, Hugo Pereira Da Costa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114328: re-add customstyleelement suite to kstyle
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114328/ --- (Updated Dec. 8, 2013, 10:24 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kdelibs Description --- re-add customstyleelement suite to kstyle Diffs - tier4/frameworkintegration/src/kstyle/kstyle.h 8a881f5 tier4/frameworkintegration/src/kstyle/kstyle.cpp 27d407e Diff: http://git.reviewboard.kde.org/r/114328/diff/ Testing --- compiles, works, fix kde-workspace build also: will be used when moving oxygen from qcommonstyle back to kstyle (right now we have a fork of some of the said methods) Thanks, Hugo Pereira Da Costa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Tier 3 depending between eachother
On Saturday 07 December 2013 17:57:31 Albert Astals Cid wrote: Looking at Aurélien's graphs i see that there seem to be a few Tier 3 things depending on other Tier 3 things. Yep, that's perfectly fine, it's the definition of tier3, see the first section in http://community.kde.org/Frameworks/Policies. Why is that? And what's the difference between a Tier 3 thing that depends on another Tier 3 thing and a Tier 4 thing? Tier4 is very special: it's for things that offer additional integration automatically (without providing an API, so more like plugins). And for things which are deprecated and sit on top of everything else. In other words: pure-KF5 applications shouldn't link to anything from tier4. The API layer stops at tier3. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Tier 3 depending between eachother
On 12/08/2013 11:46 AM, David Faure wrote: On Saturday 07 December 2013 17:57:31 Albert Astals Cid wrote: Looking at Aurélien's graphs i see that there seem to be a few Tier 3 things depending on other Tier 3 things. Yep, that's perfectly fine, it's the definition of tier3, see the first section in http://community.kde.org/Frameworks/Policies. Why is that? And what's the difference between a Tier 3 thing that depends on another Tier 3 thing and a Tier 4 thing? Tier4 is very special: it's for things that offer additional integration automatically (without providing an API, so more like plugins). And for things which are deprecated and sit on top of everything else. In other words: pure-KF5 applications shouldn't link to anything from tier4. mmm. What about kstyle then ? (tier4/frameworkintegration/src/kstyle) used to make easier kf5 widget styles ? (hence definitly not a plugin) The API layer stops at tier3. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Suggestion: create an own framework for KGlobalAccel
El Diumenge, 8 de desembre de 2013, a les 10:16:36, Martin Graesslin va escriure: Hi, at the moment KGlobalAccel is part of XmlGui which I consider semantically wrong. Global shortcuts have nothing to do with XmlGui and there are quite some examples for applications which need global shortcuts but do not use xml gui (e.g. everything in the desktop shell). My suggestion is to move the following source files into an own framework: * kglobalaccel.cpp * kglobalaccel.h * kglobalaccel_p.h * kglobalshortcutinfo.cpp * kglobalshortcutinfo.h * kglobalshortcutinfo_dbus.cpp * kglobalshortcutinfo_p.h * org.kde.kglobalaccel.Component.xml * org.kde.KGlobalAccel.xml From checking the source files this would become a tier1 framework as the dependencies are: * QtCore * QtDBus * QtWidgets * QtX11Extras Opinions? Not an oposition but... Is there no other tier1 framework where it would fit logically and dependency wise? Sometimes I have the fear we might be splitting a bit too much (which can result in nightmare for release and package people amonsght otther stuff). Cheers, Albert Cheers Martin P.S. I blame Aurélien and his diagrams for this proposal. It made me look into the dependencies of KWin and I had a wtf why are we linking sonnet? moment and looked into what we used of XmlGui. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Suggestion: create an own framework for KGlobalAccel
On Sunday 08 December 2013 10:16:36 Martin Graesslin wrote: Hi, at the moment KGlobalAccel is part of XmlGui which I consider semantically wrong. Global shortcuts have nothing to do with XmlGui and there are quite some examples for applications which need global shortcuts but do not use xml gui (e.g. everything in the desktop shell). My suggestion is to move the following source files into an own framework: * kglobalaccel.cpp * kglobalaccel.h * kglobalaccel_p.h * kglobalshortcutinfo.cpp * kglobalshortcutinfo.h * kglobalshortcutinfo_dbus.cpp * kglobalshortcutinfo_p.h * org.kde.kglobalaccel.Component.xml * org.kde.KGlobalAccel.xml From checking the source files this would become a tier1 framework as the dependencies are: * QtCore * QtDBus * QtWidgets * QtX11Extras Opinions? It ended up in XmlGui because otherwise we would have a framework with a just a pair of public classes. Now I see where you come from from kwin point of view, so let's split it out after all. Now the trick is that we're about to split (pending emptying the patch queue), so if you want it please make it happen in the next couple of days. Regards. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Suggestion: create an own framework for KGlobalAccel
On Sunday 08 December 2013 18:44:59 Martin Graesslin wrote: On Sunday 08 December 2013 18:04:45 Albert Astals Cid wrote: El Diumenge, 8 de desembre de 2013, a les 10:16:36, Martin Graesslin va escriure: Hi, at the moment KGlobalAccel is part of XmlGui which I consider semantically wrong. Global shortcuts have nothing to do with XmlGui and there are quite some examples for applications which need global shortcuts but do not use xml gui (e.g. everything in the desktop shell). My suggestion is to move the following source files into an own framework: * kglobalaccel.cpp * kglobalaccel.h * kglobalaccel_p.h * kglobalshortcutinfo.cpp * kglobalshortcutinfo.h * kglobalshortcutinfo_dbus.cpp * kglobalshortcutinfo_p.h * org.kde.kglobalaccel.Component.xml * org.kde.KGlobalAccel.xml From checking the source files this would become a tier1 framework as the dependencies are: * QtCore * QtDBus * QtWidgets * QtX11Extras Opinions? Not an oposition but... Is there no other tier1 framework where it would fit logically and dependency wise? Probably Kevin or David can better comment on it. For me the only somewhat fitting framework would be KWidgetsAddons, but I don't know whether it would be OK to have more dependencies in that framework. WidgetsAddons only depends on Widgets, but GlobalAccel also needs DBus and X11Extras. KWidgetsAddons doesn't fit indeed. It has to keep depending on QtWidgets only. Cheers. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114185: Provide our own KFontDialog
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114185/ --- (Updated Dec. 8, 2013, 5:50 p.m.) Status -- This change has been discarded. Review request for KDE Frameworks. Repository: kdelibs Description --- To brighten a bit further the e-mail I just sent to kde-framewo...@kde.org, here I'm making the PlatformTheme to use our KFontDialog, that now it's residing in KDE4Support. I'd say this should result in a new module created, since we don't want to depend on KDE4Support, although I can see how we don't want to maintain an ABI on those classes, so forking is an option too. Diffs - tier4/frameworkintegration/CMakeLists.txt 02b3563 tier4/frameworkintegration/autotests/CMakeLists.txt f126859 tier4/frameworkintegration/src/platformtheme/CMakeLists.txt 5d95c8a tier4/frameworkintegration/src/platformtheme/kdeplatformfontdialoghelper.h PRE-CREATION tier4/frameworkintegration/src/platformtheme/kdeplatformfontdialoghelper.cpp PRE-CREATION tier4/frameworkintegration/src/platformtheme/kdeplatformtheme.h 69f1f44 tier4/frameworkintegration/src/platformtheme/kdeplatformtheme.cpp 010eed4 Diff: http://git.reviewboard.kde.org/r/114185/diff/ Testing --- Works with the kfontrequestertest. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114187: KFormat - Add new KFormat class
On Dec. 4, 2013, 7:32 p.m., Kevin Ottens wrote: Any chance for an update addressing the comments raised? John, please update ASAP, it's one of the patch we're waiting for to split. - Kevin --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114187/#review45135 --- On Nov. 28, 2013, 8 p.m., John Layt wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114187/ --- (Updated Nov. 28, 2013, 8 p.m.) Review request for KDE Frameworks, Albert Astals Cid, David Faure, and Kevin Ottens. Repository: kdelibs Description --- KFormat - Add new KFormat class KLocale offers a number of extra formatting options not yet available in Qt. The KFormat class adds these options to KCoreAddons: * formatByteSize() * formatDuration() * formatDecimalDuration() * formatSpelloutDuration() * formatRelativeDate() * formatRelativeDateTime() The KFormat class can be initialised with any QLocale to use in the date and number formatting, or the default locale can be easily accessed via KFormat(): QString result = KFormat().formatDuration(1000); There's a few things that need looking at here. The main one is the translation stuff because I had to convert from using ki18n to tr and it may have lost something in the process. In particular it looks like we'll actually need an en_US translation done to get the plurals right? If we can't make tr() work for these we'll have to move the class into k18n. The second is to look at the formatting options provided and decide if they are actually useful to have. The third is to confirm that the design is OK, I did think about making these simple static methods with an extra parm for QLocale, but I think this approach offers more future flexibility, and writing KFormat().formatDuration() is just as convenient as KFormat::formatDuration(). Diffs - tier1/kcoreaddons/autotests/CMakeLists.txt c8043576181e7d06663195d017be930d0bdcbde9 tier1/kcoreaddons/autotests/kformattest.h PRE-CREATION tier1/kcoreaddons/autotests/kformattest.cpp PRE-CREATION tier1/kcoreaddons/src/lib/CMakeLists.txt 638525f7b719bcd0bc1dfdf94debd51296521334 tier1/kcoreaddons/src/lib/util/kformat.h PRE-CREATION tier1/kcoreaddons/src/lib/util/kformat.cpp PRE-CREATION tier1/kcoreaddons/src/lib/util/kformatprivate.cpp PRE-CREATION tier1/kcoreaddons/src/lib/util/kformatprivate_p.h PRE-CREATION Diff: http://git.reviewboard.kde.org/r/114187/diff/ Testing --- Autotests copied from KLocale tests and improved. Thanks, John Layt ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Preparing for the split
Hello everyone, It is now really time to gear up toward the split. So from now on please don't create any new patches for the frameworks branch of kdelibs and put all effort and priority toward getting the existing open patches in reviewboard properly reviewed and pushed. We have to move fast if we want to keep our promise of a technology preview in December. There will be only one exception to this no new patches rule, and that's for the patches about the libraries rename started by Martin. Please help him get this work completed as soon as possible. We're almost here, we just need to get all brains focused. Let's make it happen! Thanks for your attention. Regards. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114182: Add Kf5 prefix for libs, eg. libKf5Foo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114182/#review45360 --- Ship it! The moves are still not easily reviewable (thank you reviewboard...). But it looks mostly good. Let's get it in. - Kevin Ottens On Dec. 5, 2013, 5:58 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114182/ --- (Updated Dec. 5, 2013, 5:58 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- This is just one framework - KConfig - if this is the proper way to do this, I'll update this review with all frameworks updated to this. Diffs - tier1/itemviews/tests/CMakeLists.txt 4ddf5d8 tier1/itemviews/src/CMakeLists.txt bad773c tier1/itemviews/autotests/CMakeLists.txt 0219900 tier1/itemviews/KF5ItemViewsConfig.cmake.in PRE-CREATION tier1/itemviews/ItemViewsConfig.cmake.in 1956453 tier1/itemviews/CMakeLists.txt 1bdadac tier1/itemmodels/src/CMakeLists.txt 86b48cf tier1/itemmodels/autotests/proxymodeltestapp/CMakeLists.txt 525c9f3 tier1/itemmodels/autotests/CMakeLists.txt 03daf70 tier1/itemmodels/KF5ItemModelsConfig.cmake.in PRE-CREATION tier1/itemmodels/ItemModelsConfig.cmake.in 4ac98f3 tier1/itemmodels/CMakeLists.txt d0be692 tier1/karchive/CMakeLists.txt f0d12ac tier1/karchive/KArchiveConfig.cmake.in 40fa614 tier1/karchive/KF5ArchiveConfig.cmake.in PRE-CREATION tier1/karchive/autotests/CMakeLists.txt a2cfabe tier1/karchive/examples/helloworld/CMakeLists.txt 2e90094 tier1/karchive/examples/tarlocalfiles/CMakeLists.txt b855caf tier1/karchive/src/CMakeLists.txt 767140a tier1/karchive/tests/CMakeLists.txt d804cd2 tier1/kcodecs/CMakeLists.txt a8217d0 tier1/kcodecs/KCodecsConfig.cmake.in ea632ce tier1/kcodecs/KF5CodecsConfig.cmake.in PRE-CREATION tier1/kcodecs/autotests/CMakeLists.txt bf393f8 tier1/kcodecs/src/CMakeLists.txt 152bc8e tier1/kconfig/CMakeLists.txt af91aa2 tier1/kconfig/KConfigConfig.cmake.in 5d9d7eb tier1/kconfig/KConfigMacros.cmake ec354a9 tier1/kconfig/KF5ConfigConfig.cmake.in PRE-CREATION tier1/kconfig/KF5ConfigMacros.cmake PRE-CREATION tier1/kconfig/autotests/CMakeLists.txt cc2626b tier1/kconfig/autotests/kconfig_compiler/CMakeLists.txt 184ab17 tier1/kconfig/src/core/CMakeLists.txt c8a4842 tier1/kconfig/src/gui/CMakeLists.txt b677d03 tier1/kconfig/src/kconf_update/CMakeLists.txt 69668bc tier1/kconfig/src/kconfig_compiler/CMakeLists.txt 19d86d4 tier1/kcoreaddons/CMakeLists.txt 5d2b4a8 tier1/kcoreaddons/KCoreAddonsConfig.cmake.in a53be5f tier1/kcoreaddons/KF5CoreAddonsConfig.cmake.in PRE-CREATION tier1/kcoreaddons/autotests/CMakeLists.txt c804357 tier1/kcoreaddons/src/lib/CMakeLists.txt 638525f tier1/kcoreaddons/tests/CMakeLists.txt c79d0ba tier1/kdbusaddons/CMakeLists.txt 78cc443 tier1/kdbusaddons/KDBusAddonsConfig.cmake.in 27a6060 tier1/kdbusaddons/KF5DBusAddonsConfig.cmake.in PRE-CREATION tier1/kdbusaddons/autotests/CMakeLists.txt 92c9151 tier1/kdbusaddons/src/CMakeLists.txt 71dc290 tier1/kdbusaddons/tests/CMakeLists.txt 684fee3 tier1/kguiaddons/CMakeLists.txt b3f378d tier1/kguiaddons/KF5GuiAddonsConfig.cmake.in PRE-CREATION tier1/kguiaddons/KGuiAddonsConfig.cmake.in 83e4c91 tier1/kguiaddons/autotests/CMakeLists.txt 2e4a6bb tier1/kguiaddons/src/CMakeLists.txt ca94f4b tier1/kguiaddons/tests/CMakeLists.txt 754b460 tier1/kidletime/CMakeLists.txt 61ba25b tier1/kidletime/KF5IdleTimeConfig.cmake.in PRE-CREATION tier1/kidletime/KIdleTimeConfig.cmake.in ace9e8a tier1/kidletime/examples/CMakeLists.txt c88a6c3 tier1/kidletime/src/CMakeLists.txt 44a1f3f tier1/kjs/CMakeLists.txt ab27a14 tier1/kjs/KF5JSConfig.cmake.in PRE-CREATION tier1/kjs/KJSConfig.cmake.in 8c4ff9e tier1/kjs/autotests/CMakeLists.txt 206c17a tier1/kjs/src/kjs/CMakeLists.txt b63d92f tier1/kjs/src/kjs/api/CMakeLists.txt dadf39c tier1/kjs/tests/CMakeLists.txt 9388a70 tier1/kplotting/CMakeLists.txt f8e53ff tier1/kplotting/KF5PlottingConfig.cmake.in PRE-CREATION tier1/kplotting/KPlottingConfig.cmake.in 42d4fae tier1/kplotting/autotests/CMakeLists.txt cc03ea4 tier1/kplotting/examples/CMakeLists.txt 7c8ab7e tier1/kplotting/src/CMakeLists.txt 59e7d09 tier1/kwidgetsaddons/CMakeLists.txt 570630b tier1/kwidgetsaddons/KF5WidgetsAddonsConfig.cmake.in PRE-CREATION tier1/kwidgetsaddons/KWidgetsAddonsConfig.cmake.in 98dbc46 tier1/kwidgetsaddons/autotests/CMakeLists.txt 1f6b69f tier1/kwidgetsaddons/src/CMakeLists.txt 0333f3a
Re: Review Request 114333: Add KF5 prefix for tier2
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114333/#review45361 --- Ship it! Ship It! - Kevin Ottens On Dec. 6, 2013, 2:01 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114333/ --- (Updated Dec. 6, 2013, 2:01 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Adds KF5 prefix to all tier2 frameworks Diffs - tier2/dnssd/CMakeLists.txt 542de05 tier2/dnssd/KDNSSDConfig.cmake.in 8678ccf tier2/dnssd/src/CMakeLists.txt ec20b9d tier2/kauth/CMakeLists.txt b01da0c tier2/kauth/KAuthConfig.cmake.in 3bc86e3 tier2/kauth/autotests/CMakeLists.txt e973789 tier2/kauth/cmake/KAuthMacros.cmake 4cdf3ab tier2/kauth/src/CMakeLists.txt c9ad99f tier2/kauth/src/ConfigureChecks.cmake a2441d9 tier2/kcompletion/CMakeLists.txt 040f8d6 tier2/kcompletion/KCompletionConfig.cmake.in 528e9a9 tier2/kcompletion/KF5CompletionConfig.cmake.in PRE-CREATION tier2/kcompletion/autotests/CMakeLists.txt 884db91 tier2/kcompletion/src/CMakeLists.txt 2f0a068 tier2/kcompletion/tests/CMakeLists.txt 1aeb870 tier2/kcrash/CMakeLists.txt 3267d8d tier2/kcrash/KCrashConfig.cmake.in 417209a tier2/kcrash/KF5CrashConfig.cmake.in PRE-CREATION tier2/kcrash/src/CMakeLists.txt 5e91142 tier2/kdoctools/CMakeLists.txt 88e0e1a tier2/kdoctools/KDocToolsConfig.cmake.in 9eb8706 tier2/kdoctools/KDocToolsMacros.cmake 191a2c5 tier2/kdoctools/KF5DocToolsConfig.cmake.in PRE-CREATION tier2/kdoctools/KF5DocToolsMacros.cmake PRE-CREATION tier2/kdoctools/src/CMakeLists.txt 3f77da0 tier2/ki18n/CMakeLists.txt ff8ec84 tier2/ki18n/KF5I18nConfig.cmake.in PRE-CREATION tier2/ki18n/KI18nConfig.cmake.in e307f56 tier2/ki18n/autotests/CMakeLists.txt 1abb03a tier2/ki18n/cmake/KF5I18NMacros.cmake PRE-CREATION tier2/ki18n/cmake/KI18NMacros.cmake d82514e tier2/ki18n/cmake/kf5i18nuic.cmake PRE-CREATION tier2/ki18n/cmake/ki18nuic.cmake efcd0ae tier2/ki18n/src/CMakeLists.txt 6534937 tier2/kjobwidgets/CMakeLists.txt 6759617 tier2/kjobwidgets/KF5JobWidgetsConfig.cmake.in PRE-CREATION tier2/kjobwidgets/KJobWidgetsConfig.cmake.in 8ca5e9d tier2/kjobwidgets/autotests/CMakeLists.txt d290a7b tier2/kjobwidgets/src/CMakeLists.txt 032df16 tier2/kjobwidgets/tests/CMakeLists.txt b453512 tier2/knotifications/CMakeLists.txt 4f71b2e tier2/knotifications/KF5NotificationsConfig.cmake.in PRE-CREATION tier2/knotifications/KNotificationsConfig.cmake.in 0054854 tier2/knotifications/autotests/CMakeLists.txt cf59af5 tier2/knotifications/src/CMakeLists.txt 3011a3d tier2/knotifications/tests/CMakeLists.txt 01c566a tier2/kwallet/CMakeLists.txt 0cf9a55 tier2/kwallet/KF5WalletConfig.cmake.in PRE-CREATION tier2/kwallet/KWalletConfig.cmake.in ca11594 tier2/kwallet/autotests/CMakeLists.txt ef707c1 tier2/kwallet/src/CMakeLists.txt 206dd69 tier2/kwallet/tests/CMakeLists.txt ea1562a Diff: http://git.reviewboard.kde.org/r/114333/diff/ Testing --- Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build became unstable: kdelibs_frameworks_qt5 #1831
See http://build.kde.org/job/kdelibs_frameworks_qt5/1831/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 114356: Move KGlobalAccel from XmlGui into an own tier1 framework
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114356/ --- Review request for KDE Frameworks and Martin Klapetek. Repository: kdelibs Description --- New framework needs DBus, Widgets and (optionally) X11Extras as dependencies. @MartinK: how should we organize the renaming? I'm still using the old naming scheme. So should I adjust or should we use your scripts after pulling this one in? Diffs - tier1/CMakeLists.txt 450ca57 tier1/kglobalaccel/CMakeLists.txt PRE-CREATION tier1/kglobalaccel/KGlobalAccelConfig.cmake.in PRE-CREATION tier1/kglobalaccel/autotests/CMakeLists.txt PRE-CREATION tier1/kglobalaccel/autotests/kglobalshortcuttest.h PRE-CREATION tier1/kglobalaccel/autotests/kglobalshortcuttest.cpp PRE-CREATION tier1/kglobalaccel/src/CMakeLists.txt PRE-CREATION tier1/kglobalaccel/src/config-kglobalaccel.h.cmake PRE-CREATION tier1/kglobalaccel/src/kglobalaccel.h PRE-CREATION tier1/kglobalaccel/src/kglobalaccel.cpp PRE-CREATION tier1/kglobalaccel/src/kglobalaccel_p.h PRE-CREATION tier1/kglobalaccel/src/kglobalshortcutinfo.h PRE-CREATION tier1/kglobalaccel/src/kglobalshortcutinfo.cpp PRE-CREATION tier1/kglobalaccel/src/kglobalshortcutinfo_dbus.cpp PRE-CREATION tier1/kglobalaccel/src/kglobalshortcutinfo_p.h PRE-CREATION tier1/kglobalaccel/src/org.kde.KGlobalAccel.xml PRE-CREATION tier1/kglobalaccel/src/org.kde.kglobalaccel.Component.xml PRE-CREATION tier3/xmlgui/CMakeLists.txt 75593fb tier3/xmlgui/autotests/CMakeLists.txt 6546ac7 tier3/xmlgui/autotests/kglobalshortcuttest.h d8e0024 tier3/xmlgui/autotests/kglobalshortcuttest.cpp 453920b tier3/xmlgui/src/CMakeLists.txt 31621e2 tier3/xmlgui/src/kactioncollection.cpp 0266069 tier3/xmlgui/src/kglobalaccel.h 57482ad tier3/xmlgui/src/kglobalaccel.cpp 77ce993 tier3/xmlgui/src/kglobalaccel_p.h 50f271f tier3/xmlgui/src/kglobalshortcutinfo.h 0920f01 tier3/xmlgui/src/kglobalshortcutinfo.cpp d2ca948 tier3/xmlgui/src/kglobalshortcutinfo_dbus.cpp f49bd9d tier3/xmlgui/src/kglobalshortcutinfo_p.h dd2dd2d tier3/xmlgui/src/kkeysequencewidget.cpp 2148ce0 tier3/xmlgui/src/kshortcutseditor.cpp 3e917d2 tier3/xmlgui/src/kshortcutseditoritem.cpp e7257a6 tier3/xmlgui/src/kxmlguifactory.cpp 510d2ea tier3/xmlgui/src/org.kde.KGlobalAccel.xml 8746551 tier3/xmlgui/src/org.kde.kglobalaccel.Component.xml ec21201 tier4/kde4support/CMakeLists.txt cb73b46 tier4/kde4support/src/CMakeLists.txt 39298b9 tier4/khtml/CMakeLists.txt c937f38 tier4/khtml/src/CMakeLists.txt 00243fb Diff: http://git.reviewboard.kde.org/r/114356/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
