Re: Let's get in release mode!
On Saturday 14 December 2013 20:55:30 Sebastian Kügler wrote: Hi Kévin, On Saturday, December 14, 2013 20:30:14 Kevin Ottens wrote: Once the technology preview is tagged, then all attention will be needed on the remaining tasks to get a final release. This list looks suspiciously short to me (although some tasks are in fact rather large), so either we're in a good position already or I missed some stuff... I just looked for the what's left myself, just two days ago. Where is this definition of done documented? Sorry if I've been unclear in that part, it was the URL linked at the beginning of my email: http://community.kde.org/Frameworks/Epics/KF5.0_Release_Preparation And yes it wasn't here two days ago, as I said I opened it yesterday. It's really the finalization tasks toward a release. Cheers. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[kdelibs/frameworks] /: Small tip for KIO::http_update_cache porting
Git commit 279aeffd0ac28b128fc5d7782fca50ddec2057b6 by Albert Astals Cid. Committed on 15/12/2013 at 14:13. Pushed by aacid into branch 'frameworks'. Small tip for KIO::http_update_cache porting CCMAIL:kde-frameworks-devel@kde.org M +1-0KDE5PORTING.html http://commits.kde.org/kdelibs/279aeffd0ac28b128fc5d7782fca50ddec2057b6 diff --git a/KDE5PORTING.html b/KDE5PORTING.html index a4d52f1..a727079 100644 --- a/KDE5PORTING.html +++ b/KDE5PORTING.html @@ -460,6 +460,7 @@ toolbar-setProperty(otherToolbar, true);/pre liKIO::RenameDialogPlugin was removed, it was unused for a long time anyway. The rename dialog uses KFileMetaDataWidget and PreviewJob instead./li liWhen Job::setUiDelegate(0) is used on a CopyJob (KIO::copy or KIO::move), an extra call to setUiDelegateExtension(0) is probably necessary, to disable skip and rename dialogs./li liKIO::Job::isInteractive() has been removed, use uiDelegate() or uiDelegateExtension() depending on what is meant (error messages, or rename/skip dialog)./li + liKIO::http_update_cache() now takes a QDateTime instead of a time_t, you can use QDateTime::fromTime_t if you need to/li /ul h4 align=righta href=#TOCReturn to the Table of Contents/a/h4 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Let's get in release mode!
El Dissabte, 14 de desembre de 2013, a les 20:30:14, Kevin Ottens va escriure:
Hello everyone,
Now we're really getting there! Epics and review board are clean, thanks to
everyone who helped to get there. Now it's the time to go for the last push.
For that I opened what will be the last epic for the 5.0 release:
http://community.kde.org/Frameworks/Epics/KF5.0_Release_Preparation
As you can see it is split in two, one part for the tech preview, the second
part for what will be needed for a final release. I urge everyone to focus
on the tech preview tasks for now. Don't hesitate to give a hand to the
people I put in contact for those tasks.
Obviously splitting the repositories will likely come first as it was the
focus for the past efforts.
In particular please help Ben with the transition to the split repositories
by first not pushing stuff (although if he prevents pushes in the first
place you'll be the ones with patches to port ;)) and second by extensively
testing the repositories once they are online. We might need several tries
to get them ready, so pay attention to Ben's communication as he'll
obviously coordinate that with his sysadmin super powers.
Once the technology preview is tagged, then all attention will be needed on
the remaining tasks to get a final release. This list looks suspiciously
short to me (although some tasks are in fact rather large), so either we're
in a good position already or I missed some stuff... The later being the
most probable don't hesitate to add more to the list if you see fit. This
list of tasks is basically our disguised definition of done for KF 5.0. If
we get all the tasks done we should be able to release right away.
After the technology preview we'll switch to a time based release for alphas
and betas. We still have to decide on a frequency (I'm leaning toward every
two weeks). It will be a good exercise to find issues in our release
process and fix them before 5.0 final.
I'm missing a task so that the mentions of KDE4 in frameworks is smaller than
it is now, a quick grep gives me stuff like
./INSTALL:2:http://techbase.kde.org/Getting_Started/Build/KDE4
./tier2/kauth/src/kauthactionreply.h:158: kde4_add_executable(helper_target
your sources...)
./tier2/kauth/src/kauthactionreply.h:174:
kde4_install_auth_actions(helper_id actions definition file)
./tier4/apidox/src/doxygen-preprocess-kcfg.sh:5:kcfg_compiler=`kde4-config --
prefix`/bin/kconfig_compiler
./tier4/apidox/src/doxygen-preprocess-kcfg.sh:5:kcfg_compiler=`kde4-config --
prefix`/bin/kconfig_compiler
./tier3/knewstuff/tests/CMakeLists.txt:56:#kde4_add_executable(kdxspreview
TEST ${kdxspreview_SRCS})
./tier3/xmlgui/src/kbugreport.cpp:395: // ### KDE4: why oh why is
KEMailSettings in kio?
./tier3/kio/src/widgets/thumbcreator.h:57: * find_package(KDE4 REQUIRED)
./tier3/kio/src/widgets/thumbcreator.h:58: * include (KDE4Defaults)
./tier3/kio/src/kpac/CMakeLists.txt:10:set(CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS}
${KDE4_ENABLE_EXCEPTIONS})
And lots more that seem to be wrong/leftovers/needattention.
Cheers,
Albert
Regards.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 114478: Add kshareddatacache.h include
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114478/ --- Review request for KDE Frameworks. Repository: kdelibs Description --- Since #define KImageCache KSharedPixmapCacheMixinKSharedDataCache I think it is only fair that kimagecache.h includes kshareddatacache.h otherwise a #include kimagecache.h is not enough to use it. Diffs - tier1/kguiaddons/src/util/kimagecache.h 682aa66 Diff: http://git.reviewboard.kde.org/r/114478/diff/ Testing --- Thanks, Albert Astals Cid ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Can't use DNSSD
Adding DNSSD to my find_package(KF5 REQUIRED COMPONENTS gives me CMake Error at /home/frameworks/instalado/lib/x86_64-linux-gnu/cmake/KF5DNSSD/KF5DNSSDConfig.cmake:57 (include): include could not find load file: /home/frameworks/instalado/lib/x86_64-linux-gnu/cmake/KF5DNSSD/KF5DNSSDTargets.cmake Call Stack (most recent call first): /home/frameworks/instalado/lib/x86_64-linux-gnu/cmake/KF5/KF5Config.cmake:26 (find_package) CMakeLists.txt:10 (find_package) Can anyone fix this? Cheers, Albert ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Where's kf5_add_ui_files ?
[: Albert Astals Cid :] tier2/ki18n/Mainpage.dox says * If CMake is used as the build system, a macro that performs * all of the above is provided (\c kf5_add_ui_files). But I can't seem to use it at all in my CMakeLists.txt. Documentation out of date, it is named ki18n_wrap_ui. Fixed. -- Chusslove Illich (Часлав Илић) signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Where's kf5_add_ui_files ?
El Diumenge, 15 de desembre de 2013, a les 18:01:24, Chusslove Illich va escriure: [: Albert Astals Cid :] tier2/ki18n/Mainpage.dox says * If CMake is used as the build system, a macro that performs * all of the above is provided (\c kf5_add_ui_files). But I can't seem to use it at all in my CMakeLists.txt. Documentation out of date, it is named ki18n_wrap_ui. Fixed. Chussolve already knows, but answering here for it to be known for everybody. ki18n_wrap_ui doesn't seem to be usable outside kdelibs. [ 51%] Generating ui_kgamethemeselector.h CMake Error: Error processing file: /kf5i18nuic.cmake Cheers, Albert ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Let's get in release mode!
On Sunday 15 December 2013 10:58:35 Alex Merry wrote: On 14/12/13 19:30, Kevin Ottens wrote: Now we're really getting there! Epics and review board are clean, thanks to everyone who helped to get there. Now it's the time to go for the last push. For that I opened what will be the last epic for the 5.0 release: http://community.kde.org/Frameworks/Epics/KF5.0_Release_Preparation As you can see it is split in two, one part for the tech preview, the second part for what will be needed for a final release. I urge everyone to focus on the tech preview tasks for now. Don't hesitate to give a hand to the people I put in contact for those tasks. I'd like to rename the makekdewidgets executable to something like kgendesignerplugin, to be more descriptive; this should be SC providing we keep the old CMake variables around, but should probably still happen before the TP, I guess? Can happen either before or after IMO. You can go ahead with it (as it looks small enough) if you manage to produce the change before Ben starts splitting the repositories. :-) Regards. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Let's get in release mode!
On Sunday 15 December 2013 16:38:40 Albert Astals Cid wrote:
El Dissabte, 14 de desembre de 2013, a les 20:30:14, Kevin Ottens va
escriure:
Hello everyone,
Now we're really getting there! Epics and review board are clean, thanks
to
everyone who helped to get there. Now it's the time to go for the last
push. For that I opened what will be the last epic for the 5.0 release:
http://community.kde.org/Frameworks/Epics/KF5.0_Release_Preparation
As you can see it is split in two, one part for the tech preview, the
second part for what will be needed for a final release. I urge everyone
to focus on the tech preview tasks for now. Don't hesitate to give a hand
to the people I put in contact for those tasks.
Obviously splitting the repositories will likely come first as it was the
focus for the past efforts.
In particular please help Ben with the transition to the split
repositories
by first not pushing stuff (although if he prevents pushes in the first
place you'll be the ones with patches to port ;)) and second by
extensively
testing the repositories once they are online. We might need several tries
to get them ready, so pay attention to Ben's communication as he'll
obviously coordinate that with his sysadmin super powers.
Once the technology preview is tagged, then all attention will be needed
on
the remaining tasks to get a final release. This list looks suspiciously
short to me (although some tasks are in fact rather large), so either
we're
in a good position already or I missed some stuff... The later being the
most probable don't hesitate to add more to the list if you see fit. This
list of tasks is basically our disguised definition of done for KF 5.0. If
we get all the tasks done we should be able to release right away.
After the technology preview we'll switch to a time based release for
alphas and betas. We still have to decide on a frequency (I'm leaning
toward every two weeks). It will be a good exercise to find issues in our
release process and fix them before 5.0 final.
I'm missing a task so that the mentions of KDE4 in frameworks is smaller
than it is now, a quick grep gives me stuff like
./INSTALL:2:http://techbase.kde.org/Getting_Started/Build/KDE4
./tier2/kauth/src/kauthactionreply.h:158:
kde4_add_executable(helper_target your sources...)
./tier2/kauth/src/kauthactionreply.h:174:
kde4_install_auth_actions(helper_id actions definition file)
./tier4/apidox/src/doxygen-preprocess-kcfg.sh:5:kcfg_compiler=`kde4-config
-- prefix`/bin/kconfig_compiler
./tier4/apidox/src/doxygen-preprocess-kcfg.sh:5:kcfg_compiler=`kde4-config
-- prefix`/bin/kconfig_compiler
./tier3/knewstuff/tests/CMakeLists.txt:56:#kde4_add_executable(kdxspreview
TEST ${kdxspreview_SRCS})
./tier3/xmlgui/src/kbugreport.cpp:395: // ### KDE4: why oh why is
KEMailSettings in kio?
./tier3/kio/src/widgets/thumbcreator.h:57: * find_package(KDE4 REQUIRED)
./tier3/kio/src/widgets/thumbcreator.h:58: * include (KDE4Defaults)
./tier3/kio/src/kpac/CMakeLists.txt:10:set(CMAKE_CXX_FLAGS
${CMAKE_CXX_FLAGS} ${KDE4_ENABLE_EXCEPTIONS})
And lots more that seem to be wrong/leftovers/needattention.
Makes sense, feel free to add to the bottom table on the wiki page.
Cheers.
--
Kévin Ottens, http://ervin.ipsquad.net
KDAB - proud supporter of KDE, http://www.kdab.com
signature.asc
Description: This is a digitally signed message part.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114478: Add kshareddatacache.h include
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114478/#review45732 --- It is in fact intended that way as kguiaddons isn't supposed to include stuff coming from kcoreaddons (yeah I know it's slightly convoluted in that particular case). - Kevin Ottens On Dec. 15, 2013, 4:15 p.m., Albert Astals Cid wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114478/ --- (Updated Dec. 15, 2013, 4:15 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Since #define KImageCache KSharedPixmapCacheMixinKSharedDataCache I think it is only fair that kimagecache.h includes kshareddatacache.h otherwise a #include kimagecache.h is not enough to use it. Diffs - tier1/kguiaddons/src/util/kimagecache.h 682aa66 Diff: http://git.reviewboard.kde.org/r/114478/diff/ Testing --- Thanks, Albert Astals Cid ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114478: Add kshareddatacache.h include
On Dec. 15, 2013, 9:22 p.m., Kevin Ottens wrote: It is in fact intended that way as kguiaddons isn't supposed to include stuff coming from kcoreaddons (yeah I know it's slightly convoluted in that particular case). So basically we have a header that when you include it, it breaks your compilation. Do you really think this is a good idea? - Albert --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114478/#review45732 --- On Dec. 15, 2013, 4:15 p.m., Albert Astals Cid wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114478/ --- (Updated Dec. 15, 2013, 4:15 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Since #define KImageCache KSharedPixmapCacheMixinKSharedDataCache I think it is only fair that kimagecache.h includes kshareddatacache.h otherwise a #include kimagecache.h is not enough to use it. Diffs - tier1/kguiaddons/src/util/kimagecache.h 682aa66 Diff: http://git.reviewboard.kde.org/r/114478/diff/ Testing --- Thanks, Albert Astals Cid ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Can't use DNSSD
El Diumenge, 15 de desembre de 2013, a les 23:02:36, Kevin Ottens va escriure: On Sunday 15 December 2013 17:29:58 Albert Astals Cid wrote: Adding DNSSD to my find_package(KF5 REQUIRED COMPONENTS gives me CMake Error at /home/frameworks/instalado/lib/x86_64-linux-gnu/cmake/KF5DNSSD/KF5DNSSDCon f ig.cmake:57 (include): include could not find load file: /home/frameworks/instalado/lib/x86_64-linux-gnu/cmake/KF5DNSSD/KF5DNSSDTar g ets.cmake Call Stack (most recent call first): /home/frameworks/instalado/lib/x86_64-linux-gnu/cmake/KF5/KF5Config.cmake: 2 6 (find_package) CMakeLists.txt:10 (find_package) Can anyone fix this? Pushed a commit, should fix it. Please let us know if that's still failing. Any reason i hage to use KF5::KF5DNSSD instead of KF5::DNSSD in target_link_libraries like it would seem logical due to the other frameworks naming? Cheers, Albert Cheers. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
