Re: Review Request 114716: Separate author name from email addres in KAboutData::processCommandLine

> On Dec. 29, 2013, 1:05 a.m., Albert Astals Cid wrote: > > src/lib/kaboutdata.cpp, line 969 > > > > > > Not related to your patch, but i wonder if we need a \n here too? I don't think so. The output of "kgeogra

Re: Review Request 114716: Separate author name from email addres in KAboutData::processCommandLine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114716/#review46342 --- src/lib/kaboutdata.cpp

Review Request 114716: Separate author name from email addres in KAboutData::processCommandLine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114716/ --- Review request for KDE Frameworks. Repository: kcoreaddons Description

Re: Review Request 114704: kgendesignerplugin cleanups

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114704/ --- (Updated Dec. 28, 2013, 5:38 p.m.) Review request for KDE Frameworks. C

Re: Review Request 114703: Improve dependency specification for kdesignerplugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114703/#review46305 --- This review has been submitted with commit 1ff318f0d9825b7eb8

Re: Review Request 114703: Improve dependency specification for kdesignerplugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114703/ --- (Updated Dec. 28, 2013, 5:37 p.m.) Status -- This change has been ma

Re: Review Request 114703: Improve dependency specification for kdesignerplugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114703/#review46292 --- Ship it! Looks nice. - David Faure On Dec. 28, 2013, 3 p.m

Review Request 114706: Fix capitalisation in KF5WebKitConfig.cmake file

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114706/ --- Review request for KDE Frameworks. Repository: kdewebkit Description --

Review Request 114705: Remove classpreviews.{cpp, h} from kdesignerplugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114705/ --- Review request for KDE Frameworks. Repository: kdesignerplugin Descript

Review Request 114704: Deprecate -n and -g options for kgendesignerplugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114704/ --- Review request for KDE Frameworks. Repository: kdesignerplugin Descript

Review Request 114703: Improve dependency specification for kdesignerplugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114703/ --- Review request for KDE Frameworks. Repository: kdesignerplugin Descript

Re: Review Request 113805: Do not change the build types available with cmake

> On Nov. 12, 2013, 7:24 p.m., Alexander Neundorf wrote: > > IMO the patch as it is is not good. > > > > Several things: > > 1) This file, is not mandatory at all with KDE frameworks. > > You can build applications using KDE frameworks libraries without it. You > > (the developer of the applica

Re: Review Request 113805: Do not change the build types available with cmake

> On Nov. 12, 2013, 7:24 p.m., Alexander Neundorf wrote: > > IMO the patch as it is is not good. > > > > Several things: > > 1) This file, is not mandatory at all with KDE frameworks. > > You can build applications using KDE frameworks libraries without it. You > > (the developer of the applica

Re: Review Request 114524: Load the kdoctools macro before trying to find the build deps

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114524/ --- (Updated Dec. 28, 2013, 2:02 p.m.) Status -- This change has been di

Re: Review Request 114524: Load the kdoctools macro before trying to find the build deps

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114524/#review46281 --- I'm inclined to say that we don't care about the frameworks br

Re: Review Request 114701: Print a warning if kimagecache.h is used without KF5::CoreAddons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114701/ --- (Updated Dec. 28, 2013, 1:53 p.m.) Status -- This change has been ma

Re: Review Request 114700: Add -DKCOREADDONS_LIB to the exported defines for KF5::CoreAddons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114700/ --- (Updated Dec. 28, 2013, 1:52 p.m.) Status -- This change has been ma

Re: Review Request 114701: Print a warning if kimagecache.h is used without KF5::CoreAddons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114701/#review46280 --- This review has been submitted with commit 9262517af279df80a0

Re: Review Request 114700: Add -DKCOREADDONS_LIB to the exported defines for KF5::CoreAddons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114700/#review46279 --- Ship it! Ship It! - David Faure On Dec. 28, 2013, 1:03 p.m

Re: Review Request 114701: Print a warning if kimagecache.h is used without KF5::CoreAddons

> On Dec. 28, 2013, 1:42 p.m., David Faure wrote: > > Ah indeed, well done. Does that mean you're happy for me to ship 114700 as well? - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.or

Re: Review Request 114701: Print a warning if kimagecache.h is used without KF5::CoreAddons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114701/#review46276 --- Ship it! Ah indeed, well done. - David Faure On Dec. 28, 2

Re: Review Request 114701: Print a warning if kimagecache.h is used without KF5::CoreAddons

> On Dec. 28, 2013, 1:19 p.m., David Faure wrote: > > See, this will print an unnecessary (i.e. wrong) warning in case we *are* > > linking to KCoreAddons, but not using cmake. > > qmake users will have to add a define just to silence the warning. So this > > create more work, rather than helpi

Re: Review Request 114701: Print a warning if kimagecache.h is used without KF5::CoreAddons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114701/#review46273 --- See, this will print an unnecessary (i.e. wrong) warning in ca

Re: Review Request 114700: Add -DKCOREADDONS_LIB to the exported defines for KF5::CoreAddons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114700/#review46271 --- OK for this particular case, but in general I don't like Qt's

Review Request 114701: Print a warning if kimagecache.h is used without KF5::CoreAddons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114701/ --- Review request for KDE Frameworks. Repository: kguiaddons Description -

Review Request 114700: Add -DKCOREADDONS_LIB to the exported defines for KF5::CoreAddons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114700/ --- Review request for KDE Frameworks. Repository: kcoreaddons Description

Review Request 114699: Use enums instead of ints in method types

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114699/ --- Review request for KDE Frameworks. Repository: kmediaplayer Description

Re: Review Request 114698: Make KStandardDirsTest work when not installed or KDEDIRS not set correctly

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114698/#review46265 --- This review has been submitted with commit a51f0ab2c569d9a46e

Re: Review Request 114698: Make KStandardDirsTest work when not installed or KDEDIRS not set correctly

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114698/ --- (Updated Dec. 28, 2013, 12:48 p.m.) Status -- This change has been m

Re: Review Request 114698: Make KStandardDirsTest work when not installed or KDEDIRS not set correctly

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114698/#review46264 --- This review has been submitted with commit e3cbb6dc44d68b6a23

Re: Review Request 114698: Make KStandardDirsTest work when not installed or KDEDIRS not set correctly

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114698/#review46263 --- This review has been submitted with commit 6da2ebe9231d8bc995

Re: Review Request 114698: Make KStandardDirsTest work when not installed or KDEDIRS not set correctly

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114698/#review46261 --- This review has been submitted with commit 05c1fd6f82995796a9

Re: Review Request 114698: Make KStandardDirsTest work when not installed or KDEDIRS not set correctly

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114698/#review46262 --- This review has been submitted with commit 5aaeabc5c62f902a60

Re: Review Request 114697: KStandardDirs: special case for xdgdata-apps

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114697/#review46259 --- This review has been submitted with commit deaa35d72fe0c62482

Re: Review Request 114698: Make KStandardDirsTest work when not installed or KDEDIRS not set correctly

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114698/#review46258 --- Ship it! Ship It! - David Faure On Dec. 28, 2013, 12:39 p.

Re: Review Request 114697: KStandardDirs: special case for xdgdata-apps

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114697/ --- (Updated Dec. 28, 2013, 12:42 p.m.) Status -- This change has been m

Review Request 114698: Make KStandardDirsTest work when not installed or KDEDIRS not set correctly

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114698/ --- Review request for KDE Frameworks and David Faure. Repository: kde4suppor

Re: Review Request 114697: KStandardDirs: special case for xdgdata-apps

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114697/#review46257 --- Ship it! Thanks. - David Faure On Dec. 28, 2013, 12:35 p.m

Review Request 114697: KStandardDirs: special case for xdgdata-apps

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114697/ --- Review request for KDE Frameworks and David Faure. Repository: kde4suppor

Review Request 114693: fix KFileWidget url selection

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114693/ --- Review request for KDE Frameworks. Repository: kio Description ---

Re: What are the plans with CamelCase includes?

On Saturday 28 December 2013 11:55:56 David Faure wrote: > On Friday 27 December 2013 19:01:09 Friedrich W. H. Kossebau wrote: > > So existing code ported from kdelibs would have to explicitely prefix the > > includes, e.g. be changed like > > #include -> #include > > Definitely don't want this.

Re: Refocusing the tech preview

On Saturday 28 December 2013 11:39:50 David Faure wrote: > On Saturday 21 December 2013 12:42:04 Kevin Ottens wrote: > > Hello people, > > > > I see that new tasks appeared in the wiki, that's great, they were clearly > > missing. That said, they were all earmarked for the tech preview, so I > > t

Frameworks repositories on reviewboard

Hello all, Everything is in the subject of this email. Thanks to Ben for doing the grunt work as usual. Ben you rock! So now people can report bugs on bugzilla and can send us patches through reviewboard. Cheers! -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http:/

Re: XDG_APPS_INSTALL_DIR and KStandardDirs

On Tuesday 24 December 2013 15:46:34 Alex Merry wrote: > This got a bit lost in the other thread on the kde4support tests... Ah. I think I unconfused it a few minutes ago, didn't see this. > I want to advocate setting XDG_APPS_INSTALL_DIR to be > $CMAKE_INSTALL_PREFIX/share/applications instead o

Re: What are the plans with CamelCase includes?

On Friday 27 December 2013 19:01:09 Friedrich W. H. Kossebau wrote: > So existing code ported from kdelibs would have to explicitely prefix the > includes, e.g. be changed like > #include -> #include Definitely don't want this. See the QtGui/QLabel -> QtWidgets/QLabel issue between Qt4 and Qt5

Re: Forward includes

On Friday 27 December 2013 19:54:14 Àlex Fiestas wrote: > On Friday 27 December 2013 19:00:14 Aleix Pol wrote: > > Hi, > > I've been going through the kde4support forward includes, since I wanted > > to > > start making the modules I decided we'd better make sure all of them are > > working properl

Re: kde4support: kstandarddirs_unittest fix

On Monday 23 December 2013 14:51:19 Alex Merry wrote: > If $PREFIX/share/applications does not exist, KStandardDirs will not add > it. It will then notice that nothing matching the installation prefix > was added, and add installPath("xdgdata-apps"), which is > $PREFIX/share/applications/kde5/. O

Re: Refocusing the tech preview

On Saturday 21 December 2013 12:42:04 Kevin Ottens wrote: > Hello people, > > I see that new tasks appeared in the wiki, that's great, they were clearly > missing. That said, they were all earmarked for the tech preview, so I took > the liberty to move most of them to the list about the final rele

Re: kde4support: kstandarddirs_unittest fix

On Friday 27 December 2013 11:38:08 Alex Merry wrote: > On 27/12/13 11:30, Kevin Ottens wrote: > > On Friday 27 December 2013 11:22:57 Alex Merry wrote: > >> On 27/12/13 11:04, Kevin Ottens wrote: > >>> On Monday 23 December 2013 14:51:19 Alex Merry wrote: > Actually, I think we should just in