Re: Tier status of attica & kwallet

On Thursday 23 January 2014 22:47:45 Valentin Rusu wrote: > On Wednesday, January 22, 2014 10:48:00 PM Kevin Ottens wrote: > > On Wednesday 22 January 2014 22:21:47 Valentin Rusu wrote: > > > On Thursday, January 23, 2014 04:24:37 AM Michael Palimaka wrote: > > > > Hi, > > > > > > > > attica seems

Re: Build failed in Jenkins: kde4support_master_qt5 #32

On Fri, Jan 24, 2014 at 1:28 PM, šumski wrote: > On Friday 24 of January 2014 09:53:00 Ben Cooksley wrote: >> There has been no changes in regards to the compiler, etc. on >> build.kde.org in the past few weeks. >> The only thing that could have changed would be the version of CMake - >> as we fol

Re: KIO::convertSize(.,.) vs. KFormat::formatByteSize(...)

On Thu, January 23, 2014 23:43:36 Friedrich W. H. Kossebau wrote: > Hi, > > I see a few overlappings between methods in KFormat (KCoreAddons) and KIO > (KIOCore), mainly this pair: > Questions: > > Q2) Should KIO::convertSize(...) not use KFormat::formatByteSize(...) behind > the scenes? (At lea

Re: Splitting kde-workspace and kde-runtime proposal

I don't clearly understand why KUriFilter-Plugins should go to plasma- workspace. I noticed KUriFilter is defined in kio and its plugins are used e.g. in kparts (browserextension). Shouldn't these go to kio? 2014/1/22 Kevin Ottens > On Tuesday 21 January 2014 12:05:26 Antonis Tsiapaliokas wrote

KIO::convertSize(.,.) vs. KFormat::formatByteSize(...)

Hi, I see a few overlappings between methods in KFormat (KCoreAddons) and KIO (KIOCore), mainly this pair: namespace KIO { typedef qulonglong filesize_t; KIOCORE_EXPORT QString convertSize(KIO::filesize_t size); } [[Takes the binary unit dialect to use from a config file given by QStandardPath

Re: Build failed in Jenkins: kde4support_master_qt5 #32

> On Fri, Jan 24, 2014 at 8:36 AM, Christoph Cullmann > wrote: > > Hi, > > > > I think the problem is the > > > > -std=iso9899:1990 > > > > in our KDECompilerSettings.cmake, that causes at least this error on my > > machine locally. > > > > (openSUSE 13.1, gcc 4.8.1) > > > > Without that, the conf

Re: Tier status of attica & kwallet

On 23/01/14 21:50, Valentin Rusu wrote: > On Thursday, January 23, 2014 11:18:02 PM Michael Palimaka wrote: >> On 01/23/2014 08:21 AM, Valentin Rusu wrote: >>> On Thursday, January 23, 2014 04:24:37 AM Michael Palimaka wrote: >> Sure, the framework itself is still tier 2...but the repo also include

Re: Review Request 115218: rename dbus interface file on install for kwallet

> On Jan. 22, 2014, 9:27 p.m., Valentin Rusu wrote: > > src/api/KWallet/CMakeLists.txt, line 100 > > > > > > The interface will be strictly the same. New features will be added to > > secret service. That's why

Re: Tier status of attica & kwallet

On Thursday, January 23, 2014 11:18:02 PM Michael Palimaka wrote: > On 01/23/2014 08:21 AM, Valentin Rusu wrote: > > On Thursday, January 23, 2014 04:24:37 AM Michael Palimaka wrote: > Sure, the framework itself is still tier 2...but the repo also includes > kwalletd which definitely is not tier 2,

Re: Tier status of attica & kwallet

On Wednesday, January 22, 2014 10:48:00 PM Kevin Ottens wrote: > On Wednesday 22 January 2014 22:21:47 Valentin Rusu wrote: > > On Thursday, January 23, 2014 04:24:37 AM Michael Palimaka wrote: > > > Hi, > > > > > > attica seems to have been absorbed as a framework, but does not appear > > > to ha

Re: Review Request 115218: rename dbus interface file on install for kwallet

> On Jan. 22, 2014, 9:27 p.m., Valentin Rusu wrote: > > src/api/KWallet/CMakeLists.txt, line 100 > > > > > > The interface will be strictly the same. New features will be added to > > secret service. That's why

Re: Build failed in Jenkins: kde4support_master_qt5 #32

On Fri, Jan 24, 2014 at 8:36 AM, Christoph Cullmann wrote: > Hi, > > I think the problem is the > > -std=iso9899:1990 > > in our KDECompilerSettings.cmake, that causes at least this error on my > machine locally. > > (openSUSE 13.1, gcc 4.8.1) > > Without that, the configure checks work correct a

Re: Build failed in Jenkins: kde4support_master_qt5 #32

Hi, I think the problem is the -std=iso9899:1990 in our KDECompilerSettings.cmake, that causes at least this error on my machine locally. (openSUSE 13.1, gcc 4.8.1) Without that, the configure checks work correct and we have the right HAVE_* stuff set. Is there some known issue with that co

Review Request 115269: Improve dependency specifications

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115269/ --- Review request for KDE Frameworks. Repository: kdnssd-framework Descrip

Review Request 115268: Replace the KDE_ENABLE_EXCEPTIONS variable with a pair of functions

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115268/ --- Review request for Build System, Extra Cmake Modules and KDE Frameworks.

Re: QFileDialog not usable with frameworkintegration

On Thu, Jan 23, 2014 at 5:16 PM, Aleix Pol wrote: > On Thu, Jan 23, 2014 at 11:49 AM, wrote: > >> Hi, >> >> as described in https://git.reviewboard.kde.org/r/115238/ there is a bug >> QFileDialog frameworkintegration. As opposed to written in the review >> request the dialog is not usable at the

Jenkins build is back to stable : ktexteditor_master_qt5 #131

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115253: Rename kf5dot-* tools to depdiagram-*

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115253/ --- (Updated Jan. 23, 2014, 5:01 p.m.) Status -- This change has been ma

Re: Review Request 115253: Rename kf5dot-* tools to depdiagram-*

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115253/#review48148 --- This review has been submitted with commit f13b43f1cb945c8c74

Re: Review Request 115262: Split Mainpage.dox up

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115262/#review48147 --- This review has been submitted with commit 1eea8d3525d28448e8

Re: Review Request 115262: Split Mainpage.dox up

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115262/ --- (Updated Jan. 23, 2014, 4:58 p.m.) Status -- This change has been ma

Re: Review Request 115262: Split Mainpage.dox up

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115262/#review48146 --- Ship it! Dominik our doxygen guy thinks its ok ;) - Christop

Jenkins build became unstable: ktexteditor_master_qt5 #130

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 115266: Split up Mainpage.dox

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115266/ --- Review request for KDE Frameworks, Àlex Fiestas and Kevin Ottens. Reposit

Re: Review Request 115262: Split Mainpage.dox up

> On Jan. 23, 2014, 4:33 p.m., Michael Palimaka wrote: > > README.md, line 69 > > > > > > In the threadweaver diff, you did escaped the #, I am not sure if that > > is wanted here too. It sort of doesn't matter,

Re: Review Request 115262: Split Mainpage.dox up

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115262/#review48144 --- README.md

Build failed in Jenkins: kde4support_master_qt5 #33

See Changes: [david.narvaez] Relocate KDE4_CREATE_HANDBOOK -- [...truncated 603 lines...] Generating moc_kfilemetadatawidget.cpp Generating moc_kfilemetainfowidget.cpp Generating moc_kfileshare_p

Re: Review Request 115239: Relocate KDE4_CREATE_HANDBOOK

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115239/ --- (Updated Jan. 23, 2014, 4:23 p.m.) Status -- This change has been ma

Re: QFileDialog not usable with frameworkintegration

On Thu, Jan 23, 2014 at 11:49 AM, wrote: > Hi, > > as described in https://git.reviewboard.kde.org/r/115238/ there is a bug > QFileDialog frameworkintegration. As opposed to written in the review > request the dialog is not usable at the moment if someone wants to > select a non-existing file bec

Re: Review Request 115239: Relocate KDE4_CREATE_HANDBOOK

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115239/#review48143 --- This review has been submitted with commit 20a6ee11861d3119a8

Re: Review Request 115237: Relocate KDE4_CREATE_HANDBOOK

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115237/#review48142 --- This review has been submitted with commit c4b6190709eaaf7d5c

Re: Review Request 115237: Relocate KDE4_CREATE_HANDBOOK

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115237/ --- (Updated Jan. 23, 2014, 4:22 p.m.) Status -- This change has been ma

Review Request 115264: Split up Mainpage.dox

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115264/ --- Review request for KDE Frameworks and Mirko Boehm. Repository: threadweav

Review Request 115262: Split Mainpage.dox up

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115262/ --- Review request for KDE Frameworks and Christoph Cullmann. Repository: kte

Re: Review Request 115249: Add runtime detection to KUserTimestamp

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115249/#review48140 --- Ship it! +1 - Àlex Fiestas On Jan. 23, 2014, 9:05 a.m., Ma

Re: Review Request 115251: Add better runtime detection for X11 usage in KStartupInfo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115251/#review48141 --- Ship it! The rest of the code is fine, +1 from me. src/ksta

Re: Review Request 115253: Rename kf5dot-* tools to depdiagram-*

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115253/#review48138 --- Ship it! Ship It! - Alex Merry On Jan. 23, 2014, 10:55 a.m

Re: Review Request 115206: Correct spelling, grammar and style of kcompletion.h docs

> On Jan. 21, 2014, 11:43 p.m., Alex Merry wrote: > > src/kcompletion.h, line 501 > > > > > > One sentence: "This signal is emitted by makeCompletion() when a match > > is found. > > David Gil Oliva wrote: >

Re: Review Request 115234: Only set QT_STRICT_ITERATORS when not compiling with MSVC

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115234/#review48133 --- This review has been submitted with commit 506bd64a3b30fbb5c1

Re: Review Request 115234: Only set QT_STRICT_ITERATORS when not compiling with MSVC

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115234/ --- (Updated Jan. 23, 2014, 3:10 p.m.) Status -- This change has been ma

Re: Review Request 115259: Simplify the project directories that are searched for images etc

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115259/ --- (Updated Jan. 23, 2014, 2:57 p.m.) Status -- This change has been ma

Re: Review Request 115225: Add runtime platform support to KWindowInfo

> On Jan. 23, 2014, 3:47 p.m., Alexander Richardson wrote: > > Wouldn't this be easier using methods with the subclass as a template > > parameter instead of the enum. I.e: > > > > > > class KWindowSystemPrivate { > > // > > template > > inline unsigned long state() const > > { > > //

Re: Review Request 115234: Only set QT_STRICT_ITERATORS when not compiling with MSVC

> On Jan. 23, 2014, 9:28 a.m., David Faure wrote: > > Oh, OK, didn't know this was broken on MSVC. Worth a Qt fix or at least > > bugreport? > > Luigi Toscano wrote: > Thiago reported it: see > http://lists.kde.org/?l=kde-buildsystem&m=139042097719628&w=2 and > https://codereview.qt-proje

Re: Review Request 115236: Get closer to compiling KIO on windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115236/#review48129 --- This review has been submitted with commit 76f474c43b80c5bc7c

Re: Review Request 115236: Get closer to compiling KIO on windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115236/ --- (Updated Jan. 23, 2014, 2:59 p.m.) Status -- This change has been ma

Re: Review Request 115236: Get closer to compiling KIO on windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115236/#review48128 --- This review has been submitted with commit 143d64206e65b57c0a

Re: Review Request 115236: Get closer to compiling KIO on windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115236/#review48127 --- This review has been submitted with commit f875a9b073734d22a6

Re: Review Request 115259: Simplify the project directories that are searched for images etc

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115259/#review48126 --- This review has been submitted with commit 716b4cbc2d274b5bf5

Re: Review Request 115225: Add runtime platform support to KWindowInfo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115225/#review48124 --- Wouldn't this be easier using methods with the subclass as a t

Build failed in Jenkins: kde4support_master_qt5 #32

See Changes: [agateau] Move api doc images to docs/pics -- [...truncated 629 lines...] Generating moc_kmessageboxmessagehandler.cpp Generating moc_knumvalidator.cpp Generating moc_kpassivepopupme

Re: Review Request 115236: Get closer to compiling KIO on windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115236/#review48121 --- Ship it! Ship It! - David Faure On Jan. 22, 2014, 9:12 p.m

Re: Review Request 115212: Fix windows build + 1 compiler warning

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115212/ --- (Updated Jan. 23, 2014, 2:22 p.m.) Status -- This change has been ma

Re: Review Request 115212: Fix windows build + 1 compiler warning

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115212/ --- (Updated Jan. 23, 2014, 2:22 p.m.) Status -- This change has been ma

Re: Review Request 115212: Fix windows build + 1 compiler warning

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115212/#review48119 --- This review has been submitted with commit f9f05e61581dbd742d

Re: Review Request 115212: Fix windows build + 1 compiler warning

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115212/#review48120 --- This review has been submitted with commit 27598328e3a4d046bb

Re: Review Request 115212: Fix windows build + 1 compiler warning

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115212/#review48118 --- This review has been submitted with commit acbd665a79eba3ff33

Re: Review Request 115236: Get closer to compiling KIO on windows

> On Jan. 23, 2014, 10:35 a.m., David Faure wrote: > > Has this been compile-tested on Linux? Yeah, I check that all these windows changes work on linux, too. Don't want to break my primarily used platform ;) - Alexander --- This is an

Re: Review Request 115259: Simplify the project directories that are searched for images etc

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115259/#review48116 --- Ship it! Thanks for this. It's much simpler this way. Just a

Re: Review Request 115234: Only set QT_STRICT_ITERATORS when not compiling with MSVC

> On Jan. 23, 2014, 10:28 a.m., David Faure wrote: > > Oh, OK, didn't know this was broken on MSVC. Worth a Qt fix or at least > > bugreport? > > Luigi Toscano wrote: > Thiago reported it: see > http://lists.kde.org/?l=kde-buildsystem&m=139042097719628&w=2 and > https://codereview.qt-proj

Re: Review Request 115259: Simplify the project directories that are searched for images etc

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115259/ --- (Updated Jan. 23, 2014, 2:10 p.m.) Review request for KDE Frameworks and

Re: Build failed in Jenkins: kde4support_master_qt5 #31

On Wed, Jan 22, 2014 at 3:28 AM, KDE CI System wrote: > In file included from > :45:0: > :168:8: > error: redefinition of ‘struct addrinfo

QFileDialog not usable with frameworkintegration

Hi, as described in https://git.reviewboard.kde.org/r/115238/ there is a bug QFileDialog frameworkintegration. As opposed to written in the review request the dialog is not usable at the moment if someone wants to select a non-existing file because it crashes. 1. $ ./qfiledialogtest --acceptMode

Review Request 115259: Simplify the project directories that are searched for images etc

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115259/ --- Review request for KDE Frameworks and Aurélien Gâteau. Repository: kapido

Re: Authors, maintainers and licenses in apidox

On 22/01/14 17:46, Jonathan Riddell wrote: > On Wed, Jan 22, 2014 at 12:27:29PM +, Alex Merry wrote: >> I would be tempted to ditch the current LICENSE files (all three of >> them), and add (summary) license info to README.md, as > > The COPYING{.LIB,.DOC} files can't go away as there must be

Re: Review Request 115165: Use a proper temporary file for the doxygen config

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115165/ --- (Updated Jan. 23, 2014, 12:59 p.m.) Status -- This change has been m

Re: Review Request 115165: Use a proper temporary file for the doxygen config

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115165/#review48111 --- This review has been submitted with commit ff6123c897c2146b78

Re: Review Request 115212: Fix windows build + 1 compiler warning

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115212/#review48110 --- Ship it! OK, good to go :-) - Alex Merry On Jan. 22, 2014,

Re: Review Request 115186: rename dbus interface file for kjobviewer

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115186/#review48108 --- FWIW the diff works fine here. - Michael Palimaka On Jan. 2

Re: Review Request 115218: rename dbus interface file on install for kwallet

> On Jan. 22, 2014, 9:27 p.m., Valentin Rusu wrote: > > src/api/KWallet/CMakeLists.txt, line 100 > > > > > > The interface will be strictly the same. New features will be added to > > secret service. That's why

Re: Tier status of attica & kwallet

On 01/23/2014 08:21 AM, Valentin Rusu wrote: > On Thursday, January 23, 2014 04:24:37 AM Michael Palimaka wrote: >> Hi, >> >> attica seems to have been absorbed as a framework, but does not appear >> to have been assigned a tier. Based on its dependencies, it looks like >> it would fit in tier 1? >

Review Request 115255: Add x11 platform detection to kkeyserver_x11

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115255/ --- Review request for KDE Frameworks. Repository: kwindowsystem Descriptio

Re: Review Request 115234: Only set QT_STRICT_ITERATORS when not compiling with MSVC

> On Jan. 23, 2014, 9:28 a.m., David Faure wrote: > > Oh, OK, didn't know this was broken on MSVC. Worth a Qt fix or at least > > bugreport? Thiago reported it: see http://lists.kde.org/?l=kde-buildsystem&m=139042097719628&w=2 and https://codereview.qt-project.org/#change,76311 - Luigi --

Re: Review Request 115253: Rename kf5dot-* tools to depdiagram-*

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115253/ --- (Updated Jan. 23, 2014, 11:55 a.m.) Review request for KDE Frameworks and

Re: Review Request 115253: Rename kf5dot-* tools to depdiagram-*

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115253/ --- (Updated Jan. 23, 2014, 11:55 a.m.) Review request for KDE Frameworks and

Review Request 115253: Rename kf5dot-* tools to depdiag-*

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115253/ --- Review request for KDE Frameworks and Alex Merry. Repository: kapidox D

Review Request 115251: Add better runtime detection for X11 usage in KStartupInfo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115251/ --- Review request for KDE Frameworks. Repository: kwindowsystem Descriptio

Re: Review Request 115166: Add a CMakeLists.txt which wraps python setup.py

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115166/ --- (Updated Jan. 23, 2014, 9:47 a.m.) Status -- This change has been ma

Re: Review Request 115166: Add a CMakeLists.txt which wraps python setup.py

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115166/#review48095 --- This review has been submitted with commit 1729071b1bd7060aaa

Re: Review Request 115166: Add a CMakeLists.txt which wraps python setup.py

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115166/ --- (Updated Jan. 23, 2014, 10:44 a.m.) Status -- This change has been d

Re: Review Request 115165: Use a proper temporary file for the doxygen config

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115165/#review48094 --- Ship it! Looks good to me. Just a nitpick, feel free to commi

Re: Review Request 115236: Get closer to compiling KIO on windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115236/#review48093 --- Has this been compile-tested on Linux? - David Faure On Jan

Re: Review Request 115234: Only set QT_STRICT_ITERATORS when not compiling with MSVC

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115234/#review48092 --- Ship it! Oh, OK, didn't know this was broken on MSVC. Worth a

Review Request 115249: Add runtime detection to KUserTimestamp

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115249/ --- Review request for KDE Frameworks. Repository: kwindowsystem Descriptio

Review Request 115248: Add runtime detection to KXMessages

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115248/ --- Review request for KDE Frameworks. Repository: kwindowsystem Descriptio

Re: Review Request 115225: Add runtime platform support to KWindowInfo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115225/ --- (Updated Jan. 23, 2014, 9:09 a.m.) Review request for KDE Frameworks and