Re: Review Request 115078: don't install dbus interface files in kglobalaccel

2014-01-25 Thread István Kapcsándi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/#review48281 --- src/CMakeLists.txt

Build failed in Jenkins: kde4support_master_qt5 #37

2014-01-25 Thread KDE CI System
See Changes: [scripty] SVN_SILENT made messages (.desktop file) -- [...truncated 632 lines...] Generating moc_ksplashscreen.cpp Generating moc_kstatusbar.cpp Generating moc_kstringvalidator.cpp G

Jenkins build is back to stable : kconfig_master_qt5 #23

2014-01-25 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: KIO::convertSize(.,.) vs. KFormat::formatByteSize(...)

2014-01-25 Thread Friedrich W. H. Kossebau
Am Samstag, 25. Januar 2014, 21:20:25 schrieb Michael Pyne: > On Sun, January 26, 2014 00:20:02 Friedrich W. H. Kossebau wrote: > > In a Plasma Workspace I expect the bytesize parameter defaults to be > > configurable, like it used to be. And any program which wants to properly > > integrate into t

Re: KIO::convertSize(.,.) vs. KFormat::formatByteSize(...)

2014-01-25 Thread Michael Pyne
On Sun, January 26, 2014 00:20:02 Friedrich W. H. Kossebau wrote: > In a Plasma Workspace I expect the bytesize parameter defaults to be > configurable, like it used to be. And any program which wants to properly > integrate into that environment should pick these defaults up. Like I expect > the p

Re: KIO::convertSize(.,.) vs. KFormat::formatByteSize(...)

2014-01-25 Thread Friedrich W. H. Kossebau
Hi David, Michael, everyone, Am Freitag, 24. Januar 2014, 09:40:00 schrieb David Faure: > On Thursday 23 January 2014 23:43:36 Friedrich W. H. Kossebau wrote: > > Hi, > > > > I see a few overlappings between methods in KFormat (KCoreAddons) and KIO > > (KIOCore), mainly this pair: > > > > namesp

Review Request 115316: Add demo for KRecentFileList

2014-01-25 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115316/ --- Review request for KDE Frameworks. Repository: kconfigwidgets Descripti

Re: Review Request 115289: MSVC fix: Check for libintl.h and libintl.lib

2014-01-25 Thread Alex Merry
> On Jan. 24, 2014, 8:09 p.m., Alex Merry wrote: > > cmake/FindLibIntl.cmake, line 26 > > > > > > Why not check if a libintl symbol exists without linking against any > > special libraries? > > Alexander Richard

Re: Review Request 115289: MSVC fix: Check for libintl.h and libintl.lib

2014-01-25 Thread Alex Merry
> On Jan. 24, 2014, 8:09 p.m., Alex Merry wrote: > > cmake/FindLibIntl.cmake, line 26 > > > > > > Why not check if a libintl symbol exists without linking against any > > special libraries? > > Alexander Richard

Re: Review Request 115292: Do Configure Checks in the Correct Language

2014-01-25 Thread Alex Merry
> On Jan. 24, 2014, 2:17 p.m., Alex Merry wrote: > > src/ConfigureChecks.cmake, line 20 > > > > > > This is the underlying cause of the issue. I think the reason your > > changes fix it is the same reason removi

Build failed in Jenkins: kde4support_master_qt5 #36

2014-01-25 Thread KDE CI System
See Changes: [scripty] SVN_SILENT made messages (.desktop file) -- [...truncated 605 lines...] Generating moc_kfiletreeview_p.cpp Generating moc_kmetaprops.cpp Generating moc_k3bufferedsocket.cpp

Jenkins build became unstable: kconfig_master_qt5 #22

2014-01-25 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115164: Keep tests together

2014-01-25 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115164/#review48267 --- Please note that I also committed b0d4f3a86a46da4aed1812e9e8bd

Jenkins build is back to normal : kio_master_qt5 #48

2014-01-25 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kio_master_qt5 #47

2014-01-25 Thread KDE CI System
See Changes: [kensington] Move tests buried in the source tree out into autotests. -- [...truncated 792 lines...] [ 39%] [ 39%] [ 40%] Building CXX object src/kioslave/CMakeFiles/kioslave.dir/kioslave.c

Re: Review Request 115164: Keep tests together

2014-01-25 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115164/ --- (Updated Jan. 25, 2014, 3:44 p.m.) Status -- This change has been ma

Re: Review Request 115164: Keep tests together

2014-01-25 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115164/#review48264 --- This review has been submitted with commit 3d69de1b9fe6055b72

Re: kf5options and qt5options manpages

2014-01-25 Thread Albert Astals Cid
El Dissabte, 25 de gener de 2014, a les 10:20:20, David Faure va escriure: > On Tuesday 21 January 2014 18:38:28 Jonathan Riddell wrote: > > kdeoptions and qtoptions manpages listed the common options to > > applications > > using kdelibs4 and qt4. > > > > These have just become kf5options and qt5

Re: Tier status of attica & kwallet

2014-01-25 Thread Michael Palimaka
On 01/25/2014 08:19 AM, Valentin Rusu wrote: > On Friday, January 24, 2014 07:22:22 AM Kevin Ottens wrote: >> On Thursday 23 January 2014 22:47:45 Valentin Rusu wrote: >>> On Wednesday, January 22, 2014 10:48:00 PM Kevin Ottens wrote: On Wednesday 22 January 2014 22:21:47 Valentin Rusu wrote:

Re: Review Request 115289: MSVC fix: Check for libintl.h and libintl.lib

2014-01-25 Thread Alexander Richardson
> On Jan. 24, 2014, 9:09 p.m., Alex Merry wrote: > > cmake/FindLibIntl.cmake, line 26 > > > > > > Why not check if a libintl symbol exists without linking against any > > special libraries? Would be better, but

Jenkins build is back to normal : kemoticons_master_qt5 #13

2014-01-25 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kemoticons_master_qt5 #12

2014-01-25 Thread KDE CI System
See Changes: [faure] Generate and install .pri file [faure] Generate and install .pri file -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 1 i

Re: Review Request 115186: rename dbus interface file for kjobviewer

2014-01-25 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115186/ --- (Updated Jan. 25, 2014, 9:40 a.m.) Status -- This change has been ma

Re: Review Request 115186: rename dbus interface file for kjobviewer

2014-01-25 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115186/#review48260 --- This review has been submitted with commit 6ac3a3949166bd0519

Re: Review Request 115099: This file provides the function ecm_generate_pri_file(). Make ECMSetupVersion set PROJECT_VERSION_*

2014-01-25 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115099/#review48259 --- This review has been submitted with commit fc09a7e81864ad5901

Re: Review Request 115099: This file provides the function ecm_generate_pri_file(). Make ECMSetupVersion set PROJECT_VERSION_*

2014-01-25 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115099/ --- (Updated Jan. 25, 2014, 9:25 a.m.) Status -- This change has been ma

Re: kf5options and qt5options manpages

2014-01-25 Thread David Faure
On Tuesday 21 January 2014 18:38:28 Jonathan Riddell wrote: > kdeoptions and qtoptions manpages listed the common options to applications > using kdelibs4 and qt4. > > These have just become kf5options and qt5options. > > But which options are still true? > > From qt5options: All of these are n

Re: Review Request 115300: Fix KKeySequence shortcut types flags

2014-01-25 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115300/#review48258 --- Ship it! Hehe, nice find. The bug is in KDE 4.x too, but fixi

Re: Review Request 115186: rename dbus interface file for kjobviewer

2014-01-25 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115186/#review48257 --- Ship it! Ship It! - David Faure On Jan. 21, 2014, 5:02 p.m