On Jan. 30, 2014, 3:49 p.m., David Edmundson wrote:
src/kstartupinfo.cpp, line 1068
https://git.reviewboard.kde.org/r/115251/diff/2/?file=240679#file240679line1068
Does this need a runtime check?
no that should be fine. The Qt method delegates to nativeResourceForScreen in
the
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115411/
---
Review request for KDE Frameworks and Chusslove Illich.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115411/
---
(Updated Jan. 31, 2014, 12:03 p.m.)
Review request for KDE Frameworks
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115412/
---
Review request for KDE Frameworks.
Repository: kwindowsystem
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115137/
---
(Updated Jan. 31, 2014, 2:01 p.m.)
Review request for KDE Frameworks,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115404/#review48675
---
Ship it!
Checked with CMake 2.8.12.0 - still works fine.
-
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115412/#review48676
---
Ship it!
Looks valid to me
- Martin Gräßlin
On Jan. 31,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115412/#review48677
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115412/
---
(Updated Jan. 31, 2014, 1:27 p.m.)
Status
--
This change has been
On 01/31/2014 04:56 AM, Alex Merry wrote:
On 30/01/14 16:12, Aurélien Gâteau wrote:
The issue only occurred with CMake 2.8.12 when building kdelibs as a
whole. It is no longer a problem now that the repositories have been
split. Therefore, I think you can go on and remove those dependencies.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115394/#review48678
---
Ship it!
Had to redo the changes in kcompletion.h because of
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115404/#review48680
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115404/
---
(Updated Jan. 31, 2014, 2:48 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115387/#review48681
---
Looks good FWIW.
- Michael Palimaka
On Jan. 29, 2014, 4:27
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115411/#review48682
---
Ship it!
I think we should agree on doing this for all
On Thursday, 2014-01-30, 13:55:21, Alex Merry wrote:
On 30/01/14 13:50, Aurélien Gâteau wrote:
You can avoid this (on the receiving side) by editing your personal
mailing list settings. Quoting mailman settings page:
Avoid duplicate copies of messages?
When you are listed
See http://build.kde.org/job/ktexteditor_master_qt5/183/
--
Started by remote host 127.0.0.1 with note: Triggered by commit
Building remotely on LinuxSlave - 3 in workspace
http://build.kde.org/job/ktexteditor_master_qt5/ws/
Running Prebuild steps
See http://build.kde.org/job/ktexteditor_master_qt5/184/changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115411/#review48683
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115411/
---
(Updated Jan. 31, 2014, 5:35 p.m.)
Status
--
This change has been
On 31/01/14 15:39, Aleix Pol Gonzalez wrote:
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115411/
Ship it!
I think we should agree on doing this for all frameworks, actually.
All this checking if it's being built out of kdelibs doesn't
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115415/
---
Review request for KDE Frameworks and David Faure.
Repository: kio
On Jan. 13, 2014, 12:09 p.m., Alex Merry wrote:
src/kauthactionreply.h, line 173
https://git.reviewboard.kde.org/r/114990/diff/1/?file=233880#file233880line173
I'm sure no such macro exists. Have a look in
kauth/cmake/KF5AuthMacros.cmake for what it should become.
Are you
On Dec. 8, 2013, 12:08 p.m., Bhushan Shah wrote:
plasma/generic/dataengines/mouse/mouseengine.cpp, line 34
https://git.reviewboard.kde.org/r/114260/diff/2/?file=222312#file222312line34
You should call init() here. Have a look at
On Jan. 13, 2014, 12:15 p.m., Alex Merry wrote:
Currently, it is still kde4; it is tied to kde-runtime/pics/emoticons. I
think that directory needs to be merged into the kemoticons framework, and
then this line needs to match the installation location of that emoticons
theme.
On Jan. 13, 2014, 11:54 a.m., Alex Merry wrote:
Does kde5_install_icons even exist? I can't find its definition in
extra-cmake-modules.
You say you've done no testing; surely you should at least have tried a
fresh configure, compile and install of khtml?
Alex Merry wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115077/#review48693
---
If this review is obsolete, can you discard it, please?
-
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115292/#review48694
---
I'm slightly ambivilent about this, on the basis that my view
On Jan. 27, 2014, 7:39 a.m., Kevin Ottens wrote:
src/doxygen-preprocess-kcfg.sh, line 5
https://git.reviewboard.kde.org/r/114989/diff/1/?file=233879#file233879line5
Should indeed just say kconfig_compiler.
Any progress on this? As Kévin said, the $kcfg_compiler variable should
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115248/#review48699
---
Ship it!
Ship It!
- Alex Merry
On Jan. 27, 2014, 8:43
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115230/#review48700
---
Ship it!
Looks like it should be functionally equivalent to
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115416/
---
Review request for KDE Frameworks and Jeremy Whiting.
Repository:
On Jan. 31, 2014, 7:48 p.m., Alex Merry wrote:
Looks like it should be functionally equivalent to the old code (in the
presence of X11).
The only thing that gives me pause is explicitly checking the platform
plugin name (rather than, say, using the method from QX11Extras), but I
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115325/#review48701
---
I got fed up of making As above issues; the comments about
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115336/#review48705
---
Ship it!
There was an optional jsonfile argument; I guess
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115343/#review48706
---
src/solid/networking_win.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115344/#review48707
---
Ship it!
Can you include a link to
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115416/#review48709
---
Ship it!
Ship It!
- Jeremy Whiting
On Jan. 31, 2014,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115370/#review48708
---
Comments on the dox changes below. Please make the changes
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115225/#review48712
---
Ship it!
I'm not a huge fan of the dark templating magic,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115251/#review48713
---
src/kstartupinfo.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115387/#review48715
---
Is there a corresponding RR for kde-workspace?
- Alex Merry
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115415/#review48716
---
Ship it!
- Alex Merry
On Jan. 31, 2014, 5:57 p.m., Michael
On Jan. 31, 2014, 6:48 p.m., Alex Merry wrote:
Looks like it should be functionally equivalent to the old code (in the
presence of X11).
The only thing that gives me pause is explicitly checking the platform
plugin name (rather than, say, using the method from QX11Extras), but I
On Jan. 31, 2014, 9:45 p.m., Alex Merry wrote:
src/kstartupinfo.cpp, lines 458-480
https://git.reviewboard.kde.org/r/115251/diff/2/?file=240679#file240679line458
Surely we shouldn't be using KXMessages if we don't have X11?
(Also applies to the next bunch of methods)
I
On Jan. 31, 2014, 7:48 p.m., Alex Merry wrote:
Looks like it should be functionally equivalent to the old code (in the
presence of X11).
The only thing that gives me pause is explicitly checking the platform
plugin name (rather than, say, using the method from QX11Extras), but I
On Jan. 31, 2014, 8:45 p.m., Alex Merry wrote:
src/kstartupinfo.cpp, lines 458-480
https://git.reviewboard.kde.org/r/115251/diff/2/?file=240679#file240679line458
Surely we shouldn't be using KXMessages if we don't have X11?
(Also applies to the next bunch of methods)
On Jan. 31, 2014, 6:48 p.m., Alex Merry wrote:
Looks like it should be functionally equivalent to the old code (in the
presence of X11).
The only thing that gives me pause is explicitly checking the platform
plugin name (rather than, say, using the method from QX11Extras), but I
On Jan. 31, 2014, 6:21 p.m., Alex Merry wrote:
If this review is obsolete, can you discard it, please?
I'm waiting for an answer to my question above.
- David
---
This is an automatically generated e-mail. To reply, visit:
On Jan. 31, 2014, 6:31 p.m., Alex Merry wrote:
src/ConfigureChecks.cmake, lines 87-88
https://git.reviewboard.kde.org/r/115292/diff/1/?file=240431#file240431line87
Is this LANGUAGE stuff a cmake 3 feature, because it does not appear to
exist in cmake 2.8.12
$ cmake
On Jan. 31, 2014, 6:31 p.m., Alex Merry wrote:
src/ConfigureChecks.cmake, line 68
https://git.reviewboard.kde.org/r/115292/diff/1/?file=240431#file240431line68
I believe this isn't even used any more
It doesn't look like it is used, let me know if you want me to drop this call
$
On Jan. 31, 2014, 6:21 p.m., Alex Merry wrote:
If this review is obsolete, can you discard it, please?
David Narváez wrote:
I'm waiting for an answer to my question above.
I would go with Luigi's suggestion. If we determine later that it might be
useful beyond KDocTools, we can
On Jan. 31, 2014, 6:31 p.m., Alex Merry wrote:
src/ConfigureChecks.cmake, lines 87-88
https://git.reviewboard.kde.org/r/115292/diff/1/?file=240431#file240431line87
Is this LANGUAGE stuff a cmake 3 feature, because it does not appear to
exist in cmake 2.8.12
David Narváez
On Jan. 31, 2014, 6:31 p.m., Alex Merry wrote:
src/ConfigureChecks.cmake, line 68
https://git.reviewboard.kde.org/r/115292/diff/1/?file=240431#file240431line68
I believe this isn't even used any more
David Narváez wrote:
It doesn't look like it is used, let me know if you
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115417/
---
Review request for KDE Frameworks and Alex Merry.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115417/
---
(Updated Jan. 31, 2014, 10:02 p.m.)
Review request for KDE Frameworks
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115417/#review48728
---
Ship it!
Ship It!
- Alex Merry
On Jan. 31, 2014, 10:02
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115418/
---
Review request for KDE Frameworks.
Repository: kcompletion
Description
See http://build.kde.org/job/kcompletion_master_qt5/18/changes
Changes:
[davidgiloliva] Split KCompletionBase class from kcompletion.h
--
[...truncated 48 lines...]
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115394/
---
(Updated Jan. 31, 2014, 10:53 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115394/#review48729
---
This review has been submitted with commit
See http://build.kde.org/job/kcompletion_master_qt5/19/changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115292/#review48730
---
Ship it!
OK, works fine with CMake 2.8.12.0
- Alex Merry
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115419/
---
Review request for KDE Frameworks.
Repository: kcompletion
Description
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115292/#review48732
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115292/
---
(Updated Feb. 1, 2014, 3:39 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115417/#review48731
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115417/
---
(Updated Feb. 1, 2014, 3:39 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115251/
---
(Updated Feb. 1, 2014, 8:40 a.m.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115230/
---
(Updated Feb. 1, 2014, 7:41 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115230/#review48733
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115248/#review48734
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115248/
---
(Updated Feb. 1, 2014, 7:42 a.m.)
Status
--
This change has been
73 matches
Mail list logo
