Re: Review Request 115424: Improve kparts dependencies

2014-02-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115424/#review48758 --- tests/CMakeLists.txt

Review Request 115433: Fix compilation where struct addrinfo is already defined

2014-02-02 Thread Valentin Rusu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115433/ --- Review request for KDE Frameworks. Repository: kde4support Description

Re: Review Request 115251: Add better runtime detection for X11 usage in KStartupInfo

2014-02-02 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115251/#review48760 --- This review has been submitted with commit

Re: Review Request 115251: Add better runtime detection for X11 usage in KStartupInfo

2014-02-02 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115251/ --- (Updated Feb. 2, 2014, 11:06 a.m.) Status -- This change has been

Re: Review Request 115325: Improve documentation of KWindowInfo

2014-02-02 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115325/ --- (Updated Feb. 2, 2014, 11:12 a.m.) Status -- This change has been

Re: Review Request 115325: Improve documentation of KWindowInfo

2014-02-02 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115325/#review48761 --- This review has been submitted with commit

Re: Review Request 114260: Port mouse dataengine

2014-02-02 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114260/ --- (Updated Feb. 2, 2014, 12:26 p.m.) Review request for KDE Frameworks and

Review Request 115434: Deprecate KWindowSystem::windowInfo

2014-02-02 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115434/ --- Review request for KDE Frameworks. Repository: kwindowsystem

Re: Review Request 114260: Port mouse dataengine

2014-02-02 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114260/#review48763 --- Please test it with plasmaengineexplorer in my testing it

Re: Review Request 115433: Fix compilation where struct addrinfo is already defined

2014-02-02 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115433/#review48766 --- Have you updated extra-cmake-modules recently? I pushed a

Re: Review Request 115433: Fix compilation where struct addrinfo is already defined

2014-02-02 Thread Valentin Rusu
On Feb. 2, 2014, 12:40 p.m., Alex Merry wrote: Have you updated extra-cmake-modules recently? I pushed a fix for this issue a few days ago. Specifically, the issue was _GNU_SOURCE etc being defined when building, but not when running configure tests. Yes, I did a full KF5 rebuild.

Re: Review Request 115424: Improve kparts dependencies

2014-02-02 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115424/ --- (Updated Feb. 2, 2014, 3:09 p.m.) Review request for KDE Frameworks and

Re: Review Request 115424: Improve kparts dependencies

2014-02-02 Thread Michael Palimaka
On Feb. 2, 2014, 9:36 a.m., David Faure wrote: tests/CMakeLists.txt, lines 1-2 https://git.reviewboard.kde.org/r/115424/diff/1/?file=241204#file241204line1 There's never any reason for the tests/ subdir to use Qt5Test. Qt5Test = library for autotests. It uses

Re: Review Request 115424: Improve kparts dependencies

2014-02-02 Thread Michael Palimaka
On Feb. 1, 2014, 7:45 p.m., Alex Merry wrote: autotests/CMakeLists.txt, line 1 https://git.reviewboard.kde.org/r/115424/diff/1/?file=241203#file241203line1 What happens if Qt5Test is not found? Presumably, this should either be REQUIRED or the tests should be wrapped in an if()

Re: Review Request 115426: Remove transitive dependencies

2014-02-02 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115426/ --- (Updated Feb. 2, 2014, 3:11 p.m.) Status -- This change has been

Re: Review Request 115426: Remove transitive dependencies

2014-02-02 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115426/#review48773 --- This review has been submitted with commit

Re: Review Request 115424: Improve kparts dependencies

2014-02-02 Thread David Faure
On Feb. 2, 2014, 9:36 a.m., David Faure wrote: tests/CMakeLists.txt, lines 1-2 https://git.reviewboard.kde.org/r/115424/diff/1/?file=241204#file241204line1 There's never any reason for the tests/ subdir to use Qt5Test. Qt5Test = library for autotests. Michael

Re: Review Request 115433: Fix compilation where struct addrinfo is already defined

2014-02-02 Thread Valentin Rusu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115433/ --- (Updated Feb. 2, 2014, 4:03 p.m.) Status -- This change has been

Re: Find dependencies quietly?

2014-02-02 Thread Stephen Kelly
On 02/02/2014 04:54 PM, Alex Merry wrote: On 02/02/14 07:27, Stephen Kelly wrote: On 02/02/2014 12:45 AM, Alex Merry wrote: The obvious thing to do is set a package property (or something equivalent) that says it was found as a dependency. The danger there is that if something is first found

Re: Find dependencies quietly?

2014-02-02 Thread Alex Merry
On 02/02/14 16:10, Stephen Kelly wrote: On 02/02/2014 04:54 PM, Alex Merry wrote: Either that, or have it as a completly orthogonal property that nevertheless interacts with TYPE, but I think that's overcomplicating matters. It is not clear to me whether you realize that that is what I

Re: Find dependencies quietly?

2014-02-02 Thread Stephen Kelly
On 02/02/2014 05:26 PM, Alex Merry wrote: On 02/02/14 16:10, Stephen Kelly wrote: On 02/02/2014 04:54 PM, Alex Merry wrote: Either that, or have it as a completly orthogonal property that nevertheless interacts with TYPE, but I think that's overcomplicating matters. It is not clear to me

Re: Find dependencies quietly?

2014-02-02 Thread Alex Merry
On 02/02/14 16:36, Stephen Kelly wrote: On 02/02/2014 05:26 PM, Alex Merry wrote: On 02/02/14 16:10, Stephen Kelly wrote: On 02/02/2014 04:54 PM, Alex Merry wrote: Either that, or have it as a completly orthogonal property that nevertheless interacts with TYPE, but I think that's

Re: Review Request 115419: Split KCompletionMatches into own headers

2014-02-02 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115419/ --- (Updated Feb. 2, 2014, 11:14 p.m.) Review request for KDE Frameworks.