> On Feb. 2, 2014, 9:36 a.m., David Faure wrote: > > tests/CMakeLists.txt, lines 1-2 > > <https://git.reviewboard.kde.org/r/115424/diff/1/?file=241204#file241204line1> > > > > There's never any reason for the tests/ subdir to use Qt5Test. > > > > Qt5Test = library for autotests. > > Michael Palimaka wrote: > It uses QFINDTESTDATA: > > notepad.cpp: setXMLFile(QFINDTESTDATA("notepadpart.rc")); > parts.cpp: setXMLFile(QFINDTESTDATA("kpartstest_part1.rc")); > parts.cpp: setXMLFile(QFINDTESTDATA("kpartstest_part2.rc")); > partviewer.cpp: setXMLFile(QFINDTESTDATA("partviewer_shell.rc")); > testmainwindow.cpp: setXMLFile(QFINDTESTDATA("kpartstest_shell.rc"))
Oh I was wrong, there is *one* reason to use qtestlib ;) OK. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115424/#review48758 ----------------------------------------------------------- On Feb. 2, 2014, 3:09 p.m., Michael Palimaka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115424/ > ----------------------------------------------------------- > > (Updated Feb. 2, 2014, 3:09 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kparts > > > Description > ------- > > - QtNetwork is not used > - QtTest is only required for tests > - Remove transitive dependencies > > > Diffs > ----- > > CMakeLists.txt fe6de305d28c2cd073ae1bc5d171f1244d2ed29c > autotests/CMakeLists.txt d62107e51d88b0ea46be113b57c318197f3ebaa9 > tests/CMakeLists.txt d7bca988b59022bb0731a38a5d7e872217541810 > > Diff: https://git.reviewboard.kde.org/r/115424/diff/ > > > Testing > ------- > > Inspection of source. Builds. Tests pass. > > > Thanks, > > Michael Palimaka > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
