---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115749/
---
(Updated Feb. 15, 2014, 12:13 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115749/#review49814
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115755/
---
Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115756/
---
Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.
On Feb. 14, 2014, 3:26 p.m., Alex Merry wrote:
OK, I'll be honest, something about this whole module interface rubs me up
the wrong way. There's either too much or not enough magic: code that
calls ecm_generate_headers needs to know things about the implementation
and use them in
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115723/
---
(Updated Feb. 15, 2014, 12:21 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115723/#review49816
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115713/#review49817
---
This review has been submitted with commit
On Feb. 14, 2014, 3:26 p.m., Alex Merry wrote:
OK, I'll be honest, something about this whole module interface rubs me up
the wrong way. There's either too much or not enough magic: code that
calls ecm_generate_headers needs to know things about the implementation
and use them in
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115715/
---
(Updated Feb. 15, 2014, 1:37 p.m.)
Review request for KDE Frameworks,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115496/
---
(Updated Feb. 15, 2014, 12:51 p.m.)
Review request for Build System,
On Feb. 14, 2014, 1:58 p.m., John Layt wrote:
I'd prefer for now that you just replace the HAVE_X11 with #defined
Q_OS_UNIX !defined Q_OS_MAC which should produce the same effect. No
point in compiling the CUPS code if we're never going to use it. Once Qt
feature freeze kicks in
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115715/#review49828
---
Ship it!
Ship It!
- John Layt
On Feb. 15, 2014, 12:37
On Feb. 5, 2014, 4:51 p.m., Aurélien Gâteau wrote:
Wow, great work! I attempted doing this some time ago, and all I managed to
produce was two unit tests :). Looks good to me and works fine here. Just
two (really minor) nitpicks.
Kevin Krammer wrote:
Thanks :)
Good to hear
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115748/#review49836
---
Ship it!
Ship It!
- Alexander Richardson
On Feb. 14,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115752/#review49837
---
Same Problem on Windows:
On Feb. 15, 2014, 3:49 p.m., Alexander Richardson wrote:
Ship It!
Oops, I got confused between this one and
https://git.reviewboard.kde.org/r/115749/, so I already committed it.
- Alex
---
This is an automatically generated e-mail.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115748/
---
(Updated Feb. 15, 2014, 4:49 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115749/#review49841
---
This review has been submitted with commit
On Feb. 15, 2014, 12:13 p.m., Commit Hook wrote:
This review has been submitted with commit
3d931552b72972adb0cefe79cc4d9586671d5224 by Alex Merry to branch master.
Oops, I got confused between this and
https://git.reviewboard.kde.org/r/115748/, and committed that one instead.
- Alex
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115686/#review49844
---
XV is the grand-father of image viewers, I didn't know it had
On Feb. 15, 2014, 5:20 p.m., David Faure wrote:
XV is the grand-father of image viewers, I didn't know it had an image
format though. It's completely missing from shared-mime-info.
I have the very strong feeling that this should be removed, it's completely
obsolete :)
Can't
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115766/
---
Review request for KDE Frameworks and David Faure.
Repository: kparts
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115765/
---
Review request for Build System, Extra Cmake Modules, KDE Frameworks, and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115768/#review49852
---
Ship it!
Ship It!
- David Faure
On Feb. 15, 2014, 5:49
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115768/#review49854
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115686/
---
(Updated Feb. 15, 2014, 6:49 p.m.)
Review request for KDE Frameworks.
On Feb. 15, 2014, 5:20 p.m., David Faure wrote:
XV is the grand-father of image viewers, I didn't know it had an image
format though. It's completely missing from shared-mime-info.
I have the very strong feeling that this should be removed, it's completely
obsolete :)
Can't
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115686/#review49857
---
Ship it!
Ship It!
- David Faure
On Feb. 15, 2014, 6:49
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115765/#review49858
---
Ship it!
Thanks! Very nice.
I can write a porting script
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115684/
---
(Updated Feb. 15, 2014, 7:22 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115700/#review49860
---
Ship it!
Ship It!
- David Faure
On Feb. 12, 2014, 3:38
On Feb. 15, 2014, 7:24 p.m., David Faure wrote:
Ship It!
Actually the feature_summary line should be removed.
More stuff in kstyle/CMakeLists.txt should be cleaned up, there's no reason to
build it standalone.
- David
---
This is
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115701/#review49862
---
Ship it!
Ship It!
- David Faure
On Feb. 12, 2014, 4:01
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115702/#review49863
---
autotests/CMakeLists.txt
On Thursday 13 February 2014 17:41:26 Michael Pyne wrote:
In the meantime I will fix kdesrc-build to fallback automatically to
git-clone like it's supposed to.
There's two cases:
- no snapshot to download (as is the case initially for new frameworks)
(kdesrc-build should indeed fallback in
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115710/#review49866
---
src/khistorycombobox.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115719/#review49869
---
Ship it!
Ship It!
- David Faure
On Feb. 13, 2014, 11:53
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115766/#review49888
---
Ship it!
Ship It!
- David Faure
On Feb. 15, 2014, 5:42
On Sat, February 15, 2014 20:35:28 David Faure wrote:
On Thursday 13 February 2014 17:41:26 Michael Pyne wrote:
In the meantime I will fix kdesrc-build to fallback automatically to
git-clone like it's supposed to.
There's two cases:
- snapshot exists, but is broken. This is the current
40 matches
Mail list logo
