On Monday 03 March 2014 12:28:07 Aaron J. Seigo wrote:
do we want .desktop files as well as generated .json?
if so, for applications that wish to put additional data in the json files,
is it expected that they continue to do this by adding more “X-Foo”
entries to the [Desktop Entry] group
On Tuesday 04 March 2014 01:04:05 John Layt wrote:
So, now KPrintUtils and KUnitConversion are about done (bar the
KCurrencyCode move), are there any other Frameworks needing review?
All the unmaintained ones, some of the maintained ones too.
At Tier 1 level it just looks like KCodecs,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116568/#review51854
---
Ship it!
Too many C casts to not get nightmares, but other
On Tuesday 04 March 2014 12:08:07 Ben Cooksley wrote:
On Sun, Mar 2, 2014 at 5:03 AM, Albert Astals Cid aa...@kde.org wrote:
El Dissabte, 1 de març de 2014, a les 16:53:28, David Faure va escriure:
On Saturday 01 March 2014 16:39:56 Albert Astals Cid wrote:
Every time someone commits to
On Tue, Mar 4, 2014 at 9:30 PM, David Faure fa...@kde.org wrote:
On Tuesday 04 March 2014 12:08:07 Ben Cooksley wrote:
On Sun, Mar 2, 2014 at 5:03 AM, Albert Astals Cid aa...@kde.org wrote:
El Dissabte, 1 de març de 2014, a les 16:53:28, David Faure va escriure:
On Saturday 01 March 2014
See http://build.kde.org/job/knotifications_master_qt5/36/changes
Changes:
[mklapetek] Bump the tier to tier 3
--
Started by remote host 127.0.0.1 with note: Triggered by commit
Building remotely on LinuxSlave - 4 in workspace
See http://build.kde.org/job/knotifications_master_qt5/37/
--
Started by user gateau
Building remotely on LinuxSlave - 4 in workspace
http://build.kde.org/job/knotifications_master_qt5/ws/
Running Prebuild steps
[knotifications_master_qt5] $ /bin/sh -xe
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116591/
---
Review request for KDE Frameworks.
Repository: kwindowsystem
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116591/
---
(Updated March 4, 2014, 10:50 a.m.)
Review request for KDE Frameworks.
On March 4, 2014, 12:06 a.m., Aleix Pol Gonzalez wrote:
Ok, I just realized this was being dealt with and I did a different patch:
https://git.reviewboard.kde.org/r/116573/
I think that having UI strings on a header file is quite bad TBH, but since
I see there's consensus I'll
On Tuesday, March 04, 2014 09:22:11 David Faure wrote:
What I don't know is how much do we need support for queries that filter
this further, and whether just reading the json from all the plugins of
type foo is good enough.
In my tests it was expectedly slow: scaling linearly with number of
See http://build.kde.org/job/knotifications_master_qt5/38/
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
On Tuesday 04 March 2014 11:21:06 Sebastian Kügler wrote:
On Tuesday, March 04, 2014 09:22:11 David Faure wrote:
What I don't know is how much do we need support for queries that filter
this further, and whether just reading the json from all the plugins of
type foo is good enough.
In
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116588/#review51865
---
README.md
On 02/03/14 18:58, Kevin Ottens wrote:
On Thursday 27 February 2014 17:15:56 John Layt wrote:
I've done the first step, and I just need a volunteer to do the git magic
required to:
* Move kcurrencycode.h and kcurrencycode.cpp including history from
kunitconversion/src to
On March 4, 2014, 12:02 p.m., Alex Merry wrote:
README.md, line 9
https://git.reviewboard.kde.org/r/116588/diff/1/?file=251921#file251921line9
allows to interact with is bad grammar; allows interaction with
would work, and allows foo to interact with would be better. Maybe
On March 4, 2014, 8:28 a.m., David Faure wrote:
src/imageformats/pic.cpp, line 452
https://git.reviewboard.kde.org/r/116568/diff/2/?file=251701#file251701line452
Does this work on both big endian and little endian architectures? It
looks like it's extracting individual bytes out
On March 4, 2014, 11:02 a.m., Alex Merry wrote:
README.md, line 9
https://git.reviewboard.kde.org/r/116588/diff/1/?file=251921#file251921line9
allows to interact with is bad grammar; allows interaction with
would work, and allows foo to interact with would be better. Maybe
On Tuesday, March 4, 2014 11:52:11 David Faure wrote:
Unless someone has a plan for it, my suggestion would be, let's model it
after the upcoming app desktop cache, i.e. update it at install time. I'll
This sounds perfect.
In that vein, I did do some measuring of what takes time, and it really
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116588/
---
(Updated March 4, 2014, 1:32 p.m.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116588/#review51872
---
Ship it!
Ship It!
- Alex Merry
On March 4, 2014, 12:32
On 4 March 2014 09:25, Kevin Ottens er...@kde.org wrote:
On Tuesday 04 March 2014 01:04:05 John Layt wrote:
So, now KPrintUtils and KUnitConversion are about done (bar the
KCurrencyCode move), are there any other Frameworks needing review?
All the unmaintained ones, some of the maintained
On Tuesday 04 March 2014 15:29:33 John Layt wrote:
On 4 March 2014 09:25, Kevin Ottens er...@kde.org wrote:
On Tuesday 04 March 2014 01:04:05 John Layt wrote:
So, now KPrintUtils and KUnitConversion are about done (bar the
KCurrencyCode move), are there any other Frameworks needing review?
On 4 March 2014 15:59, Kevin Ottens er...@kde.org wrote:
KGuiAddons definitely. The other two are important too, but this one is even
more important.
OK, I'll get onto that then.
John.
___
Kde-frameworks-devel mailing list
On Feb. 27, 2014, 10:54 a.m., Alex Merry wrote:
The problem with doing this in support code is that it is not strictly
source compatible. An example this would break is if you want to embed the
value of QT_QMAKE_EXECUTABLE into a C++ executable using something like
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116598/
---
Review request for Build System, Extra Cmake Modules, KDE Frameworks, and
Hello everyone,
This is the minutes of the Week 10 KF5 meeting. As usual it has been held on
#kde-devel at 4pm Paris time.
Were present: afiestas, agateau, alexmerry, apol, mck182, mgraesslin, notmart,
Riddell, sebas, teo, tosky and myself.
Announcement:
* Alpha 2 is out!
* Next stop beta
Hi,
I know nothing about text codecs, but I've had a *very* quick look at KCodecs:
* Original code by Lars dated 1999!
* One method marked as deprecated to be removed for KDE4
* ###FIXME KDE4: the name of the encodings should mostly be uppercase
* Code generated by script
On March 1, 2014, 1:32 p.m., Lamarque Souza wrote:
CMakeLists.txt, line 23
https://git.reviewboard.kde.org/r/116098/diff/2/?file=246596#file246596line23
NMQt is supposed to depend on Qt only.
What is E-C-M?
Does GNUInstallDirs support all platforms that
On March 1, 2014, 5:17 p.m., David Faure wrote:
Hmm, this might be equivalent, but all it means is that the orig code was
wrong.
We should not make any memory allocations within the crash handler.
So we should instead store the startup id as a const char* somewhere and
use
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116598/#review51904
---
+1 but someone else has to approve
- Martin Gräßlin
On
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116098/#review51909
---
Ship it!
Ship It!
- Lamarque Souza
On March 4, 2014, 4:13
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116598/#review51912
---
Ship it!
Looks good to me.
- Aleix Pol Gonzalez
On March
Hi,
Nice simple one this, one public class, looks OK.
Has QWidget, Windows, Mac, and X11 (XScreensaver/XSync) backends, will need
Wayland or systemd support eventually?
Does have one TODO, but that's an implementation detail:
widgetbasedpoller.cpp # TODO: make optional, to avoid always
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115982/
---
(Updated March 4, 2014, 6:42 p.m.)
Status
--
This change has been
Hi,
Here's my first pass through KGuiAddons, focussing on the public api.
KColorCollection
- Should probably become a QSharedDataPointer
KWorkdWrap
- // KDE5 TODO: return a value, not a pointer, and use QSharedDataPointer.
KModifierKeyInfo
- Generally looks OK
- Has lots of bool
El Dimarts, 4 de març de 2014, a les 21:34:12, Ben Cooksley va escriure:
On Tue, Mar 4, 2014 at 9:30 PM, David Faure fa...@kde.org wrote:
On Tuesday 04 March 2014 12:08:07 Ben Cooksley wrote:
On Sun, Mar 2, 2014 at 5:03 AM, Albert Astals Cid aa...@kde.org wrote:
El Dissabte, 1 de març de
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116069/#review51923
---
Ship it!
Ship It!
- Burkhard Lück
On Feb. 27, 2014, 10:43
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116068/#review51924
---
Ship it!
Ship It!
- Burkhard Lück
On Feb. 27, 2014, 10:40
On March 4, 2014, 6:03 a.m., Michael Pyne wrote:
From what I can tell declaring *any* type A::B is a qualified id per the
C++ spec and therefore changes the template lookup rules for
argument-dependent lookup (which means the specialized function to be
called must already be in scope
On Tuesday 04 March 2014 19:35:10 John Layt wrote:
Hi,
Nice simple one this, one public class, looks OK.
Has QWidget, Windows, Mac, and X11 (XScreensaver/XSync) backends, will need
Wayland or systemd support eventually?
Does have one TODO, but that's an implementation detail:
On Feb. 4, 2014, 5:17 p.m., Alex Merry wrote:
Has the Qt patch been submitted upstream?
Dominik Haumann wrote:
Meanwhile yes: https://codereview.qt-project.org/#change,77390
Alex Merry wrote:
I don't think it's useful to have tests that fail because of upstream
issues in the
On Feb. 20, 2014, 12:07 p.m., Kevin Ottens wrote:
Aren't the concern raised initially on that patch addressed now? Please
make a second round of reviews or ship it.
More than a week with no reaction, should it be discarded?
- Kevin
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115752/
---
(Updated March 4, 2014, 8:09 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115916/#review51930
---
Ship it!
Ship It!
- Kevin Ottens
On Feb. 20, 2014, 4:41
On Feb. 19, 2014, 2:07 p.m., Alex Merry wrote:
I don't think papering over the X11-ness of kdesu like this is the right
approach. Of course, what this framework really needs is a test app; maybe
a simple port of the kdesu app from kde-runtime?
Kevin Ottens wrote:
This kind of
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115602/
---
(Updated March 4, 2014, 8:15 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115907/
---
(Updated March 4, 2014, 8:17 p.m.)
Status
--
This change has been
On Feb. 22, 2014, 9:09 a.m., David Faure wrote:
src/lib/kaboutdata.cpp, line 919
https://git.reviewboard.kde.org/r/115207/diff/3/?file=245365#file245365line919
A unittest would have shown you the bug in this line...
(you're modifying a copy - no effect).
Use
On Feb. 3, 2014, 6:07 p.m., Raphael Kubo da Costa wrote:
Please see the big comment below the elseif line, the link to the
kde-core-devel and
http://lists.kde.org/?l=kde-core-develm=138244424421211w=2: the issue
here is that if you pass -fno-exceptions to clang you need to guarantee
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115977/#review51936
---
src/karchive.h
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115316/#review51937
---
Ship it!
Ship It!
- Kevin Ottens
On Feb. 24, 2014, 10:05
On Feb. 25, 2014, 12:10 p.m., David Faure wrote:
The part of the description that says if accepted will modify kstyle as
well doesn't really make sense anymore (to fix if it's in your commit log
too).
The bit I'm not sure about is: using MainToolbar icon style everywhere ...
how
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116025/#review51940
---
Anything blocking you from addressing the last two issues?
-
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116096/#review51943
---
autotests/proxymodeltestsuite/CMakeLists.txt
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115932/
---
(Updated March 4, 2014, 8:41 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116088/#review51945
---
Ship it!
Ship It!
- Kevin Ottens
On Feb. 27, 2014, 12:19
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115918/
---
(Updated March 4, 2014, 8:45 p.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115918/#review51946
---
Ship it!
And I agree with Aurélien, a bug should be filed
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115710/#review51947
---
Ship it!
Ship It!
- Kevin Ottens
On Feb. 25, 2014, 10:50
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116538/#review51950
---
Ship it!
Ship It!
- Kevin Ottens
On March 2, 2014, 8:05
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116545/#review51953
---
Ship it!
Ship It!
- Kevin Ottens
On March 2, 2014, 9:11
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116561/#review51957
---
Ship it!
Ship It!
- Kevin Ottens
On March 3, 2014, 8:48
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116567/#review51959
---
Ship it!
Ship It!
- Kevin Ottens
On March 3, 2014, 3:23
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116588/#review51960
---
Ship it!
Ship It!
- Kevin Ottens
On March 4, 2014, 12:32
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115875/#review51961
---
Ship it!
autotests/kconfigtest.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116069/#review51963
---
Ship it!
Ship It!
- Kevin Ottens
On Feb. 27, 2014, 10:43
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116542/#review51966
---
Ship it!
Ship It!
- Kevin Ottens
On March 2, 2014, 8:20
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115137/#review51954
---
src/kwindowsystem_x11.cpp
On Feb. 28, 2014, 8:41 p.m., Matthew Dawson wrote:
While I'm fine with the idea behind this optimization, I worry that this
implementation could create situations were a configuration change is not
picked up by the system. For instance, what happens if the user doesn't
immediately
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115959/#review51972
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115710/#review51973
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115395/#review51974
---
Ship it!
Let's give it a try as the situation in frameworks
On Tuesday 04 March 2014 01:32:14 Michael Pyne wrote:
kf5: Port rc files to use branch-groups consistently.
Thanks!
This should be absolutely transparent except that kde-kactivities will
rename to kactivities, though you might have to update
kde-build-metadata first if you're using --pretend
Building KF5 mostly works, except I now get the error (cleaned build + install
folder) below when building kate. It looks as if Qt4 is somehow in the way now.
This used to work before, so is there any way to get it working again?
The detailed cmake logs are on paste.kde.org (see below).
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116068/#review51978
---
This review has been submitted with commit
On March 4, 2014, 10:11 p.m., David Faure wrote:
autotests/kconfigtest.cpp, line 86
https://git.reviewboard.kde.org/r/115875/diff/2/?file=251983#file251983line86
Just curious, what's the reason for the .. then? Doesn't this still
make this test potentially conflict with other
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115395/
---
(Updated March 4, 2014, 10:22 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116069/#review51985
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116069/#review51987
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116069/#review51986
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116069/
---
(Updated March 4, 2014, 10:33 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116603/
---
Review request for KDE Frameworks.
Repository: kwidgetsaddons
Hi all,
the version of DocBookXML used by our documentation has been changed in
Frameworks; our custom DTD is now based on 4.5 instead of 4.2. The change
should be *almost* painless, because the new version is backward compatibile.
Only the DTD needs to be changed.
Exception: if your application
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115207/
---
(Updated March 4, 2014, 11:11 p.m.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116603/#review51992
---
Ship it!
Should this remain internal API? If yes, please
Hello all, I've realized a bit ago that kspeech was not included in
the kdelibs split (probably because it was in staging at the time and
didn't conform to the other framework policies yet). I've cleaned it
up a bit and put it in my scratch space, but have some architectural
questions about it
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116603/#review51995
---
src/kpassworddialog.h
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116538/
---
(Updated March 5, 2014, 12:26 a.m.)
Status
--
This change has been
On March 4, 2014, 4:42 p.m., Lamarque Souza wrote:
Ship It!
Lamarque Souza wrote:
This should be ported to branches master and NM/0.9.8 as well.
Alexander Richardson wrote:
How should I commit it? Commit to oldest branch and then merge? Or rather
put this into qt5 and then
On Tue, March 4, 2014 22:54:42 David Faure wrote:
On Tuesday 04 March 2014 01:32:14 Michael Pyne wrote:
kf5: Port rc files to use branch-groups consistently.
Thanks!
This should be absolutely transparent except that kde-kactivities will
rename to kactivities, though you might have to
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116604/
---
Review request for Documentation, KDE Frameworks, kdelibs, and Aleix Pol
On Tue, March 4, 2014 18:46:53 John Layt wrote:
KImageCache
KSharedPixmapCacheMixin
KLocalImageCacheImplementation
- Looks OK
- KImageCache not exported, but KLocalImageCacheImplementation is, some
CMake magic involved?
No CMake. :)
KImageCache depends on KSharedDataCache from
On Tue, March 4, 2014 22:56:03 Dominik Haumann wrote:
Building KF5 mostly works, except I now get the error (cleaned build +
install folder) below when building kate. It looks as if Qt4 is somehow in
the way now. This used to work before, so is there any way to get it
working again?
It seems
On Wed, March 5, 2014 00:07:30 Luigi Toscano wrote:
Hi all,
the version of DocBookXML used by our documentation has been changed in
Frameworks; our custom DTD is now based on 4.5 instead of 4.2. The change
should be *almost* painless, because the new version is backward
compatibile. Only
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116098/
---
(Updated March 5, 2014, 2:46 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116098/#review52000
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115207/#review52006
---
Ship it!
Ship It!
- Kevin Ottens
On March 4, 2014, 11:11
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116542/#review52007
---
Ship it!
I wrote that code - sorry for the trouble and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115207/#review52010
---
Ship it!
Ship It!
- David Faure
On March 4, 2014, 11:11
100 matches
Mail list logo
