Re: Review Request 116696: Fix kservice_desktop_to_json when using cmake 2.8

2014-03-10 Thread Sebastian Kügler
> On March 10, 2014, 2:59 p.m., Aurélien Gâteau wrote: > > Strange, it works fine here. Which version of CMake are you using and which > > repository is failing? > > Aurélien Gâteau wrote: > Oh, version is in the request title. /me tests with 2.8. > > Aurélien Gâteau wrote: > Just trie

Re: Review Request 116696: Fix kservice_desktop_to_json when using cmake 2.8

2014-03-10 Thread Aleix Pol Gonzalez
> On March 10, 2014, 2:59 p.m., Aurélien Gâteau wrote: > > Strange, it works fine here. Which version of CMake are you using and which > > repository is failing? > > Aurélien Gâteau wrote: > Oh, version is in the request title. /me tests with 2.8. > > Aurélien Gâteau wrote: > Just trie

Re: Review Request 115478: Add QFileDialog unit autotest for filters (which reveals a QPA bug)

2014-03-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115478/#review52605 --- This review has been submitted with commit d460f4cc4d8d23ff6e

Re: Review Request 115478: Add QFileDialog unit autotest for filters (which reveals a QPA bug)

2014-03-10 Thread Dominik Haumann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115478/ --- (Updated March 10, 2014, 10:59 p.m.) Status -- This change has been

Re: Review Request 116696: Fix kservice_desktop_to_json when using cmake 2.8

2014-03-10 Thread Aurélien Gâteau
> On March 10, 2014, 3:59 p.m., Aurélien Gâteau wrote: > > Strange, it works fine here. Which version of CMake are you using and which > > repository is failing? > > Aurélien Gâteau wrote: > Oh, version is in the request title. /me tests with 2.8. > > Aurélien Gâteau wrote: > Just trie

Re: Review Request 116696: Fix kservice_desktop_to_json when using cmake 2.8

2014-03-10 Thread Sebastian Kügler
> On March 10, 2014, 2:59 p.m., Aurélien Gâteau wrote: > > Strange, it works fine here. Which version of CMake are you using and which > > repository is failing? > > Aurélien Gâteau wrote: > Oh, version is in the request title. /me tests with 2.8. > > Aurélien Gâteau wrote: > Just trie

Re: Review Request 116650: Give unique names to the targets created by KDocToolsMacros.cmake

2014-03-10 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116650/#review52599 --- KF5DocToolsMacros.cmake

Re: Review Request 116696: Fix kservice_desktop_to_json when using cmake 2.8

2014-03-10 Thread Aurélien Gâteau
> On March 10, 2014, 3:59 p.m., Aurélien Gâteau wrote: > > Strange, it works fine here. Which version of CMake are you using and which > > repository is failing? > > Aurélien Gâteau wrote: > Oh, version is in the request title. /me tests with 2.8. > > Aurélien Gâteau wrote: > Just trie

Jenkins build became unstable: kio_master_qt5 #99

2014-03-10 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116670: Use absolute paths to refer to entities/elements defined in kdoctools

2014-03-10 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116670/#review52585 --- kde4support doesn't compile yet on Windows, so I can't test it

Re: Review Request 116699: No longer use pid_t or Q_PID

2014-03-10 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116699/ --- (Updated March 10, 2014, 5:51 p.m.) Review request for KDE Frameworks and

Re: Review Request 116685: Import documentationnotfound in kio, used by kio-help

2014-03-10 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116685/ --- (Updated March 10, 2014, 5:46 p.m.) Review request for Documentation, KDE

Re: Review Request 115478: Add QFileDialog unit autotest for filters (which reveals a QPA bug)

2014-03-10 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115478/#review52575 --- Ship it! Ship It! - Kevin Ottens On March 9, 2014, 6:11 p.

Re: Review Request 116025: Add documentation about writing find modules

2014-03-10 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116025/#review52570 --- Ship it! Ship It! - Kevin Ottens On March 6, 2014, 10:56 p

Review Request 116699: No longer use pid_t or Q_PID

2014-03-10 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116699/ --- Review request for KDE Frameworks. Repository: kio Description ---

Re: Review Request 116696: Fix kservice_desktop_to_json when using cmake 2.8

2014-03-10 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116696/#review52565 --- Without this patch, the build also fails for me. With this pat

Re: Review Request 116650: Give unique names to the targets created by KDocToolsMacros.cmake

2014-03-10 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116650/ --- (Updated March 10, 2014, 4:17 p.m.) Review request for Build System and K

Re: Review Request 116650: Remove unused targets from KDocToolsMacros.cmake

2014-03-10 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116650/ --- (Updated March 10, 2014, 4:16 p.m.) Review request for Build System and K

Re: Review Request 116696: Fix kservice_desktop_to_json when using cmake 2.8

2014-03-10 Thread Aleix Pol Gonzalez
> On March 10, 2014, 2:59 p.m., Aurélien Gâteau wrote: > > Strange, it works fine here. Which version of CMake are you using and which > > repository is failing? > > Aurélien Gâteau wrote: > Oh, version is in the request title. /me tests with 2.8. > > Aurélien Gâteau wrote: > Just trie

Re: Review Request 116696: Fix kservice_desktop_to_json when using cmake 2.8

2014-03-10 Thread Alex Merry
> On March 10, 2014, 2:59 p.m., Aurélien Gâteau wrote: > > Strange, it works fine here. Which version of CMake are you using and which > > repository is failing? > > Aurélien Gâteau wrote: > Oh, version is in the request title. /me tests with 2.8. > > Aurélien Gâteau wrote: > Just trie

Re: Review Request 116696: Fix kservice_desktop_to_json when using cmake 2.8

2014-03-10 Thread Aurélien Gâteau
> On March 10, 2014, 3:59 p.m., Aurélien Gâteau wrote: > > Strange, it works fine here. Which version of CMake are you using and which > > repository is failing? > > Aurélien Gâteau wrote: > Oh, version is in the request title. /me tests with 2.8. Just tried with 2.8.12, which is the lowes

Re: Review Request 116696: Fix kservice_desktop_to_json when using cmake 2.8

2014-03-10 Thread Aurélien Gâteau
> On March 10, 2014, 3:59 p.m., Aurélien Gâteau wrote: > > Strange, it works fine here. Which version of CMake are you using and which > > repository is failing? Oh, version is in the request title. /me tests with 2.8. - Aurélien --- T

Re: Review Request 116696: Fix kservice_desktop_to_json when using cmake 2.8

2014-03-10 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116696/#review52551 --- Strange, it works fine here. Which version of CMake are you us

Review Request 116696: Fix kservice_desktop_to_json when using cmake 2.8

2014-03-10 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116696/ --- Review request for KDE Frameworks. Repository: kservice Description ---

Re: Review Request 115918: Fix kservice_desktop_to_json for Visual Studio

2014-03-10 Thread Alexander Richardson
> On March 4, 2014, 9:45 p.m., Kevin Ottens wrote: > > And I agree with Aurélien, a bug should be filed and Stephen involved in > > that issue. > > Stephen Kelly wrote: > Please provide a minimal testcase. The feature is unit tested in cmake. > If it's broken, it needs to be fixed soon (be

Jenkins build is back to stable : kunitconversion_master_qt5 #32

2014-03-10 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build became unstable: kunitconversion_master_qt5 #31

2014-03-10 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: KSpeech

2014-03-10 Thread Frederik Gladhorn
Torsdag 6. mars 2014 20.34.05 skrev Christoph Feck: > On Thursday 06 March 2014 17:13:19 Jeremy Whiting wrote: > > On Thu, Mar 6, 2014 at 6:43 AM, Frederik Gladhorn > > wrote: > > > Onsdag 5. mars 2014 23.04.12 skrev Jeremy Whiting: > > >> 3. user configurability (As a user I can't set up which v

Re: Review Request 116639: Do not read LOCATION property of desktoptojson

2014-03-10 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116639/ --- (Updated March 10, 2014, 10:27 a.m.) Status -- This change has been

Re: Review Request 116639: Do not read LOCATION property of desktoptojson

2014-03-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116639/#review52514 --- This review has been submitted with commit 223a99d128bd2877e3

Re: Review Request 116610: Use flag types in NETRootInfo

2014-03-10 Thread Aurélien Gâteau
> On March 6, 2014, 5:22 p.m., Aurélien Gâteau wrote: > > Looks good. > > > > One question though, wasn't it possible to merge properties or properties2? > > I lack extensive knowledge of this domain, but it looks odd from an API > > point of view. > > Martin Gräßlin wrote: > that would b

Review Request 116689: KCoreConfigSkeleton: delay parsing until the call to readConfig()

2014-03-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116689/ --- Review request for KDE Frameworks and Matthew Dawson. Repository: kconfig