---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116685/#review52717
---
Ship it!
Ship It!
- David Faure
On March 10, 2014, 5:46
On March 11, 2014, 11:17 p.m., Aleix Pol Gonzalez wrote:
src/kcompletionbox.h, line 228
https://git.reviewboard.kde.org/r/116747/diff/1/?file=253404#file253404line228
I wouldn't leave the implementation here. Move it to the .cpp file,
this way it can be changed in the future, if
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116756/
---
Review request for KDE Frameworks and Aurélien Gâteau.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116699/#review52731
---
there is QProcess::processId() since 5.3 (replacing
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116740/#review52738
---
This review has been submitted with commit
On 12/03/14 07:56, Kevin Ottens wrote:
Hello,
On Tuesday 11 March 2014 22:19:06 David Gil Oliva wrote:
2014-03-11 16:33 GMT+01:00 Kevin Ottens er...@kde.org:
Why is that? Are we in a hurry? Is the work in all the frameworks so
advanced that we can advance the tagging?
It just a question
On March 11, 2014, 11:17 p.m., Aleix Pol Gonzalez wrote:
src/kcompletionbox.h, line 228
https://git.reviewboard.kde.org/r/116747/diff/1/?file=253404#file253404line228
I wouldn't leave the implementation here. Move it to the .cpp file,
this way it can be changed in the future, if
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116756/#review52741
---
Ship it!
Ship It!
- Alex Merry
On March 12, 2014, 9:26
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116747/#review52740
---
Looks sensible to me, but I'll let Aleix reply.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116758/
---
Review request for KDE Frameworks and Aurélien Gâteau.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116759/
---
Review request for KDE Frameworks.
Repository: kio
Description
---
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116758/#review52745
---
Ship it!
Ship It!
- Aurélien Gâteau
On March 12, 2014,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116758/#review52746
---
This review has been submitted with commit
On March 11, 2014, 11:17 p.m., Aleix Pol Gonzalez wrote:
src/kcompletionbox.h, line 228
https://git.reviewboard.kde.org/r/116747/diff/1/?file=253404#file253404line228
I wouldn't leave the implementation here. Move it to the .cpp file,
this way it can be changed in the future, if
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116761/
---
Review request for KDE Frameworks.
Repository: kservice
Description
On March 11, 2014, 11:17 p.m., Aleix Pol Gonzalez wrote:
src/kcompletionbox.h, line 228
https://git.reviewboard.kde.org/r/116747/diff/1/?file=253404#file253404line228
I wouldn't leave the implementation here. Move it to the .cpp file,
this way it can be changed in the future, if
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116762/
---
Review request for KDE Frameworks.
Repository: kservice
Description
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116762/#review52753
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On March 12, 2014,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116766/
---
Review request for KDE Frameworks.
Repository: kservice
Description
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116762/
---
(Updated March 12, 2014, 2:47 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116762/#review52762
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116735/
---
Review request for KDE Frameworks.
Repository: knewstuff
Description
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116761/
---
(Updated March 12, 2014, 2:48 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116767/
---
Review request for KDE Frameworks.
Repository: kservice
Description
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116767/#review52772
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On March 12, 2014,
On March 1, 2014, 4:17 p.m., David Faure wrote:
Hmm, this might be equivalent, but all it means is that the orig code was
wrong.
We should not make any memory allocations within the crash handler.
So we should instead store the startup id as a const char* somewhere and
use
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116087/
---
(Updated March 12, 2014, 3:26 p.m.)
Review request for KDE Frameworks
On March 4, 2014, 8:11 p.m., Kevin Ottens wrote:
Ship It!
Any news?
- Kevin
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115916/#review51930
On March 4, 2014, 8:28 p.m., Kevin Ottens wrote:
src/karchive.h, line 32
https://git.reviewboard.kde.org/r/115977/diff/1/?file=245721#file245721line32
Hm, why the change to for the includes? We try to stick to in
public headers.
Any news?
- Kevin
On Feb. 25, 2014, 12:10 p.m., David Faure wrote:
The part of the description that says if accepted will modify kstyle as
well doesn't really make sense anymore (to fix if it's in your commit log
too).
The bit I'm not sure about is: using MainToolbar icon style everywhere ...
how
On March 4, 2014, 8:48 p.m., Kevin Ottens wrote:
Ship It!
Any news? Anything blocking this patch from being committed?
- Kevin
---
This is an automatically generated e-mail. To reply, visit:
On Feb. 19, 2014, 2:07 p.m., Alex Merry wrote:
I don't think papering over the X11-ness of kdesu like this is the right
approach. Of course, what this framework really needs is a test app; maybe
a simple port of the kdesu app from kde-runtime?
Kevin Ottens wrote:
This kind of
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116684/#review52783
---
src/kcompletionbase.h
On March 4, 2014, 8:45 p.m., Kevin Ottens wrote:
And I agree with Aurélien, a bug should be filed and Stephen involved in
that issue.
Stephen Kelly wrote:
Please provide a minimal testcase. The feature is unit tested in cmake.
If it's broken, it needs to be fixed soon (before the
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116670/#review52788
---
Ship it!
Ship It!
- Kevin Ottens
On March 9, 2014, 2:39
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116725/#review52793
---
Ship it!
Ship It!
- Kevin Ottens
On March 11, 2014, 4:33
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116724/#review52791
---
Ship it!
Ship It!
- Kevin Ottens
On March 11, 2014, 4:28
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116727/#review52795
---
Ship it!
Ship It!
- Kevin Ottens
On March 11, 2014, 4:50
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116739/#review52797
---
Ship it!
Ship It!
- Kevin Ottens
On March 11, 2014, 7:42
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116685/#review52798
---
Ship it!
Ship It!
- Kevin Ottens
On March 10, 2014, 5:46
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116760/
---
(Updated March 12, 2014, 3:44 p.m.)
Review request for KDE Frameworks
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116760/#review52801
---
I think it's fine indeed. Let's see what David think about
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116766/
---
(Updated March 12, 2014, 3:47 p.m.)
Review request for KDE Frameworks
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116766/#review52804
---
Looks fine to me.
- Kevin Ottens
On March 12, 2014, 3:47
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116735/#review52806
---
Ship it!
Ship It!
- Kevin Ottens
On March 12, 2014, 2:51
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116767/#review52807
---
Ship it!
Ship It!
- Kevin Ottens
On March 12, 2014, 2:57
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116768/
---
Review request for KDE Frameworks and Aurélien Gâteau.
Repository:
On March 1, 2014, 4:17 p.m., David Faure wrote:
Hmm, this might be equivalent, but all it means is that the orig code was
wrong.
We should not make any memory allocations within the crash handler.
So we should instead store the startup id as a const char* somewhere and
use
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116724/#review52820
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116725/
---
(Updated March 12, 2014, 4:48 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116726/
---
(Updated March 12, 2014, 4:49 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116726/#review52822
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116727/#review52823
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116727/
---
(Updated March 12, 2014, 4:50 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116728/#review52824
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116728/
---
(Updated March 12, 2014, 4:51 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116739/#review52826
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116759/
---
(Updated March 12, 2014, 4:53 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116759/#review52827
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116725/#review52821
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116735/#review52828
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116735/
---
(Updated March 12, 2014, 4:55 p.m.)
Status
--
This change has been
See http://build.kde.org/job/kio_master_qt5/100/changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116767/
---
(Updated March 12, 2014, 4:58 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116767/#review52829
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116768/#review52830
---
Ship it!
Ship It!
- Alex Merry
On March 12, 2014, 3:49
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116760/#review52831
---
well I'm still hoping some sort of migration of the useful
On March 4, 2014, 8:45 p.m., Kevin Ottens wrote:
And I agree with Aurélien, a bug should be filed and Stephen involved in
that issue.
Stephen Kelly wrote:
Please provide a minimal testcase. The feature is unit tested in cmake.
If it's broken, it needs to be fixed soon (before the
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116670/#review52838
---
This review has been submitted with commit
On March 4, 2014, 8:48 p.m., Kevin Ottens wrote:
Ship It!
Kevin Ottens wrote:
Any news? Anything blocking this patch from being committed?
Well I still need to fix the i18n issues and change up the entities a little
bit to reflect the feedback to
On March 11, 2014, 11:17 p.m., Aleix Pol Gonzalez wrote:
src/kcompletionbox.h, line 228
https://git.reviewboard.kde.org/r/116747/diff/1/?file=253404#file253404line228
I wouldn't leave the implementation here. Move it to the .cpp file,
this way it can be changed in the future, if
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116747/
---
(Updated March 12, 2014, 10:54 p.m.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116747/
---
(Updated March 12, 2014, 10:57 p.m.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116684/
---
(Updated March 12, 2014, 11:06 p.m.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116685/#review52856
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116685/#review52855
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116685/
---
(Updated March 13, 2014, 12:48 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116685/
---
(Updated March 13, 2014, 12:48 a.m.)
Status
--
This change has been
See http://build.kde.org/job/kdelibs_stable/1038/
--
Started by remote host 127.0.0.1 with note: Triggered by commit
Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace
http://build.kde.org/job/kdelibs_stable/ws/
Running Prebuild steps
79 matches
Mail list logo
