Re: Does KKeyserver QT_TR_NOOP work?
On Monday 31 March 2014 00:09:18 Albert Astals Cid wrote: Running lupdate complains so I'm not sure it does /home/scripty/prod/git- unstable/frameworks_kwindowsystem/src/kkeyserver_x11.cpp:88: Class 'KKeyServer' lacks Q_OBJECT macro on a quick check it looks like unused code. Will try to remove it. Cheers Martin signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117196: Remove unused global variable from kkeyserver_x11.cpp
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117196/ --- Review request for KDE Frameworks and Albert Astals Cid. Repository: kwindowsystem Description --- Remove unused global variable from kkeyserver_x11.cpp Diffs - src/kkeyserver_x11.cpp 0600240ecf6519f671f7152a6403911342e74d27 Diff: https://git.reviewboard.kde.org/r/117196/diff/ Testing --- compiles Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117197: Fix warnings caused by changing to enum types in NET classes
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117197/ --- Review request for KDE Frameworks. Repository: kwindowsystem Description --- Fix warnings caused by changing to enum types in NET classes KWindowSystem framework was internally still using the now deprecated methods. There is one usage left in kwindowsystem_x11 which is not yet under unit tests. Diffs - autotests/netwininfotestwm.cpp f98f4864cb06fceb89f8321730cacfeabc640b84 src/kstartupinfo.cpp 65928b731284ed0c9cf2ae8e3c53d3f2886c20ed src/kwindoweffects_x11.cpp d1c60322aa56c9527f3ac6f1f21b1a151668f50f src/kwindowinfo_x11.cpp c4d8a45c156fff07aa11d6294617dbba89204d70 src/kwindowsystem_x11.cpp eb0ad2e4e1d10f1eed55f63319b118bfa88a88d1 src/netwm.cpp 7fda3d6632da8c5770f2eac01d0a44d0760fc93f autotests/kwindowinfox11test.cpp 4f145ca2837854af24e79930b04fce933199ded9 autotests/netrootinfotestwm.cpp 24137cb1ad7c9ce25bb5b1e2685f853932fe1df7 autotests/netwininfotestclient.cpp 196862c2901010802189db29c55af6b383aba7e3 Diff: https://git.reviewboard.kde.org/r/117197/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Lots of duplicated catalogs
I am on it. On Sun, Mar 30, 2014, at 15:15, Albert Astals Cid wrote: $ find -name kdecalendarsystems.pot ./frameworks/kdecalendarsystems.pot ./kdelibs/kdecalendarsystems.pot $ find -name kdelibs_colors4.pot ./frameworks/kdelibs_colors4.pot ./kdelibs/kdelibs_colors4.pot $ find -name kdesud.pot ./frameworks/kdesud.pot ./kde-runtime/kdesud.pot $ find -name kio_help4.pot ./frameworks/kio_help4.pot ./kdelibs/kio_help4.pot $ find -name kpasswdserver.pot ./frameworks/kpasswdserver.pot ./kde-runtime/kpasswdserver.pot $ find -name solid_qt.pot ./frameworks/solid_qt.pot ./kdelibs/solid_qt.pot $ find -name timezones4.pot ./frameworks/timezones4.pot ./kdelibs/timezones4.pot $ find -name xml_mimetypes.pot ./frameworks/xml_mimetypes.pot ./kdelibs/xml_mimetypes.pot Please fix. Cheers, Albert ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Lots of duplicated catalogs
On Sun, Mar 30, 2014, at 15:15, Albert Astals Cid wrote: $ find -name kdecalendarsystems.pot ./frameworks/kdecalendarsystems.pot ./kdelibs/kdecalendarsystems.pot Renamed to kdecalendarsystems5.pot $ find -name kdelibs_colors4.pot ./frameworks/kdelibs_colors4.pot ./kdelibs/kdelibs_colors4.pot Renamed to kdelibs_colors5.pot $ find -name kdesud.pot ./frameworks/kdesud.pot ./kde-runtime/kdesud.pot Renamed to kdesud5.pot, but the binary needs renaming as well. $ find -name kio_help4.pot ./frameworks/kio_help4.pot ./kdelibs/kio_help4.pot Renamed to kio_help5.pot $ find -name kpasswdserver.pot ./frameworks/kpasswdserver.pot ./kde-runtime/kpasswdserver.pot Renamed to kpasswdserver5.pot, but the binary needs renaming as well. $ find -name solid_qt.pot ./frameworks/solid_qt.pot ./kdelibs/solid_qt.pot Renamed to solid5.pot $ find -name timezones4.pot ./frameworks/timezones4.pot ./kdelibs/timezones4.pot Renamed to timezones5.pot $ find -name xml_mimetypes.pot ./frameworks/xml_mimetypes.pot ./kdelibs/xml_mimetypes.pot Can't find this one, neither on my machine nor using lxr. Do you know where it comes from? Aurélien ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Lots of duplicated catalogs
Am Montag, 31. März 2014, 02:40:48 schrieb Aurélien Gâteau: On Sun, Mar 30, 2014, at 15:15, Albert Astals Cid wrote: $ find -name xml_mimetypes.pot ./frameworks/xml_mimetypes.pot ./kdelibs/xml_mimetypes.pot Can't find this one, neither on my machine nor using lxr. Do you know where it comes from? Generated in kcoreaddons/src/mimetypes/XmlMessages.sh line 10 -- Burkhard Lück ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Translation support in Qt-translation-based frameworks
Hi, I just committed the necessary build system changes to enable all Qt-translation-based frameworks to build, install and load their translations. This means the following frameworks: kauth kbookmarks kcodecs kcompletion kcoreaddons kcrash kdbusaddons kdesignerplugin kdnssd kglobalaccel kitemviews kjobwidgets knotifications kwidgetsaddons solid sonnet If you maintain one of those frameworks, please have a look at the changes. They were partly automated, so may not match exactly the way you like things to be named or indented. I smoke-tested those which provided manual tests to exercise part of the translated UI. This is the list of frameworks for which I found a way to test: kbookmarks kcompletion kcoreaddons kdesignerplugin kitemviews kjobwidgets knotifications kwidgetsaddons sonnet To test translations: 1. Generate a .pot file by following those instructions: http://techbase.kde.org/Development/Tutorials/Localization/i18n_Build_Systems#Testing_your_Messages.sh_script 2. Create a translation file: cd po cp myframework.pot myframework-fr.po (or -de, -es, -pt...) 3. Edit myframework-fr.po with Lokalize or your text editor, translate strings of interest (no need to translate all, this is just for testing) 4. Rerun cmake so that it notices the new po dir (touch CMakeLists.txt should do) 5. Run make and make install 6. Run the code to test, your translations should appear Do not commit the po/ dir, it will be generated at release time from the kde translation infrastructure. Aurélien ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116037: change entities to reflect new branding
On March 4, 2014, 8:48 p.m., Kevin Ottens wrote: Ship It! Kevin Ottens wrote: Any news? Anything blocking this patch from being committed? T.C. Hollingsworth wrote: Well I still need to fix the i18n issues and change up the entities a little bit to reflect the feedback to https://mail.kde.org/pipermail/kde-frameworks-devel/2014-February/012182.html Plus I've been a bit too busy to even reply to list mail. :-( Will try and finish this up by the end of the week. Luigi Toscano wrote: Ping? Friday 28th is the tag date for beta1. Kevin Ottens wrote: And that's tomorrow. I'll probably discard the patch if it doesn't make it for beta1 tagging. It'll need to be reopened later in that case... Luigi Toscano wrote: Why discard? It is not SIC, it could go in after beta1. Sure, it's just that I try to prune reviews with lack of activity. Otherwise the list would never end growing. :-) So any news? Last warning, I'll discard on my next review round. - Kevin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116037/#review51948 --- On Feb. 25, 2014, 1:02 a.m., T.C. Hollingsworth wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116037/ --- (Updated Feb. 25, 2014, 1:02 a.m.) Review request for Documentation, KDE Frameworks, Luigi Toscano, Burkhard Lück, and Yuri Chornoivan. Repository: kdoctools Description --- -kde; is no longer semantically identified as an acronym, but instead as an organization -new translatable entities for KDE Frameworks are added -new translatable entities for the KDE SC are added -new translatable entities for the various incarnations of Plasma are added with this I can finally kill the temporary entities that have been in kde-runtime.git/doc/fundamentals for over a year now. :-) Diffs - src/customization/en/user.entities 47bfe0d src/customization/entities/general.entities 183fbc9 Diff: https://git.reviewboard.kde.org/r/116037/diff/ Testing --- kdoctools still builds, kate docs still meinproc5 successfully Thanks, T.C. Hollingsworth ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117070: remove check for Linux kernel = 2.6.14
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117070/#review54680 --- Ship it! Ship It! - Kevin Ottens On March 25, 2014, 10:22 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117070/ --- (Updated March 25, 2014, 10:22 p.m.) Review request for KDE Frameworks. Repository: kcoreaddons Description --- remove check for Linux kernel = 2.6.14 That kernel was relase on the 28 of October 2005, we can safely assume everyone running KF5 has a newer kernel version. Diffs - src/lib/io/kdirwatch.cpp 3c1e851151955ff9dc48bd2b6bbe71f430b680b6 Diff: https://git.reviewboard.kde.org/r/117070/diff/ Testing --- Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117122: Cut the dependency between country files and KIO
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117122/#review54681 --- Ship it! Ship It! - Kevin Ottens On March 27, 2014, 6:42 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117122/ --- (Updated March 27, 2014, 6:42 p.m.) Review request for KDE Frameworks, Albert Astals Cid and John Layt. Repository: kio Description --- I was going through the kde-runtime localization thread again [1] and decided to start looking into it. As Albert pointed out, there's many modules making use of these, one would be KIO. I looked into the actual dependency and saw that it's rather small so decided to just drop it. In this case it's using the country/entry.desktop file to check what binary format to use, but then it seems like no entry.desktop file is specifying it [2], so it's a bit of an absurd configuration settings. I just changed it to stop reading the value. [1] https://www.mail-archive.com/kde-frameworks-devel@kde.org/msg11839.html [2] ~/kde5/share/locale/l10n$ grep -R BinaryUnitDialect C/entry.desktop:BinaryUnitDialect=0 Diffs - src/core/global.cpp 99ab2e7 Diff: https://git.reviewboard.kde.org/r/117122/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Translation support in Qt-translation-based frameworks
On 31/03/14 15:30, Aurélien Gâteau wrote: Do not commit the po/ dir, it will be generated at release time from the kde translation infrastructure. Should go in .gitignore, yes? Alex ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117150: use renamed kf5_entry.desktop file
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117150/#review54682 --- Ship it! Ship It! - Kevin Ottens On March 28, 2014, 7:24 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117150/ --- (Updated March 28, 2014, 7:24 p.m.) Review request for KDE Frameworks and Aleix Pol Gonzalez. Repository: kxmlgui Description --- entry.desktop got renamed, use the renamed file https://git.reviewboard.kde.org/r/117087/ Diffs - src/khelpmenu.cpp 4f6ce7b Diff: https://git.reviewboard.kde.org/r/117150/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117151: use renamed kf5_entry.desktop file
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117151/#review54683 --- Ship it! Ship It! - Kevin Ottens On March 28, 2014, 7:26 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117151/ --- (Updated March 28, 2014, 7:26 p.m.) Review request for KDE Frameworks and Aleix Pol Gonzalez. Repository: kde4support Description --- entry.desktop got renamed, use the renamed file https://git.reviewboard.kde.org/r/117087/ Diffs - autotests/klocaletimeformattest.cpp c965cac Diff: https://git.reviewboard.kde.org/r/117151/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117134: Use QLocale to list all languages
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117134/ --- (Updated March 31, 2014, 2:40 p.m.) Status -- This change has been discarded. Review request for KDE Frameworks, Albert Astals Cid and Chusslove Illich. Repository: kconfigwidgets Description --- Instead of finding the entries.desktop files in the file-system, use QLocale languages to list all languages. Anybody knows if bcp47 compatible with our language naming scheme yet? Diffs - src/klanguagebutton.cpp 9f0c055 Diff: https://git.reviewboard.kde.org/r/117134/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Translation support in Qt-translation-based frameworks
On Mon, Mar 31, 2014, at 7:38, Alex Merry wrote: On 31/03/14 15:30, Aurélien Gâteau wrote: Do not commit the po/ dir, it will be generated at release time from the kde translation infrastructure. Should go in .gitignore, yes? Good idea. Aurélien ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117160: solid-hardware: rename for co-installability with kdelibs4
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117160/#review54685 --- Not sure about renaming that one, it's perfectly fine to have only one of the two installed. - Kevin Ottens On March 29, 2014, 4:06 p.m., Heiko Becker wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117160/ --- (Updated March 29, 2014, 4:06 p.m.) Review request for KDE Frameworks. Repository: solid Description --- kde-runtime4 also installs solid-hardware, so rename it to solid-hardware5 for KF5. Diffs - src/tools/solid-hardware/CMakeLists.txt 7cb604e7bdbee605ecf71e38b050fc8841df8eb9 Diff: https://git.reviewboard.kde.org/r/117160/diff/ Testing --- Built and installed alongside kde-runtime4 Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117160: solid-hardware: rename for co-installability with kdelibs4
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117160/ --- (Updated March 31, 2014, 2:44 p.m.) Review request for KDE Frameworks and Àlex Fiestas. Changes --- Let's see Alex opinion on that one. Repository: solid Description --- kde-runtime4 also installs solid-hardware, so rename it to solid-hardware5 for KF5. Diffs - src/tools/solid-hardware/CMakeLists.txt 7cb604e7bdbee605ecf71e38b050fc8841df8eb9 Diff: https://git.reviewboard.kde.org/r/117160/diff/ Testing --- Built and installed alongside kde-runtime4 Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117185: Remove KPluginLoader dependency on KService
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117185/#review54686 --- Couple of nitpicks, overall I like where this is going. src/plugin/kpluginloader.h https://git.reviewboard.kde.org/r/117185/#comment38217 Why is this class all inlined? src/plugin/kpluginloader.h https://git.reviewboard.kde.org/r/117185/#comment38216 I'm confused, is that a path or a name? - Kevin Ottens On March 30, 2014, 11:41 a.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117185/ --- (Updated March 30, 2014, 11:41 a.m.) Review request for KDE Frameworks, David Faure, Kevin Ottens, and Sebastian Kügler. Repository: kservice Description --- Remove KPluginLoader dependency on KService The reason for this is so that KPluginLoader, KPluginFactory and kexportplugin.h do not require anything else from the KService framework, allowing them to be moved to KCoreAddons. A KPluginName class is introduced to act as an intermediary between KService and KPluginLoader. The KPluginLoader(KService) constructor is replaced with KPluginLoader(KPluginName), and KService gains a cast operator to convert it to a KPluginName. Now KService service(blah.desktop); KPluginLoader(service); works as before, maintaining source compatibility. The reason for the intermediary class (rather than just, say, providing a QString() operator to KService) is to make sure this combination is the only one that works (and you can't start using KService everywhere a QString is expected). Diffs - autotests/CMakeLists.txt dcc4a40bd81f7e17f10219649214a8c9aac5cc60 autotests/jsonplugin.h PRE-CREATION autotests/jsonplugin.cpp PRE-CREATION autotests/jsonplugin.json PRE-CREATION autotests/kpluginloadertest.cpp 2b0afb81469f18f93ea43e6ac73df95a60cbd7f3 autotests/kservicetest.h aa1c691c75c9e5b6903bcbf6e2dc95809ee1ce21 autotests/kservicetest.cpp 796abbcc6313d2cfd69bd213281ea30dfebaa421 autotests/noplugin.desktop PRE-CREATION src/plugin/kpluginloader.h 4e10edf0f152b409c6a4031610ff1f2f9771d08d src/plugin/kpluginloader.cpp 1602c180db5e1a5f0765d95d68f90d2046c9ef2b src/services/kservice.h 6df389a130587eea732b1d81718181bbd3df4f6d src/services/kservice.cpp c897d4c2a08d048e817154101b3a212a098f9768 Diff: https://git.reviewboard.kde.org/r/117185/diff/ Testing --- Builds, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117190: Improve tests
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117190/#review54687 --- Ship it! Ship It! - Kevin Ottens On March 30, 2014, 3:15 p.m., Michael Palimaka wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117190/ --- (Updated March 30, 2014, 3:15 p.m.) Review request for KDE Frameworks. Repository: kde4support Description --- Make it possible to avoid building tests. QtConcurrent is only required for tests. Diffs - CMakeLists.txt 71fe6d6158eaaba18ffc55d1489d9e9edc84a242 autotests/CMakeLists.txt 91e3db469cfa508be9659f0f977d03454a2144dd Diff: https://git.reviewboard.kde.org/r/117190/diff/ Testing --- Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117190: Improve tests
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117190/#review54689 --- This review has been submitted with commit 86205d8fb815210244bbf9e8fa12b86ebb196100 by Michael Palimaka to branch master. - Commit Hook On March 30, 2014, 3:15 p.m., Michael Palimaka wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117190/ --- (Updated March 30, 2014, 3:15 p.m.) Review request for KDE Frameworks. Repository: kde4support Description --- Make it possible to avoid building tests. QtConcurrent is only required for tests. Diffs - CMakeLists.txt 71fe6d6158eaaba18ffc55d1489d9e9edc84a242 autotests/CMakeLists.txt 91e3db469cfa508be9659f0f977d03454a2144dd Diff: https://git.reviewboard.kde.org/r/117190/diff/ Testing --- Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117190: Improve tests
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117190/ --- (Updated March 31, 2014, 2:52 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kde4support Description --- Make it possible to avoid building tests. QtConcurrent is only required for tests. Diffs - CMakeLists.txt 71fe6d6158eaaba18ffc55d1489d9e9edc84a242 autotests/CMakeLists.txt 91e3db469cfa508be9659f0f977d03454a2144dd Diff: https://git.reviewboard.kde.org/r/117190/diff/ Testing --- Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117012: Place KJsEmbed camelcase header under ${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed
On March 27, 2014, 3:47 p.m., Kevin Ottens wrote:
src/kjsembed/CMakeLists.txt, line 75
https://git.reviewboard.kde.org/r/117012/diff/1/?file=256496#file256496line75
Agreed, that should be the preferred way.
Note that some other frameworks probably carry the same mistake
Andrius da Costa Ribas wrote:
I'll update the patch as per Cristophe's and Aleix's comments.
From what I can see from the frameworks I've built on Windows at the
moment (all tier1 and most tier2), most of them has
include/KF5/FrameworkName/headers, except:
Attica (include/KF5/Attica/Attica/headers)
KDNSSD (include/KF5/KDNSSD/DNSSD/headers)
Solid (include/KF5/Solid/Solid/headers)
ThreadWeaver (include/KF5/ThreadWeaver/ThreadWeaver/headers)
*Sonnet (include/Kf5/SonnetCore/Sonnet/headers and
include/Kf5/SonnetUi/Sonnet/headers)
*KDocTools (include/KF5/XsltKde/headers)
Can we consider fixing those too? (I'm just not sure about the ones I
marked with *)
No, that's actually fine. We have a different convention for frameworks having
K* classes and frameworks which are namespaced (like solid, threadweaver, etc.)
- Kevin
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117012/#review54308
---
On March 24, 2014, 1:33 a.m., Andrius da Costa Ribas wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117012/
---
(Updated March 24, 2014, 1:33 a.m.)
Review request for KDE Frameworks and kdewin.
Repository: kjsembed
Description
---
Currently kjsembed CMake file tries to install both
${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed (directory) and
${INCLUDE_INSTALL_DIR}/KJsEmbed/KJsEmbed (camel case header). This is not
allowed in a case-insensitive filesystem, causing the install step to fail on
Windows.
Diffs
-
src/kjsembed/CMakeLists.txt e0ab74c
Diff: https://git.reviewboard.kde.org/r/117012/diff/
Testing
---
Tested using MSVC 2013
Thanks,
Andrius da Costa Ribas
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117196: Remove unused global variable from kkeyserver_x11.cpp
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117196/#review54692 --- Ship it! Ship It! - Kevin Ottens On March 31, 2014, 7:45 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117196/ --- (Updated March 31, 2014, 7:45 a.m.) Review request for KDE Frameworks and Albert Astals Cid. Repository: kwindowsystem Description --- Remove unused global variable from kkeyserver_x11.cpp Diffs - src/kkeyserver_x11.cpp 0600240ecf6519f671f7152a6403911342e74d27 Diff: https://git.reviewboard.kde.org/r/117196/diff/ Testing --- compiles Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117195: [kio] Replace COULD_NOT with CANNOT in the error code enum
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117195/ --- (Updated March 31, 2014, 2:55 p.m.) Review request for KDE Frameworks and David Faure. Changes --- Looks fine to me, but let's see what dfaure thinks about it. Repository: kio Description --- Use the new name for the error codes ERR_COULD_NOT_* has been replaced with ERR_CANNOT_*. Replace COULD_NOT with CANNOT in the error code enum This makes the error code names more consistent. The old versions are kept for backwards-compatibility. Diffs - src/core/global.h be8e5481c8146c2d0737be06f034cdccc1573f79 src/core/job_error.cpp 1ec28c5d9ebdbc2045743c566f473c8cfa02e1bd src/ioslaves/http/http.cpp 3158628af2dc8ee88a0ac0d968748d6b50a8da33 src/ioslaves/help/kio_help.cpp df3e934b5cac7428bd1525d5de1b3fedd9b16394 src/ioslaves/ftp/ftp.cpp 49037701772f88e9a96bc3110f1f04fccb810ca8 src/ioslaves/file/file_unix.cpp bb4d6003985269464c380927d51eaf9ed602ade1 src/ioslaves/file/file.cpp 6387d7f29df2c0a26952be5255438361c37ed082 src/core/tcpslavebase.cpp ea0434e19a7fb35cc708dece1ff904d6739aa4de src/core/slavebase.h 4726915da0757c64ab735f586142806891b517d1 src/widgets/accessmanagerreply_p.cpp 4322e0275f57f10aeba2ea8381f53d06f6b6fe25 Diff: https://git.reviewboard.kde.org/r/117195/diff/ Testing --- Builds, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117197: Fix warnings caused by changing to enum types in NET classes
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117197/#review54693 --- Ship it! Ship It! - Kevin Ottens On March 31, 2014, 8:17 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117197/ --- (Updated March 31, 2014, 8:17 a.m.) Review request for KDE Frameworks. Repository: kwindowsystem Description --- Fix warnings caused by changing to enum types in NET classes KWindowSystem framework was internally still using the now deprecated methods. There is one usage left in kwindowsystem_x11 which is not yet under unit tests. Diffs - autotests/netwininfotestwm.cpp f98f4864cb06fceb89f8321730cacfeabc640b84 src/kstartupinfo.cpp 65928b731284ed0c9cf2ae8e3c53d3f2886c20ed src/kwindoweffects_x11.cpp d1c60322aa56c9527f3ac6f1f21b1a151668f50f src/kwindowinfo_x11.cpp c4d8a45c156fff07aa11d6294617dbba89204d70 src/kwindowsystem_x11.cpp eb0ad2e4e1d10f1eed55f63319b118bfa88a88d1 src/netwm.cpp 7fda3d6632da8c5770f2eac01d0a44d0760fc93f autotests/kwindowinfox11test.cpp 4f145ca2837854af24e79930b04fce933199ded9 autotests/netrootinfotestwm.cpp 24137cb1ad7c9ce25bb5b1e2685f853932fe1df7 autotests/netwininfotestclient.cpp 196862c2901010802189db29c55af6b383aba7e3 Diff: https://git.reviewboard.kde.org/r/117197/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117150: use renamed kf5_entry.desktop file
On March 31, 2014, 2:39 p.m., Kevin Ottens wrote: Ship It! Actually scrap that, seeing the confusion around those files I might have been mistaken myself. - Kevin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117150/#review54682 --- On March 28, 2014, 7:24 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117150/ --- (Updated March 28, 2014, 7:24 p.m.) Review request for KDE Frameworks and Aleix Pol Gonzalez. Repository: kxmlgui Description --- entry.desktop got renamed, use the renamed file https://git.reviewboard.kde.org/r/117087/ Diffs - src/khelpmenu.cpp 4f6ce7b Diff: https://git.reviewboard.kde.org/r/117150/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117151: use renamed kf5_entry.desktop file
On March 31, 2014, 2:39 p.m., Kevin Ottens wrote: Ship It! Actually scrap that, seeing the confusion around those files I might have been mistaken myself. - Kevin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117151/#review54683 --- On March 28, 2014, 7:26 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117151/ --- (Updated March 28, 2014, 7:26 p.m.) Review request for KDE Frameworks and Aleix Pol Gonzalez. Repository: kde4support Description --- entry.desktop got renamed, use the renamed file https://git.reviewboard.kde.org/r/117087/ Diffs - autotests/klocaletimeformattest.cpp c965cac Diff: https://git.reviewboard.kde.org/r/117151/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117185: Remove KPluginLoader dependency on KService
On March 31, 2014, 2:49 p.m., Kevin Ottens wrote: src/plugin/kpluginloader.h, line 305 https://git.reviewboard.kde.org/r/117185/diff/2/?file=258191#file258191line305 Why is this class all inlined? Because it's a pretty trivial container class. It was patterned off things like QDBusObjectPath, although that is even simpler (except for the code that checks it is a valid D-Bus object path, which isn't inlined). On March 31, 2014, 2:49 p.m., Kevin Ottens wrote: src/plugin/kpluginloader.h, line 359 https://git.reviewboard.kde.org/r/117185/diff/2/?file=258191#file258191line359 I'm confused, is that a path or a name? Ah, good point. That should be m_name. - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117185/#review54686 --- On March 30, 2014, 11:41 a.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117185/ --- (Updated March 30, 2014, 11:41 a.m.) Review request for KDE Frameworks, David Faure, Kevin Ottens, and Sebastian Kügler. Repository: kservice Description --- Remove KPluginLoader dependency on KService The reason for this is so that KPluginLoader, KPluginFactory and kexportplugin.h do not require anything else from the KService framework, allowing them to be moved to KCoreAddons. A KPluginName class is introduced to act as an intermediary between KService and KPluginLoader. The KPluginLoader(KService) constructor is replaced with KPluginLoader(KPluginName), and KService gains a cast operator to convert it to a KPluginName. Now KService service(blah.desktop); KPluginLoader(service); works as before, maintaining source compatibility. The reason for the intermediary class (rather than just, say, providing a QString() operator to KService) is to make sure this combination is the only one that works (and you can't start using KService everywhere a QString is expected). Diffs - autotests/CMakeLists.txt dcc4a40bd81f7e17f10219649214a8c9aac5cc60 autotests/jsonplugin.h PRE-CREATION autotests/jsonplugin.cpp PRE-CREATION autotests/jsonplugin.json PRE-CREATION autotests/kpluginloadertest.cpp 2b0afb81469f18f93ea43e6ac73df95a60cbd7f3 autotests/kservicetest.h aa1c691c75c9e5b6903bcbf6e2dc95809ee1ce21 autotests/kservicetest.cpp 796abbcc6313d2cfd69bd213281ea30dfebaa421 autotests/noplugin.desktop PRE-CREATION src/plugin/kpluginloader.h 4e10edf0f152b409c6a4031610ff1f2f9771d08d src/plugin/kpluginloader.cpp 1602c180db5e1a5f0765d95d68f90d2046c9ef2b src/services/kservice.h 6df389a130587eea732b1d81718181bbd3df4f6d src/services/kservice.cpp c897d4c2a08d048e817154101b3a212a098f9768 Diff: https://git.reviewboard.kde.org/r/117185/diff/ Testing --- Builds, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117185: Remove KPluginLoader dependency on KService
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117185/ --- (Updated March 31, 2014, 3:34 p.m.) Review request for KDE Frameworks, David Faure, Kevin Ottens, and Sebastian Kügler. Changes --- m_path - m_name Repository: kservice Description --- Remove KPluginLoader dependency on KService The reason for this is so that KPluginLoader, KPluginFactory and kexportplugin.h do not require anything else from the KService framework, allowing them to be moved to KCoreAddons. A KPluginName class is introduced to act as an intermediary between KService and KPluginLoader. The KPluginLoader(KService) constructor is replaced with KPluginLoader(KPluginName), and KService gains a cast operator to convert it to a KPluginName. Now KService service(blah.desktop); KPluginLoader(service); works as before, maintaining source compatibility. The reason for the intermediary class (rather than just, say, providing a QString() operator to KService) is to make sure this combination is the only one that works (and you can't start using KService everywhere a QString is expected). Diffs (updated) - autotests/CMakeLists.txt dcc4a40bd81f7e17f10219649214a8c9aac5cc60 autotests/jsonplugin.h PRE-CREATION autotests/jsonplugin.cpp PRE-CREATION autotests/jsonplugin.json PRE-CREATION autotests/kpluginloadertest.cpp 2b0afb81469f18f93ea43e6ac73df95a60cbd7f3 autotests/kservicetest.h aa1c691c75c9e5b6903bcbf6e2dc95809ee1ce21 autotests/kservicetest.cpp 796abbcc6313d2cfd69bd213281ea30dfebaa421 autotests/noplugin.desktop PRE-CREATION src/plugin/kpluginloader.h 4e10edf0f152b409c6a4031610ff1f2f9771d08d src/plugin/kpluginloader.cpp 1602c180db5e1a5f0765d95d68f90d2046c9ef2b src/services/kservice.h 6df389a130587eea732b1d81718181bbd3df4f6d src/services/kservice.cpp c897d4c2a08d048e817154101b3a212a098f9768 Diff: https://git.reviewboard.kde.org/r/117185/diff/ Testing --- Builds, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117185: Remove KPluginLoader dependency on KService
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117185/#review54701 --- Ship it! Ship It! - Kevin Ottens On March 31, 2014, 3:34 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117185/ --- (Updated March 31, 2014, 3:34 p.m.) Review request for KDE Frameworks, David Faure, Kevin Ottens, and Sebastian Kügler. Repository: kservice Description --- Remove KPluginLoader dependency on KService The reason for this is so that KPluginLoader, KPluginFactory and kexportplugin.h do not require anything else from the KService framework, allowing them to be moved to KCoreAddons. A KPluginName class is introduced to act as an intermediary between KService and KPluginLoader. The KPluginLoader(KService) constructor is replaced with KPluginLoader(KPluginName), and KService gains a cast operator to convert it to a KPluginName. Now KService service(blah.desktop); KPluginLoader(service); works as before, maintaining source compatibility. The reason for the intermediary class (rather than just, say, providing a QString() operator to KService) is to make sure this combination is the only one that works (and you can't start using KService everywhere a QString is expected). Diffs - autotests/CMakeLists.txt dcc4a40bd81f7e17f10219649214a8c9aac5cc60 autotests/jsonplugin.h PRE-CREATION autotests/jsonplugin.cpp PRE-CREATION autotests/jsonplugin.json PRE-CREATION autotests/kpluginloadertest.cpp 2b0afb81469f18f93ea43e6ac73df95a60cbd7f3 autotests/kservicetest.h aa1c691c75c9e5b6903bcbf6e2dc95809ee1ce21 autotests/kservicetest.cpp 796abbcc6313d2cfd69bd213281ea30dfebaa421 autotests/noplugin.desktop PRE-CREATION src/plugin/kpluginloader.h 4e10edf0f152b409c6a4031610ff1f2f9771d08d src/plugin/kpluginloader.cpp 1602c180db5e1a5f0765d95d68f90d2046c9ef2b src/services/kservice.h 6df389a130587eea732b1d81718181bbd3df4f6d src/services/kservice.cpp c897d4c2a08d048e817154101b3a212a098f9768 Diff: https://git.reviewboard.kde.org/r/117185/diff/ Testing --- Builds, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
kcrash test failure
Anyone seen this test failure in kcrash? I only get it on i386 http://paste.kde.org/pccpojfwd Jonathan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117185: Remove KPluginLoader dependency on KService
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117185/ --- (Updated March 31, 2014, 4:23 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, David Faure, Kevin Ottens, and Sebastian Kügler. Repository: kservice Description --- Remove KPluginLoader dependency on KService The reason for this is so that KPluginLoader, KPluginFactory and kexportplugin.h do not require anything else from the KService framework, allowing them to be moved to KCoreAddons. A KPluginName class is introduced to act as an intermediary between KService and KPluginLoader. The KPluginLoader(KService) constructor is replaced with KPluginLoader(KPluginName), and KService gains a cast operator to convert it to a KPluginName. Now KService service(blah.desktop); KPluginLoader(service); works as before, maintaining source compatibility. The reason for the intermediary class (rather than just, say, providing a QString() operator to KService) is to make sure this combination is the only one that works (and you can't start using KService everywhere a QString is expected). Diffs - autotests/CMakeLists.txt dcc4a40bd81f7e17f10219649214a8c9aac5cc60 autotests/jsonplugin.h PRE-CREATION autotests/jsonplugin.cpp PRE-CREATION autotests/jsonplugin.json PRE-CREATION autotests/kpluginloadertest.cpp 2b0afb81469f18f93ea43e6ac73df95a60cbd7f3 autotests/kservicetest.h aa1c691c75c9e5b6903bcbf6e2dc95809ee1ce21 autotests/kservicetest.cpp 796abbcc6313d2cfd69bd213281ea30dfebaa421 autotests/noplugin.desktop PRE-CREATION src/plugin/kpluginloader.h 4e10edf0f152b409c6a4031610ff1f2f9771d08d src/plugin/kpluginloader.cpp 1602c180db5e1a5f0765d95d68f90d2046c9ef2b src/services/kservice.h 6df389a130587eea732b1d81718181bbd3df4f6d src/services/kservice.cpp c897d4c2a08d048e817154101b3a212a098f9768 Diff: https://git.reviewboard.kde.org/r/117185/diff/ Testing --- Builds, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117185: Remove KPluginLoader dependency on KService
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117185/#review54704 --- This review has been submitted with commit 953f6afab51bc2249be9cd73ff1c59b0092afdea by Alex Merry to branch master. - Commit Hook On March 31, 2014, 3:34 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117185/ --- (Updated March 31, 2014, 3:34 p.m.) Review request for KDE Frameworks, David Faure, Kevin Ottens, and Sebastian Kügler. Repository: kservice Description --- Remove KPluginLoader dependency on KService The reason for this is so that KPluginLoader, KPluginFactory and kexportplugin.h do not require anything else from the KService framework, allowing them to be moved to KCoreAddons. A KPluginName class is introduced to act as an intermediary between KService and KPluginLoader. The KPluginLoader(KService) constructor is replaced with KPluginLoader(KPluginName), and KService gains a cast operator to convert it to a KPluginName. Now KService service(blah.desktop); KPluginLoader(service); works as before, maintaining source compatibility. The reason for the intermediary class (rather than just, say, providing a QString() operator to KService) is to make sure this combination is the only one that works (and you can't start using KService everywhere a QString is expected). Diffs - autotests/CMakeLists.txt dcc4a40bd81f7e17f10219649214a8c9aac5cc60 autotests/jsonplugin.h PRE-CREATION autotests/jsonplugin.cpp PRE-CREATION autotests/jsonplugin.json PRE-CREATION autotests/kpluginloadertest.cpp 2b0afb81469f18f93ea43e6ac73df95a60cbd7f3 autotests/kservicetest.h aa1c691c75c9e5b6903bcbf6e2dc95809ee1ce21 autotests/kservicetest.cpp 796abbcc6313d2cfd69bd213281ea30dfebaa421 autotests/noplugin.desktop PRE-CREATION src/plugin/kpluginloader.h 4e10edf0f152b409c6a4031610ff1f2f9771d08d src/plugin/kpluginloader.cpp 1602c180db5e1a5f0765d95d68f90d2046c9ef2b src/services/kservice.h 6df389a130587eea732b1d81718181bbd3df4f6d src/services/kservice.cpp c897d4c2a08d048e817154101b3a212a098f9768 Diff: https://git.reviewboard.kde.org/r/117185/diff/ Testing --- Builds, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: khtml_master_qt5 #66
See http://build.kde.org/job/khtml_master_qt5/66/ -- [...truncated 175 lines...] == Commencing the Build Scanning dependencies of target khtmlimagepart_automoc Scanning dependencies of target kmultipart_automoc Scanning dependencies of target khtmladaptorpart_automoc Scanning dependencies of target KF5KHtml_automoc Scanning dependencies of target khtmlpart_automoc Scanning dependencies of target khtmltest_automoc Scanning dependencies of target kjavaappletviewer_automoc [ 0%] Scanning dependencies of target testkhtml_static_automoc Scanning dependencies of target testkhtml_automoc [ 0%] [ 1%] [ 2%] [ 2%] [ 3%] Automatic moc for target khtmlimagepart [ 4%] Automatic moc for target khtmlpart [ 4%] [ 4%] Automatic moc for target khtmladaptorpart Automatic moc for target KF5KHtml Automatic moc for target kmultipart Automatic moc for target kjavaappletviewer Automatic moc for target testkhtml Automatic moc for target testkhtml_static Automatic moc for target khtmltest [ 4%] Built target khtmlimagepart_automoc Scanning dependencies of target testserver_automoc [ 5%] Automatic moc for target testserver Generating moc_khtml_factory.cpp QIODevice::read: device not open [ 5%] Built target khtmlpart_automoc Scanning dependencies of target kencodingdetectortest_automoc [ 5%] Automatic moc for target kencodingdetectortest Generating moc_khtmladaptorpart.cpp [ 5%] Built target khtmladaptorpart_automoc Scanning dependencies of target khtmlparttest_automoc [ 5%] Automatic moc for target khtmlparttest Generating moc_testkhtmlnew.cpp [ 5%] Built target khtmltest_automoc Generating moc_kencodingdetectortest.cpp [ 5%] Built target kencodingdetectortest_automoc Generating moc_testkhtml.cpp Generating moc_testkhtml.cpp Generating moc_khtmlparttest.cpp [ 5%] [ 5%] Built target testkhtml_automoc Scanning dependencies of target khtmladaptorpart Built target testkhtml_static_automoc [ 5%] Built target khtmlparttest_automoc [ 6%] [ 6%] Building CXX object src/CMakeFiles/khtmladaptorpart.dir/khtmladaptorpart.cpp.o Building CXX object src/CMakeFiles/khtmladaptorpart.dir/khtmladaptorpart_automoc.cpp.o Generating kmultipart.moc Generating moc_httpfiltergzip_p.cpp Generating moc_kmultipart.cpp [ 6%] Built target kmultipart_automoc Generating moc_kjavaapplet.cpp Generating moc_kjavaappletcontext.cpp Generating moc_kjavaappletserver.cpp Generating moc_kjavaappletviewer.cpp Generating moc_kjavaappletwidget.cpp Generating moc_kjavadownloader.cpp Generating moc_kjavaprocess.cpp [ 6%] Built target testserver_automoc Scanning dependencies of target kmultipart [ 6%] [ 6%] Building CXX object src/kmultipart/CMakeFiles/kmultipart.dir/kmultipart.cpp.o Building CXX object src/kmultipart/CMakeFiles/kmultipart.dir/httpfiltergzip.cpp.o [ 6%] Building CXX object src/kmultipart/CMakeFiles/kmultipart.dir/kmultipart_automoc.cpp.o Generating moc_kjavaapplet.cpp Generating moc_kjavaappletcontext.cpp Generating moc_kjavaappletserver.cpp Generating moc_kjavaappletviewer.cpp Generating moc_kjavaappletwidget.cpp Generating moc_kjavadownloader.cpp Generating moc_kjavaprocess.cpp [ 6%] Built target kjavaappletviewer_automoc Scanning dependencies of target testserver [ 6%] [ 7%] Building CXX object tests/java/CMakeFiles/testserver.dir/testkjavaappletserver.cpp.o Building CXX object tests/java/CMakeFiles/testserver.dir/__/__/src/java/kjavaappletcontext.cpp.o Scanning dependencies of target kjavaappletviewer [ 7%] Building CXX object src/java/CMakeFiles/kjavaappletviewer.dir/kjavaapplet.cpp.o Generating moc_ksslkeygen.cpp Generating moc_ksslkeygen_p.cpp Generating khtml_settings.moc Generating moc_khtml_wallet_p.cpp Generating moc_khtmlpart_p.cpp http://build.kde.org/job/khtml_master_qt5/ws/src/khtmlpart_p.h:0: Note: No relevant classes found. No output generated. [ 7%] Building CXX object tests/java/CMakeFiles/testserver.dir/__/__/src/java/kjavaappletviewer.cpp.o In file included from /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kservice/inst/include/KF5/KService/kpluginfactory.h:30:0, from http://build.kde.org/job/khtml_master_qt5/ws/src/khtmladaptorpart.h:26, from http://build.kde.org/job/khtml_master_qt5/ws/src/khtmladaptorpart.cpp:21: /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kservice/inst/include/KF5/KService/kexportplugin.h:52:51: warning: ‘K_EXPORT_PLUGIN_is_deprecated_see_KDE5PORTING’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kservice/inst/include/KF5/KService/kexportplugin.h:47) [-Wdeprecated-declarations] K_EXPORT_PLUGIN_is_deprecated_see_KDE5PORTING dummy; ^ http://build.kde.org/job/khtml_master_qt5/ws/src/khtmladaptorpart.cpp:50:1: note: in expansion of macro ‘K_EXPORT_PLUGIN’ K_EXPORT_PLUGIN(KHTMLAdaptorPartFactory) ^ [ 7%] Building CXX object
Build failed in Jenkins: kde4support_master_qt5 #103
See http://build.kde.org/job/kde4support_master_qt5/103/ -- [...truncated 989 lines...] [ 42%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdeui/kdialogbuttonbox.cpp.o [ 43%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdeui/kpixmapcache.cpp.o [ 43%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdeui/kprogressdialog.cpp.o [ 43%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdeui/kmenu.cpp.o [ 43%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdeui/kmenubar.cpp.o [ 44%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdeui/kshortcut.cpp.o [ 44%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdeui/kstatusbar.cpp.o [ 44%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdeui/ksystemtrayicon.cpp.o [ 44%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdeui/ktabbar.cpp.o [ 45%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdeui/ktabwidget.cpp.o [ 45%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdeui/kuniqueapplication.cpp.o [ 45%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdeui/khbox.cpp.o In file included from http://build.kde.org/job/kde4support_master_qt5/ws/src/kdeui/kmenubar.cpp:22:0: http://build.kde.org/job/kde4support_master_qt5/ws/src/kdeui/kmenubar.h:89:44: note: #pragma message: Port to Qt5 native filter #pragma message(Port to Qt5 native filter) ^ [ 45%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdeui/kvbox.cpp.o http://build.kde.org/job/kde4support_master_qt5/ws/src/kdeui/kmenubar.cpp:425:44: note: #pragma message: Port to Qt5 native filter #pragma message(Port to Qt5 native filter) ^ [ 46%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdeui/kmessagebox_queued.cpp.o [ 46%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdeui/kmessageboxmessagehandler.cpp.o http://build.kde.org/job/kde4support_master_qt5/ws/src/kdeui/ksystemtrayicon.cpp: In member function ‘void KSystemTrayIcon::init(QWidget*)’: http://build.kde.org/job/kde4support_master_qt5/ws/src/kdeui/ksystemtrayicon.cpp:157:85: warning: ‘static KWindowInfo KWindowSystem::windowInfo(WId, NET::Properties, NET::Properties2)’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kwindowsystem/inst/include/KF5/KWindowSystem/kwindowsystem.h:104) [-Wdeprecated-declarations] KWindowInfo info = KWindowSystem::windowInfo(parent-winId(), NET::WMDesktop); ^ http://build.kde.org/job/kde4support_master_qt5/ws/src/kdeui/ksystemtrayicon.cpp: In member function ‘void KSystemTrayIcon::activateOrHide(QSystemTrayIcon::ActivationReason)’: http://build.kde.org/job/kde4support_master_qt5/ws/src/kdeui/ksystemtrayicon.cpp:265:93: warning: ‘static KWindowInfo KWindowSystem::windowInfo(WId, NET::Properties, NET::Properties2)’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kwindowsystem/inst/include/KF5/KWindowSystem/kwindowsystem.h:104) [-Wdeprecated-declarations] KWindowInfo info1 = KWindowSystem::windowInfo(pw-winId(), NET::XAWMState | NET::WMState); ^ http://build.kde.org/job/kde4support_master_qt5/ws/src/kdeui/ksystemtrayicon.cpp:283:100: warning: ‘static KWindowInfo KWindowSystem::windowInfo(WId, NET::Properties, NET::Properties2)’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kwindowsystem/inst/include/KF5/KWindowSystem/kwindowsystem.h:104) [-Wdeprecated-declarations] NET::WMGeometry | NET::XAWMState | NET::WMState | NET::WMWindowType); ^ http://build.kde.org/job/kde4support_master_qt5/ws/src/kdeui/ksystemtrayicon.cpp: In member function ‘void KSystemTrayIcon::minimizeRestore(bool)’: http://build.kde.org/job/kde4support_master_qt5/ws/src/kdeui/ksystemtrayicon.cpp:315:95: warning: ‘static KWindowInfo KWindowSystem::windowInfo(WId, NET::Properties, NET::Properties2)’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kwindowsystem/inst/include/KF5/KWindowSystem/kwindowsystem.h:104) [-Wdeprecated-declarations] KWindowInfo info = KWindowSystem::windowInfo(pw-winId(), NET::WMGeometry | NET::WMDesktop); ^ [ 46%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdeui/kpushbutton.cpp.o [ 46%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdeui/kundostack.cpp.o [ 47%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdeui/krestrictedline.cpp.o [ 47%] Building CXX object
Re: kcrash test failure
On 04/01/2014 03:21 AM, Jonathan Riddell wrote: Anyone seen this test failure in kcrash? I only get it on i386 http://paste.kde.org/pccpojfwd Jonathan I can reproduce consistently on amd64. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: kparts_master_qt5 #44
See http://build.kde.org/job/kparts_master_qt5/44/ -- [...truncated 60 lines...] kconfig - Branch master ki18n - Branch master kcompletion - Branch master kxmlgui - Branch master == Applying Patches === No patches to apply == Syncing Dependencies from Master Server == Configuring Build -- The C compiler identification is GNU 4.8.2 -- The CXX compiler identification is GNU 4.8.2 -- Check for working C compiler: /home/jenkins/bin/cc -- Check for working C compiler: /home/jenkins/bin/cc -- works -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working CXX compiler: /home/jenkins/bin/c++ -- Check for working CXX compiler: /home/jenkins/bin/c++ -- works -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success -- Performing Test COMPILER_HAS_DEPRECATED_ATTR -- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success -- -- The following REQUIRED packages have been found: * ECM (required version = 0.0.12) * Qt5Core * Qt5Gui (required version = 5.3.0) * Qt5Widgets * Qt5Xml * Qt5 (required version = 5.2) * KF5Config (required version = 4.98.0) * KF5CoreAddons (required version = 4.98.0) * KF5I18n (required version = 4.98.0) * KF5IconThemes (required version = 4.98.0) * KF5KIO (required version = 4.98.0) * KF5JobWidgets (required version = 4.98.0) * KF5Notifications (required version = 4.98.0) * KF5Service (required version = 4.98.0) * KF5TextWidgets (required version = 4.98.0) * KF5WidgetsAddons (required version = 4.98.0) * KF5XmlGui (required version = 4.98.0) * Qt5Test (required version = 5.2) Required for tests Required for tests -- Configuring done -- Generating done CMake Warning: Manually-specified variables were not used by the project: KDE4_BUILD_TESTS LIB_SUFFIX SIP_DEFAULT_SIP_DIR -- Build files have been written to: http://build.kde.org/job/kparts_master_qt5/ws/build == Commencing the Build Scanning dependencies of target kpartstest_automoc Scanning dependencies of target KF5Parts_automoc Scanning dependencies of target spellcheckplugin_automoc Scanning dependencies of target normalktmtest_automoc Scanning dependencies of target notepadpart_automoc Scanning dependencies of target terminal_test_automoc Scanning dependencies of target partviewer_automoc Scanning dependencies of target openorsavequestion_automoc Scanning dependencies of target openorsavequestion_unittest_automoc [ 1%] [ 4%] [ 4%] [ 7%] [ 7%] [ 9%] [ 12%] [ 12%] [ 14%] Automatic moc for target KF5Parts Automatic moc for target normalktmtest Automatic moc for target notepadpart Automatic moc for target spellcheckplugin Automatic moc for target kpartstest Automatic moc for target terminal_test Automatic moc for target partviewer Automatic moc for target openorsavequestion Automatic moc for target openorsavequestion_unittest [ 14%] Built target openorsavequestion_automoc Scanning dependencies of target parttest_automoc [ 15%] Automatic moc for target parttest Generating moc_parttest.cpp [ 15%] Built target parttest_automoc Generating moc_partviewer.cpp Generating terminal_test.moc [ 15%] [ 15%] Built target partviewer_automoc Built target terminal_test_automoc Generating openorsavequestion_unittest.moc [ 15%] Built target openorsavequestion_unittest_automoc Generating notepad.moc Generating moc_notepad.cpp [ 15%] Built target notepadpart_automoc Generating plugin_spellcheck.moc Generating moc_plugin_spellcheck.cpp [ 15%] Built target spellcheckplugin_automoc Generating notepad.moc Generating moc_normalktm.cpp Generating moc_notepad.cpp Generating moc_parts.cpp [ 15%] Built target normalktmtest_automoc Generating notepad.moc Generating moc_notepad.cpp Generating moc_parts.cpp Generating moc_testmainwindow.cpp [ 15%] Built target kpartstest_automoc Generating browseropenorsavequestion.moc Generating moc_browserrun.cpp Generating moc_browserrun_p.cpp Generating moc_part.cpp Generating moc_readonlypart.cpp Generating moc_readwritepart.cpp Generating moc_scriptableextension.cpp Generating moc_scriptableextension_p.cpp Generating moc_browserextension.cpp Generating moc_browserhostextension.cpp Generating moc_browserinterface.cpp Generating moc_fileinfoextension.cpp Generating moc_historyprovider.cpp Generating moc_htmlextension.cpp Generating moc_listingfilterextension.cpp Generating moc_listingnotificationextension.cpp Generating moc_liveconnectextension.cpp Generating moc_mainwindow.cpp Generating moc_partmanager.cpp Generating moc_plugin.cpp Generating moc_statusbarextension.cpp Generating moc_textextension.cpp [ 15%] Built target KF5Parts_automoc Scanning dependencies of target KF5Parts [ 17%] [ 18%] [ 20%] [ 21%] [ 23%] [ 25%] [ 26%] Building
Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #220
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/220/ -- [...truncated 734 lines...] [ 49%] Building CXX object examples/dataengines/simpleEngine/CMakeFiles/plasma_dataengine_example_simpleEngine.dir/plasma_dataengine_example_simpleEngine_automoc.cpp.o [ 50%] Building CXX object src/declarativeimports/plasmaextracomponents/CMakeFiles/plasmaextracomponentsplugin.dir/plasmaextracomponentsplugin.cpp.o http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/ws/src/plasmapkg/plasmapkg.cpp:618:14: warning: #warning read config here [-Wcpp] #warning read config here ^ [ 51%] [ 52%] Building CXX object examples/dataengines/customDataContainers/CMakeFiles/plasma_dataengine_example_customDataContainers.dir/httpContainer.cpp.o Building CXX object examples/dataengines/sourcesOnRequest/CMakeFiles/plasma_dataengine_example_sourcesOnRequest.dir/plasma_dataengine_example_sourcesOnRequest_automoc.cpp.o [ 53%] Building CXX object src/declarativeimports/plasmacomponents/CMakeFiles/plasmacomponentsplugin.dir/qrangemodel.cpp.o [ 53%] Building CXX object autotests/CMakeFiles/configloadertest.dir/configloadertest_automoc.cpp.o http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/ws/src/plasmapkg/plasmapkg.cpp:485:9: warning: unused parameter ‘pluginName’ [-Wunused-parameter] QString PlasmaPkg::findPackageRoot(const QString pluginName, const QString prefix) ^ http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/ws/src/plasmapkg/plasmapkg.cpp:485:9: warning: unused parameter ‘prefix’ [-Wunused-parameter] http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/ws/src/plasmapkg/plasmapkg.cpp: In member function ‘void Plasma::PlasmaPkgPrivate::listTypes()’: http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/ws/src/plasmapkg/plasmapkg.cpp:594:37: warning: ‘KPluginInfo::KPluginInfo(KService::Ptr)’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kservice/inst/include/KF5/KService/kplugininfo.h:114) [-Wdeprecated-declarations] KPluginInfo info(service); ^ [ 54%] Building CXX object src/declarativeimports/core/tests/CMakeFiles/sortfiltermodeltest.dir/__/__/__/plasma/dataengineconsumer.cpp.o Linking CXX shared module plasma_dataengine_example_simpleEngine.so [ 55%] Building CXX object src/plasmaquick/CMakeFiles/KF5PlasmaQuick.dir/dialog.cpp.o [ 55%] Built target plasma_dataengine_example_simpleEngine [ 55%] Building CXX object src/plasmaquick/CMakeFiles/KF5PlasmaQuick.dir/dialogshadows.cpp.o Linking CXX shared module plasma_dataengine_example_sourcesOnRequest.so [ 55%] [ 55%] Building CXX object src/plasmapkg/CMakeFiles/plasmapkg2.dir/plasmapkg2_automoc.cpp.o Building CXX object examples/dataengines/customDataContainers/CMakeFiles/plasma_dataengine_example_customDataContainers.dir/plasma_dataengine_example_customDataContainers_automoc.cpp.o Linking CXX executable plasmapkg2 http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/ws/src/declarativeimports/plasmaextracomponents/plasmaextracomponentsplugin.cpp:33:6: warning: unused parameter ‘uri’ [-Wunused-parameter] void PlasmaExtraComponentsPlugin::initializeEngine(QQmlEngine *engine, const char *uri) ^ [ 55%] Built target plasma_dataengine_example_sourcesOnRequest [ 56%] Building CXX object src/plasmaquick/CMakeFiles/KF5PlasmaQuick.dir/view.cpp.o [ 57%] Building CXX object src/declarativeimports/plasmacomponents/CMakeFiles/plasmacomponentsplugin.dir/enums.cpp.o [ 57%] Built target plasmapkg2 [ 57%] Building CXX object src/declarativeimports/plasmacomponents/CMakeFiles/plasmacomponentsplugin.dir/qmenu.cpp.o [ 57%] Building CXX object src/declarativeimports/plasmaextracomponents/CMakeFiles/plasmaextracomponentsplugin.dir/fallbackcomponent.cpp.o [ 57%] Building CXX object src/declarativeimports/core/tests/CMakeFiles/sortfiltermodeltest.dir/__/datamodel.cpp.o Linking CXX executable configloadertest Linking CXX shared module plasma_dataengine_example_customDataContainers.so Scanning dependencies of target packagestructuretest [ 57%] Building CXX object autotests/CMakeFiles/packagestructuretest.dir/packagestructuretest.cpp.o http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/ws/src/plasmaquick/dialog.cpp: In member function ‘virtual QPoint PlasmaQuick::Dialog::popupPosition(QQuickItem*, const QSize)’: http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/ws/src/plasmaquick/dialog.cpp:546:101: warning: ‘static KWindowInfo KWindowSystem::windowInfo(WId, NET::Properties, NET::Properties2)’ is deprecated (declared at
Re: Review Request 117197: Fix warnings caused by changing to enum types in NET classes
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117197/#review54705 --- This review has been submitted with commit 60a8c664c1e446210507f64d01683c5b2532d8f9 by Martin Gräßlin to branch master. - Commit Hook On March 31, 2014, 8:17 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117197/ --- (Updated March 31, 2014, 8:17 a.m.) Review request for KDE Frameworks. Repository: kwindowsystem Description --- Fix warnings caused by changing to enum types in NET classes KWindowSystem framework was internally still using the now deprecated methods. There is one usage left in kwindowsystem_x11 which is not yet under unit tests. Diffs - autotests/netwininfotestwm.cpp f98f4864cb06fceb89f8321730cacfeabc640b84 src/kstartupinfo.cpp 65928b731284ed0c9cf2ae8e3c53d3f2886c20ed src/kwindoweffects_x11.cpp d1c60322aa56c9527f3ac6f1f21b1a151668f50f src/kwindowinfo_x11.cpp c4d8a45c156fff07aa11d6294617dbba89204d70 src/kwindowsystem_x11.cpp eb0ad2e4e1d10f1eed55f63319b118bfa88a88d1 src/netwm.cpp 7fda3d6632da8c5770f2eac01d0a44d0760fc93f autotests/kwindowinfox11test.cpp 4f145ca2837854af24e79930b04fce933199ded9 autotests/netrootinfotestwm.cpp 24137cb1ad7c9ce25bb5b1e2685f853932fe1df7 autotests/netwininfotestclient.cpp 196862c2901010802189db29c55af6b383aba7e3 Diff: https://git.reviewboard.kde.org/r/117197/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117196: Remove unused global variable from kkeyserver_x11.cpp
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117196/ --- (Updated March 31, 2014, 4:48 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Albert Astals Cid. Repository: kwindowsystem Description --- Remove unused global variable from kkeyserver_x11.cpp Diffs - src/kkeyserver_x11.cpp 0600240ecf6519f671f7152a6403911342e74d27 Diff: https://git.reviewboard.kde.org/r/117196/diff/ Testing --- compiles Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117197: Fix warnings caused by changing to enum types in NET classes
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117197/ --- (Updated March 31, 2014, 4:48 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kwindowsystem Description --- Fix warnings caused by changing to enum types in NET classes KWindowSystem framework was internally still using the now deprecated methods. There is one usage left in kwindowsystem_x11 which is not yet under unit tests. Diffs - autotests/netwininfotestwm.cpp f98f4864cb06fceb89f8321730cacfeabc640b84 src/kstartupinfo.cpp 65928b731284ed0c9cf2ae8e3c53d3f2886c20ed src/kwindoweffects_x11.cpp d1c60322aa56c9527f3ac6f1f21b1a151668f50f src/kwindowinfo_x11.cpp c4d8a45c156fff07aa11d6294617dbba89204d70 src/kwindowsystem_x11.cpp eb0ad2e4e1d10f1eed55f63319b118bfa88a88d1 src/netwm.cpp 7fda3d6632da8c5770f2eac01d0a44d0760fc93f autotests/kwindowinfox11test.cpp 4f145ca2837854af24e79930b04fce933199ded9 autotests/netrootinfotestwm.cpp 24137cb1ad7c9ce25bb5b1e2685f853932fe1df7 autotests/netwininfotestclient.cpp 196862c2901010802189db29c55af6b383aba7e3 Diff: https://git.reviewboard.kde.org/r/117197/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to normal : kparts_master_qt5 #45
See http://build.kde.org/job/kparts_master_qt5/45/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to normal : kde4support_master_qt5 #105
See http://build.kde.org/job/kde4support_master_qt5/105/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to normal : khtml_master_qt5 #67
See http://build.kde.org/job/khtml_master_qt5/67/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to normal : plasma-framework_master_qt5 » All,LINBUILDER #222
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/222/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: build qt5 stable (changed subject from: qt5 stable: qengineio: fatal: remote error: access denied or repository not exported)
On Monday 31 March 2014 17:27:33 Ben Cooksley wrote: On Mon, Mar 31, 2014 at 5:38 AM, Gregor Mi codeminis...@publicstatic.de wrote: On 30/03/14 12:41, Aleix Pol wrote: On Sun, Mar 30, 2014 at 12:02 PM, Gregor Mi codeminis...@publicstatic.de mailto:codeminis...@publicstatic.de wrote: On 30/03/14 11:29, Gregor Mi wrote: Hi, has anyone recently build qt5 from scratch as described here [1]? When doing $ ./init-repository the following error occurs: --- + git clone git://anongit.kde.org/qt/qtenginio.git http://anongit.kde.org/qt/qtenginio.git qtenginio Cloning into 'qtenginio'... fatal: Could not read from remote repository. Please make sure you have the correct access rights and the repository exists. git clone git://anongit.kde.org/qt/qtenginio.git http://anongit.kde.org/qt/qtenginio.git qtenginio exited with status 32768 at ./init-repository line 305. --- The other repos are working fine. Best regards Gregor [1] http://community.kde.org/Frameworks/Building, section QT5 When building QT5 as described in [1] the stable branch of Qt is now 5.3 (and not 5.2). Is this correct? AFAIK, the building dependency is 5.2 and that probably is outdated, as stable is a moving target. Either way, I'd suggest you to use stable too. Aleix Ok. Any idea about the qtenginio Could not read from remote repository problem? Do I need special access rights? Or is it possible that the qtenginio repo is offline? This is because the upstream Qt developers have added yet another module to Qt, which wasn't included in our mirror of Qt. Our mirror has now been adjusted to include this new mirror. This is a process which has to be done each time they add a new module. For those wondering why, we maintain a mirror of Qt on the anongit network to ensure that it is always available - at least in the past people have had issues accessing the Gitorious repositories. Hi Ben, then thanks again for fixing it (again). Question though: Could this error be caught earlier, maybe automated? I'm asking because it cost me (as someone who does 10+ years KDE/Qt development) quite some time to get this working. Other developers following our official building guide will run into this, too, and probably just give up. And that is quite bad. Greetings, Dominik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: build qt5 stable (changed subject from: qt5 stable: qengineio: fatal: remote error: access denied or repository not exported)
On Tue, Apr 1, 2014 at 9:34 AM, Dominik Haumann dhaum...@kde.org wrote: On Monday 31 March 2014 17:27:33 Ben Cooksley wrote: On Mon, Mar 31, 2014 at 5:38 AM, Gregor Mi codeminis...@publicstatic.de wrote: On 30/03/14 12:41, Aleix Pol wrote: On Sun, Mar 30, 2014 at 12:02 PM, Gregor Mi codeminis...@publicstatic.de mailto:codeminis...@publicstatic.de wrote: On 30/03/14 11:29, Gregor Mi wrote: Hi, has anyone recently build qt5 from scratch as described here [1]? When doing $ ./init-repository the following error occurs: --- + git clone git://anongit.kde.org/qt/qtenginio.git http://anongit.kde.org/qt/qtenginio.git qtenginio Cloning into 'qtenginio'... fatal: Could not read from remote repository. Please make sure you have the correct access rights and the repository exists. git clone git://anongit.kde.org/qt/qtenginio.git http://anongit.kde.org/qt/qtenginio.git qtenginio exited with status 32768 at ./init-repository line 305. --- The other repos are working fine. Best regards Gregor [1] http://community.kde.org/Frameworks/Building, section QT5 When building QT5 as described in [1] the stable branch of Qt is now 5.3 (and not 5.2). Is this correct? AFAIK, the building dependency is 5.2 and that probably is outdated, as stable is a moving target. Either way, I'd suggest you to use stable too. Aleix Ok. Any idea about the qtenginio Could not read from remote repository problem? Do I need special access rights? Or is it possible that the qtenginio repo is offline? This is because the upstream Qt developers have added yet another module to Qt, which wasn't included in our mirror of Qt. Our mirror has now been adjusted to include this new mirror. This is a process which has to be done each time they add a new module. For those wondering why, we maintain a mirror of Qt on the anongit network to ensure that it is always available - at least in the past people have had issues accessing the Gitorious repositories. Hi Ben, Hi Dominik, then thanks again for fixing it (again). Question though: Could this error be caught earlier, maybe automated? Not sure how easy it would be to catch - the only way to detect missing Qt modules is when init-repository is adjusted to use them. As far as I know there is no easily machine usable list out there of the list of repositories which make up Qt 5. I'm asking because it cost me (as someone who does 10+ years KDE/Qt development) quite some time to get this working. Other developers following our official building guide will run into this, too, and probably just give up. And that is quite bad. Indeed. I see three ways forward essentially: 1) Get the Qt Project folks to inform KDE Sysadmin in advance of a new repository going into init-repository - this will give us time to add a mirror of that repository 2) Get the Qt Project folks to offer a list of all repositories which make up Qt 5. A script can periodically retrieve this and compare it against the repos offered on KDE infrastructure to detect newly added repositories. 3) Cease mirroring Qt 5 on KDE infrastructure. Greetings, Dominik Thanks, Ben ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117195: [kio] Replace COULD_NOT with CANNOT in the error code enum
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117195/#review54724 --- Ship it! Funny that somehow errno manages to never use CAN or COULD in its own error messages and descriptions. It actually manages to be much more precise about the reason for the failure, not just this call failed. Oh well :) - David Faure On March 31, 2014, 2:55 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117195/ --- (Updated March 31, 2014, 2:55 p.m.) Review request for KDE Frameworks and David Faure. Repository: kio Description --- Use the new name for the error codes ERR_COULD_NOT_* has been replaced with ERR_CANNOT_*. Replace COULD_NOT with CANNOT in the error code enum This makes the error code names more consistent. The old versions are kept for backwards-compatibility. Diffs - src/core/global.h be8e5481c8146c2d0737be06f034cdccc1573f79 src/core/job_error.cpp 1ec28c5d9ebdbc2045743c566f473c8cfa02e1bd src/ioslaves/http/http.cpp 3158628af2dc8ee88a0ac0d968748d6b50a8da33 src/ioslaves/help/kio_help.cpp df3e934b5cac7428bd1525d5de1b3fedd9b16394 src/ioslaves/ftp/ftp.cpp 49037701772f88e9a96bc3110f1f04fccb810ca8 src/ioslaves/file/file_unix.cpp bb4d6003985269464c380927d51eaf9ed602ade1 src/ioslaves/file/file.cpp 6387d7f29df2c0a26952be5255438361c37ed082 src/core/tcpslavebase.cpp ea0434e19a7fb35cc708dece1ff904d6739aa4de src/core/slavebase.h 4726915da0757c64ab735f586142806891b517d1 src/widgets/accessmanagerreply_p.cpp 4322e0275f57f10aeba2ea8381f53d06f6b6fe25 Diff: https://git.reviewboard.kde.org/r/117195/diff/ Testing --- Builds, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Translation support in Qt-translation-based frameworks
El Dilluns, 31 de març de 2014, a les 15:38:39, Alex Merry va escriure: On 31/03/14 15:30, Aurélien Gâteau wrote: Do not commit the po/ dir, it will be generated at release time from the kde translation infrastructure. Should go in .gitignore, yes? Why? We have been living without this in KDE for eons, what's the sudden need of adding this to the .gitignore? Cheers, Albert Alex ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: build qt5 stable (changed subject from: qt5 stable: qengineio: fatal: remote error: access denied or repository not exported)
El Dilluns, 31 de març de 2014, a les 22:34:21, Dominik Haumann va escriure: On Monday 31 March 2014 17:27:33 Ben Cooksley wrote: On Mon, Mar 31, 2014 at 5:38 AM, Gregor Mi codeminis...@publicstatic.de wrote: On 30/03/14 12:41, Aleix Pol wrote: On Sun, Mar 30, 2014 at 12:02 PM, Gregor Mi codeminis...@publicstatic.de mailto:codeminis...@publicstatic.de wrote: On 30/03/14 11:29, Gregor Mi wrote: Hi, has anyone recently build qt5 from scratch as described here [1]? When doing $ ./init-repository the following error occurs: --- + git clone git://anongit.kde.org/qt/qtenginio.git http://anongit.kde.org/qt/qtenginio.git qtenginio Cloning into 'qtenginio'... fatal: Could not read from remote repository. Please make sure you have the correct access rights and the repository exists. git clone git://anongit.kde.org/qt/qtenginio.git http://anongit.kde.org/qt/qtenginio.git qtenginio exited with status 32768 at ./init-repository line 305. --- The other repos are working fine. Best regards Gregor [1] http://community.kde.org/Frameworks/Building, section QT5 When building QT5 as described in [1] the stable branch of Qt is now 5.3 (and not 5.2). Is this correct? AFAIK, the building dependency is 5.2 and that probably is outdated, as stable is a moving target. Either way, I'd suggest you to use stable too. Aleix Ok. Any idea about the qtenginio Could not read from remote repository problem? Do I need special access rights? Or is it possible that the qtenginio repo is offline? This is because the upstream Qt developers have added yet another module to Qt, which wasn't included in our mirror of Qt. Our mirror has now been adjusted to include this new mirror. This is a process which has to be done each time they add a new module. For those wondering why, we maintain a mirror of Qt on the anongit network to ensure that it is always available - at least in the past people have had issues accessing the Gitorious repositories. Hi Ben, then thanks again for fixing it (again). Question though: Could this error be caught earlier, maybe automated? Honestly we should stop suggesting people to build their own Qt and just use 5.2 distro packages. Cheers, Albert I'm asking because it cost me (as someone who does 10+ years KDE/Qt development) quite some time to get this working. Other developers following our official building guide will run into this, too, and probably just give up. And that is quite bad. Greetings, Dominik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Translation support in Qt-translation-based frameworks
El Dilluns, 31 de març de 2014, a les 07:30:29, Aurélien Gâteau va escriure: Hi, I just committed the necessary build system changes to enable all Qt-translation-based frameworks to build, install and load their translations. This means the following frameworks: kauth kbookmarks kcodecs kcompletion kcoreaddons kcrash kdbusaddons kdesignerplugin kdnssd kglobalaccel kitemviews kjobwidgets knotifications kwidgetsaddons solid sonnet If you maintain one of those frameworks, please have a look at the changes. They were partly automated, so may not match exactly the way you like things to be named or indented. I smoke-tested those which provided manual tests to exercise part of the translated UI. This is the list of frameworks for which I found a way to test: kbookmarks kcompletion kcoreaddons kdesignerplugin kitemviews kjobwidgets knotifications kwidgetsaddons sonnet To test translations: 1. Generate a .pot file by following those instructions: http://techbase.kde.org/Development/Tutorials/Localization/i18n_Build_System s#Testing_your_Messages.sh_script 2. Create a translation file: cd po cp myframework.pot myframework-fr.po (or -de, -es, -pt...) 3. Edit myframework-fr.po with Lokalize or your text editor, translate strings of interest (no need to translate all, this is just for testing) 4. Rerun cmake so that it notices the new po dir (touch CMakeLists.txt should do) 5. Run make and make install 6. Run the code to test, your translations should appear This is really bad compared to our you do it in kde4 which is basically. * Go do l10n-kde4 * Install your language * Done It also makes it much harder for translators to test the translations they are working on since they suddenly have to compile the program they are translating instead of just compiling the translation and using the binaries the distro provides. Any way we can make the old just compile your l10n-kde4 language and install it way work? Cheers, Albert Do not commit the po/ dir, it will be generated at release time from the kde translation infrastructure. Aurélien ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117195: [kio] Replace COULD_NOT with CANNOT in the error code enum
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117195/#review54726 --- This review has been submitted with commit 173cdf21221c5dc91c0afe4205c6d3db28a76559 by Alex Merry to branch master. - Commit Hook On March 31, 2014, 2:55 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117195/ --- (Updated March 31, 2014, 2:55 p.m.) Review request for KDE Frameworks and David Faure. Repository: kio Description --- Use the new name for the error codes ERR_COULD_NOT_* has been replaced with ERR_CANNOT_*. Replace COULD_NOT with CANNOT in the error code enum This makes the error code names more consistent. The old versions are kept for backwards-compatibility. Diffs - src/core/global.h be8e5481c8146c2d0737be06f034cdccc1573f79 src/core/job_error.cpp 1ec28c5d9ebdbc2045743c566f473c8cfa02e1bd src/ioslaves/http/http.cpp 3158628af2dc8ee88a0ac0d968748d6b50a8da33 src/ioslaves/help/kio_help.cpp df3e934b5cac7428bd1525d5de1b3fedd9b16394 src/ioslaves/ftp/ftp.cpp 49037701772f88e9a96bc3110f1f04fccb810ca8 src/ioslaves/file/file_unix.cpp bb4d6003985269464c380927d51eaf9ed602ade1 src/ioslaves/file/file.cpp 6387d7f29df2c0a26952be5255438361c37ed082 src/core/tcpslavebase.cpp ea0434e19a7fb35cc708dece1ff904d6739aa4de src/core/slavebase.h 4726915da0757c64ab735f586142806891b517d1 src/widgets/accessmanagerreply_p.cpp 4322e0275f57f10aeba2ea8381f53d06f6b6fe25 Diff: https://git.reviewboard.kde.org/r/117195/diff/ Testing --- Builds, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117195: [kio] Replace COULD_NOT with CANNOT in the error code enum
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117195/#review54725 --- This review has been submitted with commit ed64faf67ccc86304e53305b9f93234988496605 by Alex Merry to branch master. - Commit Hook On March 31, 2014, 2:55 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117195/ --- (Updated March 31, 2014, 2:55 p.m.) Review request for KDE Frameworks and David Faure. Repository: kio Description --- Use the new name for the error codes ERR_COULD_NOT_* has been replaced with ERR_CANNOT_*. Replace COULD_NOT with CANNOT in the error code enum This makes the error code names more consistent. The old versions are kept for backwards-compatibility. Diffs - src/core/global.h be8e5481c8146c2d0737be06f034cdccc1573f79 src/core/job_error.cpp 1ec28c5d9ebdbc2045743c566f473c8cfa02e1bd src/ioslaves/http/http.cpp 3158628af2dc8ee88a0ac0d968748d6b50a8da33 src/ioslaves/help/kio_help.cpp df3e934b5cac7428bd1525d5de1b3fedd9b16394 src/ioslaves/ftp/ftp.cpp 49037701772f88e9a96bc3110f1f04fccb810ca8 src/ioslaves/file/file_unix.cpp bb4d6003985269464c380927d51eaf9ed602ade1 src/ioslaves/file/file.cpp 6387d7f29df2c0a26952be5255438361c37ed082 src/core/tcpslavebase.cpp ea0434e19a7fb35cc708dece1ff904d6739aa4de src/core/slavebase.h 4726915da0757c64ab735f586142806891b517d1 src/widgets/accessmanagerreply_p.cpp 4322e0275f57f10aeba2ea8381f53d06f6b6fe25 Diff: https://git.reviewboard.kde.org/r/117195/diff/ Testing --- Builds, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117195: [kio] Replace COULD_NOT with CANNOT in the error code enum
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117195/ --- (Updated March 31, 2014, 10:29 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and David Faure. Repository: kio Description --- Use the new name for the error codes ERR_COULD_NOT_* has been replaced with ERR_CANNOT_*. Replace COULD_NOT with CANNOT in the error code enum This makes the error code names more consistent. The old versions are kept for backwards-compatibility. Diffs - src/core/global.h be8e5481c8146c2d0737be06f034cdccc1573f79 src/core/job_error.cpp 1ec28c5d9ebdbc2045743c566f473c8cfa02e1bd src/ioslaves/http/http.cpp 3158628af2dc8ee88a0ac0d968748d6b50a8da33 src/ioslaves/help/kio_help.cpp df3e934b5cac7428bd1525d5de1b3fedd9b16394 src/ioslaves/ftp/ftp.cpp 49037701772f88e9a96bc3110f1f04fccb810ca8 src/ioslaves/file/file_unix.cpp bb4d6003985269464c380927d51eaf9ed602ade1 src/ioslaves/file/file.cpp 6387d7f29df2c0a26952be5255438361c37ed082 src/core/tcpslavebase.cpp ea0434e19a7fb35cc708dece1ff904d6739aa4de src/core/slavebase.h 4726915da0757c64ab735f586142806891b517d1 src/widgets/accessmanagerreply_p.cpp 4322e0275f57f10aeba2ea8381f53d06f6b6fe25 Diff: https://git.reviewboard.kde.org/r/117195/diff/ Testing --- Builds, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117195: [kio] Replace COULD_NOT with CANNOT in the error code enum
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117195/ --- (Updated March 31, 2014, 10:29 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and David Faure. Repository: kio Description --- Use the new name for the error codes ERR_COULD_NOT_* has been replaced with ERR_CANNOT_*. Replace COULD_NOT with CANNOT in the error code enum This makes the error code names more consistent. The old versions are kept for backwards-compatibility. Diffs - src/core/global.h be8e5481c8146c2d0737be06f034cdccc1573f79 src/core/job_error.cpp 1ec28c5d9ebdbc2045743c566f473c8cfa02e1bd src/ioslaves/http/http.cpp 3158628af2dc8ee88a0ac0d968748d6b50a8da33 src/ioslaves/help/kio_help.cpp df3e934b5cac7428bd1525d5de1b3fedd9b16394 src/ioslaves/ftp/ftp.cpp 49037701772f88e9a96bc3110f1f04fccb810ca8 src/ioslaves/file/file_unix.cpp bb4d6003985269464c380927d51eaf9ed602ade1 src/ioslaves/file/file.cpp 6387d7f29df2c0a26952be5255438361c37ed082 src/core/tcpslavebase.cpp ea0434e19a7fb35cc708dece1ff904d6739aa4de src/core/slavebase.h 4726915da0757c64ab735f586142806891b517d1 src/widgets/accessmanagerreply_p.cpp 4322e0275f57f10aeba2ea8381f53d06f6b6fe25 Diff: https://git.reviewboard.kde.org/r/117195/diff/ Testing --- Builds, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Translation support in Qt-translation-based frameworks
El Dilluns, 31 de març de 2014, a les 23:46:40, Alex Merry va escriure: On 31/03/14 23:22, Albert Astals Cid wrote: El Dilluns, 31 de març de 2014, a les 15:38:39, Alex Merry va escriure: On 31/03/14 15:30, Aurélien Gâteau wrote: Do not commit the po/ dir, it will be generated at release time from the kde translation infrastructure. Should go in .gitignore, yes? Why? We have been living without this in KDE for eons, what's the sudden need of adding this to the .gitignore? The distribution of translations with packages, rather than separately. This is something that should happen at the packaging state (and handled by scipts), i.e. I don't see why ever you'd end up with a po folder you'd want to commit in your git repo checkout, Cheers, Albert Alex ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117268: Deprecate the RESTORE macro
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117268/ --- Review request for KDE Frameworks. Repository: kxmlgui Description --- Deprecate the RESTORE macro RESTORE is just a non-typesafe version of kRestoreMainWindows(). Diffs - src/kmainwindow.h 37eed1a37902ce05c12b9288e275757de196639c Diff: https://git.reviewboard.kde.org/r/117268/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Translation support in Qt-translation-based frameworks
On 01/04/14 00:14, Albert Astals Cid wrote: El Dilluns, 31 de març de 2014, a les 23:46:40, Alex Merry va escriure: On 31/03/14 23:22, Albert Astals Cid wrote: El Dilluns, 31 de març de 2014, a les 15:38:39, Alex Merry va escriure: On 31/03/14 15:30, Aurélien Gâteau wrote: Do not commit the po/ dir, it will be generated at release time from the kde translation infrastructure. Should go in .gitignore, yes? Why? We have been living without this in KDE for eons, what's the sudden need of adding this to the .gitignore? The distribution of translations with packages, rather than separately. This is something that should happen at the packaging state (and handled by scipts), i.e. I don't see why ever you'd end up with a po folder you'd want to commit in your git repo checkout, Well, you wouldn't end up with one you wanted to commit - that's why I suggested adding it to .gitignore. You might end up with one if you were testing things, for example by following Aurélien's instructions. Alex ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Translation support in Qt-translation-based frameworks
El Dimarts, 1 d'abril de 2014, a les 00:22:14, Alex Merry va escriure: On 01/04/14 00:14, Albert Astals Cid wrote: El Dilluns, 31 de març de 2014, a les 23:46:40, Alex Merry va escriure: On 31/03/14 23:22, Albert Astals Cid wrote: El Dilluns, 31 de març de 2014, a les 15:38:39, Alex Merry va escriure: On 31/03/14 15:30, Aurélien Gâteau wrote: Do not commit the po/ dir, it will be generated at release time from the kde translation infrastructure. Should go in .gitignore, yes? Why? We have been living without this in KDE for eons, what's the sudden need of adding this to the .gitignore? The distribution of translations with packages, rather than separately. This is something that should happen at the packaging state (and handled by scipts), i.e. I don't see why ever you'd end up with a po folder you'd want to commit in your git repo checkout, Well, you wouldn't end up with one you wanted to commit - that's why I suggested adding it to .gitignore. You might end up with one if you were testing things, for example by following Aurélien's instructions. Ok, no objections to it being there. I am just raising the issue that if you're a good guy and you properly test your Messages.sh in kde4 you already have the same issue of you may have a po folder in your repo you don't have to commit so i was wondering why this was a problem now. But I understand it may make sense to add it to .gitignore just in case people trying the Messages.sh or people trying Aurelien's instructions fail to understand they don't have to commit that folder. Cheers, Albert Alex ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117269: Use KEMailSettings, instead of parsing configurations directly
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117269/#review54730 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 31, 2014, 11:24 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117269/ --- (Updated March 31, 2014, 11:24 p.m.) Review request for KDE Frameworks. Repository: kxmlgui Description --- Use KEMailSettings, instead of parsing configurations directly It turns out KEMailSettings is no longer in KIO, as the comment complains, but in KConfig where it belongs. Diffs - src/kbugreport.cpp bb37fdf45cf956d80ca351e57c1444d417439ec8 Diff: https://git.reviewboard.kde.org/r/117269/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117271: KIconDialog: do not connect to a signal that does not exist
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117271/ --- Review request for KDE Frameworks and Christoph Feck. Repository: kiconthemes Description --- Add a new test that just checks kicondialog The old kicondialogtest actually tested KIconButton. That is now renamed to kiconbuttontest, and there is a new kicondialogtest that tests KIconDialog. KIconDialog: do not connect to a signal that does not exist QDialog::finished(int) does what we want, so use that instead. Diffs - tests/CMakeLists.txt b3b4c90a9ffbc9df81dd008f9cfbc668866fafe3 tests/kiconbuttontest.cpp PRE-CREATION src/kicondialog.cpp 4b241c1591b321486c925ef5e61f09bc7b6ddd1c tests/kicondialogtest.cpp 66432ba878a4133ea3210089d3fdfbaec145bf1b Diff: https://git.reviewboard.kde.org/r/117271/diff/ Testing --- Tested with the new kicondialogtest, and everything seems to be in order. The old kiconbuttontest is not working properly, apparently because QIcon::fromTheme() is not working. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117272: Use KIconDialog instead of running kdialog to choose icons
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117272/ --- Review request for KDE Frameworks. Repository: kxmlgui Description --- Use KIconDialog instead of running kdialog to choose icons KIconDialog is no longer in KIO, but in KIconThemes, and so we can make use of it. Diffs - src/kedittoolbar_p.h 417a53f4c1332ea0d94c5bac99bbcf486eaccfa8 src/kedittoolbar.cpp 97a7c35ac79fb9f9ab69a497f4b783acf43b632a Diff: https://git.reviewboard.kde.org/r/117272/diff/ Testing --- Builds and tests pass. kwindowtest allows an icon to be selected when editing the toolbars, although that icon doesn't appear (probably because QIcon::fromTheme() isn't working properly for me). Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117273: Fix i18n in ksendbugmail
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117273/ --- Review request for KDE Frameworks. Repository: kxmlgui Description --- Use i18n() instead of QCoreApplication::translate() in ksendbugmail Someone's been copy-pasting command-line parsing code; everything else in this framework uses KI18n. Fix ksendbugmail translation domain This is what is in Messages.sh Diffs - src/ksendbugmail/main.cpp a3eaa393dcaa0d79c322488a1d46ed8e1fba9db8 Diff: https://git.reviewboard.kde.org/r/117273/diff/ Testing --- Builds. ksendbugmail --help seems to work with no translations installed; not figured out how to test the translations. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117269: Use KEMailSettings, instead of parsing configurations directly
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117269/#review54731 --- This review has been submitted with commit 4034430158a5253cb57f3327db3f5d1f186837ef by Alex Merry to branch master. - Commit Hook On March 31, 2014, 11:24 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117269/ --- (Updated March 31, 2014, 11:24 p.m.) Review request for KDE Frameworks. Repository: kxmlgui Description --- Use KEMailSettings, instead of parsing configurations directly It turns out KEMailSettings is no longer in KIO, as the comment complains, but in KConfig where it belongs. Diffs - src/kbugreport.cpp bb37fdf45cf956d80ca351e57c1444d417439ec8 Diff: https://git.reviewboard.kde.org/r/117269/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117269: Use KEMailSettings, instead of parsing configurations directly
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117269/ --- (Updated April 1, 2014, 12:52 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kxmlgui Description --- Use KEMailSettings, instead of parsing configurations directly It turns out KEMailSettings is no longer in KIO, as the comment complains, but in KConfig where it belongs. Diffs - src/kbugreport.cpp bb37fdf45cf956d80ca351e57c1444d417439ec8 Diff: https://git.reviewboard.kde.org/r/117269/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117273: Fix i18n in ksendbugmail
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117273/#review54733 --- Ship it! Good catch! We should figure out how to figure out these problems somehow... How did you notice it? - Aleix Pol Gonzalez On April 1, 2014, 12:48 a.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117273/ --- (Updated April 1, 2014, 12:48 a.m.) Review request for KDE Frameworks. Repository: kxmlgui Description --- Use i18n() instead of QCoreApplication::translate() in ksendbugmail Someone's been copy-pasting command-line parsing code; everything else in this framework uses KI18n. Fix ksendbugmail translation domain This is what is in Messages.sh Diffs - src/ksendbugmail/main.cpp a3eaa393dcaa0d79c322488a1d46ed8e1fba9db8 Diff: https://git.reviewboard.kde.org/r/117273/diff/ Testing --- Builds. ksendbugmail --help seems to work with no translations installed; not figured out how to test the translations. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117273: Fix i18n in ksendbugmail
On April 1, 2014, 1:07 a.m., Aleix Pol Gonzalez wrote: Good catch! We should figure out how to figure out these problems somehow... How did you notice it? Grepping everything for kde.*4 (see http://community.kde.org/Frameworks/Epics/KF5.0_Release_Preparation/KDE4_References) - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117273/#review54733 --- On April 1, 2014, 12:48 a.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117273/ --- (Updated April 1, 2014, 12:48 a.m.) Review request for KDE Frameworks. Repository: kxmlgui Description --- Use i18n() instead of QCoreApplication::translate() in ksendbugmail Someone's been copy-pasting command-line parsing code; everything else in this framework uses KI18n. Fix ksendbugmail translation domain This is what is in Messages.sh Diffs - src/ksendbugmail/main.cpp a3eaa393dcaa0d79c322488a1d46ed8e1fba9db8 Diff: https://git.reviewboard.kde.org/r/117273/diff/ Testing --- Builds. ksendbugmail --help seems to work with no translations installed; not figured out how to test the translations. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117274: Fix kf5kross i18n, and resurrect its KAboutData
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117274/ --- Review request for KDE Frameworks. Repository: kross Description --- Resurrect the KAboutData for the kross console Use i18n() instead of QCoreApplication::translate() in console app This was probably from copy-pasted command-line parsing code; everything else in this framework uses KI18n. Use the correct translation catalog in the console application Diffs - CMakeLists.txt 5b28a3c210232d9682af43afec9401416b858ca0 src/console/CMakeLists.txt aadc8f57eea53fdd0a51464045b0c12d5dcdb4d2 src/console/main.cpp f81672e1c15681719943f64698ada19eeebc0bef Diff: https://git.reviewboard.kde.org/r/117274/diff/ Testing --- Ran kf5kross --help. Not investigated how to test the translation stuff. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117272: Use KIconDialog instead of running kdialog to choose icons
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117272/ --- (Updated April 1, 2014, 1:18 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kxmlgui Description --- Use KIconDialog instead of running kdialog to choose icons KIconDialog is no longer in KIO, but in KIconThemes, and so we can make use of it. Diffs - src/kedittoolbar_p.h 417a53f4c1332ea0d94c5bac99bbcf486eaccfa8 src/kedittoolbar.cpp 97a7c35ac79fb9f9ab69a497f4b783acf43b632a Diff: https://git.reviewboard.kde.org/r/117272/diff/ Testing --- Builds and tests pass. kwindowtest allows an icon to be selected when editing the toolbars, although that icon doesn't appear (probably because QIcon::fromTheme() isn't working properly for me). Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117272: Use KIconDialog instead of running kdialog to choose icons
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117272/#review54736 --- This review has been submitted with commit f6d697193d01ca449e43a6c457102b669818fe4e by Alex Merry to branch master. - Commit Hook On April 1, 2014, 12:34 a.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117272/ --- (Updated April 1, 2014, 12:34 a.m.) Review request for KDE Frameworks. Repository: kxmlgui Description --- Use KIconDialog instead of running kdialog to choose icons KIconDialog is no longer in KIO, but in KIconThemes, and so we can make use of it. Diffs - src/kedittoolbar_p.h 417a53f4c1332ea0d94c5bac99bbcf486eaccfa8 src/kedittoolbar.cpp 97a7c35ac79fb9f9ab69a497f4b783acf43b632a Diff: https://git.reviewboard.kde.org/r/117272/diff/ Testing --- Builds and tests pass. kwindowtest allows an icon to be selected when editing the toolbars, although that icon doesn't appear (probably because QIcon::fromTheme() isn't working properly for me). Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117273: Fix i18n in ksendbugmail
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117273/#review54738 --- This review has been submitted with commit 9673f8c685c02ab25dcd228c36f782e59fc85426 by Alex Merry to branch master. - Commit Hook On April 1, 2014, 12:48 a.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117273/ --- (Updated April 1, 2014, 12:48 a.m.) Review request for KDE Frameworks. Repository: kxmlgui Description --- Use i18n() instead of QCoreApplication::translate() in ksendbugmail Someone's been copy-pasting command-line parsing code; everything else in this framework uses KI18n. Fix ksendbugmail translation domain This is what is in Messages.sh Diffs - src/ksendbugmail/main.cpp a3eaa393dcaa0d79c322488a1d46ed8e1fba9db8 Diff: https://git.reviewboard.kde.org/r/117273/diff/ Testing --- Builds. ksendbugmail --help seems to work with no translations installed; not figured out how to test the translations. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117273: Fix i18n in ksendbugmail
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117273/ --- (Updated April 1, 2014, 1:19 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kxmlgui Description --- Use i18n() instead of QCoreApplication::translate() in ksendbugmail Someone's been copy-pasting command-line parsing code; everything else in this framework uses KI18n. Fix ksendbugmail translation domain This is what is in Messages.sh Diffs - src/ksendbugmail/main.cpp a3eaa393dcaa0d79c322488a1d46ed8e1fba9db8 Diff: https://git.reviewboard.kde.org/r/117273/diff/ Testing --- Builds. ksendbugmail --help seems to work with no translations installed; not figured out how to test the translations. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117275: Deprecate the catalog name stuff from KAboutData
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117275/ --- Review request for KDE Frameworks, David Faure, Kevin Ottens, and Michael Pyne. Repository: kcoreaddons Description --- This is another thing on the if only we'd spotted it before beta1 list. Unfortunately, removing the second argument from the constructor is completely ambiguous for calls that do not have at least enough arguments to specify the license. Deprecate the catalog name stuff from KAboutData This is pretty useless - the translation catalog has to be set before KAboutData is constructed in order to translate its arguments. Diffs - src/lib/kaboutdata.h cff1e3f67e33657fdd265a82166ef2a04cbcc3d1 src/lib/kaboutdata.cpp ce64a13aaa89bb4bc077f05e5f8e175d6a441ead Diff: https://git.reviewboard.kde.org/r/117275/diff/ Testing --- Builds, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
