See http://build.kde.org/job/kdelibs_stable/1162/
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119455/#review63110
---
I think this is nearly good to go. A few questions below.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119457/#review63113
---
Ship it!
Thank you, you are awesome!
A couple of notes
On Friday 25 July 2014 02:52:09 Eike Hein wrote:
On 07/24/2014 08:35 PM, Alex Merry wrote:
As Jonathan said, yes, you are correct. And, yes, I should really write a
porting script for that.
Yay! That's the excuse I needed to avoid fixing Konvi's icon
installs until your script is ready ;)
On July 25, 2014, 8:13 a.m., David Edmundson wrote:
src/declarativeimports/plasmacomponents/qml/styles/ButtonStyle.qml, line 42
https://git.reviewboard.kde.org/r/119455/diff/3/?file=292514#file292514line42
I was thinking this can become just
property real minimumWidth:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119455/
---
(Updated July 25, 2014, 9:41 a.m.)
Review request for KDE Frameworks and
On July 25, 2014, 8:13 a.m., David Edmundson wrote:
src/declarativeimports/plasmacomponents/qml/styles/ButtonStyle.qml, line 42
https://git.reviewboard.kde.org/r/119455/diff/3/?file=292514#file292514line42
I was thinking this can become just
property real minimumWidth:
On July 25, 2014, 8:13 a.m., David Edmundson wrote:
src/declarativeimports/plasmacomponents/qml/styles/ButtonStyle.qml, line 42
https://git.reviewboard.kde.org/r/119455/diff/3/?file=292514#file292514line42
I was thinking this can become just
property real minimumWidth:
On July 25, 2014, 8:13 a.m., David Edmundson wrote:
src/declarativeimports/plasmacomponents/qml/styles/ButtonStyle.qml, line 42
https://git.reviewboard.kde.org/r/119455/diff/3/?file=292514#file292514line42
I was thinking this can become just
property real minimumWidth:
On July 25, 2014, 8:13 a.m., David Edmundson wrote:
src/declarativeimports/plasmacomponents/qml/styles/ButtonStyle.qml, line 42
https://git.reviewboard.kde.org/r/119455/diff/3/?file=292514#file292514line42
I was thinking this can become just
property real minimumWidth:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119455/#review63127
---
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119455/
---
(Updated July 25, 2014, 10:55 a.m.)
Review request for KDE Frameworks
On July 25, 2014, 10:44 a.m., David Edmundson wrote:
src/declarativeimports/plasmacomponents/qml/styles/ButtonStyle.qml, line 76
https://git.reviewboard.kde.org/r/119455/diff/4/?file=292603#file292603line76
This causes a behavioural change:
look at line 102 of the old
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119455/
---
(Updated July 25, 2014, 11:05 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119417/#review63136
---
Ping?
- David Gil Oliva
On jul. 22, 2014, 11:35 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119417/#review63142
---
Ship it!
Ship It!
- Alex Merry
On July 22, 2014, 11:35
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119464/
---
Review request for KDE Frameworks and Plasma.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119455/#review63163
---
One thing tough, i would put back in all the documentation
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119464/#review63169
---
src/declarativeimports/plasmacomponents/qml/ToolButton.qml
On July 25, 2014, 3:57 p.m., Andrew Lake wrote:
src/declarativeimports/plasmacomponents/qml/ToolButton.qml, line 30
https://git.reviewboard.kde.org/r/119464/diff/1/?file=292702#file292702line30
Just curious, any reason to not use ToolButton here?
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119382/#review63168
---
CMakeLists.txt
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119464/
---
(Updated July 25, 2014, 4:52 p.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119267/
---
(Updated July 25, 2014, 9:07 p.m.)
Review request for KDE Frameworks,
Hi,
The migration script from KIcon to QIcon seems to think every usage of
KIcon( ... ) is of the form KIcon( iconName ) but there's also KIcon(
iconName, pointerToIconLoader ). What do I need to do to port those to
QIcon?
Thanks.
David E. Narvaez
On Fri, Jul 25, 2014 at 11:21 PM, David Narvaez david.narv...@computer.org
wrote:
Hi,
The migration script from KIcon to QIcon seems to think every usage of
KIcon( ... ) is of the form KIcon( iconName ) but there's also KIcon(
iconName, pointerToIconLoader ). What do I need to do to port
On Fri, Jul 25, 2014 at 5:45 PM, Martin Klapetek
martin.klape...@gmail.com wrote:
You can do
QIcon icon(new KIconEngine(iconName, pointerToIconLoader));
Thanks. I'll update the porting documentation and the porting script.
David E. Narvaez
___
Hi,
What's the new way to do KDialog::makeStandardCaption[0] withot
KDELibs4Support?
Thanks.
David E. Narvaez
[0]
http://api.kde.org/4.x-api/kdelibs-apidocs/kdeui/html/classKDialog.html#a765be466448a0212674700a8f843966e
___
Kde-frameworks-devel
27 matches
Mail list logo
