Review Request 120062: KActionCollection::setDefaultShortcuts now makes the shortcut active too.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120062/ --- Review request for KDE Frameworks, Christoph Cullmann, Kevin Ottens, and Friedrich W. H. Kossebau. Repository: kxmlgui Description --- This simplifies app development, which otherwise needs to write everything twice, like this: m_actFullScreen-setShortcut(Qt::Key_F11) collection-setDefaultShortcut(m_actFullScreen, Qt::Key_F11); Diffs - autotests/kactioncollectiontest.cpp 9047b32b3909371b42a9b26c79c5a58376a84783 src/kactioncollection.h 5dbc3c2ddd8f93af9874454d735ad2a237bf4afa src/kactioncollection.cpp 6c7af0ffeb7e874ea0bce8096abde5c7df41f2e5 Diff: https://git.reviewboard.kde.org/r/120062/diff/ Testing --- kactioncollectiontest now skips calling setShortcut if it's the same as the default, and still passes. Thanks, David Faure ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120062: KActionCollection::setDefaultShortcuts now makes the shortcut active too.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120062/ --- (Updated Sept. 5, 2014, 8:39 a.m.) Review request for KDE Frameworks, Christoph Cullmann, Kevin Ottens, Friedrich W. H. Kossebau, and Laurent Montel. Repository: kxmlgui Description --- This simplifies app development, which otherwise needs to write everything twice, like this: m_actFullScreen-setShortcut(Qt::Key_F11) collection-setDefaultShortcut(m_actFullScreen, Qt::Key_F11); Diffs - autotests/kactioncollectiontest.cpp 9047b32b3909371b42a9b26c79c5a58376a84783 src/kactioncollection.h 5dbc3c2ddd8f93af9874454d735ad2a237bf4afa src/kactioncollection.cpp 6c7af0ffeb7e874ea0bce8096abde5c7df41f2e5 Diff: https://git.reviewboard.kde.org/r/120062/diff/ Testing --- kactioncollectiontest now skips calling setShortcut if it's the same as the default, and still passes. Thanks, David Faure ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120062: KActionCollection::setDefaultShortcuts now makes the shortcut active too.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120062/#review65825 --- For me it's better. I like it. For me Ship it is a good idea :) And tomorrow you tag kf5.2 so it will good to have it in this release. - Laurent Montel On sep. 5, 2014, 8:39 matin, David Faure wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120062/ --- (Updated sep. 5, 2014, 8:39 matin) Review request for KDE Frameworks, Christoph Cullmann, Kevin Ottens, Friedrich W. H. Kossebau, and Laurent Montel. Repository: kxmlgui Description --- This simplifies app development, which otherwise needs to write everything twice, like this: m_actFullScreen-setShortcut(Qt::Key_F11) collection-setDefaultShortcut(m_actFullScreen, Qt::Key_F11); Diffs - autotests/kactioncollectiontest.cpp 9047b32b3909371b42a9b26c79c5a58376a84783 src/kactioncollection.h 5dbc3c2ddd8f93af9874454d735ad2a237bf4afa src/kactioncollection.cpp 6c7af0ffeb7e874ea0bce8096abde5c7df41f2e5 Diff: https://git.reviewboard.kde.org/r/120062/diff/ Testing --- kactioncollectiontest now skips calling setShortcut if it's the same as the default, and still passes. Thanks, David Faure ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120062: KActionCollection::setDefaultShortcuts now makes the shortcut active too.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120062/#review65826 --- Looks like good idea. - Christoph Cullmann On Sept. 5, 2014, 8:39 a.m., David Faure wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120062/ --- (Updated Sept. 5, 2014, 8:39 a.m.) Review request for KDE Frameworks, Christoph Cullmann, Kevin Ottens, Friedrich W. H. Kossebau, and Laurent Montel. Repository: kxmlgui Description --- This simplifies app development, which otherwise needs to write everything twice, like this: m_actFullScreen-setShortcut(Qt::Key_F11) collection-setDefaultShortcut(m_actFullScreen, Qt::Key_F11); Diffs - autotests/kactioncollectiontest.cpp 9047b32b3909371b42a9b26c79c5a58376a84783 src/kactioncollection.h 5dbc3c2ddd8f93af9874454d735ad2a237bf4afa src/kactioncollection.cpp 6c7af0ffeb7e874ea0bce8096abde5c7df41f2e5 Diff: https://git.reviewboard.kde.org/r/120062/diff/ Testing --- kactioncollectiontest now skips calling setShortcut if it's the same as the default, and still passes. Thanks, David Faure ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119798: Generating PkgConfig files from ECM
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119798/#review65841
---
Sorry to still be nitpicking documentation, but I view it as one of the most
important parts of the code.
modules/ECMGeneratePkgConfigFile.cmake
https://git.reviewboard.kde.org/r/119798/#comment45997
Not really true any more (while the variable is created, it is only maybe
done by the function, and the default value depends on the first call of the
function with the INSTALL flag). So I'd just discard this sentence.
modules/ECMGeneratePkgConfigFile.cmake
https://git.reviewboard.kde.org/r/119798/#comment45999
You should explicitly say this is the name that projects will use when
querying pkg-config
modules/ECMGeneratePkgConfigFile.cmake
https://git.reviewboard.kde.org/r/119798/#comment45998
Talking about the Name: field is not very useful for people not very
familiar with pkg-config. It would be better to say that it's the
human-readable name in pkg-config.
I wonder if that should even be a separate argument.
modules/ECMGeneratePkgConfigFile.cmake
https://git.reviewboard.kde.org/r/119798/#comment46000
space (receivethe)
modules/ECMGeneratePkgConfigFile.cmake
https://git.reviewboard.kde.org/r/119798/#comment46001
missing y (subdirector)
- Alex Merry
On Sept. 3, 2014, 10:53 a.m., Aleix Pol Gonzalez wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119798/
---
(Updated Sept. 3, 2014, 10:53 a.m.)
Review request for Build System, KDE Frameworks and Harald Sitter.
Repository: extra-cmake-modules
Description
---
So we decided we wanted those .pc files, so I created a small script that
generates one, I haven't used pc in the past, so feedback is welcome.
Diffs
-
modules/ECMGeneratePkgConfigFile.cmake PRE-CREATION
tests/CMakeLists.txt 65de038
tests/ECMGeneratePkgConfigFile/CMakeLists.txt PRE-CREATION
tests/ECMGeneratePkgConfigFile/KF5CoreAddons.pc PRE-CREATION
tests/ECMGeneratePkgConfigFile/run_test.cmake.config PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/119798/diff/
Testing
---
I added it in KCoreAddons, this is the patch:
diff --git src/lib/CMakeLists.txt src/lib/CMakeLists.txt
index 26eb5a1..3a07d1c 100644
--- src/lib/CMakeLists.txt
+++ src/lib/CMakeLists.txt
@@ -188,4 +188,6 @@ install(FILES
include(ECMGeneratePriFile)
ecm_generate_pri_file(BASE_NAME KCoreAddons LIB_NAME KF5CoreAddons DEPS
core FILENAME_VAR PRI_FILENAME INCLUDE_INSTALL_DIR
${KF5_INCLUDE_INSTALL_DIR}/KCoreAddons)
+ecm_generate_pkgconfig_file(BASE_NAME KCoreAddons LIB_NAME KF5CoreAddons
DEPS Qt5Core INCLUDE_INSTALL_DIR ${KF5_INCLUDE_INSTALL_DIR}/KCoreAddons
INSTALL)
install(FILES ${PRI_FILENAME} DESTINATION ${ECM_MKSPECS_INSTALL_DIR})
This is the result, on my system:
Name: KF5CoreAddons
Version: 5.1.0
Libs: -L/home/kde-devel/kde5/lib64 -l/home/kde-devel/kde5/lib64
Cflags: -I/home/kde-devel/kde5/include/KF5/KCoreAddons
Requires: Qt5Core
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120058: Move imagethumbnailer away from KDE4Support
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120058/ --- (Updated Sept. 5, 2014, 4:56 p.m.) Review request for KDE Frameworks. Repository: kio-extras Description --- Remove unused includes and we don't need KDE4Support anymore. I alse replaced some tabs with spaces. Diffs (updated) - thumbnail/CMakeLists.txt bd40c0e thumbnail/imagecreator.h d06c9fa thumbnail/imagecreator.cpp dd5ffe2 Diff: https://git.reviewboard.kde.org/r/120058/diff/ Testing --- Removed my thumbnail cache and created new thumbnails. Works both from dolphin and from plasma. Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119594: fix FileDialog size restorage
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119594/ --- (Updated Sept. 5, 2014, 7:01 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, kdelibs, Aleix Pol Gonzalez, Lukáš Tinkl, and Martin Klapetek. Repository: frameworkintegration Description --- - saving in the deconstrutor is insufficient, the dialog might survive the runtime - needs to be saved when the dialog is finished or just closed (the closeEvent is not invoked if at least a sync dialog is finished) - ensure a windowHandle and then restore the window size before calling ::exec() - workaround an apparent QWidget QPA bug where even for a created platform window the QWindow geometry is not applied on the QWidget Diffs - src/platformtheme/kdeplatformfiledialogbase.cpp b823bc7 src/platformtheme/kdeplatformfiledialogbase_p.h 8ef5b1e src/platformtheme/kdeplatformfiledialoghelper.h 406a4f1 src/platformtheme/kdeplatformfiledialoghelper.cpp 520b6f5 Diff: https://git.reviewboard.kde.org/r/119594/diff/ Testing --- See https://git.reviewboard.kde.org/r/119512/ Thanks, Thomas Lübking ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: What to do with autostart scripts? (kinit / ksmserver problem)
On Tuesday 02 September 2014 11:06:02 Luca Beltrame wrote: In data martedì 19 agosto 2014 21:48:04, David Faure ha scritto: I'd pick option 1 - do it all in ksmserver. I suppose this would mean running all but .desktop files (which are handled by kinit)? I thought all was clear ;) I see no reason why kinit should keep handling such workspace stuff. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Error building KService
Hi! I get this error when building KService. I don't quite get it, what it means. Could someone help me deciphering the error? Thanks! David Gil # kdesrc-build running: 'make' '-j2' # from directory: /home/david/devel/kf5-development/build/frameworks/kservice Scanning dependencies of target -home-david-devel-kf5-development-build-frameworks-kservice-docs-desktoptojson-desktoptojson-8 Scanning dependencies of target -home-david-devel-kf5-development-build-frameworks-kservice-docs-kbuildsycoca5-kbuildsycoca5-8 [ 1%] Generating desktoptojson.8 [ 2%] Generating kbuildsycoca5.8 Note: Writing kbuildsycoca5.8 Note: Writing desktoptojson.8 [ 2%] Built target -home-david-devel-kf5-development-build-frameworks-kservice-docs-kbuildsycoca5-kbuildsycoca5-8 Scanning dependencies of target KF5Service_automoc [ 3%] Automatic moc for target KF5Service [ 3%] Built target -home-david-devel-kf5-development-build-frameworks-kservice-docs-desktoptojson-desktoptojson-8 Scanning dependencies of target kbuildsycoca5_automoc [ 4%] Automatic moc for target kbuildsycoca5 Generating moc_kbuildsycoca.cpp Generating moc_vfolder_menu.cpp [ 4%] Built target kbuildsycoca5_automoc Scanning dependencies of target fakeplugin_automoc [ 5%] Automatic moc for target fakeplugin Generating moc_ktoolinvocation.cpp Generating moc_kautostart.cpp Generating moc_ksycoca.cpp [ 5%] Built target KF5Service_automoc Scanning dependencies of target kautostarttest_automoc [ 6%] Automatic moc for target kautostarttest Generating nsaplugin.moc /home/david/devel/kf5-development/src/frameworks/kservice/autotests/nsaplugin.cpp:0: Note: No relevant classes found. No output generated. Generating moc_kautostarttest.cpp Generating moc_kwaitforsignal.cpp [ 6%] Built target kautostarttest_automoc Scanning dependencies of target kmimeassociationstest_automoc [ 7%] Automatic moc for target kmimeassociationstest Generating moc_nsaplugin.cpp [ 7%] Built target fakeplugin_automoc Scanning dependencies of target kservicetest_automoc [ 9%] Automatic moc for target kservicetest Generating kmimeassociationstest.moc [ 9%] Built target kmimeassociationstest_automoc Scanning dependencies of target ksycocadicttest_automoc [ 10%] Automatic moc for target ksycocadicttest Generating moc_kservicetest.cpp Generating moc_kwaitforsignal.cpp [ 10%] Built target kservicetest_automoc Scanning dependencies of target ksycocathreadtest_automoc [ 11%] Automatic moc for target ksycocathreadtest Generating ksycocathreadtest.moc Generating moc_kwaitforsignal.cpp [ 11%] Built target ksycocathreadtest_automoc Scanning dependencies of target pluginlocatortest_automoc Generating ksycocadicttest.moc Generating moc_kwaitforsignal.cpp [ 12%] [ 12%] Built target ksycocadicttest_automoc Automatic moc for target pluginlocatortest Scanning dependencies of target findservice_automoc [ 13%] Automatic moc for target findservice [ 13%] Built target findservice_automoc Scanning dependencies of target kdbusservicestartertest_automoc [ 14%] Automatic moc for target kdbusservicestartertest [ 14%] Built target kdbusservicestartertest_automoc Scanning dependencies of target ksycocatest_automoc [ 15%] Automatic moc for target ksycocatest [ 15%] Built target ksycocatest_automoc Scanning dependencies of target startserviceby_automoc [ 17%] Automatic moc for target startserviceby [ 17%] Built target startserviceby_automoc Scanning dependencies of target kservice-pluginloadertest_automoc [ 18%] Automatic moc for target kservice-pluginloadertest Generating moc_pluginlocatortest.cpp Generating moc_kwaitforsignal.cpp [ 18%] Built target pluginlocatortest_automoc [ 19%] Generating klauncher_iface.cpp, klauncher_iface.h Generating moc_plugintest.cpp [ 19%] Built target kservice-pluginloadertest_automoc [ 20%] Generating klauncher_iface.moc Scanning dependencies of target KF5Service [ 21%] [ 22%] Building CXX object src/CMakeFiles/KF5Service.dir/kdeinit/ktoolinvocation.cpp.o Building CXX object src/CMakeFiles/KF5Service.dir/services/kautostart.cpp.o [ 23%] Building CXX object src/CMakeFiles/KF5Service.dir/services/kmimetypefactory.cpp.o [ 25%] Building CXX object src/CMakeFiles/KF5Service.dir/services/kmimetypetrader.cpp.o [ 26%] Building CXX object src/CMakeFiles/KF5Service.dir/services/kservice.cpp.o In file included from /usr/include/kexportplugin.h:21:0, from /usr/include/kpluginfactory.h:31, from /home/david/devel/kf5-development/src/frameworks/kservice/src/services/kservice.h:27, from /home/david/devel/kf5-development/src/frameworks/kservice/src/services/kmimetypetrader.h:23, from /home/david/devel/kf5-development/src/frameworks/kservice/src/services/kmimetypetrader.cpp:20: /usr/include/kglobal.h:42:35: error: conflicting declaration ‘typedef class KSharedPtrKSharedConfig KSharedConfigPtr’ typedef KSharedPtrKSharedConfig KSharedConfigPtr; ^ In file included from /usr/include/kcomponentdata.h:23:0,
Re: Review Request 119936: Fix inconsistencies in KPluginInfo and add a basic unit test
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119936/#review65863 --- Ship it! src/services/kplugininfo.h https://git.reviewboard.kde.org/r/119936/#comment46017 @since 5.2 src/services/kplugininfo.cpp https://git.reviewboard.kde.org/r/119936/#comment46018 can't that lead to a crash if people use other methods after that? - David Faure On Aug. 28, 2014, 7:48 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119936/ --- (Updated Aug. 28, 2014, 7:48 p.m.) Review request for KDE Frameworks. Repository: kservice Description --- This is a series of small commits, I hope it is fine to have them as one diff: --- Add a basic unit test for KPluginInfo --- KPluginInfoTest: Also test reading a custom property --- Also test KPluginInfo(KService::Ptr) constructor --- Fix KPluginInfo::libraryPath() when constructing from a .desktop file --- Fix KPluginInfo::dependencies() when constructing from a .desktop file Previously it would treat X-KDE-PluginInfo-Depends= (with no value) as a string list with one element (the empty string). When constructing from a KService::Ptr using the same file we get an empty string list as one would expect. This makes the behaviour of the KPluginInfo(QString) constructor match the KPluginInfo(KService::Ptr) version. --- Fix KPluginInfo::isValid() when constructing from a .desktop file Previously it would always return true, even if the file didn't exist or was no valid .desktop file. --- Fix KPluginInfo::libraryPath() when constructing from a KService::Ptr Diffs - autotests/CMakeLists.txt da83f46a9dcd1fa7801bead5715abf51cd12d668 autotests/kplugininfotest.cpp PRE-CREATION src/services/kplugininfo.h 9a9eceee5c90c6a5516c3b03473ff6437e9b2fe4 src/services/kplugininfo.cpp 6fadf46c902455e7f5c9ece5b34fb1e40d0a97f7 Diff: https://git.reviewboard.kde.org/r/119936/diff/ Testing --- Unit test passes Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119975: KDBusService shouldn't crash upon bad application name
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119975/#review65864 --- Ship it! Ship It! - David Faure On Aug. 28, 2014, 3:57 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119975/ --- (Updated Aug. 28, 2014, 3:57 p.m.) Review request for KDE Frameworks. Repository: kdbusaddons Description --- If the application name has a '-', Qt asserts. Instead of going there, remove the '-' and output a warning so the replacement is noticed and fixable. Diffs - src/kdbusservice.cpp a9b7cc8 Diff: https://git.reviewboard.kde.org/r/119975/diff/ Testing --- Ran tests, reproduced with an application. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119970: Add functions to convert between KPluginInfo and KPluginMetaData to KPluginInfo ( + unit test)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119970/#review65866 --- Ah wait, I do: lots of @since 5.2 missing in api docs. And a [ChangeLog] entry like in Qt in the commit log, although I haven't written/stolen the script to extract that yet. - David Faure On Aug. 28, 2014, 7:50 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119970/ --- (Updated Aug. 28, 2014, 7:50 p.m.) Review request for KDE Frameworks. Repository: kservice Description --- - Add KPluginInfo::toKPluginMetaData and a unit test for it - Add KPluginInfo::fromKPluginMetaData and add a unit test for it - KPluginInfo: convert all meta data, not just the well known properties - Add functions to convert between lists of KPluginMetaData and KPluginInfo This needs https://git.reviewboard.kde.org/r/119936 Diffs - autotests/kplugininfotest.cpp PRE-CREATION src/services/kplugininfo.h 9a9eceee5c90c6a5516c3b03473ff6437e9b2fe4 src/services/kplugininfo.cpp 6fadf46c902455e7f5c9ece5b34fb1e40d0a97f7 Diff: https://git.reviewboard.kde.org/r/119970/diff/ Testing --- Unit test passes, used successfully for loading KDevelop plugins with KPluginLoader::findPlugins() Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120071: QUrl::fromUserInput in kfilewidget
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120071/#review65867 --- Ship it! Ship It! - David Faure On Sept. 5, 2014, 6:31 p.m., Maarten De Meyer wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120071/ --- (Updated Sept. 5, 2014, 6:31 p.m.) Review request for KDE Frameworks and David Faure. Bugs: 337557 https://bugs.kde.org/show_bug.cgi?id=337557 Repository: kio Description --- KUrl porting error. KFileDialog cannot open url from user input because it has no scheme. Diffs - src/filewidgets/kfilewidget.cpp 10c6120 Diff: https://git.reviewboard.kde.org/r/120071/diff/ Testing --- Now I can open absolute url's with KFileDialog Local and remote files work. Not tested: KDEPlatformFileDialog Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 120075: KArchive: add support for rcc files
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120075/ --- Review request for KDE Frameworks. Repository: karchive Description --- These the dynamic binary resources created by Qt's rcc tool from a .qrc file and the files it points to. [ChangeLog] KArchive: add support for rcc files The idea came up while talking to the GCompris author, who mentionned he's using .rcc files quite a lot in his application and was missing a way to look into such a file to find out what it contains. Now with very little work, ark could support these too. It just needs to be ported to KF5 first :-) Diffs - autotests/karchivetest.h 567be075758f6afd4bdff5a2f6f8ef5e392a53eb autotests/karchivetest.cpp 6b50f32a6d99756ba246262067dd71573f129256 autotests/runtime_resource.rcc PRE-CREATION src/CMakeLists.txt 948a25b5e017a11c1577c7c324f2fa3545b13f52 src/krcc.h PRE-CREATION src/krcc.cpp PRE-CREATION tests/CMakeLists.txt ebcd01f5bfdec1298bbc936b9429b187f50c9b45 tests/krcctest.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120075/diff/ Testing --- Manual test prog, autotest. Thanks, David Faure ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Error building KService
On Friday 05 September 2014 23:48:24 David Gil Oliva wrote: In file included from /usr/include/kexportplugin.h:21:0, /usr/include/kglobal.h:4 It's picking up kdelibs4 headers from /usr/include. Easy solution: remove kdelibs4-dev or whatever that package is called. Correct solution: make VERBOSE=1, find out if -I/home/david/KF5/include/KF5/KCoreAddons is there and if -I/usr/include is there (it should NOT) and if both are there, in which order. And check if kexportplugin.h exists in that KCoreAddons dir, of course. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build became unstable: frameworkintegration_master_qt5 #105
See http://build.kde.org/job/frameworkintegration_master_qt5/105/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120040: Install kdesu under bin
On Sept. 2, 2014, 6:37 p.m., Marco Martin wrote: I'm a bit worried by the multitude of user and distro specific scripts that rely on kdesu being present :/ Marco Martin wrote: to me either way it gets fixed i'm ok. the other option is to keep it called kdesu, so it wouldn't be coinstallable so distributions would need to make kdesu a package of its own, alternative with the kde4 kdesu, but it may look even more problematic to me Scripts will just have to be updated, just like scripts calling kioclient4, kde4-config, kstart, kdecp, kbuildsycoca4 and so many other things. We can't have both source-compat-for-scripts and co-installability. It's one or the other. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120040/#review65734 --- On Sept. 2, 2014, 6:27 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120040/ --- (Updated Sept. 2, 2014, 6:27 p.m.) Review request for KDE Frameworks and Plasma. Repository: kde-cli-tools Description --- this is a part of adressing the bug https://bugs.kde.org/show_bug.cgi?id=338755 https://bugs.kde.org/show_bug.cgi?id=338756 in kde4 kdesu was installed under bin, and should still, being something that should be invokable but renames it to kdesu5, for coinstallability reasons therefore, kio/src/core/desktopexecparser.cpp should be modified to search for kdesu5 instead of kdesu Diffs - kdesu/CMakeLists.txt 2a70831 Diff: https://git.reviewboard.kde.org/r/120040/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is still unstable: kwindowsystem_master_qt5 » All,LINBUILDER #92
See http://build.kde.org/job/kwindowsystem_master_qt5/Variation=All,label=LINBUILDER/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120025: Have KStandardAction::create(...) call KActionCollection::setDefaultShortcuts()
On Sept. 1, 2014, 7:55 vorm., David Faure wrote: You wrote: I have not yet completely grasped the concept of the default shortcuts and why they are set only explicitely via KActionCollection::setDefaultShortcuts. I think the concept is simple. QAction only knows the current shortcuts, those that will trigger the action. Now imagine that the user configures the shortcut for the quit action (default Ctrl+Q) to use something else instead (Ctrl+E for exit, whatever). QAction will then only know about Ctrl+E, the actual active shortcut. But the shortcut configuration dialog needs to know that the default shortcut was Ctrl+Q, so that we can offer revert to default, for instance (and to show that the shortcut was manually modified). This information API is in KActionCollection because, well, there's no KAction anymore, and it stores the default shortcut into the QAction as a dynamic property. Well, this means another solution could be to just set the dynamic property in KStandardAction, without going through KActionCollection via invokeMethod. That would probably more robust, including the case of creating an action without a collection as parent, and then putting it into a collection later on. Good thing I wrote the explanation, it made me realize that there is a better solution :-) Ah, so KActionCollection::setDefaultShortcuts is from KAction, and might not just have found a better place? I see. When looking at the implementation I was puzzled why it is not a static method, given that it does not use the KActionCollection object itself for anything. So not really done by original design. Putting the property already directly in KStandardAction seems an option as well. Creates an informal dependency, as the property id used has to be kept in sync, but might be okay. I am not sure though if the property should be set also if there is no KActionCollection given as parent, because that would mean that people using KConfigWidgets, but not KXMLGUI, still will get a payload of that extra property on every standard action they create. Instinctively I would say No to that, but perhaps others are more pragmatic and do not do byte-counting? - Friedrich W. H. --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120025/#review65624 --- On Aug. 31, 2014, 4:40 nachm., Friedrich W. H. Kossebau wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120025/ --- (Updated Aug. 31, 2014, 4:40 nachm.) Review request for KDE Frameworks. Bugs: 338222 https://bugs.kde.org/show_bug.cgi?id=338222 Repository: kconfigwidgets Description --- As e.g. reported in https://bugs.kde.org/show_bug.cgi?id=338222 (False positive critical warnings for KStandardActions) currently KXMLGUIFactoryPrivate::saveDefaultActionProperties complains about lots of actions that have been created properly via KStandardActions with a KActionCollection as parent. Just grep the log of your favourite XMLGUI-based KF5-ported program to see yourself. I have not yet completely grasped the concept of the default shortcuts and why they are set only explicitely via KActionCollection::setDefaultShortcuts. But to me it makes some sense to have this automatically called for all standardactions which are created directly with a KActionCollection as parent. I decided not to change KActionCollection::addAction because I had even less idea what all might be affected by that. So this is what this patch does: * add a call to KActionCollection::setDefaultShortcuts if there is a standard shortcut (via QMetaObject::invokeMethod, like done for KActionCollection::addAction) * also move code which only should be done in case of a created action into one, same branch Needs https://git.reviewboard.kde.org/r/120024/ to make KActionCollection::setDefaultShortcuts() invokable. Diffs - src/kstandardaction.cpp a18527b Diff: https://git.reviewboard.kde.org/r/120025/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119970: Add functions to convert between KPluginInfo and KPluginMetaData to KPluginInfo ( + unit test)
On Sept. 6, 2014, 12:07 vorm., David Faure wrote: Between KService, KPluginInfo (.desktop) and KPluginMetaData (json) (all of which represent a plugin), it's getting a bit confusing :) But I can't see anything wrong in this commit :) My plan is to implement KPluginInfo based on KPluginMetaData, which seems to work fine (RR upcoming) - Alexander --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119970/#review65865 --- On Aug. 28, 2014, 9:50 nachm., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119970/ --- (Updated Aug. 28, 2014, 9:50 nachm.) Review request for KDE Frameworks. Repository: kservice Description --- - Add KPluginInfo::toKPluginMetaData and a unit test for it - Add KPluginInfo::fromKPluginMetaData and add a unit test for it - KPluginInfo: convert all meta data, not just the well known properties - Add functions to convert between lists of KPluginMetaData and KPluginInfo This needs https://git.reviewboard.kde.org/r/119936 Diffs - autotests/kplugininfotest.cpp PRE-CREATION src/services/kplugininfo.h 9a9eceee5c90c6a5516c3b03473ff6437e9b2fe4 src/services/kplugininfo.cpp 6fadf46c902455e7f5c9ece5b34fb1e40d0a97f7 Diff: https://git.reviewboard.kde.org/r/119970/diff/ Testing --- Unit test passes, used successfully for loading KDevelop plugins with KPluginLoader::findPlugins() Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119936: Fix inconsistencies in KPluginInfo and add a basic unit test
On Sept. 5, 2014, 11:58 nachm., David Faure wrote: src/services/kplugininfo.cpp, line 95 https://git.reviewboard.kde.org/r/119936/diff/4/?file=308036#file308036line95 can't that lead to a crash if people use other methods after that? Well, it is the same as when KPluginInfo is constructed from a null KService::Ptr, so IMHO it ist more or less the same - Alexander --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119936/#review65863 --- On Aug. 28, 2014, 9:48 nachm., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119936/ --- (Updated Aug. 28, 2014, 9:48 nachm.) Review request for KDE Frameworks. Repository: kservice Description --- This is a series of small commits, I hope it is fine to have them as one diff: --- Add a basic unit test for KPluginInfo --- KPluginInfoTest: Also test reading a custom property --- Also test KPluginInfo(KService::Ptr) constructor --- Fix KPluginInfo::libraryPath() when constructing from a .desktop file --- Fix KPluginInfo::dependencies() when constructing from a .desktop file Previously it would treat X-KDE-PluginInfo-Depends= (with no value) as a string list with one element (the empty string). When constructing from a KService::Ptr using the same file we get an empty string list as one would expect. This makes the behaviour of the KPluginInfo(QString) constructor match the KPluginInfo(KService::Ptr) version. --- Fix KPluginInfo::isValid() when constructing from a .desktop file Previously it would always return true, even if the file didn't exist or was no valid .desktop file. --- Fix KPluginInfo::libraryPath() when constructing from a KService::Ptr Diffs - autotests/CMakeLists.txt da83f46a9dcd1fa7801bead5715abf51cd12d668 autotests/kplugininfotest.cpp PRE-CREATION src/services/kplugininfo.h 9a9eceee5c90c6a5516c3b03473ff6437e9b2fe4 src/services/kplugininfo.cpp 6fadf46c902455e7f5c9ece5b34fb1e40d0a97f7 Diff: https://git.reviewboard.kde.org/r/119936/diff/ Testing --- Unit test passes Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
