Review Request 121062: use correct ki18n_wrap_ui in ki18n based framework
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121062/ --- Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark. Repository: khtml Description --- see summary Diffs - src/CMakeLists.txt 9e71fc3 tests/CMakeLists.txt 40f37ee Diff: https://git.reviewboard.kde.org/r/121062/diff/ Testing --- builds Thanks, Burkhard Lück ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 121063: use correct ki18n_wrap_ui in ki18n based framework
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121063/ --- Review request for KDE Frameworks. Repository: kdelibs4support Description --- see summary Diffs - src/kssl/kcm/CMakeLists.txt 4e5ac11 tests/CMakeLists.txt 25275e8 Diff: https://git.reviewboard.kde.org/r/121063/diff/ Testing --- builds Thanks, Burkhard Lück ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 121065: use correct ki18n_wrap_ui in ki18n based plasma-frameworks
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121065/ --- Review request for KDE Frameworks. Repository: plasma-framework Description --- see summary Diffs - examples/kpart/CMakeLists.txt ff62817 examples/testcontainmentactionsplugin/CMakeLists.txt cb2cd56 src/tools/port-cmake.sh 4d49e9a Diff: https://git.reviewboard.kde.org/r/121065/diff/ Testing --- builds Thanks, Burkhard Lück ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 121066: use correct ki18n_wrap_ui in ki18n based frameworks/kwallet
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121066/ --- Review request for KDE Frameworks. Repository: kwallet Description --- see summary Diffs - src/runtime/kwalletd/CMakeLists.txt 907ef19 Diff: https://git.reviewboard.kde.org/r/121066/diff/ Testing --- builds Thanks, Burkhard Lück ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 121067: use correct ki18n_wrap_ui in ki18n based frameworks/knotifyconfig
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121067/ --- Review request for KDE Frameworks. Repository: knotifyconfig Description --- see summary Diffs - tests/CMakeLists.txt 8787858 Diff: https://git.reviewboard.kde.org/r/121067/diff/ Testing --- builds Thanks, Burkhard Lück ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 121068: use correct ki18n_wrap_ui in ki18n based frameworks/kjsembed
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121068/ --- Review request for KDE Frameworks. Repository: kjsembed Description --- see summary Diffs - examples/kjsconsole/CMakeLists.txt ba98fff Diff: https://git.reviewboard.kde.org/r/121068/diff/ Testing --- builds Thanks, Burkhard Lück ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121021: reverse ShowIconsOnPushButtons default
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121021/#review70083 --- Code wise it's fine, same for the other two. It might be a good idea to wait for frameworks 5.6 otherwise we have a mixup between latest frameworks and latest plasma. I'm not sure about art side, in that forum thread Hugo says: Personally, I do like icons on pushbuttons and the redundancy it bring Given he wrote most the Breeze style, frankly his opinion outranks everyone else combined. - David Edmundson On Nov. 6, 2014, 9:06 p.m., Thomas Lübking wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121021/ --- (Updated Nov. 6, 2014, 9:06 p.m.) Review request for KDE Frameworks, kdelibs and Thomas Pfeiffer. Repository: kdelibs4support Description --- sumamrized, also see https://forum.kde.org/viewtopic.php?f=285t=123587 https://git.reviewboard.kde.org/r/121019/ https://git.reviewboard.kde.org/r/121020/ Diffs - src/kdeui/k4style.cpp a1a2ab1 src/kdeui/kglobalsettings.h d63ac69 Diff: https://git.reviewboard.kde.org/r/121021/diff/ Testing --- Thanks, Thomas Lübking ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119607: Support for .hidden files
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119607/#review70102
---
src/core/kcoredirlister.cpp
https://git.reviewboard.kde.org/r/119607/#comment49065
After this line, try adding
if (!url.isLocalFile()) {
const QString localPath = dir-rootItem.localPath();
if (!localPath.isEmpty()) {
filesToHide =
filesInDotHiddenForDir(QUrl::fromLocalFile(localPath));
}
}
This should take care of the case of desktop:/ URLs. Can you test?
- David Faure
On Sept. 18, 2014, 10:06 a.m., Bruno Nova wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119607/
---
(Updated Sept. 18, 2014, 10:06 a.m.)
Review request for KDE Frameworks and David Faure.
Bugs: 64740 and 246260
https://bugs.kde.org/show_bug.cgi?id=64740
https://bugs.kde.org/show_bug.cgi?id=246260
Repository: kio
Description
---
This adds support for *.hidden* files to KDE.
When listing a directory, the files/folders listed in the *.hidden* file will
be hidden, unless the user has chosen to show hidden files.
This patch was initially based on the patch provided by Mark in Bug #246260.
Diffs
-
src/core/kcoredirlister.h e6ba2ac
src/core/kcoredirlister.cpp a31d629
src/core/kfileitem.h bebc241
src/core/kfileitem.cpp 74dc069
Diff: https://git.reviewboard.kde.org/r/119607/diff/
Testing
---
Built and tested the patch in Project Neon.
Dolphin was still using KDE4/Qt4 version of the library, so I only tested
using the desktop folder widget, and folder desktop.
It worked correctly when I pointed it to ~ and ~/Desktop (I added
.hidden there).
However, it didn't work when I pointed it to the Desktop folder (the
default option, not the custom location ~/Desktop).
More testing is required.
The version for KDE4/Qt4 submitted to Bug #246260 was tested in Kubuntu
14.04, and it worked everywhere I tested (Dolphin, open/save dialogs, folder
widget and detailed/tree view in Dolphin).
It wasn't an intensive test, though.
Thanks,
Bruno Nova
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 121075: Also export inner KBookmarkOwner::FutureBookmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121075/ --- Review request for KDE Frameworks and kdewin. Repository: kbookmarks Description --- Konqueror references KBookmarkOwner::FutureBookmark, which is not properly exported, causing the build to fail. Diffs - src/kbookmarkowner.h 4d6fe0b Diff: https://git.reviewboard.kde.org/r/121075/diff/ Testing --- It builds (MSVC2013 - 64bit), and Konqueror builds after this patch (along other patches I'm sending to review today). Kdebase-apps is still not very functional, though (missing icons and weird UI). Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 121076: Do not require KF5::Su on Windows
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121076/ --- Review request for KDE Frameworks and kdewin. Repository: kde-baseapps Description --- kdepasswd, which requires it, is already disabled on Windows. There is also konq-plugins/shellcmdplugins which was also disabled on Windows, but konq-plugins is entirely disabled now. Diffs - CMakeLists.txt f02b069 Diff: https://git.reviewboard.kde.org/r/121076/diff/ Testing --- It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending to review today). Kdebase-apps is still not very functional, though (missing icons and weird UI). Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121076: Do not require KF5::Su on Windows
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121076/ --- (Updated Nov. 8, 2014, 10:14 p.m.) Review request for KDE Base Apps, KDE Frameworks and kdewin. Repository: kde-baseapps Description --- kdepasswd, which requires it, is already disabled on Windows. There is also konq-plugins/shellcmdplugins which was also disabled on Windows, but konq-plugins is entirely disabled now. Diffs - CMakeLists.txt f02b069 Diff: https://git.reviewboard.kde.org/r/121076/diff/ Testing --- It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending to review today). Kdebase-apps is still not very functional, though (missing icons and weird UI). Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 121077: Check before using -Wno-deprecated-declarations.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121077/ --- Review request for KDE Base Apps, KDE Frameworks and kdewin. Repository: kde-baseapps Description --- A simple cmake check to avoid errors on MSVC. Diffs - dolphin/src/CMakeLists.txt c074908 Diff: https://git.reviewboard.kde.org/r/121077/diff/ Testing --- It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending to review today). Kdebase-apps is still not very functional, though (missing icons and weird UI). Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 121078: Fix exports.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121078/ --- Review request for KDE Base Apps, KDE Frameworks and kdewin. Repository: kde-baseapps Description --- Use CMake's generate_export_header whenever possible, and fix some inconsistent exports. Also, use Q_DECL_EXPORT consistently across occurrences of kdemain for kdeinit apps (removing kdemacros.h where KDE_EXPORT was being in use). Diffs - dolphin/src/views/dolphinfileitemlistwidget.h 5f7c181 dolphin/src/views/dolphinitemlistview.h 7fd72e5 dolphin/src/views/versioncontrol/updateitemstatesthread.h 9b744d5 dolphin/src/views/versioncontrol/versioncontrolobserver.h 034ef8b dolphin/src/views/viewmodecontroller.h 9ea717a dolphin/src/views/viewproperties.h d3ea428 keditbookmarks/kbookmarkmodel/CMakeLists.txt 2f83af2 keditbookmarks/kbookmarkmodel/kbookmarkmodel_export.h b759bf9 keditbookmarks/main.cpp bc64193 konqueror/client/kfmclient.cpp 276452b konqueror/src/CMakeLists.txt 6831c88 konqueror/src/konq_statusbarmessagelabel.h a115d39 konqueror/src/konqmain.cpp 7a73231 konqueror/src/konqprivate_export.h 2dec78b dolphin/src/libdolphin_export.h ff0f125 dolphin/src/main.cpp 91d32a0 dolphin/src/kitemviews/private/kitemlistviewlayouter.h 0efcab1 dolphin/src/CMakeLists.txt c074908 dolphin/src/kitemviews/kfileitemlistview.h 9f07c9d dolphin/src/kitemviews/kfileitemlistwidget.h b7061d3 dolphin/src/kitemviews/kfileitemmodel.h 535e0f3 dolphin/src/kitemviews/kfileitemmodelrolesupdater.h e8b186a dolphin/src/kitemviews/kitemlistcontainer.h 55a9a11 dolphin/src/kitemviews/kitemlistcontroller.h 99df531 dolphin/src/kitemviews/kitemlistgroupheader.h 66fe929 dolphin/src/kitemviews/kitemlistheader.h fe2d0ac dolphin/src/kitemviews/kitemlistselectionmanager.h c4decd3 dolphin/src/kitemviews/kitemliststyleoption.h 782dd0e dolphin/src/kitemviews/kitemlistview.h cc0754f dolphin/src/kitemviews/kitemlistviewaccessible.h 674f1d1 dolphin/src/kitemviews/kitemlistwidget.h 07fc789 dolphin/src/kitemviews/kitemmodelbase.h 283cfa5 dolphin/src/kitemviews/kstandarditem.h 59190bf dolphin/src/kitemviews/kstandarditemlistgroupheader.h 871c93d dolphin/src/kitemviews/kstandarditemlistview.h eb07c7f dolphin/src/kitemviews/kstandarditemlistwidget.h 7683f84 dolphin/src/kitemviews/kstandarditemmodel.h 9d1db1a dolphin/src/kitemviews/private/kbaloorolesprovider.h f1ad5c7 dolphin/src/kitemviews/private/kfileitemmodeldirlister.h 94a0e39 dolphin/src/kitemviews/private/kfileitemmodelfilter.h e4fb0a2 dolphin/src/kitemviews/private/kitemlistheaderwidget.h b99f45f dolphin/src/kitemviews/private/kitemlistkeyboardsearchmanager.h 661178d dolphin/src/kitemviews/private/kitemlistrubberband.h aea58af dolphin/src/kitemviews/private/kitemlistselectiontoggle.h 8a1a857 dolphin/src/kitemviews/private/kitemlistsizehintresolver.h a0ad033 dolphin/src/kitemviews/private/kitemlistsmoothscroller.h ea56822 dolphin/src/kitemviews/private/kitemlistviewanimation.h e2e5338 dolphin/src/kitemviews/private/kpixmapmodifier.h 4f863c3 Diff: https://git.reviewboard.kde.org/r/121078/diff/ Testing --- It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending to review today). Kdebase-apps is still not very functional, though (missing icons and weird UI). Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 121079: Fix building dolphin tests on MSVC
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121079/ --- Review request for KDE Base Apps, KDE Frameworks and kdewin. Repository: kde-baseapps Description --- MSVC complains about missing symbols from their respective moc files on linking step. Diffs - dolphin/src/tests/CMakeLists.txt 60f6517 Diff: https://git.reviewboard.kde.org/r/121079/diff/ Testing --- It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending to review today). Kdebase-apps is still not very functional, though (missing icons and weird UI). Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 121080: Replace KDE_DUMMY_QHASH_FUNCTION.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121080/ --- Review request for KDE Base Apps, KDE Frameworks and kdewin. Repository: kde-baseapps Description --- Since we're not using kdemacros.h here anymore, KDE_DUMMY_QHASH_FUNCTION is not available. Implement it instead. Diffs - lib/konq/src/konq_historyentry.h de34d6b Diff: https://git.reviewboard.kde.org/r/121080/diff/ Testing --- It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending to review today). Kdebase-apps is still not very functional, though (missing icons and weird UI). Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 121081: QT_WA
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121081/ --- Review request for KDE Base Apps, KDE Frameworks and kdewin. Repository: kde-baseapps Description --- QT_WA is not available on Qt5. We also only use the Unicode version, anyways. Diffs - lib/konq/src/konq_copytomenu.cpp 7f97c12 Diff: https://git.reviewboard.kde.org/r/121081/diff/ Testing --- It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending to review today). Kdebase-apps is still not very functional, though (missing icons and weird UI). Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
