Re: Required and supported Qt versions
On Tuesday, 30 December 2014 09:32:08 CEST, David Faure wrote: Ideally every released minor version since 5.2 :-) i.e. 5.2, 5.3, 5.4. Possibly even dev. Hi, the CI which is plugged into Gerrit now checks the following combinations: - Qt 5.2.1, GCC 4.8.2 (RHEL7), release mode - Qt 5.3.2, clang 3.4.2 (RHEL7), release mode - Qt 5.4.0, GCC 4.8.2 (RHEL7), debug build The plasma-framework also has an extra profile similar to the 5.3.2 above, but with disabled X11 on top of that. Cheers, Jan -- Trojitá, a fast Qt IMAP e-mail client -- http://trojita.flaska.net/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121949: Add name of consumer to kservice_desktop_to_json() deprecation warning.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121949/#review73608 --- Ship it! Nice! - Alex Richardson On Jan. 9, 2015, 3:41 p.m., Elias Probst wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121949/ --- (Updated Jan. 9, 2015, 3:41 p.m.) Review request for KDE Frameworks. Repository: kservice Description --- Until now, there was no way to tell from the logged message where it was originating from. This change makes it easier to find the originating application. Diffs - src/services/kplugininfo.cpp aa5d26386eb17a7e552b29c8fa7961d68b16 Diff: https://git.reviewboard.kde.org/r/121949/diff/ Testing --- Getting now messages logged which look like this: ``` Constructing a KPluginInfo object from old style JSON. Please use kcoreaddons_desktop_to_json() for Kate Session Applet instead of kservice_desktop_to_json() in your CMake code. Constructing a KPluginInfo object from old style JSON. Please use kcoreaddons_desktop_to_json() for DataEngine for Kimpanel instead of kservice_desktop_to_json() in your CMake code. Constructing a KPluginInfo object from old style JSON. Please use kcoreaddons_desktop_to_json() for Konsole Profiles instead of kservice_desktop_to_json() in your CMake code. ``` This makes it definitely far easier to update the affected applications. Thanks, Elias Probst ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121949: Add name of consumer to kservice_desktop_to_json() deprecation warning.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121949/#review73607 --- Ahh I was thinking the same thing yesterday, good stuff :) +1 from me! - Martin Klapetek On Jan. 9, 2015, 4:41 p.m., Elias Probst wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121949/ --- (Updated Jan. 9, 2015, 4:41 p.m.) Review request for KDE Frameworks. Repository: kservice Description --- Until now, there was no way to tell from the logged message where it was originating from. This change makes it easier to find the originating application. Diffs - src/services/kplugininfo.cpp aa5d26386eb17a7e552b29c8fa7961d68b16 Diff: https://git.reviewboard.kde.org/r/121949/diff/ Testing --- Getting now messages logged which look like this: ``` Constructing a KPluginInfo object from old style JSON. Please use kcoreaddons_desktop_to_json() for Kate Session Applet instead of kservice_desktop_to_json() in your CMake code. Constructing a KPluginInfo object from old style JSON. Please use kcoreaddons_desktop_to_json() for DataEngine for Kimpanel instead of kservice_desktop_to_json() in your CMake code. Constructing a KPluginInfo object from old style JSON. Please use kcoreaddons_desktop_to_json() for Konsole Profiles instead of kservice_desktop_to_json() in your CMake code. ``` This makes it definitely far easier to update the affected applications. Thanks, Elias Probst ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121949: Add name of consumer to kservice_desktop_to_json() deprecation warning.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121949/#review73609 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 9, 2015, 3:41 p.m., Elias Probst wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121949/ --- (Updated Jan. 9, 2015, 3:41 p.m.) Review request for KDE Frameworks. Repository: kservice Description --- Until now, there was no way to tell from the logged message where it was originating from. This change makes it easier to find the originating application. Diffs - src/services/kplugininfo.cpp aa5d26386eb17a7e552b29c8fa7961d68b16 Diff: https://git.reviewboard.kde.org/r/121949/diff/ Testing --- Getting now messages logged which look like this: ``` Constructing a KPluginInfo object from old style JSON. Please use kcoreaddons_desktop_to_json() for Kate Session Applet instead of kservice_desktop_to_json() in your CMake code. Constructing a KPluginInfo object from old style JSON. Please use kcoreaddons_desktop_to_json() for DataEngine for Kimpanel instead of kservice_desktop_to_json() in your CMake code. Constructing a KPluginInfo object from old style JSON. Please use kcoreaddons_desktop_to_json() for Konsole Profiles instead of kservice_desktop_to_json() in your CMake code. ``` This makes it definitely far easier to update the affected applications. Thanks, Elias Probst ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to stable : kservice_master_qt5 #220
See http://build.kde.org/job/kservice_master_qt5/220/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 121952: Make it possible to prevent a toolbar from being hidden
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121952/ --- Review request for KDE Frameworks. Bugs: 326713 https://bugs.kde.org/show_bug.cgi?id=326713 Repository: kxmlgui Description --- Adds a noHide attribute in the xml format and implements it in the toolbar handler, so we don't get an action to hide some toolbars. See related bug for more information. Basically if the application doesnt' have a menu, one can hide the toolbar and then it can't come back. Diffs - src/ktoolbar.h 54cc1cd src/ktoolbar.cpp f79a149 src/ktoolbarhandler.cpp 83c77bd src/kxmlgui.xsd bca02f1 Diff: https://git.reviewboard.kde.org/r/121952/diff/ Testing --- Fixes the attached bug, tests still pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 121949: Add name of consumer to kservice_desktop_to_json() deprecation warning.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121949/ --- Review request for KDE Frameworks. Repository: kservice Description --- Until now, there was no way to tell from the logged message where it was originating from. This change makes it easier to find the originating application. Diffs - src/services/kplugininfo.cpp aa5d26386eb17a7e552b29c8fa7961d68b16 Diff: https://git.reviewboard.kde.org/r/121949/diff/ Testing --- Getting now messages logged which look like this: ``` Constructing a KPluginInfo object from old style JSON. Please use kcoreaddons_desktop_to_json() for Kate Session Applet instead of kservice_desktop_to_json() in your CMake code. Constructing a KPluginInfo object from old style JSON. Please use kcoreaddons_desktop_to_json() for DataEngine for Kimpanel instead of kservice_desktop_to_json() in your CMake code. Constructing a KPluginInfo object from old style JSON. Please use kcoreaddons_desktop_to_json() for Konsole Profiles instead of kservice_desktop_to_json() in your CMake code. ``` This makes it definitely far easier to update the affected applications. Thanks, Elias Probst ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121949: Add name of consumer to kservice_desktop_to_json() deprecation warning.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121949/ --- (Updated Jan. 9, 2015, 4:01 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kservice Description --- Until now, there was no way to tell from the logged message where it was originating from. This change makes it easier to find the originating application. Diffs - src/services/kplugininfo.cpp aa5d26386eb17a7e552b29c8fa7961d68b16 Diff: https://git.reviewboard.kde.org/r/121949/diff/ Testing --- Getting now messages logged which look like this: ``` Constructing a KPluginInfo object from old style JSON. Please use kcoreaddons_desktop_to_json() for Kate Session Applet instead of kservice_desktop_to_json() in your CMake code. Constructing a KPluginInfo object from old style JSON. Please use kcoreaddons_desktop_to_json() for DataEngine for Kimpanel instead of kservice_desktop_to_json() in your CMake code. Constructing a KPluginInfo object from old style JSON. Please use kcoreaddons_desktop_to_json() for Konsole Profiles instead of kservice_desktop_to_json() in your CMake code. ``` This makes it definitely far easier to update the affected applications. Thanks, Elias Probst ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121952: Make it possible to prevent a toolbar from being hidden
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121952/ --- (Updated Jan. 9, 2015, 4:27 p.m.) Review request for KDE Frameworks. Changes --- Disable the toolbar action if it's attached to a noHide toolbar. Bugs: 326713 https://bugs.kde.org/show_bug.cgi?id=326713 Repository: kxmlgui Description --- Adds a noHide attribute in the xml format and implements it in the toolbar handler, so we don't get an action to hide some toolbars. See related bug for more information. Basically if the application doesnt' have a menu, one can hide the toolbar and then it can't come back. Diffs (updated) - src/ktoggletoolbaraction.cpp 3539ff3 src/ktoolbar.h 54cc1cd src/ktoolbar.cpp f79a149 src/ktoolbarhandler.cpp 83c77bd src/kxmlgui.xsd bca02f1 Diff: https://git.reviewboard.kde.org/r/121952/diff/ Testing --- Fixes the attached bug, tests still pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121927: Update XCursor settings
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121927/#review73559 --- autotests/CMakeLists.txt https://git.reviewboard.kde.org/r/121927/#comment51204 the HAVE_X11=0 seems very hackish to me; it wil prevent testing any X11 code path... I assume this is because we don't want the unittest touching the real X11 cursor, but then it would seem more accurate to just have -DUNIT_TEST here, and to say #if HAVE_X11 !defined(UNIT_TEST) in the code. - David Faure On Jan. 8, 2015, 3:37 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121927/ --- (Updated Jan. 8, 2015, 3:37 p.m.) Review request for KDE Frameworks, Àlex Fiestas and Eike Hein. Repository: frameworkintegration Description --- Code taken and adjusted from KGlobalSettings. Diffs - autotests/CMakeLists.txt 00337e775e4e2d3e2d1bb583f4102323f0e5973b src/platformtheme/CMakeLists.txt 8a3b1b43d617083730517fe8db0a1e2f543913ab src/platformtheme/khintssettings.cpp a477a1078f7d62294abfffc92a77889832b1e0db Diff: https://git.reviewboard.kde.org/r/121927/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Qt 5 buildability
On Fri, Jan 9, 2015 at 10:32 PM, Jan Kundrát j...@kde.org wrote: On Thursday, 8 January 2015 22:59:53 CEST, Ben Cooksley wrote: QtWebEngine won't build unless you have nss-devel installed (which it complains about) but it also won't build unless libcap-devel is installed (which it doesn't complain about - you only find out when the compiler bails out on you). It's documented at their wiki page [1]. I agree that configure checking these deps is an obviously good thing and that nobody reads wiki pages. Yep :) 1) A failure for QtWebEngine to find what it needs should just be gracefully ignored, not result in a fatal build failure (unless it was explicitly requested) 2) Having a dependency which no part of your configuration system knows about is extremely bad. The real big issue here though is none of this is integrated with ./configure, and the failure in QtWebEngine is fatal. Can someone please raise this with the Qt developers and get them to fix their build system please? Nobody but you have full knowledge of the build environment that you use. Even if I forwarded your report, the Qt developers are likely to ask further questions which only you can answer. That's why it's important to eliminate as many middlemens from the bug reporting process as possible, IMHO. You should file a bug at their issue tracker. The Qt project has been totally unreceptive to prior requests i've made. Hence why i'd prefer this go through an intermediary - I can only guess as to why I am ignored. Cheers, Jan Thanks, Ben [1] http://qt-project.org/wiki/Building_Qt_5_from_Git -- Trojitá, a fast Qt IMAP e-mail client -- http://trojita.flaska.net/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 121953: Add filename to KPluginInfo::property() deprecation notice.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121953/ --- Review request for KDE Frameworks. Repository: kservice Description --- Add filename to KPluginInfo::property() deprecation notice. Diffs - src/services/kplugininfo.cpp 98a2aa5c553c8a608afdaf82eee8fec9ca4ca60b Diff: https://git.reviewboard.kde.org/r/121953/diff/ Testing --- The deprecation notice for `KPluginInfo::property()` includes now the filename of the originating file, making it easier to update it. ``` Calling KPluginInfo::property(X-KDE-PluginInfo-Name) is deprecated, use KPluginInfo::pluginName() in /usr/lib64/qt5/plugins/plasma/dataengine/plasma_engine_geolocation.so instead. Calling KPluginInfo::property(X-KDE-PluginInfo-Name) is deprecated, use KPluginInfo::pluginName() in /usr/lib64/qt5/plugins/plasma/dataengine/plasma_engine_hotplug.so instead. Calling KPluginInfo::property(X-KDE-PluginInfo-Name) is deprecated, use KPluginInfo::pluginName() in /usr/lib64/qt5/plugins/plasma/dataengine/plasma_engine_tasks.so instead. ``` Thanks, Elias Probst ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
OSX/CI: captivities fails to build on branch master
Linux/CI is quiet, but here on OSX/CI I see this: --- In file included from /opt/local/include/boost/intrusive/circular_slist_algorithms.hpp:24: /opt/local/include/boost/intrusive/detail/common_slist_algorithms.hpp:146:16: error: cannot use 'throw' with exceptions disabled throw; ^ [ 89%] Built target kactivitymanagerd_fileitem_linking_plugin 10 warnings and 1 error generated. [ 90%] make[2]: *** [src/imports/CMakeFiles/kactivitiesextensionplugin.dir/activitiesextensionplugin.cpp.o] Error 1 kactivities.log.gz Description: GNU Zip compressed data ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121599: Fix crash in KIO due to exposing inconsistent views of internal data.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121599/ --- (Updated Jan. 9, 2015, 7:34 p.m.) Review request for KDE Frameworks. Changes --- Change group Repository: kio Description --- Fix crash in KIO due to exposing inconsistent views of internal data. This can be triggered by renaming a directory while one of the files in it is open in gwenview. It occurs because when KDirListerCache::emitRedirections is called, itemsInUse contains the old url. However, KDirLister::Private::redirect changes lstDirs to the new url. Thus at this point lstDirs contains an item not in itemsInUse, which causes an assertion if forgetDirs is called. In gwenview, the redirection signal is connected to openURL. This calls forgetDirs, and causes the assertion. The solution: update itemsInUse *before* emitting redirections. This fixes the crash, but gwenview opens the first file in the new directory instead of the file open before renaming. This is probably an unrelated gwenview bug. This is the same as reviewboard 117345, but on the KF5 kio repository and with a test case. While I was doing this I also fixed a minor bug in the test suite (which is a separate commit). Diffs - autotests/kdirlistertest.h 70fd16f autotests/kdirlistertest.cpp b588e5b src/core/kcoredirlister.cpp f5c5627 Diff: https://git.reviewboard.kde.org/r/121599/diff/ Testing --- Tests run Thanks, Simeon Bird ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121922: support stringlists as properties
On Jan. 9, 2015, 3:01 p.m., Alex Richardson wrote: src/services/kplugininfo.cpp, line 535 https://git.reviewboard.kde.org/r/121922/diff/2/?file=339120#file339120line535 AFAIK escaping ; or , with a \ should be allowed: see KConfigGroupPrivate::deserializeList() making it use a copy of it (that takes ; as well). that is of course not pretty but at least should work a tad better - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121922/#review73599 --- On Jan. 9, 2015, 4:52 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121922/ --- (Updated Jan. 9, 2015, 4:52 p.m.) Review request for KDE Frameworks. Repository: kservice Description --- if a property is defined as a StringList in a servicetype, return it as an actual stringlist upon KPluginInfo::property() instead of a string (with commas to separe the entries), having the same behavior of KService This is necessary to have the same behavior between the old KServiceTypeTrader::query() and KPluginTrader::applyConstraints because without list properties, all queries with the in keyword wouldn't work, such as org.kde.plasma.time in [X-Plasma-Provides] Diffs - src/services/kplugininfo.cpp aa5d263 Diff: https://git.reviewboard.kde.org/r/121922/diff/ Testing --- queries on list properties with in do work now Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121953: Add filename to KPluginInfo::property() deprecation notice.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121953/ --- (Updated Jan. 9, 2015, 5:07 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kservice Description --- Add filename to KPluginInfo::property() deprecation notice. Diffs - src/services/kplugininfo.cpp 98a2aa5c553c8a608afdaf82eee8fec9ca4ca60b Diff: https://git.reviewboard.kde.org/r/121953/diff/ Testing --- The deprecation notice for `KPluginInfo::property()` includes now the filename of the originating file, making it easier to update it. ``` Calling KPluginInfo::property(X-KDE-PluginInfo-Name) is deprecated, use KPluginInfo::pluginName() in /usr/lib64/qt5/plugins/plasma/dataengine/plasma_engine_geolocation.so instead. Calling KPluginInfo::property(X-KDE-PluginInfo-Name) is deprecated, use KPluginInfo::pluginName() in /usr/lib64/qt5/plugins/plasma/dataengine/plasma_engine_hotplug.so instead. Calling KPluginInfo::property(X-KDE-PluginInfo-Name) is deprecated, use KPluginInfo::pluginName() in /usr/lib64/qt5/plugins/plasma/dataengine/plasma_engine_tasks.so instead. ``` Thanks, Elias Probst ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121953: Add filename to KPluginInfo::property() deprecation notice.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121953/#review73618 --- +1, Let maintainer give Shipit! - Bhushan Shah On Jan. 9, 2015, 10:03 p.m., Elias Probst wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121953/ --- (Updated Jan. 9, 2015, 10:03 p.m.) Review request for KDE Frameworks. Repository: kservice Description --- Add filename to KPluginInfo::property() deprecation notice. Diffs - src/services/kplugininfo.cpp 98a2aa5c553c8a608afdaf82eee8fec9ca4ca60b Diff: https://git.reviewboard.kde.org/r/121953/diff/ Testing --- The deprecation notice for `KPluginInfo::property()` includes now the filename of the originating file, making it easier to update it. ``` Calling KPluginInfo::property(X-KDE-PluginInfo-Name) is deprecated, use KPluginInfo::pluginName() in /usr/lib64/qt5/plugins/plasma/dataengine/plasma_engine_geolocation.so instead. Calling KPluginInfo::property(X-KDE-PluginInfo-Name) is deprecated, use KPluginInfo::pluginName() in /usr/lib64/qt5/plugins/plasma/dataengine/plasma_engine_hotplug.so instead. Calling KPluginInfo::property(X-KDE-PluginInfo-Name) is deprecated, use KPluginInfo::pluginName() in /usr/lib64/qt5/plugins/plasma/dataengine/plasma_engine_tasks.so instead. ``` Thanks, Elias Probst ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121953: Add filename to KPluginInfo::property() deprecation notice.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121953/#review73619 --- +1 too, maybe you want to pass the metadata as the 2nd parameter? It doesn't look like it needs to be re-used so it's fine like that as well. - Aleix Pol Gonzalez On Jan. 9, 2015, 4:33 p.m., Elias Probst wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121953/ --- (Updated Jan. 9, 2015, 4:33 p.m.) Review request for KDE Frameworks. Repository: kservice Description --- Add filename to KPluginInfo::property() deprecation notice. Diffs - src/services/kplugininfo.cpp 98a2aa5c553c8a608afdaf82eee8fec9ca4ca60b Diff: https://git.reviewboard.kde.org/r/121953/diff/ Testing --- The deprecation notice for `KPluginInfo::property()` includes now the filename of the originating file, making it easier to update it. ``` Calling KPluginInfo::property(X-KDE-PluginInfo-Name) is deprecated, use KPluginInfo::pluginName() in /usr/lib64/qt5/plugins/plasma/dataengine/plasma_engine_geolocation.so instead. Calling KPluginInfo::property(X-KDE-PluginInfo-Name) is deprecated, use KPluginInfo::pluginName() in /usr/lib64/qt5/plugins/plasma/dataengine/plasma_engine_hotplug.so instead. Calling KPluginInfo::property(X-KDE-PluginInfo-Name) is deprecated, use KPluginInfo::pluginName() in /usr/lib64/qt5/plugins/plasma/dataengine/plasma_engine_tasks.so instead. ``` Thanks, Elias Probst ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121922: support stringlists as properties
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121922/ --- (Updated Jan. 9, 2015, 4:50 p.m.) Review request for KDE Frameworks. Repository: kservice Description --- if a property is defined as a StringList in a servicetype, return it as an actual stringlist upon KPluginInfo::property() instead of a string (with commas to separe the entries), having the same behavior of KService This is necessary to have the same behavior between the old KServiceTypeTrader::query() and KPluginTrader::applyConstraints because without list properties, all queries with the in keyword wouldn't work, such as org.kde.plasma.time in [X-Plasma-Provides] Diffs (updated) - src/services/kplugininfo.cpp aa5d263 Diff: https://git.reviewboard.kde.org/r/121922/diff/ Testing --- queries on list properties with in do work now Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121922: support stringlists as properties
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121922/ --- (Updated Jan. 9, 2015, 4:52 p.m.) Review request for KDE Frameworks. Repository: kservice Description --- if a property is defined as a StringList in a servicetype, return it as an actual stringlist upon KPluginInfo::property() instead of a string (with commas to separe the entries), having the same behavior of KService This is necessary to have the same behavior between the old KServiceTypeTrader::query() and KPluginTrader::applyConstraints because without list properties, all queries with the in keyword wouldn't work, such as org.kde.plasma.time in [X-Plasma-Provides] Diffs (updated) - src/services/kplugininfo.cpp aa5d263 Diff: https://git.reviewboard.kde.org/r/121922/diff/ Testing --- queries on list properties with in do work now Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120878: Remove unused header
On Jan. 9, 2015, 11:53 a.m., David Edmundson wrote: I should have asked, do you have commit access or do you need someone to merge this? I do have commit access, but I am okay if anyone commits it too. I just had little time to do so. - Andrius da Costa --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120878/#review73573 --- On Out. 29, 2014, 2:27 a.m., Andrius da Costa Ribas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120878/ --- (Updated Out. 29, 2014, 2:27 a.m.) Review request for KDE Frameworks, kdewin and Plasma. Repository: krunner Description --- Since scripting/runnerscript.cpp is not compiled, we get a linking error by exporting but not defining RunnerScript. Diffs - src/abstractrunner.cpp 4da0394 Diff: https://git.reviewboard.kde.org/r/120878/diff/ Testing --- Tested building using MSVC 64bit Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121084: Rename libmolletnetwork to avoid conflict with KDE4
On Jan. 9, 2015, 11:53 a.m., David Edmundson wrote: do you have commit access? No, I don't. - Armin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121084/#review73572 --- On Nov. 9, 2014, 4:10 p.m., Armin K. wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121084/ --- (Updated Nov. 9, 2014, 4:10 p.m.) Review request for KDE Runtime, KDE Frameworks and Plasma. Repository: kio-extras Description --- KDE-Runtime already provides libmolletnetwork, so lets rename this one to include 5 as a suffix since many apps outside of KDE still depend on KDE-Runtime. Diffs - network/ioslave/CMakeLists.txt 06a964d network/kded/CMakeLists.txt 3be676e network/network/CMakeLists.txt c0fb43e Diff: https://git.reviewboard.kde.org/r/121084/diff/ Testing --- Thanks, Armin K. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: qca-qt5 2.1.0.1
Hi Harald,
should perhaps stg like this:
---
diff --git a/logical-module-structure b/logical-module-structure
index a2ef4e3..14d1f94 100644
--- a/logical-module-structure
+++ b/logical-module-structure
@@ -294,6 +300,12 @@
kf5-qt5: master,
stable-kf5-qt5: master
},
+kdesupport/qca: {
+stable-qt4: KDE/4.14,
+latest-qt4: KDE/4.14,
+kf5-qt5: qt5,
+stable-kf5-qt5: qt5
+},
playground/pim/akonadi-search: {
kf5-qt5: master
},
---
get committed to KDE’s build dependencies?
Regards,
Marko
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 121958: Deprecate kservice_desktop_to_json(), use kcoreaddons_desktop_to_json().
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121958/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framework Description --- Deprecate kservice_desktop_to_json(), use kcoreaddons_desktop_to_json(). Diffs - examples/dataengines/customDataContainers/CMakeLists.txt 7c6aef8b506ddbadc6d73ce917302ac828537ba1 examples/dataengines/simpleEngine/CMakeLists.txt aa8ce4703389134b63587c28a0afe5d7b5cba3a0 examples/dataengines/sourcesOnRequest/CMakeLists.txt d60a8fb07ea7197e54985325cdc8379dfd9851c2 tests/testengine/CMakeLists.txt 08735867acee249fbb903a5f40e0a783a13f6e6a Diff: https://git.reviewboard.kde.org/r/121958/diff/ Testing --- Builds + installs as expected Thanks, Elias Probst ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121958: Deprecate kservice_desktop_to_json(), use kcoreaddons_desktop_to_json().
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121958/ --- (Updated Jan. 9, 2015, 10:34 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Plasma. Repository: plasma-framework Description --- Deprecate kservice_desktop_to_json(), use kcoreaddons_desktop_to_json(). Diffs - examples/dataengines/customDataContainers/CMakeLists.txt 7c6aef8b506ddbadc6d73ce917302ac828537ba1 examples/dataengines/simpleEngine/CMakeLists.txt aa8ce4703389134b63587c28a0afe5d7b5cba3a0 examples/dataengines/sourcesOnRequest/CMakeLists.txt d60a8fb07ea7197e54985325cdc8379dfd9851c2 tests/testengine/CMakeLists.txt 08735867acee249fbb903a5f40e0a783a13f6e6a Diff: https://git.reviewboard.kde.org/r/121958/diff/ Testing --- Builds + installs as expected Thanks, Elias Probst ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121958: Deprecate kservice_desktop_to_json(), use kcoreaddons_desktop_to_json().
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121958/#review73643 --- Ship it! Ship It! - Martin Klapetek On Jan. 9, 2015, 8:48 p.m., Elias Probst wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121958/ --- (Updated Jan. 9, 2015, 8:48 p.m.) Review request for KDE Frameworks and Plasma. Repository: plasma-framework Description --- Deprecate kservice_desktop_to_json(), use kcoreaddons_desktop_to_json(). Diffs - examples/dataengines/customDataContainers/CMakeLists.txt 7c6aef8b506ddbadc6d73ce917302ac828537ba1 examples/dataengines/simpleEngine/CMakeLists.txt aa8ce4703389134b63587c28a0afe5d7b5cba3a0 examples/dataengines/sourcesOnRequest/CMakeLists.txt d60a8fb07ea7197e54985325cdc8379dfd9851c2 tests/testengine/CMakeLists.txt 08735867acee249fbb903a5f40e0a783a13f6e6a Diff: https://git.reviewboard.kde.org/r/121958/diff/ Testing --- Builds + installs as expected Thanks, Elias Probst ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Qt 5 buildability
On Fri, Jan 9, 2015 at 10:59 AM, Ben Cooksley bcooks...@kde.org wrote: Hi all, I'm not sure about which list is most appropriate for this, so i'm sending it here. It seems that changes from Qt 5.3 to 5.4 have introduced a series of hidden dependencies. QtWebEngine won't build unless you have nss-devel installed (which it complains about) but it also won't build unless libcap-devel is installed (which it doesn't complain about - you only find out when the compiler bails out on you). The real big issue here though is none of this is integrated with ./configure, and the failure in QtWebEngine is fatal. Can someone please raise this with the Qt developers and get them to fix their build system please? Unfortunately the Qt developers have bigger problems than the above to fix. Qt 5.4 as it exists in the 5.4 branch at the moment is unbuildable (despite their blocking CI system). Please see http://build.kde.org/view/FAILED/job/qt5_master_qt5/168/console for why. Could someone prod them into fixing their build? This means that no KDE project can depend on Qt 5.4 at this time. Thanks, Ben Thanks, Ben ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Re: Qt 5 buildability
On Friday 09 January 2015 22:14:09 Ben Cooksley wrote: On Fri, Jan 9, 2015 at 10:59 AM, Ben Cooksley bcooks...@kde.org wrote: Hi all, I'm not sure about which list is most appropriate for this, so i'm sending it here. It seems that changes from Qt 5.3 to 5.4 have introduced a series of hidden dependencies. QtWebEngine won't build unless you have nss-devel installed (which it complains about) but it also won't build unless libcap-devel is installed (which it doesn't complain about - you only find out when the compiler bails out on you). The real big issue here though is none of this is integrated with ./configure, and the failure in QtWebEngine is fatal. Can someone please raise this with the Qt developers and get them to fix their build system please? Unfortunately the Qt developers have bigger problems than the above to fix. Qt 5.4 as it exists in the 5.4 branch at the moment is unbuildable (despite their blocking CI system). what about disabling the QtWebEngine module for now? Please see http://build.kde.org/view/FAILED/job/qt5_master_qt5/168/console for why. Could someone prod them into fixing their build? This means that no KDE project can depend on Qt 5.4 at this time. Thanks, Ben Thanks, Ben ___ Plasma-devel mailing list plasma-de...@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Re: Qt 5 buildability
On Fri, Jan 9, 2015 at 10:19 PM, Martin Gräßlin mgraess...@kde.org wrote: On Friday 09 January 2015 22:14:09 Ben Cooksley wrote: On Fri, Jan 9, 2015 at 10:59 AM, Ben Cooksley bcooks...@kde.org wrote: Hi all, I'm not sure about which list is most appropriate for this, so i'm sending it here. It seems that changes from Qt 5.3 to 5.4 have introduced a series of hidden dependencies. QtWebEngine won't build unless you have nss-devel installed (which it complains about) but it also won't build unless libcap-devel is installed (which it doesn't complain about - you only find out when the compiler bails out on you). The real big issue here though is none of this is integrated with ./configure, and the failure in QtWebEngine is fatal. Can someone please raise this with the Qt developers and get them to fix their build system please? Unfortunately the Qt developers have bigger problems than the above to fix. Qt 5.4 as it exists in the 5.4 branch at the moment is unbuildable (despite their blocking CI system). what about disabling the QtWebEngine module for now? We did a similar head bury in sand act when CMake regressions broke our builds. Let's not repeat that experience. Our system has detected a breakage upstream, let's get them to fix it *now* not when some part of KDE begins to use QtWebEngine. Please see http://build.kde.org/view/FAILED/job/qt5_master_qt5/168/console for why. Could someone prod them into fixing their build? This means that no KDE project can depend on Qt 5.4 at this time. Thanks, Ben Thanks, Ben ___ Plasma-devel mailing list plasma-de...@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Qt 5 buildability
On Thursday, 8 January 2015 22:59:53 CEST, Ben Cooksley wrote: QtWebEngine won't build unless you have nss-devel installed (which it complains about) but it also won't build unless libcap-devel is installed (which it doesn't complain about - you only find out when the compiler bails out on you). It's documented at their wiki page [1]. I agree that configure checking these deps is an obviously good thing and that nobody reads wiki pages. The real big issue here though is none of this is integrated with ./configure, and the failure in QtWebEngine is fatal. Can someone please raise this with the Qt developers and get them to fix their build system please? Nobody but you have full knowledge of the build environment that you use. Even if I forwarded your report, the Qt developers are likely to ask further questions which only you can answer. That's why it's important to eliminate as many middlemens from the bug reporting process as possible, IMHO. You should file a bug at their issue tracker. Cheers, Jan [1] http://qt-project.org/wiki/Building_Qt_5_from_Git -- Trojitá, a fast Qt IMAP e-mail client -- http://trojita.flaska.net/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121927: Update XCursor settings
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121927/#review73570 --- Ship it! There is test for this code in kdeplatformtheme_unittest.cpp, do you think it will be possible to test the fallback we have for then the size is -1? Alsot, maybe checking with XCursorGetTheme that the theme has been applied will be nice, so we make sure we won't loose this in possible future refactors of this code. Otherwise code looks good! - Àlex Fiestas On gen. 9, 2015, 9:18 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121927/ --- (Updated gen. 9, 2015, 9:18 a.m.) Review request for KDE Frameworks, Àlex Fiestas and Eike Hein. Repository: frameworkintegration Description --- Code taken and adjusted from KGlobalSettings. Diffs - src/platformtheme/khintssettings.cpp a477a1078f7d62294abfffc92a77889832b1e0db autotests/CMakeLists.txt 00337e775e4e2d3e2d1bb583f4102323f0e5973b src/platformtheme/CMakeLists.txt 8a3b1b43d617083730517fe8db0a1e2f543913ab Diff: https://git.reviewboard.kde.org/r/121927/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121927: Update XCursor settings
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121927/#review73571 --- src/platformtheme/khintssettings.cpp https://git.reviewboard.kde.org/r/121927/#comment51222 Maybe move this platform specific code to a separate method so IFDEF is smaller? It will help if we need to add more ifdefs in the future. - Àlex Fiestas On gen. 9, 2015, 9:18 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121927/ --- (Updated gen. 9, 2015, 9:18 a.m.) Review request for KDE Frameworks, Àlex Fiestas and Eike Hein. Repository: frameworkintegration Description --- Code taken and adjusted from KGlobalSettings. Diffs - src/platformtheme/khintssettings.cpp a477a1078f7d62294abfffc92a77889832b1e0db autotests/CMakeLists.txt 00337e775e4e2d3e2d1bb583f4102323f0e5973b src/platformtheme/CMakeLists.txt 8a3b1b43d617083730517fe8db0a1e2f543913ab Diff: https://git.reviewboard.kde.org/r/121927/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121927: Update XCursor settings
On Jan. 9, 2015, 12:37 p.m., Àlex Fiestas wrote: There is test for this code in kdeplatformtheme_unittest.cpp, do you think it will be possible to test the fallback we have for then the size is -1? Alsot, maybe checking with XCursorGetTheme that the theme has been applied will be nice, so we make sure we won't loose this in possible future refactors of this code. Otherwise code looks good! hey, I just moved the code from kglobalsettings. I have no clue how that code should and could be unit tested and honestly I don't have the time to start writing unit tests for legacy code. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121927/#review73570 --- On Jan. 9, 2015, 10:18 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121927/ --- (Updated Jan. 9, 2015, 10:18 a.m.) Review request for KDE Frameworks, Àlex Fiestas and Eike Hein. Repository: frameworkintegration Description --- Code taken and adjusted from KGlobalSettings. Diffs - src/platformtheme/khintssettings.cpp a477a1078f7d62294abfffc92a77889832b1e0db autotests/CMakeLists.txt 00337e775e4e2d3e2d1bb583f4102323f0e5973b src/platformtheme/CMakeLists.txt 8a3b1b43d617083730517fe8db0a1e2f543913ab Diff: https://git.reviewboard.kde.org/r/121927/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121927: Update XCursor settings
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121927/ --- (Updated Jan. 9, 2015, 1:24 p.m.) Review request for KDE Frameworks, Àlex Fiestas and Eike Hein. Changes --- moved code to private method and made the #ifdef section as small as possible Repository: frameworkintegration Description --- Code taken and adjusted from KGlobalSettings. Diffs (updated) - autotests/CMakeLists.txt 00337e775e4e2d3e2d1bb583f4102323f0e5973b src/platformtheme/CMakeLists.txt 8a3b1b43d617083730517fe8db0a1e2f543913ab src/platformtheme/khintssettings.h 1d9c1d23c0974c6c76912536fb2879d72ca7dc6a src/platformtheme/khintssettings.cpp a477a1078f7d62294abfffc92a77889832b1e0db Diff: https://git.reviewboard.kde.org/r/121927/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Qt 5 buildability
On Friday 09 January 2015 22:41:15 Ben Cooksley wrote: On Fri, Jan 9, 2015 at 10:32 PM, Jan Kundrát j...@kde.org wrote: On Thursday, 8 January 2015 22:59:53 CEST, Ben Cooksley wrote: QtWebEngine won't build unless you have nss-devel installed (which it complains about) but it also won't build unless libcap-devel is installed (which it doesn't complain about - you only find out when the compiler bails out on you). It's documented at their wiki page [1]. I agree that configure checking these deps is an obviously good thing and that nobody reads wiki pages. Yep :) 1) A failure for QtWebEngine to find what it needs should just be gracefully ignored, not result in a fatal build failure (unless it was explicitly requested) 2) Having a dependency which no part of your configuration system knows about is extremely bad. The real big issue here though is none of this is integrated with ./configure, and the failure in QtWebEngine is fatal. Can someone please raise this with the Qt developers and get them to fix their build system please? Nobody but you have full knowledge of the build environment that you use. Even if I forwarded your report, the Qt developers are likely to ask further questions which only you can answer. That's why it's important to eliminate as many middlemens from the bug reporting process as possible, IMHO. You should file a bug at their issue tracker. The Qt project has been totally unreceptive to prior requests i've made. Hence why i'd prefer this go through an intermediary - I can only guess as to why I am ignored. I've sent a link to this discussion and the build error to the Qt WebEngine people. You can reach them easily (during working hours) in the #qtwebengine channel on freenode IRC. They are definitely receptive to your input. And, FWIW, Simon and Allan are both still very close to the KDE project. Simon e.g. already created https://codereview.qt-project.org/#/c/103225/ based on your report. http://qt-project.org/wiki/QtWebEngineHowToTry lists all dependencies, and they have an open bug report about improving the build system as well. So, tl;dr; they will improve this. And I hope you are not burnt by your past experiences with $whomever in the Qt eco system. It's a versatile bunch, and most of them are very open to suggestions from the outside and will try to help anyone, and KDE in particular, as fast as possible. Bye -- Milian Wolff m...@milianw.de http://milianw.de ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121927: Update XCursor settings
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121927/ --- (Updated Jan. 9, 2015, 1:29 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, Àlex Fiestas and Eike Hein. Repository: frameworkintegration Description --- Code taken and adjusted from KGlobalSettings. Diffs - autotests/CMakeLists.txt 00337e775e4e2d3e2d1bb583f4102323f0e5973b src/platformtheme/CMakeLists.txt 8a3b1b43d617083730517fe8db0a1e2f543913ab src/platformtheme/khintssettings.h 1d9c1d23c0974c6c76912536fb2879d72ca7dc6a src/platformtheme/khintssettings.cpp a477a1078f7d62294abfffc92a77889832b1e0db Diff: https://git.reviewboard.kde.org/r/121927/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121927: Update XCursor settings
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121927/#review73585 --- Ship it! OK I guess this is better for future extensibility. Right now it will lead to unused variable warnings on other platforms, but that's good, they indeed have something to fix there ;) - David Faure On Jan. 9, 2015, 12:24 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121927/ --- (Updated Jan. 9, 2015, 12:24 p.m.) Review request for KDE Frameworks, Àlex Fiestas and Eike Hein. Repository: frameworkintegration Description --- Code taken and adjusted from KGlobalSettings. Diffs - autotests/CMakeLists.txt 00337e775e4e2d3e2d1bb583f4102323f0e5973b src/platformtheme/CMakeLists.txt 8a3b1b43d617083730517fe8db0a1e2f543913ab src/platformtheme/khintssettings.h 1d9c1d23c0974c6c76912536fb2879d72ca7dc6a src/platformtheme/khintssettings.cpp a477a1078f7d62294abfffc92a77889832b1e0db Diff: https://git.reviewboard.kde.org/r/121927/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KF 5.6 changelog
On Thursday 08 January 2015 17:07:40 Daniel Vrátil wrote: On Saturday, January 03, 2015 02:16:30 PM David Faure wrote: With cookies to Kai Uwe Broulik for using CHANGELOG: in most of his commits! The KPackage frameworks is Tier 2 and depends on KDocTools, which is also Tier 2, which, if I read Tier 2 policy correctly, is not allowed :-) Is there a plan to move it to Tier 3, or remove the dependency? Sorry if this was discussed before. I don't think anyone's noticed this yet. So, yes, it does need to move to tier 3 - but that should be as simple as changing the framework.yaml file. Alex ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121084: Rename libmolletnetwork to avoid conflict with KDE4
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121084/#review73572 --- do you have commit access? - David Edmundson On Nov. 9, 2014, 4:10 p.m., Armin K. wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121084/ --- (Updated Nov. 9, 2014, 4:10 p.m.) Review request for KDE Runtime, KDE Frameworks and Plasma. Repository: kio-extras Description --- KDE-Runtime already provides libmolletnetwork, so lets rename this one to include 5 as a suffix since many apps outside of KDE still depend on KDE-Runtime. Diffs - network/ioslave/CMakeLists.txt 06a964d network/kded/CMakeLists.txt 3be676e network/network/CMakeLists.txt c0fb43e Diff: https://git.reviewboard.kde.org/r/121084/diff/ Testing --- Thanks, Armin K. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120878: Remove unused header
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120878/#review73573 --- I should have asked, do you have commit access or do you need someone to merge this? - David Edmundson On Oct. 29, 2014, 2:27 a.m., Andrius da Costa Ribas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120878/ --- (Updated Oct. 29, 2014, 2:27 a.m.) Review request for KDE Frameworks, kdewin and Plasma. Repository: krunner Description --- Since scripting/runnerscript.cpp is not compiled, we get a linking error by exporting but not defining RunnerScript. Diffs - src/abstractrunner.cpp 4da0394 Diff: https://git.reviewboard.kde.org/r/120878/diff/ Testing --- Tested building using MSVC 64bit Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121672: Properly convert .desktop files that have an associated servicetype
On Jan. 8, 2015, 3:26 p.m., Milian Wolff wrote: While better than before, I still don't like it very much. As soon as another $type-property is added, we'd need to patch this here. Imo, it just shows that desktop2json should be deprecated and people should start writing .json files directly. I fully agree, desktoptojson is only a tool to help the porting and should go away. This patch is only a hack to get more files to convert correctly. Unfortunately I am very busy at the moment and will only be able to post a better version in 1-2 weeks. On Jan. 8, 2015, 3:26 p.m., Milian Wolff wrote: src/lib/plugin/desktopfileparser.cpp, line 361 https://git.reviewboard.kde.org/r/121672/diff/1/?file=335788#file335788line361 why not listProperties().contains(), similar below - i.e. why the (non const!) temporaries above? Oops, they should definitively be const. Calling listProperties().contains(), would cause the set to be constructed again. - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121672/#review73501 --- On Dec. 26, 2014, 5:21 p.m., Alex Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121672/ --- (Updated Dec. 26, 2014, 5:21 p.m.) Review request for KDE Frameworks. Repository: kcoreaddons Description --- This ensures that properties that are defined to be of type QStringList or int or bool are properly converted to the right JSON type. Not sure if this code should also be part of KF5CoreAddons.so, since it does increase the library size quite a bit. It would however be very useful for kcoreaddons_desktop_to_json(), so that the initial conversion to JSON does not have to be done by hand. I probably don't have all the service types that exist installed on my system so I might be missing some properties. I included the script to generate the list of these properties, so that missing properties can be added by anyone who has the required servicetypes/*.desktop files installed. Diffs - src/lib/plugin/read-servicetypes.py PRE-CREATION autotests/desktoptojsontest.cpp 64373d5be930426dd8a1f8e455e33c411a4795fd src/lib/plugin/desktopfileparser.cpp b1b5440b48e4fd412932a7d7e794d641b1406699 Diff: https://git.reviewboard.kde.org/r/121672/diff/ Testing --- Unit test works Thanks, Alex Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121922: support stringlists as properties
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121922/#review73599 --- src/services/kplugininfo.cpp https://git.reviewboard.kde.org/r/121922/#comment51247 AFAIK escaping ; or , with a \ should be allowed: see KConfigGroupPrivate::deserializeList() - Alex Richardson On Jan. 8, 2015, 3:34 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121922/ --- (Updated Jan. 8, 2015, 3:34 p.m.) Review request for KDE Frameworks. Repository: kservice Description --- if a property is defined as a StringList in a servicetype, return it as an actual stringlist upon KPluginInfo::property() instead of a string (with commas to separe the entries), having the same behavior of KService This is necessary to have the same behavior between the old KServiceTypeTrader::query() and KPluginTrader::applyConstraints because without list properties, all queries with the in keyword wouldn't work, such as org.kde.plasma.time in [X-Plasma-Provides] Diffs - src/services/kplugininfo.cpp aa5d263 Diff: https://git.reviewboard.kde.org/r/121922/diff/ Testing --- queries on list properties with in do work now Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 121946: Do not emit documentUrlChanged during reload.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121946/ --- Review request for KDE Frameworks and Christoph Cullmann. Repository: ktexteditor Description --- Do not emit documentUrlChanged during reload. Diffs - src/document/katedocument.cpp b33d9170c8f667dbc41335c7d38b774c88109c2a Diff: https://git.reviewboard.kde.org/r/121946/diff/ Testing --- Thanks, Milian Wolff ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
