Re: KDE Frameworks Sprint

2015-02-03 Thread Kevin Ottens
Hello, On Wednesday 04 February 2015 01:33:00 Aleix Pol wrote: > Do we want a KDE Frameworks sprint? > > I think it could be interesting, at least to recapitulate about the > first year of KF5, find what we liked and decide how to keep going. > > Who would be interested? Just an idea, but maybe

Re: Framework Categories

2015-02-03 Thread Kevin Ottens
On Tuesday 03 February 2015 12:53:08 Jeremy Whiting wrote: > Hey frameworks developers, > > Albert wrote a couple weeks ago: > > As far as i remember, functional means you can use it standalone, solution > > means it needs a daemon and integraion means it needs more stuff (more > > daemons? > > I

KDE Frameworks Sprint

2015-02-03 Thread Aleix Pol
Hello, Do we want a KDE Frameworks sprint? I think it could be interesting, at least to recapitulate about the first year of KF5, find what we liked and decide how to keep going. Who would be interested? Aleix ___ Kde-frameworks-devel mailing list Kde-

Re: Review Request 122396: Fix knotifyconfig leak

2015-02-03 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122396/ --- (Updated Feb. 4, 2015, 12:05 a.m.) Status -- This change has been ma

Re: Review Request 122413: Add paintedWidth and paintedHeight to QPixmapItem

2015-02-03 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122413/ --- (Updated Feb. 3, 2015, 11:41 p.m.) Review request for KDE Frameworks and

Re: Review Request 122396: Fix knotifyconfig leak

2015-02-03 Thread Martin Klapetek
> On Feb. 3, 2015, 10:19 a.m., Martin Klapetek wrote: > > src/knotifyconfig.h, line 93 > > > > > > This should be appName really, the notifybypopup got it wrong :S But > > let's keep the public api consistent >

Re: Review Request 122359: Create an uninstall target by default in KDE projects.

2015-02-03 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122359/#review75342 --- Ship it! Looks good to me, but I'll wait for some others givi

Re: Review Request 122413: Add paintedWidth and paintedHeight to QPixmapItem

2015-02-03 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122413/ --- (Updated Feb. 3, 2015, 10:22 p.m.) Review request for KDE Frameworks and

Re: Review Request 122413: Add paintedWidth and paintedHeight to QPixmapItem

2015-02-03 Thread Luca Beltrame
> On Feb. 3, 2015, 8:43 p.m., David Edmundson wrote: > > Next set of bugs: > > - what about if the paintedWidth is requested before the item's source has > > first been set? > > - or if the item is currently invisible? (what should that return? I'm not > > sure what Image does) > > > > > >

Re: Review Request 122413: Add paintedWidth and paintedHeight to QPixmapItem

2015-02-03 Thread Marco Martin
> On Feb. 3, 2015, 8:43 p.m., David Edmundson wrote: > > Next set of bugs: > > - what about if the paintedWidth is requested before the item's source has > > first been set? > > - or if the item is currently invisible? (what should that return? I'm not > > sure what Image does) > > > > > >

Re: Review Request 122183: [KUnitConversion] Currency: Fetch the currency file properly

2015-02-03 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122183/#review75337 --- src/currency.cpp

Re: Review Request 122206: [kio] Make tests optional

2015-02-03 Thread Andreas Sturmlechner
> On Feb. 1, 2015, 2:33 p.m., David Faure wrote: > > Let me get this straight. > > > > This patch makes the option BUILD_TESTING work, i.e. skip testing if not > > set. > > > > The solution that was committed to kwin, *additionally* sets BUILD_TESTING > > to false if Qt5Test isn't available.

Re: Review Request 122413: Add paintedWidth and paintedHeight to QPixmapItem

2015-02-03 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122413/#review75334 --- Next set of bugs: - what about if the paintedWidth is request

Re: Review Request 122413: Add paintedWidth and paintedHeight to QPixmapItem

2015-02-03 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122413/ --- (Updated Feb. 3, 2015, 8:33 p.m.) Review request for KDE Frameworks and P

Re: Review Request 122413: Add paintedWidth and paintedHeight to QPixmapItem

2015-02-03 Thread Luca Beltrame
> On Feb. 3, 2015, 8:28 p.m., David Edmundson wrote: > > src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.cpp, line 159 > > > > > > only emit if we've actually changed, otherwise every binding is going > > to be

Re: Review Request 122413: Add paintedWidth and paintedHeight to QPixmapItem

2015-02-03 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122413/ --- (Updated Feb. 3, 2015, 8:32 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 122413: Add paintedWidth and paintedHeight to QPixmapItem

2015-02-03 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122413/#review75332 --- src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.h

Re: Review Request 122359: Create an uninstall target by default in KDE projects.

2015-02-03 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122359/ --- (Updated Feb. 3, 2015, 8:19 p.m.) Review request for Build System, Extra

Jenkins build is back to stable : kservice_master_qt5 #230

2015-02-03 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122401: KPluginInfo: delegate to KPluginMetaData for reading the .desktop files

2015-02-03 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122401/ --- (Updated Feb. 3, 2015, 8:07 p.m.) Status -- This change has been mar

Framework Categories

2015-02-03 Thread Jeremy Whiting
Hey frameworks developers, Albert wrote a couple weeks ago: > As far as i remember, functional means you can use it standalone, solution > means it needs a daemon and integraion means it needs more stuff (more > daemons? Is this categorization correct? Has it been checked with a dependency analys

Review Request 122413: Add paintedWidth and paintedHeight to QPixmapItem

2015-02-03 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122413/ --- Review request for KDE Frameworks and Plasma. Repository: kdeclarative

Re: [Kde-games-devel] Freeze in 6 weeks

2015-02-03 Thread Albert Astals Cid
El Dissabte, 31 de gener de 2015, a les 19:38:27, Jeremy Whiting va escriure: > Albert, Frameworks developers/maintainers, > > On Thu, Jan 29, 2015 at 12:43 PM, Albert Astals Cid wrote: > > El Dijous, 29 de gener de 2015, a les 10:05:01, Inge Wallin va escriure: > > > On Wednesday, January 28, 20

Re: Review Request 122408: allow to cycle through activities from global shortcuts plugin

2015-02-03 Thread Ivan Čukić
> On Feb. 3, 2015, 5:40 p.m., Ivan Čukić wrote: > > This does fix the switching, but I don't agree it is the right place for it > > (I don't like that this plugin exists at all tbh). > > > > When switching the activities, there needs to be a (UI) feedback - the > > switcher needs to show up. T

Re: Review Request 122408: allow to cycle through activities from global shortcuts plugin

2015-02-03 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122408/#review75324 --- This does fix the switching, but I don't agree it is the right

Re: Review Request 122396: Fix knotifyconfig leak

2015-02-03 Thread Xuetian Weng
> On Feb. 3, 2015, 9:19 a.m., Martin Klapetek wrote: > > src/knotifyconfig.h, line 93 > > > > > > This should be appName really, the notifybypopup got it wrong :S But > > let's keep the public api consistent But

Re: Review Request 122408: allow to cycle through activities from global shortcuts plugin

2015-02-03 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122408/#review75322 --- to me is fine to have it either done by the plasmashell or act

Review Request 122408: allow to cycle through activities from global shortcuts plugin

2015-02-03 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122408/ --- Review request for KDE Frameworks, Plasma and Ivan Čukić. Bugs: 342186

Re: Review Request 122183: [KUnitConversion] Currency: Fetch the currency file properly

2015-02-03 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122183/ --- (Updated Feb. 3, 2015, 12:49 p.m.) Review request for KDE Frameworks. C

Re: Review Request 122183: [KUnitConversion] Currency: Fetch the currency file properly

2015-02-03 Thread Vishesh Handa
> On Jan. 23, 2015, 9:02 p.m., David Faure wrote: > > src/currency.cpp, line 673 > > > > > > pass 'this' as 3rd argument, just in case 'this' gets deleted while the > > job is running? 'this' isn't a QObject in

Re: Review Request 122401: KPluginInfo: delegate to KPluginMetaData for reading the .desktop files

2015-02-03 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122401/#review75293 --- Ship it! Ship It! - Sebastian Kügler On Feb. 3, 2015, 9:46

Re: Review Request 121315: Allow using kded modules with JSON metadata

2015-02-03 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121315/ --- (Updated Feb. 3, 2015, 10:11 a.m.) Status -- This change has been ma

Review Request 122401: KPluginInfo: delegate to KPluginMetaData for reading the .desktop files

2015-02-03 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122401/ --- Review request for KDE Frameworks, David Faure and Sebastian Kügler. Repo

Re: Review Request 121737: KPluginInfo: Fix properties not being copied from KService::Ptr

2015-02-03 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121737/ --- (Updated Feb. 3, 2015, 9:43 a.m.) Status -- This change has been mar

Re: Review Request 122396: Fix knotifyconfig leak

2015-02-03 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122396/#review75271 --- Ship it! Looks good, thank you src/knotifyconfig.h

Build failed in Jenkins: kde-baseapps_master_qt5 #220

2015-02-03 Thread KDE CI System
See Changes: [emmanuelpescosta099] Port away from KGlobalSettings::singleClick() and use the mouse kcm module instead of implementing the single/double click settings on our one. [emmanuelpescosta099] Port away from KGlobalSettings