Jenkins build is back to normal : kdeclarative_stable_qt5 #36
See http://build.kde.org/job/kdeclarative_stable_qt5/36/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: New framework: KXmlRpcClient
El Dijous, 12 de febrer de 2015, a les 12:31:14, Daniel Vrátil va escriure: On Friday, January 30, 2015 09:12:01 AM David Faure wrote: On Wednesday 28 January 2015 17:12:04 Daniel Vrátil wrote: I guess I should update kde-build-metadata and release-tools and ask for the _stable_qt5 build once the repo is moved to frameworks on projects.k.o, so that changes don't have to be done twice (I don't really know if build.k.o has to be updated when module moves...?). No, build.kde.org uses a git url, so it doesn't matter where the module is logically placed on projects.kde.org. But yes, for kde-build-metadata it matters. (there is nothing to update in release-tools, just set release to true in your yaml file) KXmlRpcClient has been moved to frameworks. I enabled the release flag, adjusted kde-build-metadata, created bugzilla entry, so we should be good to go. Can someone tell the distro packagers list they'll have a duplciation issue when using frameworks 5.8 + Plasma 5.2? Cheers, Albert David, could you please add it to release-tools? Apparently I don't have the rights :-) Thanks, Dan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: kdeclarative_master_qt5 #159
See http://build.kde.org/job/kdeclarative_master_qt5/159/changes Changes: [hein] Switch press-and-hold from hardcoded 800msecs to platform hint. -- [...truncated 147 lines...] PROJECT_VERSION_MAJOR PROJECT_VERSION_MINOR PROJECT_VERSION_PATCH This warning is for project developers. Use -Wno-dev to suppress it. CMake Warning (dev) at src/qmlcontrols/kquickcontrols/private/CMakeLists.txt:1 (project): Policy CMP0048 is not set: project() command manages VERSION variables. Run cmake --help-policy CMP0048 for policy details. Use the cmake_policy command to set the policy and suppress this warning. The following variable(s) would be set to empty: PROJECT_VERSION PROJECT_VERSION_MAJOR PROJECT_VERSION_MINOR PROJECT_VERSION_PATCH This warning is for project developers. Use -Wno-dev to suppress it. CMake Warning (dev) at src/qmlcontrols/kcoreaddons/CMakeLists.txt:1 (project): Policy CMP0048 is not set: project() command manages VERSION variables. Run cmake --help-policy CMP0048 for policy details. Use the cmake_policy command to set the policy and suppress this warning. The following variable(s) would be set to empty: PROJECT_VERSION PROJECT_VERSION_MAJOR PROJECT_VERSION_MINOR PROJECT_VERSION_PATCH This warning is for project developers. Use -Wno-dev to suppress it. CMake Warning (dev) at src/qmlcontrols/kioplugin/CMakeLists.txt:1 (project): Policy CMP0048 is not set: project() command manages VERSION variables. Run cmake --help-policy CMP0048 for policy details. Use the cmake_policy command to set the policy and suppress this warning. The following variable(s) would be set to empty: PROJECT_VERSION PROJECT_VERSION_MAJOR PROJECT_VERSION_MINOR PROJECT_VERSION_PATCH This warning is for project developers. Use -Wno-dev to suppress it. -- -- The following OPTIONAL packages have been found: * PkgConfig -- The following REQUIRED packages have been found: * ECM (required version = 1.7.0) * Qt5Core (required version = 5.4.1) * Qt5Network (required version = 5.4.1) * Qt5Qml * Qt5Quick * Qt5Gui * Qt5 (required version = 5.2.0) * KF5Config (required version = 5.7.0) * Gettext * PythonInterp * KF5I18n (required version = 5.7.0) * KF5IconThemes (required version = 5.7.0) * KF5KIO (required version = 5.7.0) * KF5WidgetsAddons (required version = 5.7.0) * KF5WindowSystem (required version = 5.7.0) * KF5GlobalAccel (required version = 5.7.0) * KF5GuiAddons (required version = 5.7.0) * epoxy , libepoxy , http://github.com/anholt/libepoxy OpenGL dispatch library * Qt5Test Dependencies for libkdeclarative found: it will be built Dependencies for KQuickControls found: it will be built Dependencies for KCoreAddons QML bindings found; it will be built -- Configuring done -- Generating done CMake Warning: Manually-specified variables were not used by the project: KDE4_BUILD_TESTS LIB_SUFFIX SIP_DEFAULT_SIP_DIR -- Build files have been written to: http://build.kde.org/job/kdeclarative_master_qt5/ws/build == Commencing the Build Scanning dependencies of target KF5Declarative_automoc Scanning dependencies of target fullmodelaccesstest_automoc Scanning dependencies of target KF5QuickAddons_automoc Scanning dependencies of target draganddropplugin_automoc Scanning dependencies of target kquickcontrolsaddonsplugin_automoc [ 1%] Scanning dependencies of target kquickcontrolsprivateplugin_automoc [ 3%] [ 5%] Automatic moc for target KF5Declarative Scanning dependencies of target kcoreaddonsplugin_automoc Scanning dependencies of target kdeclarativetest_automoc Scanning dependencies of target kio_automoc [ 7%] [ 9%] [ 11%] [ 13%] Automatic moc for target draganddropplugin [ 15%] [ 17%] Automatic moc for target kquickcontrolsprivateplugin Automatic moc for target kquickcontrolsaddonsplugin Automatic moc for target fullmodelaccesstest Automatic moc for target kio Automatic moc for target KF5QuickAddons Automatic moc for target kcoreaddonsplugin Automatic moc for target kdeclarativetest [ 17%] [ 17%] Built target kdeclarativetest_automoc Built target KF5QuickAddons_automoc Scanning dependencies of target KF5QuickAddons Generating moc_kioplugin.cpp Generating moc_krunproxy.cpp [ 17%] Built target kio_automoc [ 19%] Generating moc_formats.cpp Generating moc_kcoreaddonsplugin.cpp Generating moc_kuserproxy.cpp [ 21%] [ 21%] Built target kcoreaddonsplugin_automoc Building CXX object src/quickaddons/CMakeFiles/KF5QuickAddons.dir/imagetexturescache.cpp.o Generating moc_columnproxymodeltest.cpp Generating moc_modeltest.cpp Generating moc_columnproxymodel.cpp Building CXX object src/quickaddons/CMakeFiles/KF5QuickAddons.dir/managedtexturenode.cpp.o [ 21%] Built target fullmodelaccesstest_automoc Scanning dependencies of target kio [ 23%] Generating moc_keysequencehelper.cpp Generating moc_kquickcontrolsprivateplugin.cpp Generating moc_translationcontext.cpp
Build failed in Jenkins: kdeclarative_stable_qt5 #35
See http://build.kde.org/job/kdeclarative_stable_qt5/35/changes Changes: [hein] Switch press-and-hold from hardcoded 800msecs to platform hint. -- [...truncated 147 lines...] PROJECT_VERSION_MAJOR PROJECT_VERSION_MINOR PROJECT_VERSION_PATCH This warning is for project developers. Use -Wno-dev to suppress it. CMake Warning (dev) at src/qmlcontrols/kquickcontrols/private/CMakeLists.txt:1 (project): Policy CMP0048 is not set: project() command manages VERSION variables. Run cmake --help-policy CMP0048 for policy details. Use the cmake_policy command to set the policy and suppress this warning. The following variable(s) would be set to empty: PROJECT_VERSION PROJECT_VERSION_MAJOR PROJECT_VERSION_MINOR PROJECT_VERSION_PATCH This warning is for project developers. Use -Wno-dev to suppress it. CMake Warning (dev) at src/qmlcontrols/kcoreaddons/CMakeLists.txt:1 (project): Policy CMP0048 is not set: project() command manages VERSION variables. Run cmake --help-policy CMP0048 for policy details. Use the cmake_policy command to set the policy and suppress this warning. The following variable(s) would be set to empty: PROJECT_VERSION PROJECT_VERSION_MAJOR PROJECT_VERSION_MINOR PROJECT_VERSION_PATCH This warning is for project developers. Use -Wno-dev to suppress it. CMake Warning (dev) at src/qmlcontrols/kioplugin/CMakeLists.txt:1 (project): Policy CMP0048 is not set: project() command manages VERSION variables. Run cmake --help-policy CMP0048 for policy details. Use the cmake_policy command to set the policy and suppress this warning. The following variable(s) would be set to empty: PROJECT_VERSION PROJECT_VERSION_MAJOR PROJECT_VERSION_MINOR PROJECT_VERSION_PATCH This warning is for project developers. Use -Wno-dev to suppress it. -- -- The following OPTIONAL packages have been found: * PkgConfig -- The following REQUIRED packages have been found: * ECM (required version = 1.7.0) * Qt5Core (required version = 5.3.2) * Qt5Network (required version = 5.3.2) * Qt5Qml * Qt5Quick * Qt5Gui * Qt5 (required version = 5.2.0) * KF5Config (required version = 5.7.0) * Gettext * PythonInterp * KF5I18n (required version = 5.7.0) * KF5IconThemes (required version = 5.7.0) * KF5KIO (required version = 5.7.0) * KF5WidgetsAddons (required version = 5.7.0) * KF5WindowSystem (required version = 5.7.0) * KF5GlobalAccel (required version = 5.7.0) * KF5GuiAddons (required version = 5.7.0) * epoxy , libepoxy , http://github.com/anholt/libepoxy OpenGL dispatch library * Qt5Test Dependencies for libkdeclarative found: it will be built Dependencies for KQuickControls found: it will be built Dependencies for KCoreAddons QML bindings found; it will be built -- Configuring done -- Generating done CMake Warning: Manually-specified variables were not used by the project: KDE4_BUILD_TESTS LIB_SUFFIX SIP_DEFAULT_SIP_DIR -- Build files have been written to: http://build.kde.org/job/kdeclarative_stable_qt5/ws/build == Commencing the Build Scanning dependencies of target fullmodelaccesstest_automoc Scanning dependencies of target KF5Declarative_automoc Scanning dependencies of target kio_automoc Scanning dependencies of target kquickcontrolsprivateplugin_automoc Scanning dependencies of target kcoreaddonsplugin_automoc Scanning dependencies of target KF5QuickAddons_automoc Scanning dependencies of target draganddropplugin_automoc Scanning dependencies of target kdeclarativetest_automoc Scanning dependencies of target kquickcontrolsaddonsplugin_automoc [ 1%] [ 3%] [ 5%] [ 7%] [ 9%] [ 11%] [ 13%] [ 15%] [ 17%] Automatic moc for target KF5QuickAddons Automatic moc for target fullmodelaccesstest Automatic moc for target kio Automatic moc for target draganddropplugin Automatic moc for target KF5Declarative Automatic moc for target kquickcontrolsprivateplugin Automatic moc for target kcoreaddonsplugin Automatic moc for target kquickcontrolsaddonsplugin Automatic moc for target kdeclarativetest [ 17%] Built target KF5QuickAddons_automoc [ 17%] Built target kdeclarativetest_automoc Scanning dependencies of target KF5QuickAddons [ 19%] [ 21%] Generating moc_kioplugin.cpp Generating moc_krunproxy.cpp Building CXX object src/quickaddons/CMakeFiles/KF5QuickAddons.dir/imagetexturescache.cpp.o Building CXX object src/quickaddons/CMakeFiles/KF5QuickAddons.dir/managedtexturenode.cpp.o [ 21%] Built target kio_automoc [ 23%] Building CXX object src/quickaddons/CMakeFiles/KF5QuickAddons.dir/KF5QuickAddons_automoc.cpp.o Generating moc_columnproxymodeltest.cpp Generating moc_modeltest.cpp Generating moc_columnproxymodel.cpp [ 23%] Built target fullmodelaccesstest_automoc Generating moc_keysequencehelper.cpp Generating moc_kquickcontrolsprivateplugin.cpp Generating moc_translationcontext.cpp Generating moc_formats.cpp Generating moc_kcoreaddonsplugin.cpp Generating
Jenkins build is back to normal : kdeclarative_master_qt5 #160
See http://build.kde.org/job/kdeclarative_master_qt5/160/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: New framework: KXmlRpcClient
On Friday, January 30, 2015 09:12:01 AM David Faure wrote: On Wednesday 28 January 2015 17:12:04 Daniel Vrátil wrote: I guess I should update kde-build-metadata and release-tools and ask for the _stable_qt5 build once the repo is moved to frameworks on projects.k.o, so that changes don't have to be done twice (I don't really know if build.k.o has to be updated when module moves...?). No, build.kde.org uses a git url, so it doesn't matter where the module is logically placed on projects.kde.org. But yes, for kde-build-metadata it matters. (there is nothing to update in release-tools, just set release to true in your yaml file) KXmlRpcClient has been moved to frameworks. I enabled the release flag, adjusted kde-build-metadata, created bugzilla entry, so we should be good to go. David, could you please add it to release-tools? Apparently I don't have the rights :-) Thanks, Dan -- Daniel Vrátil | dvra...@redhat.com | dvratil on #kde-devel, #kontact, #akonadi Software Engineer - KDE Desktop Team, Red Hat Inc. GPG Key: 0xC59D614F6F4AE348 Fingerprint: 4EC1 86E3 C54E 0B39 5FDD B5FB C59D 614F 6F4A E348 signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is still unstable: plasma-framework_master_qt5 » All,LINBUILDER #995
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122383: Remove internal copy of KXmlRpcClient
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122383/#review75906 --- Ship it! KXmlRpcClient is a framework now! - Daniel Vrátil On Feb. 2, 2015, 4:37 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122383/ --- (Updated Feb. 2, 2015, 4:37 p.m.) Review request for KDE Frameworks, Plasma and Rohan Garg. Repository: plasma-workspace Description --- The internal copy isn't needed as soon as KXmlRpcClient becomes a framework. Diffs - drkonqi/internalkxmlrpcclient/KF5XmlRpcClientPrivateConfig.cmake.in 8f99a29 drkonqi/internalkxmlrpcclient/README d8b6cd2 drkonqi/internalkxmlrpcclient/autotests/CMakeLists.txt f737d14 drkonqi/internalkxmlrpcclient/autotests/testclient.h e4897a3 drkonqi/internalkxmlrpcclient/autotests/testclient.cpp f10b20a drkonqi/internalkxmlrpcclient/autotests/testquery.h 7957af6 drkonqi/internalkxmlrpcclient/autotests/testquery.cpp f43a7ff drkonqi/internalkxmlrpcclient/src/CMakeLists.txt 884599e drkonqi/internalkxmlrpcclient/src/Messages.sh 059f34d drkonqi/internalkxmlrpcclient/src/client.h 60866da drkonqi/internalkxmlrpcclient/src/client.cpp 779a01a drkonqi/internalkxmlrpcclient/src/query.h cd6b786 drkonqi/internalkxmlrpcclient/src/query.cpp ff18e24 drkonqi/tests/bugzillalibtest/bugzillalibtest.cpp 83d299a CMakeLists.txt e4d2b2d drkonqi/CMakeLists.txt d851d84 drkonqi/bugzillaintegration/reportassistantpages_bugzilla.cpp 12d9626 drkonqi/internalkxmlrpcclient/CMakeLists.txt 276aeaa drkonqi/internalkxmlrpcclient/COPYING.BSD cca2a5c Diff: https://git.reviewboard.kde.org/r/122383/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: New framework: KXmlRpcClient
On Thursday 12 February 2015 12:31:14 Daniel Vrátil wrote: On Friday, January 30, 2015 09:12:01 AM David Faure wrote: On Wednesday 28 January 2015 17:12:04 Daniel Vrátil wrote: I guess I should update kde-build-metadata and release-tools and ask for the _stable_qt5 build once the repo is moved to frameworks on projects.k.o, so that changes don't have to be done twice (I don't really know if build.k.o has to be updated when module moves...?). No, build.kde.org uses a git url, so it doesn't matter where the module is logically placed on projects.kde.org. But yes, for kde-build-metadata it matters. (there is nothing to update in release-tools, just set release to true in your yaml file) KXmlRpcClient has been moved to frameworks. I enabled the release flag, adjusted kde-build-metadata, created bugzilla entry, so we should be good to go. Great. David, could you please add it to release-tools? Apparently I don't have the rights :-) Again: don't worry about release-tools, it gets updated automatically at release time, based on the release flag in the yaml files. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122542: All frameworks: Add Q_DECL_OVERRIDE where needed
On feb. 12, 2015, 4:43 p.m., Albert Astals Cid wrote: It also adds a Q_DECL_OVERRIDE to a Q_DECL_FINAL which is not needed since final will already complain if trying to finalize something that is not overriding a virtual of the parent, no? Kevin Funk wrote: Nitpicker! :D Fixed that one occurence, but won't upload the patch again. Honestly, if it compiles, ship it, you can't screw up. - Albert --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122542/#review75928 --- On feb. 12, 2015, 3:47 p.m., Kevin Funk wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122542/ --- (Updated feb. 12, 2015, 3:47 p.m.) Review request for KDE Frameworks. Description --- This is a huge patch (almost 30 000 lines) covering all frameworks. This was done using clang-modernize and a few wrapper scripts. If you'll give me the okay, I'll push this to the individual frameworks. Diffs - Diff: https://git.reviewboard.kde.org/r/122542/diff/ Testing --- Compiles fine on my machine. File Attachments frameworks-add-override.patch https://git.reviewboard.kde.org/media/uploaded/files/2015/02/12/97a4c658-1517-4ab8-88ee-f76c09146393__frameworks-add-override.patch Without 'virtual' https://git.reviewboard.kde.org/media/uploaded/files/2015/02/12/8c42d21f-6a7b-496f-addf-757cb45dbc77__frameworks-add-override.patch Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121077: Check before using -Wno-deprecated-declarations.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121077/ --- (Updated feb. 12, 2015, 10:56 p.m.) Status -- This change has been discarded. Review request for KDE Base Apps, KDE Frameworks and kdewin. Repository: kde-baseapps Description --- A simple cmake check to avoid errors on MSVC. Diffs - dolphin/src/CMakeLists.txt c074908 Diff: https://git.reviewboard.kde.org/r/121077/diff/ Testing --- It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending to review today). Kdebase-apps is still not very functional, though (missing icons and weird UI). Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 122549: Avoid code path that leaves local config files locked
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122549/ --- Review request for KDE Frameworks and Matthew Dawson. Repository: kconfig Description --- The local config file gets locked on line 415, if we return early we need to unlock it otherwise we keep a stray .lock file on the config. We've been getting a lot of lockups in Plasma with stray .lock files so I code reviewed the relevant bit of code to look for any problems. I doubt this is the cause but it seems wrong anyway. Diffs - src/core/kconfig.cpp 782e971 Diff: https://git.reviewboard.kde.org/r/122549/diff/ Testing --- Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122445: an if-statement at KDesktopFile::locateLocal is not build correctly
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122445/#review75949
---
Guy: ping?
- Albert Astals Cid
On feb. 5, 2015, 6:36 p.m., Guy Maurel wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122445/
---
(Updated feb. 5, 2015, 6:36 p.m.)
Review request for KDE Frameworks, Cornelius Schumacher, Nicolás Alvarez, and
Thiago Macieira.
Repository: kconfig
Description
---
The if statements at lines 84, 91
if (path.startsWith(dir) + '/') {
cannot be correct. The value of (path.startsWith(dir) + '/') is always 47.
I propose to use:
QString plus = QLatin1String(/);
QString dirPlus;
...
Q_FOREACH (...) {
dirPlus = dir;
dirPlus.append(plus);
if (path.startsWith(dirPlus)) {
Diffs
-
src/core/kdesktopfile.cpp 6381cb30ba9382de492e2d8d4cf1f9e342f1c509
Diff: https://git.reviewboard.kde.org/r/122445/diff/
Testing
---
Thanks,
Guy Maurel
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121079: Fix building dolphin tests on MSVC
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121079/#review75951 --- Patch doesn't apply, please rebase - Albert Astals Cid On nov. 8, 2014, 10:26 p.m., Andrius da Costa Ribas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121079/ --- (Updated nov. 8, 2014, 10:26 p.m.) Review request for KDE Base Apps, KDE Frameworks and kdewin. Repository: kde-baseapps Description --- MSVC complains about missing symbols from their respective moc files on linking step. Diffs - dolphin/src/tests/CMakeLists.txt 60f6517 Diff: https://git.reviewboard.kde.org/r/121079/diff/ Testing --- It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending to review today). Kdebase-apps is still not very functional, though (missing icons and weird UI). Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121081: QT_WA
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121081/ --- (Updated Feb. 12, 2015, 10:53 p.m.) Status -- This change has been marked as submitted. Review request for KDE Base Apps, KDE Frameworks and kdewin. Repository: kde-baseapps Description --- QT_WA is not available on Qt5. We also only use the Unicode version, anyways. Diffs - lib/konq/src/konq_copytomenu.cpp 7f97c12 Diff: https://git.reviewboard.kde.org/r/121081/diff/ Testing --- It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending to review today). Kdebase-apps is still not very functional, though (missing icons and weird UI). Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122194: Initialise all member variables
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122194/ --- (Updated feb. 12, 2015, 10:51 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kdeclarative Description --- If DeclarativeMimeData is created using one of the two constructors m_source was not initialised. BUG: 336834 Diffs - src/qmlcontrols/draganddrop/DeclarativeMimeData.h 3d2beb5 src/qmlcontrols/draganddrop/DeclarativeMimeData.cpp fc96c83 Diff: https://git.reviewboard.kde.org/r/122194/diff/ Testing --- Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 118155: adapt to ecm_add_tests so that tests can be found
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118155/ --- (Updated feb. 12, 2015, 10:58 p.m.) Status -- This change has been discarded. Review request for KDE Frameworks, kdewin and Plasma. Repository: plasma-framework Description --- adapt to ecm_add_tests so that tests can be found Diffs - autotests/CMakeLists.txt dcee37f0771753d3e381e9d77f351cff16531e93 Diff: https://git.reviewboard.kde.org/r/118155/diff/ Testing --- mingw Thanks, Patrick Spendrin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119567: Also find catalog files that are symlinks
On Aug. 2, 2014, 1:25 a.m., Luigi Toscano wrote: src/docbookl10nhelper.cpp, line 209 https://git.reviewboard.kde.org/r/119567/diff/1/?file=294859#file294859line209 I'm pretty sure this is not needed: the script is called only during build time between the build directory and the source directory; unless the symlinks are created somehow before that phase. Ok, I guess it's not really a problem. - Luigi --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119567/#review63656 --- On Feb. 13, 2015, 1:26 a.m., Harald Fernengel wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119567/ --- (Updated Feb. 13, 2015, 1:26 a.m.) Review request for Documentation, KDE Frameworks and Luigi Toscano. Repository: kdoctools Description --- When building KF5 on Mac OS X with homebrew, the catalog and other files are symlinked from the 'Cellar' (install dir) to the homebrew prefix. After that, meinproc5 wouldn't find its catalog because it decides to ignore symbolic links. Removing that option fixes the build on Mac OS X. Diffs - src/docbookl10nhelper.cpp 6eecb376cab6e3ba03e9548b3402eaa5e5530198 src/xslt.cpp 3c81a172b00458419fc2f310cbdf76eb357336fc Diff: https://git.reviewboard.kde.org/r/119567/diff/ Testing --- Builds on Mac OS X Thanks, Harald Fernengel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119567: Also find catalog files that are symlinks
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119567/ --- (Updated Feb. 13, 2015, 12:26 a.m.) Status -- This change has been marked as submitted. Review request for Documentation, KDE Frameworks and Luigi Toscano. Repository: kdoctools Description --- When building KF5 on Mac OS X with homebrew, the catalog and other files are symlinked from the 'Cellar' (install dir) to the homebrew prefix. After that, meinproc5 wouldn't find its catalog because it decides to ignore symbolic links. Removing that option fixes the build on Mac OS X. Diffs - src/docbookl10nhelper.cpp 6eecb376cab6e3ba03e9548b3402eaa5e5530198 src/xslt.cpp 3c81a172b00458419fc2f310cbdf76eb357336fc Diff: https://git.reviewboard.kde.org/r/119567/diff/ Testing --- Builds on Mac OS X Thanks, Harald Fernengel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122542: All frameworks: Add Q_DECL_OVERRIDE where needed
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122542/#review75956 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 12, 2015, 4:47 p.m., Kevin Funk wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122542/ --- (Updated Feb. 12, 2015, 4:47 p.m.) Review request for KDE Frameworks. Description --- This is a huge patch (almost 30 000 lines) covering all frameworks. This was done using clang-modernize and a few wrapper scripts. If you'll give me the okay, I'll push this to the individual frameworks. Diffs - Diff: https://git.reviewboard.kde.org/r/122542/diff/ Testing --- Compiles fine on my machine. File Attachments frameworks-add-override.patch https://git.reviewboard.kde.org/media/uploaded/files/2015/02/12/97a4c658-1517-4ab8-88ee-f76c09146393__frameworks-add-override.patch Without 'virtual' https://git.reviewboard.kde.org/media/uploaded/files/2015/02/12/8c42d21f-6a7b-496f-addf-757cb45dbc77__frameworks-add-override.patch Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 122551: New feature: Open all recent files
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122551/ --- Review request for KDE Frameworks. Repository: kconfigwidgets Description --- I've always been looking for a feature (mostly in Kate et al.) to open all recently opened files at once. Every once in a while I think I'm done with some source code editing, realise that I'm not, and then have to click through all files one by one. With this patch opening all files at once gets possible. So much for the background. Still there are some open questions: 1) Is such a feature wanted at all? 2) Is the code quality/style ok? 3) Last but not least: This patch will work nicely with kate, presumably also with okular and some others, but I guess it will not work as expected with Kaffeine, for example, as new files which are to be opened will not get appended to a playlist but instead each file will get opened for an instance and then be replaced by the next opened file. Possible solutions: In principle it would be possible to add another signal passing a list of URLs to applications, which then have to define a suitable slot. Alternatively this patch could just not be applied and the feature I'm trying to introduce could be added to kate only... (I don't prefer that option ;) ) So, what are your opinions, comments, ideas? Thanks in advance! PS I hope the reviewer group kdeframeworks is the right one... Diffs - src/krecentfilesaction.h 06965d4 src/krecentfilesaction.cpp 40fdf93 src/krecentfilesaction_p.h 2c690a7 Diff: https://git.reviewboard.kde.org/r/122551/diff/ Testing --- I don't run KF5 on a daily basis, but in a Docker session the patch works nicely with Kate. Thanks, Thomas Murach ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122551: New feature: Open all recent files
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122551/#review75958 --- You're aware that Kate (and any other decent editor) has session management which probably solves your issue? It saves the session when you close it, and re-opens all the files that had been opened. - Kevin Funk On Feb. 12, 2015, 11:56 p.m., Thomas Murach wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122551/ --- (Updated Feb. 12, 2015, 11:56 p.m.) Review request for KDE Frameworks. Repository: kconfigwidgets Description --- I've always been looking for a feature (mostly in Kate et al.) to open all recently opened files at once. Every once in a while I think I'm done with some source code editing, realise that I'm not, and then have to click through all files one by one. With this patch opening all files at once gets possible. So much for the background. Still there are some open questions: 1) Is such a feature wanted at all? 2) Is the code quality/style ok? 3) Last but not least: This patch will work nicely with kate, presumably also with okular and some others, but I guess it will not work as expected with Kaffeine, for example, as new files which are to be opened will not get appended to a playlist but instead each file will get opened for an instance and then be replaced by the next opened file. Possible solutions: In principle it would be possible to add another signal passing a list of URLs to applications, which then have to define a suitable slot. Alternatively this patch could just not be applied and the feature I'm trying to introduce could be added to kate only... (I don't prefer that option ;) ) So, what are your opinions, comments, ideas? Thanks in advance! PS I hope the reviewer group kdeframeworks is the right one... Diffs - src/krecentfilesaction.h 06965d4 src/krecentfilesaction.cpp 40fdf93 src/krecentfilesaction_p.h 2c690a7 Diff: https://git.reviewboard.kde.org/r/122551/diff/ Testing --- I don't run KF5 on a daily basis, but in a Docker session the patch works nicely with Kate. Thanks, Thomas Murach ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 122555: knotifications: Add optional dependency on Qt5TextToSpeech for speech notifications.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122555/ --- Review request for KDE Frameworks and Frederik Gladhorn. Repository: knotifications Description --- Add optional dependency on Qt5TextToSpeech for speech notifications. Diffs - CMakeLists.txt 208fd02153a0607e4cfbc02e4b289ef835cedbfd src/CMakeLists.txt 6a3d81707a0e27e2d7bbfbf7f3924852ab737bf9 src/knotification.h c85621699793436442090b7f94ea82ef10c45b89 src/knotificationmanager.cpp affb6a673468bf6585cbda6fafdd008beb445cd9 src/kstatusnotifieritem.h 113dad513c320ef97f59b221b3541ca2f388693e src/notifybyktts.h 43756f776678bd7700a77a3357577363b36d2542 src/notifybyktts.cpp a2a15a9c77089527f54dfc63f13699d44336dda1 src/notifybyspeech.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122555/diff/ Testing --- As I said in the knotifyconfig review something at runtime isn't refreshing/reloading the config when it is changed. Otherwise this works fine when QtSpeech is available. QtSpeech is still in development, so this change is added as an optional dependency. Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122549: Avoid code path that leaves local config files locked
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122549/#review75962 --- related bug : https://bugs.kde.org/show_bug.cgi?id=344032 - Bhushan Shah On Feb. 13, 2015, 3:04 a.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122549/ --- (Updated Feb. 13, 2015, 3:04 a.m.) Review request for KDE Frameworks and Matthew Dawson. Repository: kconfig Description --- The local config file gets locked on line 415, if we return early we need to unlock it otherwise we keep a stray .lock file on the config. We've been getting a lot of lockups in Plasma with stray .lock files so I code reviewed the relevant bit of code to look for any problems. I doubt this is the cause but it seems wrong anyway. Diffs - src/core/kconfig.cpp 782e971 Diff: https://git.reviewboard.kde.org/r/122549/diff/ Testing --- Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 122554: knotifyconfig: Add optional dependency on QtSpeech to reenable speaking notifications.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122554/ --- Review request for KDE Frameworks and Frederik Gladhorn. Repository: knotifyconfig Description --- Change config from KTTS to Speech. If QtSpeech is available when building return true from have_speech static method. Otherwise return false. Could also add a check to see if there are any backend errors later on. Diffs - CMakeLists.txt f5aa0e78d89a4c14c3acfd9384b100e507e30067 src/knotifyconfigactionswidget.h 88b341a909d466b8eaf065c5220ac05f8c963697 src/knotifyconfigactionswidget.cpp 27012e3b803ef0a99d5bafcebea270e2d7419d62 src/knotifyconfigactionswidgetbase.ui cbe647b70eb41ba540b7bf6d87f519b3246973a1 src/knotifyconfigelement.h 703952d23d1622e4b6214acc52461ea75b480254 src/knotifyconfigelement.cpp 5a1ac57fa5a4139682327d14c55a489450ea956b src/knotifyeventlist.cpp 148bca7d33c722a4aeecabac45286a5e501c81b3 Diff: https://git.reviewboard.kde.org/r/122554/diff/ Testing --- It builds, the config widget shows, the icon for speech is properly showing when that configuration is enabled. Speech from konversation's new message notifications are spoken. Something strange here: After enabling this notification, no messages are spoken until restarting the application with the notifications (konversation in my test case). Similarly, after disabling this notification, messages are still spoken until restarting the application. I checked and the konversation.notifyrc file is getting updated, but for some reason the changes aren't taking effect imediately yet. Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
OSX/CI: kde-baseapps fails to build for branch-group stable-kf5-qt5
Hi Albert, I just realised that kde-baseapps fails on OSX/CI when being build for branch group stable-kf5-qt5: -- Group: stable-kf5-qt5 Project : kde/applications/kde-baseapps Branch : Applications/14.12 Linux-CI : UNSTABLE OSX/CI : FAILURE Prep... Build... : BUILD FAILED == This I find in the build log: --- -- The C compiler identification is AppleClang 6.0.0.656 -- The CXX compiler identification is AppleClang 6.0.0.656 -- Check for working C compiler: /usr/bin/cc -- Check for working C compiler: /usr/bin/cc -- works -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working CXX compiler: /usr/bin/c++ -- Check for working CXX compiler: /usr/bin/c++ -- works -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done CMake Error at /opt/kde/install/darwin/mavericks/clang/shared/general/cmake/share/cmake-3.1/Modules/FindKDE4.cmake:71 (message): ERROR: Could not find KDE4 kde4-config Call Stack (most recent call first): CMakeLists.txt:10 (find_package) CMake Warning (dev) in CMakeLists.txt: No cmake_minimum_required command is present. A line of code such as cmake_minimum_required(VERSION 3.1) should be added at the top of the file. The version specified may be lower if you wish to support older CMake versions for this project. For more information run cmake --help-policy CMP. This warning is for project developers. Use -Wno-dev to suppress it. -- Configuring incomplete, errors occurred! See also /Users/marko/WC/KDECI-builds/stable-kf5-qt5/kde-baseapps/build/CMakeFiles/CMakeOutput.log. KDE Continuous Integration Build == Building Project: kde-baseapps - Branch Applications/14.12 --- Any idea what goes wrong? Regards, Marko ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: OSX/CI: kde-baseapps fails to build for branch-group stable-kf5-qt5
I just realise that the same happens for these two projects: -- Group: stable-kf5-qt5 Project : kde/kdegraphics/libs/libkdcraw Branch : Applications/14.12 Linux-CI : SUCCESS OSX/CI : FAILURE Prep... Build... : BUILD FAILED == -- Group: stable-kf5-qt5 Project : kde/kdeedu/kqtquickcharts Branch : Applications/14.12 Linux-CI : SUCCESS OSX/CI : FAILURE Prep... Build... : BUILD FAILED == while many other build just fine, like the kde-edu projects! ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 122541: KService: fix regression in stringlist properties handling
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122541/ --- Review request for KDE Frameworks and Marco Martin. Repository: kservice Description --- Commit f724942 has introduced a regression in stringlist properties handling in KService's KPluginInfo. KPluginInfo::property() now tries to convert any `result` to QString (if the value is expected to be a string list) and split the string by , or ; to get a QStringList. This will fail when the `result` is already a QVariant(QStringList) (QPluginLoader and QJsonDocument handle JSON arrays correctly), because QVariant::toString() will return an empty string, so in the end the function returns empty list. This patch enables the attempt to deserialize string list only when the `result` value returned from KPluginMetaData is also a string. Diffs - src/services/kplugininfo.cpp 572f14b Diff: https://git.reviewboard.kde.org/r/122541/diff/ Testing --- KDevelop can load plugins again. Thanks, Daniel Vrátil ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122541: KService: fix regression in stringlist properties handling
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122541/#review75919 --- unittest? - Albert Astals Cid On feb. 12, 2015, 1:27 p.m., Daniel Vrátil wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122541/ --- (Updated feb. 12, 2015, 1:27 p.m.) Review request for KDE Frameworks and Marco Martin. Repository: kservice Description --- Commit f724942 has introduced a regression in stringlist properties handling in KService's KPluginInfo. KPluginInfo::property() now tries to convert any `result` to QString (if the value is expected to be a string list) and split the string by , or ; to get a QStringList. This will fail when the `result` is already a QVariant(QStringList) (QPluginLoader and QJsonDocument handle JSON arrays correctly), because QVariant::toString() will return an empty string, so in the end the function returns empty list. This patch enables the attempt to deserialize string list only when the `result` value returned from KPluginMetaData is also a string. Diffs - src/services/kplugininfo.cpp 572f14b Diff: https://git.reviewboard.kde.org/r/122541/diff/ Testing --- KDevelop can load plugins again. Thanks, Daniel Vrátil ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122541: KService: fix regression in stringlist properties handling
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122541/#review75920 --- discarded? what happened to it? - Marco Martin On Feb. 12, 2015, 1:27 p.m., Daniel Vrátil wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122541/ --- (Updated Feb. 12, 2015, 1:27 p.m.) Review request for KDE Frameworks and Marco Martin. Repository: kservice Description --- Commit f724942 has introduced a regression in stringlist properties handling in KService's KPluginInfo. KPluginInfo::property() now tries to convert any `result` to QString (if the value is expected to be a string list) and split the string by , or ; to get a QStringList. This will fail when the `result` is already a QVariant(QStringList) (QPluginLoader and QJsonDocument handle JSON arrays correctly), because QVariant::toString() will return an empty string, so in the end the function returns empty list. This patch enables the attempt to deserialize string list only when the `result` value returned from KPluginMetaData is also a string. Diffs - src/services/kplugininfo.cpp 572f14b Diff: https://git.reviewboard.kde.org/r/122541/diff/ Testing --- KDevelop can load plugins again. Thanks, Daniel Vrátil ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122514: Make it possible to interpret properties from plugins that expose properties correctly in the json
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122514/ --- (Updated Feb. 12, 2015, 1:54 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, Alex Richardson and David Faure. Repository: kservice Description --- Currently it checks whether it's a stringlist value according to the servicetype (good) and splits the ','. What this patch does is to allow plugins to use json lists to specify string list properties. For example: X-KDevelop-Interfaces: [ IBuildSystemManager, IProjectFileManager] Otherwise I was getting invalid values and nothing worked. Diffs - autotests/kplugininfotest.cpp d99b92a src/services/kplugininfo.cpp 572f14b Diff: https://git.reviewboard.kde.org/r/122514/diff/ Testing --- Builds, tests still pass. Now KDevelop boots correctly, I tried to add a test, but I don't know where's the service type file for KService/NSA. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 122542: All frameworks: Add Q_DECL_OVERRIDE where needed
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122542/ --- Review request for KDE Frameworks. Description --- This is a huge patch (almost 30 000 lines) covering all frameworks. This was done using clang-modernize and a few wrapper scripts. If you'll give me the okay, I'll push this to the individual frameworks. Diffs - Diff: https://git.reviewboard.kde.org/r/122542/diff/ Testing --- Compiles fine on my machine. File Attachments frameworks-add-override.patch https://git.reviewboard.kde.org/media/uploaded/files/2015/02/12/97a4c658-1517-4ab8-88ee-f76c09146393__frameworks-add-override.patch Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122541: KService: fix regression in stringlist properties handling
On Feb. 12, 2015, 1:49 p.m., Marco Martin wrote: discarded? what happened to it? Martin Klapetek wrote: This happened :) https://git.reviewboard.kde.org/r/122514/ oki (hmm, hope can fix the current test fail in kservice) - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122541/#review75920 --- On Feb. 12, 2015, 1:27 p.m., Daniel Vrátil wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122541/ --- (Updated Feb. 12, 2015, 1:27 p.m.) Review request for KDE Frameworks and Marco Martin. Repository: kservice Description --- Commit f724942 has introduced a regression in stringlist properties handling in KService's KPluginInfo. KPluginInfo::property() now tries to convert any `result` to QString (if the value is expected to be a string list) and split the string by , or ; to get a QStringList. This will fail when the `result` is already a QVariant(QStringList) (QPluginLoader and QJsonDocument handle JSON arrays correctly), because QVariant::toString() will return an empty string, so in the end the function returns empty list. This patch enables the attempt to deserialize string list only when the `result` value returned from KPluginMetaData is also a string. Diffs - src/services/kplugininfo.cpp 572f14b Diff: https://git.reviewboard.kde.org/r/122541/diff/ Testing --- KDevelop can load plugins again. Thanks, Daniel Vrátil ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122541: KService: fix regression in stringlist properties handling
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122541/ --- (Updated Feb. 12, 2015, 2:27 p.m.) Status -- This change has been discarded. Review request for KDE Frameworks and Marco Martin. Repository: kservice Description --- Commit f724942 has introduced a regression in stringlist properties handling in KService's KPluginInfo. KPluginInfo::property() now tries to convert any `result` to QString (if the value is expected to be a string list) and split the string by , or ; to get a QStringList. This will fail when the `result` is already a QVariant(QStringList) (QPluginLoader and QJsonDocument handle JSON arrays correctly), because QVariant::toString() will return an empty string, so in the end the function returns empty list. This patch enables the attempt to deserialize string list only when the `result` value returned from KPluginMetaData is also a string. Diffs - src/services/kplugininfo.cpp 572f14b Diff: https://git.reviewboard.kde.org/r/122541/diff/ Testing --- KDevelop can load plugins again. Thanks, Daniel Vrátil ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122541: KService: fix regression in stringlist properties handling
On Feb. 12, 2015, 2:49 p.m., Marco Martin wrote: discarded? what happened to it? This happened :) https://git.reviewboard.kde.org/r/122514/ - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122541/#review75920 --- On Feb. 12, 2015, 2:27 p.m., Daniel Vrátil wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122541/ --- (Updated Feb. 12, 2015, 2:27 p.m.) Review request for KDE Frameworks and Marco Martin. Repository: kservice Description --- Commit f724942 has introduced a regression in stringlist properties handling in KService's KPluginInfo. KPluginInfo::property() now tries to convert any `result` to QString (if the value is expected to be a string list) and split the string by , or ; to get a QStringList. This will fail when the `result` is already a QVariant(QStringList) (QPluginLoader and QJsonDocument handle JSON arrays correctly), because QVariant::toString() will return an empty string, so in the end the function returns empty list. This patch enables the attempt to deserialize string list only when the `result` value returned from KPluginMetaData is also a string. Diffs - src/services/kplugininfo.cpp 572f14b Diff: https://git.reviewboard.kde.org/r/122541/diff/ Testing --- KDevelop can load plugins again. Thanks, Daniel Vrátil ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122539: Use Q_DECL_OVERRIDE where possible
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122539/ --- (Updated Feb. 12, 2015, 12:54 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Matthew Dawson. Repository: kconfig Description --- With -Winconsistent-missing-override (Clang), headers from KConfig are throwing a lot of warnings. Diffs - src/core/kconfig.h 0fb15756ec9d089b956ebc9eb3eeade0a76cf7c1 src/core/kconfiggroup.h abb246e37619bcead938a0496eac51f6afff5ec4 src/core/kconfigini_p.h 29f61090df99bf66fdccdb0a1801dbeaec1c6c0f src/core/kcoreconfigskeleton.h bb3d0f61adbfe95077fce759bb437ae7a13856be src/core/ksharedconfig.h b2317afd6d5189e6364acc989bc9ca7a5694248d src/gui/kconfigloader.h aadb19a5b266f4c1ccd07d4b05af0dcbd2686bd9 src/gui/kconfigloaderhandler_p.h 1c7c5a1d3c79a7e98a53245d1037be0b253dc135 src/gui/kconfigskeleton.h 4cd8d140535bb550af8b934a746e2a8ffc0ec008 Diff: https://git.reviewboard.kde.org/r/122539/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122542: All frameworks: Add Q_DECL_OVERRIDE where needed
On Feb. 12, 2015, 2:53 p.m., Albert Astals Cid wrote: Is your script smart enough to convert virtual QByteArray data() const; into QByteArray data() const Q_DECL_OVERRIDE; instead of virtual QByteArray data() const Q_DECL_OVERRIDE; Nope. It only deals with 'override'. But in this case I could easily do sth along s/virtual// in the *diff*. - Kevin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122542/#review75924 --- On Feb. 12, 2015, 2:43 p.m., Kevin Funk wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122542/ --- (Updated Feb. 12, 2015, 2:43 p.m.) Review request for KDE Frameworks. Description --- This is a huge patch (almost 30 000 lines) covering all frameworks. This was done using clang-modernize and a few wrapper scripts. If you'll give me the okay, I'll push this to the individual frameworks. Diffs - Diff: https://git.reviewboard.kde.org/r/122542/diff/ Testing --- Compiles fine on my machine. File Attachments frameworks-add-override.patch https://git.reviewboard.kde.org/media/uploaded/files/2015/02/12/97a4c658-1517-4ab8-88ee-f76c09146393__frameworks-add-override.patch Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122542: All frameworks: Add Q_DECL_OVERRIDE where needed
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122542/#review75926 --- +1 from me (though it would be prettier to also remove 'virtual', as Albert mentioned) - Ivan Čukić On Feb. 12, 2015, 2:43 p.m., Kevin Funk wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122542/ --- (Updated Feb. 12, 2015, 2:43 p.m.) Review request for KDE Frameworks. Description --- This is a huge patch (almost 30 000 lines) covering all frameworks. This was done using clang-modernize and a few wrapper scripts. If you'll give me the okay, I'll push this to the individual frameworks. Diffs - Diff: https://git.reviewboard.kde.org/r/122542/diff/ Testing --- Compiles fine on my machine. File Attachments frameworks-add-override.patch https://git.reviewboard.kde.org/media/uploaded/files/2015/02/12/97a4c658-1517-4ab8-88ee-f76c09146393__frameworks-add-override.patch Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is still unstable: plasma-framework_master_qt5 » All,LINBUILDER #996
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is still unstable: plasma-framework_master_qt5 » All,LINBUILDER #997
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122542: All frameworks: Add Q_DECL_OVERRIDE where needed
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122542/ --- (Updated Feb. 12, 2015, 3:47 p.m.) Review request for KDE Frameworks. Changes --- New patch, removing 'virtual' from decls Description --- This is a huge patch (almost 30 000 lines) covering all frameworks. This was done using clang-modernize and a few wrapper scripts. If you'll give me the okay, I'll push this to the individual frameworks. Diffs - Diff: https://git.reviewboard.kde.org/r/122542/diff/ Testing --- Compiles fine on my machine. File Attachments (updated) frameworks-add-override.patch https://git.reviewboard.kde.org/media/uploaded/files/2015/02/12/97a4c658-1517-4ab8-88ee-f76c09146393__frameworks-add-override.patch Without 'virtual' https://git.reviewboard.kde.org/media/uploaded/files/2015/02/12/8c42d21f-6a7b-496f-addf-757cb45dbc77__frameworks-add-override.patch Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122542: All frameworks: Add Q_DECL_OVERRIDE where needed
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122542/#review75928 --- It also adds a Q_DECL_OVERRIDE to a Q_DECL_FINAL which is not needed since final will already complain if trying to finalize something that is not overriding a virtual of the parent, no? - Albert Astals Cid On feb. 12, 2015, 3:47 p.m., Kevin Funk wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122542/ --- (Updated feb. 12, 2015, 3:47 p.m.) Review request for KDE Frameworks. Description --- This is a huge patch (almost 30 000 lines) covering all frameworks. This was done using clang-modernize and a few wrapper scripts. If you'll give me the okay, I'll push this to the individual frameworks. Diffs - Diff: https://git.reviewboard.kde.org/r/122542/diff/ Testing --- Compiles fine on my machine. File Attachments frameworks-add-override.patch https://git.reviewboard.kde.org/media/uploaded/files/2015/02/12/97a4c658-1517-4ab8-88ee-f76c09146393__frameworks-add-override.patch Without 'virtual' https://git.reviewboard.kde.org/media/uploaded/files/2015/02/12/8c42d21f-6a7b-496f-addf-757cb45dbc77__frameworks-add-override.patch Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122542: All frameworks: Add Q_DECL_OVERRIDE where needed
On Feb. 12, 2015, 4:43 p.m., Albert Astals Cid wrote: It also adds a Q_DECL_OVERRIDE to a Q_DECL_FINAL which is not needed since final will already complain if trying to finalize something that is not overriding a virtual of the parent, no? Nitpicker! :D Fixed that one occurence, but won't upload the patch again. - Kevin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122542/#review75928 --- On Feb. 12, 2015, 3:47 p.m., Kevin Funk wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122542/ --- (Updated Feb. 12, 2015, 3:47 p.m.) Review request for KDE Frameworks. Description --- This is a huge patch (almost 30 000 lines) covering all frameworks. This was done using clang-modernize and a few wrapper scripts. If you'll give me the okay, I'll push this to the individual frameworks. Diffs - Diff: https://git.reviewboard.kde.org/r/122542/diff/ Testing --- Compiles fine on my machine. File Attachments frameworks-add-override.patch https://git.reviewboard.kde.org/media/uploaded/files/2015/02/12/97a4c658-1517-4ab8-88ee-f76c09146393__frameworks-add-override.patch Without 'virtual' https://git.reviewboard.kde.org/media/uploaded/files/2015/02/12/8c42d21f-6a7b-496f-addf-757cb45dbc77__frameworks-add-override.patch Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
