Review Request 122908: Fix segfaults due to missing screens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122908/ --- Review request for KDE Frameworks. Repository: kwindowsystem Description --- Fix segfaults due to missing screens Qt 5.5 has some changes which allow returning of null QScreen*. This file was OK with such a situation throughout a lot of other places, but these two were missing. Diffs - src/kwindoweffects_x11.cpp 661a0af95a7a1757c5ae863270434b0c2d5c0a26 Diff: https://git.reviewboard.kde.org/r/122908/diff/ Testing --- Thanks, Jan Kundrát ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122886: QML-only KCM base
On March 11, 2015, 2:07 p.m., David Edmundson wrote: src/quickaddons/configmodule.h, line 373 https://git.reviewboard.kde.org/r/122886/diff/1/?file=354024#file354024line373 I guess you copy and pasted all these. KConfigXT isn't relevant at all here. yes, is pretty much KCModule docs :) I think they are fine-ish, I think needs mostly the addition of how to combine that with QML in the general class description seciton. On March 11, 2015, 2:07 p.m., David Edmundson wrote: src/quickaddons/configmodule.h, line 338 https://git.reviewboard.kde.org/r/122886/diff/1/?file=354024#file354024line338 This documentation tells me nothing, and I'm not sure what this does from the method name. eh, I have no idea about this method as well :/ it's a thing exported by KCModule, so here just wrapping it. it's presumably used for some reason, somewhere, but even from the code it's not understandable. on lxr, seems the only place where is used is KInfoCenter http://lxr.kde.org/source/kde/workspace/kinfocenter/infocenter.cpp?v=kf5-qt5 (may be worth even just dumping it...) On March 11, 2015, 2:07 p.m., David Edmundson wrote: src/quickaddons/configmodule.cpp, line 102 https://git.reviewboard.kde.org/r/122886/diff/1/?file=354025#file354025line102 when combined with your other KCModule patch you have a crash. From KCModule docs: This sets the KAboutData returned by aboutData() The about data is now owned by KCModule. So this will result in a double delete. Same for the delete in setAboutData. hmm, would work actually creating a copy of this about data in the wrapper class? - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122886/#review77304 --- On March 10, 2015, 11:28 a.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122886/ --- (Updated March 10, 2015, 11:28 a.m.) Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- This is a QObject-based fork of KCmodule, with the api slightly adaped to be more declarative friendly. it loads a qml file that then will be able to access its instance as kcm or as the KCM attached property, like what happens in plasmoids (for how attached proeprties work, unfortunately only properties of the base class will be accessible). They will be loaded in systemsettings by review 122887 Diffs - src/quickaddons/CMakeLists.txt 3c7a34b src/quickaddons/configmodule.h PRE-CREATION src/quickaddons/configmodule.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122886/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122886: QML-only KCM base
On March 11, 2015, 2:07 p.m., David Edmundson wrote: src/quickaddons/configmodule.cpp, line 102 https://git.reviewboard.kde.org/r/122886/diff/1/?file=354025#file354025line102 when combined with your other KCModule patch you have a crash. From KCModule docs: This sets the KAboutData returned by aboutData() The about data is now owned by KCModule. So this will result in a double delete. Same for the delete in setAboutData. Marco Martin wrote: hmm, would work actually creating a copy of this about data in the wrapper class? David Edmundson wrote: Yeah, I think that would work. Marco Martin wrote: thinking about it i'm not sure about the double delete (i don't get a crash after all) since KCModuleQml never gets an aboutdata by its own but just returns this class instance in the reimplementation of virtual aboutData() (so the KCModule instance never gets a valid d-_aboutData), opposed to do a setAboutData(d-configModule-aboutData()) in which would definitely crash oh, you're right. I got confused as we were signally and proxying everything else. You can close this. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122886/#review77304 --- On March 10, 2015, 11:28 a.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122886/ --- (Updated March 10, 2015, 11:28 a.m.) Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- This is a QObject-based fork of KCmodule, with the api slightly adaped to be more declarative friendly. it loads a qml file that then will be able to access its instance as kcm or as the KCM attached property, like what happens in plasmoids (for how attached proeprties work, unfortunately only properties of the base class will be accessible). They will be loaded in systemsettings by review 122887 Diffs - src/quickaddons/CMakeLists.txt 3c7a34b src/quickaddons/configmodule.h PRE-CREATION src/quickaddons/configmodule.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122886/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122886: QML-only KCM base
On March 11, 2015, 2:07 p.m., David Edmundson wrote: src/quickaddons/configmodule.cpp, line 102 https://git.reviewboard.kde.org/r/122886/diff/1/?file=354025#file354025line102 when combined with your other KCModule patch you have a crash. From KCModule docs: This sets the KAboutData returned by aboutData() The about data is now owned by KCModule. So this will result in a double delete. Same for the delete in setAboutData. Marco Martin wrote: hmm, would work actually creating a copy of this about data in the wrapper class? Yeah, I think that would work. On March 11, 2015, 2:07 p.m., David Edmundson wrote: src/quickaddons/configmodule.h, line 338 https://git.reviewboard.kde.org/r/122886/diff/1/?file=354024#file354024line338 This documentation tells me nothing, and I'm not sure what this does from the method name. Marco Martin wrote: eh, I have no idea about this method as well :/ it's a thing exported by KCModule, so here just wrapping it. it's presumably used for some reason, somewhere, but even from the code it's not understandable. on lxr, seems the only place where is used is KInfoCenter http://lxr.kde.org/source/kde/workspace/kinfocenter/infocenter.cpp?v=kf5-qt5 (may be worth even just dumping it...) ++ for killing it here. Then it becomes not our problem :D - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122886/#review77304 --- On March 10, 2015, 11:28 a.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122886/ --- (Updated March 10, 2015, 11:28 a.m.) Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- This is a QObject-based fork of KCmodule, with the api slightly adaped to be more declarative friendly. it loads a qml file that then will be able to access its instance as kcm or as the KCM attached property, like what happens in plasmoids (for how attached proeprties work, unfortunately only properties of the base class will be accessible). They will be loaded in systemsettings by review 122887 Diffs - src/quickaddons/CMakeLists.txt 3c7a34b src/quickaddons/configmodule.h PRE-CREATION src/quickaddons/configmodule.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122886/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122886: QML-only KCM base
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122886/#review77309 --- src/quickaddons/CMakeLists.txt https://git.reviewboard.kde.org/r/122886/#comment53094 you need also KF5::Auth as public, the new public header has a kauthaction include - Hrvoje Senjan On March 10, 2015, 12:28 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122886/ --- (Updated March 10, 2015, 12:28 p.m.) Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- This is a QObject-based fork of KCmodule, with the api slightly adaped to be more declarative friendly. it loads a qml file that then will be able to access its instance as kcm or as the KCM attached property, like what happens in plasmoids (for how attached proeprties work, unfortunately only properties of the base class will be accessible). They will be loaded in systemsettings by review 122887 Diffs - src/quickaddons/CMakeLists.txt 3c7a34b src/quickaddons/configmodule.h PRE-CREATION src/quickaddons/configmodule.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122886/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122886: QML-only KCM base
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122886/ --- (Updated March 11, 2015, 5:05 p.m.) Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- This is a QObject-based fork of KCmodule, with the api slightly adaped to be more declarative friendly. it loads a qml file that then will be able to access its instance as kcm or as the KCM attached property, like what happens in plasmoids (for how attached proeprties work, unfortunately only properties of the base class will be accessible). They will be loaded in systemsettings by review 122887 Diffs (updated) - src/quickaddons/CMakeLists.txt 3c7a34b src/quickaddons/configmodule.h PRE-CREATION src/quickaddons/configmodule.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122886/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122886: QML-only KCM base
On March 11, 2015, 2:07 p.m., David Edmundson wrote: src/quickaddons/configmodule.cpp, line 102 https://git.reviewboard.kde.org/r/122886/diff/1/?file=354025#file354025line102 when combined with your other KCModule patch you have a crash. From KCModule docs: This sets the KAboutData returned by aboutData() The about data is now owned by KCModule. So this will result in a double delete. Same for the delete in setAboutData. Marco Martin wrote: hmm, would work actually creating a copy of this about data in the wrapper class? David Edmundson wrote: Yeah, I think that would work. thinking about it i'm not sure about the double delete (i don't get a crash after all) since KCModuleQml never gets an aboutdata by its own but just returns this class instance in the reimplementation of virtual aboutData() (so the KCModule instance never gets a valid d-_aboutData), opposed to do a setAboutData(d-configModule-aboutData()) in which would definitely crash - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122886/#review77304 --- On March 10, 2015, 11:28 a.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122886/ --- (Updated March 10, 2015, 11:28 a.m.) Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- This is a QObject-based fork of KCmodule, with the api slightly adaped to be more declarative friendly. it loads a qml file that then will be able to access its instance as kcm or as the KCM attached property, like what happens in plasmoids (for how attached proeprties work, unfortunately only properties of the base class will be accessible). They will be loaded in systemsettings by review 122887 Diffs - src/quickaddons/CMakeLists.txt 3c7a34b src/quickaddons/configmodule.h PRE-CREATION src/quickaddons/configmodule.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122886/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: [kde-frameworks-devel] Review request: QBluez
On Wed, Mar 11, 2015 at 6:49 PM, Jonathan Riddell j...@jriddell.org wrote: The name KF5BluezQt seems inelegant, is has both a prefix and a suffix, how about just KF5Bluez? That would work, but only for cmake files, otherwise I would have to change namespace from BluezQt to just Bluez, which is obviously not a right thing. The headers get installed into /usr/include/BluezQt/, I guess that should be /usr/include/KF5/BluezQt/ ? It requires extra-cmake-modules 1.8 but seems to compile fine with 1.7. Fixed Do you expect this to be moved into KDE Frameworks? That gets tagged on April 4th. Or do you expect it to be moved into kde/workspace for release with Plasma? That gets tagged in April 9th. If it goes into Frameworks it must remain API and ABI compatible while in Plasma you only need to bump the soversion if it changes. Is it ready for that? Originally, I wanted to move it to frameworks. But if i think about it again, I plan to extend the library with new features which may break the ABI. So, I would like to move it to kde/workspace once reviewed. Thanks, David ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 122910: Introduce KMoreTools
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122910/ --- Review request for KDE Frameworks, Emmanuel Pescosta and Jeremy Whiting. Repository: knewstuff Description --- Moved from kservice (https://git.reviewboard.kde.org/r/122576/) to here (knewstuff). Diffs - src/CMakeLists.txt 3b9a403eb473e0c3760506b2757c71d603b99775 src/kmoretools/kmoretools.h PRE-CREATION src/kmoretools/kmoretools.cpp PRE-CREATION src/kmoretools/kmoretools_p.h PRE-CREATION src/kmoretools/kmoretoolsconfigdialog_p.h PRE-CREATION src/kmoretools/kmoretoolsconfigdialog_p.cpp PRE-CREATION src/kmoretools/ui/kmoretoolsconfigwidget.ui PRE-CREATION tests/CMakeLists.txt 103c5fc98deaf83288b843cc66a87f2d95ad9dfb tests/kmoretools/1/a.desktop PRE-CREATION tests/kmoretools/1/b.desktop PRE-CREATION tests/kmoretools/1/c.desktop PRE-CREATION tests/kmoretools/2/kate.desktop PRE-CREATION tests/kmoretools/2/kate.png PRE-CREATION tests/kmoretools/2/mynotinstalledapp.desktop PRE-CREATION tests/kmoretools/2/mynotinstalledapp.png PRE-CREATION tests/kmoretools/kmoretoolstest.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122910/diff/ Testing --- Thanks, Gregor Mi ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122893: Populate KIconDialog on showEvent
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122893/ --- (Updated März 11, 2015, 10:56 nachm.) Review request for KDE Frameworks. Changes --- Use eventFilter Repository: kiconthemes Description --- Populate the dialog on showEvent, this way you can use the regular QDialog show() and exec() methods and use, for instance, Qt::WindowModal rather than having showDialog() or openDialog() mess with modality. showDialog() could probably be deprecated then. I don't know whether this is binary compatible. you can safely reimplement a virtual function defined in one of the base classes only if it is safe that the programs linked with the prior version call the implementation in the base class rather than the derived one Diffs (updated) - src/kicondialog.h ee4edca src/kicondialog.cpp 7a6c1f1 Diff: https://git.reviewboard.kde.org/r/122893/diff/ Testing --- Just calling show() on the KIconDialog works as expected, the icon button in kfileproperties thingie dialog still works. Thanks, Kai Uwe Broulik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122910: Introduce KMoreTools
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122910/ --- (Updated March 11, 2015, 11:06 p.m.) Review request for KDE Frameworks, Emmanuel Pescosta and Jeremy Whiting. Repository: knewstuff Description (updated) --- Moved from kservice (https://git.reviewboard.kde.org/r/122576/) to here (knewstuff). Example usages: - dolphin's SpaceInfoToolsMenu: https://git.reviewboard.kde.org/r/122911/ - kate's project addin: https://git.reviewboard.kde.org/r/122374/ Diffs - src/CMakeLists.txt 3b9a403eb473e0c3760506b2757c71d603b99775 src/kmoretools/kmoretools.h PRE-CREATION src/kmoretools/kmoretools.cpp PRE-CREATION src/kmoretools/kmoretools_p.h PRE-CREATION src/kmoretools/kmoretoolsconfigdialog_p.h PRE-CREATION src/kmoretools/kmoretoolsconfigdialog_p.cpp PRE-CREATION src/kmoretools/ui/kmoretoolsconfigwidget.ui PRE-CREATION tests/CMakeLists.txt 103c5fc98deaf83288b843cc66a87f2d95ad9dfb tests/kmoretools/1/a.desktop PRE-CREATION tests/kmoretools/1/b.desktop PRE-CREATION tests/kmoretools/1/c.desktop PRE-CREATION tests/kmoretools/2/kate.desktop PRE-CREATION tests/kmoretools/2/kate.png PRE-CREATION tests/kmoretools/2/mynotinstalledapp.desktop PRE-CREATION tests/kmoretools/2/mynotinstalledapp.png PRE-CREATION tests/kmoretools/kmoretoolstest.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122910/diff/ Testing --- Thanks, Gregor Mi ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122576: Introduce KMoreTools
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122576/#review77316 --- Moved to knewstuff: https://git.reviewboard.kde.org/r/122910/ - Gregor Mi On March 1, 2015, 2:28 p.m., Gregor Mi wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122576/ --- (Updated March 1, 2015, 2:28 p.m.) Review request for KDE Frameworks, Dominik Haumann and Emmanuel Pescosta. Repository: kservice Description --- Usage examples see https://git.reviewboard.kde.org/r/122352/ and https://git.reviewboard.kde.org/r/122374/ Description see class comments on KMoreTools and https://community.kde.org/Scratchpad/KMoreToolsFramework If KMoreTools is considered useful it needs a home. I placed it in KService for now. Diffs - CMakeLists.txt 34ce792652415100c9a5f877f0516781eb4aec17 src/CMakeLists.txt 35154a597f55313847b8140962c0e2a4cf1c15a2 src/kmoretools/kmoretools.h PRE-CREATION src/kmoretools/kmoretools.cpp PRE-CREATION src/kmoretools/kmoretools_p.h PRE-CREATION src/kmoretools/kmoretoolsconfigdialog_p.h PRE-CREATION src/kmoretools/kmoretoolsconfigdialog_p.cpp PRE-CREATION src/kmoretools/ui/kmoretoolsconfigwidget.ui PRE-CREATION tests/CMakeLists.txt cbb5ece6a3265612fa4640426b7025de8f0dc78e tests/kmoretools/1/a.desktop PRE-CREATION tests/kmoretools/1/b.desktop PRE-CREATION tests/kmoretools/1/c.desktop PRE-CREATION tests/kmoretools/2/kate.desktop PRE-CREATION tests/kmoretools/2/kate.png PRE-CREATION tests/kmoretools/2/mynotinstalledapp.desktop PRE-CREATION tests/kmoretools/2/mynotinstalledapp.png PRE-CREATION tests/kmoretools/kmoretoolstest.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122576/diff/ Testing --- Thanks, Gregor Mi ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: solid bugzilla product marked obsolete
El Dimecres, 11 de març de 2015, a les 20:24:00, Jonathan Riddell va escriure: I've labelled the solid bugzilla product as obsolete and added a comment to any bugs that it's for kdelibs4 code which is now in maintenance mode. Replacement products are bluedevil, powerdevil, plasma-nm and frameworks-solid. You forgot to email kde-hardware-de...@kde.org Jonathan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: New framework: BluezQt
On Tue, Mar 10, 2015 at 10:12:31PM +0100, David Rosca wrote: BluezQt is a wrapper library for Bluez 5 DBus API. It will be used in Bluedevil as a replacement for libbluedevil. It is currently in playground (playground/libs/bluez-qt). It should be a Tier 1 framework (only depends on Qt libs). The code should follow all framework policies and the build is green, so I'd like to submit BluezQt for review. Also sent this to the other thread on kde-core-devel... Looks like you've been working hard :) The name KF5BluezQt seems inelegant, is has both a prefix and a suffix, how about just KF5Bluez ? The headers get installed into /usr/include/BluezQt/, I guess that should be /usr/include/KF5/BluezQt/ ? It requires extra-cmake-modules 1.8 but seems to compile fine with 1.7. Do you expect this to be moved into KDE Frameworks? That gets tagged on April 4th. Or do you expect it to be moved into kde/workspace for release with Plasma? That gets tagged in April 9th. If it goes into Frameworks it must remain API and ABI compatible while in Plasma you only need to bump the soversion if it changes. Is it ready for that? Jonathan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
solid bugzilla product marked obsolete
I've labelled the solid bugzilla product as obsolete and added a comment to any bugs that it's for kdelibs4 code which is now in maintenance mode. Replacement products are bluedevil, powerdevil, plasma-nm and frameworks-solid. Jonathan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: [kde-frameworks-devel] Review request: QBluez
On Mon, Feb 16, 2015 at 10:40:44AM +0100, David Rosca wrote: Hi all, I'd like to ask for a review of the QBluez library [1]. Looks like you've been working hard :) The name KF5BluezQt seems inelegant, is has both a prefix and a suffix, how about just KF5Bluez ? The headers get installed into /usr/include/BluezQt/, I guess that should be /usr/include/KF5/BluezQt/ ? It requires extra-cmake-modules 1.8 but seems to compile fine with 1.7. Do you expect this to be moved into KDE Frameworks? That gets tagged on April 4th. Or do you expect it to be moved into kde/workspace for release with Plasma? That gets tagged in April 9th. If it goes into Frameworks it must remain API and ABI compatible while in Plasma you only need to bump the soversion if it changes. Is it ready for that? Jonathan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122576: Introduce KMoreTools
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122576/ --- (Updated March 11, 2015, 11:08 p.m.) Status -- This change has been discarded. Review request for KDE Frameworks, Dominik Haumann and Emmanuel Pescosta. Repository: kservice Description --- Usage examples see https://git.reviewboard.kde.org/r/122352/ and https://git.reviewboard.kde.org/r/122374/ Description see class comments on KMoreTools and https://community.kde.org/Scratchpad/KMoreToolsFramework If KMoreTools is considered useful it needs a home. I placed it in KService for now. Diffs - CMakeLists.txt 34ce792652415100c9a5f877f0516781eb4aec17 src/CMakeLists.txt 35154a597f55313847b8140962c0e2a4cf1c15a2 src/kmoretools/kmoretools.h PRE-CREATION src/kmoretools/kmoretools.cpp PRE-CREATION src/kmoretools/kmoretools_p.h PRE-CREATION src/kmoretools/kmoretoolsconfigdialog_p.h PRE-CREATION src/kmoretools/kmoretoolsconfigdialog_p.cpp PRE-CREATION src/kmoretools/ui/kmoretoolsconfigwidget.ui PRE-CREATION tests/CMakeLists.txt cbb5ece6a3265612fa4640426b7025de8f0dc78e tests/kmoretools/1/a.desktop PRE-CREATION tests/kmoretools/1/b.desktop PRE-CREATION tests/kmoretools/1/c.desktop PRE-CREATION tests/kmoretools/2/kate.desktop PRE-CREATION tests/kmoretools/2/kate.png PRE-CREATION tests/kmoretools/2/mynotinstalledapp.desktop PRE-CREATION tests/kmoretools/2/mynotinstalledapp.png PRE-CREATION tests/kmoretools/kmoretoolstest.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122576/diff/ Testing --- Thanks, Gregor Mi ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: [Kde-hardware-devel] solid bugzilla product marked obsolete
On Thu, Mar 12, 2015 at 12:37 AM, Lamarque Souza lamar...@kde.org wrote: Hi all, Following the obsolete action, could someone mark Network Management product as obsolete too? It is related to old Plasma NM 0.9.0.x series, which is now unmaintained. I've removed open for bugs option on that product. Thanks Lamarque V. Souza KDE's Network Management maintainer http://planetkde.org/pt-br On Wed, Mar 11, 2015 at 7:57 PM, Albert Astals Cid aa...@kde.org wrote: El Dimecres, 11 de març de 2015, a les 20:24:00, Jonathan Riddell va escriure: I've labelled the solid bugzilla product as obsolete and added a comment to any bugs that it's for kdelibs4 code which is now in maintenance mode. Replacement products are bluedevil, powerdevil, plasma-nm and frameworks-solid. You forgot to email kde-hardware-de...@kde.org Jonathan ___ Kde-hardware-devel mailing list kde-hardware-de...@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122893: Populate KIconDialog on showEvent
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122893/#review77320 --- src/kicondialog.cpp https://git.reviewboard.kde.org/r/122893/#comment53104 I do not understand the check for spontaneous. Is there a case where showIcons does not need to be called when receiving a showEvent? If this is to avoid stealing the focus, it probably needs to be moved down to the setFocus call. - Christoph Feck On March 11, 2015, 10:56 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122893/ --- (Updated March 11, 2015, 10:56 p.m.) Review request for KDE Frameworks. Repository: kiconthemes Description --- Populate the dialog on showEvent, this way you can use the regular QDialog show() and exec() methods and use, for instance, Qt::WindowModal rather than having showDialog() or openDialog() mess with modality. showDialog() could probably be deprecated then. I don't know whether this is binary compatible. you can safely reimplement a virtual function defined in one of the base classes only if it is safe that the programs linked with the prior version call the implementation in the base class rather than the derived one Diffs - src/kicondialog.h ee4edca src/kicondialog.cpp 7a6c1f1 Diff: https://git.reviewboard.kde.org/r/122893/diff/ Testing --- Just calling show() on the KIconDialog works as expected, the icon button in kfileproperties thingie dialog still works. Thanks, Kai Uwe Broulik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122864: Added event() version that takes StandardEvent eventId and QString iconName
On March 9, 2015, 11:20 a.m., Martin Klapetek wrote: Ship It! Martin Klapetek wrote: Actually wait, StandardEvents should have standard icons, why would you need to change them? Albert Vaca Cintora wrote: They don't have a standard, default icon: you have to specify it and as of now the only way you have for it is with a QPixmap. Indeed, you are correct. Ship this then, it makes sense to have an alternative for the QPixmap only. Another overload should be added that actually uses the default icons automatically though. Would you be up for that? - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122864/#review77205 --- On March 9, 2015, 6:02 a.m., Albert Vaca Cintora wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122864/ --- (Updated March 9, 2015, 6:02 a.m.) Review request for KDE Frameworks and Aleix Pol Gonzalez. Repository: knotifications Description --- This allows to use icon names instead of QPixmaps when using StandardEvents instead of app-defined events. Diffs - src/knotification.cpp 293de09bae8d16b77df81ee2fe447c3246a476b5 src/knotification.h f2dcd74e26a4feefe53dc0e536b0178d5ce287e1 Diff: https://git.reviewboard.kde.org/r/122864/diff/ Testing --- Thanks, Albert Vaca Cintora ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122887: Load and wrap the QML-only version of kcms if possible
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122887/#review77299 --- +1 looks good to me. src/kcmoduleqml.cpp https://git.reviewboard.kde.org/r/122887/#comment53081 could you add a comment that QWidget::createWindowContainer takes ownership of the window src/kcmoduleqml_p.h https://git.reviewboard.kde.org/r/122887/#comment53080 Q_DECL_OVERRIDE *4 - David Edmundson On March 10, 2015, 11:28 a.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122887/ --- (Updated March 10, 2015, 11:28 a.m.) Review request for KDE Frameworks and Plasma. Repository: kcmutils Description --- This makes KCMLoader try to load the qobject-only, qml based kcms as well, if it succeeds it wraps them in the KCModuleQML KCModule subclass and returns it as loaded module (the class itself is not exported, so no new symbols). This makes systemsettings, kcmshell and any config dialog that loads kcms transparently load those config modules not based upon KCModule Diffs - CMakeLists.txt cb4ae5d src/CMakeLists.txt f7b869f src/kcmoduleloader.cpp 5ccf236 src/kcmoduleqml.cpp PRE-CREATION src/kcmoduleqml_p.h PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122887/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122888: Port the look and feel KCM to the qml only version
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122888/#review77300 --- Ship it! (when other stuff is merged obviously) - David Edmundson On March 10, 2015, 11:32 a.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122888/ --- (Updated March 10, 2015, 11:32 a.m.) Review request for KDE Frameworks and Plasma. Repository: plasma-desktop Description --- this ports the lf kcm to KDeclarative::ConfigModule showing an example on how should be used Diffs - CMakeLists.txt 7c6284c kcms/lookandfeel/CMakeLists.txt 2cde16f kcms/lookandfeel/autotests/CMakeLists.txt 1f01310 kcms/lookandfeel/kcm.h c082cd3 kcms/lookandfeel/kcm.cpp d930b45 kcms/lookandfeel/package/contents/ui/main.qml 9ff3df3 Diff: https://git.reviewboard.kde.org/r/122888/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: [Kde-hardware-devel] solid bugzilla product marked obsolete
Hi all, Following the obsolete action, could someone mark Network Management product as obsolete too? It is related to old Plasma NM 0.9.0.x series, which is now unmaintained. Lamarque V. Souza KDE's Network Management maintainer http://planetkde.org/pt-br On Wed, Mar 11, 2015 at 7:57 PM, Albert Astals Cid aa...@kde.org wrote: El Dimecres, 11 de març de 2015, a les 20:24:00, Jonathan Riddell va escriure: I've labelled the solid bugzilla product as obsolete and added a comment to any bugs that it's for kdelibs4 code which is now in maintenance mode. Replacement products are bluedevil, powerdevil, plasma-nm and frameworks-solid. You forgot to email kde-hardware-de...@kde.org Jonathan ___ Kde-hardware-devel mailing list kde-hardware-de...@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122886: QML-only KCM base
On March 10, 2015, 11:33 a.m., Marco Martin wrote: src/quickaddons/configmodule.cpp, line 167 https://git.reviewboard.kde.org/r/122886/diff/1/?file=354025#file354025line167 I didn't test things that need authentication yet (if some good soul ports a module that uses it would be great) but seems there may be a problem here due to KAuth assuming QWidgets This is for a custom KDE extension to polkit setWIdForAction that tells the KDE polkit agent which window is about to trigger an action so that the window manager can do something sensible wrt to focus. So it's not super criticial. It's also fixable, KAuth only uses it for a window ID, so we can add a QWindow/ Right now it's not a problem, as when used via KCModuleQml, it will call KCModule::setAuthAction which changes the parent widget anyway. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122886/#review77248 --- On March 10, 2015, 11:28 a.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122886/ --- (Updated March 10, 2015, 11:28 a.m.) Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- This is a QObject-based fork of KCmodule, with the api slightly adaped to be more declarative friendly. it loads a qml file that then will be able to access its instance as kcm or as the KCM attached property, like what happens in plasmoids (for how attached proeprties work, unfortunately only properties of the base class will be accessible). They will be loaded in systemsettings by review 122887 Diffs - src/quickaddons/CMakeLists.txt 3c7a34b src/quickaddons/configmodule.h PRE-CREATION src/quickaddons/configmodule.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122886/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122886: QML-only KCM base
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122886/#review77304 --- src/quickaddons/configmodule.h https://git.reviewboard.kde.org/r/122886/#comment53086 this should mention packages somewhere. src/quickaddons/configmodule.h https://git.reviewboard.kde.org/r/122886/#comment53084 This documentation tells me nothing, and I'm not sure what this does from the method name. src/quickaddons/configmodule.h https://git.reviewboard.kde.org/r/122886/#comment53083 I guess you copy and pasted all these. KConfigXT isn't relevant at all here. src/quickaddons/configmodule.cpp https://git.reviewboard.kde.org/r/122886/#comment53085 when combined with your other KCModule patch you have a crash. From KCModule docs: This sets the KAboutData returned by aboutData() The about data is now owned by KCModule. So this will result in a double delete. Same for the delete in setAboutData. - David Edmundson On March 10, 2015, 11:28 a.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122886/ --- (Updated March 10, 2015, 11:28 a.m.) Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- This is a QObject-based fork of KCmodule, with the api slightly adaped to be more declarative friendly. it loads a qml file that then will be able to access its instance as kcm or as the KCM attached property, like what happens in plasmoids (for how attached proeprties work, unfortunately only properties of the base class will be accessible). They will be loaded in systemsettings by review 122887 Diffs - src/quickaddons/CMakeLists.txt 3c7a34b src/quickaddons/configmodule.h PRE-CREATION src/quickaddons/configmodule.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122886/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122864: Added event() version that takes StandardEvent eventId and QString iconName
On mar. 9, 2015, 11:20 a.m., Martin Klapetek wrote: Ship It! Martin Klapetek wrote: Actually wait, StandardEvents should have standard icons, why would you need to change them? Albert Vaca Cintora wrote: They don't have a standard, default icon: you have to specify it and as of now the only way you have for it is with a QPixmap. Martin Klapetek wrote: Indeed, you are correct. Ship this then, it makes sense to have an alternative for the QPixmap only. Another overload should be added that actually uses the default icons automatically though. Would you be up for that? Sure: https://git.reviewboard.kde.org/r/122913/ - Albert --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122864/#review77205 --- On mar. 9, 2015, 6:02 a.m., Albert Vaca Cintora wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122864/ --- (Updated mar. 9, 2015, 6:02 a.m.) Review request for KDE Frameworks and Aleix Pol Gonzalez. Repository: knotifications Description --- This allows to use icon names instead of QPixmaps when using StandardEvents instead of app-defined events. Diffs - src/knotification.cpp 293de09bae8d16b77df81ee2fe447c3246a476b5 src/knotification.h f2dcd74e26a4feefe53dc0e536b0178d5ce287e1 Diff: https://git.reviewboard.kde.org/r/122864/diff/ Testing --- Thanks, Albert Vaca Cintora ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122900: KPluginSelector to provide initialization arguments for the configuration modules
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122900/#review77322 --- Ship it! It even works! :D src/kpluginselector.h https://git.reviewboard.kde.org/r/122900/#comment53110 @since 5.9 src/kpluginselector.h https://git.reviewboard.kde.org/r/122900/#comment53111 @since 5.9 - Albert Vaca Cintora On mar. 11, 2015, 1:53 a.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122900/ --- (Updated mar. 11, 2015, 1:53 a.m.) Review request for kdeconnect and KDE Frameworks. Repository: kcmutils Description --- KCMs make it possible to receive a list of arguments we're not passing yet. This patch makes it possible to specify these arguments by specifying a static list of arguments for all the plugins in the selector. Diffs - src/kpluginselector.h 0125991 src/kpluginselector.cpp 98ab59e src/kpluginselector_p.h d80cd2e Diff: https://git.reviewboard.kde.org/r/122900/diff/ Testing --- Tested over at kdeconnect, where we need this. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 122913: Added an event() version that takes no icon and will use a default one
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122913/ --- Review request for KDE Frameworks and Martin Klapetek. Repository: knotifications Description --- Added an event() version that takes no icon and will use a default one depending on the notification type Diffs - src/knotification.h f2dcd74e26a4feefe53dc0e536b0178d5ce287e1 src/knotification.cpp 293de09bae8d16b77df81ee2fe447c3246a476b5 Diff: https://git.reviewboard.kde.org/r/122913/diff/ Testing --- Thanks, Albert Vaca Cintora ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122913: Added an event() version that takes no icon and will use a default one
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122913/ --- (Updated mar. 12, 2015, 4:37 a.m.) Review request for KDE Frameworks and Martin Klapetek. Changes --- Had to remove a default empty QPixmap parameter from a different event() header, that would make a call to one of them ambiguous. This means that when recompiling an app that used event() with StandardEvent and didn't specify an icon, it will now pick the version that uses standard icons instead of the one that shows no icon at all. (Which seems ok to me). Repository: knotifications Description --- Added an event() version that takes no icon and will use a default one depending on the notification type Diffs (updated) - src/knotification.h f2dcd74e26a4feefe53dc0e536b0178d5ce287e1 src/knotification.cpp 293de09bae8d16b77df81ee2fe447c3246a476b5 Diff: https://git.reviewboard.kde.org/r/122913/diff/ Testing --- Thanks, Albert Vaca Cintora ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
