Re: Places bookmark bug - Help needed

2015-04-25 Thread David Faure
On Thursday 23 April 2015 18:24:26 Marco Martin wrote: On Thursday 23 April 2015, Emmanuel Pescosta wrote: So the possible solutions I see are: * Store the bookmarks in one file (user-places.xbel) and remove the syncing I like the idea of storing places bookmarks only in a cross desktop

Re: kdepackages.h

2015-04-25 Thread David Faure
On Friday 24 April 2015 14:32:12 Jonathan Riddell wrote: kxmlgui has a file kdepackages.h which lists the products in bugzilla. This is used by the dialog in Help → Report Bug. It was horribly out of date so I've synced it with current bugzilla. David could you add to the release scripts

Re: Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

2015-04-25 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123367/#review79510 --- Ship it! Ship It! - Matthew Dawson On April 25, 2015,

Re: Review Request 123500: Bug332692 Better error message if a single file is too large for the trash

2015-04-25 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123500/#review79518 --- Ship it! Ship It! - David Faure On April 25, 2015, 7:35

Re: Review Request 123500: Bug332692 Better error message if a single file is too large for the trash

2015-04-25 Thread Gilbert Assaf
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123500/ --- (Updated April 25, 2015, 9:10 p.m.) Review request for KDE Frameworks.

Re: Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

2015-04-25 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123367/ --- (Updated April 25, 2015, 11:42 p.m.) Status -- This change has been

Re: Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

2015-04-25 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123367/#review79507 --- autotests/kconfig_compiler/test13.h.ref (line 55)

Re: Review Request 123443: Make it possible to call a put job from an IODevice

2015-04-25 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123443/#review79517 --- Ship it! Ship It! - David Faure On April 22, 2015, 4:13

Re: Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

2015-04-25 Thread Aleix Pol Gonzalez
On April 25, 2015, 3:50 a.m., Matthew Dawson wrote: autotests/kconfig_compiler/test13.h.ref, line 55 https://git.reviewboard.kde.org/r/123367/diff/9/?file=363036#file363036line55 Also, I guess brightnessChanged and usrWriteconfig don't need to be generated anymore if a signal

Re: Review Request 123443: Make it possible to call a put job from an IODevice

2015-04-25 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123443/#review79515 --- I love the idea (QIODevice rocks). But I wonder about the

Re: kdepackages.h

2015-04-25 Thread Jonathan Riddell
On Sat, Apr 25, 2015 at 11:02:07PM +0200, David Faure wrote: On Friday 24 April 2015 14:32:12 Jonathan Riddell wrote: kxmlgui has a file kdepackages.h which lists the products in bugzilla. This is used by the dialog in Help → Report Bug. It was horribly out of date so I've synced it with

Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames

2015-04-25 Thread David Faure
On April 6, 2015, 1:12 p.m., Martin Klapetek wrote: autotests/globaltest.cpp, line 96 https://git.reviewboard.kde.org/r/123224/diff/2/?file=359784#file359784line96 This should be (1).txt? Ashish Bansal wrote: imho if my any file starts with ., that's my dot file and I would

Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames

2015-04-25 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123224/#review79509 --- src/core/global.cpp (line 396)

Re: Review Request 123500: Bug332692 Better error message if a single file is too large for the trash

2015-04-25 Thread Gilbert Assaf
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123500/ --- (Updated April 25, 2015, 9:13 p.m.) Status -- This change has been

Re: Review Request 123414: Duplicate RecentDocuments entry if two different files have the same name.

2015-04-25 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123414/#review79511 --- You're quite right about quite a long time. Looking at git

Re: Review Request 121080: Replace KDE_DUMMY_QHASH_FUNCTION.

2015-04-25 Thread David Faure
On Nov. 10, 2014, 9:41 p.m., David Faure wrote: lib/konq/src/konq_historyentry.h, line 57 https://git.reviewboard.kde.org/r/121080/diff/1/?file=327432#file327432line57 const ref, no? Andrius da Costa Ribas wrote: before I try to fix the pending issues: what are we going to

Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames

2015-04-25 Thread Martin Klapetek
On April 6, 2015, 3:12 p.m., Martin Klapetek wrote: autotests/globaltest.cpp, line 96 https://git.reviewboard.kde.org/r/123224/diff/2/?file=359784#file359784line96 This should be (1).txt? Ashish Bansal wrote: imho if my any file starts with ., that's my dot file and I would