----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123367/#review79507 -----------------------------------------------------------
autotests/kconfig_compiler/test13.h.ref (line 55) <https://git.reviewboard.kde.org/r/123367/#comment54320> I mean to only avoid creating the brightnessChanged signal, since it isn't necessary to make this patch work. brightnessModified, being required, is fine. I'm only thinking of this as an optimization, and I'm not that worried about it anyways. Also, I don't mind commiting the removal of that signal after this lands, as long as it happens before the release. As long as that is true, no user code would be broken. Doing it now is preferred :) - Matthew Dawson On April 24, 2015, 9:39 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123367/ > ----------------------------------------------------------- > > (Updated April 24, 2015, 9:39 p.m.) > > > Review request for KDE Frameworks and Matthew Dawson. > > > Repository: kconfig > > > Description > ------- > > The generation of those classes makes it useful to have these being used > within C++ application. This change makes it possible to use these classes > from QML as well. > > For each variable, exposes the getter. In case there's a setter, it will add > a notify signal and the setter to the property. > > > Diffs > ----- > > autotests/kconfig_compiler/CMakeLists.txt 0cca605 > autotests/kconfig_compiler/kconfigcompiler_test.cpp 43623ce > autotests/kconfig_compiler/test13.cpp.ref PRE-CREATION > autotests/kconfig_compiler/test13.h.ref PRE-CREATION > autotests/kconfig_compiler/test13.kcfg PRE-CREATION > autotests/kconfig_compiler/test13.kcfgc PRE-CREATION > autotests/kconfig_compiler/test13main.cpp PRE-CREATION > autotests/kconfig_compiler/test_signal.cpp.ref 58e73ef > autotests/kconfig_compiler/test_signal.h.ref 19b8b40 > src/kconfig_compiler/kconfig_compiler.cpp 5aae340 > > Diff: https://git.reviewboard.kde.org/r/123367/diff/ > > > Testing > ------- > > KConfig tests still pass. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
