Re: Review Request 123836: Ensure KNotification can be used from a non-GUI thread

2015-05-18 Thread Martin Klapetek
On May 18, 2015, 4:15 p.m., Aleix Pol Gonzalez wrote: This fixes my boot. I wasn't able to boot for the whole day because it was showing a QWidget from the wrong thread. On a related note, let's port away from QDesktopWidget, it has these things... Ok, QScreen then? - Martin

Re: Review Request 123836: Ensure KNotification can be used from a non-GUI thread

2015-05-18 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123836/ --- (Updated May 18, 2015, 3:34 p.m.) Status -- This change has been

Re: Review Request 123836: Ensure KNotification can be used from a non-GUI thread

2015-05-18 Thread Aleix Pol Gonzalez
On May 18, 2015, 4:15 p.m., Aleix Pol Gonzalez wrote: This fixes my boot. I wasn't able to boot for the whole day because it was showing a QWidget from the wrong thread. On a related note, let's port away from QDesktopWidget, it has these things... Martin Klapetek wrote:

Re: Review Request 121153: Restore filedialog show() functionality for modal dialogs

2015-05-18 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121153/ --- (Updated May 18, 2015, 3:49 p.m.) Status -- This change has been

Re: Review Request 123836: Ensure KNotification can be used from a non-GUI thread

2015-05-18 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123836/#review80575 --- Ship it! This fixes my boot. I wasn't able to boot for the

Re: Review Request 123836: Ensure KNotification can be used from a non-GUI thread

2015-05-18 Thread Martin Klapetek
On May 18, 2015, 4:15 p.m., Aleix Pol Gonzalez wrote: This fixes my boot. I wasn't able to boot for the whole day because it was showing a QWidget from the wrong thread. On a related note, let's port away from QDesktopWidget, it has these things... Martin Klapetek wrote:

Review Request 123836: Ensure KNotification can be used from a non-GUI thread

2015-05-18 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123836/ --- Review request for KDE Frameworks and Plasma. Repository: knotifications

Re: Review Request 123803: Coding Style for k7zip.cpp kar.cpp karchive.cpp kbzip2filter.cpp kcompressiondevice.cpp kfilterdev.cpp kgzipfilter.cpp klimitediodevice.cpp knonefilter.cpp krcc.cpp ktar.cpp

2015-05-18 Thread Martin Klapetek
On May 15, 2015, 9:49 p.m., David Faure wrote: About your commit log: we won't have a different coding style for karchive, all frameworks should follow https://techbase.kde.org/Policies/Kdelibs_Coding_Style and https://techbase.kde.org/Policies/Library_Code_Policy About the

Re: Review Request 123838: Move from QDesktopWidget to QScreen

2015-05-18 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123838/#review80591 --- src/notifybypopup.cpp (line 292)

Re: Review Request 123838: Move from QDesktopWidget to QScreen

2015-05-18 Thread Martin Klapetek
On May 18, 2015, 7:31 p.m., Martin Gräßlin wrote: src/notifybypopup.cpp, line 298 https://git.reviewboard.kde.org/r/123838/diff/1/?file=369884#file369884line298 I fear that's now most likely no longer the same. I assume that QDesktopWidget::availableGeometry() is the combination

Re: Review Request 123838: Move from QDesktopWidget to QScreen

2015-05-18 Thread Aleix Pol Gonzalez
On May 18, 2015, 7:31 p.m., Martin Gräßlin wrote: src/notifybypopup.cpp, line 298 https://git.reviewboard.kde.org/r/123838/diff/1/?file=369884#file369884line298 I fear that's now most likely no longer the same. I assume that QDesktopWidget::availableGeometry() is the combination

Re: Review Request 123838: Move from QDesktopWidget to QScreen

2015-05-18 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123838/#review80588 --- src/notifybypopup.cpp (line 292)

Review Request 123838: Move from QDesktopWidget to QScreen

2015-05-18 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123838/ --- Review request for KDE Frameworks. Repository: knotifications

Re: Review Request 123735: version of QmlObject with a static engine

2015-05-18 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/ --- (Updated May 18, 2015, 7:09 p.m.) Review request for KDE Frameworks and

Re: Review Request 123735: version of QmlObject with a static engine

2015-05-18 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/ --- (Updated May 18, 2015, 7:02 p.m.) Review request for KDE Frameworks and

Re: Review Request 123735: version of QmlObject with a static engine

2015-05-18 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/#review80600 --- src/quickaddons/quickviewsharedengine.cpp (lines 35 - 39)

Re: Review Request 123735: version of QmlObject with a static engine

2015-05-18 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/ --- (Updated May 18, 2015, 8 p.m.) Review request for KDE Frameworks and

Jenkins-kde-ci: ki18n master kf5-qt5 » OSX,clang - Build # 25 - Failure!

2015-05-18 Thread no-reply
Check console output at https://build.kde.org/job/ki18n%20master%20kf5-qt5/PLATFORM=OSX,compiler=clang/25/ to view the results.___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kde-baseapps frameworks kf5-qt5 » OSX,clang - Build # 14 - Failure!

2015-05-18 Thread no-reply
Check console output at https://build.kde.org/job/kde-baseapps%20frameworks%20kf5-qt5/PLATFORM=OSX,compiler=clang/14/ to view the results.___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Jenkins-kde-ci: knewstuff master kf5-qt5 » OSX,clang - Build # 68 - Failure!

2015-05-18 Thread no-reply
Check console output at https://build.kde.org/job/knewstuff%20master%20kf5-qt5/PLATFORM=OSX,compiler=clang/68/ to view the results.___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Jenkins-kde-ci: ki18n master stable-kf5-qt5 » OSX,clang - Build # 22 - Failure!

2015-05-18 Thread no-reply
Check console output at https://build.kde.org/job/ki18n%20master%20stable-kf5-qt5/PLATFORM=OSX,compiler=clang/22/ to view the results.___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Jenkins-kde-ci: kde-baseapps frameworks kf5-qt5 » OSX,clang - Build # 15 - Still Failing!

2015-05-18 Thread no-reply
Check console output at https://build.kde.org/job/kde-baseapps%20frameworks%20kf5-qt5/PLATFORM=OSX,compiler=clang/15/ to view the results.___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Jenkins-kde-ci: knewstuff master stable-kf5-qt5 » OSX,clang - Build # 46 - Still Failing!

2015-05-18 Thread no-reply
Check console output at https://build.kde.org/job/knewstuff%20master%20stable-kf5-qt5/PLATFORM=OSX,compiler=clang/46/ to view the results.___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org