Re: Review Request 124213: Add standard shortcut for "new tab" action

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124213/ --- (Updated July 4, 2015, 1:04 a.m.) Review request for KDE Frameworks. Ch

Re: Review Request 122893: Populate KIconDialog on showEvent

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122893/ --- (Updated Juli 3, 2015, 9:16 nachm.) Status -- This change has been m

Re: Review Request 124066: Recognize X-KDE-FormFactor as stringlist

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124066/#review82057 --- Why don't we store plugin metadata in JSON files? Look how the

Re: Review Request 124222: kidletime: Introduce plugin infrastructure for platform specific parts

> On July 3, 2015, 1:32 p.m., Aleix Pol Gonzalez wrote: > > Looks good to me. +1 > > > > Maybe now we could get some unit tests... :D hehe :-) Yes with a null/fake plugin that would certainly be possible now. - Martin --- This is an au

Re: Review Request 124222: kidletime: Introduce plugin infrastructure for platform specific parts

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124222/#review82031 --- Looks good to me. +1 Maybe now we could get some unit tests..

Re: Review Request 124239: Fix KMimeType::Ptr::isNull implementation.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124239/ --- (Updated July 3, 2015, 9:19 a.m.) Status -- This change has been mar

Re: Review Request 124239: Fix KMimeType::Ptr::isNull implementation.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124239/ --- (Updated July 3, 2015, 9:19 a.m.) Review request for KDE Frameworks, Davi

Re: Review Request 124239: Fix KMimeType::Ptr::isNull implementation.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124239/#review82028 --- Ship it! Good catch ! Ship it ! Thanks for unittest too - La

Review Request 124239: Fix KMimeType::Ptr::isNull implementation.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124239/ --- Review request for KDE Frameworks, David Faure and Laurent Montel. Reposi

Re: Review Request 124222: kidletime: Introduce plugin infrastructure for platform specific parts

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124222/ --- (Updated July 3, 2015, 10:48 a.m.) Review request for KDE Frameworks. C

Re: Review Request 124222: kidletime: Introduce plugin infrastructure for platform specific parts

> On July 2, 2015, 5:27 p.m., Aleix Pol Gonzalez wrote: > > src/kidletime.cpp, line 213 > > > > > > qCDebug! > > Martin Gräßlin wrote: > There's no qCDebug usage in KIdleTime yet. That's why I kept it on >

Re: KEncodingProber vs "unexisting" codecs

On Friday 03 July 2015 01:18:33 Albert Astals Cid wrote: > Question is, where do we want that? Do we want it on probing time so we > don't try to probe codecs that don't exist (for this installation), or > should we actually mention in the docs that it may happen that the returned > codec does not