Re: Review Request 124371: Fix potential endless recursion in PlatformStatus::findLookAndFeelPackage()

2015-07-16 Thread Daniel Vrátil
On July 16, 2015, 2:49 p.m., Bhushan Shah wrote: +1, though I remember sebas also tried to fix some recursive loop here sometime ago.. tree b2e50f720e779924ffbc9211c935cb433894337a

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 51 - Fixed!

2015-07-16 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/51/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Thu, 16 Jul 2015 13:13:37 + Build duration: 3 min 2 sec CHANGE SET

Re: Review Request 124281: Remove KService and KIconThemes usage from KNotifications

2015-07-16 Thread Martin Klapetek
On July 13, 2015, 8:44 p.m., Sune Vuorela wrote: src/notifybypopup.cpp, line 565 https://git.reviewboard.kde.org/r/124281/diff/4/?file=383900#file383900line565 Isn,t QFont() the same as QApplication::font(), and then the #include QApplication seems unused. It is the same but

Review Request 124372: Fix crash when MigrationAgent::isEmptyOldWallet() check fails

2015-07-16 Thread Daniel Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124372/ --- Review request for KDE Frameworks and Valentin Rusu. Repository: kwallet

Review Request 124371: Fix potential endless recursion in PlatformStatus::findLookAndFeelPackage()

2015-07-16 Thread Daniel Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124371/ --- Review request for KDE Frameworks and Marco Martin. Repository:

Re: Review Request 124371: Fix potential endless recursion in PlatformStatus::findLookAndFeelPackage()

2015-07-16 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124371/#review82566 --- +1, though I remember sebas also tried to fix some recursive

Re: Review Request 124371: Fix potential endless recursion in PlatformStatus::findLookAndFeelPackage()

2015-07-16 Thread Bhushan Shah
On July 16, 2015, 6:19 p.m., Bhushan Shah wrote: +1, though I remember sebas also tried to fix some recursive loop here sometime ago.. tree b2e50f720e779924ffbc9211c935cb433894337a

Re: Review Request 124371: Fix potential endless recursion in PlatformStatus::findLookAndFeelPackage()

2015-07-16 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124371/#review82568 --- Ship it! Ship It! - Bhushan Shah On July 16, 2015, 5:08

Review Request 124376: Fix tr() warning

2015-07-16 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124376/ --- Review request for KDE Frameworks. Repository: kcoreaddons Description

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 46 - Fixed!

2015-07-16 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/46/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Thu, 16 Jul 2015 15:38:13 + Build duration: 2 min 40 sec CHANGE SET Revision

Re: Review Request 124376: Fix tr() warning

2015-07-16 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124376/#review82579 --- Ship it! Ship It! - Albert Astals Cid On jul. 16, 2015,

Re: Review Request 124376: Fix tr() warning

2015-07-16 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124376/ --- (Updated July 16, 2015, 11:31 p.m.) Status -- This change has been