Re: setting default widgetStyle (and ColorScheme)

Martin Graesslin wrote: > That is in deed a better approach. I'm still questioning whether it's the > right thing to do on OSX, but that would then be up to the OSX developers to > decide on. I'll handle that tomorrow. > But if the platformtheme plugin does get moved to Plasma I would say

Re: setting default widgetStyle (and ColorScheme)

Martin Graesslin wrote: > In my opinion: no. I even think the frameworkintegration framework should get > removed from frameworks and moved into Plasma Workspace. Because that's what > it is about: integrating Qt applications into plasma. I don't care where the framework is, but I do think

Re: [Kde-pim] KDE PIM Split?

Le lundi 30 novembre 2015, 22:43:36 CET Ben Cooksley a écrit : > Hi Pim devels, > > I've received a slew of tickets which appears to be laying the ground > work for splitting out all the PIM libraries into separate > repositories. > > Before this happens can we: > > 1) Confirm this is the

Re: Review Request 126199: Don't warn when SVG(Z) icons are provided with multiple sizes/levels of detail

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126199/ --- (Updated Nov. 30, 2015, 5:05 p.m.) Status -- This change has been

Re: Scope of framework integration plugin?

On Monday, 30 November 2015 14:45:41 CET, René J. V. Bertin wrote: Would you really expect Qt to accept a patch that allows generic applications to use font role specifications from KF5? Yes, I think that such a goal is fully in line with Qt's attempt at being reasonably cross-platform.

Re: Scope of framework integration plugin?

On Monday November 30 2015 16:07:50 Jan Kundrát wrote: Hi, >Yes, I think that such a goal is fully in line with Qt's attempt at being >reasonably cross-platform. The keyword here is reasonable - and that's to be interpreted from their point of view. The last time we (including David Faure)

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/ --- (Updated Nov. 30, 2015, 4:51 p.m.) Review request for KDE Software on

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/#review88970 --- File Attachment: using the KDEPlatformTheme - Screen Shot

kpty/utempter

I've had a quick look, and it appears that it shouldn't be overly hard to port libutempter to OS X (which has setutxent, pututxline etc. instead of "x-less" counterparts on Linux). Question is, how useful is this in KPty? R. ___ Kde-frameworks-devel

Re: Review Request 126196: Fix regression caused by RR 125527

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126196/ --- (Updated Nov. 30, 2015, 8:40 p.m.) Status -- This change has been

Review Request 126212: Do not crash if KDE platform integration is loaded but SNI is unavailable

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126212/ --- Review request for KDE Frameworks. Repository: knotifications

Re: Review Request 126212: Do not crash if KDE platform integration is loaded but SNI is unavailable

> On Dec. 1, 2015, 12:53 a.m., Aleix Pol Gonzalez wrote: > > src/kstatusnotifieritem.cpp, line 804 > > > > > > qEnvironmentVariableIsSet I'll use qEnvironmentVariableIsEmpty, that is what Qt uses internally and

Re: Review Request 126212: Do not crash if KDE platform integration is loaded but SNI is unavailable

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126212/ --- (Updated Dec. 1, 2015, 12:34 a.m.) Review request for KDE Frameworks.

Re: Review Request 126212: Do not crash if KDE platform integration is loaded but SNI is unavailable

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126212/ --- (Updated Dec. 1, 2015, 12:37 a.m.) Review request for KDE Frameworks.

Re: Review Request 126212: Do not crash if KDE platform integration is loaded but SNI is unavailable

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126212/#review88980 --- src/kstatusnotifieritem.cpp (line 804)

Re: Review Request 126212: Do not crash if KDE platform integration is loaded but SNI is unavailable

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126212/ --- (Updated Dec. 1, 2015, 1:53 a.m.) Review request for KDE Frameworks.

Re: KDE PIM Split?

Le lundi 30 novembre 2015, 22:43:36 CET Ben Cooksley a écrit : > Hi Pim devels, Hi, So I reorganized source yesterday. I verified that all was ok So how I do now to split ? Regards > I've received a slew of tickets which appears to be laying the ground > work for splitting out all the PIM

Re: Review Request 126161: OS X housekeeping

On Thursday 26 November 2015 10:27:31 René J.V. Bertin wrote: > Yes, the *helper* does that, from within the newly exec'ed process. It's > weird, but apparently the exact "forbidden" thing is "fork - call/load > non-POSIX APIs - exec" while "fork - exec - call/load non-POSIX APIs" works. That

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/#review88960 --- I'm strictly against OSX specific changes in framework

Re: setting default widgetStyle (and ColorScheme)

On Monday, November 30, 2015 11:06:57 AM CET René J. V. Bertin wrote: > Martin Graesslin wrote: > > In my opinion: no. I even think the frameworkintegration framework should > > get removed from frameworks and moved into Plasma Workspace. Because > > that's what it is about: integrating Qt

Re: Scope of framework integration plugin?

On Monday 30 of November 2015 12:48:26 Martin Graesslin wrote: > Hi all, > > there is currently a review request to add OSX specific changes to framework > integration plugin [1]. > > This seems wrong to me. I think our framework integration plugin is about > integration Qt applications into the

Re: setting default widgetStyle (and ColorScheme)

René J. V. Bertin wrote: > Of course one could work on improving the native theme, but wouldn't that be > easiest by writing a dedicated KDE theme? In fact, I ought to check what > happens if one selects the "Macintosh (aqua)" style as KDE's widget style and > then applies the font selection from

Scope of framework integration plugin?

Hi all, there is currently a review request to add OSX specific changes to framework integration plugin [1]. This seems wrong to me. I think our framework integration plugin is about integration Qt applications into the Plasma workspace. In my opinion it should not be used anywhere else. Not

Re: Scope of framework integration plugin?

On Monday, November 30, 2015 12:59:02 PM CET Luigi Toscano wrote: > On Monday 30 of November 2015 12:48:26 Martin Graesslin wrote: > > Hi all, > > > > there is currently a review request to add OSX specific changes to > > framework integration plugin [1]. > > > > This seems wrong to me. I think

Re: setting default widgetStyle (and ColorScheme)

Martin Graesslin wrote: Is this going to turn into another shouting match? > That's not the point! Any user can use whatever theme they want. The question > is whether we should default to our Plasma defaults on non-Plasma. And the > question to that can only be: NO! I'm not suggesting it

Re: Scope of framework integration plugin?

On Mon, Nov 30, 2015 at 12:48 PM, Martin Graesslin wrote: > Hi all, > > there is currently a review request to add OSX specific changes to framework > integration plugin [1]. > > This seems wrong to me. I think our framework integration plugin is about > integration Qt

Re: Scope of framework integration plugin?

On Monday, November 30, 2015 1:02:01 PM CET Aleix Pol wrote: > On Mon, Nov 30, 2015 at 12:48 PM, Martin Graesslin wrote: > > Hi all, > > > > there is currently a review request to add OSX specific changes to > > framework integration plugin [1]. > > > > This seems wrong to

Re: Scope of framework integration plugin?

Adding KDE-mac because we're the first concerned (thanks for omitting us ... again). First off: what about splitting off the KdePlatformPlugin from frameworkintegration? I can see the point that it was conceived to allow pure Qt5 applications to integrate with the look KF5 applications have

Re: Review Request 126185: Make the KAppTemplate CMake module global

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/ --- (Updated Nov. 30, 2015, 1:47 p.m.) Status -- This change has been

Re: Review Request 126185: Make the KAppTemplate CMake module global

> On Nov. 27, 2015, 5:21 p.m., Simon Wächter wrote: > > Thanks for moving the template macro to the ECM module. A few things I am > > not quite sure: > > > > - Is the .kdev_ignore file still in use? I never saw it in a KDevelop > > project > > - If you commit the patch, I'll delete the macro

Re: Scope of framework integration plugin?

On 30 November 2015 at 17:32, Aleix Pol wrote: > On Mon, Nov 30, 2015 at 12:48 PM, Martin Graesslin wrote: >> Opinions? > > Hi, > I agree with you, I've proposed the same thing as you in the past, > although there's some issues that would then need to be

Re: Review Request 126185: Make the KAppTemplate CMake module global

> On Nov. 27, 2015, 5:21 p.m., Simon Wächter wrote: > > Thanks for moving the template macro to the ECM module. A few things I am > > not quite sure: > > > > - Is the .kdev_ignore file still in use? I never saw it in a KDevelop > > project > > - If you commit the patch, I'll delete the macro

Re: Scope of framework integration plugin?

On Mon, Nov 30, 2015 at 2:24 PM, René J. V. wrote: > Boudewijn Rempt wrote: > >> Sort of related question... Is this also the module that picks up the font > > Not sort of related: I think you're spot-on. (These settings are probably moot > on OS X, btw.) > >> hinting

Re: Review Request 126199: Don't warn when SVG(Z) icons are provided with multiple sizes/levels of detail

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126199/#review88966 --- Ship it! Ship It! - Alex Merry On Nov. 29, 2015, 8:59

KDE PIM Split?

Hi Pim devels, I've received a slew of tickets which appears to be laying the ground work for splitting out all the PIM libraries into separate repositories. Before this happens can we: 1) Confirm this is the appropriate way to split it 2) Confirm the code is ready to build independently, and

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

> On Nov. 30, 2015, 12:42 p.m., Martin Gräßlin wrote: > > I'm strictly against OSX specific changes in framework integration. In my > > opinion framework integration should only be about Plasma. I'll start a new > > thread about it. I was afraid you'd be saying that. I can only hope that

Re: Scope of framework integration plugin?

Boudewijn Rempt wrote: > Sort of related question... Is this also the module that picks up the font Not sort of related: I think you're spot-on. (These settings are probably moot on OS X, btw.) > hinting settings and applies it to KDE applications? I setup a gnome-only dev > env to see what

Re: Scope of framework integration plugin?

On Mon, 30 Nov 2015, David Edmundson wrote: On Mon, Nov 30, 2015 at 1:17 PM, Boudewijn Rempt wrote: Sort of related question... Is this also the module that picks up the font hinting settings and applies it to KDE applications? I setup a gnome-only dev env to

Re: setting default widgetStyle (and ColorScheme)

On Monday, November 30, 2015 1:17:20 PM CET René J. V. Bertin wrote: > Martin Graesslin wrote: > > Is this going to turn into another shouting match? sorry what? > > > That's not the point! Any user can use whatever theme they want. The > > question is whether we should default to our Plasma

Re: Scope of framework integration plugin?

Sort of related question... Is this also the module that picks up the font hinting settings and applies it to KDE applications? I setup a gnome-only dev env to see what Krita 3 looks like on that platform, without any kde integration available, and I noticed that Qt 5.6 doesn't seem to pick up

Re: Scope of framework integration plugin?

On Mon, Nov 30, 2015 at 1:17 PM, Boudewijn Rempt wrote: > Sort of related question... Is this also the module that picks up the font > hinting > settings and applies it to KDE applications? I setup a gnome-only dev env > to see > what Krita 3 looks like on that platform,

Re: Review Request 126185: Make the KAppTemplate CMake module global

> On Nov. 27, 2015, 6:21 p.m., Simon Wächter wrote: > > Thanks for moving the template macro to the ECM module. A few things I am > > not quite sure: > > > > - Is the .kdev_ignore file still in use? I never saw it in a KDevelop > > project > > - If you commit the patch, I'll delete the macro

Re: setting default widgetStyle (and ColorScheme)

On Monday, November 30, 2015 3:01:40 PM CET René J. V. Bertin wrote: > Martin Graesslin wrote: > > what you put on review board is in my opinion not a minimal modification. > > That are lots of ifdefs and each ifdef is a huge burden for the > > framework. It means > ... > > > Given that: we need

Re: Scope of framework integration plugin?

Aleix Pol wrote: > Correct, but the fix isn't to make Qt look in the KF5 paths. Qt should > be fixed to fetch the settings wherever gnome puts them, so that the > sizes are the same. > > IOW, we shouldn't expect users to open "kcmshell5 fonts" to set the > font size of KDE applications on