Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

> On Dec. 2, 2015, 10:45 a.m., Boudhayan Gupta wrote: > > src/platformtheme/kdemactheme.mm, line 39 > > > > > > This makes me very nervous. > > > > Using private APIs is almost always a guarantee the

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

> On Dec. 2, 2015, 10:45 a.m., Boudhayan Gupta wrote: > > src/platformtheme/kdemactheme.mm, line 39 > > > > > > This makes me very nervous. > > > > Using private APIs is almost always a guarantee the

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

> On Dec. 2, 2015, 3:15 p.m., Boudhayan Gupta wrote: > > src/platformtheme/kdemactheme.mm, line 39 > > > > > > This makes me very nervous. > > > > Using private APIs is almost always a guarantee the

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

> On Dec. 1, 2015, 9:34 p.m., René J.V. Bertin wrote: > > src/platformtheme/kdemactheme.mm, lines 53-87 > > > > > > I thought it would be best to use a native dialog here to show a > > warning dialog, but it

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

> On Dec. 2, 2015, 8:46 a.m., Martin Gräßlin wrote: > > Overall I think this is now too much code duplication. With this appraoch > > you don't get bug fixes from the base code. I recommed to rather go for > > inheritance to have the actual code which can be shared still together. Yes, I was

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

> On Dec. 2, 2015, 8:38 a.m., Martin Gräßlin wrote: > > Just wondering: if your main aim is to change default settings, why don't > > follow what linux distros do? That is ship some default configuration > > interface. For inspiration check e.g. kubuntu-default-settings. > > René J.V. Bertin

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

> On Dec. 2, 2015, 8:38 a.m., Martin Gräßlin wrote: > > Just wondering: if your main aim is to change default settings, why don't > > follow what linux distros do? That is ship some default configuration > > interface. For inspiration check e.g. kubuntu-default-settings. > > René J.V. Bertin

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

> On Dec. 2, 2015, 8:38 a.m., Martin Gräßlin wrote: > > Just wondering: if your main aim is to change default settings, why don't > > follow what linux distros do? That is ship some default configuration > > interface. For inspiration check e.g. kubuntu-default-settings. If I understand you

Review Request 126222: Fix rating widget flickering when selecting rating with mouse

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126222/ --- Review request for KDE Frameworks and David Faure. Repository:

Re: Review Request 126222: Fix rating widget flickering when selecting rating with mouse

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126222/#review89052 --- That code was added to fix this bug

Re: Updating techbase wiki page according to KF5 policies

On 2015-12-02 08:09, David Faure wrote: On Tuesday 01 December 2015 22:36:52 Alex Merry wrote: On 2015-12-01 15:34, Martin Walch wrote: > On Saturday, November 14, 2015 06:08:55 PM Alex Merry wrote: >> On 2015-11-14 01:21, Martin Walch wrote: >> > Alright, so I have created a stub at >> > >> >

Re: Review Request 124905: Win: Hide console window for binaries in LIBEXEC

> On Aug. 27, 2015, 9:57 p.m., Patrick Spendrin wrote: > > Wait, Wait, Wait. > > 1) The difference between console apps and GUI apps is that console apps > > actually have stdin, stdout and stderr streams. So using or not using a > > console app actually depends on if you need to have these

Re: Review Request 126170: [OS X] make kded5 an agent, and build it as a regular application instead of an app bundle

> On Dec. 2, 2015, 8:51 a.m., David Faure wrote: > > Please kind in mind that kded must be able to pop up dialogs, though. > > (cookie dialog, SSL cert messagebox + dialog, etc. etc.). > > > > If making it an "agent" doesn't prevent it from showing GUI elements now > > and then, then no

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/ --- (Updated Dec. 2, 2015, 10:38 p.m.) Review request for KDE Software on

Re: Purpose as a KDE Framework

On Tue, Dec 1, 2015 at 3:01 PM, Aleix Pol wrote: > Hi, > I've been working on Purpose since some months now, with the intention > of becoming a framework some day. Some information about it can be > read here: > >

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/ --- (Updated Dec. 2, 2015, 10:42 p.m.) Review request for KDE Software on

Re: Review Request 126222: Fix rating widget flickering when selecting rating with mouse

> On Dec. 2, 2015, 4:45 p.m., Lamarque Souza wrote: > > That code was added to fix this bug > > https://bugs.kde.org/show_bug.cgi?id=171343#c6 Emm.. interesting feature. But code inside mouseMoveEvent looks fishy, and this feature shouldn't be used when halfStepsEnabled is true. I'll try to

Re: Review Request 126189: Support https and other URL schemas for "home page" property in KAboutData constructor.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126189/ --- (Updated Dec. 3, 2015, 12:38 a.m.) Status -- This change has been

Re: Review Request 126222: Fix rating widget flickering when selecting rating with mouse

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126222/ --- (Updated Dec. 2, 2015, 11:37 p.m.) Review request for KDE Frameworks and

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

> On Dec. 2, 2015, 3:15 p.m., Boudhayan Gupta wrote: > > src/platformtheme/kdemactheme.mm, line 39 > > > > > > This makes me very nervous. > > > > Using private APIs is almost always a guarantee the

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/#review89026 --- src/platformtheme/kdemactheme.mm (line 39)

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

> On Dic. 2, 2015, 10:45 a.m., Boudhayan Gupta wrote: > > src/platformtheme/kdemactheme.mm, line 39 > > > > > > This makes me very nervous. > > > > Using private APIs is almost always a guarantee the

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

> On Dec. 2, 2015, 10:45 a.m., Boudhayan Gupta wrote: > > src/platformtheme/kdemactheme.mm, line 39 > > > > > > This makes me very nervous. > > > > Using private APIs is almost always a guarantee the

Re: Updating techbase wiki page according to KF5 policies

On Tuesday 01 December 2015 22:36:52 Alex Merry wrote: > On 2015-12-01 15:34, Martin Walch wrote: > > On Saturday, November 14, 2015 06:08:55 PM Alex Merry wrote: > >> On 2015-11-14 01:21, Martin Walch wrote: > >> > Alright, so I have created a stub at > >> > > >> >

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

> On Dec. 2, 2015, 8:38 a.m., Martin Gräßlin wrote: > > Just wondering: if your main aim is to change default settings, why don't > > follow what linux distros do? That is ship some default configuration > > interface. For inspiration check e.g. kubuntu-default-settings. > > René J.V. Bertin

Review Request 126226: kdetemplate_add_app_templates installs previews

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126226/ --- Review request for KDE Frameworks and Marco Martin. Repository: