Re: RFC: split platformtheme plugin from frameworkintegration and move to kde/workspace

2015-12-07 Thread Martin Graesslin
On Monday, December 7, 2015 3:54:31 PM CET Mark Gaiser wrote: > While at it. Why does frameworkintegration force [1] specific fonts upon > the user? > > It's fine that apparently some folks prefer Oxygen fonts over all else, but > i thoroughly dislike it. > I always end up blacklisting it in my

Re: Review Request 126241: [OS X] adapting KStyle (WIP)

2015-12-07 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126241/#review89220 --- I honestly have some doubt on the approach (but no counter

Re: Review Request 123229: Ensure we don't crash when using KIO from non-QApplication process

2015-12-07 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123229/ --- (Updated Dec. 7, 2015, 2:29 p.m.) Review request for KDE Frameworks.

Re: Review Request 126170: [OS X] make kded5 an agent, and build it as a regular application instead of an app bundle

2015-12-07 Thread René J . V . Bertin
On Sunday December 06 2015 14:51:40 David Faure wrote: > Here is an easy way to test this: do the same change for kiod in kio (it's > like a mini kded) and then > cd kio/tests ; ./listjobtest ftp://t...@upload.kde.org > should bring up a password dialog. Regardless of what I try (even with

Re: KNotifications filters

2015-12-07 Thread Jeremy Whiting
Yeah, that makes sense. Ok will do. On Sun, Dec 6, 2015 at 3:37 AM, David Faure wrote: > On Thursday 24 September 2015 20:35:24 Jeremy Whiting wrote: >> If so I guess the logical place for it would be a TTS group in >> kdeglobals, does that make sense? > > Stay away from

Re: RFC: split platformtheme plugin from frameworkintegration and

2015-12-07 Thread Jonathan Riddell
On Mon, Dec 07, 2015 at 03:54:31PM +0100, Mark Gaiser wrote: > While at it. Why does frameworkintegration force [1] specific fonts upon the > user? For the same reason it sets an icon theme, to give Plasma desktops a consistent look and feel. It switches to Noto in 5.5. Jonathan

Re: RFC: split platformtheme plugin from frameworkintegration and move to kde/workspace

2015-12-07 Thread Mark Gaiser
On Mon, Dec 7, 2015 at 1:09 PM, Martin Graesslin wrote: > Hi all, > > based on the discussion in [1] I propose that we split out platformtheme > plugin from frameworkintegration into a dedicated repository and move it to > kde/workspace to be released together with Plasma

Re: Review Request 126212: Do not crash if KDE platform integration is loaded but SNI is unavailable

2015-12-07 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126212/#review89225 --- Ship it! Ship It! - Martin Klapetek On Dec. 1, 2015, 1:53

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

2015-12-07 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/#review89222 --- So with the current implementation that uses inheritance,

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 172 - Unstable!

2015-12-07 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/172/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 07 Dec 2015 13:33:18 + Build duration: 12 min CHANGE SET Revision

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

2015-12-07 Thread René J . V . Bertin
> On Dec. 4, 2015, 8:26 a.m., Martin Gräßlin wrote: > > src/platformtheme/kdeplatformtheme.h, lines 41-54 > > > > > > why did you add the virtual? The methods are marked as Q_DECL_OVERRIDE > > which implies they

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

2015-12-07 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/ --- (Updated Dec. 7, 2015, 5:43 p.m.) Review request for KDE Software on Mac

Re: Review Request 126241: [OS X] adapting KStyle (WIP)

2015-12-07 Thread René J . V . Bertin
> On Dec. 7, 2015, 4:29 p.m., Hugo Pereira Da Costa wrote: > > I honestly have some doubt on the approach (but no counter proposal either) > > Basically the file kstyle.mm is a *copy* of the .cpp file, with a couple of > > lines changed. (which I had to track down by > > - downloading the

Re: Review Request 126212: Do not crash if KDE platform integration is loaded but SNI is unavailable

2015-12-07 Thread Sven Brauch
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126212/ --- (Updated Dec. 7, 2015, 5:45 p.m.) Status -- This change has been

Re: Review Request 125762: External extractor plugin support for KFileMetaData

2015-12-07 Thread Boudhayan Gupta
> On Dec. 6, 2015, 5:32 p.m., Vishesh Handa wrote: > > If you're planning on pushing this please push it to a testing branch. > > Untill we actually have some plugins using this we might not be sure of the > > API. My points below are quite negative and I was hoping on writing a more > >

RFC: split platformtheme plugin from frameworkintegration and move to kde/workspace

2015-12-07 Thread Martin Graesslin
Hi all, based on the discussion in [1] I propose that we split out platformtheme plugin from frameworkintegration into a dedicated repository and move it to kde/workspace to be released together with Plasma 5.6. The main reasoning is that this plugin only gets loaded with env variables set in

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

2015-12-07 Thread Martin Gräßlin
> On Dec. 4, 2015, 8:26 a.m., Martin Gräßlin wrote: > > src/platformtheme/kdeplatformtheme.h, lines 41-54 > > > > > > why did you add the virtual? The methods are marked as Q_DECL_OVERRIDE > > which implies they

Re: Icons missing

2015-12-07 Thread Michael Palimaka
On 06/12/15 23:56, Thorsten Zachmann wrote: > Hello all, > > I use a separate user for running calligra. I use ssh -X to login from my > normal desktop user to my kde running user. However when I start any > kde application I have no icons. With strace I can see it searches for icons > in the

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 181 - Fixed!

2015-12-07 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/181/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Mon, 07 Dec 2015 16:29:29 + Build duration: 6 min 54 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 181 - Fixed!

2015-12-07 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/181/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Mon, 07 Dec 2015 16:29:29 + Build duration: 6 min 54 sec CHANGE SET Revision

Re: RFC: split platformtheme plugin from frameworkintegration and move to kde/workspace

2015-12-07 Thread Aleix Pol
On Mon, Dec 7, 2015 at 1:09 PM, Martin Graesslin wrote: > Hi all, > > based on the discussion in [1] I propose that we split out platformtheme > plugin from frameworkintegration into a dedicated repository and move it to > kde/workspace to be released together with Plasma 5.6.