Re: Review Request 123229: Ensure we don't crash when using KIO from non-QApplication process

> On April 7, 2015, 3:38 p.m., Aleix Pol Gonzalez wrote: > > src/widgets/jobuidelegate.cpp, line 391 > > > > > > This is not correct, it's too early to figure out if it's going to have > > a QApplication or

Re: Review Request 123229: Ensure we don't crash when using KIO from non-QApplication process

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123229/#review89239 --- I don't understand why the move to

Re: Review Request 126185: Make the KAppTemplate CMake module global

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/#review89242 --- kde-modules/KDETemplateMacro.cmake (line 1)

Re: Review Request 126185: Make the KAppTemplate CMake module global

> On Dec. 3, 2015, 11:49 p.m., Aleix Pol Gonzalez wrote: > > kde-modules/KDETemplateMacro.cmake, line 1 > > > > > > You might want to add documentation. > > > > You can get inspired with > >

kdelibs4support forces "icons in buttons"?

Hi, I have the strong impression that applications using the kdelibs4support fw are forced to show icons in buttons, regardless of the corresponding setting (which is respected elsewhere). For some reason it does not happen when I use the native platform plugin on OS X, but if the

Re: RFC: split platformtheme plugin from frameworkintegration and move to kde/workspace

On Tue, Dec 8, 2015 at 7:49 AM, Martin Graesslin wrote: > On Monday, December 7, 2015 3:54:31 PM CET Mark Gaiser wrote: > > While at it. Why does frameworkintegration force [1] specific fonts upon > > the user? > > > > It's fine that apparently some folks prefer Oxygen fonts

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

> On Nov. 3, 2015, 9:47 p.m., Albert Astals Cid wrote: > > How does this work without modifying > > KProtocolInfoPrivate::KProtocolInfoPrivate? > > Christoph Cullmann wrote: > You mean the JSON stuff? That was implemented in > https://git.reviewboard.kde.org/r/125830/ > For the http

Re: Review Request 126038: Add protocol info to KIO plugin metadata

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126038/ --- (Updated Dec. 8, 2015, 6:31 p.m.) Status -- This change has been

Re: Purpose as a KDE Framework

On 2015-12-03 18:29, Aleix Pol wrote: On Wed, Dec 2, 2015 at 11:56 PM, Mark Gaiser wrote: I'm trying to understand what Purpose is doing exactly. I've read the readme file, but i still can't quite figure out what it's doing or where i might be able to use it. Could you

Re: Review Request 125800: OS X build and warning fix

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125800/ --- (Updated Dec. 8, 2015, 8:46 p.m.) Status -- This change has been

Re: Review Request 126285: OS X build and warning fix

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126285/ --- (Updated Dec. 8, 2015, 8:48 p.m.) Review request for KDE Frameworks and

Re: Review Request 126039: When configfile is loaded from resource, do not issue file not found error

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126039/#review89263 --- Ship it! Ship It! - Milian Wolff On Nov. 12, 2015, 11:15

Re: Review Request 126039: When configfile is loaded from resource, do not issue file not found error

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126039/#review89265 --- Ship it! Works for me, sorry I missed this somehow. -

Re: RFC: split platformtheme plugin from frameworkintegration and move to kde/workspace

On Tuesday, December 8, 2015 6:03:47 PM CET Mark Gaiser wrote: > I thought the frameworkintegration plugin was exactly that and usable for > any platform if they wish to use it. > Or is my assumption wrong and is it really only for Plasma and should > others stay away from it? well obviously it's