Re: RFC: split platformtheme plugin from frameworkintegration and move to kde/workspace

Most of our users currently prefer the basic Qt file dialog, but if there's some way to get the KDE one outside of plasma, I'm sure many would rejoice. On 12 December 2015 at 13:31, David Faure wrote: > On Thursday 10 December 2015 10:38:06 Weng Xuetian wrote: >> if you want to

Re: Review Request 126295: Fix wrong button in KUrlNavigator issue caused by 9dbe36f734b5b839b2a6a934fad29d639e954498

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126295/ --- (Updated Dec. 12, 2015, 9:35 a.m.) Review request for KDE Frameworks,

Re: Review Request 125988: [KUrlCompletion] Add autocompletion for '.' input which offers all hidden files/folders

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125988/#review89381 --- Either that, or if you want the fix to be available before

Re: kwidgetsaddons on OS X: menus become menu items

René J.V. Bertin wrote: > The widget is reparented away from the QMenu to the native menu view. If you > show the menu in some other place (e.g. as a popup menu), the widget will not > be there. Actually I think this part *is* related: I noticed that the Bookmarks menu is supposed to appear

Re: kdelibs4support forces "icons in buttons"?

On Tuesday 08 December 2015 14:36:14 René J.V. Bertin wrote: > Hi, > > I have the strong impression that applications using the kdelibs4support fw > are forced to show icons in buttons, regardless of the corresponding setting > (which is respected elsewhere). > For some reason it does not

Re: Review Request 126295: Fix wrong button in KUrlNavigator issue caused by 9dbe36f734b5b839b2a6a934fad29d639e954498

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126295/#review89377 --- src/filewidgets/kurlnavigator.cpp (line 156)

Re: Review Request 126170: [OS X] make kded5 an agent, and build it as a regular application instead of an app bundle

On Monday 07 December 2015 16:14:54 René J.V. Bertin wrote: > On Sunday December 06 2015 14:51:40 David Faure wrote: > > > Here is an easy way to test this: do the same change for kiod in kio (it's > > like a mini kded) and then > > cd kio/tests ; ./listjobtest ftp://t...@upload.kde.org > >

Re: Review Request 125988: [KUrlCompletion] Add autocompletion for '.' input which offers all hidden files/folders

> On Dec. 6, 2015, 12:19 p.m., David Faure wrote: > > OK I debugged this further, and I found why this didn't match my > > expectations of the QUrl behaviour: > > > > QUrl::fromLocalFile("/tmp/.") leads to file:///tmp rather than > > file:///tmp/. I consider this a bug (when

Re: Review Request 126295: Fix wrong button in KUrlNavigator issue caused by 9dbe36f734b5b839b2a6a934fad29d639e954498

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126295/ --- (Updated Dec. 12, 2015, 11:11 a.m.) Review request for KDE Frameworks,

Re: Review Request 126320: Read KPluginMetada's property X-Plasma-ComponentTypes as a stringlist

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126320/#review89394 --- +1, this also fixes plasma on mobile CI - Bhushan Shah On

Re: Review Request 126185: Make the KAppTemplate CMake module global

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/#review89388 --- We're getting there :-). kde-modules/KDEInstallDirs.cmake

Re: Review Request 126185: Make the KAppTemplate CMake module global

> On Dec. 12, 2015, 3:35 p.m., Alex Merry wrote: > > kde-modules/KDETemplateGenerator.cmake, line 52 > > > > > > Honestly, I'd just use ARG as the prefix - you're in a function, it's > > not going to leak

Re: Review Request 126185: Make the KAppTemplate CMake module global

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/#review89391 --- Ooh, also, please write a unit test. I can help with that if

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

> On Dec. 7, 2015, 5:41 p.m., René J.V. Bertin wrote: > > So with the current implementation that uses inheritance, there are 2 > > classes that have a `delayedDBusConnects` method which uses > > `QDBusConnection::sessionBus().connect()` to register things on the DBus. > > Both invoke that

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/ --- (Updated Dec. 12, 2015, 7:08 p.m.) Review request for KDE Software on

Re: Review Request 126295: Fix wrong button in KUrlNavigator issue caused by 9dbe36f734b5b839b2a6a934fad29d639e954498

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126295/#review89398 --- Ship it! We could findChildren in an autotest to find the

Re: Review Request 125988: [KUrlCompletion] Add autocompletion for '.' input which offers all hidden files/folders

> On Dec. 12, 2015, 11:12 a.m., David Faure wrote: > > Either that, or if you want the fix to be available before 5.6 is out, wrap > > your fix with #if QT_VERSION < QT_VERSION_CHECK(5, 6, 0). > > > > We can always clean it up once 5.6 is required (i.e. in a few years ;). > > And mention the

Jenkins-kde-ci: threadweaver master stable-kf5-qt5 » Linux,gcc - Build # 25 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/threadweaver%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/25/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 12 Dec 2015 19:34:43 + Build duration: 3 min 5 sec CHANGE SET Revision

Jenkins-kde-ci: threadweaver master stable-kf5-qt5 » Linux,gcc - Build # 25 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/threadweaver%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/25/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 12 Dec 2015 19:34:43 + Build duration: 3 min 5 sec CHANGE SET Revision

Re: Review Request 126329: kio: Do not use QStringLiteral with multi strings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126329/#review89405 --- please use QLatin1String instead of QString::fromLatin1 for

Re: Review Request 126327: sonnet: Do not use QStringLiteral with multi strings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126327/#review89406 --- Ship it! as that are just tests, i.e. not real code, i

Re: Review Request 126328: kwallet: Do not use QStringLiteral with multi strings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126328/#review89407 --- i suggest using: #ifdef Q_OS_WIN #define U QLatin1String

Re: Review Request 125988: [KUrlCompletion] Add autocompletion for '.' input which offers all hidden files/folders

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125988/#review89400 --- Ah I needed the last hunk from your patch, too. Now it works.

Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126324/ --- Review request for KDE Software on Mac OS X and KDE Frameworks.

Review Request 126326: kdbusaddons: Do not use QStringLiteral with multi strings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126326/ --- Review request for KDE Frameworks. Repository: kdbusaddons Description

kdesrc-build setup for kdepim

The recent splitting of kdepimlibs has caused a clean run of kdesrc-build to fail on lots of pim modules. This seems to be a combination of kde-build-metadata not recording the dependencies properly for a lot of things, and "playground/pim" in the kdepim kdesrc-build include file being far too

Review Request 126329: kio: Do not use QStringLiteral with multi strings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126329/ --- Review request for KDE Frameworks. Repository: kio Description ---

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126324/ --- (Updated Dec. 12, 2015, 10:19 p.m.) Review request for KDE Software on

Review Request 126330: use Qt defines for portability

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126330/ --- Review request for KDE Frameworks. Repository: kdeclarative

Review Request 126328: kwallet: Do not use QStringLiteral with multi strings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126328/ --- Review request for KDE Frameworks. Repository: kwallet Description